Commit Graph

28702 Commits

Author SHA1 Message Date
Sergey Biryukov
1e5ed7fdfd Toolbar: Make network admin accessible via keyboard.
props Cheffheid.
fixes #29422.

git-svn-id: https://develop.svn.wordpress.org/trunk@31111 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-09 09:50:39 +00:00
Sergey Biryukov
1c88f482bf Use localized format for Last Updated date in plugin details modal, for consistency with [31055].
see #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31110 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-09 06:20:08 +00:00
Sergey Biryukov
b641ca55f5 Improve documentation for media_handle_upload().
props ericlewis.
fixes #30962.

git-svn-id: https://develop.svn.wordpress.org/trunk@31109 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-09 05:04:59 +00:00
Sergey Biryukov
c8f0a49dee Correct @return value for WP_Theme::load_textdomain() after [30681].
see #30224.

git-svn-id: https://develop.svn.wordpress.org/trunk@31108 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-09 04:53:29 +00:00
Gary Pendergast
dec1cba410 Add get_avatar_url(), for retrieving just the URL of an avatar, rather than the entire <img> tag that get_avatar() produces.
Unlike `get_avatar()`, `get_avatar_url()` is not pluggable. It can be extended/or modified through the new filters included.

Fixes #21195.

Props mdawaffe, pento, pathawks, DrewAPicture



git-svn-id: https://develop.svn.wordpress.org/trunk@31107 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-09 04:42:48 +00:00
Scott Taylor
0c37f866f2 After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks.
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31106 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 22:51:30 +00:00
Scott Taylor
c4e2ad04a2 Properly declare $hook_suffix, $plugin_page, $typenow, and $taxnow as globals in wp-admin/admin.php.
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31105 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 22:14:58 +00:00
Sergey Biryukov
9d67bfe82d If WP_Rewrite::flush_rules() is called on 'init' or earlier, wait until 'wp_loaded' before actually flushing the rules, to make sure all the rules registered on 'init' are included.
props joostdevalk.
see #30501.

git-svn-id: https://develop.svn.wordpress.org/trunk@31104 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 21:59:57 +00:00
Sergey Biryukov
c96947757a Remove a redundant inline comment with a typo.
props nicnicnicdevos.
fixes #30956.

git-svn-id: https://develop.svn.wordpress.org/trunk@31103 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 21:28:11 +00:00
Sergey Biryukov
6ffb5feab9 Make a hint on Edit Selection view in media modal more accurate, as it applies to all media files, not just images.
props pavelevap.
see #30931.

git-svn-id: https://develop.svn.wordpress.org/trunk@31102 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 21:23:21 +00:00
Scott Taylor
85595b73cc Overriding methods should do more than simply call the same method in the super class.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31101 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 21:19:24 +00:00
Scott Taylor
0522fcb3f9 Jump statements should not be followed by other statements (there were 5 lingering).
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31100 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 21:14:56 +00:00
Scott Taylor
da9057fd6d Use && instead of and in the 3 places where and was used.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31099 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 21:11:46 +00:00
Sergey Biryukov
907be55276 Pass post type to count_user_posts() in get_the_author_posts().
props Caspie, tyxla.
fixes #30904.

git-svn-id: https://develop.svn.wordpress.org/trunk@31098 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 19:52:52 +00:00
Sergey Biryukov
d5b99d560e Use home_url() instead of hardcoded domain in Tests_Link_GetAdjacentPostLink.
props CalEvans.
fixes #30955.

git-svn-id: https://develop.svn.wordpress.org/trunk@31097 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 18:44:18 +00:00
Sergey Biryukov
386d0d5fc7 Remove non-functional date filter from Edit Selection view in media modal.
props tyxla.
fixes #30931.

git-svn-id: https://develop.svn.wordpress.org/trunk@31096 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 18:22:35 +00:00
Helen Hou-Sandi
854ea3e3e6 Collapse additional avatar settings if avatars are disabled.
props markjaquith, krogsgard, valendesigns.
 fixes #30168.


git-svn-id: https://develop.svn.wordpress.org/trunk@31095 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 17:00:15 +00:00
Gary Pendergast
ceccfa10b4 WPDB: When sanity checking a string, check that it's a string, first - PHP notices can occur if an array or object is handled like a string.
See #21212


git-svn-id: https://develop.svn.wordpress.org/trunk@31094 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 08:44:10 +00:00
Gary Pendergast
befcf4f442 WPDB: When wpdb::query() needs to sanity check a query string, make sure to run wpdb:flush() afterwards, to ensure the results from sanity check queries aren't mixed up with the results for the user query.
See #21212.

Fixes #30948.


git-svn-id: https://develop.svn.wordpress.org/trunk@31093 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 08:31:42 +00:00
Scott Taylor
ddbb6c7a0f In wp_xmlrpc_server, remove dead code.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31092 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:20:17 +00:00
Scott Taylor
1ca58614b2 In wp-includes/plugin.php, collapse 3 else-newline-tab-if statements.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31091 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:12:42 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Dion Hulse
d0767caf54 Enable Pretty Permalinks for new sites during install if the server supports it.
See #6481, Props valendesigns, DrewAPicture & ericlewis


git-svn-id: https://develop.svn.wordpress.org/trunk@31089 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 06:46:55 +00:00
Scott Taylor
59e6292c0e In wp-includes/taxonomy.php:
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31087 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 06:25:40 +00:00
Scott Taylor
8108c0babe PHP keywords and constants "true", "false", "null" should be in lower case - there was one lingering capitalized false in _http_build_query().
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31086 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 06:13:05 +00:00
Scott Taylor
14c2161a3b There is no need to use the final modifier inside a final class. Everything in it is final by default.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31085 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 06:09:59 +00:00
Scott Taylor
101e00314d In Customizer classes:
* `public final function` methods should be `final public function` - confusing Hack and aligns with PSR2
* Some methods were missing access modifiers

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31083 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 06:01:08 +00:00
wonderboymusic
1dd301f634 WP_Query->parse_tax_query() - for BC, this method is not marked as protected. See [28987]. It needs an access modifier, it shall have public. The comment remains.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31081 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:53:58 +00:00
Scott Taylor
5d6cc49628 Perl-style comments should not be used
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31079 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:51:39 +00:00
Scott Taylor
97d6901048 Access Modifiers:
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31078 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:43:54 +00:00
Scott Taylor
469164785f Pinking Shears.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31077 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:02:05 +00:00
Sergey Biryukov
621292d70f In dashboard activity widget, display a front-end link if the user cannot edit the post.
props UaMV, DrewAPicture.
fixes #29025.

git-svn-id: https://develop.svn.wordpress.org/trunk@31075 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 00:25:26 +00:00
Sergey Biryukov
ca34257bd6 Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices.
props ocean90.
fixes #30827 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31074 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 23:42:48 +00:00
Sergey Biryukov
dd05a3a40f TinyMCE: Remove dashicon-no-alt.png, unused since [30694].
props kpdesign, MattyRob.
fixes #30791 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31073 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 23:31:16 +00:00
Sergey Biryukov
37499b6169 Theme install: Display an appropriate string if theme has not been rated yet.
props kevdotbadger, valendesigns.
fixes #28147.

git-svn-id: https://develop.svn.wordpress.org/trunk@31072 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 23:16:19 +00:00
Sergey Biryukov
22c9a89602 Add context for 'Previous' and 'Next' strings in get_the_posts_pagination().
fixes #30762 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31071 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 23:06:20 +00:00
Andrew Ozz
3fdc11be29 Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167.
git-svn-id: https://develop.svn.wordpress.org/trunk@31070 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 22:47:32 +00:00
Sergey Biryukov
bac33e9a17 Customizer: Correctly display "Select" option in Navigation section dropdowns.
props kucrut.
fixes #30929.

git-svn-id: https://develop.svn.wordpress.org/trunk@31069 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 19:49:17 +00:00
Sergey Biryukov
c99a082e25 Dashicons: Fix typo in .dashicons-excerpt-view class.
props desrosj.
fixes #30832.

git-svn-id: https://develop.svn.wordpress.org/trunk@31068 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 09:01:58 +00:00
Sergey Biryukov
23bb9030f2 Remove obsolete help sentence on Edit User screen.
fixes #30750.

git-svn-id: https://develop.svn.wordpress.org/trunk@31067 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 08:22:13 +00:00
Sergey Biryukov
4fdc7c7a0b Don't force newlines around URLs in WP_Embed::autoembed().
props chipx86, sgrant.
fixes #23776.

git-svn-id: https://develop.svn.wordpress.org/trunk@31066 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 07:50:58 +00:00
Sergey Biryukov
2fcd588983 Fix typo in a comment in slashing tests.
git-svn-id: https://develop.svn.wordpress.org/trunk@31065 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 07:08:47 +00:00
Gary Pendergast
d3d11c704d Options: When updating options, make sure the user isn't trying to insert characters that aren't supported by the database character set.
See #30361.


git-svn-id: https://develop.svn.wordpress.org/trunk@31064 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 04:14:32 +00:00
Drew Jaynes (DrewAPicture)
af680788bc Add a description for the $data parameter in the DocBlock for the customize_save_response hook introduced in [31062].
Props westonruter.
Fixes #29098.


git-svn-id: https://develop.svn.wordpress.org/trunk@31063 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 01:47:17 +00:00
Dominik Schilling (ocean90)
8bf3003c67 Customizer: Send JSON success for customize_save and allow response to be filtered.
props westonruter.
fixes #29098.

git-svn-id: https://develop.svn.wordpress.org/trunk@31062 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 21:46:54 +00:00
Dominik Schilling (ocean90)
afb8352a70 Autoprefixer for [31038].
see #30886.

git-svn-id: https://develop.svn.wordpress.org/trunk@31061 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 21:43:35 +00:00
Sergey Biryukov
76afa9f9a3 Remove space before comma in wp_notify_postauthor() and wp_notify_moderator().
see #30930.

git-svn-id: https://develop.svn.wordpress.org/trunk@31060 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 17:16:17 +00:00
Sergey Biryukov
ca4df7ec0a Remove padding from the comment notification emails in wp_notify_moderator().
See [30015] for wp_notify_postauthor().

props pavelevap.
fixes #30930.

git-svn-id: https://develop.svn.wordpress.org/trunk@31059 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 17:09:13 +00:00
Sergey Biryukov
3274f5fee6 Skip building the query in wp_count_posts() if cached results are used.
props MikeHansenMe.
fixes #30928.

git-svn-id: https://develop.svn.wordpress.org/trunk@31058 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 16:57:12 +00:00
Sergey Biryukov
4b29e64a4d Fix 'compare' parameter description in WP_Date_Query.
props dlh.
fixes #30925.

git-svn-id: https://develop.svn.wordpress.org/trunk@31057 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 03:35:56 +00:00