Commit Graph

81 Commits

Author SHA1 Message Date
Andrew Nacin
afacb030f5 Remove _wp_delete_nav_menu(). wp_delete_nav_menu() should instead remove the menu from theme locations, which was the only difference between the functions. see #23119.
git-svn-id: https://develop.svn.wordpress.org/trunk@23897 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-04 04:28:12 +00:00
Ryan Boren
c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Sergey Biryukov
c99000e98c Ensure that get_nav_menu_locations() always returns an array. props JustinSainton for initial patch. fixes #23508.
git-svn-id: https://develop.svn.wordpress.org/trunk@23550 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 15:51:16 +00:00
Ryan Boren
a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Jon Cave
452976110d Correctly associate new menu items with a menu when using wp_update_nav_menu_item()
wp_update_nav_menu_item() must pass tax_input to wp_insert_post() when creating items
otherwise the menu-item relationship isn't made.

See #22189.


git-svn-id: https://develop.svn.wordpress.org/trunk@22399 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-06 14:46:56 +00:00
Andrew Nacin
2fa64d3930 Optimize wp_update_nav_menu_item() for high performance. Only query items for a menu when we need them. Update items after updating its meta so the meta cache can be leveraged. see #22189.
git-svn-id: https://develop.svn.wordpress.org/trunk@22235 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-15 14:27:16 +00:00
Andrew Nacin
32687208c3 Prime post term caches for nav menu items. Avoid doing so in frontend template functions as it remains unneeded there. see #22189.
git-svn-id: https://develop.svn.wordpress.org/trunk@22233 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-15 14:17:50 +00:00
Ryan Boren
2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Ryan Boren
676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Jon Cave
0753dd9764 Rescue those who created menu items before r18733. Trim menu item descriptions. See #16799.
git-svn-id: https://develop.svn.wordpress.org/trunk@18734 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-20 22:57:47 +00:00
Jon Cave
df9f6eb62a Make new nav menu items have a blank description and attr_title. See #16799.
git-svn-id: https://develop.svn.wordpress.org/trunk@18733 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-20 21:58:37 +00:00
Andrew Nacin
bb7c1ac6d7 Check for WP_Error return values when using get_term_field() to set up nav menu items. fixes #17958 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@18426 602fd350-edb4-49c9-b593-d223f7449a82
2011-07-11 19:03:04 +00:00
Ryan Boren
7d7509eabd Improvements to invalid menu item handling. Props ocean90. fixes #13958
git-svn-id: https://develop.svn.wordpress.org/trunk@18277 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-11 15:52:15 +00:00
Ryan Boren
feaf2597bf Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@18276 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-11 15:44:06 +00:00
Andrew Nacin
c24e4daf5a Mark menu items tied to invalid taxonomies and post types as invalid. props ocean90, see #13958.
git-svn-id: https://develop.svn.wordpress.org/trunk@18260 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-11 00:55:48 +00:00
Andrew Nacin
5e37bb785a s/showposts/posts_per_page/
git-svn-id: https://develop.svn.wordpress.org/trunk@15788 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-13 05:25:00 +00:00
Andrew Nacin
9494e4ce7e Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: https://develop.svn.wordpress.org/trunk@15590 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-07 11:21:11 +00:00
Andrew Nacin
7c3292bb4a Add unregister_nav_menu(). props jorbin, fixes #14001 for 3.1.
git-svn-id: https://develop.svn.wordpress.org/trunk@15467 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-22 20:50:11 +00:00
Andrew Nacin
3ba32595f1 Add missing filter to wp_get_nav_menu_items(). props filosofo, fixes #13858.
git-svn-id: https://develop.svn.wordpress.org/trunk@15256 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-14 20:50:55 +00:00
Andrew Nacin
09f7a954bf Revert [15219], [15250], some of [15249] for 3.0, revisit in 3.0.1. see #13822.
git-svn-id: https://develop.svn.wordpress.org/trunk@15254 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-14 19:52:30 +00:00
Andrew Nacin
eb1311849e Treat trash/untrash of posts associated with media items the same as other stati changes. props koopersmith, see #13822.
git-svn-id: https://develop.svn.wordpress.org/trunk@15249 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-14 08:33:48 +00:00
Ryan Boren
82be9621ec Trim trailing whitespace.
git-svn-id: https://develop.svn.wordpress.org/trunk@15235 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-11 20:19:35 +00:00
Ron Rennick
9c74b84590 hide unpublished items on frontend nav menus, props filosofo, fixes #13822
git-svn-id: https://develop.svn.wordpress.org/trunk@15219 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-11 15:34:32 +00:00
Andrew Nacin
a53e7e3018 Switch to current_theme_supports(menus) internally. Adding theme support for 'nav-menus' is deprecated in favor of register_nav_menu(s). fixes #13825.
git-svn-id: https://develop.svn.wordpress.org/trunk@15193 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-10 17:57:30 +00:00
Ryan Boren
0922715668 Cut 'em out, move 'em on, trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@15116 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-02 20:04:07 +00:00
Ryan Boren
dea561c819 wp_get_nav_menus filter. Props filosofo. fixes #13702
git-svn-id: https://develop.svn.wordpress.org/trunk@15112 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-02 16:31:42 +00:00
Andrew Nacin
b94b5ece42 Ensure we're only auto-adding root pages to menus. fixes #13447.
git-svn-id: https://develop.svn.wordpress.org/trunk@15111 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-02 15:08:03 +00:00
Ryan Boren
a6e58d85bf Nav menu API cleanups. Props filosofo. fixes #13696
git-svn-id: https://develop.svn.wordpress.org/trunk@15104 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-02 13:43:46 +00:00
Andrew Nacin
5b3b2aaee1 Introduce has_nav_menu(). Returns boolean whether the theme's registered nav menu location has a menu assigned to it. props greenshady for the idea.
git-svn-id: https://develop.svn.wordpress.org/trunk@15091 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-01 16:40:14 +00:00
Andrew Nacin
d45fc420f4 Cleanups.
git-svn-id: https://develop.svn.wordpress.org/trunk@15078 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-31 16:11:20 +00:00
Andrew Nacin
29ccf1ec31 New pending menu item behavior. props filosofo, see #13579.
git-svn-id: https://develop.svn.wordpress.org/trunk@15008 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 22:22:09 +00:00
Andrew Nacin
9b4a85cdaf Move the "Add Home Link" functionality to a checkbox on the View All tab of the Pages metabox. Also makes it work non-JS. props filosofo, fixes #13213.
git-svn-id: https://develop.svn.wordpress.org/trunk@14971 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 02:24:33 +00:00
Ryan Boren
6c79e1395d Make classes property for menus an array. Props filosofo. fixes #13551
git-svn-id: https://develop.svn.wordpress.org/trunk@14944 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 15:41:21 +00:00
Andrew Nacin
20597ef3f8 Ensure auto-added pages are both published and sent to the end of the menu. Tiny enhancement and optimization to wp_update_nav_menu_item come with it. fixes #13447.
git-svn-id: https://develop.svn.wordpress.org/trunk@14937 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 06:59:14 +00:00
Andrew Nacin
e0630f2a93 Don't store nonexistent (deleted) menus in the auto-add option. see #13447.
git-svn-id: https://develop.svn.wordpress.org/trunk@14934 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 05:11:46 +00:00
Ryan Boren
aec821c651 Strip trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@14924 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 02:42:15 +00:00
Andrew Nacin
00fda9f10b Allow pages to be added automattically to menus. see #13447.
git-svn-id: https://develop.svn.wordpress.org/trunk@14878 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-25 13:49:56 +00:00
Andrew Nacin
aceae2cfef Properly format menu item title attributes and descriptions. props ryan, fixes #12864.
git-svn-id: https://develop.svn.wordpress.org/trunk@14826 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-23 22:56:51 +00:00
Andrew Nacin
5b7ecb587d Notice sanity check. fixes #13484, props etiger13.
git-svn-id: https://develop.svn.wordpress.org/trunk@14788 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-21 19:02:36 +00:00
Ryan Boren
b6d8dbf426 Order menu tabs by name. Allow passing args to wp_get_nav_menus() which are passed on to get_terms(). Default orderby for wo_get_nav_menus() to none since most requests won't care about order. fixes #13334
git-svn-id: https://develop.svn.wordpress.org/trunk@14751 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-19 18:52:37 +00:00
Andrew Nacin
e005e28966 Inline docs for menu location functions. props jorbin, see #13378.
git-svn-id: https://develop.svn.wordpress.org/trunk@14721 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-18 05:59:25 +00:00
Andrew Nacin
4db10bf0d7 First pass on 'Theme Locations' for navigation menus. Themes need to specify a location when calling wp_nav_menu and register locations in functions.php. Users then map menus to locations in the nav menu admin. Subject to review. see #13378.
git-svn-id: https://develop.svn.wordpress.org/trunk@14620 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-14 06:20:30 +00:00
Nikolay Bachiyski
599c19481e I18n for custom taxonomies. Fixes #13357
git-svn-id: https://develop.svn.wordpress.org/trunk@14614 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-14 00:34:04 +00:00
Ron Rennick
05b0578c06 add menu slots/theme_menus, props ryan, see #13378
git-svn-id: https://develop.svn.wordpress.org/trunk@14611 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-13 22:14:54 +00:00
Ryan Boren
0a38355cce Check for WP_Error. Props ptahdunbar. fixes #12949
git-svn-id: https://develop.svn.wordpress.org/trunk@14599 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-13 16:34:14 +00:00
Ryan Boren
6648182c8c Don't pass a slug when creating anew menu. This prevents creating a menu whose slug matches a different term in another taxonomy. Props filosofo. fixes #13345
git-svn-id: https://develop.svn.wordpress.org/trunk@14590 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-12 21:23:29 +00:00
Ryan Boren
686cd3b696 Pass menu id instead of name. Allows menus with commas in the name. Props filosofo. fixes #13368
git-svn-id: https://develop.svn.wordpress.org/trunk@14586 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-12 20:47:08 +00:00
Andrew Nacin
92d97fad12 Allow for multiple classes and XFN relationships in menu items.
git-svn-id: https://develop.svn.wordpress.org/trunk@14574 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-11 23:58:26 +00:00
Nikolay Bachiyski
ad3881470e I18n for custom post type labels. Props demetris, dimadin. Fixes #12968
git-svn-id: https://develop.svn.wordpress.org/trunk@14571 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-11 19:52:50 +00:00
Ryan Boren
5d13bccc69 Don't prime menu item cache if a persistent cache is being used. Prime the menu item cache only on the first call to wp_get_nav_menu_items(). Avoids unneeded queries when wp_get_nav_menu_items() is called repeatedly. see #12734
git-svn-id: https://develop.svn.wordpress.org/trunk@14560 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-11 15:55:17 +00:00