Commit Graph

31745 Commits

Author SHA1 Message Date
Scott Taylor
a98ca8b314 Links: in get_adjacent_post(), add a "get_{$adjacent}_post_excluded_terms" filter.
Props rmccue, Japh, MikeHansenMe.
Fixes #9571.


git-svn-id: https://develop.svn.wordpress.org/trunk@34528 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-25 02:37:29 +00:00
Scott Taylor
641150a87a Comments List Table: after [34179], scope the <th>s and <td>s as direct descendants of their parent row.
Fixes #33943.


git-svn-id: https://develop.svn.wordpress.org/trunk@34527 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-25 02:20:11 +00:00
John Blackbourn
53c3cd897a Update the oEmbed endpoint URL for Photobucket.
Fixes #33783


git-svn-id: https://develop.svn.wordpress.org/trunk@34526 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 22:02:16 +00:00
Scott Taylor
2300740fa2 Comments: In comment_form(), move the comment textarea to the top for logged-out users when replying, improves keyboard/focus navigation.
Rehabilitate errant tabbing and extra unnecessary `<?php ?>` toggling.

Props afercia, adamsilverstein.
Fixes #29974.


git-svn-id: https://develop.svn.wordpress.org/trunk@34525 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:59:39 +00:00
Scott Taylor
3e46dd8b92 Comments: In get_comment_statuses(), also return trash.
XML-RPC: In `wp_xmlrpc_server::wp_editComment()`, allow comments to be trashed.

Introduce unit tests for `wp_editComment` in `xmlrpc/*` #NeverForget

Props tyxla, wonderboymusic.
Fixes #30965.


git-svn-id: https://develop.svn.wordpress.org/trunk@34524 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:47:51 +00:00
Scott Taylor
15935e0aed Comments: in comment_form(), add args for cancel_reply_before and cancel_reply_after to eradicate remaining hard-coded HTML bits.
Props MikeHansenMe.
Fixes #23797.



git-svn-id: https://develop.svn.wordpress.org/trunk@34523 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:32:03 +00:00
Scott Taylor
9b55d4fecb Comments: in check_comment_flood_db(), don't throttle moderators. If the commenter is logged in, check against their user_id instead of comment_author_IP.
Throwback: "If you can edit comments on the post, 'Slow down Cowboy' shouldn't kick in."

Props garyc40, wonderboymusic.
Fixes #16219.


git-svn-id: https://develop.svn.wordpress.org/trunk@34522 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:21:16 +00:00
Dominik Schilling (ocean90)
d1fbe56dfc Plugins: Don't use _n() for singular/plural strings which have no placeholder for a number.
Fixes #33239.
See #28502.

git-svn-id: https://develop.svn.wordpress.org/trunk@34521 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:06:50 +00:00
Scott Taylor
55bb8b8c0b Comments: add a 'comment_excerpt_length' filter to get_comment_excerpt().
Create the first ever unit tests for `get_comment_excerpt()`.

Props dannydehaan, wonderboymusic.
Fixes #27526.


git-svn-id: https://develop.svn.wordpress.org/trunk@34520 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:04:16 +00:00
John Blackbourn
c5a336d664 Use WP_TESTS_DOMAIN where it should be used in tests in place of hard-coded uses of example.org.
Also corrects a test value in the data provider for `Tests_Sanitize_Option::test_sanitize_option()` which was only consequentially passing.

Fixes #34000


git-svn-id: https://develop.svn.wordpress.org/trunk@34519 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:01:10 +00:00
John Blackbourn
b415937e4a Another missed file from [34172].
See #33877


git-svn-id: https://develop.svn.wordpress.org/trunk@34518 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 20:32:49 +00:00
Scott Taylor
5b5b714694 Comments List Table JS: move the dynamic count functions into closure scope so that setCommentsList AND commentReply can access them. Update counts when replying inline.
Fixes #33403.


git-svn-id: https://develop.svn.wordpress.org/trunk@34517 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 20:15:54 +00:00
John Blackbourn
1e42aeb3c4 Add a @since entry for the implementation of the $public argument in register_taxonomy().
See #21949


git-svn-id: https://develop.svn.wordpress.org/trunk@34516 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 20:15:29 +00:00
Scott Taylor
e1d433a233 Edit Post: in the logic determining whether to display the Comments meta box, check for the current post status in get_post_stati( array( 'public' => true ) ) instead of just checking publish and private. Ensure that private is checked in both instances.
Props Thaicloud, wonderboymusic.
Fixes #24486.


git-svn-id: https://develop.svn.wordpress.org/trunk@34515 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 20:01:55 +00:00
Scott Taylor
395fc15df3 Widgets: use input[type="number"] for the number prop in the Recent Posts and Recent Comments widget forms.
Props helen, obenland, mordauk.
Fixes #22965.


git-svn-id: https://develop.svn.wordpress.org/trunk@34514 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:52:06 +00:00
John Blackbourn
075245d894 Convert the $args passed to register_post_type() into an array before passing them to the new register_post_type_args filter.
Fixes #17447


git-svn-id: https://develop.svn.wordpress.org/trunk@34513 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:38:11 +00:00
Drew Jaynes
2703af7691 Docs: Clarify the summary and optional $query parameter description for remove_query_arg().
Props johnbillion.
Fixes #33912.


git-svn-id: https://develop.svn.wordpress.org/trunk@34512 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:33:07 +00:00
Drew Jaynes
c406171d12 Docs: Overhaul the DocBlock for add_query_arg() to attempt to better explain the various call signatures it accepts.
Also adds a couple of in-DocBlock examples illustrating single key and value, and associative array usage. Retains the note about the unescaped return value.

Props johnbillion.
See #33912.


git-svn-id: https://develop.svn.wordpress.org/trunk@34511 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:31:40 +00:00
Drew Jaynes
a099621012 Docs: Convert the $args parameter description in the register_taxonomy() DocBlock to a hash notation.
Also standardizes the DocBlock summary.

Props johnbillion.
Fixes #33991.


git-svn-id: https://develop.svn.wordpress.org/trunk@34510 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:11:53 +00:00
Drew Jaynes
45b8138b97 Docs: Improve the summary and description for the pre_http_request filter docs to better illustrate expected values.
The filter explicitly expects one of three passed value types:

*  An array containing 'headers', 'body', 'response', 'cookies', and 'filename' elements
*  A `WP_Error` instance
*  Boolean false (to avoid short-circuiting the response)

Props johnbillion.
Fixes #33995.


git-svn-id: https://develop.svn.wordpress.org/trunk@34509 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 18:51:13 +00:00
Andrea Fercia
5852971d3c Comments List Table: fix the translators comment for all count after [34506].
See #17275.

git-svn-id: https://develop.svn.wordpress.org/trunk@34508 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 18:39:04 +00:00
John Blackbourn
133993389e Add $depth as a parameter in the nav_menu_item_args filter.
Fixes #29417


git-svn-id: https://develop.svn.wordpress.org/trunk@34507 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 17:58:20 +00:00
Scott Taylor
d7a59c4661 Comments List Table: include count for "All". Dynamically update.
Fixes #17275.


git-svn-id: https://develop.svn.wordpress.org/trunk@34506 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 17:56:50 +00:00
John Blackbourn
3d97e9a53b Correctly present an error to the user if the nickname field is empty when updating a user profile. It's strange that this field is required, but it is, so be it.
Fixes #33310
Props prasad-nevase, metodiew


git-svn-id: https://develop.svn.wordpress.org/trunk@34505 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 17:48:10 +00:00
Scott Taylor
821821c8b5 Comments: add date column to WP_Comments_List_Table to allow sorting and to break out the date/time from the comment content column.
Props jshreve.
Fixes #15520.


git-svn-id: https://develop.svn.wordpress.org/trunk@34504 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 17:26:54 +00:00
Scott Taylor
ba2842f326 Comments: In comments_template(), set $wp_query->comments_by_type to empty array if not separating comments. The value becomes stale otherwise. Edge case.
Props jakub.tyrcha.
Fixes #14809.


git-svn-id: https://develop.svn.wordpress.org/trunk@34503 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 16:30:12 +00:00
Drew Jaynes
057ba76b2c Docs: Add more explicit optional parameter types and return descriptions in the DocBlocks for is_page(), is_single(), is_singular().
Also adds explicit types and return descriptions to the corresponding `WP_Query` methods: `WP_Query::is_page()`, `WP_Query::is_single()`, and `WP_Query::is_singular()`.

Props Shelob9 for the initial patch.
Fixes #33907.


git-svn-id: https://develop.svn.wordpress.org/trunk@34502 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 16:17:23 +00:00
Dominik Schilling (ocean90)
9d4d1a7572 Twenty Fifteen: Add a missing comma in rtl.css.
Props Toro_Unit.
Fixes #33985.

git-svn-id: https://develop.svn.wordpress.org/trunk@34501 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 16:02:19 +00:00
Scott Taylor
c0ebd3b5e2 Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget.
Fixes #10422.


git-svn-id: https://develop.svn.wordpress.org/trunk@34500 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 15:52:41 +00:00
Drew Jaynes
b408cd37fb Docs: Standardize and clarify class DocBlocks for all of the Upgrade API classes.
Standardizes summaries and tags for the following classes:

* `WP_Upgrader`
* `Plugin_Upgrader`
* `Theme_Upgrader`
* `Language_Pack_Upgrader`
* `Core_Upgrader`
* `File_Upload_Upgrader`
* `WP_Automatic_Updater`

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34499 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:53:46 +00:00
DrewAPicture
cccd9356fe Docs: Clarify the file header for wp-admin/includes/class-wp-upgrader.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34498 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:43:02 +00:00
Drew Jaynes
ad64ee866b Docs: Mark the optional $upgrader parameter as such and add a description in the DocBlock for Language_Pack_Upgrader::async_upgrade().
See [32655].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34497 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:34:15 +00:00
Scott Taylor
04bb8a07d7 Canonical/Rewrite: After [34492], fix rel="canonical" URLs for paginated posts.
Props wonderboymusic, joostdevalk.
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34496 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:30:00 +00:00
Drew Jaynes
02e1102a5b Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_ftpsockets::get_contents().
Also reverses the return types as `string` is expected, `false` is the outlier.

See [30978].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34495 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:21:50 +00:00
Scott Taylor
30554cccab After [34492], no need to import the global instance when we are, in fact, currently, that instance.
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34494 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:19:03 +00:00
Drew Jaynes
6ac2cb05e6 Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_FTPext::get_contents().
Also reverses the return types as `string` is expected, `false` is the outlier.

See [30978].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34493 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:10:47 +00:00
Scott Taylor
0111ecef55 Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content.
Awesome rewrite bug: the `page` query var was being set to `'/4'` in `$wp`. When cast to `int`, it returns `0` (Bless you, PHP). `WP_Query` calls `trim( $page, '/' )` when setting its own query var. The few places that were checking `page`	before posts were queried now have sanity checks, so that these changes work without flushing rewrites.	

Adds/updates unit tests.

Props wonderboymusic, dd32.
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34492 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:03:05 +00:00
Drew Jaynes
c9093207df Docs: Add a summary, version, and @access tag to the property DocBlock for Custom_Image_Header->updated.
See [14907] for where the property was initially introduced.
See [30187] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34491 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 13:38:03 +00:00
Drew Jaynes
00eab11256 Docs: Add a summary, version, and @access tag to the property DocBlock for Custom_Background->updated.
See [13765] for where the property was initially introduced.
See [30186] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34490 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 13:33:18 +00:00
Drew Jaynes
72a968ca03 Docs: Add a summary, version, and @access tag to the property DocBlock for WP_Locale->number_format.
See [5308] for where the property was initially introduced.
See [31083] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34489 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 13:25:55 +00:00
Dominik Schilling (ocean90)
1efbe10b47 Customizer: Update tests for [34487].
Fixes #33634.

git-svn-id: https://develop.svn.wordpress.org/trunk@34488 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 11:31:30 +00:00
Dominik Schilling (ocean90)
15ee0a44b2 Customizer: Use the plural label for available menu item types.
Fixes #33634.

git-svn-id: https://develop.svn.wordpress.org/trunk@34487 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 09:15:15 +00:00
Dominik Schilling (ocean90)
273bd1ed99 Edit Post: Add missing periods.
See #31858.

git-svn-id: https://develop.svn.wordpress.org/trunk@34486 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 08:53:21 +00:00
Drew Jaynes
8e61ab359c Docs: Link up a hook reference with an inline @see tag in the return description for get_locale().
Missed in [34484].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34485 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:50:49 +00:00
Drew Jaynes
b91804e0bf Docs: Fix the summary for get_locale().
Also update the description to properly link up hook references with inline `@see` tags.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34484 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:49:07 +00:00
Drew Jaynes
f85670cd36 Docs: Clarify the file header summary for wp-includes/l10n.php and add the version it was introduced.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34483 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:46:35 +00:00
Drew Jaynes
1810710798 Docs: Split the DocBlock summary for __() into a summary and description.
Also, notate the default value for the optional `$domain` parameter.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34482 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:42:35 +00:00
Drew Jaynes
4d94ef47de Docs: Add a summary to the hook doc for the nav_menu_item_args filter, introduced in [34471].
Fixes #29417.


git-svn-id: https://develop.svn.wordpress.org/trunk@34481 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:08:36 +00:00
Scott Taylor
3a8f42bfe0 Post Thumbnails: In get_the_post_thumbnail_url(), return false instead of empty string when no URL is available.
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34480 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 04:37:48 +00:00
Scott Taylor
e366584fae Unit Tests: after [34477], make Tests_Link_GetPostCommentsFeedLink more respectable.
See #33693.


git-svn-id: https://develop.svn.wordpress.org/trunk@34479 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 04:31:58 +00:00