Commit Graph

3044 Commits

Author SHA1 Message Date
Sergey Biryukov
ef8ed3e279 Avoid a PHP notice in WP_Press_This::get_suggested_content() after [32828].
props kraftbj.
fixes #32751.

git-svn-id: https://develop.svn.wordpress.org/trunk@32901 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 15:19:53 +00:00
Andrew Ozz
e366658072 Update the TinyMCE initialization:
- Replace `wp_htmledit_pre()` and `wp_richedit_pre()` with `format_for_editor()`.
- Replace the `'htmledit_pre'` and `'richedit_pre'` filters with `'format_for_editor'`.
- Do not run the post content through `wpautop()` in PHP when the visual editor is default. Run the textarea content through the JS wpautop on initializing TinyMCE.
- Simplify both editors initialization.
- Improve setting of `wpActiveEditor` in Quicktags.
- Improve editor.js, use `tinymce.$` when possible.
See #32425.

git-svn-id: https://develop.svn.wordpress.org/trunk@32899 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-21 22:00:42 +00:00
Dominik Schilling (ocean90)
724b22938e Customizer: Accessibility improvements for menu item searches.
* Add a description and an `aria-describedby` attribute to inform users this is a "live" search.
* Announce the number of search results via `wp.a11y.speak`.
* Use `aria-busy` attribute to stop screen readers announcing content while the "loading more results" is running.
* Increase the search debounce wait interval to 500ms to be consistent with other live searches.
* If a search fails don't call `wp.a11y.speak` with an undefined variable.

props afercia.
see #32720.

git-svn-id: https://develop.svn.wordpress.org/trunk@32891 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 19:21:38 +00:00
Dominik Schilling (ocean90)
842347841e Customizer: Don't add a menu item twice when using the keyboard.
Buttons don't need keyboard events, they natively support keyboard interaction and they just need a click event.

fixes #32665.

git-svn-id: https://develop.svn.wordpress.org/trunk@32890 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 19:00:05 +00:00
Scott Taylor
a968694338 Use valid markup in Walker_Nav_Menu_Edit::start_el() - replace <d(l|t)> with <div> for .menu-item-bar and .menu-item-handle.
Props sagarjadhav.
Fixes #31817.


git-svn-id: https://develop.svn.wordpress.org/trunk@32879 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:22:00 +00:00
Scott Taylor
6ffc540366 Add access modifier to WP_Upgrader::clear_destination()
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32871 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:52:44 +00:00
Scott Taylor
53a3137e1a Edit Post screen messages need to run preview URLs through the preview_post_link filter.
Props pareshradadiya.
Fixes #32191.


git-svn-id: https://develop.svn.wordpress.org/trunk@32870 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:48:11 +00:00
Scott Taylor
c5f72c4ab7 Use <button> instead of <a> for non-link links in Quick Edit.
Props afercia.
Fixes #32213.


git-svn-id: https://develop.svn.wordpress.org/trunk@32869 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:41:07 +00:00
Scott Taylor
bb292c74c1 Cleanup (ms-)?admin-filters.php
Props johnjamesjacoby.
Fixes #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32865 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:17:20 +00:00
Scott Taylor
da826f59a5 Media Library Bulk Select button size should be smaller.
Props afercia.
Fixes #32325.


git-svn-id: https://develop.svn.wordpress.org/trunk@32862 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:55:52 +00:00
Dominik Schilling (ocean90)
bd272f3188 Customizer: Improve accessibility of the toggle button in the available menu items panel.
Prevents focus lost in Safari because the button was "invisible" until it got focused.

fixes #32709.

git-svn-id: https://develop.svn.wordpress.org/trunk@32859 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 17:23:46 +00:00
Konstantin Obenland
82a26045e5 Check that current changes can be lost before editing another comment.
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.

Props pareshradadiya, chriscct7.
Fixes #21845.



git-svn-id: https://develop.svn.wordpress.org/trunk@32857 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 13:47:35 +00:00
Ella Iseulde Van Dorpe
fa5ec5077b Editor: restructure word count
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.

See #30966. Fixes #26620.



git-svn-id: https://develop.svn.wordpress.org/trunk@32856 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 10:34:59 +00:00
Dion Hulse
9c0750ac52 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921


git-svn-id: https://develop.svn.wordpress.org/trunk@32854 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:48:55 +00:00
Dion Hulse
4ff7f27c83 Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@32852 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:17:12 +00:00
Dominik Schilling (ocean90)
413d24c47f Customizer: Improve accessibility of Add Menu Items button and its panel.
props afercia, ocean90.
fixes #32682.

git-svn-id: https://develop.svn.wordpress.org/trunk@32848 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 20:51:48 +00:00
Dominik Schilling (ocean90)
ee24335ba5 Autoprefixer for [32844].
git-svn-id: https://develop.svn.wordpress.org/trunk@32847 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 20:48:52 +00:00
Scott Taylor
646c19accf Make sure that all Gravatars are generated by get_avatar() or at least run through apply_filters( 'get_avatar', $avatar ) for the sake of extensibility.
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650.


git-svn-id: https://develop.svn.wordpress.org/trunk@32845 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 18:35:04 +00:00
Konstantin Obenland
9bf79ed862 Semanticize Help and Screen Options toggle.
Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.



git-svn-id: https://develop.svn.wordpress.org/trunk@32844 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 16:35:12 +00:00
Konstantin Obenland
2ae17175b2 Use https for Google API external libraries.
Google recommends it and users are more likely to have the https version cached in their browser already.

Props rommelxcastro.
Fixes #32552.



git-svn-id: https://develop.svn.wordpress.org/trunk@32843 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:50:42 +00:00
Konstantin Obenland
771509a452 Show the posts meta box by default in Appearance > Menus.
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.

Props bcole808.
Fixes #32440.



git-svn-id: https://develop.svn.wordpress.org/trunk@32842 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:03:29 +00:00
Konstantin Obenland
b758c6cec4 More consistent spacing around the excerpt textarea.
Props paulwilde.
Fixes #32242.



git-svn-id: https://develop.svn.wordpress.org/trunk@32841 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 14:18:53 +00:00
Konstantin Obenland
f88225549e Revert [32834].
It's not ready yet and was a product of misusing vim.

See #30729.



git-svn-id: https://develop.svn.wordpress.org/trunk@32835 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 12:26:40 +00:00
Konstantin Obenland
1fc76c997f Emphasise previewing new themes
git-svn-id: https://develop.svn.wordpress.org/trunk@32834 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 12:23:30 +00:00
Konstantin Obenland
77d2e23a69 Make posts in the 'Most recent' tab of post type meta boxes filterable.
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.

Props jpyper, chriscct7.
Fixes #19365.



git-svn-id: https://develop.svn.wordpress.org/trunk@32833 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:34:33 +00:00
Konstantin Obenland
cfbff5b495 Recommend a user updates keys/salts in maint/repair.php.
Since they are already going into `wp-config.php`, we should also encourage
them to update their unique phrases for keys and salts, assuming they do not
have a complete set of 8 unique ones already.

Props nacin, chriscct7.
Fixes #20779.



git-svn-id: https://develop.svn.wordpress.org/trunk@32830 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 11:06:09 +00:00
Andrew Ozz
80a511015b Press This: Check the embeds list against all of the oembed providers.
Props stephdau. Fixes #32069.

git-svn-id: https://develop.svn.wordpress.org/trunk@32828 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 00:11:30 +00:00
Andrew Ozz
675de40f11 Press This: show error message when the user is attempting to add a category that already exists.
Fixes #32339.

git-svn-id: https://develop.svn.wordpress.org/trunk@32827 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 23:12:08 +00:00
Dominik Schilling (ocean90)
9031531071 Customizer: Remove an overflow: hidden declaration to prevent cutting off the left and right edge focus style of the "Add a Menu" input field.
props paulwilde.
fixes #32680.

git-svn-id: https://develop.svn.wordpress.org/trunk@32825 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 21:42:45 +00:00
Dominik Schilling (ocean90)
59230dd5ab Customizer: Fix keyboard events for the menu items search field.
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.

props tywayne.
fixes #32677.

git-svn-id: https://develop.svn.wordpress.org/trunk@32824 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 21:36:11 +00:00
Dominik Schilling (ocean90)
71cdd9a3e1 Customizer: Revert the blue on hover color which was introduced in [32649].
Blue is meant to be the primary action which isn't the case in this context. Colors need to be revised in #29158. 

see #31336.

git-svn-id: https://develop.svn.wordpress.org/trunk@32823 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 21:07:01 +00:00
Dominik Schilling (ocean90)
2481eec41d Customizer: Replace usage of calc() with box-sizing: border-box.
IE8 doesn't support `calc()`.

props afercia.
see #31336.
fixes #32664.

git-svn-id: https://develop.svn.wordpress.org/trunk@32821 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 19:34:44 +00:00
Boone Gorges
322b6cc54f Bail out of 4.3 term splitting routine when no shared terms are found.
Props dd32.
See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@32819 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 11:39:19 +00:00
Ella Iseulde Van Dorpe
2b857dfdc3 JSHint after [32806]
See #32576.


git-svn-id: https://develop.svn.wordpress.org/trunk@32815 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 04:14:06 +00:00
Boone Gorges
f9ae6b826a Split all shared taxonomy terms on upgrade to 4.3.
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@32814 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 01:52:46 +00:00
Dominik Schilling (ocean90)
b31928788d Fix a typo in [32806].
see #32576.

git-svn-id: https://develop.svn.wordpress.org/trunk@32808 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 23:08:09 +00:00
Dominik Schilling (ocean90)
c0a66eba79 Add menu management to the Customizer.
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/.

props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576.

git-svn-id: https://develop.svn.wordpress.org/trunk@32806 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 22:07:08 +00:00
Helen Hou-Sandi
0433b87fdf Media list table: Avoid PHP notices by using the proper variables.
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32805 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 21:32:53 +00:00
Scott Taylor
862c761c08 Avoid using HTML in translation strings in edit-form-comment.php.
Fixes #31847.


git-svn-id: https://develop.svn.wordpress.org/trunk@32801 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:07:14 +00:00
Scott Taylor
296c559baf if is a statment, not a function.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:00:15 +00:00
Scott Taylor
9cf3adb204 Avoid using <code> in a translation string.
Props ramiy.
Fixes #31848.


git-svn-id: https://develop.svn.wordpress.org/trunk@32799 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:52:39 +00:00
Helen Hou-Sandi
d878ce73f5 Media list table: Restore row actions.
see #29881, #32657.


git-svn-id: https://develop.svn.wordpress.org/trunk@32798 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:46:27 +00:00
Helen Hou-Sandi
b9b36d1c57 Comments: Better markup for the edit screen.
Previously there were no labels, and since labels can't contain links and the links were of dubious value, we've removed those.

props afercia, DrewAPicture.
fixes #31326.


git-svn-id: https://develop.svn.wordpress.org/trunk@32796 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 18:53:16 +00:00
Boone Gorges
91512a9161 Tag/category conversion link on edit-tags.php should point to specific importer page when cat2tag plugin is active.
Props solarissmoke, c3mdigital.
Fixes #16369.

git-svn-id: https://develop.svn.wordpress.org/trunk@32792 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 04:29:04 +00:00
Dion Hulse
9f2ad2538e Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
Props mordauk. Fixes #31784


git-svn-id: https://develop.svn.wordpress.org/trunk@32784 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 06:25:58 +00:00
Dion Hulse
8455dd10da Updats: Add a filter for the options params for the update being performed.
Props nofearinc. Fixes #27754


git-svn-id: https://develop.svn.wordpress.org/trunk@32783 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:34:52 +00:00
Dion Hulse
5b607d7ff6 Updates: Allow the update row to include the active border styling post-ajax update.
Props TobiasBg. Fixes #32129


git-svn-id: https://develop.svn.wordpress.org/trunk@32782 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:12:41 +00:00
Dion Hulse
4f8b348c9b Updates: Remove redundant title tags from update outputs.
Props afercia. Fixes #32530


git-svn-id: https://develop.svn.wordpress.org/trunk@32781 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:08:48 +00:00
Dion Hulse
672f394b57 Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin.
Props magicroundabout. Fixes #32110 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@32780 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 04:27:37 +00:00
Dion Hulse
a5ed63c86f Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
Fixes #32435, #32473


git-svn-id: https://develop.svn.wordpress.org/trunk@32779 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:47:54 +00:00
Dion Hulse
5a33c20515 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32778 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:31:40 +00:00
Dion Hulse
7805a509f3 Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32777 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:19:30 +00:00
Dion Hulse
d72005f6d0 Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32776 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 02:47:19 +00:00
Helen Hou-Sandi
97e6967d63 Multisite: Use an email input for new user email address.
We also need to set novalidate on the form due to some browsers rejecting valid email addresses containing an IDN. We should holistically investigate whether this is still an issue in any major browsers at some point.

props earnjam.
fixes #32643.


git-svn-id: https://develop.svn.wordpress.org/trunk@32774 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 20:40:35 +00:00
Helen Hou-Sandi
32845bd9c6 Reduce form spacing on narrower screens.
props liljimmi.
fixes #32489, #32484.


git-svn-id: https://develop.svn.wordpress.org/trunk@32772 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 20:11:40 +00:00
Andrew Nacin
8b5b201fa1 Tweak the first post/page content to get with the times.
props chriscct7.
fixes #22474.


git-svn-id: https://develop.svn.wordpress.org/trunk@32768 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 18:55:52 +00:00
Jeremy Felt
2cdea6f446 Remove a now unused switch_to_blog() and restore_current_blog() in site-info.php
Now that we decide when to automatically update `home` and `siteurl`, we no longer need to switch to the site while displaying the form output.

See #32503.


git-svn-id: https://develop.svn.wordpress.org/trunk@32761 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 08:22:34 +00:00
Jeremy Felt
4b0eaacd84 Remove the "Update siteurl and home as well" checkbox when editing a site
Rather than provide a checkbox to update the `siteurl` and `home` options, we can make an educated decision based on the current state. If the home and/or siteurl domain and path match the existing domain and path of the site, then we update with the new information.

Also, while scheme is not stored in `wp_blogs` along with a site, the scheme of the `home` and `siteurl` options can now be modified via the Site URL setting in `site-info.php` when the `home` and/or `siteurl` options match the existing domain.

Props @hugobaeta, @earnjam, @jeremyfelt.
Fixes #32503, see #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@32760 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 07:51:30 +00:00
Jeremy Felt
250aaa16e8 Capture domain and path when editing sites on a subdomain network
When a network is configured as subdomain, allow for the input of arbitrary domain and path combinations when editing a site rather than just the domain.

This takes a step or two toward #32503.

Props @scribu, @ericlewis, @jeremyfelt.
See #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@32759 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 07:08:30 +00:00
Jeremy Felt
a0ef4e9ed6 Improve code readability in site-info.php
In advance of some other work here, clean up some braces and spaces.

See #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@32758 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 05:00:27 +00:00
Scott Taylor
857197f14d In WP_MS_Users_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32757 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 17:10:49 +00:00
Scott Taylor
dea07077fa In WP_MS_Themes_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32756 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 16:53:06 +00:00
Scott Taylor
ae8bd2bcd3 In WP_MS_Sites_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32755 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 16:23:01 +00:00
Scott Taylor
31d50764c3 In WP_Media_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32754 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:56:13 +00:00
Scott Taylor
c32f856cf3 In WP_Links_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32753 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:32:57 +00:00
Scott Taylor
6c6638c163 In WP_Posts_List_Table, move the <th> markup out of ->column_cb().
See #29881, [32740].


git-svn-id: https://develop.svn.wordpress.org/trunk@32752 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:13:47 +00:00
Scott Taylor
0eb50f80b9 In wp_ajax_hidden_columns(), don't explode() on an empty string.
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.


git-svn-id: https://develop.svn.wordpress.org/trunk@32751 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:59:40 +00:00
Scott Taylor
9629b5413d In WP_Posts_List_Table::column_title(), use is_post_type_hierarchical() instead of $this->hierarchical_display in the logic to determine whether the_excerpt() should be called.
Fixes #32187.


git-svn-id: https://develop.svn.wordpress.org/trunk@32749 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:41:15 +00:00
Dominik Schilling (ocean90)
8502ee5f86 Nav menu: Allow the sortable items selector in wpNavMenu to be overridden.
props adamsilverstein.
fixes #32633.

git-svn-id: https://develop.svn.wordpress.org/trunk@32745 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:02:41 +00:00
Weston Ruter
4092c5a37e Fix regressions from [32649] wrt Customizer expanded and active state changes for sections.
The `args.completeCallback` was not always called when `onChangeExpanded()` was called. And when a section became inactive (`active` state goes to `false`) and it was currently `expanded`, the Customizer panel would then becomes blank as the section was hidden; it needed to `collapse()` the section first before hiding the element.

See #31336.



git-svn-id: https://develop.svn.wordpress.org/trunk@32743 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 22:27:51 +00:00
Scott Taylor
52cfab850f After [32740], in WP_Posts_List_Table::single_row() - $lock_holder is checked but unused, so the call to get_userdata() is unnecessary.
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32742 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 20:47:46 +00:00
Scott Taylor
7fbeffec20 After [32740], correct doc block typo.
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32741 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 20:28:22 +00:00
Scott Taylor
1de436b466 Override ->single_row_columns() in WP_Posts_List_Table.
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.

This list table class is now easier to subclass.

Props joehoyle, wonderboymusic.
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32740 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 20:17:59 +00:00
Scott Taylor
87f0a73bdc In WP_Terms_List_Table::display_rows_or_placeholder():
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32739 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:54:56 +00:00
Scott Taylor
8463ad6f29 In WP_Posts_List_Table::single_row():
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32738 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:49:18 +00:00
Scott Taylor
cae366cad0 In WP_Media_List_Table::display_rows(), get_the_terms() can return WP_Error, so its return value should be checked before traversing.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32737 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:44:50 +00:00
Scott Taylor
ca123a2054 In WP_Comments_List_Table::column_comment(), $post and $the_comment_status are unused, as is the $comment_status global.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32736 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:38:26 +00:00
Scott Taylor
9bb0d08c14 Fix some malformed doc blocks in Custom_Image_Header.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32735 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:34:49 +00:00
Scott Taylor
6b48cb1205 Fix some malformed doc blocks in Custom_Background.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32734 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:24:10 +00:00
Scott Taylor
3f29a2101d Don't loosely compare functions that return bool against a literal bool.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32730 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 17:18:38 +00:00
Dion Hulse
671218ac1d SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions.
See #32345


git-svn-id: https://develop.svn.wordpress.org/trunk@32726 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 06:30:58 +00:00
Konstantin Obenland
995753d1d0 Improve non-visual feedback for list table items without terms.
Props karpstrucking, afercia.
Fixes #32150.



git-svn-id: https://develop.svn.wordpress.org/trunk@32725 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-11 09:27:13 +00:00
Helen Hou-Sandi
c2ed5b170d List tables: Use a class instead of inline styles for hidden columns.
fixes #32608.


git-svn-id: https://develop.svn.wordpress.org/trunk@32724 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 19:46:39 +00:00
Helen Hou-Sandi
c296d882a8 List tables:
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32723 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 19:30:22 +00:00
Helen Hou-Sandi
1a0773a4b4 List tables: Better primary column back-compat.
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.

props kovshenin.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32722 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 14:58:42 +00:00
Helen Hou-Sandi
615ab22fea List tables: Consolidate <td> output for posts.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32721 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 14:00:55 +00:00
Konstantin Obenland
e66948cf50 More semantic markup for the post formats metabox.
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.



git-svn-id: https://develop.svn.wordpress.org/trunk@32720 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 09:08:10 +00:00
Jeremy Felt
fc2ba19214 Additional improvement to sites list table display
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.

See #32434.


git-svn-id: https://develop.svn.wordpress.org/trunk@32719 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 07:27:09 +00:00
Jeremy Felt
9170edb2b2 Improve information displayed in a network's sites list table
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.


git-svn-id: https://develop.svn.wordpress.org/trunk@32718 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 06:49:38 +00:00
Helen Hou-Sandi
74a6899d0d List tables:
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.

props georgestephanis, stephdau.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32717 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 01:45:11 +00:00
Konstantin Obenland
c7a40c6847 When inline editing a post, reset password field to be editable by default.
The Quick Edit form is cloned and then populated with post-specific data. If the 
previous post was private, the password field would continue to be disabled for
the next post.

Props afercia.
Fixes #32259.



git-svn-id: https://develop.svn.wordpress.org/trunk@32716 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-09 22:01:06 +00:00
Aaron Jorbin
b095afe2db Remove Truthy check from DO_NOT_UPGRADE_GLOBAL_TABLES
Some, but not all, of the checks for DO_NOT_UPGRADE_GLOBAL_TABLES just check if it is defined, so checking for truthiness could cause the issue to not be fully fixed.

In the words of Colonel Jessep: You can't handle the truth!

Introduced in [32714]

Fixes #32011



git-svn-id: https://develop.svn.wordpress.org/trunk@32715 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-09 21:59:51 +00:00
Aaron Jorbin
09340de73e Add error if a user attempts to install WordPress with DO_NOT_UPGRADE_GLOBAL_TABLES defined
The install process runs through migrations to global tables, therefore we cannot install WordPress with this constant defined. This error message prevents a false success screen from being seen.

Fixes #32011.
Props Oxymoron.



git-svn-id: https://develop.svn.wordpress.org/trunk@32714 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-09 17:58:18 +00:00
Konstantin Obenland
99d0d85fb0 Sort screen options for meta boxes according to the meta box's priority.
Props swissspidy.
Fixes #32582.



git-svn-id: https://develop.svn.wordpress.org/trunk@32707 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-08 12:34:03 +00:00
Ella Iseulde Van Dorpe
9eafba9d15 Autoprefixer after autoprefixer-core 5.2 update
grunt-autoprefixer requires ^5.1.7, so this was automatically updated.

See #31700.


git-svn-id: https://develop.svn.wordpress.org/trunk@32704 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-07 20:07:06 +00:00
Helen Hou-Sandi
028c61f1d4 Nav menus: Hidden inputs do not need an ID, especially one that's already in use.
props sagarjadhav.
fixes #31816.


git-svn-id: https://develop.svn.wordpress.org/trunk@32695 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-05 15:35:17 +00:00
Konstantin Obenland
990008aa50 Remove title attributes in user list tables.
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.

Props afercia.
Fixes #32535.



git-svn-id: https://develop.svn.wordpress.org/trunk@32694 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-05 08:39:26 +00:00
Konstantin Obenland
9dfbd00947 Text improvements for screen readers in list table paginations.
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.



git-svn-id: https://develop.svn.wordpress.org/trunk@32693 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-05 05:00:23 +00:00
Helen Hou-Sandi
6c51513a44 Nav menus: hide the title attribute field by default for new users and installs.
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.

props paulwilde.
fixes #32218.


git-svn-id: https://develop.svn.wordpress.org/trunk@32691 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-04 04:37:02 +00:00
Helen Hou-Sandi
112fc6d369 Nav menus: Provide visual feedback when attempting to add an empty custom link.
props pragunbhutani for the initial patch.
fixes #18517.


git-svn-id: https://develop.svn.wordpress.org/trunk@32690 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-04 04:30:04 +00:00
John Blackbourn
e069a38598 Switch to pointer tolerance for improved drag and drop behaviour when reordering widgets.
Props jkudish, MikeHansenMe.
Fixes #20791


git-svn-id: https://develop.svn.wordpress.org/trunk@32689 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 22:58:52 +00:00
Helen Hou-Sandi
2da4d61f95 Media list view: ensure thumbnails are appropriately sized and constrained.
see #29993.


git-svn-id: https://develop.svn.wordpress.org/trunk@32688 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:22:14 +00:00
Helen Hou-Sandi
6c60055740 Media: move the thumbnail into the title column in list view.
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@32687 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:12:19 +00:00
Helen Hou-Sandi
fa29d5bb80 List tables: tighten up primary column handling for plugins and multisite themes.
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32686 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:07:22 +00:00
Konstantin Obenland
d91e9c98de Use WordPress' default focus styles for links on login screens.
Props afercia.
Fixes #31712.



git-svn-id: https://develop.svn.wordpress.org/trunk@32682 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-02 05:50:33 +00:00
Dominik Schilling (ocean90)
5ae2271098 Customizer: Improve JS templates for Panels and Sections added in [32658].
* Always fall back to using the default template if no custom template exists.
* Provide a set of default params when constructing new `Section` and `Panel` objects.

Includes QUnit tests.

Props celloexpressions, westonruter, ocean90.
Fixes #30737.

git-svn-id: https://develop.svn.wordpress.org/trunk@32681 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 22:46:56 +00:00
Andrew Ozz
40df2f48bf Editor: run autosave when pressing Ctrl or Command + S in the Text editor, same as the Visual editor.
Fixes #31655.

git-svn-id: https://develop.svn.wordpress.org/trunk@32680 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 19:01:53 +00:00
Andrew Ozz
156df52851 Editor:
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.

git-svn-id: https://develop.svn.wordpress.org/trunk@32677 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 17:37:14 +00:00
Sergey Biryukov
9940e8c16f Revert a part of [32673] that caused a fatal error with SCRIPT_DEBUG disabled.
see #19257.

git-svn-id: https://develop.svn.wordpress.org/trunk@32676 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-01 04:13:17 +00:00
John Blackbourn
87d5aefe74 Introduce featured_image, set_featured_image, remove_featured_image, and use_featured_image post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
Props johnbillion, mordauk, valendesigns.
Fixes #19257.


git-svn-id: https://develop.svn.wordpress.org/trunk@32673 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 16:53:12 +00:00
Scott Taylor
986990163f Add doc blocks to functions that are missing them.
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32672 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 03:17:50 +00:00
Drew Jaynes
492a2ed9a2 Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653].
See #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32671 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:59:45 +00:00
Drew Jaynes
563efdc1bb Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_Users_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32670 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:44:53 +00:00
Drew Jaynes
5e765a3f2f Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Terms_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32669 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:43:33 +00:00
Drew Jaynes
cb1ea6f5c8 Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Posts_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32668 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:41:28 +00:00
Drew Jaynes
cb0fbfa276 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Plugins_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32667 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:39:22 +00:00
Drew Jaynes
b310f8ddc0 Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Users_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32666 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:37:36 +00:00
Drew Jaynes
e24bc6a185 Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_MS_Themes_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32665 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:35:34 +00:00
Drew Jaynes
78e56cd89b Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Sites_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32664 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:33:40 +00:00
Drew Jaynes
0041aea872 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Media_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32663 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:31:11 +00:00
Drew Jaynes
e3077edcad Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for WP_List_Table.
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.

See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32662 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:28:28 +00:00
Drew Jaynes
3725befcd8 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Links_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32661 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:22:28 +00:00
Drew Jaynes
5b06d42c51 Add missing return descriptions and fix formatting of inline documentation introduced in [32644].
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32660 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:17:25 +00:00
Weston Ruter
cc19680774 Add JS templates for Customizer Panels and Sections.
This extends the approach taken for Customizer Controls in #29572.

Props celloexpressions, westonruter, ocean90.
See #30737.


git-svn-id: https://develop.svn.wordpress.org/trunk@32658 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-30 00:02:13 +00:00
Scott Taylor
c49c139a22 Add @access annotations to methods that have no doc block in wp-admin/includes/*.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32656 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 21:31:56 +00:00
Scott Taylor
60e5c90e62 Add (more) missing doc blocks to wp-admin/includes/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32655 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 21:16:59 +00:00
Scott Taylor
ec5758225c Add missing doc blocks to wp-admin/includes/*.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32654 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 20:16:22 +00:00
Scott Taylor
d55800a4f2 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32653 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 17:03:13 +00:00
Scott Taylor
d5e9f8770a Add missing annotations to ajax-actions.php`
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32652 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 16:00:29 +00:00
Helen Hou-Sandi
923bffda98 Define a primary column for WP_Post_Comments_List_Table.
props boonebgorges.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32651 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:51:11 +00:00
Scott Taylor
c8a44d437a Add @static* annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:42:40 +00:00
Dominik Schilling (ocean90)
cced199188 Customizer: Replace accordion behavior of sections with a slide-in navigation.
This allows users to focus on the contents of the active section more easily and separating the navigation from the content/controls in the Customizer.

props valendesigns, celloexpressions.
see #31336.

git-svn-id: https://develop.svn.wordpress.org/trunk@32649 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 13:56:39 +00:00
Helen Hou-Sandi
ea9de1aacd After [32644], sanity for a pile of selectors.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32645 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:59:44 +00:00
Helen Hou-Sandi
86c907d2a5 List tables: introduce the concept of a "primary" column.
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32644 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:40:52 +00:00
Scott Taylor
f864c1d712 Add @global annotations to (the rest of the?) wp-admin/* files.
Does not include list table file changes.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32643 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:05:26 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Helen Hou-Sandi
805d876017 About: Give bottom navigation links the full width.
This will prevent longer strings from wrapping needlessly, and is more semantically correct markup.

props tyxla.
fixes #32391.


git-svn-id: https://develop.svn.wordpress.org/trunk@32636 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 15:38:44 +00:00
Jeremy Felt
b1e80f0388 Use site objects rather than get_blog_status() in MS list tables.
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.

Fixes #32512.


git-svn-id: https://develop.svn.wordpress.org/trunk@32630 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-27 23:13:04 +00:00
Mark Jaquith
556ffa235a Insert temporary password field hook for feature development in a plugin.
git-svn-id: https://develop.svn.wordpress.org/trunk@32625 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-27 19:58:38 +00:00
Scott Taylor
bd06ad2725 get_comments() can return int, so a few places need to check if the return value is traversable before passing what is assumed to be an array.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32600 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-25 17:58:52 +00:00
Dion Hulse
d8dc5d9f63 Updates: Correctly identify more failed update cases. This checks for a WP_Error being raised during an individual update, in addition to just the bootstrap error cases.
The error message in these cases is still not displayed in the UI.

See #32473, #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32571 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-24 08:44:09 +00:00
Dion Hulse
8d64dc4e6b Shiny Updates: Handle the case where the plugin is installed into a different directory than it previously existed in.
A good example of this is when the plugin being updated is currently installed as 'Plugin-Name' but the canonical directory is 'plugin-name', but it can also occur when the plugin is installed in 'super-cool-plugin' and it's canonical name is 'average-plugin'.

Fixes #32465 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@32570 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-24 08:04:55 +00:00
Konstantin Obenland
065cdadce9 Improve description for link notification option.
Makes it clear that the option only applies to new articles.

Props chriscct7.
Fixes #22961.



git-svn-id: https://develop.svn.wordpress.org/trunk@32569 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-24 07:54:06 +00:00
Scott Taylor
46752a491e When calling unset(), it is unnecessary to immediately precede it with a call to isset().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32545 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 05:46:47 +00:00
Helen Hou-Sandi
6d1e0f0704 Updates: Use the warning color for the backup notice, as it's not a success message.
props paulwilde.
fixes #32241.


git-svn-id: https://develop.svn.wordpress.org/trunk@32522 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:09:46 +00:00
jorbin
8bb46554a8 In List Tables, ensure sorting indicator is visible on focus
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose. 

Happy #GAAD

Props afercia
Fixes #32189



git-svn-id: https://develop.svn.wordpress.org/trunk@32521 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:04:03 +00:00
Scott Taylor
e088947cea In WP_Media_List_Table::get_views(), declare $num_posts explicitly before looping.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32517 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:49:59 +00:00
Scott Taylor
17fff532cd In WP_Comments_List_Table::column_comment(), all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32516 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:45:36 +00:00
Jeremy Felt
6f4e407208 Move network update submenu items to the Network Dashboard menu item
Provides parity with the placement of the "Updates" submenu item in single site.

props Ipstenu.
fixes #32431.


git-svn-id: https://develop.svn.wordpress.org/trunk@32514 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 16:59:40 +00:00
Helen Hou-Sandi
d800ebdf96 Accessibility: Ensure screen reader text is read as words and not affected by word-wrap.
props afercia.
fixes #31962.


git-svn-id: https://develop.svn.wordpress.org/trunk@32509 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-18 18:36:46 +00:00
Helen Hou-Sandi
42eb2ec407 Autoprefixer for [32506]. see #31874.
git-svn-id: https://develop.svn.wordpress.org/trunk@32508 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 20:43:02 +00:00
Helen Hou-Sandi
691656f2cf Media: Visually align upload errors with other admin notices.
props sagarjadhav.
fixes #31874.


git-svn-id: https://develop.svn.wordpress.org/trunk@32506 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 16:18:50 +00:00
Andrew Ozz
12b3b1c100 Fix dragging to the bottom of the screen on the Dashboard.
Props eltobiano. See #32094.

git-svn-id: https://develop.svn.wordpress.org/trunk@32505 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-14 23:49:44 +00:00
Dion Hulse
047c2fdadd Allow plugins to activate other plugins within their Activation hook. Fixes #32368
git-svn-id: https://develop.svn.wordpress.org/trunk@32504 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-14 06:57:47 +00:00
Andrew Ozz
59eb437a35 Fix comments postbox:
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349.

git-svn-id: https://develop.svn.wordpress.org/trunk@32495 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 01:21:58 +00:00
Dominik Schilling (ocean90)
297a4eae48 Improve focus styles for the Switch View links in Posts listings and Media Library.
props afercia.
fixes #32294.

git-svn-id: https://develop.svn.wordpress.org/trunk@32485 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-11 19:33:32 +00:00
Andrew Ozz
5bf60d981b Widgets:
- Fix dragging to the bottom of the screen.
- Fix hiding of the dragged widget when dragging over a closed sidebar.
- Fix the admin menu position and scrolling when all widget containers are folded.
Fixes #32094 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32480 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-10 00:31:47 +00:00
Dominik Schilling (ocean90)
bcbae1cee3 Improve focus styles for:
* Quick Draft links
* Media Library list mode thumbnails 

props afercia.
fixes #32284, #32291.

git-svn-id: https://develop.svn.wordpress.org/trunk@32476 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 21:04:21 +00:00
Dominik Schilling (ocean90)
0422e527b1 Improve focus styles for:
* Welcome Panel dismiss link
* Welcome Panel assembled links
* At a Glance links
* Recently Published/Publishing Soon and latest Comments links in the Dashboard Activity box 

props afercia.
fixes #32287, #32288, #32289, #32292.

git-svn-id: https://develop.svn.wordpress.org/trunk@32475 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 20:34:13 +00:00
Dominik Schilling (ocean90)
27d0216b0c Merge a help tab string for pages.
fixes #32328.

git-svn-id: https://develop.svn.wordpress.org/trunk@32474 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 20:07:00 +00:00
Dominik Schilling (ocean90)
ca2cd7405c List Table: Add placeholder to a plural string.
props SergeyBiryukov.
fixes #32034.

git-svn-id: https://develop.svn.wordpress.org/trunk@32473 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 19:21:38 +00:00
Dominik Schilling (ocean90)
3df6a4a9da Sites List Table: Replace context with a translators comment for the site name and tagline.
props ramiy.
fixes #31849.

git-svn-id: https://develop.svn.wordpress.org/trunk@32472 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 19:18:00 +00:00
Dominik Schilling (ocean90)
ff4f261101 Merge similar error strings.
props pavelevap.
fixes #32327.

git-svn-id: https://develop.svn.wordpress.org/trunk@32471 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 18:26:37 +00:00
Gary Pendergast
733e06315a Upgrades: If a table has already been converted to utf8mb4, there's no need to try and convert it again.
Props gabrielperezs for the initial patch.

See #32310.



git-svn-id: https://develop.svn.wordpress.org/trunk@32456 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 12:21:18 +00:00
Gary Pendergast
2cde17f232 When saving Writing Options, check that the UI is enabled for use_smilies and use_balanceTags before trying to update them.
Fixes #5161.
Fixes #32298.



git-svn-id: https://develop.svn.wordpress.org/trunk@32455 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 11:58:22 +00:00
Gary Pendergast
231c73751b On the Writing Options screen, hide the Balance Tags and Convert Smilies options on new installs.
Fixes #5161.
Fixes #32298.



git-svn-id: https://develop.svn.wordpress.org/trunk@32454 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 06:51:52 +00:00
Michael Adams (mdawaffe)
80238b81d6 Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes.
Props jorbin, et alii.

See #32165.


git-svn-id: https://develop.svn.wordpress.org/trunk@32440 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 01:10:05 +00:00
Michael Adams (mdawaffe)
89b384a05a Upgrade: $wpdb->get_col_length() sanity check: bail on unexpected return value.
See #32165.


git-svn-id: https://develop.svn.wordpress.org/trunk@32429 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 23:10:18 +00:00
Michael Adams (mdawaffe)
a42401d0c9 Upgrade: Ensure unintelligible DB schemas don't result in content loss.
See #32165.


git-svn-id: https://develop.svn.wordpress.org/trunk@32417 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 21:45:58 +00:00
Aaron Jorbin
1417929e0d When upgrading WordPress remove genericons example.html files
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin

--This line,build.wordpress-develop.dea and those below, will be ignored--

M    src/wp-admin/includes/update-core.php


git-svn-id: https://develop.svn.wordpress.org/trunk@32385 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 18:36:48 +00:00
Sergey Biryukov
5af9ac0ea2 Customizer: Use a semantic, accessible element for Remove Header Image button.
Make the button more noticeable on dark, light, and busy images.

props afercia, RDall, melchoyce.
fixes #32227, #31325.

git-svn-id: https://develop.svn.wordpress.org/trunk@32382 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 10:53:07 +00:00
Sergey Biryukov
2b8e7270d5 Multisite: Add translator comments to default email messages with non-typical placeholders.
props yoavf.
fixes #32263.

git-svn-id: https://develop.svn.wordpress.org/trunk@32381 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 09:11:18 +00:00
Gary Pendergast
9e12deeb9c Fix an incorrect version number check in [32378].
See #32099.



git-svn-id: https://develop.svn.wordpress.org/trunk@32379 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:40:36 +00:00
Gary Pendergast
ca11cafb07 Upgrades: When converting to utf8mb4, we were trying to change the wrong index on wp_signups, causing the conversion to later fail.
Props kovshenin, pento.

See #32099.



git-svn-id: https://develop.svn.wordpress.org/trunk@32378 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:33:53 +00:00
Gary Pendergast
2ce97b2984 WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding(), as it behaves differently to MySQL's character encoding conversion.
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.

See #32165.



git-svn-id: https://develop.svn.wordpress.org/trunk@32364 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 02:59:50 +00:00
Drew Jaynes
3ca1ff6b72 Fix documentation syntax and formatting for the media_sideload_image() DocBlock.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32352 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:19:47 +00:00
Drew Jaynes
7138b7e1bd Add two changelog entries for functional changes introduced in 4.2.0.
Props dimadin.
See #31925.


git-svn-id: https://develop.svn.wordpress.org/trunk@32350 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:15:27 +00:00
Drew Jaynes
eea4111667 Add a missing DocBlock for wp_caption_input_textarea().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32341 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:12:12 +00:00
Drew Jaynes
b7bce33748 Add a missing @return tag to the DocBlock for `uninstall_plugin().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32340 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:07:47 +00:00
Drew Jaynes
5a45289302 Add a missing @return tag to the DocBlock for site_admin_notice().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32339 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:05:48 +00:00
Drew Jaynes
511ce10e53 Clarify accepted types for the $args and $context parameters in WP_Filesystem().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32338 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:03:08 +00:00
Andrew Ozz
49626f348a Emoji: rename the exclude class to wp-exclude-emoji.
Props Clorith. See #32197.

git-svn-id: https://develop.svn.wordpress.org/trunk@32337 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 00:04:15 +00:00
Andrew Ozz
992cc2e796 Emoji: add an exclude class to wp-emoji checked when monitoring for changes with mutationObserver. Use it for the hidden div used for resizing the Text editor.
See #32197.

git-svn-id: https://develop.svn.wordpress.org/trunk@32336 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 20:17:38 +00:00
Sergey Biryukov
2848b8a911 Replace echo __() with _e().
props marsjaninzmarsa.
fixes #32239.

git-svn-id: https://develop.svn.wordpress.org/trunk@32333 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 16:17:06 +00:00
Sergey Biryukov
72c437c2a8 Merge two strings from theme details dialog.
props McGuive7.
fixes #32047.

git-svn-id: https://develop.svn.wordpress.org/trunk@32332 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-02 09:10:59 +00:00
Scott Taylor
625e7135f3 After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.

See #31139.


git-svn-id: https://develop.svn.wordpress.org/trunk@32330 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 21:39:52 +00:00
Sergey Biryukov
345d34cad9 Bulk Edit: Properly associate the Format select with its label.
props afercia.
fixes #32210.

git-svn-id: https://develop.svn.wordpress.org/trunk@32329 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 16:03:06 +00:00
Sergey Biryukov
e4be853426 Use correct closing tag.
props eligijus, TobiasBg.
fixes #32205.

git-svn-id: https://develop.svn.wordpress.org/trunk@32328 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 14:29:24 +00:00
Dion Hulse
342989657f When creating a temporary file treat the / directory properly, to prevent it ending up in an endless self-calling loop.
Props hnle, taka2. Fixes #32135. See #31811


git-svn-id: https://develop.svn.wordpress.org/trunk@32322 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 03:16:06 +00:00
Gary Pendergast
0b868edb8e When deleting suspicious comments, do so permanently.
git-svn-id: https://develop.svn.wordpress.org/trunk@32310 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:10:50 +00:00
Gary Pendergast
ae1f6413c9 [32308] was for 4.3, not 4.2.1.
git-svn-id: https://develop.svn.wordpress.org/trunk@32309 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:07:20 +00:00
Gary Pendergast
0224286861 When upgrading to 4.2.1, delete suspicious comments.
git-svn-id: https://develop.svn.wordpress.org/trunk@32308 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:03:48 +00:00
Helen Hou-Sandi
ffe23d2f93 About page: Finalize media for 4.2.
props ocean90, Nao.
fixes #31929.


git-svn-id: https://develop.svn.wordpress.org/trunk@32277 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-23 15:42:24 +00:00
Helen Hou-Sandi
09f830dca5 Customizer theme details modal: Repair the layout for IE8.
props obenland.
fixes #32066.


git-svn-id: https://develop.svn.wordpress.org/trunk@32269 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 18:56:01 +00:00
Helen Hou-Sandi
eaba93ed33 Admin menu: prevent (most) lock outs caused by plugins or IE7.
fixes #30900.


git-svn-id: https://develop.svn.wordpress.org/trunk@32268 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 18:37:13 +00:00
Dominik Schilling (ocean90)
5e371ea458 Don't try to focus disabled input fields in the request filesystem credentials form.
fixes #32064.

git-svn-id: https://develop.svn.wordpress.org/trunk@32267 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:56:36 +00:00
Dominik Schilling (ocean90)
2abf4c39ef Don't focus input fields outside of the request filesystem credentials form.
props valendesigns.
fixes #32055.

git-svn-id: https://develop.svn.wordpress.org/trunk@32266 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:23:57 +00:00
Dominik Schilling (ocean90)
f029572866 Theme Switcher: Provide an easier way to reset back to the current active theme.
* Add control for the active theme when doing a theme preview
* Highlight an active theme and move it to the top

props valendesigns, ocean90.
fixes #32002.

git-svn-id: https://develop.svn.wordpress.org/trunk@32265 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:15:01 +00:00
Dominik Schilling (ocean90)
ca11d4c876 Don't return empty themes in wp_prepare_themes_for_js().
see #32002.

git-svn-id: https://develop.svn.wordpress.org/trunk@32264 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:10:40 +00:00
Sergey Biryukov
4e067b0354 About page design for 4.2.
props melchoyce, ryelle.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32260 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 06:03:03 +00:00
Andrew Ozz
925682e2d1 Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
Props iseulde. Fixes #31139, fixes #32006.

git-svn-id: https://develop.svn.wordpress.org/trunk@32258 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 22:40:23 +00:00
Helen Hou-Sandi
19c0b3f469 Shiny Updates: Prevent the post-update success message from jumping.
props pareshradadiya, afercia.
fixes #31984.


git-svn-id: https://develop.svn.wordpress.org/trunk@32256 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 20:40:55 +00:00
Helen Hou-Sandi
b7d25c00e2 Rename the pre_wp_prepare_themes_for_js filter to pre_prepare_themes_for_js.
props DrewAPicture.
fixes #31789.


git-svn-id: https://develop.svn.wordpress.org/trunk@32246 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:22:15 +00:00
Helen Hou-Sandi
8ae79e3d33 Customizer: Better experience for widget filtering in desktop and iOS Safari.
Previously, the search field did not appear at all in desktop Safari, and the auto-focus keyboard fly-up in iOS rendered widget adding frustrating at best.

props dsmart, ocean90.
fixes #31987.


git-svn-id: https://develop.svn.wordpress.org/trunk@32243 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:14:27 +00:00
Helen Hou-Sandi
38ee7ae7eb Press This: Prevent bottom buttons from wrapping on narrow screens.
props Michael Arestad.
fixes #32022.


git-svn-id: https://develop.svn.wordpress.org/trunk@32230 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 21:02:07 +00:00
Gary Pendergast
05710aaa41 Ensure post titles are correctly escaped on the Dashboard.
Props helen, ocean90, dd32, pento.



git-svn-id: https://develop.svn.wordpress.org/trunk@32175 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 07:38:29 +00:00
Gary Pendergast
98da14ab75 Correctly escape theme version numbers when displaying them.
Props collinsinternet.



git-svn-id: https://develop.svn.wordpress.org/trunk@32170 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 06:26:35 +00:00
Andrew Nacin
17d6534bb1 Update wp_die() calls modified in [31658] to use shorthand calling style.
see #31422.


git-svn-id: https://develop.svn.wordpress.org/trunk@32152 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 03:26:24 +00:00
Sergey Biryukov
3c28d7b1f6 Press This: Update documentation for press_this_save_redirect filter after [31992].
props kraftbj.
fixes #31996.

git-svn-id: https://develop.svn.wordpress.org/trunk@32143 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-19 01:34:01 +00:00
Dominik Schilling (ocean90)
6e6e1f45ed About page: All strings are available for translation.
* Remove AJAX call added in [30840].
* Remove `<code>` tags out of localized strings.

props johnbillion, ocean90.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32136 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 18:18:53 +00:00
Helen Hou-Sandi
a71a815a0c About page: A last round of text updates.
props DrewAPicture, johnbillion, afercia, helen.
see #31929.


git-svn-id: https://develop.svn.wordpress.org/trunk@32135 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 17:33:11 +00:00
Dominik Schilling (ocean90)
7fba67e4b7 Customizer: Escape theme preview URLs.
props johnbillion, ocean90.
see #31896.

git-svn-id: https://develop.svn.wordpress.org/trunk@32134 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 16:32:03 +00:00
Aaron Jorbin
686b4af44d Move wp-plugin-update-success event to after lock is released
Fixes #31978
See #31819
Props DavidAnderson



git-svn-id: https://develop.svn.wordpress.org/trunk@32133 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 14:36:04 +00:00
Sergey Biryukov
7b0dbe06fd About page: Two more string tweaks.
props DrewAPicture, pento.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32132 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 01:23:07 +00:00
Sergey Biryukov
99abb0cf3a About page updates.
* Change the subhead strings on credits.php and freedoms.php to match about.php.
* Link the Emoji Codex article in the emoji blurb.
* Add a second sentence to the JavaScript Accessibility blurb.
* Switch positions for the JavaScript Accessibility and Complex Query Ordering sections for balance.

props DrewAPicture, ocean90, pavelevap.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32131 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 00:38:00 +00:00
Dominik Schilling (ocean90)
cf9908ef31 Update about page for 4.2.
props siobhan, DrewAPicture.
see #31929

git-svn-id: https://develop.svn.wordpress.org/trunk@32130 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 18:52:19 +00:00
Dominik Schilling (ocean90)
f00aa86644 Force default avatar for HiDPI avatars on Discussion Settings.
props SergeyBiryukov.
fixes #31972.

git-svn-id: https://develop.svn.wordpress.org/trunk@32129 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 18:08:15 +00:00
Dominik Schilling (ocean90)
be2e1d9937 Reset padding for buttons in theme details modal.
props awbauer.
fixes #31963.

git-svn-id: https://develop.svn.wordpress.org/trunk@32128 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 18:03:59 +00:00
Aaron Jorbin
73479254bc Use named function instead of anonymous function
The named function is testable and replaceable.

Fixes #31964
Props DavidAnderson, adamsilverstein, jorbin




git-svn-id: https://develop.svn.wordpress.org/trunk@32126 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 16:41:24 +00:00
Scott Taylor
91143924cd Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).
Props iseulde, ocean90.
Fixes #31912.


git-svn-id: https://develop.svn.wordpress.org/trunk@32125 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 15:30:16 +00:00
Sergey Biryukov
a8c4455adc Fix typo on About page.
props jamescollins.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32123 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 06:53:25 +00:00
Andrew Ozz
f3033a9f5a Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php.
Props kraftbj. Fixes #31968.

git-svn-id: https://develop.svn.wordpress.org/trunk@32122 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 05:44:08 +00:00
Dominik Schilling (ocean90)
5c1eb9f4f8 Customizer Theme Switcher: Don't re-render a theme control if it has already been rendered.
Move initialization of `$customizeSidebar` to `api.ThemesSection.initialize()` to prevent cases where the result can be undefined.

props westonruter, ocean90.
fixes #31793.

git-svn-id: https://develop.svn.wordpress.org/trunk@32119 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-13 22:09:35 +00:00
Dominik Schilling (ocean90)
17cc95573f 4.2 about page text, rough cut.
props helen, siobhan, DrewAPicture, samuelsidler, markjaquith, nacin.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32118 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-13 15:38:19 +00:00
Dominik Schilling (ocean90)
b0d6757918 Use HTTPS URLs for codex.wordpress.org.
see #27115.

git-svn-id: https://develop.svn.wordpress.org/trunk@32116 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-12 21:28:58 +00:00
Gary Pendergast
b806e118c6 When dbDelta() is checking whether an index is defined in a CREATE TABLE statement, don't worry if MySQL has a subpart defined on an index, but the CREATE TABLE doesn't.
Fixes #31869.



git-svn-id: https://develop.svn.wordpress.org/trunk@32108 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-11 10:39:49 +00:00
Andrew Ozz
301bb0b9da Press This: check the bookmarklet version and add the update notice from PHP.
Fixes #31942.

git-svn-id: https://develop.svn.wordpress.org/trunk@32106 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-10 21:07:42 +00:00
Helen Hou-Sandi
3019ddf457 Customizer theme switcher: Fix some esoteric breakage in iOS Safari.
This manifested in only being able to switch your theme once in the customizer before the "Change" button would appear to stop responding, though a switch to "Preview" and back to "Customize" would reveal the theme switcher after all. Animated positioning appears to be the problem here. The animations are not critical to the experience, particularly on touch+smaller screen devices.

props iseulde.
see #31794.


git-svn-id: https://develop.svn.wordpress.org/trunk@32103 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-10 02:43:20 +00:00
Andrew Ozz
6cf43dfc06 Press This: add ARIA attributes to the alerts container.
Props afercia. Fixes #31942.

git-svn-id: https://develop.svn.wordpress.org/trunk@32102 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-09 23:44:50 +00:00
Andrew Ozz
02a5d32641 Revert [32099] per discussion in #core: https://wordpress.slack.com/archives/core/p1428608303003309.
See #30900.

git-svn-id: https://develop.svn.wordpress.org/trunk@32100 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-09 19:55:54 +00:00
Andrew Ozz
5eb6128f8e Remove z-index from #adminmenuback.
Fixes #30900.

git-svn-id: https://develop.svn.wordpress.org/trunk@32099 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-09 19:25:27 +00:00
Andrew Ozz
fd6c5e6cbd Press This:
- Fix focusing the Standard Editor link after saving draft, if the user has not focused another element.
- Reset the Save Draft button on node change in the editor.
See #31923.

git-svn-id: https://develop.svn.wordpress.org/trunk@32098 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-09 19:06:41 +00:00
Andrew Ozz
47754dfc55 Press This: change the link text to Standard Editor.
Props Michael-Arestad. See #31923.

git-svn-id: https://develop.svn.wordpress.org/trunk@32093 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 23:27:04 +00:00
Andrew Ozz
bd8cb111ed Press This:
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923.

git-svn-id: https://develop.svn.wordpress.org/trunk@32092 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 23:13:35 +00:00
Dominik Schilling (ocean90)
0dee3a771a Customize Headers: Improve handling of the initial header model.
Headers are currently keyed by the basename of the image, see #31786. When two images have the same key only one image will be listed and the current image can be empty in the header control.
To prevent this we now fall back to the raw current header image if the image isn't in `_wpCustomizeHeader.uploads`.

props sirbrillig.
fixes #31742.

git-svn-id: https://develop.svn.wordpress.org/trunk@32091 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 22:27:57 +00:00
Andrew Ozz
543a9d052e Fix flickering of the admin menu on over-scrolling.
Props joemcgill, mindrun. Fixes #30900.

git-svn-id: https://develop.svn.wordpress.org/trunk@32089 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 21:38:16 +00:00
Dominik Schilling (ocean90)
e9196a321a Customizer Theme Switcher: Lazy load theme screenshots.
props westonruter, ocean90.
fixes #31793.

git-svn-id: https://develop.svn.wordpress.org/trunk@32088 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 20:51:39 +00:00
Dominik Schilling (ocean90)
c3143d4bd0 Customizer Theme Switcher: Fix tabbing order if section is open.
see #31289.

git-svn-id: https://develop.svn.wordpress.org/trunk@32087 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 19:02:57 +00:00
Dominik Schilling (ocean90)
b74982a479 Customizer Theme Switcher: Don't deactivate section on empty search results.
props westonruter.
fixes #31889.

git-svn-id: https://develop.svn.wordpress.org/trunk@32083 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 17:52:18 +00:00
Aaron Jorbin
583a13344c Disable shiny updates from modal based on parent window
The QS method added in [32067] and modified in [32080] doesn't work when the user changes the tab inside the modal.  Instead, let's use the parent window's location.

Fixes #31739




git-svn-id: https://develop.svn.wordpress.org/trunk@32082 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 17:37:38 +00:00
Aaron Jorbin
7e4fa157a7 Fix logic for details based shiny updates.
This fixes two problems.  TB seems to sometimes strip window.location.search variables after tb ones, so we need to move it forward.  Also fixes logic error.

See #31739



git-svn-id: https://develop.svn.wordpress.org/trunk@32080 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 17:26:05 +00:00
Boone Gorges
7d18785497 Don't allow whitespace-only image captions from the Media modal.
Captions containing only whitespace trick `image_add_caption()` into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.

Fixes #21848.

git-svn-id: https://develop.svn.wordpress.org/trunk@32079 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 17:10:53 +00:00
Aaron Jorbin
852937d006 Update placeholder for FTP credentials
Two changes:
 * Remove superfluous __ function call
 * Update domain used

Fixes #31922
Props Tmeister



git-svn-id: https://develop.svn.wordpress.org/trunk@32077 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 16:49:22 +00:00
Helen Hou-Sandi
7e87edf5c2 Dashboard: Ensure images other than avatars (such as emoji replacements) in recent comments are not incorrectly positioned.
props SergeyBiryukov.
fixes #31919.


git-svn-id: https://develop.svn.wordpress.org/trunk@32076 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 16:48:48 +00:00
Helen Hou-Sandi
aa24b6d94f Admin menu: fix colors for focus state and in IE8.
props afercia.
fixes #31345.


git-svn-id: https://develop.svn.wordpress.org/trunk@32075 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 16:37:13 +00:00
Helen Hou-Sandi
1ad6f40e53 Modals: Significantly improve the touch scrolling experience.
This particularly fixes the attachment and plugin details modals, but also improves other modals such as wpLink and interim login.

props iseulde.
fixes #31609, #31611. see #31610, #31612.


git-svn-id: https://develop.svn.wordpress.org/trunk@32073 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 03:18:58 +00:00
helen
e7adde0551 Ensure post title input is not shortened for non-public post types.
props tyxla.
fixes #30968.


git-svn-id: https://develop.svn.wordpress.org/trunk@32071 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 20:43:01 +00:00
Helen Hou-Sandi
96bd504d60 Dismissible notices: more precise positioning across browsers.
props valendesigns.
fixes #31233.


git-svn-id: https://develop.svn.wordpress.org/trunk@32068 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 18:43:11 +00:00
Aaron Jorbin
6078d22a0a Disable modal initiated shiny updates on wp-admin/update-core.php
We don't have links to update a single plugin on wp-admin/update-core.php so we can't initiate a shiny update there.

Fixes #31739



git-svn-id: https://develop.svn.wordpress.org/trunk@32067 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 04:47:59 +00:00
Aaron Jorbin
38f0420e12 Use dashes instead of dots as separator for jQuery events in shiny updates
`.` is used for namespaces, so better to use dashes.

see #31819
props iseulde 



git-svn-id: https://develop.svn.wordpress.org/trunk@32063 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 03:12:01 +00:00
Aaron Jorbin
43623c464c Enable users to initiate a shiny update from plugin detail modal
The plugin detail modal can contain a link to update a plugin.  When it does, we should initiate a shiny update.

This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on.  These are the same users that can't use the customizer. 

Fixes #31739




git-svn-id: https://develop.svn.wordpress.org/trunk@32062 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 03:08:38 +00:00
Aaron Jorbin
c7956dcae0 Trigger events upon the completion of a shiny update
Plugins need to be able to do actions when a shiny update completes. While we don't have complete javascript actions and filters, we do have jQuery events that we can fire to assist plugin authors.  

See #31819



git-svn-id: https://develop.svn.wordpress.org/trunk@32061 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-07 02:31:43 +00:00
Helen Hou-Sandi
2f368bf396 Insert from URL: Make sure the link text is actually used.
Turns out there were more pieces to renaming the field.

props iseulde.
fixes #29476.


git-svn-id: https://develop.svn.wordpress.org/trunk@32055 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-06 18:24:53 +00:00
Dominik Schilling (ocean90)
d8f439c335 Customizer: Refresh nonces when a session expires and the user logs in again.
This was broken since 4.0 and the introduction of user session tokens. The nonces are now tied to session tokens as opposed to user IDs, and thus they change with each re-login.
Custom nonces can be added through the `customize_refresh_nonces` filter. On a successful refresh request the JavaScript API will trigger a `nonce-refresh` event. See widget's update nonce as an example.

props westonruter for initial patch.
fixes #31294.

git-svn-id: https://develop.svn.wordpress.org/trunk@32054 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-06 15:09:21 +00:00
Aaron Jorbin
f78df13277 Remove Shiny Bulk Updates
Bulk updates don't need to be ajaxified so let's revert.

See #31770, #29820,



git-svn-id: https://develop.svn.wordpress.org/trunk@32053 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-06 01:20:23 +00:00
Aaron Jorbin
91518f0070 Conditionally add AYS to leaving shiny updates
When a shiny update is happening or pending, we should make sure users don't accidentally leave the page. This simple notification should help prevent users from accidentally not updating when they want to update.

See #31769
Props ericlewis and adamsilverstein for initial patch



git-svn-id: https://develop.svn.wordpress.org/trunk@32052 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-06 00:59:16 +00:00
Helen Hou-Sandi
f64bf71719 Update more instances of default admin blues and grays.
props hugobaeta.
fixes #31234.


git-svn-id: https://develop.svn.wordpress.org/trunk@32051 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 21:19:54 +00:00
Sergey Biryukov
b2a468c1fc After [31941], use the decoupled strings from wp-admin/network/themes.php in wp-admin/network/site-themes.php as well.
fixes #28502.

git-svn-id: https://develop.svn.wordpress.org/trunk@32029 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 14:57:35 +00:00
Sergey Biryukov
0e236b6e72 wp_install_maybe_enable_pretty_permalinks() should have a consistent @return value.
props DrewAPicture.
fixes #6481. see #31888.

git-svn-id: https://develop.svn.wordpress.org/trunk@32027 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 14:48:23 +00:00
Drew Jaynes
fd8d9c5883 Correct grammar when referring to "a user" vs "an user" in several places.
Props ocean90.
Fixes #31894.


git-svn-id: https://develop.svn.wordpress.org/trunk@32025 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-05 14:43:57 +00:00
Drew Jaynes
08a897b58c Clarify the DocBlock summary and parameter description for wp_edit_attachments_query_vars().
See [31037]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32019 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 21:51:36 +00:00
Drew Jaynes
c7fee4fab0 Add proper descriptions for the @global and @param tags in the wp_media_attach_action() DocBlock.
See [31619]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32018 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 21:34:15 +00:00
Drew Jaynes
8d8ea0c529 Clarify the DocBlock description for wp_print_request_filesystem_credentials_modal().
See [31811]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32016 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 21:12:10 +00:00
Drew Jaynes
2a44016ef8 Clarify 4.2.0 changelog entry, add global description to the DocBlock for WP_Users_List_Table->single_row().
See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32015 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 21:08:57 +00:00
Drew Jaynes
3e36e59646 Add missing @since versions from a variety of methods in WP_Press_This.
See [31693]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32014 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 19:45:48 +00:00
Drew Jaynes
4d751d4e98 Add missing DocBlocks for the _limit_array(), _limit_string(), _limit_url(), _limit_img(), _limit_embed(), and _process_meta_entry() utility methods in WP_Press_This.
See [31609]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32013 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 18:22:30 +00:00
Dominik Schilling (ocean90)
9be177ec95 Customize Widgets: Improve sync logic for select[multiple] inputs.
The current logic doesn't account for the special case of `select[multiple]` inputs which lack a single value to synchronize: The value to synchronize is an array of zero or more values.
This change replaces `_getInputStatePropertyName()` with `_getInputState()`, which returns the state for an input depending on its type, and `_setInputState()`, which updates an input's state based on its type.

props westonruter.
fixes #31885.

git-svn-id: https://develop.svn.wordpress.org/trunk@32012 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 16:33:24 +00:00
Drew Jaynes
58ee5beced Fix filter doc vernacular for the quick_edit_show_taxonomy filter.
See [31308]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32011 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 16:07:48 +00:00
Drew Jaynes
d0d60543ae Fix syntax for the $to_display parameter description in the DocBlock for WP_Posts_List_Table->_page_rows().
See [31730]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32010 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 16:03:20 +00:00
Drew Jaynes
472b335948 Add a return description to the DocBlock for WP_Posts_List_Table->is_base_request().
See [31828]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32009 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 16:00:08 +00:00
Dominik Schilling (ocean90)
d5c14c102b Customizer: Fix spinners after [31996].
props westonruter.
fixes #31884.

git-svn-id: https://develop.svn.wordpress.org/trunk@32008 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 15:41:45 +00:00
Drew Jaynes
f937bdc6ce Fix typos in the function summaries for wp_ajax_press_this_save_post() and wp_ajax_press_this_add_category().
See [31534]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32007 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:37:16 +00:00
Drew Jaynes
5394bd31a0 Add an @see mention for Plugin_Upgrader, plus spacing to the wp_ajax_update_plugin() delcaration.
See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32006 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:18:52 +00:00
Drew Jaynes
3e5eeaf6f0 Add a more descriptive function summary for options_discussion_add_js().
See [31095]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32005 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:15:49 +00:00
Dominik Schilling (ocean90)
b152b46c0e Customizer Theme Switcher: Remove "Add New" reference from customize-controls.js.
see #31837.

git-svn-id: https://develop.svn.wordpress.org/trunk@32004 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:13:14 +00:00
Drew Jaynes
f76ed758b8 Fix Docblock syntax for the taxonomy_parent_dropdown_args filter.
See [30998]. See #31888


git-svn-id: https://develop.svn.wordpress.org/trunk@32003 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:12:04 +00:00
Boone Gorges
ddb33c9aed After [31114] and [31323], 'View Post' generated in get_sample_permalink_html() should go to pretty permalink.
`get_permalink()` will return a non-pretty permalink for future posts, which
breaks some user workflows that expect View Post to lead to a page with the
pretty permalink.

Fixes #30910.

git-svn-id: https://develop.svn.wordpress.org/trunk@32002 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 01:26:08 +00:00
Sergey Biryukov
667899569f Remove hidden user_id input from wp_comment_reply().
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.

See [31776] for Edit Comment screen.

props dllh.
fixes #30307.

git-svn-id: https://develop.svn.wordpress.org/trunk@31999 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 13:27:32 +00:00
Helen Hou-Sandi
6983294161 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.


git-svn-id: https://develop.svn.wordpress.org/trunk@31996 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 04:51:18 +00:00
Andrew Ozz
ca908b2056 Themes screen: remove extra debounce when searching.
Props evansolomon. Fixes #31812.

git-svn-id: https://develop.svn.wordpress.org/trunk@31995 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 02:36:36 +00:00
Andrew Ozz
c3d7fa68ce Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling.
Props joedolson, adamsilverstein, afercia, DrewAPicture. Fixes #26600.

git-svn-id: https://develop.svn.wordpress.org/trunk@31994 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 02:31:11 +00:00
Andrew Ozz
04fbf4cd60 Accessibility improvements for Options general screen: add missing labels and aria attributes.
Props DrewAPicture, afercia. Fixes #31144.

git-svn-id: https://develop.svn.wordpress.org/trunk@31993 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 01:54:47 +00:00
Andrew Ozz
eacf52a68a Press This:
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875.

git-svn-id: https://develop.svn.wordpress.org/trunk@31992 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 01:33:30 +00:00
John Blackbourn
a0bd96bafb Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet.
See #31770.


git-svn-id: https://develop.svn.wordpress.org/trunk@31991 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 00:17:20 +00:00
Dion Hulse
248c73b1cf Plugins Browser: Replace the download count with the number of Active installs of the plugin.
Fixes #31865


git-svn-id: https://develop.svn.wordpress.org/trunk@31990 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 23:48:26 +00:00
Andrew Ozz
4527b2cbb4 Press This: prevent pasting of HTML in the title H2. Insert the clipboard text instead.
Fixes #31768.

git-svn-id: https://develop.svn.wordpress.org/trunk@31987 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 21:10:28 +00:00
Sergey Biryukov
08e6f5306e Remove unnecessary echo(), add translator comment.
props ramiy.
fixes #31873.

git-svn-id: https://develop.svn.wordpress.org/trunk@31986 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 19:00:08 +00:00
Dominik Schilling (ocean90)
2563a4f802 Customizer: Update selector, missed in [31984].
see #28784.

git-svn-id: https://develop.svn.wordpress.org/trunk@31985 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 17:17:19 +00:00
Dominik Schilling (ocean90)
340cb573ae Customizer: Improve the overlay close button for iOS.
see #28784.

git-svn-id: https://develop.svn.wordpress.org/trunk@31984 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 17:15:08 +00:00
Aaron Jorbin
dc502287ef Update aria-label when doing a shiny plugin update
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails

props mehulkaklotar, afercia
Fixes #31722




git-svn-id: https://develop.svn.wordpress.org/trunk@31982 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 05:30:13 +00:00
Sergey Biryukov
b8b33293e1 Press This: Use more accurate wording on Tools screen.
props kraftbj.
see #31836.

git-svn-id: https://develop.svn.wordpress.org/trunk@31980 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 01:29:41 +00:00
Dominik Schilling (ocean90)
a05bbf7e7b Customizer Theme Switcher: Navigation streamlining.
* Detach Themes section from other controls
* Move to buttons to navigate back and forth
* Change titles based on current theme status, active/previewing
* Hide the active/previewing theme from the list of available themes

props folletto for the design concepts.
props designsimply, celloexpressions for initial patches.
props Team Gandalf.
see #31289.

git-svn-id: https://develop.svn.wordpress.org/trunk@31975 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:50:10 +00:00
Dominik Schilling (ocean90)
d6a590e087 Customizer: Make the available widgets overlay closable on narrow screens.
see #28784.

git-svn-id: https://develop.svn.wordpress.org/trunk@31974 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:24:21 +00:00
Helen Hou-Sandi
35df5592f1 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.


git-svn-id: https://develop.svn.wordpress.org/trunk@31973 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:05:17 +00:00
Aaron Jorbin
5b676b4f8e Fix colors for activated and updated plugins
If we don't have the updated class on the TR for he update message, then the message is red and red is scary and they just updated, they should be happy and celebrating, not scared. 

See #31608




git-svn-id: https://develop.svn.wordpress.org/trunk@31969 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:30:50 +00:00
Sergey Biryukov
f898c8bd3d Merge title strings on Edit Site screens.
props ramiy.
fixes #31844.

git-svn-id: https://develop.svn.wordpress.org/trunk@31962 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 17:59:25 +00:00
Sergey Biryukov
02253bbcb6 Remove unused printf() on network setup screen.
props ramiy.
fixes #31841.

git-svn-id: https://develop.svn.wordpress.org/trunk@31961 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 17:00:49 +00:00
Scott Taylor
8f8c526a56 In WP_Posts_List_Table::get_views(), don't add the current class to the all status link if ->user_posts_count has a value, which triggers the additional mine status.
See [31828].
Fixes #24869.


git-svn-id: https://develop.svn.wordpress.org/trunk@31959 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 16:17:01 +00:00
Sergey Biryukov
3ecaee903e Add translator comments for placeholders in network-related strings.
props ramiy.
fixes #31834.

git-svn-id: https://develop.svn.wordpress.org/trunk@31956 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 13:25:55 +00:00
Dominik Schilling (ocean90)
14dc44fb83 Accessibility: Add landmark roles to WordPress admin areas.
props afercia, joedolson.
fixes #31450.

git-svn-id: https://develop.svn.wordpress.org/trunk@31955 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 13:16:47 +00:00