Commit Graph

24622 Commits

Author SHA1 Message Date
Lance Willett db7ec86731 Twenty Fourteen: legibility improvements for small sidebar text. Fixes #25827 props iamtakashi.
git-svn-id: https://develop.svn.wordpress.org/trunk@26044 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 00:54:24 +00:00
Andrew Ozz 3032512477 Grunt: limit JSHint's run to a single specified file. Run with grunt jshint:core --file=filename.js. Props kadamwhite, see #25187.
git-svn-id: https://develop.svn.wordpress.org/trunk@26043 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 00:40:38 +00:00
Andrew Nacin 3a5802dd3b Ignore wp-langs-en.js during linting, per azaozz. see #25187.
git-svn-id: https://develop.svn.wordpress.org/trunk@26042 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 21:47:24 +00:00
Andrew Nacin 8bdd289576 Update jshint grunt task to exclude eqeqeq and curly for now, until we've resolved other code smells.
props kadamwhite.
see #25187.


git-svn-id: https://develop.svn.wordpress.org/trunk@26041 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 21:14:49 +00:00
Andrew Nacin aacc286f7c Use only one var per scope in our password-strength-meter tests.
props kadamwhite.
see #25187.


git-svn-id: https://develop.svn.wordpress.org/trunk@26040 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 20:40:12 +00:00
Lance Willett f7c0b07d98 Twenty Fourteen: better override for Background and Colors descriptions in Customizer, props obenland. See #25869.
git-svn-id: https://develop.svn.wordpress.org/trunk@26039 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 20:36:09 +00:00
Lance Willett d3bd9f465c Twenty Fourteen: add contextual help text to Background and Colors controls in Customizer, using the `description` field. Props rachelbaker, see #25869.
git-svn-id: https://develop.svn.wordpress.org/trunk@26038 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 20:27:05 +00:00
Lance Willett daad8899b1 Twenty Fourteen: move all controls for managing Featured Content to the Customizer. Also implement smart fallbacks to not using a custom tag with the "featured" tag and sticky posts. Props obenland and celloexpressions, see #25549.
git-svn-id: https://develop.svn.wordpress.org/trunk@26037 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 20:24:24 +00:00
Lance Willett 976df5f9ed Twenty Fourteen: clean up inconsistencies in content template files. Props iamtakashi, fixes #25868.
git-svn-id: https://develop.svn.wordpress.org/trunk@26036 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 19:04:56 +00:00
Andrew Ozz 1a396b5d8a jshint: fixes for revisions.js, props adamsilverstein, fixes #25864.
git-svn-id: https://develop.svn.wordpress.org/trunk@26035 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 18:13:33 +00:00
Lance Willett 48d44afbb9 Twenty Fourteen: remove the pattern image used as a placeholder for featured images. This greatly improves the "first run" experience of the theme and gives it a more general appeal as a blog theme by putting less of a requirement on featured images. Props iamtakashi, fixes #25859.
git-svn-id: https://develop.svn.wordpress.org/trunk@26034 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 17:28:56 +00:00
Sergey Biryukov bc9ca186e5 Add missing semicolon after wpLink object definition. props mt8.biz. fixes #25862.
git-svn-id: https://develop.svn.wordpress.org/trunk@26033 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 10:41:15 +00:00
Dion Hulse 01a9ea55be Add the various Drop ins to the svn:ignore property on src/wp-content. Fixes #25857
git-svn-id: https://develop.svn.wordpress.org/trunk@26032 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 05:50:19 +00:00
Dion Hulse 24c2774076 Fix a case where wp_guess_url() would leave a prefixed path in the generated URL when symlinks were involved. Fixes #25797
git-svn-id: https://develop.svn.wordpress.org/trunk@26031 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-07 03:33:11 +00:00
Lance Willett 245b99ceb1 Twenty Fourteen: minor template fixes and a placeholder screenshot.
git-svn-id: https://develop.svn.wordpress.org/trunk@26030 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 23:53:13 +00:00
Andrew Ozz 859516cd19 Add X-UA-Compatible meta tag in the admin, locking the compatibility mode in IE to the highest supported document mode. Fixes #25575.
git-svn-id: https://develop.svn.wordpress.org/trunk@26029 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 23:48:02 +00:00
Sergey Biryukov fc8d09e2a6 A negative term parent value should be sanitized to 0, not 1. Fix a regression in sanitize_term_field() caused by [26010].
props mattheu for initial patch.
fixes #25852.

git-svn-id: https://develop.svn.wordpress.org/trunk@26028 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 23:40:46 +00:00
Sergey Biryukov 2564c74a57 Fix inverted logic for displaying the 'Broken Theme' string. props pavelevap. fixes #25465.
git-svn-id: https://develop.svn.wordpress.org/trunk@26027 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 22:39:35 +00:00
Lance Willett 8b481f300b Twenty Fourteen: add full-width featured images for layouts without a content sidebar, but use `wp_is_mobile()` to load smaller-sized images for mobile. Props iamtakashi, fixes #25758.
git-svn-id: https://develop.svn.wordpress.org/trunk@26026 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 20:39:50 +00:00
Andrew Ozz 370c503d66 Add es3 and onevar to the JSHint configuration as discussed in IRC. Props jorbin, see #25187.
git-svn-id: https://develop.svn.wordpress.org/trunk@26025 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 20:26:42 +00:00
Sergey Biryukov cd7deb0e7b Make Twenty Fourteen the default theme. props markmcwilliams. fixes #25702.
git-svn-id: https://develop.svn.wordpress.org/trunk@26024 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 20:01:54 +00:00
Lance Willett 8f46d50138 Twenty Fourteen: add missing sidebar for post format archives. Props iamtakashi, fixes #25842.
git-svn-id: https://develop.svn.wordpress.org/trunk@26023 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 16:11:51 +00:00
Sergey Biryukov 3d26edf1fe Remove irrelevant @see references. props mt8.biz. fixes #25843.
git-svn-id: https://develop.svn.wordpress.org/trunk@26022 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-06 10:16:55 +00:00
Lance Willett e20baa48d8 Twenty Fourteen: improvements to Accent Color behavior, including a case where options were published too soon. Props celloexpressions, fixes #25580.
git-svn-id: https://develop.svn.wordpress.org/trunk@26021 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 23:28:07 +00:00
Lance Willett e2bf98b1d3 Twenty Fourteen: add Audio post format support. Props celloexpressions, closes #25807.
git-svn-id: https://develop.svn.wordpress.org/trunk@26020 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 21:51:03 +00:00
Lance Willett a009e64c18 Twenty Fourteen: remove a todo.
git-svn-id: https://develop.svn.wordpress.org/trunk@26019 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 21:48:29 +00:00
Lance Willett b3722a1edd Twenty Fourteen: add print styles, props iamtakashi. Closes #25830.
git-svn-id: https://develop.svn.wordpress.org/trunk@26018 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 16:42:29 +00:00
Dion Hulse 34fa8af8bb Core Upgrader: Include an unmodified $wp_version in Core_Upgrader::upgrade(). This protects against cases where the global $wp_version has been modified. See #25772
git-svn-id: https://develop.svn.wordpress.org/trunk@26017 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 06:22:23 +00:00
Dion Hulse 18e173ae80 Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to. Props nacin. See #25772 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@26016 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 06:19:05 +00:00
Dion Hulse 83754e1636 Remove dead code from the Plugin Upgrader class. Props jdgrimes. Fixes #25470
git-svn-id: https://develop.svn.wordpress.org/trunk@26015 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 05:47:41 +00:00
Dion Hulse 58e4a21f07 When checking filesystem permissions for core updates, only check the permissions of the files which we need to alter. Props nacin for initial patch. Fixes #25771 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@26014 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 05:42:23 +00:00
Dion Hulse 43d50e9c9e Add a filter to the Background Updates debug email, matches the filter used on the non-debug post-update emails. Props pento. Fixes #25756
git-svn-id: https://develop.svn.wordpress.org/trunk@26013 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 02:14:34 +00:00
Scott Taylor d8f57f88ad Respect `paged` when `offset` is used in `WP_Query`. Adds unit tests.
Props coffee2code.
Fixes #18897.



git-svn-id: https://develop.svn.wordpress.org/trunk@26012 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:34:44 +00:00
Scott Taylor 5643e3ca17 Pass `$args` to the `export_wp` action in `export_wp()`, which is currently passed no arguments.
Props nickdaugherty.
Fixes #25574.



git-svn-id: https://develop.svn.wordpress.org/trunk@26011 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:26:49 +00:00
Scott Taylor ed22220a0f Cast proper fields to `int` when returning from `wp_get_object_terms()`. Add `term_taxonomy_id` and `object_id` to the list in `sanitize_term()` and `sanitize_term_field()`.
Fixes #17646. Adds unit tests.
Props simonwheatley, dd32, kovshenin.



git-svn-id: https://develop.svn.wordpress.org/trunk@26010 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:18:02 +00:00
Scott Taylor 67443e080c Don't globalize version variables twice. See #23685.
git-svn-id: https://develop.svn.wordpress.org/trunk@26009 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 00:57:52 +00:00
Scott Taylor 268667e170 When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be. Explicitly make the version variables global.
Props nbachiyski.
Fixes #23685.



git-svn-id: https://develop.svn.wordpress.org/trunk@26008 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 00:23:38 +00:00
Scott Taylor 0923b7b93a Category and tag are typically checked before checking for a custom taxonomy. If the global query matches category or tag (even if it also has tax_query set), return category/tag as the queried object, instead of arbitrarily returning the first term in the `tax_query` stack (typically those added with 'pre_get_posts').
Real world example: http://www.emusic.com/17dots/topics/daily-download/ - "tag" page, regionalized for US-only content using `pre_get_posts` passing in the terms "US" and "ALL" for "region" (custom tax). All of the theme functions would output "ALL" as the term name. Even though it was a tag archive, the queried object was an arbitrary term from `tax_query`.

See [26006]. All unit tests pass.
Fixes #20767.




git-svn-id: https://develop.svn.wordpress.org/trunk@26007 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 23:53:55 +00:00
Scott Taylor 5321bc4957 `WP_UnitTestCase::go_to()` tried its best to clean up global space, but ultimately fell short. Because it was blowing away `WP` every time it was called, it was dropping all the query vars that were registered for custom taxonomies and custom post types (ouch).
Introduces `_cleanup_query_vars()`. This is a prerequisite for the unit tests on #20767. All unit tests pass with this change.

See #20767.
Fixes #25818.



git-svn-id: https://develop.svn.wordpress.org/trunk@26006 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 22:46:44 +00:00
Scott Taylor 2f38d2efc6 Move `Tests_Query_Conditionals::assertQueryTrue()` to `WP_UnitTestCase`. It should be available to all unit test classes. The conditionals class is huge, other classes are necessary for better coverage.
git-svn-id: https://develop.svn.wordpress.org/trunk@26005 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 21:55:12 +00:00
Scott Taylor ecbcfc5a20 Set the default parent id to 0, instead of -1, in `Tests_Post_Attachments::_make_attachment()`. Prevents `Out of range value for column 'post_parent'` database error without papering over it in core.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@26004 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 21:39:35 +00:00
Lance Willett e512f03e75 Twenty Fourteen: update bundled Genericons to the latest version, 3.0.2. Props iamtakashi, closes #25812.
git-svn-id: https://develop.svn.wordpress.org/trunk@26003 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 18:07:18 +00:00
Lance Willett 848937c672 Twenty Thirteen: capitalize "Not Found" string for use in a page title, see #24891 and r25907.
git-svn-id: https://develop.svn.wordpress.org/trunk@26002 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 17:56:32 +00:00
Sergey Biryukov 6fa1c89458 Pass comment ID and comment post ID to get_comment_class() in WP_Comments_List_Table::single_row().
props drozdz.
fixes #25814.

git-svn-id: https://develop.svn.wordpress.org/trunk@26001 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 10:59:58 +00:00
Sergey Biryukov acc8ac64b8 Fall back to comment author email in get_avatar() if the user who left the comment no longer exists.
props mauryaratan, lite3.
fixes #25803.

git-svn-id: https://develop.svn.wordpress.org/trunk@26000 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-02 12:19:43 +00:00
Lance Willett fcc1bb0b65 Twenty Fourteen: revamp the RTL stylesheet and related cleanup. Props iamtakashi, see #25801.
git-svn-id: https://develop.svn.wordpress.org/trunk@25999 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-02 04:35:35 +00:00
Lance Willett b604102332 Twenty Fourteen: second pass at revamping the main CSS file. Update pattern graphics to fix issue with orientation changes on tablets. Props iamtakashi, fixes #25592.
git-svn-id: https://develop.svn.wordpress.org/trunk@25998 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-31 04:27:51 +00:00
Sergey Biryukov 3c625347e6 Correct $user_id parameter description. props mauryaratan, Corphi. fixes #25774.
git-svn-id: https://develop.svn.wordpress.org/trunk@25997 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 20:17:21 +00:00
Andrew Nacin 90202aed35 Explicitly globalize $is_nginx in vars.php.
props johnjamesjacoby.
fixes #25776.


git-svn-id: https://develop.svn.wordpress.org/trunk@25996 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 19:36:39 +00:00
Lance Willett 34139288e8 Twenty Fourteen: JavaScript fixes after running jshint, see r25960:
* Enforce `===` instead of `==`
 * Fix confusing use of `!`
 * Remove unused variables like `calcNext`, defined but never used
 * Proper use of braces
 * Move functions out of if/else statements
 * Document unknown functions as Microsoft-specific

git-svn-id: https://develop.svn.wordpress.org/trunk@25995 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 18:52:54 +00:00