sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
29,717 Commits 2 Branches 473 Tags 137 MiB
5af9ac0ea2
Commit Graph

1191 Commits

Author SHA1 Message Date
Andrew Nacin
d0d07cf614 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative. 
props dd32 for initial patch.
fixes #25657.


git-svn-id: https://develop.svn.wordpress.org/trunk@25863 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 09:48:36 +00:00
Andrew Nacin
bce2656e6d Move upgrader_process_complete for core to its proper place in Core_Upgrader. 
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.


git-svn-id: https://develop.svn.wordpress.org/trunk@25861 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 04:36:54 +00:00
Andrew Nacin
597e82e94c Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.) 
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.


git-svn-id: https://develop.svn.wordpress.org/trunk@25859 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-21 22:28:07 +00:00
Andrew Nacin
d96b64c116 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED. 
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25851 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 21:23:43 +00:00
Andrew Nacin
fda5b39db2 Use correct variable. fixes #10787. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25843 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 17:15:36 +00:00
Andrew Nacin
0b22aae62d Notify administrators of successful, failed, and pending core updates. 
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25841 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 16:29:16 +00:00
Andrew Nacin
142d8c3d30 Delete expired transients on database upgrades. 
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.


git-svn-id: https://develop.svn.wordpress.org/trunk@25838 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 07:47:44 +00:00
Andrew Nacin
92c2bc7797 Introduce email templates for automatic background updates. 
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25837 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 06:32:27 +00:00
Andrew Nacin
aa4635548d set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin. 
fixes #25622.


git-svn-id: https://develop.svn.wordpress.org/trunk@25836 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 23:23:42 +00:00
Andrew Nacin
8cb344e237 In automatic background updates, standardize on 'update'. 
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25835 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 23:20:56 +00:00
Dion Hulse
3ce626a96b Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check). 
See #25576, #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25831 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 18:39:04 +00:00
Dion Hulse
d2d9b963a2 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock. 
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25828 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 05:23:35 +00:00
Andrew Nacin
4644bb87f6 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25825 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 04:01:06 +00:00
Andrew Nacin
c39143fd2e Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods. 
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25823 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 00:54:15 +00:00
Dion Hulse
d0bd68cf5f Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25822 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 00:11:25 +00:00
Dion Hulse
d5aba84213 Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25818 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 22:26:47 +00:00
Dion Hulse
853c9a50bd When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25817 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 19:47:21 +00:00
Andrew Nacin
977ca48a58 Merge the should_auto_update() and can_auto_update() methods. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25815 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 19:34:05 +00:00
Dion Hulse
aa5c907e40 Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25812 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 17:06:58 +00:00
Dion Hulse
549029393f Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath. 
See #18201


git-svn-id: https://develop.svn.wordpress.org/trunk@25811 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 15:19:59 +00:00
Andrew Nacin
e192eb396e Include translations in the update bubbles (as +1 if there are any). see #18200. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25810 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 14:33:21 +00:00
Dion Hulse
96aa66a924 Remove the no longer used Headerless_Upgrader_Skin class, it's been replaced by Language_Pack_Upgrader_Skin. 
See #18200, [25806]


git-svn-id: https://develop.svn.wordpress.org/trunk@25807 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:18:12 +00:00
Dion Hulse
ddaaa6d88a Language Packs: Many many fixes such as: 
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200, #22704



git-svn-id: https://develop.svn.wordpress.org/trunk@25806 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:14:29 +00:00
Andrew Nacin
4f7112000f Avoid numerous potential PHP warnings when dealing with the pre-r25801 get_core_checksums() return value. 
Warnings included current(), filestat(), and md5_file().

see #18201. see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25805 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:01:12 +00:00
Andrew Nacin
867f084ca0 Significantly simplify get_core_checksums(), as the caching and chunking was causing too much grief. 
Make sure we only do our pre-flight is_writable check when the file exists.

see #18201. see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25801 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 23:02:28 +00:00
Andrew Nacin
14b83f44f1 Use correct variable. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25800 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 22:06:08 +00:00
Andrew Nacin
3b724d5082 Remove accidental debug cruft in [25780]. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25799 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 21:24:01 +00:00
Andrew Nacin
1e8729b5c1 Avoid our pre-flight writable checks if get_core_checksums() doesn't exist yet. 
Thus, it will not work for 3.6 => 3.7, only 3.7+.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25798 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 20:34:02 +00:00
Andrew Nacin
0a284a4d5c Only add error data to the files_not_writable WP_Error if the install already has [25775] and [25796] applied. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25797 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 20:00:01 +00:00
Andrew Nacin
55d176020b In show_message(), only print error data if it is a string. 
see #25576, [25775].


git-svn-id: https://develop.svn.wordpress.org/trunk@25796 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:50:48 +00:00
Andrew Nacin
204ca72a66 Core Updates: Verify that all files we're about to copy are actually writable, when using the direct transport. 
Once we begin to copy core files, all bets are off. This allows us to fail early when we'll otherwise need to stop midway through due to permissions issues, which is a particularly bad problem when only some files have permissions issues.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25794 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:17:56 +00:00
Andrew Nacin
c72ba036cf Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir(). 
This occurs when we can't copy a file. We chmod it and try again.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25793 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:13:33 +00:00
Dion Hulse
fa79184a7d Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/. 
My bad. See #22704, [25781].


git-svn-id: https://develop.svn.wordpress.org/trunk@25787 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 14:54:29 +00:00
Andrew Nacin
2eebc47254 Hide auto updates from update-core.php directly in get_core_updates(). see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25783 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 05:06:35 +00:00
Andrew Nacin
85d32ce873 Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback. 
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25782 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 02:58:07 +00:00
Andrew Nacin
1918e828da Automatic updates: Include error data in the follow-up API request. 
props dd32.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25781 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 23:32:47 +00:00
Andrew Nacin
3eac3d0380 Parse absolute paths out of error data. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25780 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 22:24:28 +00:00
Dion Hulse
b492ae85f8 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return. 
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25779 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:54:33 +00:00
Andrew Nacin
67c80dae13 Account for the possible failure of disk_free_space() in update_core(). 
see #22704, #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25778 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:14:39 +00:00
Andrew Nacin
d6a1b681d3 Auto updates: Only attempt a roll back when we've hit a critical error code. 
Specifically, this means when we've failed in copying files.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25777 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:02:46 +00:00
Andrew Nacin
b8efab15d8 Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files. 
see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25776 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:57:28 +00:00
Andrew Nacin
47e85a9b54 In the upgrader, only print additional error data if it is a string. 
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25775 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:19:52 +00:00
Andrew Nacin
5db3863d12 In unzip_file(), confirm we have enough available disk space before extracting. 
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25774 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:14:13 +00:00
Andrew Nacin
bd26f54af2 More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25772 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 19:37:53 +00:00
Andrew Nacin
7bf44580a9 Add explicit link to the installation being updated in debugging emails. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25770 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-12 20:17:20 +00:00
Andrew Nacin
9eff9eaebe Silence possible warnings from is_dir(). fixes #25572. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25764 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-11 17:10:18 +00:00
Andrew Nacin
2e605e76c6 Refine error codes throughout the upgrader so we can better detect at what stage updates fail. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25763 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-11 16:05:13 +00:00
Andrew Nacin
627b25bf50 Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25755 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 14:45:55 +00:00
Dion Hulse
f0571c02b7 After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25752 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 01:56:44 +00:00
Dion Hulse
e03279e8b0 In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful. 
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25750 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 01:31:22 +00:00
Andrew Nacin
12cb3a353e Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height. 
props plocha.
fixes #25038.


git-svn-id: https://develop.svn.wordpress.org/trunk@25744 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 19:06:56 +00:00
Helen Hou-Sandi
99df61b666 Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25741 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 18:46:34 +00:00
Dion Hulse
28736216f3 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069 
git-svn-id: https://develop.svn.wordpress.org/trunk@25739 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 16:46:31 +00:00
Scott Taylor
4aa0066736 Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video in attachment_submitbox_metadata(). 
Props kovshenin.
See #23926.



git-svn-id: https://develop.svn.wordpress.org/trunk@25727 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-08 15:31:32 +00:00
Andrew Nacin
04f053ce0c Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping. 
props SergeyBiryukov.
see #25023.
for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25719 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-07 18:34:35 +00:00
Drew Jaynes
2a2587c6dc Inline documentation for hooks in wp-admin/includes/bookmark.php. 
Props johnafish, kpdesign.
Fixes #25494.


git-svn-id: https://develop.svn.wordpress.org/trunk@25706 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-07 02:18:20 +00:00
Andrew Nacin
40ea01d759 Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25700 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 15:45:09 +00:00
Andrew Nacin
0286d7030d Don't modify post_author during a quick edit when the post type doesn't support authors. 
props ocean90.
fixes #16645.


git-svn-id: https://develop.svn.wordpress.org/trunk@25698 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 13:14:06 +00:00
Andrew Nacin
9f23f85ae2 Run _fix_attachment_links() when post_status is future or private in addition to publish. 
Fixes regression caused by [20308].

props jond3r.
fixes #25268.


git-svn-id: https://develop.svn.wordpress.org/trunk@25697 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 12:55:38 +00:00
Andrew Nacin
352ff49768 Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid. 
props garyc40, wonderboymusic.
fixes #14578.


git-svn-id: https://develop.svn.wordpress.org/trunk@25695 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 10:55:42 +00:00
Andrew Nacin
c0fb231f92 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override. 
props azaozz.
fixes #24930.


git-svn-id: https://develop.svn.wordpress.org/trunk@25694 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 10:45:25 +00:00
Andrew Nacin
1b37564f35 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25691 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-05 10:58:20 +00:00
Andrew Nacin
a2c2641419 Avoid counting auto-drafts in sticky. 
props nofearinc.
fixes #25127.


git-svn-id: https://develop.svn.wordpress.org/trunk@25678 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-03 01:15:30 +00:00
Andrew Nacin
635a1249f5 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses. 
props creativeinfusion.
fixes #24818.


git-svn-id: https://develop.svn.wordpress.org/trunk@25676 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-03 00:59:12 +00:00
Andrew Nacin
df647346b1 Don't use a double negative. 
props TobiasBg.
fixes #18201.


git-svn-id: https://develop.svn.wordpress.org/trunk@25674 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:49:34 +00:00
Andrew Nacin
69a17e3469 Links manager: Restrict field length based on DB schema. 
props solarissmoke, vinod-dalvi.
fixes #17296, #12264.


git-svn-id: https://develop.svn.wordpress.org/trunk@25670 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:10:24 +00:00
Dominik Schilling (ocean90)
6311fbbfdb Replace use of global $user_ID in favor of get_current_user_id(). fixes #25372. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25669 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:09:52 +00:00
Andrew Nacin
212dba1113 Show a proper error message on the dashboard when the current theme is broken. 
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.

Clean up broken/ugly "alt" row styling when we are displaying broken themes.

props johnbillion for initial patch.
fixes #21670.


git-svn-id: https://develop.svn.wordpress.org/trunk@25666 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 20:49:59 +00:00
Scott Taylor
a27234c898 Rather than adding a taxonomy arg to get_category(), convert all uses of get_category() in core to get_term(). By doing so, we negate the need to call _make_cat_compat() in a few places that are only looking for a single property. 
Fixes #8722.



git-svn-id: https://develop.svn.wordpress.org/trunk@25662 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 19:58:50 +00:00
Andrew Nacin
64d3d53838 More string cleanups. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25658 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 18:50:45 +00:00
Andrew Nacin
fc97814a23 This error message should have a period. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25656 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 17:44:09 +00:00
Andrew Nacin
49e7cf1a30 Rollback is not a verb. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25655 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 17:43:15 +00:00
Dion Hulse
6d29f14560 Automatic Updates: Remove some debug from [25649] See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25651 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:29:19 +00:00
Dion Hulse
3fa23828e3 Automatic Updates: Disable Automatic updates for Mercurial(HG) and Bazaar(bzr) version control systems in addition to Git and SVN. Props jamescollins. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25650 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:24:06 +00:00
Dion Hulse
05a01e5964 Automatic Updates: Add a rollback functionality upon installation failure, the rollback package will be available for partial-updates for automatic updates and be similar to our existing partial builds (but in reverse). 
A further iteration of this is to also detect whitescreens (fatals) after a auto update, and trigger the rollback for that too.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25649 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:20:35 +00:00
Dion Hulse
f1928e42bf MD5 file verification: Prevent md5_file() warnings when files don't exist, additionally, don't verify wp-content files as they can be updated separately, as well as WP_CONTENT_DIR being set elsewhere. See #22704 See #18201 
git-svn-id: https://develop.svn.wordpress.org/trunk@25648 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-29 23:07:59 +00:00
Dion Hulse
fefaa807e9 Automatic Updates: Skip doing the sanity checking MD5 before deciding if we should use a partial build or not, This change means we always use a partial build for automatic updates. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25647 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-29 22:59:46 +00:00
Drew Jaynes
78d93bfac3 Improve inline documentation for Walker_Nav_Menu, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist. 
Includes previously undocumented parameters.

See #23406.


git-svn-id: https://develop.svn.wordpress.org/trunk@25643 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 21:01:54 +00:00
Drew Jaynes
346d71fdbd Inline documentation for Walker_Category_Checklist. 
See #23406.


git-svn-id: https://develop.svn.wordpress.org/trunk@25642 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 18:07:02 +00:00
Andrew Nacin
c3a6047584 Fix strict notice. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25635 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 06:32:14 +00:00
Andrew Nacin
ed31cbfab1 Changes to automatic background updates in preparation for Beta 1. 
* Show a notice for beta testers on update-core.php explaining the status of their install. Three possibilities: auto updates are enabled, auto updates are disabled because the install doesn't support SSL HTTP requests, and auto updates are disabled because it is a VCS checkout.
 * Improve the output of the email, for maximum debugging potential. Failures are clearly labeled and the email leads testers to the support forums and Trac.
 * Try to create wp-content/languages in the upgrader if it doesn't exist. Our mkdir isn't recursive, so trying to create wp-content/languages/plugins could fail.
 * Abstract out version control checkout determination into a public method. The filter is now auto_upgrade_is_vcs_checkout, still subject to change.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25633 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-27 23:20:08 +00:00
Drew Jaynes
8a3df7d4b4 Inline documentation for hooks in wp-admin/includes/class-wp-plugin-install-list-table.php. 
Props naomicbush.
Fixes #25357.


git-svn-id: https://develop.svn.wordpress.org/trunk@25630 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-26 02:47:44 +00:00
Helen Hou-Sandi
ab117ae99c Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25608 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 20:22:24 +00:00
Andrew Nacin
34e9dc9f06 Introduce wp_get_user_contact_methods() as a public version of _wp_get_user_contactmethods. 
props johnnyb.
fixes #24273.


git-svn-id: https://develop.svn.wordpress.org/trunk@25606 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 18:13:18 +00:00
Dion Hulse
e4a523977f Automatic Updates: Correct a typo of a constant, s/DISABLE_FILE_MODS/DISALLOW_FILE_MODS/. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25599 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 07:15:58 +00:00
Dion Hulse
c8251ec989 Automatic Core Updates: Enable Core Automatic Updates for Security releases, Development nightly releases, and, Language packs. See #22704 
For more information on Automatic Core Updates, See #22704 and http://wp.me/p2AvED-1Lo



git-svn-id: https://develop.svn.wordpress.org/trunk@25598 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 03:35:53 +00:00
Helen Hou-Sandi
9ac7b0ce32 Saner CSS for row actions - now we can just target .row-actions instead of both .row-actions and .row-actions-visible. CSS for .row-actions-visible remains for now due to usage in plugins. Visibility is controlled by toggling a .visible class. fixes #25403. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25592 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 01:53:08 +00:00
Andrew Nacin
d420b71d52 Ignore unauthorized meta keys in meta_form(). fixes #18786. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25591 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 01:30:31 +00:00
Drew Jaynes
164b32b566 Inline documentation for hooks in wp-admin/includes/revision.php. 
Fixes #25283.


git-svn-id: https://develop.svn.wordpress.org/trunk@25587 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 22:44:26 +00:00
Dion Hulse
aa9a8de56b Language Packs: Integrate Language Packs into the Auto-upgrader. See #18200 See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25568 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 09:37:25 +00:00
Andrew Nacin
330a8daccd Add a language pack upgrader class. 
At the conclusion of any upgrade, after the transients are refreshed from the API, pending translations are downloaded and installed to wp-content/languages.

props dd32.
see #18200.


git-svn-id: https://develop.svn.wordpress.org/trunk@25566 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 02:07:51 +00:00
Dion Hulse
455b8d47a9 First pass at documenting the WP_Filesystem methods. This also introduces stubs of the methods into the base class which are documented, which subclasses can override, some methods were cleaned up at the same time. 
See #18476 See #23122. Props kurtpayne, bananastalktome, and, DrewAPicture 


git-svn-id: https://develop.svn.wordpress.org/trunk@25560 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-22 04:43:29 +00:00
Drew Jaynes
05ae44eaca Inline documentation for hooks in wp-admin/includes/ajax-actions.php. 
Fixes #25374.


git-svn-id: https://develop.svn.wordpress.org/trunk@25558 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 20:46:15 +00:00
Drew Jaynes
8c8a0b990c Make the WP_List_Table::months_dropdown() query results filterable. 
Introduces the `months_dropdown_results` filter.

Fixes #17022.


git-svn-id: https://develop.svn.wordpress.org/trunk@25556 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 18:34:26 +00:00
Dion Hulse
f0fa5f821e Add a missing . in the Hook documentation from r25542 See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25543 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 07:01:23 +00:00
Dion Hulse
6048f75b93 WordPress Core Automatic Updates: Add a filter as to whether or not to send the site administrator a summary of executed updates. Props JustinSainton. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25542 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:59:25 +00:00
Dion Hulse
f377693931 When using download_url(), if the resource supplies a Content-MD5 header, verify the downloaded file against it. Fixes #20074 
git-svn-id: https://develop.svn.wordpress.org/trunk@25541 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:53:50 +00:00
Dion Hulse
eb3bee3ba5 Upgrader: Perform a MD5 file verification check on the files during upgrade. This ensures that both a Partial upgrade build can be used, and that all the files were copied into place correctly. 
Props pento for initial patch. Fixes #18201


git-svn-id: https://develop.svn.wordpress.org/trunk@25540 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:48:20 +00:00
Helen Hou-Sandi
76cb40634b Make it possible to filter comment screen by post type; no UI. props johnbillion, c3mdigital. fixes #18596. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25526 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-20 20:15:51 +00:00
Drew Jaynes
ebf3305722 Inline documentation for hooks in wp-admin/includes/plugin-install.php. 
Props naomicbush.
See #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25511 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-20 02:21:44 +00:00
Helen Hou-Sandi
68f34a5d80 Add a class to the bulk actions wrapper div. props nofearinc. fixes #25197. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25509 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 21:00:02 +00:00
Helen Hou-Sandi
c23defe7c3 Restore post formats to bulk editing. props azaozz, SergeyBiryukov, DrewAPicture. fixes #24096. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25505 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 17:46:25 +00:00
Sergey Biryukov
24db2253b3 Some more tweaks for the documentation in wp-admin/includes/ms.php. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25497 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 16:05:21 +00:00
Dion Hulse
f52d0a96af WordPress Core Automatic Updates: Add a post-upgrade summary email to the WordPress install's admin email address. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25496 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 08:45:06 +00:00
Dion Hulse
fb0b86a078 Upgrader: Fix the order of arguements passed to wp_parse_args() in the Upgrader, introduced with [25272]. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25495 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 08:39:51 +00:00
Sergey Biryukov
a4f3fc3489 Update inline documentation for hooks in wp-admin/includes/ms.php. 
props jamescollins.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25486 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 00:04:16 +00:00
Sergey Biryukov
801f56dec2 Clean up the documentation for hooks in wp-admin/includes/plugin.php. 
props DrewAPicture.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25482 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 19:35:10 +00:00
Sergey Biryukov
8834a52e40 Inline documentation for hooks in wp-admin/includes/ms.php. 
props enej, DrewAPicture.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25481 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 18:21:46 +00:00
Sergey Biryukov
7069b5c47c Correct @since for hooks in wp-admin/includes/plugin.php. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25477 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 11:57:18 +00:00
Peter Westwood
e71b7b15cf Inline documentation for hooks in wp-admin/includes/plugin.php 
See #25229 props dllh


git-svn-id: https://develop.svn.wordpress.org/trunk@25474 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 07:37:39 +00:00
Sergey Biryukov
89c1b75ada Deprecate the_attachment_links(), unused since [6910]. props vinod dalvi. fixes #25340. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25472 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 09:07:12 +00:00
Dion Hulse
ea24e2ce0d WordPress Upgrades: When defining the default filesystem permissions for files/directories, base the value on the existing ABSPATH & index.php file permissions - so as to respect the executable bit (if set) and not set global read if not required. 
This sets a minimum permission set to 750 and 640 for directories and files, so any systems requring less permission than that will still need to define the constants themselves. Fixes #20069 


git-svn-id: https://develop.svn.wordpress.org/trunk@25469 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 08:05:23 +00:00
Dion Hulse
ed8f918e4e WordPress Core Automatic Updates: Remove some debug. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25468 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 04:07:35 +00:00
Dion Hulse
d1dcc8cca3 WordPress Core Automatic Updates: Switch from using a transient for locking the upgrade process, to using a site option. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25467 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 02:27:21 +00:00
Andrew Nacin
c89f2e38a8 Add nginx detection to the Permalink Settings screen. 
Introduces got_url_rewrite() and a corresponding filter, which should now be used in lieu of the got_rewrite filter in got_mod_rewrite().

This does not write or even suggest nginx configuration; rather, it prevents nginx from being considered as either Apache or as an unrecognized server.

props johnbillion.
fixes #25098.


git-svn-id: https://develop.svn.wordpress.org/trunk@25456 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 20:06:27 +00:00
Andrew Nacin
fdc9bc6130 Allow callback args to be passed from wp_add_dashboard_widget() to add_meta_box(). 
props jdgrimes.
fixes #25152.


git-svn-id: https://develop.svn.wordpress.org/trunk@25454 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 18:06:05 +00:00
Andrew Nacin
e24a1ac0dc Use get_terms() in the ajax tag search. 
props Chouby.
fixes #25231.


git-svn-id: https://develop.svn.wordpress.org/trunk@25452 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 17:50:16 +00:00
Andrew Nacin
1d80307d5d Multisite blogs table: Convert the archived field from enum to tinyint to match the other status fields. fixes #12832. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25448 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-15 23:11:30 +00:00
Dion Hulse
3ec962dd56 WordPress Core Automatic Updates: Remove an accidental closure which isn't supported in PHP 5.2. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25447 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-15 01:25:56 +00:00
Andrew Nacin
e539910e1a Move to JSON for three api.wordpress.org endpoints. see #25311. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25441 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 19:30:44 +00:00
Scott Taylor
535ae26afd Fix several esoteric errors related to AJAX unit tests for comments: 
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 18:35:43 +00:00
Sergey Biryukov
27d3a78193 Inline documentation for hooks in wp-admin/includes/comment.php. 
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25434 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 01:00:44 +00:00
Scott Taylor
402e61f269 Fix some undefined index notices related to Comment unit tests: 
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25433 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 22:17:51 +00:00
Scott Taylor
ac23d53402 * Avoid notices in tests/ajax/Autosave by bailing early when get_post() returns nothing. 
* Check for the existence of `$_POST['catslist']` before using it in `wp_ajax_autosave()`.

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25430 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 21:21:16 +00:00
Dion Hulse
9c1b30860c Upgrader: Allow plugins to short-circuit the package download. Props rmccue and DrewAPicture. Fixes #22378 
git-svn-id: https://develop.svn.wordpress.org/trunk@25427 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 12:52:28 +00:00
Sergey Biryukov
a57529c720 Avoid a PHP warning in network admin if a constant corresponding to a drop-in is not defined. fixes #25301. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25425 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 09:36:08 +00:00
Dion Hulse
5959a7011b WordPress Core Automatic Updates: Pass the Filesystem path as $context to request_filesystem_credentials(). See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25422 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 06:52:11 +00:00
Dion Hulse
63956aa479 WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25421 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 06:18:16 +00:00
Sergey Biryukov
96d12ddd9d Better alignment for wp_prepare_revisions_for_js() inline docs. see #25283. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25420 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 23:14:55 +00:00
Sergey Biryukov
529c973323 Inline documentation fixes and additions for wp-admin/revision.php and wp-admin/includes/revision.php. 
props adamsilverstein.
see #25283.

git-svn-id: https://develop.svn.wordpress.org/trunk@25419 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 22:58:45 +00:00
Andrew Nacin
bb2908d613 Clear all transients (regardless of expiration) on all database upgrades. see #20316. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25416 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 21:13:18 +00:00
Andrew Nacin
8917f2b3bd Add populate_network_meta filter to populate_network(). 
props jeremyfelt.
fixes #25020.


git-svn-id: https://develop.svn.wordpress.org/trunk@25414 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 20:48:20 +00:00
Andrew Nacin
3631b81545 Fix comma placement in [25179]. 
props gradyetc.
see #15004, fixes #25298.


git-svn-id: https://develop.svn.wordpress.org/trunk@25413 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 20:15:30 +00:00
Helen Hou-Sandi
435c2b5686 Add file size to attachment publish meta box. props desrosj. fixes #25170. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25403 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 15:09:35 +00:00
Sergey Biryukov
a56e83373d Consistently call skin methods in WP_Upgrader. fixes #25254. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25370 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 02:42:10 +00:00
Sergey Biryukov
c05412b16c Fix invalid markup when searching for installed themes. fixes #25288. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25369 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 00:03:01 +00:00
Dion Hulse
ea6da7d5dc Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237 
git-svn-id: https://develop.svn.wordpress.org/trunk@25349 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-11 08:26:57 +00:00
Dion Hulse
47c25b41af Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259 
git-svn-id: https://develop.svn.wordpress.org/trunk@25347 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-11 08:08:35 +00:00
Andrew Nacin
2c0b23557a Ignore user ID post data. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25316 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 17:57:14 +00:00
Scott Taylor
d141191598 Consistently wrap author and excerpt nodes with CDATA in feeds. 
Fixes #18056.



git-svn-id: https://develop.svn.wordpress.org/trunk@25315 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 16:54:16 +00:00
Dion Hulse
4a56e07c75 Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577 
git-svn-id: https://develop.svn.wordpress.org/trunk@25308 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 07:53:15 +00:00
Dion Hulse
30827b47c1 Upgrader: Deprecate a few mostly unused functions, wp_update_plugin(), wp_update_theme(), and, wp_update_core(). 
wp_update_core() was still used, as it was never updated to make use of the newer Skins. Fixes #21874


git-svn-id: https://develop.svn.wordpress.org/trunk@25307 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 06:44:25 +00:00
Dion Hulse
fb20ed8b5b WP_Filesyste: SSH2 PHP Extension support: Fix a case where defining a custom FS_CHMOD_FILE / FS_CHMOD_DIR constant wouldn't take effect due to chmod() failing with a invalid path. Fixes #23589 
git-svn-id: https://develop.svn.wordpress.org/trunk@25306 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 03:05:01 +00:00
Dion Hulse
beaf91c019 WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25305 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 02:54:50 +00:00
Dion Hulse
2f40784d97 WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237 
git-svn-id: https://develop.svn.wordpress.org/trunk@25304 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 02:42:52 +00:00
Helen Hou-Sandi
bde3435a63 Alignment standards for [25296]. props DrewAPicture. see #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25300 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 22:06:21 +00:00
Sergey Biryukov
8e4a6b31cd Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25298 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 18:16:09 +00:00
Helen Hou-Sandi
ed6316d44b Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25297 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 16:19:39 +00:00
Helen Hou-Sandi
e9173ef83b Add media_submitbox_misc_sections and audio_submitbox_misc_sections filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25296 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 16:18:26 +00:00
Scott Taylor
2661cd53fc Use get_the_title() when dealing with post_type-like items in the admin. 
Props nacin, DrewAPicture.
Fixes #14975.



git-svn-id: https://develop.svn.wordpress.org/trunk@25285 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 17:08:00 +00:00
Andrew Nacin
69a949d160 Add new ajax_query_attachments_args filter. 
props alex-ye.
fixes #24285.


git-svn-id: https://develop.svn.wordpress.org/trunk@25279 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 15:17:35 +00:00
Sergey Biryukov
e8daea7de7 Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross. 
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.

git-svn-id: https://develop.svn.wordpress.org/trunk@25277 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 14:09:07 +00:00
Dion Hulse
d9c5265303 WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049 
git-svn-id: https://develop.svn.wordpress.org/trunk@25274 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 08:28:59 +00:00
Dion Hulse
9095e4b866 Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25272 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 01:32:09 +00:00
Scott Taylor
4286692d7d Remove redundant checks in some update functions. Adds some readability/coding standards cleanup. 
Props miqrogroove, azaozz.
Fixes #22828.


git-svn-id: https://develop.svn.wordpress.org/trunk@25256 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 17:04:03 +00:00
Scott Taylor
16ef2c2e36 Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this. 
Props jdgrimes.
See #25160.



git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 16:33:50 +00:00
Scott Taylor
d10b9d32a0 Remove unnecessary checks before setting $wp_settings_* arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional array. 
Props scribu.
Fixes #17884.



git-svn-id: https://develop.svn.wordpress.org/trunk@25240 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 19:06:13 +00:00
Dion Hulse
7c8107734f Core Auto Updates: Add a initial skin to allow capturing the output from the upgrader without displaying it (such as we need during cron calls). 
This has been copied almost verbatim from the automatic-updater plugin with a few style tweaks and additional upgrade-possible check. See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25228 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 07:16:16 +00:00
Dion Hulse
ea02f466c9 Upgrader: Split the UI "skins" out from the main Upgrader file into a seperate file to reduce the length of the files. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25227 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 06:34:38 +00:00
Sergey Biryukov
56731f831d Avoid 'Only variables should be passed by reference' notice on plugin search. props daankortenbach. fixes #25217. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25210 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 13:53:57 +00:00
Sergey Biryukov
8b16c9bba8 Deprecate wp_nav_menu_locations_meta_box(), unused since [23441]. props DrewAPicture. fixes #24942. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25209 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 11:25:16 +00:00
Sergey Biryukov
a82593e4e4 Move get_real_file_to_edit() upper in the file for consistency with the existing order of functions. Some phpdoc fixes and additions. see #23680. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25208 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 11:18:35 +00:00
Sergey Biryukov
6bef163456 Update phpdoc for get_user_to_edit(), get_userdata(), and get_user_by(). props tivnet. fixes #24992. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25204 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 03:24:33 +00:00
Sergey Biryukov
4e75fe1bf1 Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25201 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-01 12:36:45 +00:00
Dion Hulse
b518606d42 Plugin Upgrader: Plugin_Upgrader::upgrade() returns nothing in event of success, every other install(), upgrade() and bulk_upgrade() method returns true, so return true; 
git-svn-id: https://develop.svn.wordpress.org/trunk@25181 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 07:37:32 +00:00
Dion Hulse
e320a48146 Theme Upgrader: Be super-careful and check the contents of the $wp_theme_directories variable before merging it, if someone has changed it directly, or worse, unset it, this could've resulted in the $protected_directories being empty. See [25082] See #22501 
git-svn-id: https://develop.svn.wordpress.org/trunk@25180 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 07:34:24 +00:00
Andrew Nacin
21b61a9e6f Add signup_id primary key to $wpdb->signups, and add better indexes. 
props josephscott, pento, barry.
see #15004.


git-svn-id: https://develop.svn.wordpress.org/trunk@25179 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 04:29:06 +00:00
Andrew Nacin
fba8c3dabe Avoid validating wildcard hostnames in populate_network() when multisite is already activated. 
props jeremyfelt.
fixes #25182.


git-svn-id: https://develop.svn.wordpress.org/trunk@25171 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-29 19:30:46 +00:00
Andrew Nacin
65465e9c88 Don't create an edit link to a non-UI post type in the media list table. 
props johnbillion.
fixes #20453.


git-svn-id: https://develop.svn.wordpress.org/trunk@25140 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 20:48:40 +00:00
Andrew Nacin
d41c30be7a Network Admin: Hide the bulk actions checkbox for the main site. 
props ericlewis.
fixes #24463.


git-svn-id: https://develop.svn.wordpress.org/trunk@25125 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 18:45:30 +00:00
Sergey Biryukov
6edecc378d Avoid displaying multiple instances of the same feature pointers on a single screen. props nacin. fixes #25022 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25117 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-24 22:33:51 +00:00
Sergey Biryukov
107d2b8716 Remove unused variable. props jeremyfelt. fixes #25121. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25098 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-23 00:18:48 +00:00
Andrew Nacin
f57bd31f2d Fix various typos in inline documentation. props nofearinc, fixes #25119. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25094 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 22:00:41 +00:00
Andrew Nacin
0c24a916d4 In the admin, do not use auto-generated Gravatar images for comment authors. 
This makes it easier to recognize Gravatars (or lack thereof) when moderating comments.

props solarissmoke.
fixes #7054.



git-svn-id: https://develop.svn.wordpress.org/trunk@25091 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 20:07:51 +00:00
Helen Hou-Sandi
5ea9e40fed Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25083 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 15:23:41 +00:00
Dion Hulse
2ceaba8b30 Theme Installer/Updater: Handle custom Theme directories when updating themes, and installing new themes. Fixes #22501 
git-svn-id: https://develop.svn.wordpress.org/trunk@25082 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 04:49:06 +00:00
Dion Hulse
ddad24c82c Sanitize the plugin path in _get_plugin_data_markup_translate() to a WP_PLUGIN_DIR-relative path. The function is designed in mind for receiving relative paths, but may be used with a absolute path. 
This change makes the function path-agnostic, and can accept either relative or absolute (converting to relative internally). Fixes #20813


git-svn-id: https://develop.svn.wordpress.org/trunk@25081 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 04:02:13 +00:00
Dion Hulse
ead4efa78a Add a note that the FTP Password will not be stored on the server to the FTP credentials page. Fixes #16492 
git-svn-id: https://develop.svn.wordpress.org/trunk@25071 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-21 07:06:12 +00:00
Dion Hulse
b4f0fbd985 Add a filter on the Plugin and Theme installers table listing API args, this allows for plugins to hook in and add custom args to plugins_api() and themes_api() for the Plugin/Theme listing tabls. Fixes #18169 
git-svn-id: https://develop.svn.wordpress.org/trunk@25070 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-21 06:51:51 +00:00
Dion Hulse
318a1c9c52 WP_Filesystem: Use the FTP_* path override constants during upgrades for prefixed paths, ie. use FTP_BASE for ABSPATH/sub-dir as well as just for ABSPATH/. Props vericgar for initial patch. See #14401 
git-svn-id: https://develop.svn.wordpress.org/trunk@25057 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-20 06:46:37 +00:00
Dion Hulse
e4361d8f96 Check to see if mbstring.func_overload is configured to affect string functions before switching charsets. Props SergeyBiryukov. Fixes #25063 
git-svn-id: https://develop.svn.wordpress.org/trunk@25056 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-20 06:23:48 +00:00
Dion Hulse
c6e43f5327 WP_Upgrader: Don't activate maintenance mode in bulk_upgrade() when no Themes or Plugins are specified. This doesn't affect Core, but rather, plugins who use the upgrade routines and do not do precautionary tests. Props jamescollins. Fixes #24496 
git-svn-id: https://develop.svn.wordpress.org/trunk@25048 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-17 05:35:17 +00:00
Andrew Nacin
81248f6568 In populate_network(), insert the first site as blog_id 1, overriding any auto-increment DB seed. props wpmuguru, fixes #16568. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25038 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 20:07:05 +00:00
Andrew Nacin
ea7196081f Add a maxlength attribute to the post password input, reflecting the current DB field length.\ 
props RayBernard, DrewAPicture.
see #24792.



git-svn-id: https://develop.svn.wordpress.org/trunk@25035 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 19:55:19 +00:00
Ryan Boren
5125650b72 Be consistent with the arguments passed to the theme_action_links filter. Stop passing stylesheet from class-wp-ms-themes-list-table.php. 
Props georgestephanis
fixes #24478


git-svn-id: https://develop.svn.wordpress.org/trunk@25032 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 15:46:08 +00:00
Sergey Biryukov
6c3b030245 Avoid PHP notices in get_sample_permalink() and get_sample_permalink_html(). Remove unused global reference. props ocean90. fixes #25005. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25028 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 16:24:08 +00:00
Dion Hulse
b971127bac Remove the usage of @$_GET and @$_POST and just check to see if the indicies are set. Fixes #22429 
git-svn-id: https://develop.svn.wordpress.org/trunk@25025 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 06:05:54 +00:00
Dion Hulse
51c3faba5d WP_Filesystem: Make WP_Filesystem_Base::search_for_folder() a bit more usable on the command-line when the $verbose mode is used, additionally, bail early from the function rather than repeating itself if the CWD is the root directory already. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25024 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 05:59:36 +00:00
Dominik Schilling (ocean90)
bf8e3cab1e Remove unused cat JavaScript file. props carldanley. fixes #24989. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25020 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-14 15:43:03 +00:00
Jon Cave
38345135a1 Add javascript files deleted in [25013] to $_old_files. See #23486. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25019 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-14 15:18:04 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository. 
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-07 05:25:25 +00:00