sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
24,647 Commits 2 Branches 473 Tags 137 MiB
5b05610ade
Commit Graph

319 Commits

Author SHA1 Message Date
Dion Hulse
34fa8af8bb Core Upgrader: Include an unmodified $wp_version in Core_Upgrader::upgrade(). This protects against cases where the global $wp_version has been modified. See #25772 
git-svn-id: https://develop.svn.wordpress.org/trunk@26017 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 06:22:23 +00:00
Dion Hulse
18e173ae80 Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to. Props nacin. See #25772 for trunk 
git-svn-id: https://develop.svn.wordpress.org/trunk@26016 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 06:19:05 +00:00
Dion Hulse
83754e1636 Remove dead code from the Plugin Upgrader class. Props jdgrimes. Fixes #25470 
git-svn-id: https://develop.svn.wordpress.org/trunk@26015 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 05:47:41 +00:00
Dion Hulse
58e4a21f07 When checking filesystem permissions for core updates, only check the permissions of the files which we need to alter. Props nacin for initial patch. Fixes #25771 for trunk 
git-svn-id: https://develop.svn.wordpress.org/trunk@26014 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 05:42:23 +00:00
Dion Hulse
43d50e9c9e Add a filter to the Background Updates debug email, matches the filter used on the non-debug post-update emails. Props pento. Fixes #25756 
git-svn-id: https://develop.svn.wordpress.org/trunk@26013 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 02:14:34 +00:00
Scott Taylor
5643e3ca17 Pass $args to the export_wp action in export_wp(), which is currently passed no arguments. 
Props nickdaugherty.
Fixes #25574.



git-svn-id: https://develop.svn.wordpress.org/trunk@26011 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 01:26:49 +00:00
Sergey Biryukov
6fa1c89458 Pass comment ID and comment post ID to get_comment_class() in WP_Comments_List_Table::single_row(). 
props drozdz.
fixes #25814.

git-svn-id: https://develop.svn.wordpress.org/trunk@26001 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-04 10:59:58 +00:00
Sergey Biryukov
bc6c0c9b0f Correct @since values for various hooks. fixes #25766. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25991 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-30 03:19:16 +00:00
Andrew Nacin
78f8c980da Use correct variable in WP_Automatic_Updater::send_email(). 
props pento.
see #25757 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25977 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-29 13:45:17 +00:00
Sergey Biryukov
2e50c871ab Avoid a PHP warning in wp_generate_attachment_metadata() if $metadata is not an array. props asakurayoh. fixes #25649. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25968 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-28 16:42:36 +00:00
Sergey Biryukov
267b476885 Fix a copy/paste error in wp_update_theme() description. props Caspie. fixes #25742. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25964 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-28 10:55:50 +00:00
Drew Jaynes
3a26e383ae Inline documentation for hooks in wp-admin/includes/theme.php. 
Props l10n for the initial patch.
Fixes #25732.


git-svn-id: https://develop.svn.wordpress.org/trunk@25961 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-27 22:45:32 +00:00
Andrew Nacin
1694272bff When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning. 
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.

see #25716 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25956 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-27 21:08:25 +00:00
Drew Jaynes
acb441a519 Inline documentation for hooks in wp-admin/includes/schema.php. 
Props johnafish, kpdesign.
Fixes #25498.


git-svn-id: https://develop.svn.wordpress.org/trunk@25938 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-26 20:28:34 +00:00
Drew Jaynes
eef2e83b13 Inline documentation for hooks in wp-admin/includes/nav-menu.php. 
Props Faison.
Fixes #25474.


git-svn-id: https://develop.svn.wordpress.org/trunk@25935 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-26 17:47:33 +00:00
Andrew Nacin
9a2bf56fc3 Avoid a notice for an undefined $checksums variable when updating from pre-3.7 to post-3.7. 
props GaryJ.
fixes #25689 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25915 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-25 20:14:23 +00:00
Andrew Nacin
7508e7c03b Add editimage.min.js to $_old_files. see #24999. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25897 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-24 19:26:11 +00:00
Andrew Nacin
391b22a4de Confirm delete_site_option() exists before calling it during an update. 
This function won't yet exist when updating from 2.7 [sic].

fixes #25682 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25893 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-24 18:17:41 +00:00
Andrew Nacin
9c5420d74d Remove debug code from WP_Automatic_Updater::send_email(). 
props markmcwilliams for initial patch.
see #25678.


git-svn-id: https://develop.svn.wordpress.org/trunk@25891 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-24 01:50:09 +00:00
Andrew Nacin
3d2776d023 Introduce a send_core_update_notification_email filter to control whether to send update notifications. 
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.

This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.

see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25882 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-23 19:46:33 +00:00
Ryan Boren
30f822b8ee Pinking shears 
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-23 14:37:54 +00:00
Andrew Nacin
ff69fb4b8f Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version. 
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.

This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.

fixes #25654.


git-svn-id: https://develop.svn.wordpress.org/trunk@25873 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 21:18:09 +00:00
Andrew Nacin
aab4ffb29d Show the nag we show for a stuck .maintenance file when an auto update failed. 
see #25654.


git-svn-id: https://develop.svn.wordpress.org/trunk@25872 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 21:14:06 +00:00
Andrew Nacin
ddbc271329 "some files" instead of "certain files". Less stuffy. 
props markjaquith.
see #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25871 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 18:40:20 +00:00
Andrew Nacin
f36fbb550c New, better error message when we realize we won't be able to copy a file and continue with the update. 
fixes #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25870 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 18:20:51 +00:00
Andrew Nacin
1a7bfffd0b Only enforce disk free space checks when doing background updates. 
see #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25869 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 18:17:13 +00:00
Andrew Nacin
c87ad6023d Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 17:21:32 +00:00
Andrew Nacin
ea7d0de723 Updates: Disable maintenance mode once we've finished copying files, to minimize disruption. 
props dd32.
fixes #25655.


git-svn-id: https://develop.svn.wordpress.org/trunk@25866 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 17:19:48 +00:00
Andrew Nacin
d0d07cf614 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative. 
props dd32 for initial patch.
fixes #25657.


git-svn-id: https://develop.svn.wordpress.org/trunk@25863 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 09:48:36 +00:00
Andrew Nacin
bce2656e6d Move upgrader_process_complete for core to its proper place in Core_Upgrader. 
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.


git-svn-id: https://develop.svn.wordpress.org/trunk@25861 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 04:36:54 +00:00
Andrew Nacin
597e82e94c Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.) 
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.


git-svn-id: https://develop.svn.wordpress.org/trunk@25859 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-21 22:28:07 +00:00
Andrew Nacin
d96b64c116 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED. 
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25851 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 21:23:43 +00:00
Andrew Nacin
fda5b39db2 Use correct variable. fixes #10787. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25843 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 17:15:36 +00:00
Andrew Nacin
0b22aae62d Notify administrators of successful, failed, and pending core updates. 
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25841 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 16:29:16 +00:00
Andrew Nacin
142d8c3d30 Delete expired transients on database upgrades. 
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.


git-svn-id: https://develop.svn.wordpress.org/trunk@25838 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 07:47:44 +00:00
Andrew Nacin
92c2bc7797 Introduce email templates for automatic background updates. 
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25837 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 06:32:27 +00:00
Andrew Nacin
aa4635548d set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin. 
fixes #25622.


git-svn-id: https://develop.svn.wordpress.org/trunk@25836 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 23:23:42 +00:00
Andrew Nacin
8cb344e237 In automatic background updates, standardize on 'update'. 
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25835 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 23:20:56 +00:00
Dion Hulse
3ce626a96b Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check). 
See #25576, #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25831 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 18:39:04 +00:00
Dion Hulse
d2d9b963a2 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock. 
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25828 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 05:23:35 +00:00
Andrew Nacin
4644bb87f6 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25825 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 04:01:06 +00:00
Andrew Nacin
c39143fd2e Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods. 
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25823 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 00:54:15 +00:00
Dion Hulse
d0bd68cf5f Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25822 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 00:11:25 +00:00
Dion Hulse
d5aba84213 Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25818 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 22:26:47 +00:00
Dion Hulse
853c9a50bd When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25817 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 19:47:21 +00:00
Andrew Nacin
977ca48a58 Merge the should_auto_update() and can_auto_update() methods. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25815 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 19:34:05 +00:00
Dion Hulse
aa5c907e40 Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25812 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 17:06:58 +00:00
Dion Hulse
549029393f Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath. 
See #18201


git-svn-id: https://develop.svn.wordpress.org/trunk@25811 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 15:19:59 +00:00
Andrew Nacin
e192eb396e Include translations in the update bubbles (as +1 if there are any). see #18200. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25810 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 14:33:21 +00:00
Dion Hulse
96aa66a924 Remove the no longer used Headerless_Upgrader_Skin class, it's been replaced by Language_Pack_Upgrader_Skin. 
See #18200, [25806]


git-svn-id: https://develop.svn.wordpress.org/trunk@25807 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:18:12 +00:00
Dion Hulse
ddaaa6d88a Language Packs: Many many fixes such as: 
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200, #22704



git-svn-id: https://develop.svn.wordpress.org/trunk@25806 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:14:29 +00:00
Andrew Nacin
4f7112000f Avoid numerous potential PHP warnings when dealing with the pre-r25801 get_core_checksums() return value. 
Warnings included current(), filestat(), and md5_file().

see #18201. see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25805 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:01:12 +00:00
Andrew Nacin
867f084ca0 Significantly simplify get_core_checksums(), as the caching and chunking was causing too much grief. 
Make sure we only do our pre-flight is_writable check when the file exists.

see #18201. see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25801 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 23:02:28 +00:00
Andrew Nacin
14b83f44f1 Use correct variable. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25800 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 22:06:08 +00:00
Andrew Nacin
3b724d5082 Remove accidental debug cruft in [25780]. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25799 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 21:24:01 +00:00
Andrew Nacin
1e8729b5c1 Avoid our pre-flight writable checks if get_core_checksums() doesn't exist yet. 
Thus, it will not work for 3.6 => 3.7, only 3.7+.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25798 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 20:34:02 +00:00
Andrew Nacin
0a284a4d5c Only add error data to the files_not_writable WP_Error if the install already has [25775] and [25796] applied. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25797 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 20:00:01 +00:00
Andrew Nacin
55d176020b In show_message(), only print error data if it is a string. 
see #25576, [25775].


git-svn-id: https://develop.svn.wordpress.org/trunk@25796 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:50:48 +00:00
Andrew Nacin
204ca72a66 Core Updates: Verify that all files we're about to copy are actually writable, when using the direct transport. 
Once we begin to copy core files, all bets are off. This allows us to fail early when we'll otherwise need to stop midway through due to permissions issues, which is a particularly bad problem when only some files have permissions issues.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25794 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:17:56 +00:00
Andrew Nacin
c72ba036cf Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir(). 
This occurs when we can't copy a file. We chmod it and try again.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25793 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:13:33 +00:00
Dion Hulse
fa79184a7d Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/. 
My bad. See #22704, [25781].


git-svn-id: https://develop.svn.wordpress.org/trunk@25787 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 14:54:29 +00:00
Andrew Nacin
2eebc47254 Hide auto updates from update-core.php directly in get_core_updates(). see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25783 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 05:06:35 +00:00
Andrew Nacin
85d32ce873 Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback. 
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25782 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 02:58:07 +00:00
Andrew Nacin
1918e828da Automatic updates: Include error data in the follow-up API request. 
props dd32.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25781 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 23:32:47 +00:00
Andrew Nacin
3eac3d0380 Parse absolute paths out of error data. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25780 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 22:24:28 +00:00
Dion Hulse
b492ae85f8 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return. 
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25779 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:54:33 +00:00
Andrew Nacin
67c80dae13 Account for the possible failure of disk_free_space() in update_core(). 
see #22704, #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25778 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:14:39 +00:00
Andrew Nacin
d6a1b681d3 Auto updates: Only attempt a roll back when we've hit a critical error code. 
Specifically, this means when we've failed in copying files.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25777 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:02:46 +00:00
Andrew Nacin
b8efab15d8 Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files. 
see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25776 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:57:28 +00:00
Andrew Nacin
47e85a9b54 In the upgrader, only print additional error data if it is a string. 
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25775 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:19:52 +00:00
Andrew Nacin
5db3863d12 In unzip_file(), confirm we have enough available disk space before extracting. 
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25774 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:14:13 +00:00
Andrew Nacin
bd26f54af2 More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25772 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 19:37:53 +00:00
Andrew Nacin
7bf44580a9 Add explicit link to the installation being updated in debugging emails. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25770 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-12 20:17:20 +00:00
Andrew Nacin
9eff9eaebe Silence possible warnings from is_dir(). fixes #25572. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25764 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-11 17:10:18 +00:00
Andrew Nacin
2e605e76c6 Refine error codes throughout the upgrader so we can better detect at what stage updates fail. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25763 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-11 16:05:13 +00:00
Andrew Nacin
627b25bf50 Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25755 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 14:45:55 +00:00
Dion Hulse
f0571c02b7 After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25752 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 01:56:44 +00:00
Dion Hulse
e03279e8b0 In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful. 
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25750 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 01:31:22 +00:00
Andrew Nacin
12cb3a353e Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height. 
props plocha.
fixes #25038.


git-svn-id: https://develop.svn.wordpress.org/trunk@25744 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 19:06:56 +00:00
Helen Hou-Sandi
99df61b666 Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25741 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 18:46:34 +00:00
Dion Hulse
28736216f3 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069 
git-svn-id: https://develop.svn.wordpress.org/trunk@25739 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 16:46:31 +00:00
Scott Taylor
4aa0066736 Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video in attachment_submitbox_metadata(). 
Props kovshenin.
See #23926.



git-svn-id: https://develop.svn.wordpress.org/trunk@25727 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-08 15:31:32 +00:00
Andrew Nacin
04f053ce0c Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping. 
props SergeyBiryukov.
see #25023.
for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25719 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-07 18:34:35 +00:00
Drew Jaynes
2a2587c6dc Inline documentation for hooks in wp-admin/includes/bookmark.php. 
Props johnafish, kpdesign.
Fixes #25494.


git-svn-id: https://develop.svn.wordpress.org/trunk@25706 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-07 02:18:20 +00:00
Andrew Nacin
40ea01d759 Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25700 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 15:45:09 +00:00
Andrew Nacin
0286d7030d Don't modify post_author during a quick edit when the post type doesn't support authors. 
props ocean90.
fixes #16645.


git-svn-id: https://develop.svn.wordpress.org/trunk@25698 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 13:14:06 +00:00
Andrew Nacin
9f23f85ae2 Run _fix_attachment_links() when post_status is future or private in addition to publish. 
Fixes regression caused by [20308].

props jond3r.
fixes #25268.


git-svn-id: https://develop.svn.wordpress.org/trunk@25697 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 12:55:38 +00:00
Andrew Nacin
352ff49768 Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid. 
props garyc40, wonderboymusic.
fixes #14578.


git-svn-id: https://develop.svn.wordpress.org/trunk@25695 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 10:55:42 +00:00
Andrew Nacin
c0fb231f92 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override. 
props azaozz.
fixes #24930.


git-svn-id: https://develop.svn.wordpress.org/trunk@25694 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 10:45:25 +00:00
Andrew Nacin
1b37564f35 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25691 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-05 10:58:20 +00:00
Andrew Nacin
a2c2641419 Avoid counting auto-drafts in sticky. 
props nofearinc.
fixes #25127.


git-svn-id: https://develop.svn.wordpress.org/trunk@25678 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-03 01:15:30 +00:00
Andrew Nacin
635a1249f5 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses. 
props creativeinfusion.
fixes #24818.


git-svn-id: https://develop.svn.wordpress.org/trunk@25676 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-03 00:59:12 +00:00
Andrew Nacin
df647346b1 Don't use a double negative. 
props TobiasBg.
fixes #18201.


git-svn-id: https://develop.svn.wordpress.org/trunk@25674 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:49:34 +00:00
Andrew Nacin
69a17e3469 Links manager: Restrict field length based on DB schema. 
props solarissmoke, vinod-dalvi.
fixes #17296, #12264.


git-svn-id: https://develop.svn.wordpress.org/trunk@25670 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:10:24 +00:00
Dominik Schilling (ocean90)
6311fbbfdb Replace use of global $user_ID in favor of get_current_user_id(). fixes #25372. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25669 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:09:52 +00:00
Andrew Nacin
212dba1113 Show a proper error message on the dashboard when the current theme is broken. 
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.

Clean up broken/ugly "alt" row styling when we are displaying broken themes.

props johnbillion for initial patch.
fixes #21670.


git-svn-id: https://develop.svn.wordpress.org/trunk@25666 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 20:49:59 +00:00
Scott Taylor
a27234c898 Rather than adding a taxonomy arg to get_category(), convert all uses of get_category() in core to get_term(). By doing so, we negate the need to call _make_cat_compat() in a few places that are only looking for a single property. 
Fixes #8722.



git-svn-id: https://develop.svn.wordpress.org/trunk@25662 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 19:58:50 +00:00
Andrew Nacin
64d3d53838 More string cleanups. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25658 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 18:50:45 +00:00
Andrew Nacin
fc97814a23 This error message should have a period. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25656 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 17:44:09 +00:00
Andrew Nacin
49e7cf1a30 Rollback is not a verb. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25655 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 17:43:15 +00:00
Dion Hulse
6d29f14560 Automatic Updates: Remove some debug from [25649] See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25651 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:29:19 +00:00
Dion Hulse
3fa23828e3 Automatic Updates: Disable Automatic updates for Mercurial(HG) and Bazaar(bzr) version control systems in addition to Git and SVN. Props jamescollins. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25650 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:24:06 +00:00
Dion Hulse
05a01e5964 Automatic Updates: Add a rollback functionality upon installation failure, the rollback package will be available for partial-updates for automatic updates and be similar to our existing partial builds (but in reverse). 
A further iteration of this is to also detect whitescreens (fatals) after a auto update, and trigger the rollback for that too.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25649 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:20:35 +00:00
Dion Hulse
f1928e42bf MD5 file verification: Prevent md5_file() warnings when files don't exist, additionally, don't verify wp-content files as they can be updated separately, as well as WP_CONTENT_DIR being set elsewhere. See #22704 See #18201 
git-svn-id: https://develop.svn.wordpress.org/trunk@25648 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-29 23:07:59 +00:00
Dion Hulse
fefaa807e9 Automatic Updates: Skip doing the sanity checking MD5 before deciding if we should use a partial build or not, This change means we always use a partial build for automatic updates. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25647 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-29 22:59:46 +00:00
Drew Jaynes
78d93bfac3 Improve inline documentation for Walker_Nav_Menu, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist. 
Includes previously undocumented parameters.

See #23406.


git-svn-id: https://develop.svn.wordpress.org/trunk@25643 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 21:01:54 +00:00
Drew Jaynes
346d71fdbd Inline documentation for Walker_Category_Checklist. 
See #23406.


git-svn-id: https://develop.svn.wordpress.org/trunk@25642 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 18:07:02 +00:00
Andrew Nacin
c3a6047584 Fix strict notice. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25635 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 06:32:14 +00:00
Andrew Nacin
ed31cbfab1 Changes to automatic background updates in preparation for Beta 1. 
* Show a notice for beta testers on update-core.php explaining the status of their install. Three possibilities: auto updates are enabled, auto updates are disabled because the install doesn't support SSL HTTP requests, and auto updates are disabled because it is a VCS checkout.
 * Improve the output of the email, for maximum debugging potential. Failures are clearly labeled and the email leads testers to the support forums and Trac.
 * Try to create wp-content/languages in the upgrader if it doesn't exist. Our mkdir isn't recursive, so trying to create wp-content/languages/plugins could fail.
 * Abstract out version control checkout determination into a public method. The filter is now auto_upgrade_is_vcs_checkout, still subject to change.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25633 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-27 23:20:08 +00:00
Drew Jaynes
8a3df7d4b4 Inline documentation for hooks in wp-admin/includes/class-wp-plugin-install-list-table.php. 
Props naomicbush.
Fixes #25357.


git-svn-id: https://develop.svn.wordpress.org/trunk@25630 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-26 02:47:44 +00:00
Helen Hou-Sandi
ab117ae99c Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25608 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 20:22:24 +00:00
Andrew Nacin
34e9dc9f06 Introduce wp_get_user_contact_methods() as a public version of _wp_get_user_contactmethods. 
props johnnyb.
fixes #24273.


git-svn-id: https://develop.svn.wordpress.org/trunk@25606 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 18:13:18 +00:00
Dion Hulse
e4a523977f Automatic Updates: Correct a typo of a constant, s/DISABLE_FILE_MODS/DISALLOW_FILE_MODS/. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25599 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 07:15:58 +00:00
Dion Hulse
c8251ec989 Automatic Core Updates: Enable Core Automatic Updates for Security releases, Development nightly releases, and, Language packs. See #22704 
For more information on Automatic Core Updates, See #22704 and http://wp.me/p2AvED-1Lo



git-svn-id: https://develop.svn.wordpress.org/trunk@25598 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 03:35:53 +00:00
Helen Hou-Sandi
9ac7b0ce32 Saner CSS for row actions - now we can just target .row-actions instead of both .row-actions and .row-actions-visible. CSS for .row-actions-visible remains for now due to usage in plugins. Visibility is controlled by toggling a .visible class. fixes #25403. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25592 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 01:53:08 +00:00
Andrew Nacin
d420b71d52 Ignore unauthorized meta keys in meta_form(). fixes #18786. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25591 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 01:30:31 +00:00
Drew Jaynes
164b32b566 Inline documentation for hooks in wp-admin/includes/revision.php. 
Fixes #25283.


git-svn-id: https://develop.svn.wordpress.org/trunk@25587 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 22:44:26 +00:00
Dion Hulse
aa9a8de56b Language Packs: Integrate Language Packs into the Auto-upgrader. See #18200 See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25568 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 09:37:25 +00:00
Andrew Nacin
330a8daccd Add a language pack upgrader class. 
At the conclusion of any upgrade, after the transients are refreshed from the API, pending translations are downloaded and installed to wp-content/languages.

props dd32.
see #18200.


git-svn-id: https://develop.svn.wordpress.org/trunk@25566 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 02:07:51 +00:00
Dion Hulse
455b8d47a9 First pass at documenting the WP_Filesystem methods. This also introduces stubs of the methods into the base class which are documented, which subclasses can override, some methods were cleaned up at the same time. 
See #18476 See #23122. Props kurtpayne, bananastalktome, and, DrewAPicture 


git-svn-id: https://develop.svn.wordpress.org/trunk@25560 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-22 04:43:29 +00:00
Drew Jaynes
05ae44eaca Inline documentation for hooks in wp-admin/includes/ajax-actions.php. 
Fixes #25374.


git-svn-id: https://develop.svn.wordpress.org/trunk@25558 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 20:46:15 +00:00
Drew Jaynes
8c8a0b990c Make the WP_List_Table::months_dropdown() query results filterable. 
Introduces the `months_dropdown_results` filter.

Fixes #17022.


git-svn-id: https://develop.svn.wordpress.org/trunk@25556 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 18:34:26 +00:00
Dion Hulse
f0fa5f821e Add a missing . in the Hook documentation from r25542 See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25543 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 07:01:23 +00:00
Dion Hulse
6048f75b93 WordPress Core Automatic Updates: Add a filter as to whether or not to send the site administrator a summary of executed updates. Props JustinSainton. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25542 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:59:25 +00:00
Dion Hulse
f377693931 When using download_url(), if the resource supplies a Content-MD5 header, verify the downloaded file against it. Fixes #20074 
git-svn-id: https://develop.svn.wordpress.org/trunk@25541 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:53:50 +00:00
Dion Hulse
eb3bee3ba5 Upgrader: Perform a MD5 file verification check on the files during upgrade. This ensures that both a Partial upgrade build can be used, and that all the files were copied into place correctly. 
Props pento for initial patch. Fixes #18201


git-svn-id: https://develop.svn.wordpress.org/trunk@25540 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:48:20 +00:00
Helen Hou-Sandi
76cb40634b Make it possible to filter comment screen by post type; no UI. props johnbillion, c3mdigital. fixes #18596. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25526 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-20 20:15:51 +00:00
Drew Jaynes
ebf3305722 Inline documentation for hooks in wp-admin/includes/plugin-install.php. 
Props naomicbush.
See #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25511 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-20 02:21:44 +00:00
Helen Hou-Sandi
68f34a5d80 Add a class to the bulk actions wrapper div. props nofearinc. fixes #25197. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25509 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 21:00:02 +00:00
Helen Hou-Sandi
c23defe7c3 Restore post formats to bulk editing. props azaozz, SergeyBiryukov, DrewAPicture. fixes #24096. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25505 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 17:46:25 +00:00
Sergey Biryukov
24db2253b3 Some more tweaks for the documentation in wp-admin/includes/ms.php. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25497 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 16:05:21 +00:00
Dion Hulse
f52d0a96af WordPress Core Automatic Updates: Add a post-upgrade summary email to the WordPress install's admin email address. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25496 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 08:45:06 +00:00
Dion Hulse
fb0b86a078 Upgrader: Fix the order of arguements passed to wp_parse_args() in the Upgrader, introduced with [25272]. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25495 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 08:39:51 +00:00
Sergey Biryukov
a4f3fc3489 Update inline documentation for hooks in wp-admin/includes/ms.php. 
props jamescollins.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25486 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 00:04:16 +00:00
Sergey Biryukov
801f56dec2 Clean up the documentation for hooks in wp-admin/includes/plugin.php. 
props DrewAPicture.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25482 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 19:35:10 +00:00
Sergey Biryukov
8834a52e40 Inline documentation for hooks in wp-admin/includes/ms.php. 
props enej, DrewAPicture.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25481 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 18:21:46 +00:00
Sergey Biryukov
7069b5c47c Correct @since for hooks in wp-admin/includes/plugin.php. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25477 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 11:57:18 +00:00
Peter Westwood
e71b7b15cf Inline documentation for hooks in wp-admin/includes/plugin.php 
See #25229 props dllh


git-svn-id: https://develop.svn.wordpress.org/trunk@25474 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 07:37:39 +00:00
Sergey Biryukov
89c1b75ada Deprecate the_attachment_links(), unused since [6910]. props vinod dalvi. fixes #25340. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25472 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 09:07:12 +00:00
Dion Hulse
ea24e2ce0d WordPress Upgrades: When defining the default filesystem permissions for files/directories, base the value on the existing ABSPATH & index.php file permissions - so as to respect the executable bit (if set) and not set global read if not required. 
This sets a minimum permission set to 750 and 640 for directories and files, so any systems requring less permission than that will still need to define the constants themselves. Fixes #20069 


git-svn-id: https://develop.svn.wordpress.org/trunk@25469 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 08:05:23 +00:00
Dion Hulse
ed8f918e4e WordPress Core Automatic Updates: Remove some debug. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25468 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 04:07:35 +00:00
Dion Hulse
d1dcc8cca3 WordPress Core Automatic Updates: Switch from using a transient for locking the upgrade process, to using a site option. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25467 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 02:27:21 +00:00
Andrew Nacin
c89f2e38a8 Add nginx detection to the Permalink Settings screen. 
Introduces got_url_rewrite() and a corresponding filter, which should now be used in lieu of the got_rewrite filter in got_mod_rewrite().

This does not write or even suggest nginx configuration; rather, it prevents nginx from being considered as either Apache or as an unrecognized server.

props johnbillion.
fixes #25098.


git-svn-id: https://develop.svn.wordpress.org/trunk@25456 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 20:06:27 +00:00
Andrew Nacin
fdc9bc6130 Allow callback args to be passed from wp_add_dashboard_widget() to add_meta_box(). 
props jdgrimes.
fixes #25152.


git-svn-id: https://develop.svn.wordpress.org/trunk@25454 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 18:06:05 +00:00
Andrew Nacin
e24a1ac0dc Use get_terms() in the ajax tag search. 
props Chouby.
fixes #25231.


git-svn-id: https://develop.svn.wordpress.org/trunk@25452 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 17:50:16 +00:00
Andrew Nacin
1d80307d5d Multisite blogs table: Convert the archived field from enum to tinyint to match the other status fields. fixes #12832. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25448 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-15 23:11:30 +00:00
Dion Hulse
3ec962dd56 WordPress Core Automatic Updates: Remove an accidental closure which isn't supported in PHP 5.2. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25447 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-15 01:25:56 +00:00
Andrew Nacin
e539910e1a Move to JSON for three api.wordpress.org endpoints. see #25311. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25441 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 19:30:44 +00:00
Scott Taylor
535ae26afd Fix several esoteric errors related to AJAX unit tests for comments: 
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 18:35:43 +00:00
Sergey Biryukov
27d3a78193 Inline documentation for hooks in wp-admin/includes/comment.php. 
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25434 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 01:00:44 +00:00