Commit Graph

40487 Commits

Author SHA1 Message Date
Andrea Fercia
5c91f0d75b Accessibility: Login and Registration: Improve the invalid username and invalid email messages.
- explicitly informs users they can use their email to log in as an alternative to their username and vice-versa
- shows the `Lost your password?` link only when an wrong password has been entered
- uses a more appropriate copy by changing "invalid" to "unknown"
- removes the all caps `ERROR`

Props subrataemfluence, zalak151291, ryokuhi, SergeyBiryukov, audrasjb, joedolson, marybaum, ramiy, markjaquith, chanthaboune, afercia.
Fixes #43037.


git-svn-id: https://develop.svn.wordpress.org/trunk@46417 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-07 11:52:32 +00:00
Aaron Jorbin
2215a9bbb3 External Libraries: Fix PHP 7.4 compatibility issue in the Requests library.
Moves https://github.com/rmccue/Requests/pull/370 into WordPress.

Previous [46258].

See #47746.


git-svn-id: https://develop.svn.wordpress.org/trunk@46416 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 17:12:23 +00:00
Sergey Biryukov
a59b9dd39e Coding Standards: Fix WPCS issues in WP_Widget_Links and WP_Widget_Pages.
Props itowhid06.
Fixes #48228.

git-svn-id: https://develop.svn.wordpress.org/trunk@46415 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 15:26:42 +00:00
Sergey Biryukov
3a06234fe4 Tests: Use a consistent group for nav menu tests.
Fixes #48230.

git-svn-id: https://develop.svn.wordpress.org/trunk@46414 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 15:12:42 +00:00
Sergey Biryukov
f6267a04ee Menus: In Walker_Nav_Menu, Walker_Category, and Walker_Page, properly output link attributes having a legitimate "empty" value, for example an HTML data attribute with a value of zero (0).
Props nevma, AkSDvP, greenshady, SergeyBiryukov.
Fixes #47720.

git-svn-id: https://develop.svn.wordpress.org/trunk@46413 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 15:04:18 +00:00
Jake Spurlock
ed1a53588f Privacy: Ensure that sending email, and remove data follow the same user experience.
Both personal data request processes should follow the same convention.

Fixes: #43974.
Props: garrett-eclipse, kjellr, Kerfred, birgire, marybaum, SergeyBiryukov.




git-svn-id: https://develop.svn.wordpress.org/trunk@46412 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 06:54:13 +00:00
Jake Spurlock
de0efbb825 Administration: Add a max-width to the Privacy Policy Page dropdown.
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.

Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.


git-svn-id: https://develop.svn.wordpress.org/trunk@46411 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 06:40:36 +00:00
Sergey Biryukov
e2b7892a3e Docs: Format comments in wp-admin/includes/plugin.php as per the documentation standards.
Props dkarfa.
Fixes #48191.

git-svn-id: https://develop.svn.wordpress.org/trunk@46410 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-06 02:21:42 +00:00
Aaron Jorbin
2c5032e29d Build/Test: Update Grunt Uglify options
Follow up to [46408]

Sometimes you need to take documentation literally. And sometimes you need to take it seriously. Deprecations and replacements in uglify are a case where I took them literally and should have taken them seriously.

See #48203.



git-svn-id: https://develop.svn.wordpress.org/trunk@46409 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 21:59:32 +00:00
Aaron Jorbin
3f9927d3ab Build/Test: Bump devDependencies for WordPress 5.3
This upgrades a number of devDependencies.  Some of these include changes to how the tasks are configured.

Uglify: There are deprecated options from 2.x to 4.x, see: https://github.com/gruntjs/grunt-contrib-uglify#options

Autoprefixer: Browserslist now warns when passing in the browser list, so that is put into package.json

As with most changes to uglify, this changes every minified JS file.

Fixes #48203.




git-svn-id: https://develop.svn.wordpress.org/trunk@46408 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 19:47:04 +00:00
Sergey Biryukov
f6357458f4 Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields.
Props garrett-eclipse, dkarfa.
Fixes #48188.

git-svn-id: https://develop.svn.wordpress.org/trunk@46405 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 15:40:31 +00:00
Aaron Jorbin
e963c18719 Build/Test tools: Update grunt-contrib-imagemin and run it
Smaller images are good, so is not having npm vulnerabilities.

See #48203.
Fixes #48206.
Props whyisjake, netweb.



git-svn-id: https://develop.svn.wordpress.org/trunk@46404 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 14:19:20 +00:00
Aaron Jorbin
269c8baa33 Build/Test Tools: Fork and Update grunt-replace
The version of grunt replace that is bundled in core is using an outdated version of lodash that is bringing 2 low, 3 high, and 1 critical issue. This package is currently abandoned. There is a community forked version, but that is also harboring some similar security issues.

This switches to a fork by @whyisjake and causes no change to the build.

See #48203.
Fixes #48217.
Props whyisjake, netweb for testing.



git-svn-id: https://develop.svn.wordpress.org/trunk@46403 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 13:47:52 +00:00
Sergey Biryukov
04293be9e8 Site Health: Improve the wording for UTF8MB4 test description.
Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans.
Fixes #48044.

git-svn-id: https://develop.svn.wordpress.org/trunk@46402 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 02:38:14 +00:00
Sergey Biryukov
21de64fc34 Customize: Remove duplicate attr_title assignment in api.Menus.MenuItemControl.renderContent().
See #47838.

git-svn-id: https://develop.svn.wordpress.org/trunk@46401 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 02:31:14 +00:00
Sergey Biryukov
e99e14570e Filesystem API: Use strict type check in the in_array() call for the $skip_list parameter in copy_dir() and _copy_dir().
This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped.

Props codex-m.
Fixes #46581.

git-svn-id: https://develop.svn.wordpress.org/trunk@46400 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 02:15:13 +00:00
SergeyBiryukov
ef942c65bb Docs: Correct formatting of the @return value description in _wp_handle_upload().
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46399 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 02:08:01 +00:00
Sergey Biryukov
840a03335f Docs: Add missing documentation for the first parameter of the big_image_size_threshold filter.
Props dkarfa, desrosj, earnjam.
Fixes #48214.

git-svn-id: https://develop.svn.wordpress.org/trunk@46398 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 01:30:00 +00:00
Sergey Biryukov
c3c0007121 Emoji: Revert [46393] pending test failure investigation.
See #46537.

git-svn-id: https://develop.svn.wordpress.org/trunk@46397 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 00:59:50 +00:00
Sergey Biryukov
0200a429c7 Comments: Remove a one-time variable in wp_rel_nofollow() and wp_rel_ugc().
See #48022.

git-svn-id: https://develop.svn.wordpress.org/trunk@46396 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 00:55:48 +00:00
Sergey Biryukov
56b6b1e803 Themes: In get_theme_mod(), only run the sprintf() replacement on the default value if there's a string format pattern found in the value.
This prevents standalone percent symbols from being stripped out, e.g. in a default value like `100%`.

Props aristath, kuus, moonomo, westonruter, davetgreen, daviedR, katielgc, noisysocks, SergeyBiryukov.
Fixes #34290.

git-svn-id: https://develop.svn.wordpress.org/trunk@46395 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 00:53:39 +00:00
Sergey Biryukov
1be6c41ada Docs: Improve documentation for get_theme_mod() and set_theme_mod().
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46394 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-05 00:39:04 +00:00
Sergey Biryukov
c411aad31b Emoji: Stop emoji replacement from happening inside CodeMirror instances, and clean up some logic in the MutationObserver.
Props pento, hirofumi2012, davidbaumwald.
Fixes #46537.

git-svn-id: https://develop.svn.wordpress.org/trunk@46393 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 23:28:22 +00:00
Sergey Biryukov
0e2b212b57 Themes: Bring default values for get_theme_root(), get_theme_root_uri(), wp_get_theme(), and wp_customize_url() in line with the documentation.
Reverts [46327].

Fixes #44397.

git-svn-id: https://develop.svn.wordpress.org/trunk@46392 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 23:20:01 +00:00
Sergey Biryukov
c2bcdea8c9 Docs: Add missing description for $comment global.
Props immeet94, mukesh27.
Fixes #46928. See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46391 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 22:18:11 +00:00
Sergey Biryukov
08ff597054 I18N: Add missing comma in a translator comment.
See #47515.

git-svn-id: https://develop.svn.wordpress.org/trunk@46390 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 22:08:34 +00:00
Dominik Schilling
84dc68a77f Customize: Prevent breaking the customizer when site title contains templating syntax.
When the site title is inside an underscore template, syntax defined in `wp.template` like `{{ }}` is treated as special characters and will make Underscore treat it as data to be compiled/rendered.

Props pierlo, donmhico.
Fixes #46863.

git-svn-id: https://develop.svn.wordpress.org/trunk@46389 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 21:58:48 +00:00
Dominik Schilling
25ba9074cc QUnit: Include script dependencies for wp-a11y script to fix a TypeError.
Also, add missing message argument to Customizer notifications to ensure tests are passing.

Fixes #45066.

git-svn-id: https://develop.svn.wordpress.org/trunk@46388 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 21:19:17 +00:00
Dominik Schilling
a468719eb9 I18N: Fix translator comment for a themes list table string with numbered placeholders.
Props garrett-eclipse.
Fixes #47515.

git-svn-id: https://develop.svn.wordpress.org/trunk@46387 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 20:19:11 +00:00
Dominik Schilling
0b3bc89aba Docs: Convert 'Block Editor' to lowercase.
Props garrett-eclipse.
Fixes #45634.

git-svn-id: https://develop.svn.wordpress.org/trunk@46386 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 20:11:20 +00:00
Dominik Schilling
c7bd227390 Networks and Sites: Improve newly added strings for i18n.
* Remove unnecessary numbered placeholders.
* Add context to "All" and "Spam" status.
* Add translator comments.

Props pedromendonca.
Fixes #48210.

git-svn-id: https://develop.svn.wordpress.org/trunk@46385 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 19:57:08 +00:00
Jonathan Desrosiers
f183dd84f1 Networks and Sites: Fix issues processing additional fields displayed for the Sites list table.
This prevents a `The link you followed has expired.` error when using a filter and now uses `$_POST` instead of `$_GET` to capture all form values.

Props pbiron.
Fixes #45954.

git-svn-id: https://develop.svn.wordpress.org/trunk@46384 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-04 14:31:05 +00:00
Sergey Biryukov
17765e9e76 Docs: Clarify default value for the $link parameter in edit_tag_link(), edit_term_link(), and edit_bookmark_link().
Props atachibana.
Fixes #48109.

git-svn-id: https://develop.svn.wordpress.org/trunk@46383 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 23:11:20 +00:00
Andrew Ozz
5e0904cf67 Upload: Fix the method used to create image sub-sizes when uploading fails with a PHP fatal error. Use a custom header to send the new attachment post ID even in HTTP 500 responses instead of an upload reference sent by the client. Also add another cap check and remove the action when deleting an attachment post during a failed upload cleanup.
Props timothyblynjacobs, clorith, azaozz.
Fixes #48200.

git-svn-id: https://develop.svn.wordpress.org/trunk@46382 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 21:00:10 +00:00
Jonathan Desrosiers
7c1662cba0 Docs: Fix code example for removing internal pointers.
Props daleharrison, swissspidy, garrett-eclipse, luciano-croce, jrf, desrosj.
Fixes #45529.

git-svn-id: https://develop.svn.wordpress.org/trunk@46381 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 20:38:08 +00:00
Jonathan Desrosiers
271fc0d151 Menus: Fix typo in the class attribute for the hidden title field in Walker_Nav_Menu_Checklist.
Each item that `Walker_Nav_Menu_Checklist` displays is accompanied by several hidden `<input/>` fields that specify default values for each item when added to a menu. These values are passed in JavaScript to the AJAX call triggered when an item is added to a menu.

The hidden field for the title attribute field incorrectly had an underscore instead of a hyphen. Because of this, it was impossible to supply a default value for the Title Attribute field of a nav menu item.

Props yanngarcia, davidbaumwald.
See #47838.

git-svn-id: https://develop.svn.wordpress.org/trunk@46380 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 20:02:28 +00:00
Joe McGill
5a2c04c7a8 Media: Ensure medialement scripts are loaded in the footer.
This fixes a regression in [41877] which caused `mediaelement` scripts to load in the header.

Props Themezly.
Fixes #44484.


git-svn-id: https://develop.svn.wordpress.org/trunk@46379 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 16:05:14 +00:00
Jonathan Desrosiers
f13714d9d1 General: Patch PHMailer for PHP 7.4 compatibility.
This patches the PHPMailer library in Core to be PHP 7.4 compatible by adding a version check before calling `get_magic_quotes_runtime()`.

Props ayeshrajans, jrf.
See #47783.

git-svn-id: https://develop.svn.wordpress.org/trunk@46378 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 15:44:36 +00:00
Jonathan Desrosiers
80b4dbf0d0 Docs: Add missing @deprecated tags.
Follow up to [46205-46206,46208].

Props jrf.
See #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46377 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 14:47:17 +00:00
Joe McGill
0c66e65b42 Media: Improve documentation for add_image_size()
This improves the description of the `$crop` parameter to clarify behavior.

Props nikolastoqnow, ketuchetan, audrasjb, killua99, pierlo.
Fixes #42463.



git-svn-id: https://develop.svn.wordpress.org/trunk@46376 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 14:46:46 +00:00
Andrea Fercia
37cdffd3cc Accessibility: Media: Add more headings in the Media Modal.
Headings are the predominant mechanism for screen reader users to find information in a page. They also help all users to better identify the main sections of user interfaces.

- adds three new headings within the media modal 
- improves plural form translation for "item selected" by using `wp.i18n`
- horizontally centers the media modal menu in the responsive view

Props kjellr, karmatosed, melchoyce, afercia.
See #47149.
Fixes #47610.


git-svn-id: https://develop.svn.wordpress.org/trunk@46375 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-03 12:09:31 +00:00
Sergey Biryukov
ee03b05605 Privacy: Remove unused $wpdb global in WP_Privacy_Requests_Table::prepare_items().
Props david.binda.
Fixes #48178.

git-svn-id: https://develop.svn.wordpress.org/trunk@46374 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-02 23:21:17 +00:00
Andrea Fercia
65c94d5cd8 Accessibility: Media: Allow users to set a proper language for Video subtitles.
For a number of years, subtitles track added to videos were always set to "English" regardless of the actual subtitles language.

By making the track `srclang`, `label`, and `kind` attributes editable, content authors are now able to set a language that matches the actual track content.

Props BjornW, audrasjb, birgire, karmatosed, sabernhardt, afercia.
Fixes #47559.


git-svn-id: https://develop.svn.wordpress.org/trunk@46373 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 22:04:43 +00:00
Andrea Fercia
dc0b9dc2d3 Login and Registration: Hide the Edge browser "Reveal password" native button.
Props Clorith.
Fixes #42888.


git-svn-id: https://develop.svn.wordpress.org/trunk@46372 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 17:59:18 +00:00
Andrea Fercia
5ddfa37db0 Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements.
- allows the login input fields to better scale with text 
- improves the input fields layout on Internet Explorer 11
- uses the new focus style on the "Show password" button 
- adjusts the CSS for the interim login

See #47153.
See #42888.


git-svn-id: https://develop.svn.wordpress.org/trunk@46371 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 15:54:39 +00:00
Jake Spurlock
02cf7f526e Shortcodes: Improve handling from shortcode_parse_attts().
Added missing @ticket for #47863 on `data_shortcode_parse_atts()`

Also cleans up some linter fixes that were missed.

Props garrett-eclipse, whyisjake.
ixes #47863.


git-svn-id: https://develop.svn.wordpress.org/trunk@46370 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 04:12:15 +00:00
Jake Spurlock
1f5525d2ff Shortcodes: Improve handling from shortcode_parse_attts().
Ensure consistency between `shortcode_parse_attts()` when being used directly.

Props mauteri, birgire, SergeyBiryukov, kadamwhite, whyisjake.
Fixes #47863.



git-svn-id: https://develop.svn.wordpress.org/trunk@46369 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 03:41:58 +00:00
Sergey Biryukov
4b93e1eff3 Docs: Fix typo in wp_get_missing_image_subsizes() DocBlock.
Props david.binda.
Fixes #48179.

git-svn-id: https://develop.svn.wordpress.org/trunk@46368 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 01:18:03 +00:00
Sergey Biryukov
38ea9f486f Docs: Remove obsolete comment in wpmu_signup_blog_notification() and wpmu_signup_user_notification().
Props david.binda.
Fixes #48185.

git-svn-id: https://develop.svn.wordpress.org/trunk@46367 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 00:45:20 +00:00
Jonathan Desrosiers
796f012ddc Post WordPress 5.3 Beta 2 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@46366 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 21:08:00 +00:00