Commit Graph

174 Commits

Author SHA1 Message Date
Ryan Boren f32bc0c541 Fire wp_auth_check_load() from admin_enqueue_scripts instead of admin_init so that it can access the current screen object.
Black list the update and upgrade screens.

Allow plugins to white/black list screens via the wp_auth_check_load filter.

Props nacin

see #23295


git-svn-id: https://develop.svn.wordpress.org/trunk@24738 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-18 19:06:35 +00:00
Andrew Nacin a8fb7603c6 Revert title auto-generation for asides and statuses.
Reverts [24043] and related.

fixes #24011.



git-svn-id: https://develop.svn.wordpress.org/trunk@24693 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 22:35:38 +00:00
Andrew Nacin 52897ae4b9 Don't store a revision for the initial call to wp_insert_post(), only on saves.
In core UI (and XML-RPC), we first create an auto-draft via get_default_post_to_edit(), which means the first "save" is in practice the first revision.

This reverts [23842].

fixes #24708.



git-svn-id: https://develop.svn.wordpress.org/trunk@24650 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-10 22:40:42 +00:00
Ryan Boren 33188fb613 Normalize the UTF-8 and ISO-8859-1 charset strings stored in blog_charset to make them friendlier with PHP functions that accept a charset such as htmlspecialchars().
fixes #23688


git-svn-id: https://develop.svn.wordpress.org/trunk@24510 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-25 19:03:17 +00:00
Mark Jaquith 87a35c7838 Revert [23450]. Removes post format compat.
see #23347, #24452. closes #24454.

git-svn-id: https://develop.svn.wordpress.org/trunk@24387 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-30 17:55:22 +00:00
Ryan Boren 2662748593 * Introduce wp_parse_post_content() and use it in setup_postdata(), get_the_content(), and get_the_remaining_content().
* Add a post ID argument to the_content(), get_the_content(), the_remaining_content(), and get_the_remaining_content().
* Pass the post ID to the the_content filter.
* Remove the format_pages global.
* Declare format_content and split_content as vars in WP_Post.
* phpdoc for the the_content filter that documents the new ID argument and denotes it as not-so-portable.

Props gcorne, DrewAPicture, duck_, aaroncampbell
see #24330


git-svn-id: https://develop.svn.wordpress.org/trunk@24301 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-20 11:05:50 +00:00
Sergey Biryukov 57b250943c Update _post_formats_fix_empty_title() description. Make it clear that 'wp_insert_post_data' is a filter, not an action. props DrewAPicture. fixes #24303.
git-svn-id: https://develop.svn.wordpress.org/trunk@24233 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-10 14:53:34 +00:00
Mark Jaquith aeaf7787c0 Hide the post title and auto-generate based on the post body, for the status and aside post formats.
props kovshenin. see #24011.

git-svn-id: https://develop.svn.wordpress.org/trunk@24043 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-22 04:00:25 +00:00
Andrew Ozz 93f1856d06 Logged out warnings: by default, load only in the admin. Plugins and themes can load on the front-end when needed, see #23295
git-svn-id: https://develop.svn.wordpress.org/trunk@23881 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-30 19:17:09 +00:00
Mark Jaquith 191ceb01cd Use the wp_insert_post hook to save revisions, so we save revisions for
an initial wp_insert_post() run, not just updates.

see #16215

git-svn-id: https://develop.svn.wordpress.org/trunk@23842 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-28 23:45:19 +00:00
Mark Jaquith 54e229a8b8 Fix a longstanding "off by one" revision authorship bug.
* Fixes old revision data on the fly when you open a post for editing.
* Uses post_name of revisions to store a post version number (-v1), so we know what has been fixed.
* Latest version should also have a revision stored, whereas before it did not.

props adamsilverstein, mdawaffe. fixes #16215.

git-svn-id: https://develop.svn.wordpress.org/trunk@23823 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-27 20:21:38 +00:00
Andrew Ozz 45f54b41d8 Logged out warnings: add fallback text dialog for:
- The login page has "X-Frame-Options: DENY" header.
- Cross-domain when displaying on the front-end on multisite with domain mapping.
- The site forces ssl login but not ssl admin.

Add onbeforeunload prompt to counter (frame-busting) JS redirects. Move the JS and CSS into separate files. See #23295.

git-svn-id: https://develop.svn.wordpress.org/trunk@23805 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-27 08:43:11 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Andrew Ozz 780ee565aa Improved logged out warnings, first run, props mintindeed, see #23295
git-svn-id: https://develop.svn.wordpress.org/trunk@23504 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-28 08:57:17 +00:00
Helen Hou-Sandi 351438ebe1 Output fallbacks / theme compat for post format metadata.
* Currently handles link, quote, image, gallery, audio, and video formats.
* `add_theme_support()` for a given post format is now an indicator that the theme handles format-specific metadata.
* If no support for a given format is defined, fallback output will be generated and hooked onto the_content if a post has metadata for that format.
* Fallbacks attempt to be smart about not duplicating data already appearing in the post content itself. Gallery is particularly liberal, looking for any instance of the gallery shortcode in the content, not just an exact match to the gallery shortcode defined in the format-specific meta.
* Compat output defaults to being wrapped in a `div` with a class of `post-format-content`.

Theme authors: please test and evaluate, keeping in mind that the goal is to support user expectations of not losing format-specific data they've entered in the admin when viewing the front-end of their site.

props wonderboymusic, beaulebens, helen. see #23347.


git-svn-id: https://develop.svn.wordpress.org/trunk@23450 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-18 19:22:58 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Peter Westwood 671a9b2017 Revisions: Before saving a new post revision make sure that something has changed in the fields that we are revisioning.
Fixes: #7392 and #9843 props adamsilverstein.


git-svn-id: https://develop.svn.wordpress.org/trunk@23414 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 11:36:32 +00:00
Andrew Ozz 5edc6b2711 Heartbeat API: first run, see #23216
git-svn-id: https://develop.svn.wordpress.org/trunk@23355 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-29 06:15:25 +00:00
Andrew Nacin 00d0bff81b Validate pingback source URIs. Less verbose errors.
git-svn-id: https://develop.svn.wordpress.org/trunk@23329 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-22 22:30:08 +00:00
Andrew Nacin dee18a07f9 Fix option name. props ocean90, see #21719.
git-svn-id: https://develop.svn.wordpress.org/trunk@22070 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-27 19:19:18 +00:00
Andrew Nacin 119bd9f50a New design and content for the welcome panel. First pass.
props lessbloat, helenyhou, georgestephanis, sabreuse, ryelle.
see #21368.



git-svn-id: https://develop.svn.wordpress.org/trunk@22018 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-26 19:44:43 +00:00
Andrew Nacin 84ca011876 Always attempt to embed URLs in content, removing the Auto-embeds (autoembed_urls) option.
Remove the UI for setting the default width and height for embeds. Width was confusing as it
was blank by default (inheriting the content width from the theme, or 500px). The height is
now calculated as 1.5x the content width, or 1000px, whichever is smaller.

The [embed] shortcode can still receive manual height and width attributes. This just removes
the global settings.

props wonderboymusic. see #21719.



git-svn-id: https://develop.svn.wordpress.org/trunk@21998 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 07:10:09 +00:00
Andrew Nacin 2e6cb465b2 Call clean_post_cache() in wp_insert_post() after the manual query to change GUID. Remove the second call to clean_post_cache() previously done on the save_post hook. see #11399.
git-svn-id: https://develop.svn.wordpress.org/trunk@21943 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-21 18:52:15 +00:00
Andrew Nacin 80cc4de72f If the DB upgrade hasn't yet been run, assume the Link Manager is disabled. Important for multisite installs. props ryan. see #21307.
git-svn-id: https://develop.svn.wordpress.org/trunk@21537 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-16 23:09:40 +00:00
Ryan Boren 71f71219fc Escape editable_slug as a textarea.
git-svn-id: https://develop.svn.wordpress.org/trunk@21049 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-10 17:58:57 +00:00
Ryan Boren 3f793e457c Fire the wp_cron action from init instead of sanitize_comment_cookies so that cron handlers can rely on a fully initialized env. Props SergeyBiryukov, norocketsurgeon. fixes #19818
git-svn-id: https://develop.svn.wordpress.org/trunk@20652 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-30 21:02:54 +00:00
Ryan Boren d1100bacb4 Schedule auto-draft deletion from post-new.php instead of from admin.php. This provides better throttling for large multisite installs and reduces the risk of a delete avalanche.
fixes #19663


git-svn-id: https://develop.svn.wordpress.org/trunk@20453 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-12 18:49:48 +00:00
Jon Cave 8d9d86352a Pass post_type through sanitize_key() instead of sanitize_user(). Fixes #20202.
For consistency with the registration API and because it does less work.


git-svn-id: https://develop.svn.wordpress.org/trunk@20234 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-21 15:04:00 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Peter Westwood ef0a93fea9 Make it possible for commenter cookies to be disabled if someone wants to by setting them on an action instead of always. Fixes #17976 props SergeyBiryukov and pishmishy .
git-svn-id: https://develop.svn.wordpress.org/trunk@19622 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-21 10:57:42 +00:00
Peter Westwood 62719b3438 Revert [18592] because there are issues to solve with autop/shortcode parsing ordering before we add this. See #10457 and #19411
git-svn-id: https://develop.svn.wordpress.org/trunk@19547 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-03 09:35:38 +00:00
Ryan Boren 80ee709653 Introduce wp_no_robots(). Call it for pages that should never be indexed, regardless of blog privacy settings. Props nacin. fixes #19251
git-svn-id: https://develop.svn.wordpress.org/trunk@19304 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-15 20:44:48 +00:00
Ryan Boren 448700b2e7 Count only published posts when updating term counts. Fire term count updates on transition_post_status. Props joehoyle. see #17548
git-svn-id: https://develop.svn.wordpress.org/trunk@18932 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-10 20:52:44 +00:00
Ryan Boren 83551cc744 Pass the query object to _close_comments_for_old_posts() so that is_singular is checked for the proper query. Props kawauso. fixes #18109
git-svn-id: https://develop.svn.wordpress.org/trunk@18836 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-30 15:35:50 +00:00
Andrew Nacin cd0ad3ead4 Revert [18783], as it breaks term relationship counts for attachment taxonomies. see #17548.
git-svn-id: https://develop.svn.wordpress.org/trunk@18809 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-29 05:29:20 +00:00
Ryan Boren f63662aa82 Count only published posts when updating term counts. Fire term count updates on transition_post_status. Props joehoyle. fixes #17548
git-svn-id: https://develop.svn.wordpress.org/trunk@18783 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-26 22:24:46 +00:00
Andrew Nacin 5c6b6c074f Strip a number of special characters in sanitize_title_with_dashes on save. Includes quotes (curly, angle), dashes, marks, etc. props SergeyBiryukov. props ampt for the unit tests in [UT438]. see #10797.
git-svn-id: https://develop.svn.wordpress.org/trunk@18705 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-18 19:53:59 +00:00
Andrew Nacin b4b2a1847b Remove support for <link rel=start>, end, up, and index. These rel="" values have been dropped by the HTML Working Group. props Elpie, kawauso, fixes #18128.
git-svn-id: https://develop.svn.wordpress.org/trunk@18680 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-15 16:54:59 +00:00
Andrew Ozz 647031a087 Rename the newly added action 'after_theme_change' to 'after_switch_theme' so it matches the 'switch_theme' action, props scribu, see #17979
git-svn-id: https://develop.svn.wordpress.org/trunk@18656 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-08 20:59:41 +00:00
Andrew Ozz 7b2c49d219 Make check_theme_switched() run an action so this enhancement is available to plugins and themes too, see #17979
git-svn-id: https://develop.svn.wordpress.org/trunk@18655 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-08 20:07:15 +00:00
Andrew Ozz 4782c3dc6f Avoid losing widgets when switching themes - take one, props aaroncampbell, see #17979
git-svn-id: https://develop.svn.wordpress.org/trunk@18630 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-02 22:13:55 +00:00
Dion Hulse 06338d1653 Store Plugin/Theme uploads in the Media Library properly. Add Scheduled cleanup +2hrs to clean up any aborted installation attempts. See #18182
git-svn-id: https://develop.svn.wordpress.org/trunk@18617 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-28 08:42:07 +00:00
Andrew Ozz 83275816df Fix action 'wp_print_footer_scropts' (on the front-end), see #11520
git-svn-id: https://develop.svn.wordpress.org/trunk@18610 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-26 20:31:30 +00:00
Peter Westwood edec48d754 Whitespace and code layout tidyup.
git-svn-id: https://develop.svn.wordpress.org/trunk@18593 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-24 10:59:06 +00:00
Peter Westwood 087b273a40 Parse shortcodes in text widgets by default. Fixes #10457 props tmoorewp, sillybean, jamescollins.
git-svn-id: https://develop.svn.wordpress.org/trunk@18592 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-24 10:54:48 +00:00
Andrew Ozz 461ceba60d Editor API enhancement, first run (still needs some work), see #17144
git-svn-id: https://develop.svn.wordpress.org/trunk@18498 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-03 10:19:00 +00:00
Andrew Ozz c1779932f1 Support for using wp_enqueue_script() and wp_enqueue_style() in the HTML body. All scripts and styles are added in the footer, fixes #9346
git-svn-id: https://develop.svn.wordpress.org/trunk@18446 602fd350-edb4-49c9-b593-d223f7449a82
2011-07-21 16:32:01 +00:00
Ryan Boren da02537bb0 Mark import attachments as private. Schedule job to delete old import attachments. Introduce attachment context.
git-svn-id: https://develop.svn.wordpress.org/trunk@17999 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-22 23:25:28 +00:00
Ryan Boren 57b6c9aeda Sanitize guid on save and display. Sanitize mime type on save. Don't allow changing mime type via edit form handlers. Protect hidden meta.
git-svn-id: https://develop.svn.wordpress.org/trunk@17994 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-22 23:19:42 +00:00
Ryan Boren 0d2dfe033e s/login_form/login_init/. Props sorich87. fixes #17411
git-svn-id: https://develop.svn.wordpress.org/trunk@17918 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-13 18:33:20 +00:00