Commit Graph

31129 Commits

Author SHA1 Message Date
Drew Jaynes
bc9e25d053 Docs: Clarify the return description for wp_create_user() to illustrate that a WP_Error object will be returned on failure.
Props jmayhak
Fixes #33321.


git-svn-id: https://develop.svn.wordpress.org/trunk@33725 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 22:22:33 +00:00
Boone Gorges
32cd95e1c1 In WP_Query::parse_tax_query(), allow 'cat' and 'tag' querystrings to be formatted as arrays.
See [33095] #32454 for a previous fix related to custom taxonomies.

Props Veraxus.
Fixes #33532.

git-svn-id: https://develop.svn.wordpress.org/trunk@33724 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 21:21:49 +00:00
Scott Taylor
5f3879e37c With a few modifications in wp-admin/menu.php, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare menu_position on post type registration.
Props scribu, wonderboymusic.
Fixes #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33723 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 21:18:20 +00:00
Scott Taylor
dc577d6072 WP_Query: add changelog for the title param after [33706]
Props dimadin.
Fixes #33074.


git-svn-id: https://develop.svn.wordpress.org/trunk@33722 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 20:09:25 +00:00
Drew Jaynes
7b7cd91984 Docs: Improve pared formatting of the oEmbed providers tables by removing the unrecognized first and last rows in the hook docs for the oembed_providers filter.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33720 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 04:37:40 +00:00
Gary Pendergast
845d31baf9 oEmbed: Remove blip.tv as an oEmbed provider, the service has been shut down.
Vale, blip.tv.

Fixes #33522.

Props rabmalin.



git-svn-id: https://develop.svn.wordpress.org/trunk@33719 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 04:11:13 +00:00
Gary Pendergast
bf3d36e0b6 WPDB: get_table_from_query() didn't find table names with hyphens in them.
Props dustinbolton for the fix.

Fixes #33470.



git-svn-id: https://develop.svn.wordpress.org/trunk@33718 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 00:18:49 +00:00
Drew Jaynes
83476bb77f Docs: Add a description and example to the hook docs for the navigation_markup_template filter, introduced in [33714].
Since the value of the filter is passed through `sprintf()` it's important to note that any filtered output needs to contain the expected specifiers.

See #31315.


git-svn-id: https://develop.svn.wordpress.org/trunk@33717 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 18:07:41 +00:00
Drew Jaynes
3969554606 Docs: Better clarify that the $post_type parameter for the get_usernumposts filter and count_user_posts() can accept either a single post type or array of post types.
Props tyxla
See #33481. Fixes #33520.


git-svn-id: https://develop.svn.wordpress.org/trunk@33716 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 17:45:51 +00:00
Drew Jaynes
797b6c4d7c Docs: Add better documentation for all accepted values for the fields argument in get_terms().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33715 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 17:39:07 +00:00
Scott Taylor
d8ba4fde1b Add a filter to _navigation_markup: 'navigation_markup_template'
Props joedolson, mordauk.
Fixes #31315.


git-svn-id: https://develop.svn.wordpress.org/trunk@33714 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 16:33:25 +00:00
Scott Taylor
9596ae0993 Posts List Table:
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33713 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 16:27:44 +00:00
Drew Jaynes
dfa9da5356 Docs: Fix a minor alignment issue in the DocBlock for get_pagenum_link().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33712 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 07:18:19 +00:00
Boone Gorges
b01b3be23e In wp_delete_term(), the $deleted_term object passed to filters should be generated before term relationships are deleted.
This allows the `count` property to reflect the pre-delete state of affairs,
rather than always being 0.

Props nicholas_io.
Fixes #33485.

git-svn-id: https://develop.svn.wordpress.org/trunk@33711 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 19:42:30 +00:00
Boone Gorges
6c3449b710 Pass the $public_only value to 'get_usernumposts' filter.
[32523] introduced the `$public_only` parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.

This changeset also fixes an incorrect variable name in the docblock for
the same filter.

Props swisspidy, tmatsuur.
Fixes #33481 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33710 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 18:58:18 +00:00
Scott Taylor
a679368d8b Add some JS Docs for Customizer.
Props ericlewis.
See #33503.


git-svn-id: https://develop.svn.wordpress.org/trunk@33709 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 17:23:37 +00:00
Scott Taylor
7e894153a4 In wp_insert_user(), add a filter: insert_user_meta, to filter a user's meta values and keys before the user is created or updated.
Props tharsheblows, chriscct7, DrewAPicture.
Fixes #31549.


git-svn-id: https://develop.svn.wordpress.org/trunk@33708 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 17:11:42 +00:00
Scott Taylor
36a9be2af5 In wp_sanitize_redirect(), don't eat @ characters. According to RFC 3986, "@" is a perfectly valid character in a URL path or query string.
Adds unit test.

Props markjaquith.
Fixes #18818.


git-svn-id: https://develop.svn.wordpress.org/trunk@33707 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 17:04:17 +00:00
Scott Taylor
dc48f3d795 Query:
Add a query var, `title`, that allows you to query posts by `post_title`. To accomplish this now, you have to do something like:

{{{
$tacos = get_posts( [
  'post_type' => 'taco',
  's' => $name,
  'exact' => true,
  'sentence' => true,
  'post_status' => 'publish',
  'fields' => 'ids',
  'posts_per_page' => 1
] );
}}}

Adds unit tests.

Fixes #33074.


git-svn-id: https://develop.svn.wordpress.org/trunk@33706 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 16:58:21 +00:00
Scott Taylor
a70e0183e5 Ensure that attachment_url_to_postid() matches cross-scheme when front-end and back-end schemes are different.
Adds unit test.

Props welcher.
Fixes #33109.


git-svn-id: https://develop.svn.wordpress.org/trunk@33705 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 16:38:09 +00:00
Scott Taylor
e76b48a26c update-core.php help docs, update string to include translations: themes, plugins, and translations
Props netweb, DrewAPicture.
Fixes #28201.


git-svn-id: https://develop.svn.wordpress.org/trunk@33704 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 16:24:58 +00:00
Dominik Schilling (ocean90)
918dd71257 Tests: Fix a typo in function names for $autoload tests.
Autoload is "no" if the `$autoload` param for `update_option()` is `'no'` or `false`.

see #26394.

git-svn-id: https://develop.svn.wordpress.org/trunk@33703 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 09:44:48 +00:00
Dominik Schilling (ocean90)
cb4a9ea174 Tests: Skip some tests for the Transients API when an external object cache is in use.
`test_transient_data_with_timeout()`, `test_transient_add_timeout()`, `test_nonexistent_key_dont_delete_if_false()`, and `test_nonexistent_key_old_timeout` are testing option values which aren't available with an an external object cache like memcache.

see #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@33702 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 20:32:42 +00:00
Scott Taylor
326b67c0aa In wpdb::get_col_length(), breaks are not necessary when a case returns
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33701 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:40:55 +00:00
Scott Taylor
5d494bae12 Doc block for_wp_specialchars: $quote_style can also be string ('single' or 'double')
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33700 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:35:31 +00:00
Scott Taylor
a14be1fffa In _WP_Editors::editor_settings(), $first_run is unused.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33699 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:29:31 +00:00
Aaron Jorbin
3b24c024b5 Add new constant MONTH_IN_SECONDS and expand time convenience documentation.
The "month" isn't really a month.  It's a WordPress Month. As the docs make clear, it's not about accuracy as much as it about convenience.  This adds a missing step in the time convenience constants. 

Props egill
Fixes #33397




git-svn-id: https://develop.svn.wordpress.org/trunk@33698 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:15:52 +00:00
Scott Taylor
e4f8047716 In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33697 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:12:56 +00:00
Weston Ruter
d40b6eab66 Widgets: Switch back to using array_key_exists() instead of isset() for widget instance existence check.
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.

See #32474.
Fixes #33442.


git-svn-id: https://develop.svn.wordpress.org/trunk@33696 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:08:53 +00:00
Scott Taylor
a1e5332489 Make 'Docs Committer' translatable.
Props dimadin. 
Fixes #33424.


git-svn-id: https://develop.svn.wordpress.org/trunk@33695 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:46:54 +00:00
Scott Taylor
9e784dd59f Clarify doc entry for _wp_customize_include()
Props ericlewis. 
Fixes #33488.


git-svn-id: https://develop.svn.wordpress.org/trunk@33694 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:44:11 +00:00
Scott Taylor
ab71eb93b1 When createing "Sample Page" on install, comments should be closed.
Props macmanx. 
Fixes #33490.


git-svn-id: https://develop.svn.wordpress.org/trunk@33693 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:41:16 +00:00
Scott Taylor
7dd261ce61 Comment List Tables:
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33692 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:25:06 +00:00
Drew Jaynes
e6466911d7 Docs: Add a changelog entry for the $post_type parameter added to the restrict_manage_posts hook in [33644].
Props pavelevap
Fixes #17891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33691 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 16:11:31 +00:00
Drew Jaynes
31e802293c Docs: Fix a typo in the DocBlock description for _get_additional_user_keys(), introduced in [33687].
Props dimadin
See #29120.


git-svn-id: https://develop.svn.wordpress.org/trunk@33690 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 16:00:35 +00:00
Helen Hou-Sandi
961dd71cf3 List tables: Allow filtering of hidden and default hidden columns.
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.

props Compute, MikeHansenMe, chriscct7.
fixes #32499.


git-svn-id: https://develop.svn.wordpress.org/trunk@33689 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 15:31:30 +00:00
Dion Hulse
466500743f WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user.
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33688 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 11:42:04 +00:00
Drew Jaynes
143c3e8a87 Docs: Clarify the DocBlock summary and add a description and return description for _get_additional_user_keys().
As noted in the description, returned keys being set is dependent on the existence of those keys in user meta at the point where `_get_additional_user_keys()` is called in `wp_update_user()`.

Fixes #29120.


git-svn-id: https://develop.svn.wordpress.org/trunk@33687 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 05:32:53 +00:00
Drew Jaynes
e803952278 Docs: Fix some minor inline documentation syntax issues in the hook docs for the post_edit_category_parent_dropdown_args filter, introduced in [33682].
See #32246. See #33026.


git-svn-id: https://develop.svn.wordpress.org/trunk@33686 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:54:00 +00:00
Drew Jaynes
a65c2e068a Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing.
Fixes #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33685 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:12:45 +00:00
Drew Jaynes
c53fe2779e Docs: Add missing @access tags to properties and methods in wp-admin/includes/class-wp-upgrader.
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33684 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:04:23 +00:00
Drew Jaynes
3721940e0f Docs: Correct a typo in the summary for the Theme_Upgrader->bulk property.
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33683 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 03:14:35 +00:00
Boone Gorges
57592ef976 Filter the arguments passed to wp_dropdown_categories() in the Categories post edit metabox.
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.

git-svn-id: https://develop.svn.wordpress.org/trunk@33682 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 01:27:15 +00:00
Boone Gorges
c1b8f1f72a In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute.
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the `'selected'`
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.

We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.

Fixes #33452 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33681 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 01:10:34 +00:00
Drew Jaynes
f35fde4e35 Docs: Standardize @deprecated tag formatting in the DocBlock for the logIO() function.
Props Alphawolf.
Fixes #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33680 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 22:43:02 +00:00
Drew Jaynes
6db612790d Docs: Standardize @deprecated tag formatting in the DocBlocks for several wpdb methods.
Props Alphawolf.
See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33679 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 22:41:07 +00:00
Drew Jaynes
2cfd34e85e Docs: Standardize @deprecated tag formatting in the DocBlock for WP_Object_Cache:reset().
Props Alphawolf.
See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33678 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 22:38:45 +00:00
Drew Jaynes
d83fcf8e9c Docs: Standardize @deprecated tag formatting in the DocBlock for wp_xmlrpc_server::login_pass_ok().
Props Alphawolf.
See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33677 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 22:37:16 +00:00
Drew Jaynes
a66a94a149 Docs: Standardize @deprecated tag formatting and add missing summaries to deprecated functions in wp-includes/ms-deprecated.php.
Props Alphawolf for the initial patch.
Props DrewAPicture

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33676 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 22:35:30 +00:00
Drew Jaynes
b09cedbd11 Docs: Standardize @deprecated tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php.
Props Alphawolf for the initial patch
Props DrewAPicture

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33675 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 22:25:41 +00:00