Commit Graph

37 Commits

Author SHA1 Message Date
Sergey Biryukov
ade1ffde80 Plugins list table: Add an aria-label attribute with the plugin name to plugin action links to provide context for screen reader users.
props bramd, rianrietveld, afercia.
fixes #26167.

git-svn-id: https://develop.svn.wordpress.org/trunk@33087 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-05 15:02:04 +00:00
Sergey Biryukov
056fcf6162 Plugins list table: Use case-insensitive sorting.
props GaryJ.
fixes #32735.

git-svn-id: https://develop.svn.wordpress.org/trunk@33076 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:52:46 +00:00
Dominik Schilling (ocean90)
454d8682d0 Plugins list table: Sort plugins by Name by default so translated plugin names get correctly sorted.
props swissspidy.
fixes #32735.

git-svn-id: https://develop.svn.wordpress.org/trunk@33010 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 22:30:19 +00:00
Helen Hou-Sandi
c2ed5b170d List tables: Use a class instead of inline styles for hidden columns.
fixes #32608.


git-svn-id: https://develop.svn.wordpress.org/trunk@32724 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 19:46:39 +00:00
Helen Hou-Sandi
c296d882a8 List tables:
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32723 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 19:30:22 +00:00
Helen Hou-Sandi
fa29d5bb80 List tables: tighten up primary column handling for plugins and multisite themes.
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32686 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-03 15:07:22 +00:00
Drew Jaynes
cb0fbfa276 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Plugins_List_Table.
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32667 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-31 01:39:22 +00:00
Scott Taylor
ec5758225c Add missing doc blocks to wp-admin/includes/*.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32654 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 20:16:22 +00:00
Scott Taylor
c8a44d437a Add @static* annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:42:40 +00:00
Helen Hou-Sandi
86c907d2a5 List tables: introduce the concept of a "primary" column.
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32644 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:40:52 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Sergey Biryukov
ecad13044d Fix a typo in [31872].
see #31738.

git-svn-id: https://develop.svn.wordpress.org/trunk@31873 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 17:32:47 +00:00
Aaron Jorbin
0d35447647 Fill $plugins['upgrade'] with extra info for use in list table
Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses `$plugin['upgrade']` rather than `$plugins['all']`, we need to fill that information in both places.   

Fixes #31738.



git-svn-id: https://develop.svn.wordpress.org/trunk@31872 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 17:29:32 +00:00
Aaron Jorbin
757ee0684c Fix notice that exists for plugins with no slug
Not all plugins have a slug, especially plugins not from the WordPress.org repository. 

Props imath for initial patch. 
Fixes #31694



git-svn-id: https://develop.svn.wordpress.org/trunk@31834 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 17:47:30 +00:00
Aaron Jorbin
cc0e582a67 Ensure that we target the correct plugin row for update updates
The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.

Props ericlewis
Fixes #31621




git-svn-id: https://develop.svn.wordpress.org/trunk@31831 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 05:26:00 +00:00
Scott Taylor
c0045bda84 Improve various @param docs for List Tables.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30679 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:32:19 +00:00
Drew Jaynes (DrewAPicture)
f45fd382b3 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30648 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:27:19 +00:00
Andrew Nacin
ca32a2d410 Pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@29707 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-04 15:22:58 +00:00
Andrew Nacin
e8d8b21cec Plugins: Only show details link if user can install plugins.
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29595 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:27:45 +00:00
Dominik Schilling (ocean90)
e4717c19c1 Apply accessibility improvements to Plugins screen too.
props SergeyBiryukov.
fixes #29342.

git-svn-id: https://develop.svn.wordpress.org/trunk@29583 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:21:20 +00:00
Drew Jaynes (DrewAPicture)
39ba840e04 Add @access tags to constructor docblocks in list table classes.
See #28679. See [29459].


git-svn-id: https://develop.svn.wordpress.org/trunk@29460 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:21:56 +00:00
Drew Jaynes (DrewAPicture)
126147a877 Document default arguments for the WP_List_Table class. Also add referenced docblocks to extending class constructors.
Props mikejolley for the initial patch.
Fixes #28679. See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29459 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:17:14 +00:00
Dominik Schilling (ocean90)
e8e0880851 WP_Plugins_List_Table::bulk_actions() method declaration should match WP_List_Table, see [29440].
props imath.
fixes #29148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29453 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 14:45:20 +00:00
Andrew Nacin
be026764a3 Move plugin details link into the description area.
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29371 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 18:48:07 +00:00
Scott Taylor
ced3f94927 Adds <label>s to current page selector and bulk actions <select> field so that screen readers have an explicit label.
Props joedolson.
Fixes #28867.


git-svn-id: https://develop.svn.wordpress.org/trunk@29294 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:19:21 +00:00
Andrew Nacin
b00097b758 Add 'Details' links to installed plugins.
Installed plugins that are up to date are now returned in the update-check API response.

props tellyworth.
see #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29226 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 20:48:28 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses.
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 22:08:22 +00:00
Scott Taylor
63cb20cc5a Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.
Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 03:26:40 +00:00
Sergey Biryukov
7f3b20c45d Remove redundant 'Visit author homepage' title attributes for plugins and themes.
props joedolson.
fixes #26554.

git-svn-id: https://develop.svn.wordpress.org/trunk@28673 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 04:51:55 +00:00
Scott Taylor
d6a3c2a0de Add access modifiers to methods and members of list table classes:
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 01:16:16 +00:00
John Blackbourn
f45c06c09c Avoid searching HTML tags when searching plugins and themes. Fixes #27136. Props enej.
git-svn-id: https://develop.svn.wordpress.org/trunk@27507 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 22:23:51 +00:00
Drew Jaynes
4346d63207 Inline documentation for hooks in wp-admin/includes/class-wp-plugins-list-table.php.
Props nicolealleyinteractivecom, kpdesign.
Fixes #26957.


git-svn-id: https://develop.svn.wordpress.org/trunk@27356 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-02 20:47:31 +00:00
John Blackbourn
6950f1bcd6 Don't filter out network-only plugins from the Plugins screen if they're individually active on the current site. Add some code comments for clarity. Props mordauk
git-svn-id: https://develop.svn.wordpress.org/trunk@27326 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-28 20:21:52 +00:00
Sergey Biryukov
a57529c720 Avoid a PHP warning in network admin if a constant corresponding to a drop-in is not defined. fixes #25301.
git-svn-id: https://develop.svn.wordpress.org/trunk@25425 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 09:36:08 +00:00
Scott Taylor
16ef2c2e36 Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this.
Props jdgrimes.
See #25160.



git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:33:50 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00