Andrew Nacin
2123afcbd3
All destructive row actions should be styled as such.
...
This fixes spam and trash links in the dashboard activity widget.
props avryl.
fixes #27370 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27547 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 04:25:55 +00:00
Dion Hulse
526bf7d352
WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27546 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 03:08:47 +00:00
Andrew Ozz
0fdb6dadfb
TinyMCE: add internal command and shortcut (Alt+Shift+X) for toggling <code>. Define a button that can be added to any toolbar as wp_code
. See #6113
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27545 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 22:42:59 +00:00
Scott Taylor
b6e2bd9f0e
MCE Views: don't (re-)render views if the format of the content is "raw" to avoid adding additional undo levels on undo/redo.
...
Props gcorne.
Fixes #27416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27544 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 20:40:44 +00:00
Dominik Schilling (ocean90)
a339826668
Widget Customizer: Make temp hooks final and add inline docs.
...
New hooks are `dynamic_sidebar_before`, `dynamic_sidebar_after`, `dynamic_sidebar_has_widgets ` and `is_active_sidebar`.
Remove obsolete use of hacky dynamic_sidebar hook.
props westonruter, DrewAPicture.
fixes #25368 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27543 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 20:30:54 +00:00
Scott Taylor
f2164771a7
In wp.media.mixin
, add ua
and a compat
map to separate and clarify browser detection and support. Leverage Underscore list iterators in isCompatible()
.
...
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27542 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 20:25:31 +00:00
Dominik Schilling (ocean90)
9e6f811c2b
Widget Customizer: Move widget area sections to bottom.
...
Since a theme can have a lot of widget areas and we don't want to bury third-party sections, bump the widget sections to the bottom with a priority of 1000+. Fixes also the ordering.
props westonruter.
fixes #27401 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27541 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 20:00:09 +00:00
Dominik Schilling (ocean90)
cecef45157
Customizer: Introduce a processing state.
...
The processing state will prevent a save when it doesn't return 0.
Widget Customizer will use the state to prevent a save while a widget is updating, which is an asynchronous process.
props westonruter.
fixes #27390 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27540 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 19:15:04 +00:00
Scott Taylor
bfd0ac1099
The canPlayType
property for audio and video in JS is so bad that the official valid responses are "probably" and "maybe". There are many cases where we might want to know if an audio|video tag is gonna blow up in our face before even attempting to make a MediaElementPlayer
instance out of it.
...
The best (and most cautious) way to tackle this is to whitelist types by browser. Imagine that one implemented MEjs in TinyMCE's rich editor mode, this would be very helpful.
Add `isCompatible( $media )` to `wp.media.mixin`. Future features will use this.
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27539 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 14:35:49 +00:00
Scott Taylor
2ba763c9ba
Move removePlayer()
and unsetPlayer()
to wp.media.mixin
so that other classes can take advantage of them.
...
* `removePlayer()` is an alternative to MediaElement's player removal method that does not re-add the audio|video element back to the DOM.
* `unsetPlayer()` will check for an existing `player` property on the passed instance and pause all players before calling `unsetPlayer()`
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27538 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 13:47:24 +00:00
Scott Taylor
3d244e1fed
Rather than extending wp.media.mixin
, only borrow coerce
when necessary in wp.media.audio|video|collection
. wp.media.mixin
will make sense to be mixed in for classes that expect to interact with the player. More universal methods can be added and inherited by all those who extend their prototype with it.
...
Assuming someone had implemented players in the editor, pause all players when switching between editor tabs. A method, `pauseAllPlayers`, has been added to `wp.media.mixin`.
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27537 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 13:16:07 +00:00
Scott Taylor
5e1e5c53ec
In media.model.PostMedia
, for these 2 scenarios:
...
* `src` is set, and 'Add a Source' results in the same file (or a file with the same extension) being added
* `src` is set, and 'Replace Audio|Video' is used, which will add a model property named by the attachment's extension
... call `model.unset( 'src' )`.
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27536 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 12:59:28 +00:00
Scott Taylor
12792afdde
Make media.view.VideoDetails.prepareSrc
a static class method instead of an instance method. Properly pairs it with its incrementing instances
property.
...
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27535 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 12:42:57 +00:00
Scott Taylor
86722dfaaa
Load MediaElement's CSS when TinyMCE is loaded via $mce_css
in editor_settings()
. Add some baseline styles in wp-content.css
for audio, video, and embed tags to ensure their max-width
is 100%
, regardless of whether MEjs is implemented in TinyMCE.
...
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27534 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 12:33:24 +00:00
Scott Taylor
4a2ffa917c
When rendering Underscore templates for Audio/Video details, use 2 new PHP functions to render the markup for audio and video tags: wp_underscore_audio_template()
and wp_underscore_video_template()
.
...
Future JS templates can follow the convention of expecting `data` to be passed to them containing a `model` property.
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27533 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 12:19:40 +00:00
Andrew Ozz
83501070d5
Modals: darken all overlays, update all box-shadows and headings, correct thickbox styling, make the link modal narrower and bring back the animation (css transition). Props avryl, see #26952
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27532 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 05:54:16 +00:00
Andrew Ozz
a33829d1d0
Drag/drop upload: don't trigger on "local" dragging, hide the overlay on click. Props kovshenin, fixes #19845
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27531 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 00:41:12 +00:00
Scott Taylor
bb02b06ad4
Revert [27528] until Flash in Firefox behaves :(
...
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27530 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 23:38:14 +00:00
Scott Taylor
163b0e2832
Version bump for TinyMCE stylesheet.
...
See #27389 , [27528].
git-svn-id: https://develop.svn.wordpress.org/trunk@27529 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 23:15:04 +00:00
Scott Taylor
1c7d92ba50
Add MCE Views for audio and video. Please clear your browser cache so that you get the latest TinyMCE stylesheet.
...
* Move TinyMCE shortcode handling from `wpgallery` plugin to `mce-view.js`
* Force `preload="none"` when rendering media in the editor to ensure fast loading (I realize this sounds illogical)
* Move audio and video tag builder logic in `media-template.php` into PHP funcs that can be reused by any code passing `data.model` to an Underscore template
* Pause all players when moving between editor tabs and when moving from the editor to editing in the media modal.
* Rename `wp.media.audio|video.shortcode()` to the more appropriate `wp.media.audio|video.update()` that now returns a `wp.shortcode` object instead of a string.
* Add necessary MediaElement css files to `$mce_css`
* In `wp.mce.View.render()`, support multiple instances of the same shortcode
* When rendering `wp.mce.View`s, fire a ready event that passes the current MCE View root element as context
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27528 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 23:09:06 +00:00
John Blackbourn
110e19a6a0
figcaption
should not be treated as a block-level element by wpautop()
. See #25646 . Props oso96_2000.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27527 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 21:50:17 +00:00
John Blackbourn
eaae9961ef
Remove Qik from the oEmbed provider list as it's shutting down. Fixes #27302 . Props JustinSainton.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27526 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 21:27:54 +00:00
Dominik Schilling (ocean90)
a247452cbb
Widget Customizer: Move style/script registration to script loader. Update Gruntfile.js.
...
fixes #27356 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27525 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 19:40:15 +00:00
Dominik Schilling (ocean90)
91fbdbbcc4
Widget Customizer: Use ?wp_customize=on.
...
Let _wp_customize_include() handle customizer initialisation.
Sets also the priority for the Add Widget and Reorder buttons and removes debug cruft.
props westonruter.
fixes #27291 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27524 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 18:37:24 +00:00
John Blackbourn
22eb8b34ef
Improve paginate_links()
performance by not calling number_format_i18n()
unnecessarily. Fixes #25735 with tests. Props johnpbloch.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27523 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 17:38:51 +00:00
Scott Taylor
543bc6404a
The Image Editor should apply changes to custom image sizes by checking $_wp_additional_image_sizes
for $size
in wp_save_image()
before arbitrarily going to the options table.
...
Props Otto42, SergeyBiryukov.
Fixes #19889 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27522 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 04:17:36 +00:00
Scott Taylor
dad0455ef9
Avoid a notice in get_the_category_by_ID()
when is_wp_error( $term )
is false but $term->name
is not set. Clarify the @return
value of get_category()
and get_tag()
which return the same possible types as get_term()
, which they wrap.
...
Props ericmann, SergeyBiryukov.
Fixes #25429 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27521 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 04:03:06 +00:00
Scott Taylor
dc73f008ce
Add a class property to wp.media.view.MediaDetails
called instances
that is incremented every time the class is invoked. This mimics what happens in the shortcodes: the sources receive an incremented cache-buster so that the browser won't ignore the file when preload="metadata"
is set.
...
See #26779 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27520 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 03:54:38 +00:00
Scott Taylor
d018152785
Account for preload="metadata"
in audio and video shortcodes when multiple versions of the same <source>
appear on the page by appending a query arg to "cache-bust" passed sources. The query arg is used to make the sources "unique." They will still be cached by the browser and won't bust the cache on every request.
...
Fixes #26779 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27519 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 03:41:53 +00:00
Scott Taylor
abf794f75c
In wp.media.view.AttachmentFilters
, when creating its inner HTML content, pass filter.text
via .html( str )
instead of .text( str )
to allow more formatting options.
...
Props tlovett1.
Fixes #25010 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27518 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 03:18:42 +00:00
Helen Hou-Sandi
14615cd317
Ensure the correct model is selected when editing an image from gallery mode. props gcorne. fixes #27363 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27517 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 22:04:56 +00:00
Helen Hou-Sandi
5f936ab3dd
Smooth out some display and race condition issues with the media modal loading spinner. props kadamwhite, gcorne. see #24859 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27516 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 21:06:30 +00:00
Andrew Nacin
395b466fb7
Revert [27203], restore JIT color scheme stylesheets. Restores [27111].
...
fixes #27175 . see #20729 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27515 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 16:11:38 +00:00
Sergey Biryukov
96b39f3363
Avoid a notice in trackback_rdf() if user agent is not set.
...
props joostdevalk.
fixes #27374 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27514 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 12:53:49 +00:00
Andrew Ozz
8fc52817b9
TinyMCE modals: re-enable the Close button in charmap, fix arrows in listboxes, add and position dashicons to the menu (when visible), see #26952
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27513 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 08:18:56 +00:00
Scott Taylor
61bc04deff
Change string "Create Playlist" to "Create Audio Playlist." Open new tickets for individual issues.
...
Fixes #26631 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27512 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 04:39:28 +00:00
Scott Taylor
36df368171
In WP_Query::get_queried_object()
, account for pre_get_posts
by checking for tag
when tag_id
isn't present. Tags still need to be rolled up into tax_query
. Add a unit test confirming expected query vars during and after pre_get_posts
.
...
Props mattonomics for a patch.
See #27362 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27511 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 04:07:41 +00:00
Andrew Ozz
0336d4c265
wpLink: bring back the Cancel link, improve responsive styles, see #26952
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27510 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 03:06:11 +00:00
Andrew Nacin
3a126c0452
Use correct variable in themes JS, fixes themes.php.
...
props SergeyBiryukov.
fixes #27360 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27509 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-12 00:28:26 +00:00
John Blackbourn
f3629139a5
Correct the "View Post" button link when changing a post slug. Fixes #16477 . Props aubreypwd.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27508 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 22:59:03 +00:00
John Blackbourn
f45c06c09c
Avoid searching HTML tags when searching plugins and themes. Fixes #27136 . Props enej.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27507 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 22:23:51 +00:00
John Blackbourn
961899214e
Present a normal admin page when bailing out of the Plugin Editor screen. Fixes #27067 . Props SergeyBiryukov.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27506 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 22:13:05 +00:00
John Blackbourn
b7fbb777e9
Add missing hyperlink styles to the login screen. Fixes #27245 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27505 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 20:50:55 +00:00
Sergey Biryukov
11f58c181f
Avoid unintentional overriding of .spinner styles for HiDPI displays.
...
props mauryaratan for initial patch.
fixes #27269 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27504 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 19:41:22 +00:00
Sergey Biryukov
28dd458547
Avoid a warning in wpdb::db_connect(). before_needle parameter of strstr() was added in PHP 5.3.
...
props klihelp, pento.
fixes #27277 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27503 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 19:26:02 +00:00
Sergey Biryukov
1a769c0e11
Remove duplicate description of WP_List_Table class.
...
props bravokeyl.
fixes #27346 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27502 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 16:22:44 +00:00
Andrew Nacin
6aa60cf530
Assign correct variable.
...
props nendeb55.
fixes #27351 . see #14424 , [27373].
git-svn-id: https://develop.svn.wordpress.org/trunk@27501 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 13:23:14 +00:00
Andrew Nacin
1f5eec43cd
A nice round commit number for a beta 1.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27500 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 07:53:15 +00:00
Andrew Nacin
96176b269d
Bring the theme browsing experience from 3.8 to the theme installer. First pass.
...
props matveb with assists from me and gcorne.
see #27055 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27499 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 07:46:27 +00:00
Andrew Nacin
a9b6b9339f
JS linting for [27497].
...
see #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27498 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 04:19:25 +00:00