Dominik Schilling (ocean90)
a2c020e068
WP_Widget: Introduce is_preview()
method.
...
With the Widget Customizer it's possible that previewed widgets can leak data outside of Customizer, when the widget uses the cache API.
The Customizer calls the regular update callback which should already refresh the cache. Since cache additions aren't blocked yet the cache can be filled with preview data.
To prevent this issue `WP_Widget::is_preview()` will return true, when `$wp_customize->is_preview()` returns true. If `is_preview()` is true, cache additions are suspended via `wp_suspend_cache_addition()`. Make sure your object cache drop-in has implemented `wp_suspend_cache_addition()`.
`is_preview()` can/should also be used inside `WP_Widget::widget()`, see WP_Widget_Recent_Posts or WP_Widget_Recent_Comments for examples.
For more info see IRC logs: http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-04-02&sort=asc#m824279
props westonruter.
fixes #27538 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27966 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 18:47:46 +00:00
Drew Jaynes (DrewAPicture)
789305948e
Inline documentation for remaining hooks in wp-admin/includes/upgrade.php.
...
Props jackreichert, vancoder.
Fixes #27646 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27965 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 22:29:41 +00:00
Andrew Nacin
14d96748c7
Better checks for contributors when saving posts.
...
props dd32, kovshenin, plocha.
see #27452 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27964 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 21:18:44 +00:00
Andrew Nacin
12f66b9859
Theme Installer: Separate API from an event handler to avoid issues where a false return value stops the event.
...
see #27055 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27963 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:45:37 +00:00
Andrew Nacin
e40de50197
Theme Installer: Don't encode description entities/HTML.
...
props johnbillion.
fixes #27641 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27962 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:29:44 +00:00
Andrew Nacin
ba9e3d2bc3
Theme Installer: Use JSONP for api.wordpress.org requests.
...
fixes #27639 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27961 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:27:56 +00:00
Scott Taylor
1ff1343a82
Revert the changes made to data.title
in playlist Underscore templates in [27869]. {{ data.title }}
causes the title to be double-encoded on the front end.
...
See #27574 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27960 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:05:04 +00:00
Andrew Nacin
5863d7874d
Theme Installer: Better responsive styles for feature filters.
...
props matveb.
fixes #27661 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27959 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:03:41 +00:00
Andrew Nacin
c4d09e4736
Theme Installer: Fix displaying of errors.
...
props SergeyBiryukov.
fixes #27640 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27958 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 19:25:20 +00:00
Andrew Nacin
631b55ac0b
Don't pass variables by reference.
...
props markjaquith.
fixes #27656 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27957 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 18:16:45 +00:00
Andrew Nacin
84c4332b3e
RTL: Fix taxonomy quick edit list alignment.
...
props SergeyBiryukov.
fixes #27629 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27956 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 18:13:11 +00:00
Dominik Schilling (ocean90)
8c28ef2b7c
Fix typo in hook description for async_upload_{$type}
.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27955 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 14:11:38 +00:00
Dominik Schilling (ocean90)
fc34a6e63e
Customizer: Add height: auto;
for select[multiple]
.
...
fixes #27662 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27954 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 13:11:39 +00:00
Sergey Biryukov
4a197c45a2
Avoid an undefined index notice in wp_http_validate_url().
...
props jesin.
fixes #27684 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27953 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 12:44:19 +00:00
Drew Jaynes (DrewAPicture)
6c7aabda19
Fix a typo in the PHPDoc description for the WP_Http_Curl->max_body_length
property.
...
Props eightface.
Fixes #27681 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27952 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 05:47:54 +00:00
Andrew Ozz
30cdc10180
When autosaving a new post for the first time after a title was typed, cancel the autosave if the user is submitting the form. (Includes a precommit fix for customize-controls.css.) Props Nessworthy, davidmarichal, fixes #27657
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27951 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 01:28:35 +00:00
Andrew Ozz
36f0a60829
Throw a user notice when the editor ID used for TinyMCE contains brackets, props nacin, fixes #27601
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27950 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 01:10:19 +00:00
Andrew Ozz
548772fcc1
TinyMCE: update the default style for html5-captions, props obenland fixes #26642
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27949 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 23:11:21 +00:00
Andrew Ozz
63bf25ec1f
Edit image modal: check if full size exists before trying to use it for setting aspect ratio, props gcorne, see #27366
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27948 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 18:00:04 +00:00
Andrew Nacin
6ec7a5a52b
Header images: Accessibility and style improvements. Headers no longer jump around when chosen.
...
props mcsf, ehg.
see #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27947 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 15:48:34 +00:00
Andrew Nacin
96e15acb2e
Header images: Handle cropping failures.
...
props ehg.
see #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27946 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 15:47:43 +00:00
Andrew Nacin
996a502103
Add missing space between strings.
...
props rachelbaker.
fixes #27597 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27945 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 13:16:15 +00:00
Andrew Ozz
48269a7c29
TinyMCE: add image backgrounds for more and nextpage tags (also jshint fix for theme.js). Fixes #27106
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27944 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 05:22:47 +00:00
Drew Jaynes (DrewAPicture)
e9f0de0951
Remove a blank line and @global reference in the PHPDoc for comment_author_email_link()
.
...
Props norcross, ocean90.
Fixes #27655 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27943 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 04:35:20 +00:00
Andrew Ozz
ee33326f32
Edit image modal:
...
- Make the calculation of the aspect ratio more robust.
- Better getting of the image height and width.
Props gcorne, see #27366
git-svn-id: https://develop.svn.wordpress.org/trunk@27942 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 01:48:24 +00:00
Andrew Ozz
ec18e88dee
TinyMCE: better calculation for editor height when switching Text to Visual and back. Add stopping of editor resizing when the mouse leaves the browser window. See #27279
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27941 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 01:30:11 +00:00
Andrew Nacin
e8ad1fbf6c
Theme Installer: Center spinner, remove plural string.
...
fixes #27581 . see #27055 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27940 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:45:13 +00:00
Sergey Biryukov
96563b4143
Clarify tooltips on Edit Image screen.
...
props siobhan.
fixes #27651 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27939 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:02:22 +00:00
Sergey Biryukov
a97e9018c4
Fix typo in verify_file_md5() description. see [25541].
...
props siobhan.
see #27651 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27938 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:02:12 +00:00
Andrew Nacin
b29ccb5656
Theme Installer: Fix sorting, counts, keyboard navigation; add prev/next to previews.
...
props matveb.
see #27055 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27937 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 23:52:45 +00:00
Andrew Nacin
e73e290712
Themes: Hide 'Add New' with no JS. see #27055 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27936 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 23:05:01 +00:00
Andrew Nacin
ccb4f3714a
Database: Fall back from ext/mysqli to ext/mysql if the connection fails.
...
This allows us to avoid breaking a site that works under ext/mysql but is misconfigured for ext/mysqli.
props pento.
see #21663 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27935 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 21:57:22 +00:00
Andrew Ozz
641f9f9a93
TinyMCE: improve setting disabled/enabled/activated states on the Unlink button, fixes #27309
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27934 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 20:04:44 +00:00
Dominik Schilling (ocean90)
de2c9e23cf
Plupload wrapper: Call init callback on PostInit event.
...
Fixes the background image uploader in Customizer, which was broken after [27316].
fixes #27620 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27933 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 19:43:53 +00:00
Dominik Schilling (ocean90)
d817c574a3
Fix styling for plugin update details Thickbox.
...
see #26952 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27932 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 14:07:42 +00:00
Sergey Biryukov
ed139644be
Use multiplication sign instead of a colon for selection size when editing an image.
...
props siobhan.
fixes #27652 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27931 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 09:45:44 +00:00
Dion Hulse
ce76432676
Background Updates: Fix a PHP Warning caused by a Upgrader instance being passed into the Theme & Plugin $extra_stats parameter. See #27633
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27928 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 05:32:02 +00:00
Andrew Ozz
f57853519f
TinyMCE: update translatable strings, see #27453 , #24067
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27927 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 05:15:59 +00:00
Lance Willett
8dcec58f2a
Twenty Thirteen and Fourteen: style to support the new HTML5 line-break-less galleries. Props obenland, see #27637 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27926 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 04:46:23 +00:00
Andrew Nacin
0faaacc7c8
Database: Add $allow_bail argument to wpdb::check_connection() to match the connect method.
...
props DrProtocols, pento.
fixes #27240 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27925 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 04:05:31 +00:00
Andrew Ozz
74ec183ee7
TinyMCE:
...
- Bring back loading of /langs/[locale].js and /langs/[locale]_dlg.js from PHP. Prevents errors with missing translation files when custom plugins use requireLangPack() without second argument.
- Back to using ISO 639-1 (two letter) locales as the locale is used as part of the translation file name.
See #24067 , fixes #27610
git-svn-id: https://develop.svn.wordpress.org/trunk@27922 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:39:21 +00:00
Andrew Ozz
26391af850
Edit Image modal:
...
- Fix issue with adding a link to an image that didn't have one previously.
- Adjust the look-and-feel of the advance options toggle so that it becomes a section heading that can be open/closed.
- Add a Custom Size option to the size drop-down that reveals fields for soft-resizing the image inserted into the post.
Props gcorne, and props sdasse for the design help, see #27366
git-svn-id: https://develop.svn.wordpress.org/trunk@27918 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:20:40 +00:00
Andrew Nacin
66f20812b9
Remove old links_recently_updated_* DB options that never had a UI.
...
fixes #27649 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27916 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:09:59 +00:00
Sergey Biryukov
df3eaf73cb
Fix copy/paste error in [27710].
...
props kovshenin.
fixes #21969 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27915 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 23:46:34 +00:00
Andrew Nacin
87bc851561
Remove <br> elements for HTML5 galleries.
...
props obenland.
fixes #27637 , see #26697 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27914 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 21:49:38 +00:00
Dominik Schilling (ocean90)
63a83c88f8
Widget Customizer: Restore deferral of previewer-loading
class removal until preview is synced.
...
props westonruter.
fixes #27635 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27913 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 19:24:18 +00:00
Dominik Schilling (ocean90)
41c2ce306a
Widget Customizer: Don't use opacity for the update spinner.
...
`opacity` isn't supported in IE8 and makes the spinner always visible.
see #27485 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27912 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 19:19:53 +00:00
Dominik Schilling (ocean90)
c65af080fd
Update suggest.min.js for [26333].
...
see #26110 , #27599 .
fixes #27621 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27911 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 19:04:56 +00:00
Dominik Schilling (ocean90)
b0fae8aa2a
Widget Customizer: Remove leading underscores from public methods.
...
Fix also an incorrect hook name in `stop_capturing_option_updates()`.
props DrewAPicture.
see #27534 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27910 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 18:30:06 +00:00
Dominik Schilling (ocean90)
9f3976baf2
Widget Customizer: Improve support for dynamically-created inputs.
...
* Re-work how and when widget forms get updated.
* Replace ad hoc hooks system with jQuery events,
* Add `widget-updated`/`widget-synced` events for widget soft/hard updates.
* Enter into a non-live form update mode, where the Apply button is restored when a sanitized form does not have the same fields as currently in the form, and so the fields cannot be easily updated to their sanitized values without doing a complete form replacement. Also restores live update mode if sanitized fields are aligned with the existing fields again.
Note: jQuery events are *not* final yet, see #19675 .
props westonruter.
see #27491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27909 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 18:20:00 +00:00