Commit Graph

32835 Commits

Author SHA1 Message Date
dd32
f935d4c26b Updates: Add a generic failure case to the ajax update endpoint for when the WP_Error value hasn't been found.
See #34403


git-svn-id: https://develop.svn.wordpress.org/trunk@35371 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 07:34:02 +00:00
Dion Hulse
8c33fe770e Use wp_parse_url() in esc_url() to avoid parsing bugs in < PHP 5.4.7.
Props johnbillion for unit tests
See #34408
Fixes #34202


git-svn-id: https://develop.svn.wordpress.org/trunk@35370 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 05:56:25 +00:00
Dion Hulse
cacd015856 WP_HTTP: Promote the WP_HTTP::parse_url() method to a more generic wp_parse_url() function.
Fixes #34408


git-svn-id: https://develop.svn.wordpress.org/trunk@35369 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 05:53:05 +00:00
Dion Hulse
743fe671f1 Comments: Use a full URL rather than a relative one for links which can contain IPv6 addresses to avoid an issue where the URL was being eaten by escaping functions.
See #34407, #34202
Fixes #34054


git-svn-id: https://develop.svn.wordpress.org/trunk@35368 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 05:13:27 +00:00
Dion Hulse
f70e623991 XMLRPC: Revert the changes to WP_XMLRPC_UnitTestCase in [35366] as they weren't required.
See #34336


git-svn-id: https://develop.svn.wordpress.org/trunk@35367 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 04:49:08 +00:00
Dion Hulse
75ab50c70e XMLRPC: Prevent authentication from occuring after a failed authentication attmept in any single XML-RPC call.
This hardens WordPress against a common vector which uses multiple user identifiers in a single `system.multicall` call. In the event that authentication fails, all following authentication attempts ''in that call'' will also fail.

Props dd32, johnbillion.
Fixes #34336


git-svn-id: https://develop.svn.wordpress.org/trunk@35366 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 04:45:10 +00:00
Dion Hulse
3a992e266f Update to Random_Compat 1.0.9.
This update includes fixes for Windows support & libSodium support, and removes the `Throwable` Polyfill due to PHP7 incompatibilities. 

Fixes #28633


git-svn-id: https://develop.svn.wordpress.org/trunk@35365 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 04:21:01 +00:00
Dion Hulse
b89670b0f6 Update variable naming after [35279].
See #29957.


git-svn-id: https://develop.svn.wordpress.org/trunk@35364 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 02:00:21 +00:00
Aaron Jorbin
21b29ebf5e Bump grunt-contrib-jshint to 0.11.3
This bumps the included jshint to 2.8.0 from 2.6.0

See #34177




git-svn-id: https://develop.svn.wordpress.org/trunk@35363 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 01:09:03 +00:00
Scott Taylor
a77a05447c 4.4-beta1
git-svn-id: https://develop.svn.wordpress.org/trunk@35362 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 21:44:57 +00:00
Scott Taylor
c6354d6bfd Plugins: after [35151], set default $restrict_network_* values to prevent notices.
Props johnjamesjacoby.
Fixes #20104.


git-svn-id: https://develop.svn.wordpress.org/trunk@35361 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:55:30 +00:00
Scott Taylor
9aba8ef2aa Options: remove old 'gzipcompression' and 'advanced_edit' options.
Props chriscct7, solarissmoke.
Fixes #12996.


git-svn-id: https://develop.svn.wordpress.org/trunk@35360 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:48:38 +00:00
Drew Jaynes
68c5efb7f3 Docs: Add a proper file header to wp-admin/includes/continents-cities.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35359 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:42:23 +00:00
Andrew Ozz
5aa7a8ce78 Responsive Images: limit the size of images included in srcset attributes. Introduce max_srcset_image_width filter to adjust the limit.
Props joemcgill.
Fixes #34341.

git-svn-id: https://develop.svn.wordpress.org/trunk@35358 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:30:12 +00:00
Helen Hou-Sandi
7adf6e9125 List tables: Move the view mode switcher into screen options for posts.
Having a view mode switcher nestled within table navigation makes no sense, especially now that it's a sticky user option. While less convenient for frequent switching, there is no evidence as of yet that there is a large userbase of frequent view mode switchers.

Introduces a filter for `view_mode_post_types`, which by default is all hierarchical post types with edit UI on.

props Oxymoron.
fixes #22222.


git-svn-id: https://develop.svn.wordpress.org/trunk@35357 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:24:10 +00:00
Scott Taylor
a37f75eb87 oEmbed: add Reddit Comments as a provider
Docs: https://github.com/reddit/reddit/wiki/oEmbed

Props swissspidy.
Fixes #31752.



git-svn-id: https://develop.svn.wordpress.org/trunk@35356 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 18:16:12 +00:00
Scott Taylor
6a3b784104 Media: in wp_get_attachment_image_sizes(), to streamline and for performance:
* Change the 3rd arg from `args` to `width`
* Change `wp_image_sizes_args` filter to `wp_get_attachment_image_sizes`

Updates unit tests.

Props joemcgill.
Fixes #34379.


git-svn-id: https://develop.svn.wordpress.org/trunk@35355 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 16:45:37 +00:00
Scott Taylor
a19a0e6e72 oEmbed: if SimpleXMLElement does not exist, return an HTTP Error 501 Not implemented response.
Props swissspidy.
Fixes #34274.


git-svn-id: https://develop.svn.wordpress.org/trunk@35354 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 16:37:31 +00:00
Scott Taylor
ff49cc7ebf REST API: don't load wp-admin/includes/admin.php on every request.
Props swissspidy.
Fixes #34395.


git-svn-id: https://develop.svn.wordpress.org/trunk@35353 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 16:28:40 +00:00
Sergey Biryukov
54c840dc04 Docs: Correct description for _wp_post_revision_fields() arguments.
See #13382.

git-svn-id: https://develop.svn.wordpress.org/trunk@35352 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 12:16:48 +00:00
John Blackbourn
1691563872 Force the REST API URL to use https for its scheme when the current request is served over HTTPS and the host name matches that of the REST API URL.
This allows sites to use an admin area over HTTPS with the front end over HTTP, and not end up with a cross-protocol problem when using the REST API URL in the admin area.

Fixes #34299


git-svn-id: https://develop.svn.wordpress.org/trunk@35351 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 00:07:36 +00:00
John Blackbourn
82cb793355 Initialise $_SERVER['SERVER_NAME'] during the test bootstrap to avoid individual tests having to do it.
Fixes #34394


git-svn-id: https://develop.svn.wordpress.org/trunk@35350 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 23:51:45 +00:00
John Blackbourn
2e1b898077 Revert [34352], pending investigation.
See #34299


git-svn-id: https://develop.svn.wordpress.org/trunk@35349 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 23:05:43 +00:00
John Blackbourn
5f8d0870a2 Remove the explicit Imagick extension test.
See #34087


git-svn-id: https://develop.svn.wordpress.org/trunk@35348 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 22:40:48 +00:00
John Blackbourn
2c3c286b84 Correctly use WP_TESTS_EMAIL in email tests.
See #761, #34000


git-svn-id: https://develop.svn.wordpress.org/trunk@35347 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 22:33:53 +00:00
John Blackbourn
20eb6402fd Correct some more tests which were using example.org instead of WP_TESTS_DOMAIN.
See #33641, #34000


git-svn-id: https://develop.svn.wordpress.org/trunk@35346 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 22:21:51 +00:00
John Blackbourn
63748f2d67 Provide a more helpful failure message when Imagick isn't installed. Skipping the tests isn't really an option because Imagick's presence affects several other tests too.
See #34087


git-svn-id: https://develop.svn.wordpress.org/trunk@35345 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 22:10:43 +00:00
John Blackbourn
289973f078 Remove the failing test_rest_url_scheme() test while it's investigated.
See #34299


git-svn-id: https://develop.svn.wordpress.org/trunk@35344 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 22:06:41 +00:00
Andrea Fercia
bdffdf0eb6 Plugins: Improve the "Install Now" button vertical alignment in the Plugin Details modal dialog.
Props paulwilde.

Fixes #34199.

git-svn-id: https://develop.svn.wordpress.org/trunk@35343 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 21:54:42 +00:00
John Blackbourn
672782f0a6 Force the REST API URL to use https for its scheme when the current request is served over HTTPS and the host name matches that of the REST API URL.
This allows sites to use an admin area over HTTPS with the front end over HTTP, and not end up with a cross-protocol problem when using the REST API URL in the admin area.

Fixes #34299


git-svn-id: https://develop.svn.wordpress.org/trunk@35342 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 20:37:56 +00:00
Andrew Ozz
f447d2f5bf TinyMCE:
- Sanitize and render HTML in captions when showing a gallery preview (wpView).
- Encode/escape HTML entered in the text field in the wpLink dialog.

Props iseulde, kraftbj, jnylen0, shawarkhan.
Fixes #32616.

git-svn-id: https://develop.svn.wordpress.org/trunk@35341 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 20:37:54 +00:00
Helen Hou-Sandi
9e865f51a8 RIP #21759b, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35340 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:35:05 +00:00
Drew Jaynes
1a7298861b Comments: Introduce two new filters, notify_moderator and notify_post_author, both of which make it possible to selectively override site notification email settings for new comments.
The `notify_moderator` filter makes it possible to override the value for the `moderation_notify` option, which controls whether to send new comment emails to "site moderators", that is to say, the owner of the admin email for the site and the post author if they have the ability to modify the comment.

The `notify_post_author` filter likewise makes it possible to override the value for the `comments_notify` option, which controls whether to send new comment emails to the post author. If the post author is the comment author, default behavior is not to send the notification. Note: enabling or disabling notifications via this hook could also affect other recipients added via the 'comment_notification_recipients' filter in `wp_notify_postauthor()`, if hooked.

Passing a falsey value to either of the new filters will prevent notifications from being sent, regardless of their corresponding option values.

Adds tests.

Props coffee2code, adamsilverstein, DrewAPicture.
Fixes #761.


git-svn-id: https://develop.svn.wordpress.org/trunk@35339 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:34:06 +00:00
Andrea Fercia
ac3edc61fd Press This: Improve the "choose tags" button focus style.
Props adamholisky for the initial patch.

Fixes 34241.

git-svn-id: https://develop.svn.wordpress.org/trunk@35338 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:33:46 +00:00
Dominik Schilling (ocean90)
05356ff7dc Options: Hide the week starts on setting for installs that have the default setting already.
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35337 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 17:38:44 +00:00
Dominik Schilling (ocean90)
597e3630f3 WP Locale: Add a start_of_week property to store the start of the week per locale.
Props swissspidy.
See #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35336 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 17:27:47 +00:00
Aaron Jorbin
739fc4a8c7 Update grunt-browserify
upstream changes https://github.com/jmreidy/grunt-browserify/compare/v4.0.0...v4.0.1

See #34177


git-svn-id: https://develop.svn.wordpress.org/trunk@35335 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:58:37 +00:00
Konstantin Obenland
52204f7b27 Tests: Use most specific function for document titles.
Adds tests specific to `_wp_render_title_tag()`.

See #31078.



git-svn-id: https://develop.svn.wordpress.org/trunk@35334 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:54:53 +00:00
Boone Gorges
f492a81d70 Prevent non-public taxonomies from registering aquery var.
[34247] made the 'public' paramater of `register_taxonomy()` work by blocking
requests for non-public taxonomy archives during `parse_request()`. Blocking
taxonomy archive requests this late means that it's impossible to register an
independent query var that matches the slug of a non-public taxonomy. By
moving the block to `register_taxonomy()` - not allowing these taxonomies to
register their query vars in the first place - we free up the slug for other
use. In addition, we free up a bit of processing (no need to look for the query
var in `parse_request()` and better parallel the way non-public post types
work. See `register_post_type()`.

Non-public taxonomy archives that are requested using `?taxonomy=tax_name` are
still blocked during `parse_request`. It's only custom query vars -
`?tax_name=term` - that are affected by this change.

Props mboynes.
Fixes #21949.

git-svn-id: https://develop.svn.wordpress.org/trunk@35333 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:53:51 +00:00
Aaron Jorbin
8f2e001efe Replace Autoprefixer Core with Autoprefixer
Autoprefixer Core 5.2.1 -> Autoprefixer 6.0.3 https://github.com/postcss/autoprefixer/releases/tag/6.0.0
Package autoprefixer-core is deprecated in favour of autoprefixer as part of the 6.0.0 release:
Packages autoprefixer and autoprefixer-core were merged in 6.0 release.
Autoprefixer 6.0.0 requires PostCSS 5.0.10 or greater
PostCSS 0.5.4 -> 0.6.0 https://github.com/nDmitry/grunt-postcss/compare/v0.5.4...v0.6.0

You will need to update your dev dependencies after this change.

Props netweb
See #34177



git-svn-id: https://develop.svn.wordpress.org/trunk@35332 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:47:21 +00:00
Boone Gorges
e4b72ad5ca Don't force comment pagination.
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@35331 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:25:31 +00:00
Helen Hou-Sandi
11bd47beca Media: Update colors to match the times.
This bikeshed is a real nice blue.

props afercia.
fixes #34244. see #34388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35330 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:17:58 +00:00
Boone Gorges
75887ec865 Document title tests should expect dynamic blogname.
Fixes #31078.

git-svn-id: https://develop.svn.wordpress.org/trunk@35329 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:14:06 +00:00
Drew Jaynes
6c178fd1ab Docs: Add documentation in the form of a hash notation for default arguments accepted by wp_login_form().
Props ramiy for the initial patch.
Fixes #34364.


git-svn-id: https://develop.svn.wordpress.org/trunk@35328 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 15:37:23 +00:00
Helen Hou-Sandi
3d64414d5c wp_die(): Update colors and button styling.
see #34388, #31459.


git-svn-id: https://develop.svn.wordpress.org/trunk@35327 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 15:23:01 +00:00
Dominik Schilling (ocean90)
9a1b5f93cd List Tables: Replace the hyphen separator for titles and post/media states with a &mdash;.
Props McGuive7.
Fixes #23230.

git-svn-id: https://develop.svn.wordpress.org/trunk@35326 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:32:02 +00:00
Drew Jaynes
a28e35e462 Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES constants in [35286], use them in various places in core.
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:02:59 +00:00
Drew Jaynes
86794324c7 Docs: Improve the return description in the DocBlock for rest_send_allow_header().
Props danielbachhuber.
Fixes #34374.


git-svn-id: https://develop.svn.wordpress.org/trunk@35324 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 13:47:12 +00:00
Sergey Biryukov
bc2a538b1a REST API: Change nonce name to _wpnonce.
It's shorter and is compatible with the default name in `wp_nonce_field()`.

Props danielbachhuber.
Fixes #34375.

git-svn-id: https://develop.svn.wordpress.org/trunk@35323 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 08:13:18 +00:00
Sergey Biryukov
5bba750579 Add get_terms_defaults filter for the default arguments of get_terms().
Fixes #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35322 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 08:07:12 +00:00