Commit Graph

42377 Commits

Author SHA1 Message Date
Sergey Biryukov 6e94ee644f Site Health: Correct the quotes for the `tested` value of mock plugin data in auto-updates test.
Follow-up to [48584].

See #50662.

git-svn-id: https://develop.svn.wordpress.org/trunk@48587 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 20:11:07 +00:00
John Blackbourn 285fa03b3a Docs: First pass at some inline docs fixes mostly made by PHPCBF.
See #49572, #50744

git-svn-id: https://develop.svn.wordpress.org/trunk@48586 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 19:59:16 +00:00
John Blackbourn b6046636f0 Docs: Use more appropriate variable names in the inline docs for action and filter parameters.
See #49572

git-svn-id: https://develop.svn.wordpress.org/trunk@48585 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 19:04:38 +00:00
Jonathan Desrosiers c0d3d7627b Site Health: Pass all expected parameters to `auto_update_{$type}`.
This prevents fatal errors when other hooked functions are expecting both parameters. 

Props dd32, desrosj, audrasjb, pbiron.
Fixes #50662.

git-svn-id: https://develop.svn.wordpress.org/trunk@48584 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 19:01:24 +00:00
Sergey Biryukov 7ddd0a5702 I18N: Update "Default Template" string to match the sentence case used in the block editor.
Props ramiy.
Fixes #50742.

git-svn-id: https://develop.svn.wordpress.org/trunk@48583 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 18:53:25 +00:00
Jonathan Desrosiers 7d50110242 General: Ensure the database upgrades from [48575] are run.
This corrects the database version to match the commit number the upgrade changes were made.

See #50413.

git-svn-id: https://develop.svn.wordpress.org/trunk@48582 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 18:41:41 +00:00
Sergey Biryukov b554928e83 Tests: Update the `es_ES` string used in `wp_send_user_request()` tests to match the current translation.
Props a2hosting.
Fixes #50741.

git-svn-id: https://develop.svn.wordpress.org/trunk@48581 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 18:21:13 +00:00
Sergey Biryukov 6c17894e5e Docs: Add missing description for `wp_convert_widget_settings()` parameters.
Props stevenlinx.
Fixes #50738.

git-svn-id: https://develop.svn.wordpress.org/trunk@48580 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 13:48:37 +00:00
Sergey Biryukov a3427e3bb6 Coding Standards: Use a consistent naming pattern for variables in `wp-includes/comment-template.php`.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@48579 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 13:32:34 +00:00
Sergey Biryukov 8dc4165d46 I18N: Add context to privacy request status strings.
These strings already have a context in `create_initial_post_types()`, and should use the same context in `_wp_privacy_statuses()`.

Props ramiy, audrasjb.
Fixes #50740.

git-svn-id: https://develop.svn.wordpress.org/trunk@48578 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 13:10:40 +00:00
Sergey Biryukov c0920761a8 Docs: Improve description for `comment_id_fields()`.
Rename the `$id` parameter to `$post_id` for clarity.

Props stevenlinx.
Fixes #50737.

git-svn-id: https://develop.svn.wordpress.org/trunk@48577 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 13:09:50 +00:00
John Blackbourn 7d4c77560c Docs: Further corrections and improvements to various inline docblocks.
See #49572

git-svn-id: https://develop.svn.wordpress.org/trunk@48576 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 07:37:57 +00:00
Aaron Jorbin cefe2c7f7c General: Update code for readability and inclusion
There are two pieces in here:

1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks.

2) This improves backwards compatibility for code that was accessing the now deprecated code.

Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566]

Props: desrosj, SergeyBiryukov, johnjamesjacoby
Fixes: #50413



git-svn-id: https://develop.svn.wordpress.org/trunk@48575 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 03:12:49 +00:00
John Blackbourn 5e35ad2510 Docs: Various formatting improvements to inline docblocks.
See #49572

git-svn-id: https://develop.svn.wordpress.org/trunk@48574 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 00:50:57 +00:00
John Blackbourn 4b2abac911 Docs: Various corrections to inline docblocks.
See #49572

git-svn-id: https://develop.svn.wordpress.org/trunk@48573 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 00:46:56 +00:00
Jake Spurlock 447d25f090 Media: Add "loading" as an allowed kses image attribute
With loading="lazy" being added to all images in [47554], let's ensure that it passes kses attributes too.

Fixes #50731.
Props TimothyBlynJacobs, peterwilsoncc, azaozz. 



git-svn-id: https://develop.svn.wordpress.org/trunk@48572 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-23 00:42:48 +00:00
Timothy Jacobs e306fca2c1 REST API: Remove textdomain from doing it wrong message.
See #50075.
Props dlh.


git-svn-id: https://develop.svn.wordpress.org/trunk@48571 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 22:29:23 +00:00
Jake Spurlock 99736aea17 i18n: Merge similar translation strings in wp-admin/options.php
WARNING! is now Warning:

You have been warned.

Fixes #50715.
Props: ramiy, audrasjb, ocean90.



git-svn-id: https://develop.svn.wordpress.org/trunk@48570 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 22:19:25 +00:00
Jake Spurlock f976a73997 i18n: Merge similar translation strings to "Update failed".
Fixes #50714.
Props ramiy, ocean90.


git-svn-id: https://develop.svn.wordpress.org/trunk@48569 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 22:08:25 +00:00
Jake Spurlock 2c617a48f5 I18N: Merge similar "Installation failed" strings
Fixes #50708.

Props ramiy, ocean90, audrasjb.


git-svn-id: https://develop.svn.wordpress.org/trunk@48568 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 21:57:19 +00:00
Jake Spurlock 00f4e4f6e9 I18N: Update some strings to have periods.
Fixes #50707.
Props ramiy, afercia, audrasjb.


git-svn-id: https://develop.svn.wordpress.org/trunk@48567 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 21:53:22 +00:00
Jonathan Desrosiers 857d34590a General: Rename `remove_option_allowed_list()` to `remove_allowed_options()`.
This was missed in [48142] which renamed `add_option_allowed_list()` to `add_allowed_options()` for better readability. The two functions should have consistent names.

See #50413.

git-svn-id: https://develop.svn.wordpress.org/trunk@48566 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 18:50:30 +00:00
Sergey Biryukov d2a1fb965d Upgrade/Install: Don't trigger database upgrade on Ajax requests via `wp-admin/async-upload.php`.
Props schlessera, jgrodel, elrae, davidbaumwald, hareesh-pillai, adamsilverstein, SergeyBiryukov.
Fixes #39459.

git-svn-id: https://develop.svn.wordpress.org/trunk@48565 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 12:54:22 +00:00
Sergey Biryukov 60dc387ce9 Accessibility: Themes: Consistently use an underline for "Enable auto-updates" link and theme author link in theme overlay.
Props chetan200891, sabernhardt, afercia.
Fixes #50697.

git-svn-id: https://develop.svn.wordpress.org/trunk@48564 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 12:17:58 +00:00
Sergey Biryukov d6c7a479f4 Docs: Correct type and improve description for the `$fields` parameter of `WP_Query::parse_query()`.
Props ocean90, palmiak, johannadevos, noisysocks.
Fixes #44305.

git-svn-id: https://develop.svn.wordpress.org/trunk@48563 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 11:34:32 +00:00
Sergey Biryukov e88e84c662 Docs: Improve formatting of the `$fields` parameter description in `WP_Term_Query::__construct()`.
See #44305, #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@48562 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 11:33:51 +00:00
Sergey Biryukov 3d2cd19b4f Docs: Correct type for the `$theme` parameter of `theme_auto_update_debug_string` filter.
Follow-up to [48546], [48549], [48552].

See #50663.

git-svn-id: https://develop.svn.wordpress.org/trunk@48561 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 00:27:36 +00:00
Sergey Biryukov 712f548664 Site Health: Fix some typos in the test for plugin and theme auto-updates.
Follow-up to [48548], [48558], [48559].

See #50662.

git-svn-id: https://develop.svn.wordpress.org/trunk@48560 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 00:15:33 +00:00
Sergey Biryukov 874e6afdca Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates.
Follow-up to [48548], [48558].

See #50662.

git-svn-id: https://develop.svn.wordpress.org/trunk@48559 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 00:13:21 +00:00
Sergey Biryukov 8cbd2ca439 Site Health: Add the test for plugin and theme auto-updates to `WP_Site_Health::get_tests()`.
This ensures that the test actually runs.

Follow-up to [48548].

See #50662.

git-svn-id: https://develop.svn.wordpress.org/trunk@48558 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-22 00:05:45 +00:00
Sergey Biryukov f840dabcc6 Widgets: Make sure image widgets with custom image size render captions.
Props kasparsd, JavierCasares, audrasjb.
Fixes #50160.

git-svn-id: https://develop.svn.wordpress.org/trunk@48557 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 23:12:22 +00:00
Sergey Biryukov 3da487037d REST API: Use consistent error messages when managing network plugins.
Props ramiy.
Fixes #50729.

git-svn-id: https://develop.svn.wordpress.org/trunk@48556 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 21:59:46 +00:00
Timothy Jacobs df8399dce5 REST API: Optimize rest_filter_response_by_context performance.
In [47758] a new function `rest_filter_response_by_context` was introduced to expand the JSON schema features supported by the context filtering mechanism.

This commit improves the performance of that function by eliminating repetitive comparisons and loops. Additionally, it improves multi-type support for object + array types.

Fixes #50700.
Props dlh.


git-svn-id: https://develop.svn.wordpress.org/trunk@48555 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 21:20:22 +00:00
Sergey Biryukov b11757e4ed Site Health: Use a consistent label for theme auto-updates in debug data.
Props audrasjb.
Fixes #50728.

git-svn-id: https://develop.svn.wordpress.org/trunk@48554 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 21:04:57 +00:00
Sergey Biryukov 26362089c5 Sitemaps: Rename `wp_register_sitemap()` to `wp_register_sitemap_provider()`.
Follow-up to [48536], [48540], [48541].

Props pbiron.
Fixes #50724.

git-svn-id: https://develop.svn.wordpress.org/trunk@48553 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 20:13:59 +00:00
Sergey Biryukov 44335fdc43 Site Health: Simplify the logic for displaying whether auto-updates are enabled for plugins and themes.
Remove some extra variables.

Follow-up to [48546], [48549].

See #50663.

git-svn-id: https://develop.svn.wordpress.org/trunk@48552 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 18:42:24 +00:00
Jake Spurlock 9875847c9e WordPress 5.5 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@48551 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 17:54:05 +00:00
Jake Spurlock f3a6fc5716 WordPress 5.5 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@48550 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 17:30:06 +00:00
Sergey Biryukov 6440e85a2c Site Health: Rename the filters added in [48546] for clarity.
See #50663.

git-svn-id: https://develop.svn.wordpress.org/trunk@48549 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 17:06:55 +00:00
Jake Spurlock 5e14b1b5fd Site Health: Add tests to check for potential issues with plugin and theme auto-updates.
Fixes #50662.
Props desrosj, audrasjb.


git-svn-id: https://develop.svn.wordpress.org/trunk@48548 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 17:06:00 +00:00
Sergey Biryukov ffef4daf88 Media: Pass the attachment ID to the `wp_image_file_matches_image_meta` filter.
Props spacedmonkey.
Fixes #50722.

git-svn-id: https://develop.svn.wordpress.org/trunk@48547 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 16:52:48 +00:00
Jake Spurlock 11fe34deb8 Site Health: Add auto-update information to for plugins and themes.
New filters:

* `plugin_auto_update_debug_str`
* `theme_auto_update_debug_str`

Fixes #50663.
Props pbiron, audrasjb, davidbaumwald.


git-svn-id: https://develop.svn.wordpress.org/trunk@48546 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 16:52:47 +00:00
Sergey Biryukov e10083b7de I18N: Add context to some theme strings for consistency.
Props ramiy, ocean90.
Fixes #50709.

git-svn-id: https://develop.svn.wordpress.org/trunk@48545 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 16:31:06 +00:00
Sergey Biryukov 0da858ffae Site Health: Rename `upload_max` array key in file upload checks to `max_effective_size` for clarity.
Follow-up to [48535].

See #50038.

git-svn-id: https://develop.svn.wordpress.org/trunk@48544 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 16:18:53 +00:00
Pascal Birchler 7bcdf886c0 Sitemaps: Replace `wp_sitemaps_register_providers` filter with more suitable `wp_sitemaps_add_provider` filter.
The previous filter failed the goal of allowing developers to filter all providers before they are registered, since it only filtered the built-in ones.

The more specific `wp_sitemaps_add_provider` filter enables exactly that, as it filters every sitemap provider right before it is added to the sitemaps registry.

Props pbiron, pfefferle, Chouby, swissspidy.
Fixes #50660.

git-svn-id: https://develop.svn.wordpress.org/trunk@48543 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 16:12:49 +00:00
Jonathan Desrosiers bea9ce74a7 Administration: Ensure SVG icons in admin menus are correctly colored.
Props ryelle.
Fixes #50555.

git-svn-id: https://develop.svn.wordpress.org/trunk@48542 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 16:08:44 +00:00
Sergey Biryukov 8c7fe179da Sitemaps: Rename `wp_get_sitemaps_providers()` to `wp_get_sitemap_providers()`.
Follow-up to [48536], [48540].

Props pbiron, swissspidy, SergeyBiryukov.
See #50724.

git-svn-id: https://develop.svn.wordpress.org/trunk@48541 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 16:04:35 +00:00
Pascal Birchler 83b94f5cd6 Sitemaps: Rename `wp_get_sitemaps()` to `wp_get_sitemaps_providers()`
Following [48536], rename the function to match the rest of the sitemaps logic.

Also eliminates some dead code after [48523].

Props pbiron.
See #50724. See #50643.

git-svn-id: https://develop.svn.wordpress.org/trunk@48540 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 15:55:21 +00:00
Sergey Biryukov 3269e83801 Site Health: Move `post_max_size` and `upload_max_filesize` out of a translatable string in file upload checks.
Simplify some other strings, use a consistent format for translator comments.

Follow-up to [48535].

See #50038.

git-svn-id: https://develop.svn.wordpress.org/trunk@48539 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 15:51:22 +00:00
Sergey Biryukov 0d956d4013 Site Health: Remove `parse_ini_size()`, use the existing `wp_convert_hr_to_bytes()` function instead.
Follow-up to [48535].

See #50038.

git-svn-id: https://develop.svn.wordpress.org/trunk@48538 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-21 15:38:40 +00:00