Commit Graph

93 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
0cc1c11049 Users: Don't show roles dropdown on user-edit.php if current user cannot promote user.
Fixes #43580.

git-svn-id: https://develop.svn.wordpress.org/trunk@42856 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-19 20:55:20 +00:00
Sergey Biryukov
1fddd69163 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.

Fixes #43523.

git-svn-id: https://develop.svn.wordpress.org/trunk@42827 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-11 16:43:59 +00:00
Sergey Biryukov
21258c9bc7 Users: After [41163], add a notice for Email field on Profile screen that the new address will not become active until confirmed.
Props dilipbheda.
Fixes #43106. See #16470.

git-svn-id: https://develop.svn.wordpress.org/trunk@42688 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 12:22:21 +00:00
Gary Pendergast
8f95800d52 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-30 23:09:33 +00:00
Gary Pendergast
f797c252d9 General: Reformat inline if () statements inside HTML tags.
This pattern occurs a handful of times across the codebase:

`<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">`

Unfortunately, it doesn't really play nicely with `phpcbf`, so all instances need to be removed in preperation for auto code formatting.

See #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42217 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-23 04:08:42 +00:00
Dominik Schilling (ocean90)
187f352e9d Taxonomy/Users: Use correct escaping function for URLs.
git-svn-id: https://develop.svn.wordpress.org/trunk@41522 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 21:13:32 +00:00
Dominik Schilling (ocean90)
7be5b80976 Taxonomy/Users: Provide a fallback for incorrect HTTP referrers.
git-svn-id: https://develop.svn.wordpress.org/trunk@41398 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 09:12:27 +00:00
Weston Ruter
dbace684e2 Editor: Add CodeMirror-powered code editor with syntax highlighting, linting, and auto-completion.
* Code editor is integrated into the Theme/Plugin Editor, Additional CSS in Customizer, and Custom HTML widget. Code editor is not yet integrated into the post editor, and it may not be until accessibility concerns are addressed.
* The CodeMirror component in the Custom HTML widget is integrated in a similar way to TinyMCE being integrated into the Text widget, adopting the same approach for integrating dynamic JavaScript-initialized fields.
* Linting is performed for JS, CSS, HTML, and JSON via JSHint, CSSLint, HTMLHint, and JSONLint respectively. Linting is not yet supported for PHP.
* When user lacks `unfiltered_html` the capability, the Custom HTML widget will report any Kses-invalid elements and attributes as errors via a custom Kses rule for HTMLHint.
* When linting errors are detected, the user will be prevented from saving the code until the errors are fixed, reducing instances of broken websites.
* The placeholder value is removed from Custom CSS in favor of a fleshed-out section description which now auto-expands when the CSS field is empty. See #39892.
* The CodeMirror library is included as `wp.CodeMirror` to prevent conflicts with any existing `CodeMirror` global.
* An `wp.codeEditor.initialize()` API in JS is provided to convert a `textarea` into CodeMirror, with a `wp_enqueue_code_editor()` function in PHP to manage enqueueing the assets and settings needed to edit a given type of code.
* A user preference is added to manage whether or not "syntax highlighting" is enabled. The feature is opt-out, being enabled by default.
* Allowed file extensions in the theme and plugin editors have been updated to include formats which CodeMirror has modes for: `conf`, `css`, `diff`, `patch`, `html`, `htm`, `http`, `js`, `json`, `jsx`, `less`, `md`, `php`, `phtml`, `php3`, `php4`, `php5`, `php7`, `phps`, `scss`, `sass`, `sh`, `bash`, `sql`, `svg`, `xml`, `yml`, `yaml`, `txt`.

Props westonruter, georgestephanis, obenland, melchoyce, pixolin, mizejewski, michelleweber, afercia, grahamarmfield, samikeijonen, rianrietveld, iseulde.
See #38707.
Fixes #12423, #39892.


git-svn-id: https://develop.svn.wordpress.org/trunk@41376 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-13 06:07:48 +00:00
John Blackbourn
34ee8c9d28 Users: Require a confirmation link in an email to be clicked when a user attempts to change their email address.
This adds this previously Multisite-only functionality to single site installations too. This change prevents accidental or erroneous email address changes from potentially locking users out of their account.

Props rodrigosprimo, tharsheblows, johnbillion

Fixes #16470


git-svn-id: https://develop.svn.wordpress.org/trunk@41163 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-27 02:09:51 +00:00
Sergey Biryukov
fa174e4a06 Users: Display the name of user being edited on Edit User screen.
Props seanchayes.
Fixes #28182.

git-svn-id: https://develop.svn.wordpress.org/trunk@39907 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 07:13:11 +00:00
Andrea Fercia
7417527b4b Accessibility: Remove inappropriate content from the Edit User screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39538 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 22:07:14 +00:00
John Blackbourn
93a5849d7e Users: Style the super admin message on the user editing screen as a notice, not a success message.
Fixes #39131


git-svn-id: https://develop.svn.wordpress.org/trunk@39531 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 01:27:13 +00:00
Dominik Schilling (ocean90)
257026f7a3 I18N: In wp_dropdown_languages() rename the new show_site_locale_default argument to show_option_site_default.
This makes it consistent with arguments of other `wp_dropdown_*()` functions.

Props SergeyBiryukov.
See #38632.
Fixes #38871.

git-svn-id: https://develop.svn.wordpress.org/trunk@39331 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-21 16:14:01 +00:00
Pascal Birchler
21e874e00a I18N: Add ability to change user's locale back to site's locale.
Previously there was no way to remove the user locale setting again, even though that might be desirable.

This adds a new 'Site Default' option to the user-specific language setting by introducing a new `show_site_locale_default` argument to `wp_dropdown_languages()`.

Props ocean90.
See #29783.
Fixes #38632.

git-svn-id: https://develop.svn.wordpress.org/trunk@39169 602fd350-edb4-49c9-b593-d223f7449a82
2016-11-08 23:00:38 +00:00
Dominik Schilling (ocean90)
f4b61df0e4 I18N: Don't use get_user_option() for retrieving user's language.
`get_user_option()` checks for both option types, site and network. Since `locale` is only a network option we can directly access the field via `WP_User`s magic getter.

Props johnjamesjacoby.
Fixes #38578.

git-svn-id: https://develop.svn.wordpress.org/trunk@39040 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-30 22:25:34 +00:00
Dominik Schilling (ocean90)
7d378f82d0 I18N: Use correct value for the for attribute of the user language setting label.
Props johnjamesjacoby.
Fixes #38576.

git-svn-id: https://develop.svn.wordpress.org/trunk@39039 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-30 21:57:17 +00:00
Pascal Birchler
5224e2bd84 I18N: Improve "Site Language" label for per-user language selection.
Renames the label to "Language" and adds an explanation of the feature to the help tab.

Props johnbillion, jorbin.
Fixes #38344.

git-svn-id: https://develop.svn.wordpress.org/trunk@38856 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-21 10:40:02 +00:00
Andrea Fercia
050d2d9a25 Accessibility: Remove target=_blank from the Users and Widgets screens help tabs links.
Stop taking control of users' browsers.

Props rianrietveld.
Fixes #38217. See #23432.


git-svn-id: https://develop.svn.wordpress.org/trunk@38723 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-04 07:09:12 +00:00
Pascal Birchler
f231e7233d I18N: Introduce a user-specific language setting.
By enabling the user to select their preferred locale when editing the profile, we allow for greater personalization of the WordPress admin and therefore a better user experience.

The back end will be displayed in the user's individual locale while the locale used on the front end equals the one set for the whole site. If the user didn't specify a locale, the site's locale will be used as a fallback. The new `locale` property of the `WP_User` class can be used to retrieve the user's locale setting.

Props ocean90, ipm-frommen, swissspidy.
Fixes #29783.

git-svn-id: https://develop.svn.wordpress.org/trunk@38705 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-03 07:03:41 +00:00
Andrea Fercia
ee7f970ffa Administration: Improve the usage of the button CSS classes.
Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

- Adds the `button` class to all primary buttons make them responsive
- Removes all `secondary-button` classes and replaces it with button when needed. `button-secondary` shouldn't be used and exists just for backward compatibility reasons
- Replaces classes inside `submit_button()` with a shorthand for some buttons, and use an empty string for the default `button` class. Passing `button` is unnecessary
- Adjusts `get_submit_button()` to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.


git-svn-id: https://develop.svn.wordpress.org/trunk@38672 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-28 19:53:07 +00:00
Sergey Biryukov
6c1e64d76d Users: Pass $profileuser parameter to user_profile_picture_description filter on "Edit User" screen.
Props turtlepod, deremohan.
Fixes #37379.

git-svn-id: https://develop.svn.wordpress.org/trunk@38481 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-31 21:12:29 +00:00
Peter Wilson
f71ae5a0bb Users: Check zxcvbn is defined before calling.
Prevents JavaScript errors by checking zxcvbn is defined before calling.

Changes `wp.passwordStrength.meter()` to return `-1` if the strength of the password is unknown.

On the user profile screen, `generatePassword()` checks if the user has entered the password before setting the value of the password input box.

Props peterwilsoncc, adamsilverstein.
Fixes #34905.


git-svn-id: https://develop.svn.wordpress.org/trunk@37940 602fd350-edb4-49c9-b593-d223f7449a82
2016-07-01 12:44:43 +00:00
Dominik Schilling (ocean90)
206380180e Text Changes: Unify permission error messages.
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.

Props ramiy, Presskopp.
Fixes #34521.

git-svn-id: https://develop.svn.wordpress.org/trunk@37914 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-29 15:15:40 +00:00
Drew Jaynes
1cd420af5e Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37488 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:00:23 +00:00
Dominik Schilling (ocean90)
7987d26847 Multisite: Validate new email address confirmations.
git-svn-id: https://develop.svn.wordpress.org/trunk@37103 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 14:44:00 +00:00
jeremyfelt
95ba2c38c0 Multisite: Provide an "Edit user" link after adding a new user
Props codex-m, jeremyfelt.
Fixes #35705.


git-svn-id: https://develop.svn.wordpress.org/trunk@36695 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 21:42:02 +00:00
Dominik Schilling (ocean90)
8b8312f822 Multisite: Switch to a usermeta key for email confirmation.
To prevent inconsistent data across sites in a network the new email address is now stored in usermeta. Adds visual feedback for the case when an update has failed.
All existing options will be removed on a database upgrade.

Props MikeHansenMe, kovshenin, jeremyfelt, ocean90.
Fixes #23358.

git-svn-id: https://develop.svn.wordpress.org/trunk@36679 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 15:33:14 +00:00
Sergey Biryukov
e34ce471af I18N: Remove <a> tag from translatable string in wp-admin/user-edit.php.
Add translator comment.

Props ramiy.
Fixes #35672.

git-svn-id: https://develop.svn.wordpress.org/trunk@36655 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-23 23:26:44 +00:00
Sergey Biryukov
242709ce40 Users: Only show the profile picture if 'Show Avatars' option in Discussion Settings is enabled.
Props ocean90.
See #32286.

git-svn-id: https://develop.svn.wordpress.org/trunk@35613 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-11 19:40:44 +00:00
Sergey Biryukov
7674a767ed Users: Add user's Gravatar to 'About the user' section on user profile page.
Add `user_profile_picture_description` filter for the description text displayed under the Gravatar.

Props carolinegeven, obrienlabs, SergeyBiryukov.
Fixes #32286.

git-svn-id: https://develop.svn.wordpress.org/trunk@35610 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-11 19:27:11 +00:00
Jeremy Felt
599fb50e09 Revert [34778], continue using _site_option() for the current network.
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34912 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 17:11:01 +00:00
Jeremy Felt
3c177b8c6f MS: Use *_network_option() functions throughout core.
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@34778 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-02 19:07:23 +00:00
Drew Jaynes
11e0b8d0b0 Docs: Fix a minor typo from [34592]. Meant to be past-tense, not present.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34593 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:13:50 +00:00
Drew Jaynes
b68ae42ddd Docs: Add missing parameter documentation for $profileuser in the hook doc for show_password_fields, added in [11302].
Also adds a changelog entry for when the parameter was introduced.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34592 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:10:47 +00:00
Drew Jaynes
35837a00b7 Docs: Relocate the hook doc for the show_password_fields filter to its duplicate, since the original was removed in [34582].
Adds a changelog entry noting the adjustment in behavior, and simplifies the conditional logic.

Fixes #15115.


git-svn-id: https://develop.svn.wordpress.org/trunk@34590 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:04:23 +00:00
Scott Taylor
96a40d6102 Move 2 ad hoc user admin functions:
* Move `use_ssl_preference()` from `wp-admin/user-edit.php` to `wp-admin/includes/user.php`.
* Move `admin_created_user_email()` from `wp-admin/user-new.php` to `wp-admin/includes/user.php`.

See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34021 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:32:46 +00:00
Andrea Fercia
7b3b1c12d5 Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens.
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].

Fix a typo in the DocBlock for the `additional_capabilities_display` filter.

Props metodiew.
Fixes #33606. See #31650.

git-svn-id: https://develop.svn.wordpress.org/trunk@33909 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 18:29:40 +00:00
Helen Hou-Sandi
0c19c94561 Drop the hyphen from e-mail and standardize on email.
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.


git-svn-id: https://develop.svn.wordpress.org/trunk@33774 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:16:02 +00:00
Scott Taylor
68ff8b1a80 Passwords UI: clean up the new JS in wp-admin/js/user-profile.js.
Instead of wrapping `#pass1` in a `<span>` dynamically, add the `<span>` to the HTML in PHP. It currently has no styling.

Fixes #33145.


git-svn-id: https://develop.svn.wordpress.org/trunk@33450 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-27 21:24:36 +00:00
Mark Jaquith
80c9c8cfca Toggle between dashicons-hidden and dashicons-visibility in the password hide/show button.
fixes #33135

git-svn-id: https://develop.svn.wordpress.org/trunk@33438 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-27 03:12:55 +00:00
Sergey Biryukov
a3f2503ddc Update help text after [33368].
fixes #33082.

git-svn-id: https://develop.svn.wordpress.org/trunk@33420 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-26 01:51:18 +00:00
Sergey Biryukov
7214dc6fb4 Remove unused pw-weak ID attributes.
see #33077.

git-svn-id: https://develop.svn.wordpress.org/trunk@33419 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-26 00:57:21 +00:00
Mark Jaquith
bc7ad4b965 Improve the "sessions" section strings.
fixes #33082
props johnjamesjacoby

git-svn-id: https://develop.svn.wordpress.org/trunk@33368 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 20:49:55 +00:00
Mark Jaquith
1a8b292ab6 Move password and session items into "Account Management" profile section.
fixes #33080
props johnjamesjacoby

git-svn-id: https://develop.svn.wordpress.org/trunk@33367 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 20:44:30 +00:00
Mark Jaquith
9ca3978a3e Introduce a Cancel button and onUnload warning for password changes.
fixes #33079
props johnjamesjacoby

git-svn-id: https://develop.svn.wordpress.org/trunk@33364 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 18:35:51 +00:00
Mark Jaquith
fece657158 Fix up and normalize pw_weak/pw-weak IDs and labels.
props johnjamesjacoby
fixes #33077

git-svn-id: https://develop.svn.wordpress.org/trunk@33363 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 17:23:27 +00:00
Konstantin Obenland
2ab769b1b9 Passwords: Add password strength meter feedback for screen readers.
Also gives context to the show/hide button.

Props rianrietveld, afercia.
Fixes #33032.



git-svn-id: https://develop.svn.wordpress.org/trunk@33353 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-22 00:14:37 +00:00
Konstantin Obenland
a48af6ef86 Passwords: Make show/hide toggle translatable.
See #32589.


git-svn-id: https://develop.svn.wordpress.org/trunk@33249 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:34:18 +00:00
Konstantin Obenland
05c4803450 Passwords: New UI for install screen.
Also synchronises the use of `pw_weak` as an input name and removes trailing
periods from checkbox labels.

Props MikeHansenMe, adamsilverstein, obenland.
See #32589.



git-svn-id: https://develop.svn.wordpress.org/trunk@33246 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:21:39 +00:00
Dominik Schilling (ocean90)
55de610283 Add/Edit User: Move weak password label to the checkbox.
props paulwilde.
fixes #32908.

git-svn-id: https://develop.svn.wordpress.org/trunk@33137 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 21:27:25 +00:00