Commit Graph

1006 Commits

Author SHA1 Message Date
Sergey Biryukov
6d2ca4edba Twenty Twenty: Make checkbox in comment form larger.
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb, ianbelanger.
Merges [46844] to the 5.3 branch.
Fixes #48652.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46847 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 14:30:27 +00:00
Sergey Biryukov
0df37cb856 Twenty Twenty: Correct alignment for embedded Instagram posts.
Props SGr33n, audrasjb, nielslange, JarretC.
Merges [46840] to the 5.3 branch.
Fixes #48688.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46841 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 13:38:50 +00:00
Sergey Biryukov
f5afff0560 Twenty Twenty: Pass $post_meta and $location values to twentytwenty_start_of_post_meta_list and twentytwenty_end_of_post_meta_list actions to provide better context.
Props msaari, SergeyBiryukov.
Merges [46832] to the 5.3 branch.
Fixes #48906.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46833 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 11:49:15 +00:00
Sergey Biryukov
5485536237 Twenty Twenty: Replace Smooth Scroll JS implementation with scroll-behavior CSS property.
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Merges [46824] to the 5.3 branch.
Fixes #48763, #48551, #48866.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46825 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-07 11:06:06 +00:00
Jonathan Desrosiers
8f25de113e Bundled Themes: Fixes JS TypeError in Twenty Twenty.
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx, ianbelanger.
Fixes #48601.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46787 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-26 18:41:31 +00:00
Sergey Biryukov
03b7f795f5 Twenty Twenty: Fix typos in a variable name and inline comment in assets/js/color-calculations.js.
Props tanvirul.
Merges [46747] to the 5.3 branch.
Fixes #48704.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46769 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-24 11:03:05 +00:00
Sergey Biryukov
9b6286fd43 Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile.
Props nielslange, Anlino.
Merges [46762] to the 5.3 branch.
Fixes #48619.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46767 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-24 10:59:16 +00:00
Sergey Biryukov
c293937438 Twenty Twenty: Remove duplicate array key/value in TwentyTwenty_Non_Latin_Languages::get_non_latin_css().
Props manikmist09.
Merges [46765] to the 5.3 branch.
Fixes #48624.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46766 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-24 10:57:24 +00:00
Sergey Biryukov
4874ee7539 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Merges [46722] to the 5.3 branch.
Fixes #48571.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46723 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 18:24:42 +00:00
Sergey Biryukov
fa56af86d8 Bundled Themes: Update copyright year in readme.txt.
Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Merges [46719] and [46720] to the 5.3 branch.
Fixes #48566.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46721 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 18:04:34 +00:00
Sergey Biryukov
d7de7823ea Bundled Themes: Update Twenty Twenty.
* Add `.has-background` excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46715] to the 5.3 branch.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46716 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 02:06:19 +00:00
Sergey Biryukov
c898d6e1ec Bundled Themes: Update Twenty Twenty.
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46713] to the 5.3 branch.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46714 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 01:44:51 +00:00
Sergey Biryukov
029d6e17c8 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see c267289...ab5fa23.

Reviewed by SergeyBiryukov.
Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07, allancole, karmatosed, pierlo, joen, ianbelanger.
See #48110, #48386, #48450, #48505.
Merges [46701], [46702], [46711] to the 5.3 branch.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46712 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 21:03:55 +00:00
Sergey Biryukov
22e9dadef6 Bundled Themes: Standardize the Required PHP and Tested Up To headers.
This change makes several changes to ensure consistency and accuracy for default theme headers:

- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.

Props Otto42, afragen.
Merges [46676] to the 5.3 branch.
Fixes #48517.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46699 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 11:37:42 +00:00
Jonathan Desrosiers
40dcc57154 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46669 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 22:28:25 +00:00
Jonathan Desrosiers
1be86768b2 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46571], see 4549fd9...dea9290.

Reviewed by ianbelanger, SergeyBiryukov, desrosj.
Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Merges [46613] to the 5.3 branch.
Fixes #48450.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46614 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-29 16:40:34 +00:00
Jonathan Desrosiers
a8fa07371f Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46551], see bc89c51...4549fd9.

Reviewed by SergeyBiryukov, desrosj, ianbelanger.
Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, intimez, itowhid06, decrecementofeliz, aristath, westonruter, mukesh27, jorgefilipecosta, karmatosed.
Fixes #48386.

git-svn-id: https://develop.svn.wordpress.org/trunk@46571 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-22 18:25:45 +00:00
desrosj
2b3fc3211f Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46445], see 7246fd6...bc89c51.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyously, mahesh901122, josephscott, byalextran, amolv, Clorith.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46551 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 18:45:02 +00:00
Jonathan Desrosiers
d4e9608dec Bundled Themes: Update/audit NPM dependencies for Twenty Nineteen.
Also, ignore the `node_modules` folder for Twenty Nineteen.

Fixes #48262.

git-svn-id: https://develop.svn.wordpress.org/trunk@46450 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 22:17:54 +00:00
Dominik Schilling
e20a6135e4 Bundled Themes: Fix JSHint error in [46445]
Props ianbelanger.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46447 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:50:54 +00:00
Jonathan Desrosiers
f95a75b783 Bundled Themes: Update Twenty Twenty.
This brings `trunk`'s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46357], see 7157870...7246fd6.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyusly, luminuu, itowhid06, cbravobernal, intimez, glauberglauber, ocean90, amolv, briceduclos, aristath, mukesh27, garrett-eclipse, audrasjb, afercia, dianeco, utsav72640, mahesh901122, tobifjellner.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46445 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:05:53 +00:00
Sergey Biryukov
9ec0161373 Twenty Fourteen: Replace overly broad float-clearing selectors with more specific ones, to avoid unintentionally targeting elements generated by plugins.
Props ianbelanger, iandunn, karmatosed.
Fixes #35779.

git-svn-id: https://develop.svn.wordpress.org/trunk@46430 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 02:00:24 +00:00
Sergey Biryukov
683309fc44 Twenty Fourteen: Ensure the content after the Read More tag is visible and has the appropriate padding.
Props ianbelanger, sabernhardt, slobodanmanic, Quantumstate, Gwendydd, andraganescu, francina.
Fixes #28967.

git-svn-id: https://develop.svn.wordpress.org/trunk@46429 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 01:52:26 +00:00
Jonathan Desrosiers
f905d80e77 Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46271], see 932b16248...dd7032f

Props anlino, ianbelanger, nielslange, acosmin, netweb, williampatton, adhitya03, phpdocs, acalfieri, itowhid06, littlebigthing, aristath, karmatosed, poena.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46357 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:40:14 +00:00
Sergey Biryukov
d6aa801691 Twenty Nineteen: Remove trailing comma after selector in sass/site/primary/_posts-and-pages.scss.
Props itowhid06.
Fixes #48171.

git-svn-id: https://develop.svn.wordpress.org/trunk@46347 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 22:39:20 +00:00
Jake Spurlock
fd0b230dcd Themes: Fix javascript regression that linter found.
Tests were failing from line length optimizations and double quotes. 

Fixes #37536


git-svn-id: https://develop.svn.wordpress.org/trunk@46310 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 22:11:11 +00:00
Jake Spurlock
6649b3638c Themes: Improve Twenty Fifteen sticky sidebar logic
The current logic in TwentyFifteen (#30366) for making the sidebar sticky while still allowing to scroll through it when the sidebar height is larger than the viewport height is flawed and massively overcomplicated.
This can be mitigated by removing the admin bar specific logic and leaving most of the heavy lifting up to the browser.

Fixes #37536

Props DvanKooten, lukecavanagh, karmatosed, ianbelanger, davidbaumwald



git-svn-id: https://develop.svn.wordpress.org/trunk@46308 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 21:37:09 +00:00
Sergey Biryukov
197d99a589 Twenty Twenty: Rename widget areas to sidebar-1 and sidebar-2.
This ensures that widgets are mapped correctly and is consistent with the previous default themes.

See https://github.com/WordPress/twentytwenty/issues/481.

Reverts [46282].

Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46283 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-23 23:16:59 +00:00
Jonathan Desrosiers
e256cb1bef Bundled Themes: Fix failing tests for Twenty Twenty.
Follow up of [46271].

See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46277 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-23 20:53:02 +00:00
Jonathan Desrosiers
509647e568 Bundled Themes: Import Twenty Twenty, the new default theme for WordPress 5.3.
Welcome to the bundled themes family!

Theme development to this point has taken place on GitHub. See: https://github.com/WordPress/twentytwenty/.

Props anlino, ianbelanger, audrasjb, nielslange, fabiankaegy, mukesh27, poena, joyously, emiluzelac, williampatton, dingo-d, dkarfa, acosmin, rabmalin, kafleg, jeffpaul, hareesh-pillai, burhandodhy, afercia, juanfra, soean, presskopp, justinahinon, jrf, netweb, garyj, pento, flixos90, vbaimas, zebulan, byalextran, mor10, kjellr, allancole, tdh, karmatosed, mapk, matt, andrewtaylor-1, ismailelkorchi, garrett-eclipse, gsayed786, dianeco, celloexpressions, aristath, nadir, cbravobernal, intimez, hometowntrailers, collet, littlebigthing, tobifjellner, kevinkovadia, jarretc.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46271 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-23 20:14:50 +00:00
Andrea Fercia
975812c783 Accessibility: Twenty Nineteen: Improve the special pages headings.
Improves information provided by the headings, their alignment and spacing in the following special pages:
- search page with and without search results
- 404 page (no content)
- archive pages

Props ianbelanger, kjellr, nrqsnchz, audrasjb.
Fixes #47140.


git-svn-id: https://develop.svn.wordpress.org/trunk@46234 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-22 21:58:06 +00:00
Andrea Fercia
f326f7ebfb Accessibility: Bundled Theme: Make the TwentyEleven skip link the first focusable element within the body.
Props poena, williampatton.
Fixes #47891.


git-svn-id: https://develop.svn.wordpress.org/trunk@46195 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-20 11:40:06 +00:00
SergeyBiryukov
baaaef5b63 Bundled Themes: Declare HTML5 support for scripts and styles.
Fixes #42804.

git-svn-id: https://develop.svn.wordpress.org/trunk@46165 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-18 14:50:02 +00:00
Sergey Biryukov
3ac6f6a8f8 Bundled Themes: Update the message shown when a comment is awaiting moderation.
If the commenter doesn't have cookies set, they won't see the comment preview again. Showing an expanded message will help offset any confusion if they revisit the site later, and their comment is still in moderation, but they can't see it anymore.

Props birgire, superpoincare.
Fixes #47461. See #43857.

git-svn-id: https://develop.svn.wordpress.org/trunk@46117 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-14 20:59:29 +00:00
Sergey Biryukov
159c78c853 Docs: Fix placement of some duplicate hook references.
Hook documentation should be on the line directly above the line containing the `do_action()` or `apply_filters()` call. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of duplicate hook references.

Includes minor code layout fixes.

See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46088 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-10 19:22:07 +00:00
Andrea Fercia
a1fd37e413 Bundled Theme: Twenty Nineteen: Use human-friendly color names.
For better accessibility, the Primary and Secondary theme colors have now more understandable names.
Changes the names "Primary" and "Secondary" to "Blue" and "Dark Blue". Fallbacks to the `hex` color codes when the theme is set to use a custom Primary color.

Props kjellr, aduth, audrasjb.
Fixes #46698.


git-svn-id: https://develop.svn.wordpress.org/trunk@45964 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:45:58 +00:00
Andrea Fercia
8aab6352f2 Bundled Theme: Twenty Nineteen: Fix the nesting of the main element.
The `main` element must not appear as a descendant of the `section` element. Correct markup is the first requirement to make user agents and assistive technologies work properly.

Changes the `<section>` element that was wrapping the `<main>` element to a `<div>`.

Props albertomake, ryelle, desrosj, ianbelanger, audrasjb.
Fixes #47066.


git-svn-id: https://develop.svn.wordpress.org/trunk@45942 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:26:50 +00:00
Sergey Biryukov
00b03f2a6f I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.

git-svn-id: https://develop.svn.wordpress.org/trunk@45932 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-03 00:39:13 +00:00
Sergey Biryukov
27c877e2b9 Twenty Nineteen: Remove unused jQuery argument passed to an IIFE that accepts no arguments.
Props Christian1012, hareesh-pillai.
Fixes #40333.

git-svn-id: https://develop.svn.wordpress.org/trunk@45923 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-31 20:52:07 +00:00
Sergey Biryukov
08a91859dd Twenty Seventeen: Remove unused jQuery argument passed to an IIFE that accepts no arguments.
Props Christian1012, hareesh-pillai.
See #40333.

git-svn-id: https://develop.svn.wordpress.org/trunk@45922 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-31 20:51:45 +00:00
Sergey Biryukov
9abbd90d30 Twenty Nineteen: Correct file name in JS DocBlocks.
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@45921 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-31 20:42:27 +00:00
Sergey Biryukov
9445634e0c Twenty Nineteen: Improve compatibility with custom colors in the separator block.
Props kjellr.
Fixes #47811.

git-svn-id: https://develop.svn.wordpress.org/trunk@45920 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-30 19:14:23 +00:00
Sergey Biryukov
6f22a931ff Twenty Nineteen: Remove Baskerville Old Face from the font stack due to several shortcomings:
* Being difficult to read due to its mix of thin and thick strokes.
* Having poor language/extended character support.
* Not having other weights/styles (bold, italic, etc) and relying on browser approximations of those variants.

The next fonts down the stack (Garamond and Times) are more properly aligned to the appearance of the top-level serif font in the stack (Hoefler Text), and work better in its place.

Props kjellr, Rarst, justintadlock.
Fixes #45881.

git-svn-id: https://develop.svn.wordpress.org/trunk@45919 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-30 18:57:51 +00:00
Sergey Biryukov
ef69d4ba14 Twenty Nineteen: Make sure center-aligned images in columns do not break beyond the column boundaries.
Props kjellr.
Fixes #47937.

git-svn-id: https://develop.svn.wordpress.org/trunk@45897 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-26 19:00:46 +00:00
Sergey Biryukov
c8bd4cbae4 Twenty Nineteen: Update style-rtl.css after [45773].
See #47850.

git-svn-id: https://develop.svn.wordpress.org/trunk@45896 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-26 18:59:39 +00:00
Jonathan Desrosiers
0847b67b13 Coding Standards: Dynamic hooks should be named using interpolation not concatenation.
Props arena, desrosj.
Fixes #47052.

git-svn-id: https://develop.svn.wordpress.org/trunk@45881 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-22 19:07:57 +00:00
Sergey Biryukov
23769b62c1 Twenty Seventeen: Fix tabs vs. spaces in [45764].
See #47414.

git-svn-id: https://develop.svn.wordpress.org/trunk@45863 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-20 19:10:15 +00:00
Sergey Biryukov
92ba7258b0 Twenty Eleven: Fix tabs vs. spaces in [45763].
See #47414.

git-svn-id: https://develop.svn.wordpress.org/trunk@45862 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-20 19:10:12 +00:00
Sergey Biryukov
c277879ad0 Twenty Seventeen: Adjust [45764] to conform to CSS Coding Standards.
See #47414.

git-svn-id: https://develop.svn.wordpress.org/trunk@45861 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-20 19:05:30 +00:00
Sergey Biryukov
13f064a1c3 Twenty Eleven: Adjust [45763] to conform to CSS Coding Standards.
See #47414.

git-svn-id: https://develop.svn.wordpress.org/trunk@45860 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-20 19:05:24 +00:00