Commit Graph

148 Commits

Author SHA1 Message Date
Drew Jaynes
644b0e27a3 Add a proper return description for the wp_xmlrpc_server->addTwoNumbers() method.
See [30181]. See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@32557 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-23 19:25:38 +00:00
Drew Jaynes
206debf59e Add proper descriptions for the $methods, $blog_options, and $error properties in wp_xmlrpc_server.
See [30181]. See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@32556 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-23 19:22:40 +00:00
Scott Taylor
4ab280361c Upgrade the doc blocks in class-wp-xmlrpc-server.php. Rehabilitate some unfortunate use of tabbing.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32550 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 19:36:22 +00:00
Dominik Schilling (ocean90)
cfa32bc1d7 Merge similar error strings for invalid data.
props pavelevap.
fixes #32329.

git-svn-id: https://develop.svn.wordpress.org/trunk@32477 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 21:08:57 +00:00
Sergey Biryukov
e71959fc57 Remove duplicate string with a typo, merge it with an existing string.
props pavelevap.
fixes #32020.

git-svn-id: https://develop.svn.wordpress.org/trunk@32209 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 15:26:04 +00:00
John Blackbourn
d92cc07d91 Correctly set the post author in wp_xmlrpc_server::mw_editPost() when the current user is not the author of the post.
Props redsweater, markoheijnen, DrewAPicture
Fixes #24916


git-svn-id: https://develop.svn.wordpress.org/trunk@31983 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 15:48:41 +00:00
Sergey Biryukov
da8f896426 Fix a typo in [30138].
see #30224.

git-svn-id: https://develop.svn.wordpress.org/trunk@31279 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-25 09:47:05 +00:00
Scott Taylor
5acc6bdb58 In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning.
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.

To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.

`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.

Props markoheijnen, wonderboymusic.
Fixes #25672.


git-svn-id: https://develop.svn.wordpress.org/trunk@31188 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 01:05:52 +00:00
Scott Taylor
f6d7c5e52f In wp_xmlrpc_server, only allow __call() to run against ->_multisite_getUsersBlogs().
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31149 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-11 22:30:26 +00:00
Scott Taylor
349e5cb318 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31126 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-10 06:53:48 +00:00
Scott Taylor
ddbb6c7a0f In wp_xmlrpc_server, remove dead code.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31092 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:20:17 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Scott Taylor
5d6cc49628 Perl-style comments should not be used
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31079 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:51:39 +00:00
Scott Taylor
4d46475b3d Improve various @param docs for src/wp-includes/*.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30681 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 01:33:34 +00:00
Scott Taylor
43d5210cfa Almost every method in wp_xmlrpc_server can also return IXR_Error and should be labeled as such. Rehabilitate some return syntax.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30181 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:03:30 +00:00
Scott Taylor
f759c23d31 In wp_xmlrpc_server methods, for comprehensibility:
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30153 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 19:44:07 +00:00
Scott Taylor
17e9c6f403 In wp_xmlrpc_server->pingback_ping(), remove the internal variable $way each time it is set and not used.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30139 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:49:26 +00:00
Scott Taylor
eb05767743 In wp_xmlrpc_server methods, don't set $blog_id internally if it is never used, which is almost always. Updates the docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30138 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:43:41 +00:00
Scott Taylor
842d9bc5cf In wp_xmlrpc_server->_prepare_comment(), $comment_date is set internally but never used.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30137 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:28:18 +00:00
Sergey Biryukov
5a89372970 XML-RPC: Check if category support was added for pages before calling wp_get_post_categories() to avoid unnecessary query in wp.getPage.
props markoheijnen, nprasath002.
fixes #17920.

git-svn-id: https://develop.svn.wordpress.org/trunk@29731 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-11 13:55:56 +00:00
Sergey Biryukov
9f3b8dbead XML-RPC: Avoid a PHP notice in pingback_ping() method.
props jesin, simonp303.
fixes #29177.

git-svn-id: https://develop.svn.wordpress.org/trunk@29464 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 15:18:08 +00:00
Peter Westwood
01277f8d32 XMLRPC: Switch the file deletion alias to be deleteFile to more closely make uploadFile.
Fixes #5310 props SergeyBiryukov.


git-svn-id: https://develop.svn.wordpress.org/trunk@29255 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-20 14:01:35 +00:00
Drew Jaynes (DrewAPicture)
7ad77d58ee Add periods to short descriptions for magic methods added in [28501], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29165 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 01:11:55 +00:00
Drew Jaynes (DrewAPicture)
2d27b684fb Fill out inline documentation for the __call() magic method added to the wp_xmlrpc_server class in [28515].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29161 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:45:54 +00:00
Peter Westwood
52aa1804e4 XMLRPC: Restore support in wp.newPost for dates to be supplied in the structured dateTime.iso8601 format as well as still supporting dates specified as strings.
Fixes #28601.


git-svn-id: https://develop.svn.wordpress.org/trunk@29063 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 14:16:20 +00:00
Sergey Biryukov
146bcaa937 XML-RPC: Make sure wp.newPost does not produce a fatal error when a post_date field is included in the data.
props dllh.
fixes #28601.

git-svn-id: https://develop.svn.wordpress.org/trunk@28854 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 17:42:17 +00:00
Sergey Biryukov
772903e5e9 XML-RPC: Add wp.deleteMediaItem as an alias to wp_deletePost.
props fahmiadib.
fixes #5310.

git-svn-id: https://develop.svn.wordpress.org/trunk@28849 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 15:20:07 +00:00
Scott Taylor
84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like().
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:43:32 +00:00
Scott Taylor
fc2601044b wp_xmlrpc_server::wp_getPage() should return new IXR_Error( instead of return(new IXR_Error(. One of the few places that is unparseable by static analysis.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28636 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:21:33 +00:00
Scott Taylor
312ef7b264 These functions import $wpdb but do not use it.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28539 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 17:36:42 +00:00
Scott Taylor
ea0e965af3 Add missing access modifiers to methods in wp_xmlrpc_server. Add a magic __call() method for BC.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28515 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 06:08:04 +00:00
Scott Taylor
61d2e52e4b In wp_xmlrpc_server::mw_editPost, also set $post_type = $postdata['post_type'].
See #22400, [28448].



git-svn-id: https://develop.svn.wordpress.org/trunk@28453 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:05:21 +00:00
Scott Taylor
cf3574516a Eliminate use of extract() in wp_xmlrpc_server::mw_editPost() (MetaWeblog API, y'all).
A lot of the extracted variables are overwritten by being explicitly set later. 
Only set variables that would otherwise not be present with `compact()` is called.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28448 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 15:18:17 +00:00
Scott Taylor
9d873771b7 Eliminate use of extract() in wp_xmlrpc_server::blogger_editPost().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28412 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:24:40 +00:00
Drew Jaynes (DrewAPicture)
b5612f8b80 Priority fixes for various existing hook documentation.
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 00:00:32 +00:00
Andrew Nacin
3e6d8864a9 XML-RPC: Fix bracing of conditionals around doc blocks.
props redsweater, DrewAPicture.
fixes #27506.


git-svn-id: https://develop.svn.wordpress.org/trunk@28065 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-10 21:03:29 +00:00
Andrew Nacin
631b55ac0b Don't pass variables by reference.
props markjaquith.
fixes #27656.


git-svn-id: https://develop.svn.wordpress.org/trunk@27957 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 18:16:45 +00:00
Andrew Nacin
239ac6e830 Forward pingback IP during pingback verification.
props tellyworth, nacin.
fixes #27613.


git-svn-id: https://develop.svn.wordpress.org/trunk@27872 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 20:42:41 +00:00
Drew Jaynes (DrewAPicture)
e111f0a5ec Inline documentation for hooks in wp-includes/class-wp-xmlrpc-server.php.
Props kpdesign and DrewAPicture.
Fixes #27506.


git-svn-id: https://develop.svn.wordpress.org/trunk@27730 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-26 05:43:05 +00:00
Drew Jaynes (DrewAPicture)
af0f9a5e00 Inline documentation for hooks in wp-admin/includes/file.php.
Fixes #27429.


git-svn-id: https://develop.svn.wordpress.org/trunk@27672 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:44:17 +00:00
Andrew Nacin
f4cc32fac9 XML-RPC: In wp.editPost, Remove all terms in a taxonomy when an empty array is explicitly passed.
props jstraitiff, maxcutler.
fixes #26686.


git-svn-id: https://develop.svn.wordpress.org/trunk@27554 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 05:08:40 +00:00
Andrew Nacin
890b809bb9 XML-RPC: Include 'sticky' in the struct returned from metaWeblog.getRecentPosts.
Using wp.getPosts is preferred and non-WP XML-RPC APIs are no longer actively maintained. This is simply for parity with existing MW methods.

props soulseekah.
fixes #26679.


git-svn-id: https://develop.svn.wordpress.org/trunk@27553 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 05:04:54 +00:00
Andrew Nacin
8355232a65 Avoid saving slashed data in XML-RPC's wp.setOptions.
props danielbachhuber.
fixes #22936.


git-svn-id: https://develop.svn.wordpress.org/trunk@27551 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 04:46:53 +00:00
Drew Jaynes
647f80595d Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core.
See #27200.


git-svn-id: https://develop.svn.wordpress.org/trunk@27262 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-25 17:13:08 +00:00
Drew Jaynes
bd39e26032 First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.


git-svn-id: https://develop.svn.wordpress.org/trunk@26868 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-24 18:56:05 +00:00
Sergey Biryukov
39d55fddb8 Use get_current_site() instead of the $current_site global when possible.
props jeremyfelt.
fixes #25158.

git-svn-id: https://develop.svn.wordpress.org/trunk@26120 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 03:22:48 +00:00
Dominik Schilling (ocean90)
ad422b8366 Introduce show_in_menu for register_taxonomy.
Accepts boolean: true to show, false to hide. If not set, the default is inherited from show_ui.

fixes #20930.

git-svn-id: https://develop.svn.wordpress.org/trunk@25133 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-26 22:34:56 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00