Commit Graph

32938 Commits

Author SHA1 Message Date
Andrea Fercia
6e3838503c Dashboard: remove not clickable spaces between icons and links in the "At a Glance" panel. Also, some CSS cleanup.
Props 5um17 for the initial patch.
Fixes #27813.

git-svn-id: https://develop.svn.wordpress.org/trunk@35894 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 12:00:12 +00:00
Jeremy Felt
03310b2e22 MS: Update "Add New Site" address description text for accuracy.
Add hyphens to the list of allowed characters and add the `description` class to helper text paragraph tag.

Props thomaswm for the initial patch.
Fixes #26388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35893 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 03:12:11 +00:00
Mel Choyce
e9b376bfe4 Customizer: Bold pixel value under Site Icon to match the Custom Header instructions.
Props karmatosed.
Fixes #35039.


git-svn-id: https://develop.svn.wordpress.org/trunk@35892 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 00:13:12 +00:00
Joe Hoyle
03f3276797 Remove accidental .svn addition to .gitignore
Introduced in 35890, oops!


git-svn-id: https://develop.svn.wordpress.org/trunk@35891 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 18:26:22 +00:00
Joe Hoyle
a375d93001 REST API: Improve formatting of failed validation errors.
If a validation_callback returns a WP_Error it should give the same response format as if it returned `false`. This makes programmatically reading the validation errors better.

Props bradyvercher for initial patch.
Fixes #35028.


git-svn-id: https://develop.svn.wordpress.org/trunk@35890 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 18:22:02 +00:00
Drew Jaynes
cca457a958 Docs: Document the optional $args parameter in wp_delete_term() in the hash notation style.
Props slushman, swissspidy.
Fixes #34862.


git-svn-id: https://develop.svn.wordpress.org/trunk@35889 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 16:26:42 +00:00
Sergey Biryukov
ddf45b0142 Docs: Improve documentation for request_filesystem_credentials() and the corresponding filter.
Props swissspidy, danhgilmore, slushman.
Fixes #34858.

git-svn-id: https://develop.svn.wordpress.org/trunk@35888 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 16:15:07 +00:00
Sergey Biryukov
7dbca374a6 Docs: Remove @todo entry from get_archives_link(), as all optional arguments are now documented.
See #34856.

git-svn-id: https://develop.svn.wordpress.org/trunk@35887 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 15:54:11 +00:00
Sergey Biryukov
9689976129 Docs: Document optional parameters in get_archives_link().
Props kiranpotphode.
Fixes #34856.

git-svn-id: https://develop.svn.wordpress.org/trunk@35886 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 15:51:57 +00:00
Pascal Birchler
4e58589669 Docs: Fix some minor DocBlock alignment issues.
See #32246.

git-svn-id: https://develop.svn.wordpress.org/trunk@35885 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 15:36:36 +00:00
Sergey Biryukov
fd30730949 I18N: In WP_Locale::init(), replace space as a thousands separator with a non-breaking space.
* If PHP version is 5.4.0 or greater, a regular space as a thousands separator is replaced with a non-breaking space, decoded using the `blog_charset` option.
* If PHP version is 5.2.x or 5.3.x, ` ` or ` ` as a thousands separator is replaced with a regular space, as multiple bytes are not supported there.

Fixes #10373.

git-svn-id: https://develop.svn.wordpress.org/trunk@35884 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 02:05:37 +00:00
Sergey Biryukov
2bfa87c2df Editor: Move 'Password protected' and 'Private' options description directly after 'Visibility' setting description.
Props christophherr.
Fixes #34919.

git-svn-id: https://develop.svn.wordpress.org/trunk@35883 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:55:07 +00:00
Sergey Biryukov
c81f71b550 Docs: Correct wp_debug_mode() description to clarify that WP_DEBUG_DISPLAY is true by default.
Props jrf.
Fixes #34960.

git-svn-id: https://develop.svn.wordpress.org/trunk@35882 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:48:41 +00:00
Sergey Biryukov
e7287de7f3 Fix typo in wp-admin/setup-config.php.
Props obrienlabs.
Fixes #34916.

git-svn-id: https://develop.svn.wordpress.org/trunk@35881 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:44:56 +00:00
Sergey Biryukov
bbce167f29 I18N: In wp_maybe_decline_date(), bail early if translation functions are not available, e.g. in SHORTINIT mode.
Fixes #34967 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@35880 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:41:24 +00:00
Sergey Biryukov
d1b6832295 Revert [35878].
See #34967.

git-svn-id: https://develop.svn.wordpress.org/trunk@35879 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:40:06 +00:00
Sergey Biryukov
27f35b5675 I18N: In wp_maybe_decline_date(), bail early if translation functions are not available, e.g. in SHORTINIT mode.
Fixes #34967 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@35878 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:34:33 +00:00
Drew Jaynes
7493d90f96 Docs: Update the summary for the comment_form_fields hook docs to explicitly mention inclusion of the textarea element as a filterable element.
Previously [35723]

Props bappidgreat.
Fixes #34973.


git-svn-id: https://develop.svn.wordpress.org/trunk@35877 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:06:03 +00:00
John Blackbourn
9c354378ff Avoid a PHP notice when trying to access the post_parent property of hierarchical post type nav menu items.
FIxes #34446


git-svn-id: https://develop.svn.wordpress.org/trunk@35876 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:05:27 +00:00
Andrea Fercia
4dfb95179a When editing terms, properly display an admin notice-warning when tag_ID is empty.
Also, avoids two related PHP notices when empty or not set (and thus the global `$tag` is a WP_Error object).

Fixes: #34515.

git-svn-id: https://develop.svn.wordpress.org/trunk@35875 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 22:48:49 +00:00
Pascal Birchler
5a445d7515 Admin Menu: Deprecate add_object_page() and add_utility_page().
These functions are not used in core and are just wrappers for `add_menu_page()`.

Fixes #23108.

git-svn-id: https://develop.svn.wordpress.org/trunk@35874 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 22:11:03 +00:00
Pascal Birchler
64b89c09f0 Dashboard: Do not show "Search Engines Discouraged" text when the blog_public option is not set.
Search engines are only discouraged from indexing the site when the option is explicitly set to `0`.

Fixes #34860.

git-svn-id: https://develop.svn.wordpress.org/trunk@35873 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 22:02:27 +00:00
johnbillion
3348774d3a Ensure that all the capabilities that any users have are being tested. This ensures that if new capabilities are introduced in the future, tests will be required for them.
See #35024


git-svn-id: https://develop.svn.wordpress.org/trunk@35872 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 21:59:01 +00:00
John Blackbourn
a7f713f45d Introduce tests for the unfiltered_upload capability, which no user should have (unless the ALLOW_UNFILTERED_UPLOADS constant is defined).
See #35024


git-svn-id: https://develop.svn.wordpress.org/trunk@35871 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 21:54:05 +00:00
Pascal Birchler
410aa27b1d Passwords: Hide weak password confirmation checkbox when password strength improves.
Props subharanjan for initial patch.
Fixes #34950.

git-svn-id: https://develop.svn.wordpress.org/trunk@35870 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 21:53:29 +00:00
John Blackbourn
eaa8863723 Correct the hash notation documentation introduced in [34891].
See #32147


git-svn-id: https://develop.svn.wordpress.org/trunk@35869 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 20:15:54 +00:00
Drew Jaynes
91f343c461 Docs: Remove indentation from a wrapped line in the DocBlock description for get_post_type_labels() to prevent incorrect formatting when parsed.
With the false indentation in place, the parser for the Code Reference incorrectly interprets it as a block quote.

Fixes #35019.


git-svn-id: https://develop.svn.wordpress.org/trunk@35868 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 18:41:37 +00:00
Sergey Biryukov
e01a52e878 Post Template: Pass the post ID to the_guid and get_the_guid filters.
Props danielbachhuber for initial patch.
Fixes #35015.

git-svn-id: https://develop.svn.wordpress.org/trunk@35867 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 16:38:15 +00:00
Andrea Fercia
d0da333cf0 Accessibility: on the Updates screen, remove a redundant title attribute.
Removes the title attribute from the Plugin details link and adds the Plugin name hidden with `screen-reader-text` within the link text.

Props Cheffheid.
Fixes #35001.

git-svn-id: https://develop.svn.wordpress.org/trunk@35866 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 16:31:06 +00:00
Drew Jaynes
fb5997f206 Administration: Improve the message displayed in the login form modal when a user's session has expired.
Props obrienlabs.
Fixes #34340.


git-svn-id: https://develop.svn.wordpress.org/trunk@35865 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 16:00:36 +00:00
Drew Jaynes
640599e8f5 Docs: Document the optional $options parameter for wp_register_widget_control() as a hash notation.
Props stephanethomas.
Fixes #34855.


git-svn-id: https://develop.svn.wordpress.org/trunk@35864 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 15:23:26 +00:00
John Blackbourn
e76be26406 Add assertions for role names as capabilities in the capabilities tests. This ensures the role name is only available as a capability to the corresponding role.
See #35007


git-svn-id: https://develop.svn.wordpress.org/trunk@35863 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 11:06:28 +00:00
Gary Pendergast
d498c9f0f2 About: Add a fallback -webkit-calc() to about.css
We forgot to run `grunt precommit` before [35834] was committed.

This change doesn't need to be backported to the 4.4 branch, as it only affects Chrome < 26, it's really just to clean up the behaviour of `grunt precommit`.

See #34663.




git-svn-id: https://develop.svn.wordpress.org/trunk@35862 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 03:52:26 +00:00
Eric Andrew Lewis
f1b07f779f Add inline documentation for get_page_by_path().
Fixes #34964.


git-svn-id: https://develop.svn.wordpress.org/trunk@35861 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 03:49:40 +00:00
ericlewis
26e7188154 Don't suppress error messages in database function calls.
Fixes #21870.


git-svn-id: https://develop.svn.wordpress.org/trunk@35860 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 03:39:52 +00:00
Gary Pendergast
957697adf0 Build Tools: Update grunt-contrib-imagemin to v1.0.0
This updates `imagemin` to 4.0.0, which fixes an error when running `grunt imagemin:core`.

Props netweb.

Fixes #35003.



git-svn-id: https://develop.svn.wordpress.org/trunk@35859 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 03:37:36 +00:00
Boone Gorges
4c1c287413 Be sure to force-delete when cleaning up fixtures in get_comment_link() tests.
Introduced in [35857].

Mega-super-anti-props boonebgorges.

git-svn-id: https://develop.svn.wordpress.org/trunk@35858 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 02:46:37 +00:00
Boone Gorges
3626449004 Share fixtures in get_comment_link() tests.
See #30017.

git-svn-id: https://develop.svn.wordpress.org/trunk@35857 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 02:26:43 +00:00
Dominik Schilling (ocean90)
ab584ff499 L10n: Use an absolute path for the is_dir() check when looking for installed translations.
Avoids warnings when `open_basedir` restrictions are in effect.

Props Profforg.
Fixes #34526.

git-svn-id: https://develop.svn.wordpress.org/trunk@35856 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 23:08:46 +00:00
Andrea Fercia
56dc5b5b30 Updates screen: make the new strings introduced in [35854] translatable.
Props walbo.
Fixes #34763.

git-svn-id: https://develop.svn.wordpress.org/trunk@35855 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 19:23:30 +00:00
Andrea Fercia
f207e68c27 Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.
Fixes #34763.

git-svn-id: https://develop.svn.wordpress.org/trunk@35854 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 17:20:18 +00:00
Rachel Baker
d13adcc9bf Comments: Comments don’t need no Post ID when created, so they don’t be needing one to be edited.
In `wp_update_comment()` only check if the given `comment_post_ID` is valid if it isn’t `0`.  This allows comments that were created programmatically via `wp_insert_comment()` without the (optional) `comment_post_ID` parameter to be edited.

Props subharanjan for the initial patch.
Fixes #34954



git-svn-id: https://develop.svn.wordpress.org/trunk@35853 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 15:16:51 +00:00
Boone Gorges
52384c2e6b Improve handling for WP_Error objects in get_the_terms().
`wp_get_object_terms()` can return a `WP_Error` object. As such, the
`get_the_terms()` cache wrapper should handle them properly. To wit:

* Don't try to map an error object to `get_term()`. Introduced in [35032].
* Don't cache an error object as taxonomy relationships. Introduced in at least [16487], maybe earlier.

Props stephenharris.
Fixes #34723.

git-svn-id: https://develop.svn.wordpress.org/trunk@35850 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 03:34:51 +00:00
John Blackbourn
ad338fb3d0 Comments: Commit tests missed in [35848].
See #28617


git-svn-id: https://develop.svn.wordpress.org/trunk@35849 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 03:15:44 +00:00
John Blackbourn
c4cf5124ca Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times.
Twelve years later, after no fewer than three themes have intentionally implemented popup comments in their functionality, before being abandoned for at least the last six years, we've reached a time where we can put this era behind us. A time when we can remove comment popup functionality from WordPress.

If this breaks the internet, I'll eat my hat.

Fixes #28617


git-svn-id: https://develop.svn.wordpress.org/trunk@35848 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 03:05:34 +00:00
John Blackbourn
c2f597280b Formatting: Don't make links inside <script> and <style> tags clickable.
Fixes #30162
Props ninos-ego, adamsilverstein


git-svn-id: https://develop.svn.wordpress.org/trunk@35847 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-09 23:54:24 +00:00
Andrea Fercia
08f67db8a3 Accessibility: remove no-purpose title attributes from the login screen.
Also, it's hard to convey the ironic tone of the sentences used for these title attributes in languages other than English.

Fixes #34943.

git-svn-id: https://develop.svn.wordpress.org/trunk@35846 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-09 22:19:01 +00:00
Rachel Baker
7d1436ffb7 Docs: Better param descriptions and fix incorrect param name within REST API deprecated functions
`rest_handle_deprecated_function`: you get better parameter descriptions.
`rest_handle_deprecated_argument`: you get a corrected parameter name ($replacement->$message), appropriate i18n translation hints, and better parameter descriptions.

Props ocean90.
Fixes #34908



git-svn-id: https://develop.svn.wordpress.org/trunk@35845 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-09 21:25:15 +00:00
Drew Jaynes
3e57adcf39 Docs: Move the hook doc for the view_mode_post_types filter to directly precede the apply_filters() line.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35844 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-09 16:16:07 +00:00
Dominik Schilling (ocean90)
0339d7d145 About Page: Add release video and update post embed.
Props camikaos, siobhan, rosso99, wonderboymusic.
See #34663.

git-svn-id: https://develop.svn.wordpress.org/trunk@35839 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 23:22:25 +00:00