Commit Graph

62 Commits

Author SHA1 Message Date
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin 774a12be83 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: https://develop.svn.wordpress.org/trunk@21996 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 05:26:19 +00:00
Andrew Nacin a8aba36255 Use $gmt_time rather than $local_time in cron, since it uses GMT/UTC and not a local timestamp. see #14391.
git-svn-id: https://develop.svn.wordpress.org/trunk@21954 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-23 16:57:21 +00:00
Ryan Boren a5d94bef07 Introduce cron_request filter. Props ikailo. fixes #13449
git-svn-id: https://develop.svn.wordpress.org/trunk@21293 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-20 15:15:22 +00:00
Ryan Boren 4ccc748312 Use site_url() to construct the cron url. Props SergeyBiryukov. see #13449
git-svn-id: https://develop.svn.wordpress.org/trunk@19922 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-14 17:53:35 +00:00
Ryan Boren 3a1b732f51 Use microtime() for cron locks. fixes #19700
git-svn-id: https://develop.svn.wordpress.org/trunk@19722 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-09 19:02:31 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Ryan Boren 332d6d1351 Improve cron locking. Avoid multiple cron processes looping over the same events. fixes #17462
git-svn-id: https://develop.svn.wordpress.org/trunk@18659 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-09 19:59:44 +00:00
Andrew Nacin 4904a251a5 Don't show extra .0 in _deprecated_argument calls. They should appear in @since docs though.
git-svn-id: https://develop.svn.wordpress.org/trunk@16938 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-15 11:27:38 +00:00
scribu 063f1b5680 Add note about wp_next_scheduled() in wp_schedule_event(). See #14668
git-svn-id: https://develop.svn.wordpress.org/trunk@16690 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-02 16:27:16 +00:00
Andrew Nacin 9e9f0bf3d6 Kill check_server_timer(). fixes #15602.
git-svn-id: https://develop.svn.wordpress.org/trunk@16603 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-29 05:16:24 +00:00
Ryan Boren d5bd0ffd71 Introduce schedule_event filter. fixes #15146
git-svn-id: https://develop.svn.wordpress.org/trunk@15837 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-18 20:50:35 +00:00
Dion Hulse 7efc4efdaa Alot more tabs. Props jacobsantos & Viper007bond. See #14147
git-svn-id: https://develop.svn.wordpress.org/trunk@15355 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-30 00:05:18 +00:00
Ryan Boren eee631b773 Don't suppress errors when including cron if WP_DEBUG. Props sivel. fixes #11507
git-svn-id: https://develop.svn.wordpress.org/trunk@14414 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-03 21:46:19 +00:00
Peter Westwood a752e6b561 Updates and improvements to _depreceated_argument. See #11386 props nacin.
git-svn-id: https://develop.svn.wordpress.org/trunk@12584 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-30 16:23:39 +00:00
Peter Westwood b607185b4e Fix typo in _deprecated_argument() and start using _deprecated_argument() in wp-includes files. See #11386 props nacin.
git-svn-id: https://develop.svn.wordpress.org/trunk@12537 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-24 11:12:04 +00:00
Peter Westwood cbb63c4f78 Fix wp_clear_scheduled_hook() so that it function prototype matches the other cron functions.
Include backwards compatibility code so that plugins that used the old way still work.
Fixes #10468.

git-svn-id: https://develop.svn.wordpress.org/trunk@12462 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-19 11:47:16 +00:00
Matt Mullenweg 2101888ec0 Cast out the lowercase P demons that snuck in. http://www.google.com/search?q=out+out+you+demons+of+stupidity
git-svn-id: https://develop.svn.wordpress.org/trunk@12341 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-08 19:59:34 +00:00
Ryan Boren 2f034b4430 Schedule trash collection from admin page loads. see #4529
git-svn-id: https://develop.svn.wordpress.org/trunk@12120 602fd350-edb4-49c9-b593-d223f7449a82
2009-10-27 18:13:42 +00:00
Andrew Ozz 245d113bfc "Trash" status for comments updates, props caesarsgrunt, see #4529
git-svn-id: https://develop.svn.wordpress.org/trunk@11741 602fd350-edb4-49c9-b593-d223f7449a82
2009-07-24 07:23:11 +00:00
Ryan Boren 5159541678 Fix handling of old timestamps in wp_reschedule_event(). Props natethelen. fixes #9318
git-svn-id: https://develop.svn.wordpress.org/trunk@10969 602fd350-edb4-49c9-b593-d223f7449a82
2009-04-17 00:23:48 +00:00
Peter Westwood f84a032000 Improve cron phpdoc.
git-svn-id: https://develop.svn.wordpress.org/trunk@10898 602fd350-edb4-49c9-b593-d223f7449a82
2009-04-08 20:16:59 +00:00
Andrew Ozz c58b656d42 Add filter for local connection ssl verify to cron spawning, props sivel, see #8702
git-svn-id: https://develop.svn.wordpress.org/trunk@10526 602fd350-edb4-49c9-b593-d223f7449a82
2009-02-08 15:26:16 +00:00
Andrew Ozz ccaf039e0d Cron spawning improvement, see #9005
git-svn-id: https://develop.svn.wordpress.org/trunk@10521 602fd350-edb4-49c9-b593-d223f7449a82
2009-02-07 13:32:34 +00:00
Ryan Boren 17a19d056b Use transient for doing_cron. see #9048
git-svn-id: https://develop.svn.wordpress.org/trunk@10519 602fd350-edb4-49c9-b593-d223f7449a82
2009-02-06 22:25:35 +00:00
Andrew Ozz 962dc22c5e Spawn cron with AJAX request, see #9005
git-svn-id: https://develop.svn.wordpress.org/trunk@10474 602fd350-edb4-49c9-b593-d223f7449a82
2009-01-31 02:23:24 +00:00
Ryan Boren decf24ecb6 Lose hash check
git-svn-id: https://develop.svn.wordpress.org/trunk@10473 602fd350-edb4-49c9-b593-d223f7449a82
2009-01-30 22:35:41 +00:00
Ryan Boren 35d982904f cron phpdoc fixes. Props filosofo. fixes #8680 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@10233 602fd350-edb4-49c9-b593-d223f7449a82
2008-12-19 20:47:20 +00:00
Ryan Boren fab4e5a68e Unused var fixes. Props DD32. see #8220
git-svn-id: https://develop.svn.wordpress.org/trunk@9716 602fd350-edb4-49c9-b593-d223f7449a82
2008-11-15 18:10:35 +00:00
Ryan Boren 1f781cae47 Fix the fix
git-svn-id: https://develop.svn.wordpress.org/trunk@9407 602fd350-edb4-49c9-b593-d223f7449a82
2008-10-29 22:59:47 +00:00
Ryan Boren a76105406a Wrong view ryan
git-svn-id: https://develop.svn.wordpress.org/trunk@9406 602fd350-edb4-49c9-b593-d223f7449a82
2008-10-29 22:56:48 +00:00
Ryan Boren d3258d101e Formatting cleanup
git-svn-id: https://develop.svn.wordpress.org/trunk@9403 602fd350-edb4-49c9-b593-d223f7449a82
2008-10-29 20:26:20 +00:00
Ryan Boren 45123cac1f don't schedule a duplicate if there's already an identical event due in the next 10 minutes. Props tellyworth. fixes #6966
git-svn-id: https://develop.svn.wordpress.org/trunk@9181 602fd350-edb4-49c9-b593-d223f7449a82
2008-10-15 06:00:42 +00:00
Andrew Ozz a98c49b45c Cron improvement, props hailin, fixes #7068
git-svn-id: https://develop.svn.wordpress.org/trunk@8927 602fd350-edb4-49c9-b593-d223f7449a82
2008-09-18 07:09:38 +00:00
Ryan Boren 534fbf940d phpdoc for cron.php. Props jacobsantos and hansengel. fixes #5637
git-svn-id: https://develop.svn.wordpress.org/trunk@8806 602fd350-edb4-49c9-b593-d223f7449a82
2008-09-04 19:12:40 +00:00
Mark Jaquith 3cab99fbd2 Cast to array when using foreach(). Props santosj (and thanks for your perseverance!). fixes #2784
git-svn-id: https://develop.svn.wordpress.org/trunk@8572 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-06 20:31:54 +00:00
Ryan Boren 2b63884467 Don't use wp_guess_url(). Caused big problems. see #4779
git-svn-id: https://develop.svn.wordpress.org/trunk@8537 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-04 19:19:05 +00:00
Ryan Boren 0f4aac8854 Use wp_guess_url() for determining the cron URL. Props jacobsantos. see #4779
git-svn-id: https://develop.svn.wordpress.org/trunk@8529 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-03 21:07:21 +00:00
Ryan Boren 0e54a9ce6b Formatting changes and non-blocking mode. Props DD32. see #4779
git-svn-id: https://develop.svn.wordpress.org/trunk@8519 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-01 16:36:50 +00:00
Ryan Boren 086b9294b9 HTTP POST and REQUEST API from jacobsantos. see #4779
git-svn-id: https://develop.svn.wordpress.org/trunk@8516 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-01 05:00:07 +00:00
Ryan Boren cf2daaf071 Don't run get_plugins() on every admin page load. Use cron for async update plugin requests. see #7372
git-svn-id: https://develop.svn.wordpress.org/trunk@8514 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-01 04:26:32 +00:00
Ryan Boren 6fc09cfd3b Take port into consideration when spawning cron. Props bchecketts. fixes #4782
git-svn-id: https://develop.svn.wordpress.org/trunk@5972 602fd350-edb4-49c9-b593-d223f7449a82
2007-08-29 17:57:06 +00:00
Ryan Boren b046d67f41 Trim empty lines. Nothing but newline.
git-svn-id: https://develop.svn.wordpress.org/trunk@5700 602fd350-edb4-49c9-b593-d223f7449a82
2007-06-14 02:25:30 +00:00
Ryan Boren 66d8f40564 Use wp_hash to create cron's check hash.
git-svn-id: https://develop.svn.wordpress.org/trunk@5274 602fd350-edb4-49c9-b593-d223f7449a82
2007-04-16 20:47:23 +00:00
Ryan Boren ab521be7dd Make sure openssl is available. Props Robert Deaton and rob1n. fixes #3765
git-svn-id: https://develop.svn.wordpress.org/trunk@4984 602fd350-edb4-49c9-b593-d223f7449a82
2007-03-07 04:16:06 +00:00
Ryan Boren 26d480eb5f Fix spawning with SSL. Props dragonhard and rob1n. fixes #3765
git-svn-id: https://develop.svn.wordpress.org/trunk@4980 602fd350-edb4-49c9-b593-d223f7449a82
2007-03-07 01:47:57 +00:00
Mark Jaquith 5acfcd9fea trailing tabs and whitespace cleanup.
git-svn-id: https://develop.svn.wordpress.org/trunk@4953 602fd350-edb4-49c9-b593-d223f7449a82
2007-02-27 15:24:54 +00:00
Mark Jaquith 61ce0809a7 Prevent a missing wp-cron.php from causing an infinite loop. Props jan. fixes #3713
git-svn-id: https://develop.svn.wordpress.org/trunk@4834 602fd350-edb4-49c9-b593-d223f7449a82
2007-01-30 13:06:56 +00:00
Ryan Boren f03d22ae89 Change cron arg passing. Props masquerade. fixes #3169.
git-svn-id: https://develop.svn.wordpress.org/trunk@4362 602fd350-edb4-49c9-b593-d223f7449a82
2006-10-08 17:50:21 +00:00
Mark Jaquith bc7cd93309 case insensitive sorting. props Nazgul. fixes #3108
git-svn-id: https://develop.svn.wordpress.org/trunk@4289 602fd350-edb4-49c9-b593-d223f7449a82
2006-10-04 03:49:56 +00:00