Commit Graph

3272 Commits

Author SHA1 Message Date
Scott Taylor
6a9c55cd9f Because of YouTube's overwhelming dominance in the online video space, we should help our users who paste bad URLs when possible. It is easy to fix http://youtube.com/embed/acb1233 URLs by turning them into http://youtube.com/watch?v=abc1233 embeds using an embed handler (we already have one to fix Google Video embeds).
We should avoid doing this in almost every other case, but it's YouTube, and it's an easy error for a novice to make.

Fixes #24660.


git-svn-id: https://develop.svn.wordpress.org/trunk@28652 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 01:21:13 +00:00
Sergey Biryukov
9953e4ddaf Add oEmbed support for TED talks.
props pdclark.
fixes #28285.

git-svn-id: https://develop.svn.wordpress.org/trunk@28651 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:45:12 +00:00
Scott Taylor
174af6cca4 In the spirit of [27622], add a few CSS rules to ensure that videos will be responsive, regardless of theme.
Props Funkatronic.
Fixes #28414.


git-svn-id: https://develop.svn.wordpress.org/trunk@28650 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:39:47 +00:00
Scott Taylor
58690d7b97 In WPPlaylistView::ended(), at the end of a playlist, set the index to 0 and call ->setCurrent() instead of ->loadCurrent() so that the first track is properly highlighted.
Fixes #28428.


git-svn-id: https://develop.svn.wordpress.org/trunk@28649 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:26:24 +00:00
Sergey Biryukov
d4b336ded2 Fix typo in mbstring_binary_safe_encoding() description.
props ghost1227.
fixes #28423.

git-svn-id: https://develop.svn.wordpress.org/trunk@28648 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-01 05:05:44 +00:00
Sergey Biryukov
e8e39d212b Plugin activation/deletion errors should be styled as such.
props johnbillion.
fixes #28260.

git-svn-id: https://develop.svn.wordpress.org/trunk@28646 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-31 20:09:26 +00:00
Lance Willett
f48c3b9582 Twenty Fourteen: change hardcoded pagination base to use the WordPress Rewrite object's pagination_base value instead. Document global variable usage properly.
Props SergeyBiryukov, fixes #28405.

git-svn-id: https://develop.svn.wordpress.org/trunk@28645 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-31 18:50:16 +00:00
Sergey Biryukov
c04daa1ade Avoid stomping of the $plugin variable in activate_plugin().
fixes #28102.

git-svn-id: https://develop.svn.wordpress.org/trunk@28644 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 22:07:43 +00:00
Sergey Biryukov
9120e6a9d7 Display the site scheme, not the current scheme on Edit Site screen in network admin.
props johnbillion.
fixes #28406.

git-svn-id: https://develop.svn.wordpress.org/trunk@28643 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 22:00:45 +00:00
Sergey Biryukov
dbef7e2587 Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite.
props jkudish, topher1kenobe.
fixes #20271.

git-svn-id: https://develop.svn.wordpress.org/trunk@28642 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 21:50:24 +00:00
Sergey Biryukov
3afd9885c2 Adjacent links in wp_head() should only be generated for posts, not pages.
props alexander.rohmann.
fixes #21658.

git-svn-id: https://develop.svn.wordpress.org/trunk@28641 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 21:19:55 +00:00
wonderboymusic
2d0be44d85 In WP_Image_Editor_GD::_save(), pass $compression_level into the args array for ->make_image().
Props MuViMoTV, markoheijnen, SergeyBiryukov, mikemanger, ericlewis.
Fixes #24380.



git-svn-id: https://develop.svn.wordpress.org/trunk@28640 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 20:05:02 +00:00
Scott Taylor
804b82bd11 Make the image editor less jumpy when opening.
Props eddiemoya, ericlewis.
Fixes #22793.



git-svn-id: https://develop.svn.wordpress.org/trunk@28639 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:52:35 +00:00
Scott Taylor
3d48e21248 Fix an error caused by [28604] in get_comments_number() unit tests.
Props SergeyBiryukov.
Fixes #26240.



git-svn-id: https://develop.svn.wordpress.org/trunk@28638 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:46:05 +00:00
Scott Taylor
e996a74984 Restore $val in WP_Importer::bump_request_timeout() - even though the parent class and WP_Import ignore the parameter, it creates an incompatible interface notice in the plugin.
See [28629].



git-svn-id: https://develop.svn.wordpress.org/trunk@28637 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:34:53 +00:00
Scott Taylor
fc2601044b wp_xmlrpc_server::wp_getPage() should return new IXR_Error( instead of return(new IXR_Error(. One of the few places that is unparseable by static analysis.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28636 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:21:33 +00:00
Scott Taylor
de685a9f73 Move default to the bottom in _wp_mysql_week().
See #28409.


git-svn-id: https://develop.svn.wordpress.org/trunk@28634 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 18:09:43 +00:00
Scott Taylor
2cd825a21b Cleanup for switch statements:
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28633 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 17:57:51 +00:00
Drew Jaynes (DrewAPicture)
dc96d99a70 Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php.
Also add `@param` and `@return` descriptions.

See #28408.


git-svn-id: https://develop.svn.wordpress.org/trunk@28632 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 17:37:36 +00:00
Lance Willett
a0dbf001c5 Twenty Fourteen: adjust spacing for site description (tagline) to avoid cutting off accented characters. Props SergeyBiryukov, iamtakashi. Fixes #28397.
git-svn-id: https://develop.svn.wordpress.org/trunk@28630 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 17:08:14 +00:00
Scott Taylor
7ab6b096e6 Remove some dead variable assignments.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 16:58:36 +00:00
Drew Jaynes (DrewAPicture)
1da8a18e5f Update the $secure_logged_in_cookie variable in the 'secure_logged_in_cookie' hook docs following [28627].
See #15330.


git-svn-id: https://develop.svn.wordpress.org/trunk@28628 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 15:19:29 +00:00
Andrew Nacin
8d980de0ee Use a secure logged_in_cookie when the home URL is forced HTTPS (see #27954).
see #15330.


git-svn-id: https://develop.svn.wordpress.org/trunk@28627 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 15:07:18 +00:00
Andrew Ozz
d87a482353 TinyMCE in iOS:
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242

git-svn-id: https://develop.svn.wordpress.org/trunk@28626 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 02:37:52 +00:00
Andrew Ozz
1da0e87bdc TinyMCE: remove margins from the image toolbar wrapper, props avryl, fixes #28389
git-svn-id: https://develop.svn.wordpress.org/trunk@28624 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 22:58:27 +00:00
Scott Taylor
8f247884c2 Simplify the logic for determining isset( $this->query['s'] ) after [28612], and don't limit this logic to just the main query.
Props SergeyBiryukov.
Fixes #11330.


git-svn-id: https://develop.svn.wordpress.org/trunk@28623 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 20:49:28 +00:00
Scott Taylor
8bb2117aad If post_status is passed to WP_Query as an array containing 'any' and anything else, don't exclude the other values if they match when running any's exclusion logic.
Adds unit tests.

Fixes #28007.


git-svn-id: https://develop.svn.wordpress.org/trunk@28622 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 20:41:53 +00:00
Scott Taylor
25593e291c When queries are passed to WP_Tax_Query, the value for operator is assumed to be uppercase. This is an unnecessary constraint. In ->get_sql(), cast it using $operator = strtoupper( $query['operator'] ).
Props clifgriffin.
Fixes #27557.


git-svn-id: https://develop.svn.wordpress.org/trunk@28618 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 17:52:25 +00:00
Helen Hou-Sandi
2e1c4959af Fix a jshint error introduced in [28607]. see #23560.
git-svn-id: https://develop.svn.wordpress.org/trunk@28617 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 14:24:20 +00:00
Helen Hou-Sandi
220a45a32d Don't use the box shadow focus styling for the admin menu or toolbar. see #28267.
git-svn-id: https://develop.svn.wordpress.org/trunk@28616 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 14:22:39 +00:00
Andrew Ozz
6418ba1696 Regex should be non-greedy, see #28389
git-svn-id: https://develop.svn.wordpress.org/trunk@28615 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 07:55:17 +00:00
Andrew Ozz
8f5ea4bacd TinyMCE: fix problems with undo/redo after resizing an image several times. Fixes #28389.
git-svn-id: https://develop.svn.wordpress.org/trunk@28614 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 07:50:35 +00:00
Scott Taylor
8530693a51 If post__in or post_parent__in is passed to WP_Query as an empty array, nuke the query. Both vars are currently only checked for truthiness after which they are ignored. Setting these vars at all indicates explicit filtering being desired.
Adds unit test.

Fixes #28099.


git-svn-id: https://develop.svn.wordpress.org/trunk@28613 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 06:03:15 +00:00
Scott Taylor
4d1e46231b When parsing the main query, if s is set to empty: ?s= and $this->is_main_query() && array_key_exists( 's', $this->query ) - kill the query instead of loading the homepage. This will load the search page with no results.
Fixes #11330.



git-svn-id: https://develop.svn.wordpress.org/trunk@28612 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 05:47:35 +00:00
Andrew Nacin
6e269a7120 Append the date to $wp_version in the build output, for nightly packages.
props azaozz.
fixes #26751.


git-svn-id: https://develop.svn.wordpress.org/trunk@28611 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 04:32:41 +00:00
Andrew Nacin
e317e5454a Force SSL on the frontend via canonical when the home URL uses the https scheme.
fixes #27954.


git-svn-id: https://develop.svn.wordpress.org/trunk@28610 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 04:12:05 +00:00
Andrew Nacin
961459ee31 Forcing SSL logins now forces SSL for the entire admin, with no middle ground.
fixes #10267.


git-svn-id: https://develop.svn.wordpress.org/trunk@28609 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 03:58:41 +00:00
Helen Hou-Sandi
06c142a1a5 Better align link element focus with form focus styling, which also improves the visibility. props zamfeer. see #28267.
git-svn-id: https://develop.svn.wordpress.org/trunk@28608 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 03:57:44 +00:00
Helen Hou-Sandi
b27a8697d6 At long last, improved keyboard accessibility for the media modal.
props lessbloat, grahamarmfield, sharonaustin, bramd.
see #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@28607 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 03:38:31 +00:00
Andrew Ozz
139b5b3cb0 TinyMCE: update to 4.0.28. Also includes 43fff5b453. Part-props avryl for the patch on #27941, fixes #28391, #27941.
git-svn-id: https://develop.svn.wordpress.org/trunk@28606 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 00:58:11 +00:00
Scott Taylor
32893ac7ea Allow users to sort posts by type in WP_Query.
Props DeBAAT.
Fixes #28214.


git-svn-id: https://develop.svn.wordpress.org/trunk@28605 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 00:23:45 +00:00
Dominik Schilling (ocean90)
0af37cccdb Pass $post->ID to get_comments_number filter.
Also fixes indentation and a typo in corresponding filter docs.

see #26240.

git-svn-id: https://develop.svn.wordpress.org/trunk@28604 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 22:35:21 +00:00
Drew Jaynes (DrewAPicture)
d201ded99e Fix parameter description for the $post_id argument in get_comments_number() to note that it is optional.
Also fixes the corresponding filter docs, as `$post_id`, not `$post` is passed to the filter.

See [27156]. Fixes #26240.


git-svn-id: https://develop.svn.wordpress.org/trunk@28602 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 22:04:59 +00:00
Andrew Nacin
0c7edb2045 Revert [28579] and [28582]. see #21963.
git-svn-id: https://develop.svn.wordpress.org/trunk@28601 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 18:13:55 +00:00
Sergey Biryukov
c73f5ef2de Fix displaying taxonomies in bulk edit if the post type does not support titles.
props scribu.
fixes #16793.

git-svn-id: https://develop.svn.wordpress.org/trunk@28600 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:49:21 +00:00
Sergey Biryukov
2d420d52bb Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard.
props ghost1227.
fixes #26754.

git-svn-id: https://develop.svn.wordpress.org/trunk@28599 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:41:23 +00:00
Sergey Biryukov
98b4b63e40 Twenty Fourteen: Avoid passing an empty string to document.getElementById().
props nabil_kadimi.
fixes #28340.

git-svn-id: https://develop.svn.wordpress.org/trunk@28598 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:35:47 +00:00
Sergey Biryukov
5a8b1cfac2 Fix SlideShare oEmbed regex.
props kovshenin.
fixes #28380.

git-svn-id: https://develop.svn.wordpress.org/trunk@28597 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:31:22 +00:00
Scott Taylor
598e79479b RIP Viddler oEmbed support.
More: https://gigaom.com/2014/02/07/viddler-gets-ready-to-delete-personal-videos/

See #28379.



git-svn-id: https://develop.svn.wordpress.org/trunk@28596 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 21:59:42 +00:00
Scott Taylor
d80969655c Update the Scribd oEmbed pattern to more actually represent which endpoints from the site are discoverable.
See #28379.


git-svn-id: https://develop.svn.wordpress.org/trunk@28595 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 21:54:24 +00:00
Scott Taylor
0b209f55ee When parsing an [embed] shortcode into a TinyMCE view, don't attempt to append any returned <script>s to the editor's <head>. This affects only a few supported endpoints: Issuu and Twitter.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28594 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 19:59:47 +00:00
Scott Taylor
7eb0253744 For YouTube playlist oEmbed, we need keep BC for wp_oembed_remove_provider() by not changing the existing YouTube endpoint keys. So, rather than merging the rules, the playlist endpoints should be on their own line.
Props kovshenin.

See #28125, [28552].


git-svn-id: https://develop.svn.wordpress.org/trunk@28593 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 18:42:30 +00:00
Sergey Biryukov
7b133a336f Remove obsolete code from wp_dashboard_setup().
props kitchin.
fixes #26604.

git-svn-id: https://develop.svn.wordpress.org/trunk@28592 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 15:40:19 +00:00
Sergey Biryukov
2f1ad4ddbf Move 'Documentation on date and time formatting' link under the 'Time Format' block.
props gauravmittal1995.
fixes #28348.

git-svn-id: https://develop.svn.wordpress.org/trunk@28591 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 14:49:51 +00:00
Sergey Biryukov
b8b933418a Pass anchor text to 'edit_post_link' and 'edit_comment_link' filters.
props kwight.
fixes #28373.

git-svn-id: https://develop.svn.wordpress.org/trunk@28590 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 13:42:27 +00:00
Sergey Biryukov
86b88bd2b7 Add BMP to the list of displayable image types.
props ericlewis.
fixes #26808.

git-svn-id: https://develop.svn.wordpress.org/trunk@28589 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 13:24:39 +00:00
Sergey Biryukov
a25a5de409 Update documentation for is_new_day().
props obenland.
fixes #28333.

git-svn-id: https://develop.svn.wordpress.org/trunk@28588 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 11:40:11 +00:00
Sergey Biryukov
c2076859eb Remove redundant get_shortcode_regex() check.
props kovshenin.
see #28195.

git-svn-id: https://develop.svn.wordpress.org/trunk@28587 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 11:29:11 +00:00
Sergey Biryukov
6bca1ca960 Clean up wp_widget_rss_output():
* Fix appending [&hellip;] to $summary.
* Use wp_trim_words() instead of wp_html_excerpt().
* Trim $title before checking if it's empty. props UmeshSingla.
* Use correct escaping function for $title.

fixes #28356.

git-svn-id: https://develop.svn.wordpress.org/trunk@28586 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 11:07:32 +00:00
Sergey Biryukov
9599dd9705 Avoid a PHP notice in bundled themes if no images were found.
props nabil_kadimi.
fixes #28361.

git-svn-id: https://develop.svn.wordpress.org/trunk@28585 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 10:54:54 +00:00
Sergey Biryukov
06bf55f809 Avoid a PHP notice in adjacent_image_link() if no images were found.
props nabil_kadimi.
see #28361.

git-svn-id: https://develop.svn.wordpress.org/trunk@28584 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 10:54:45 +00:00
Scott Taylor
4dd4a32cde In wp_get_object_terms(), before returning terms (and before running them through the 'wp_get_object_terms' filter) - run them through $terms = array_values( array_unique( $terms, SORT_REGULAR ) ).
There will be "dupes" when the function is called with `'fields' => 'all_with_object_id'`, but the objects will actually be unique due to the `object_id` addition, so they shouldn't be filtered out. 

Adds unit tests. All other unit tests pass.

Fixes #11003.


git-svn-id: https://develop.svn.wordpress.org/trunk@28583 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 03:28:05 +00:00
Scott Taylor
7f2cad1809 Fix some inline docs churn in wp_insert_post() after [28579].
Props kpdesign.
See #21963.



git-svn-id: https://develop.svn.wordpress.org/trunk@28582 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 00:23:21 +00:00
Scott Taylor
792fe23675 When adding a URL in the Insert from URL state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields.
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.


git-svn-id: https://develop.svn.wordpress.org/trunk@28581 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:56:27 +00:00
Scott Taylor
8567bba0bf Don't pass embeds through the_content() when trying to render MCE previews, leverage WP_Embed and do_shortcode() instead.
Props kovshenin.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28580 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:42:08 +00:00
Scott Taylor
6cd28991e3 Combine wp_insert_attachment() and wp_insert_post(). wp_insert_attachment() becomes a wrapper. Update inline docs.
Props wonderboymusic, DrewAPicture.
See #21963.


git-svn-id: https://develop.svn.wordpress.org/trunk@28579 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:19:03 +00:00
Scott Taylor
ef81c3fdba Add oEmbed support for Mixcloud.
Props Jayjdk.
Fixes #27169.



git-svn-id: https://develop.svn.wordpress.org/trunk@28578 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:09:00 +00:00
Scott Taylor
5413bfc35a Allow the settings view for galleries to be disabled when instantiating wp.media.controller.GalleryEdit.
Props nd987.
Fixes #23116.


git-svn-id: https://develop.svn.wordpress.org/trunk@28577 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 22:48:56 +00:00
Andrew Ozz
92f79f5bcd TinyMCE: fix saving the editor content on switching Visual -> Text, fixes #28353
git-svn-id: https://develop.svn.wordpress.org/trunk@28576 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-25 22:46:06 +00:00
Sergey Biryukov
aa6d49590b Fix typo in [28574].
see #28360.

git-svn-id: https://develop.svn.wordpress.org/trunk@28575 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-25 16:11:26 +00:00
Sergey Biryukov
508c1c1ae7 Replace $in_same_cat with $in_same_term in adjacent post functions for consistency.
props ixkaito.
fixes #28360.

git-svn-id: https://develop.svn.wordpress.org/trunk@28574 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-25 16:09:07 +00:00
Sergey Biryukov
95e42909a9 Suggest get_current_site() as an alternative for get_current_site_name().
props jesin.
fixes #28346.

git-svn-id: https://develop.svn.wordpress.org/trunk@28573 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-25 14:31:16 +00:00
Sergey Biryukov
191705a964 Fix inversed logic in Walker_Category::start_el(). see [28359].
Correct 'use_desc_for_title' parameter description.

see #26557.

git-svn-id: https://develop.svn.wordpress.org/trunk@28572 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 13:41:11 +00:00
Sergey Biryukov
90a40a07a1 Pass $post to 'protected_title_format' and 'private_title_format' filters.
props johnjamesjacoby, DrewAPicture.
fixes #23724.

git-svn-id: https://develop.svn.wordpress.org/trunk@28571 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 06:47:55 +00:00
Drew Jaynes (DrewAPicture)
cff4631f00 Add inline documentation for the option_none_value argument added to wp_dropdown_users|categories() in [28564].
Fixes #16625.


git-svn-id: https://develop.svn.wordpress.org/trunk@28570 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 05:38:06 +00:00
Drew Jaynes (DrewAPicture)
c4dc6180a5 Use three-digit x.x.x style version for @deprecated phpDoc tags.
See #18298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28569 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 05:22:34 +00:00
Andrew Ozz
8d02021b7c TinyMCE: update to 4.0.26. Includes fixes for the 'paste' plugin (paste from Word/Excel, paste in WebKit/Blink), show/hide/isHidden in inline mode, drag/drop in tables and in Safari, and others. Fixes #28342, #28016, #28250 and #28067
git-svn-id: https://develop.svn.wordpress.org/trunk@28568 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 01:43:16 +00:00
Scott Taylor
5c3f7d5392 In media_sideload_image(), check the returned value of download_url() earlier to avoid attempting to unlink() an instance of WP_Error.
Props georgestephanis. 
Fixes #28204.


git-svn-id: https://develop.svn.wordpress.org/trunk@28567 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 21:32:12 +00:00
Andrew Ozz
cfb7408e2a wpView: fix selecting a view's text string in Safari, props gcorne, fixes #28088
git-svn-id: https://develop.svn.wordpress.org/trunk@28565 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 20:55:53 +00:00
Scott Taylor
cd7d3f2ee8 wp_dropdown_pages() allows option_none_value to be passed. Add that arg to the $defaults for wp_dropdown_users() and wp_dropdown_categories() as well.
Props solarissmoke. 
Fixes #16625.


git-svn-id: https://develop.svn.wordpress.org/trunk@28564 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 20:46:18 +00:00
Scott Taylor
70f735669a Replaces all uses of TEMPLATEPATH and STYLESHEETPATH in core with get_template_directory() and get_stylesheet_directory().
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.

Props obenland, aaroncampbell. 
Fixes #18298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28563 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 20:11:08 +00:00
Scott Taylor
e2a124a911 When adding queries to tax_query: if the query's field is term_taxonomy_id, don't require taxonomy to be specified. In WP_Tax_Query::transform_query(), $query['taxonomy'] is never checked for the 'term_taxonomy_id' case because 'term_taxonomy_id' is the primary key being looked up.
Adds unit tests.

Props helen.
Fixes #25284.



git-svn-id: https://develop.svn.wordpress.org/trunk@28562 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 19:58:52 +00:00
Scott Taylor
a2b0c8b2e4 In get_terms_to_edit(), call get_object_term_cache() before priming cache with wp_get_object_terms().
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.



git-svn-id: https://develop.svn.wordpress.org/trunk@28561 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 19:28:45 +00:00
Scott Taylor
aa34ede226 Truly check for ! empty() instead of falsey '' when determining whether to add LIMIT clause to SQL in wp_get_archives().
Props jjeaton for the initial patch.
Fixes #27834.


git-svn-id: https://develop.svn.wordpress.org/trunk@28560 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 18:27:10 +00:00
Scott Taylor
3b060c1931 Read the src attribute for the [embed] shortcode if the shortcode's body is empty.
These work:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"]`
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"][/embed]`

If you do:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"]http://any-other-url.com[/embed]`

... "http://any-other-url.com" will be the URL that is parsed.

Props kovshenin, aaroncampbell for making initial patches.
Fixes #24456.



git-svn-id: https://develop.svn.wordpress.org/trunk@28559 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 18:05:24 +00:00
Scott Taylor
1061a15eaf Allow get_comments_number() to officially accept $post or $post_id. Adds unit tests.
Props coffee2code, JanHenkG.
Fixes #26240.


git-svn-id: https://develop.svn.wordpress.org/trunk@28558 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 17:43:03 +00:00
John Blackbourn
d07954ea60 Add CollegeHumor.com oEmbed support. Fixes #24497. Props johnzanussi.
git-svn-id: https://develop.svn.wordpress.org/trunk@28557 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 23:46:22 +00:00
Scott Taylor
e2240cd82f Viddler has had a new oEmbed endpoint for at least 10 months. Let us update to it.
Props garhdez.
Fixes #24296.


git-svn-id: https://develop.svn.wordpress.org/trunk@28556 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 23:16:11 +00:00
Scott Taylor
2baa683984 Support Polldaddy's short URL format as a whitelisted oEmbed provider.
Props donncha.
Fixes #28283.



git-svn-id: https://develop.svn.wordpress.org/trunk@28555 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 23:12:05 +00:00
Scott Taylor
47be64543c Add Issuu to list of whitelisted oEmbed providers.
Props issuu.
Fixes #28312.



git-svn-id: https://develop.svn.wordpress.org/trunk@28554 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 21:49:10 +00:00
Scott Taylor
a4e1ec0b90 Fix parsing in wp_match_mime_types() to allow some mime-types with + in them to appear in the list of filter links shown above the list table on upload.php.
Props _duck.
Fixes #20672.



git-svn-id: https://develop.svn.wordpress.org/trunk@28553 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 21:35:36 +00:00
Scott Taylor
1bc5e8329a Support oEmbed matching for YouTube playlist URLs.
Fixes #28125.


git-svn-id: https://develop.svn.wordpress.org/trunk@28552 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 21:11:31 +00:00
Scott Taylor
285d74a283 In is_user_option_local(), $user_id is set conditionally, but never used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28551 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 19:17:12 +00:00
Scott Taylor
7b3181e4ed $count is set in get_post_galleries() and never used, relic from PFUI RIP.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28550 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 19:13:01 +00:00
Scott Taylor
1d78b1dcc4 $gallery_div is set twice in gallery_shortcode() before it is used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28549 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 19:11:16 +00:00
Scott Taylor
ae9cf4a66d In get_attachment_icon_src(), $class is set in 2 conditions but never used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28548 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 19:07:30 +00:00
Scott Taylor
363301f36e break is unreachable in WP_Theme::translate_header().
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28547 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 19:04:16 +00:00
Scott Taylor
8b3d002486 In WP_Customize_Manager::register_controls(), $menu_locations is set and never used.
git-svn-id: https://develop.svn.wordpress.org/trunk@28546 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 19:00:30 +00:00
Scott Taylor
e53cdbb8f0 In wp_dashboard_recent_posts(), $i is set and never used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28545 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 18:55:07 +00:00
Scott Taylor
70342f4a75 $theme_name is set but no longer used in wp_dashboard_right_now(). The theme name is displayed with the call to update_right_now_message().
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28544 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 18:53:43 +00:00