Commit Graph

80 Commits

Author SHA1 Message Date
Ryan Boren 6d2a8d2ef0 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23594 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-03 21:11:40 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin 774a12be83 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: https://develop.svn.wordpress.org/trunk@21996 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 05:26:19 +00:00
Andrew Nacin 33a76bd97c Anchor a regular expression in wp-mail.php to ensure we are matching the Reply-To: header, not the In-Reply-To: header.
Per RFCs *822, mail headers must start at the beginning of a line. This same pattern could be continued throughout this file.

props solarissmoke.
fixes #18923.



git-svn-id: https://develop.svn.wordpress.org/trunk@20682 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-02 13:32:19 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Ryan Boren eda7d43e85 Deprecate get_userdatabylogin() and get_user_by_email(). Props scribu. fixes #18333
git-svn-id: https://develop.svn.wordpress.org/trunk@18513 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-05 16:57:31 +00:00
Ryan Boren aec821c651 Strip trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@14924 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 02:42:15 +00:00
Andrew Nacin 00ae9bee64 Adjust POP3 error checks in wp-mail.php. props solarissmoke, fixes #13163.
git-svn-id: https://develop.svn.wordpress.org/trunk@14518 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-08 19:34:59 +00:00
Dion Hulse 491063c698 Tweak new strings for better typography. Props demetris. Fixes #12962
git-svn-id: https://develop.svn.wordpress.org/trunk@14070 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-11 10:41:54 +00:00
Peter Westwood 38b009d86c Switch from POST_BY_EMAIL constant to enable post-by-email when multisite to a filter. See #12381.
git-svn-id: https://develop.svn.wordpress.org/trunk@13418 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-25 22:06:10 +00:00
Ryan Boren ed156968a3 Integrate maybe_cancel_post_by_email() into wp-mail.php. see #11644
git-svn-id: https://develop.svn.wordpress.org/trunk@12855 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-26 20:53:59 +00:00
Peter Westwood f5e49c809b Make the action name for post-by-email takeover actually unique so the plugins are not triggered every time WP tries to send an email!
git-svn-id: https://develop.svn.wordpress.org/trunk@11949 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-18 20:43:05 +00:00
Peter Westwood 09845dfd03 Post by Email plugins might want to use there own POP3 class so move the action earlier.
git-svn-id: https://develop.svn.wordpress.org/trunk@11910 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-10 20:05:24 +00:00
Peter Westwood a7c38d2297 Allow a plugin to do a complete takeover of Post by Email
git-svn-id: https://develop.svn.wordpress.org/trunk@11893 602fd350-edb4-49c9-b593-d223f7449a82
2009-08-28 07:18:05 +00:00
Peter Westwood b4836e4e27 Allow a plugin to do a complete takeover of Post by Email
git-svn-id: https://develop.svn.wordpress.org/trunk@11892 602fd350-edb4-49c9-b593-d223f7449a82
2009-08-28 07:17:03 +00:00
Peter Westwood 8381ee663f Set the interval to 5 minutes like I meant. See #7245 props aaroncampbell.
git-svn-id: https://develop.svn.wordpress.org/trunk@11786 602fd350-edb4-49c9-b593-d223f7449a82
2009-08-07 17:11:39 +00:00
Peter Westwood 3faf80baad Limit wp-mail blog by email checks to every 5 minutes. Fixes #7245 based on patches from lilyfan and Denis-de-Bernardy.
git-svn-id: https://develop.svn.wordpress.org/trunk@11782 602fd350-edb4-49c9-b593-d223f7449a82
2009-08-06 19:58:47 +00:00
Mark Jaquith f0336cfa7d deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security.
git-svn-id: https://develop.svn.wordpress.org/trunk@11380 602fd350-edb4-49c9-b593-d223f7449a82
2009-05-18 15:11:07 +00:00
Andrew Ozz 3bf18aa189 Banishing ASCII quotes and apostrophes, props demetris, fixes #9655
git-svn-id: https://develop.svn.wordpress.org/trunk@11190 602fd350-edb4-49c9-b593-d223f7449a82
2009-05-05 04:28:05 +00:00
Ryan Boren 6f00ac0c70 Don't absint gmt_offset. Props Hirvine. fixes #9162
git-svn-id: https://develop.svn.wordpress.org/trunk@11066 602fd350-edb4-49c9-b593-d223f7449a82
2009-04-23 07:03:21 +00:00
Ryan Boren 8d00b5d37d Trim trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@10810 602fd350-edb4-49c9-b593-d223f7449a82
2009-03-18 02:43:45 +00:00
Peter Westwood 66ce91f31f Add a filter to allow post-by-email plugins better control over the content.
git-svn-id: https://develop.svn.wordpress.org/trunk@10412 602fd350-edb4-49c9-b593-d223f7449a82
2009-01-22 22:31:27 +00:00
Ryan Boren baaaa352ba Strip trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@10150 602fd350-edb4-49c9-b593-d223f7449a82
2008-12-09 18:03:31 +00:00
Peter Westwood 93269fad46 Improve wp-mail utf8 support. Fixes #6788 props filosofo.
git-svn-id: https://develop.svn.wordpress.org/trunk@10011 602fd350-edb4-49c9-b593-d223f7449a82
2008-12-02 18:40:16 +00:00
Ryan Boren 6f0b606518 Localization for wp-mail. Props filosofo. fixes #8051
git-svn-id: https://develop.svn.wordpress.org/trunk@9504 602fd350-edb4-49c9-b593-d223f7449a82
2008-11-03 23:35:34 +00:00
Ryan Boren c2d2f01baa Revert POP3 changes. Localization for wp-mail. Props filosofo. see #8051
git-svn-id: https://develop.svn.wordpress.org/trunk@9503 602fd350-edb4-49c9-b593-d223f7449a82
2008-11-03 23:25:11 +00:00
Peter Westwood e7559c8134 Performance improvements using strpos. Fixes #7611 and #7610 props johnbillion.
git-svn-id: https://develop.svn.wordpress.org/trunk@8754 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-27 20:47:01 +00:00
Peter Westwood 9099a0e896 Remove setting of error_reporting and just use the default WordPress error_reporting settings. Fixes #7035 props jacobsantos.
git-svn-id: https://develop.svn.wordpress.org/trunk@8488 602fd350-edb4-49c9-b593-d223f7449a82
2008-07-29 19:56:38 +00:00
Ryan Boren e25996c368 File file level phpdoc from jacobsantos. see #7037
git-svn-id: https://develop.svn.wordpress.org/trunk@7991 602fd350-edb4-49c9-b593-d223f7449a82
2008-05-25 15:50:15 +00:00
Ryan Boren e911cca913 Allow wp-config.php to exist one level up from WordPress root directory. Props sambauers. fixes #6933
git-svn-id: https://develop.svn.wordpress.org/trunk@7971 602fd350-edb4-49c9-b593-d223f7449a82
2008-05-21 05:59:27 +00:00
Ryan Boren bee51869ea Don't echo content. Props xknown.
git-svn-id: https://develop.svn.wordpress.org/trunk@6526 602fd350-edb4-49c9-b593-d223f7449a82
2007-12-29 19:38:33 +00:00
Ryan Boren cd740755cc Don't echo posted content. Specialchars all other displayed info.
git-svn-id: https://develop.svn.wordpress.org/trunk@6524 602fd350-edb4-49c9-b593-d223f7449a82
2007-12-29 19:20:15 +00:00
Ryan Boren a01ab04c3b Add some sanitization
git-svn-id: https://develop.svn.wordpress.org/trunk@6500 602fd350-edb4-49c9-b593-d223f7449a82
2007-12-27 08:08:11 +00:00
Ryan Boren 7ca479d4c1 Escape pop3 error messages. Props xknown. fixes #5484
git-svn-id: https://develop.svn.wordpress.org/trunk@6404 602fd350-edb4-49c9-b593-d223f7449a82
2007-12-18 20:06:37 +00:00
Peter Westwood d3be09a763 Ensure wp-mail doesn't issue a 500 error if no messages are available to post. Fixed #5420 props Bobcat
git-svn-id: https://develop.svn.wordpress.org/trunk@6357 602fd350-edb4-49c9-b593-d223f7449a82
2007-12-05 07:39:07 +00:00
Ryan Boren 1715c0f74e When posting by email, publish only if user has publish caps, otherwise set status to pending. Props Bobcat. fixes #4642
git-svn-id: https://develop.svn.wordpress.org/trunk@6349 602fd350-edb4-49c9-b593-d223f7449a82
2007-11-29 05:51:09 +00:00
Ryan Boren 8878de4cf3 Fix email address parsing in wp-mail.php. Props Bobcat. fixes #5169
git-svn-id: https://develop.svn.wordpress.org/trunk@6281 602fd350-edb4-49c9-b593-d223f7449a82
2007-10-21 06:18:59 +00:00
Mark Jaquith 93014f5c00 Strip From/Reply-To from e-mail before sanitizing in wp-mail.php. Props Bobcat. fixes #5169
git-svn-id: https://develop.svn.wordpress.org/trunk@6217 602fd350-edb4-49c9-b593-d223f7449a82
2007-10-10 16:46:20 +00:00
Mark Jaquith 1e41dc0c9e Properly sanitize e-mail addresses in wp-mail.php. Props giannis1. fixes #5169 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@6212 602fd350-edb4-49c9-b593-d223f7449a82
2007-10-09 22:15:37 +00:00
Ryan Boren 5917c5458c Add checks for WP_Error. Props filosofo. see #4809
git-svn-id: https://develop.svn.wordpress.org/trunk@6125 602fd350-edb4-49c9-b593-d223f7449a82
2007-09-18 16:32:22 +00:00
Mark Jaquith 1b56625a0d Skip deprecated option replacement in wp-mail.php. props Nazgul. fixes #4924
git-svn-id: https://develop.svn.wordpress.org/trunk@6056 602fd350-edb4-49c9-b593-d223f7449a82
2007-09-07 02:07:13 +00:00
Ryan Boren 52eceb61d0 Formatting cleanups from johnjosephbachir. fixes #4775
git-svn-id: https://develop.svn.wordpress.org/trunk@5901 602fd350-edb4-49c9-b593-d223f7449a82
2007-08-19 22:25:44 +00:00
Ryan Boren b046d67f41 Trim empty lines. Nothing but newline.
git-svn-id: https://develop.svn.wordpress.org/trunk@5700 602fd350-edb4-49c9-b593-d223f7449a82
2007-06-14 02:25:30 +00:00
rob1n b972383f1c Add in missing delimiter. fixes #4226 for 2.0, 2.2 and 2.3
git-svn-id: https://develop.svn.wordpress.org/trunk@5396 602fd350-edb4-49c9-b593-d223f7449a82
2007-05-05 02:51:20 +00:00
rob1n 429613b2cc Add support to wp-mail.php for quoted-printable Content-Transfer-Encoding. Props Nazgul. fixes #2460
git-svn-id: https://develop.svn.wordpress.org/trunk@5188 602fd350-edb4-49c9-b593-d223f7449a82
2007-04-06 02:57:46 +00:00
Matt Mullenweg d57901d29a Ryan slays the dragon. (Some of these return WP_Error objects.)
git-svn-id: https://develop.svn.wordpress.org/trunk@5089 602fd350-edb4-49c9-b593-d223f7449a82
2007-03-23 02:05:29 +00:00
Matt Mullenweg b1f6f9a6a8 (int)er the dragon.
git-svn-id: https://develop.svn.wordpress.org/trunk@5087 602fd350-edb4-49c9-b593-d223f7449a82
2007-03-23 00:59:21 +00:00
Ryan Boren 7e82eef627 Use get_option instead of get_settings. Just 'cause.
git-svn-id: https://develop.svn.wordpress.org/trunk@4144 602fd350-edb4-49c9-b593-d223f7449a82
2006-08-30 21:46:31 +00:00