Commit Graph

5531 Commits

Author SHA1 Message Date
Adam Silverstein
74ccb68c56 Taxonomy: restore TagSearch unit tests and correct deprecated version string.
Reverts unit test removal, instead changing them to expect the function to be deprecated.
Correct the version the ajax callback was deprecated.

Amends [42614].

Props dlh, ocean90.
Fixes #38922.



git-svn-id: https://develop.svn.wordpress.org/trunk@42737 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-25 16:27:57 +00:00
Sergey Biryukov
ba351c550f Administration: Use HTTPS for dashboard_primary_feed URL.
`dashboard_secondary_feed` is already using HTTPS since [29787].

Props iandunn.
Fixes #40416.

git-svn-id: https://develop.svn.wordpress.org/trunk@42731 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-24 09:29:17 +00:00
Aaron Jorbin
9377c9a873 Community Events Dashboard: Use wp_list_pluck rather than array_columns
array_columns is only available in PHP 5.5+

Introduced in [42726]

See: #41112.



git-svn-id: https://develop.svn.wordpress.org/trunk@42728 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-21 23:27:00 +00:00
Andrea Fercia
827b9056c9 Accessibility: Change the terms "Quick Edit" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
See #38677 / [42725].

Fixes #43382.


git-svn-id: https://develop.svn.wordpress.org/trunk@42727 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-21 23:03:57 +00:00
Aaron Jorbin
53a61339e4 Community Events Dashboard: Always show a WordCamp if one is coming up
WordCamps are celebrations of the local WordPress Community and once a local one is scheduled, people in that community should know it is coming. This adjusts the WordPress Events in the dashboard widgets to always display a WordCamp, even if there are multiple Meetups happening first.

Props iandunn, metalandcoffee, warmlaundry, alejandroxlopez, jorbin.
Fixes #41112.



git-svn-id: https://develop.svn.wordpress.org/trunk@42726 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-21 23:00:50 +00:00
Andrea Fercia
c729ca4171 Accessibility: Change the posts "Quick Edit" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation. Also,
adds an `aria-expanded` attribute to the button to communicate to assistive
technologies the expanded / collapsed status of the Quick Edit form.

Props Cheffheid, audrasjb, afercia.
Fixes #38677.


git-svn-id: https://develop.svn.wordpress.org/trunk@42725 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-21 22:30:34 +00:00
Sergey Biryukov
21c6dabbc3 Docs: Correct documentation for Heartbeat filters.
`$response` parameter is documented as an array or object, but only array is actually supported.

See #42777, #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42720 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-19 21:45:03 +00:00
Peter Wilson
d002fde80e General: Further improve error messages following [42648].
Props kristastevens, melchoyce.
Fixes #38332 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@42719 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-19 02:12:41 +00:00
Kónståntîn Obénland
b99139814d Docs: Add filter docs for wp_refresh_nonces
Props chetan200891, slushman, dlh, netweb.
Fixes #42777.



git-svn-id: https://develop.svn.wordpress.org/trunk@42717 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-17 04:41:58 +00:00
Anton Timmermans
666507cb3f Docs: Improve JSDoc for for wp-admin/js/xfn.js.
Props kapteinbluf, igorsch.
Fixes #43204.


git-svn-id: https://develop.svn.wordpress.org/trunk@42715 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-15 13:34:37 +00:00
Anton Timmermans
dcc39fc4e7 Docs: Improve JSDoc for wp-admin/js/user-suggest.js.
Amend r42708 by fixing the 80 character wrap around.

Props timhavinga.
See #43270.


git-svn-id: https://develop.svn.wordpress.org/trunk@42714 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-15 13:25:22 +00:00
Sergey Biryukov
b252154091 Customize: Correct closing tags in customize_themes_print_templates().
Props johnpgreen, nandorsky.
Fixes #43307.

git-svn-id: https://develop.svn.wordpress.org/trunk@42711 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-13 22:14:36 +00:00
Drew Jaynes
1b46470b75 Docs: Link to the "Conditional Tags" article in the Theme Developer Handbook from the descriptions for a variety of core conditional tag functions.
These notations largely serve to direct consumers (of both the source and the parsed code reference) to extended information on individual and related conditional tags throughout WordPress. The changeset also standardizes corresponding DocBlock summaries to use third-person singular verbs.

Notations been added for the following functions:

* comments_open()
* email exists()
* has_excerpt()
* has_post_thumbnail()
* has_tag()
* in_category()
* in_the_loop()
* is_404()
* is_active_sidebar()
* is_active_widget()
* is_admin()
* is_admin_bar_showing()
* is_archive()
* is_attachment()
* is_author()
* is_blog_installed()
* is_category()
* is_comments_popup()
* is_date()
* is_day()
* is_dynamic_sidebar()
* is_feed()
* is_front_page()
* is_home()
* is_local_attachment()
* is_main_query
* is_month()
* is_multi_author
* is_new_day()
* is_page()
* is_page_template()
* is_paged()
* is_plugin_active()
* is_plugin_active_for_network()
* is_plugin_inactive()
* is_plugin_page()
* is_post_type_archive()
* is_preview()
* is_rtl()
* is_search()
* is_single()
* is_singular()
* is_sticky()
* is_tag()
* is_tax()
* is_taxonomy_hierarchical()
* is_time()
* is_trackback()
* is_user_logged_in()
* is_year()
* pings_open()
* post_type_exists()
* taxonomy_exists()
* term_exists()
* username exists()
* wp_attachment_is_image()
* wp_script_is()

Props janalwin.
Fixes #43254.


git-svn-id: https://develop.svn.wordpress.org/trunk@42710 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-13 16:53:44 +00:00
Anton Timmermans
56cef1dc9d Docs: Improve JSDoc for wp-admin/js/user-suggest.js.
Props timhavinga.
Fixes #43270.


git-svn-id: https://develop.svn.wordpress.org/trunk@42708 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-13 15:37:07 +00:00
Sergey Biryukov
ff8e7c03d2 Administration: Make sure wp.updates.addAdminNotice is displayed after the page header and does not unexpectedly push down "Add New" and other buttons.
Props shivapoudel.
Fixes #41221.

git-svn-id: https://develop.svn.wordpress.org/trunk@42700 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 17:27:17 +00:00
Sergey Biryukov
5e9067e8b9 Administration: Remove erroneous transition-delay values from CSS files.
Although unitless zero is allowed for `<length>` CSS data type, it's invalid for `<time>` data type.

Props chetan200891, manuel_84, GaryJ.
Fixes #43195.

git-svn-id: https://develop.svn.wordpress.org/trunk@42689 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 12:54:15 +00:00
Sergey Biryukov
21258c9bc7 Users: After [41163], add a notice for Email field on Profile screen that the new address will not become active until confirmed.
Props dilipbheda.
Fixes #43106. See #16470.

git-svn-id: https://develop.svn.wordpress.org/trunk@42688 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 12:22:21 +00:00
Sergey Biryukov
6e95cf3403 Build/Test Tools: Update prefixed CSS properties in about.css.
Firefox 52+ supports unprefixed `column-count` and `column-gap` properties.

Props netweb, afercia.
Fixes #43190.

git-svn-id: https://develop.svn.wordpress.org/trunk@42687 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-10 23:46:10 +00:00
Sergey Biryukov
88d00c0fac Plugins: Use correct variable name in install_plugin_information().
Props afragen.
Fixes #43282. See #43192, #29274.

git-svn-id: https://develop.svn.wordpress.org/trunk@42686 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-10 22:07:40 +00:00
Sergey Biryukov
e4519b3444 Administration: Rename Appearance → Editor menu item to Theme Editor and Plugins → Editor to Plugin Editor for clarity.
Props xkon, karmatosed.
Fixes #43072.

git-svn-id: https://develop.svn.wordpress.org/trunk@42685 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-10 08:42:07 +00:00
John Blackbourn
84b08f302e Comments: Add a "Mine" link to the list of filters on the comment listing screen.
This filter shows comments made by the current user, and copies the same filter functionality that's available on the post listing screens.

Props Iceable

Fixes #42379


git-svn-id: https://develop.svn.wordpress.org/trunk@42684 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 18:45:30 +00:00
John Blackbourn
47abf85ab8 Docs: First pass at switching some array parameter documentation to typed notation.
Props janak007

See #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@42679 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 17:25:22 +00:00
John Blackbourn
4836686b6f Docs: Add missing code formatting to various @since entries.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42678 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 16:54:58 +00:00
John Blackbourn
dc28b0d31d Docs: Update the hook docs for update_bulk_theme_complete_actions.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42677 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 16:21:04 +00:00
John Blackbourn
209baca2ca Posts, Post Types: Add a new add_inline_data action which allows extra fields to be added to the inline editing fields.
Props mensmaximus, NathanAtmoz

Fixes #36085


git-svn-id: https://develop.svn.wordpress.org/trunk@42676 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 15:54:56 +00:00
Sergey Biryukov
31816ccec2 Posts, Post Types: Remove extra tabs around page_attributes_meta_box_template action in page_attributes_meta_box().
Props chetan200891.
See #43252.

git-svn-id: https://develop.svn.wordpress.org/trunk@42674 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 11:23:43 +00:00
Sergey Biryukov
02d8aa907a Upgrade/Install: Avoid extra line breaks in a textarea in wp-admin/setup-config.php.
See #43252.

git-svn-id: https://develop.svn.wordpress.org/trunk@42672 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 10:57:28 +00:00
Sergey Biryukov
0859c8c968 Options: Avoid extra tabs in a textarea in wp-admin/options.php.
See #43252.

git-svn-id: https://develop.svn.wordpress.org/trunk@42671 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 10:57:14 +00:00
Sergey Biryukov
d6bfc44a16 Comments: Avoid extra tabs in a textarea in WP_Comments_List_Table::column_comment().
Props chetan200891, jrf.
Fixes #43252.

git-svn-id: https://develop.svn.wordpress.org/trunk@42670 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 10:56:55 +00:00
Peter Wilson
f317869c7f General: Replace Cheatin’ uh? with friendlier error messages.
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.

Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332.



git-svn-id: https://develop.svn.wordpress.org/trunk@42648 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-05 02:29:53 +00:00
Andrea Fercia
a6888ef843 Administration: Make the Screen Options available on small screens.
Previously, the Screen Options toggle and the related panel content 
were hidden on small screens, preventing access to important settings,
including the ability to toggle the meta boxes visibility.

Props chetan200891.
Fixes #40985.


git-svn-id: https://develop.svn.wordpress.org/trunk@42644 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 16:57:24 +00:00
Sergey Biryukov
bc982475fc Help/About: Correct outdated media icons reference in help text on Edit Post screen.
Props thrijith, transl8or.
Fixes #42378.

git-svn-id: https://develop.svn.wordpress.org/trunk@42643 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 13:57:33 +00:00
Sergey Biryukov
1b0695780f Media: Remove checkered background for icons in Attachment Details.
Props BandonRandon.
Fixes #42535. See #41948.

git-svn-id: https://develop.svn.wordpress.org/trunk@42642 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 13:53:44 +00:00
Andrea Fercia
ce61a7f676 Administration: CSS coding standards: use double quotes for values that require quotes.
As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.

Fixes #43220.


git-svn-id: https://develop.svn.wordpress.org/trunk@42641 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 13:18:40 +00:00
Sergey Biryukov
6d379c6f0f Posts, Post Types: Don't count pending comments in WP_Posts_List_Table::_display_rows() if the post type does not support comments.
Props seanchayes.
Fixes #43212.

git-svn-id: https://develop.svn.wordpress.org/trunk@42638 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-02 07:37:10 +00:00
Dion Hulse
212c880d71 Themes: Use api.wordpress.org/themes/info/1.2/ to query theme information.
See #43192.


git-svn-id: https://develop.svn.wordpress.org/trunk@42632 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 05:18:54 +00:00
Dion Hulse
e0d5a8ac54 Plugins: Use api.wordpress.org/plugins/info/1.2/ for querying plugins & plugin information.
See #43192.
Fixes #29274.


git-svn-id: https://develop.svn.wordpress.org/trunk@42631 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 05:16:15 +00:00
Adam Silverstein
3f04c10fea Remove unused var after r42614, fixing a jshint error.
git-svn-id: https://develop.svn.wordpress.org/trunk@42618 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:33:18 +00:00
Adam Silverstein
04b0a0f77c Taxonomy: Use REST API for ajax tag search.
Deprecate wp_ajax_ajax_tag_search and switch to using the REST API when searching tags in the tags meta box.

Props nacin, chriscct7, afercia, swissspidy, jnylen0, rmccue, ryelle.
Fixes #38922.



git-svn-id: https://develop.svn.wordpress.org/trunk@42614 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:16:37 +00:00
Weston Ruter
8561f22f4d Customize: Ensure heartbeat keeps changeset locked when in branching mode.
Props dlh.
See #42024.
Fixes #42658.


git-svn-id: https://develop.svn.wordpress.org/trunk@42612 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-29 23:04:22 +00:00
Sergey Biryukov
5bc3564249 Role/Capability: Make install_languages capability check less restrictive.
A user should still be able to have the capability, even when language packs cannot be automatically installed. The automatic installation part is separate from that now.

Props flixos90.
Fixes #42697.

git-svn-id: https://develop.svn.wordpress.org/trunk@42606 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 22:41:58 +00:00
Sergey Biryukov
9feedd0b0d Upgrade/Install: In postMessage events handler, check for message object existence before checking its action property.
Props manikmist09.
Fixes #43005.

git-svn-id: https://develop.svn.wordpress.org/trunk@42604 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 22:30:12 +00:00
Andrew Ozz
d6cc2b6f02 Editor: when keeping the scroll position treat all shortcodes as preview-able. Otherwise in some cases the marker span can get stuck inside the shortcode and break the markup.
Props azaozz, lizkarkoski and othellobloke for testing.
Fixes #42908 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@42574 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 17:33:26 +00:00
Sergey Biryukov
974d3afb9c Media: Restore white background of the content area in media modal.
Props afercia, chetan200891.
Fixes #43088.

git-svn-id: https://develop.svn.wordpress.org/trunk@42572 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 14:00:39 +00:00
SergeyBiryukov
10ad912128 Taxonomy: Don't display an empty edit link in taxonomy list table if the user doesn't have permissions to edit the term.
Props grapplerulrich.
Fixes #43146.

git-svn-id: https://develop.svn.wordpress.org/trunk@42565 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 11:33:26 +00:00
Aaron Jorbin
5bb7fc10c5 Remove JSHint due to license compatibility
JSHint inherits a license from JSLint that includes the clause  "The Software shall be used for Good, not Evil." WordPress's license specifically allows grants the freedom to run the program, for any purpose. Please note, this is not an encouragement of evil. Rather than doing something evil, how about learning to love those around you. Instead of tweeting lies and saying people are "Not Good!", help your neighbor. In the words of Lin Manual Miranda, "Love is love is love is love is love is love is love is love, cannot be killed or swept aside." 

This replaces JSHint with esprima, a part of the larger jQuery project, and a custom wrapper for some basic error checking within codemirror.

The existing JSHint configuration is kept in place in case someone wants to use that, but they can only do so for Good.

Fixes #42850
Props netweb for a spelling fix on a comment.



git-svn-id: https://develop.svn.wordpress.org/trunk@42547 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 01:28:26 +00:00
Weston Ruter
e2b25e6159 Customize: Let default status for Customizer be draft if user does not have capability to publish.
Amends [41626].
Props sayedwp, westonruter.
See #30937.
Fixes #42686.


git-svn-id: https://develop.svn.wordpress.org/trunk@42543 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 19:09:16 +00:00
Weston Ruter
f65c46cc50 Customize: Prevent showing SFTP theme installation notification in multisite when user cannot install themes.
Props flixos90.
See #37661, #42184.
Fixes #42674.


git-svn-id: https://develop.svn.wordpress.org/trunk@42536 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 06:14:10 +00:00
Anton Timmermans
33cd11ecb6 Docs: Improve JSDoc for password-strength-meter.js.
Props herregroen, carolinegeven, ireneyoast, jjcomack.
Fixes #43066.


git-svn-id: https://develop.svn.wordpress.org/trunk@42528 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-18 13:38:26 +00:00
Sergey Biryukov
0baa8ae85c Media: In _wp_handle_upload(), check if the file was properly uploaded before checking its size.
Props achbed, dglingren.
Fixes #39522.

git-svn-id: https://develop.svn.wordpress.org/trunk@42525 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-17 07:15:57 +00:00