Commit Graph

64 Commits

Author SHA1 Message Date
Andrea Fercia
e4b26366e4 Plugin Install: show the upload form in place rather than sending users to the devoted upload plugin page.
Props Ipstenu, ericlewis, michaelarestad.

Fixes #35429.

git-svn-id: https://develop.svn.wordpress.org/trunk@37221 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-16 16:42:48 +00:00
Aaron Jorbin
bd0c3bf0c7 Add Nonce to updating wporg_favorites user meta field
git-svn-id: https://develop.svn.wordpress.org/trunk@37145 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:35:37 +00:00
Dominik Schilling (ocean90)
e5556666cc Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.

git-svn-id: https://develop.svn.wordpress.org/trunk@36858 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:06:57 +00:00
Sergey Biryukov
520170222b I18N: Remove <code> tag from translatable string in wp-admin/theme-install.php.
Props ramiy.
Fixes #35739.

git-svn-id: https://develop.svn.wordpress.org/trunk@36666 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 01:29:08 +00:00
Konstantin Obenland
12ac7b2998 Themes: Clear floated theme cards on Themes page.
Also maintains visual separation for Broken Themes table on searches that
return no results.

See [36171] for `.wp-clearfix`.

Props 5um17, obenland, valendesigns, afercia.
Fixes #26646.



git-svn-id: https://develop.svn.wordpress.org/trunk@36270 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-12 17:12:17 +00:00
Sergey Biryukov
54c918d407 Remove redundant title attribute from wp_star_rating(). Hide the visible number of ratings from assistive technologies.
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.

Props afercia.
Fixes #35141.

git-svn-id: https://develop.svn.wordpress.org/trunk@36092 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 00:47:35 +00:00
Andrea Fercia
660608f219 Accessibility: Correctly associate the search input label in the new Themes favorites tab introduced in [35527].
Fixes #35122.

git-svn-id: https://develop.svn.wordpress.org/trunk@35977 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 22:29:38 +00:00
Sergey Biryukov
1631a99336 Themes: Add a Favorites tab to the Add Themes screen.
You can now browse and install your wordpress.org theme favorites from the theme installer, just like with plugins.

Props swissspidy.
Fixes #34206.

git-svn-id: https://develop.svn.wordpress.org/trunk@35527 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:48:43 +00:00
Andrea Fercia
3ee61161c6 Accessibility: Improve the headings hierarchy in the Add Themes screen.
Fixes #33819.

git-svn-id: https://develop.svn.wordpress.org/trunk@35273 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 22:03:48 +00:00
Sergey Biryukov
975c16f4b2 Use wp_star_rating() on Add Themes screen:
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible

Fixes #34080.

git-svn-id: https://develop.svn.wordpress.org/trunk@35006 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 06:50:35 +00:00
Scott Taylor
9e267b6e72 List Tables/WP_Screen: in WP_Screen, add methods to store, retrieve, and render screen reader text, primarily used by list table screens.
These additions are based on an audit and recommendations by the Accessibility team. #a11y'all

Props afercia.
Fixes #32147.


git-svn-id: https://develop.svn.wordpress.org/trunk@34891 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 01:27:01 +00:00
Dominik Schilling (ocean90)
07ea6a2334 Themes: Don't use HTML entities for placeholders.
See #32875.

git-svn-id: https://develop.svn.wordpress.org/trunk@34086 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 19:47:53 +00:00
Scott Taylor
d6e73d47e4 Round 2 of: We should use ellipses &hellip; / … instead of three dots/periods ... e.g Loading… not Loading...
Props yoavf.
Fixes #32875.


git-svn-id: https://develop.svn.wordpress.org/trunk@33970 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:38:31 +00:00
Dominik Schilling (ocean90)
0730240b9a Customizer: Use a <button> for the collapse sidebar … button.
props afercia.
fixes #32819.

git-svn-id: https://develop.svn.wordpress.org/trunk@33153 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-10 21:21:07 +00:00
Konstantin Obenland
e33229a237 Synchronize star ratings of themes and plugins.
Makes themes ratings look like plugins ratings already do.

Props helen.
Fixes #32782.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@33073 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:53:18 +00:00
Konstantin Obenland
8d40cdcb1b Use a less element-specific class name for links within page titles.
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@33067 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 16:41:18 +00:00
Konstantin Obenland
e59592f87e Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32974 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:40:27 +00:00
Konstantin Obenland
f88225549e Revert [32834].
It's not ready yet and was a product of misusing vim.

See #30729.



git-svn-id: https://develop.svn.wordpress.org/trunk@32835 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 12:26:40 +00:00
Konstantin Obenland
1fc76c997f Emphasise previewing new themes
git-svn-id: https://develop.svn.wordpress.org/trunk@32834 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 12:23:30 +00:00
Dominik Schilling (ocean90)
b0d6757918 Use HTTPS URLs for codex.wordpress.org.
see #27115.

git-svn-id: https://develop.svn.wordpress.org/trunk@32116 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-12 21:28:58 +00:00
Andrew Ozz
c3d7fa68ce Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling.
Props joedolson, adamsilverstein, afercia, DrewAPicture. Fixes #26600.

git-svn-id: https://develop.svn.wordpress.org/trunk@31994 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 02:31:11 +00:00
Dominik Schilling (ocean90)
4aeeb0e0f0 Customizer: Add title attributes to iframes.
props afercia.
fixes #31202.

git-svn-id: https://develop.svn.wordpress.org/trunk@31704 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-10 21:19:14 +00:00
Sergey Biryukov
7f69e6430b Themes: Add feedback for screen readers when search results are changed.
props obenland, joedolson.
see #26600.

git-svn-id: https://develop.svn.wordpress.org/trunk@31497 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 10:14:45 +00:00
Scott Taylor
469164785f Pinking Shears.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31077 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:02:05 +00:00
Sergey Biryukov
37499b6169 Theme install: Display an appropriate string if theme has not been rated yet.
props kevdotbadger, valendesigns.
fixes #28147.

git-svn-id: https://develop.svn.wordpress.org/trunk@31072 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-07 23:16:19 +00:00
Drew Jaynes (DrewAPicture)
ac47dd2cd0 Tweak formatting in the DocBlock for the install_themes_tabs hook.
Props kpdesign.
See #28578.


git-svn-id: https://develop.svn.wordpress.org/trunk@30772 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 18:40:03 +00:00
Helen Hou-Sandi
10d40a7801 Filter bar: Better field display on smaller screens.
props TacoVerdo, jesin.
fixes #29556 and #29495.


git-svn-id: https://develop.svn.wordpress.org/trunk@30740 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 22:22:26 +00:00
Drew Jaynes (DrewAPicture)
b90807cccd Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/*.
Also includes some changes to move hook docs to directly precede hook lines. This is necessary to prevent DocBlock-matching confusion when core is parsed.

Affects DocBlocks for the following hooks:
* `wp_ajax_ . $_REQUEST['action']`
* `wp_ajax_nopriv_ . $_REQUEST['action']`
* `admin_footer- . $GLOBALS['hook_suffix']`
* `admin_head-$hook_suffix`
* `admin_post_nopriv_{$action}`
* `admin_post_{$action}`
* `load-  . $page_hook`
* `load- . $plugin_page`
* `load-importer- . $importer`
* `load- . $pagenow`
* `admin_action_ . $_REQUEST['action']`
* `async_upload_{$type}`
* `add_meta_boxes_ . $post_type`
* `{$taxonomy}_pre_edit_form`
* `{$taxonomy}_term_edit_form_tag`
* `{$taxonomy}_edit_form_fields`
* `{$taxonomy}_edit_form`
* `after-{$taxonomy}-table`
* `{$taxonomy}_pre_add_form`
* `{$taxonomy}_term_new_form_tag`
* `{$taxonomy}_add_form_fields`
* `{$taxonomy}_add_form`
* `media_upload_$type`
* `media_upload_$tab`
* `install_plugins_pre_$tab`
* `install_plugins_$tab`
* `install_themes_pre_{$tab}`
* `install_themes_{$tab}`
* `update-core-custom_{$action}`
* `update-custom_{$action}`
* `user_{$name}_label`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30649 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:42:00 +00:00
Sergey Biryukov
d7955317f3 Theme install:
* Move the "based on" string below the rating to avoid wrapping to a second line.
* Reduce the gap between the theme screenshot and description.
* Fix Install button height on mobile.

props obenland, ocean90.
fixes #28148. see #29556.

git-svn-id: https://develop.svn.wordpress.org/trunk@29959 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:42:12 +00:00
Dominik Schilling (ocean90)
5829ccba9b Theme install: Remove unused strings.
fixes #29488.

git-svn-id: https://develop.svn.wordpress.org/trunk@29904 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 17:21:43 +00:00
Andrew Nacin
322991024f Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters.
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
 
Also:
 * Use the same nice design for the plugin upload screen as the theme upload screen.
 * Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578.
 * Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
 * Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.

fixes #29236.


git-svn-id: https://develop.svn.wordpress.org/trunk@29634 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-27 01:31:05 +00:00
Helen Hou-Sandi
f187cf1dec Make filter bar CSS less verbose and redundant.
Also removes an unused handler in the theme feature filter.

see #28794.


git-svn-id: https://develop.svn.wordpress.org/trunk@29596 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:57:34 +00:00
Helen Hou-Sandi
021750b4f4 Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794.
git-svn-id: https://develop.svn.wordpress.org/trunk@29217 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 03:39:04 +00:00
Helen Hou-Sandi
bfdd641013 More consistent icons in place of some buttons for the Customizer and theme install preview.
* Use a single close icon instead of a context-changing cancel/close button in the Customizer. In user testing, this small distinction in language was overlooked, and we use an AYS now instead. This also makes it consistent with the back arrow in Customizer panels.
* Use the same close icon as well as the previous/next arrows from the theme details browser in the theme install preview.

props celloexpressions. fixes #28655.


git-svn-id: https://develop.svn.wordpress.org/trunk@29031 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 18:18:23 +00:00
Sergey Biryukov
c1c0693cee Reinstate 'install_themes_tabs' filter.
props ghost1227.
fixes #28578.

git-svn-id: https://develop.svn.wordpress.org/trunk@29002 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 23:57:39 +00:00
Sergey Biryukov
d56f67b8e9 Update help text on Add Themes screen.
props thomasvanderbeek.
fixes #28132.

git-svn-id: https://develop.svn.wordpress.org/trunk@28473 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 23:43:41 +00:00
Sergey Biryukov
046a2bff94 Add context for 'Previous' and 'Next' theme strings.
see #28120, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28286 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 12:19:41 +00:00
Andrew Nacin
47de352468 Use correct echoing context function. see #27889.
git-svn-id: https://develop.svn.wordpress.org/trunk@28160 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-19 18:08:05 +00:00
Andrew Nacin
cb4f555da4 Context for 'Installed' and 'Already Installed' theme strings.
props SergeyBiryukov.
see #27889, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28159 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-19 18:07:30 +00:00
Andrew Nacin
7ed14feff1 Theme Installer: Revert to proxying through PHP for WordPress.org API requests.
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.


git-svn-id: https://develop.svn.wordpress.org/trunk@28126 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 01:15:43 +00:00
Andrew Nacin
b807ab4a34 Theme installer: Improve route handling and make ?theme= work.
props matveb.
fixes #27708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28123 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 22:05:20 +00:00
Andrew Nacin
e7524d0ba7 Theme install: Set a timeout and error message for API responses.
props ocean90.
fixes #27708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28105 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 19:01:21 +00:00
Andrew Nacin
d5c3a966be Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28037 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 04:30:01 +00:00
Andrew Nacin
b47c6d0746 Theme Installer: Disable prev/next buttons on first/last themes, add Esc handling, use IDs.
props adamsilverstein, DH-Shredder.
fixes #27521.


git-svn-id: https://develop.svn.wordpress.org/trunk@28033 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 03:57:01 +00:00
Andrew Nacin
bcc41afd37 Theme Installer: Handle currently installed themes, add search route, let prev/next refresh collections.
props matveb.
see #27055. fixes #27695.


git-svn-id: https://develop.svn.wordpress.org/trunk@28025 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 23:03:05 +00:00
Andrew Nacin
e40de50197 Theme Installer: Don't encode description entities/HTML.
props johnbillion.
fixes #27641.


git-svn-id: https://develop.svn.wordpress.org/trunk@27962 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:29:44 +00:00
Andrew Nacin
5863d7874d Theme Installer: Better responsive styles for feature filters.
props matveb.
fixes #27661.


git-svn-id: https://develop.svn.wordpress.org/trunk@27959 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:03:41 +00:00
Andrew Nacin
e8ad1fbf6c Theme Installer: Center spinner, remove plural string.
fixes #27581. see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27940 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:45:13 +00:00
Andrew Nacin
b29ccb5656 Theme Installer: Fix sorting, counts, keyboard navigation; add prev/next to previews.
props matveb.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27937 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 23:52:45 +00:00
Andrew Nacin
5b4287b991 Theme Installer fixes:
* Better more filters section. props sonjanyc for some mockups.
 * Better handling of no results.
 * Use # for hrefs.

props matveb.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27896 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-01 22:19:51 +00:00