Scott Taylor
1ffe74ad6f
Fix SQL generation when `meta_query` has an `'relation' => 'OR'` for its queries and wants to `'orderby' => 'meta_value'`.
...
Adds unit test.
Props jackreichert.
Fixes #25538 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28659 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 05:47:19 +00:00
Drew Jaynes (DrewAPicture)
24b3ed214e
Make sure to use 3-digit x.x.x style for two 3.9.0 `@since` versions.
...
Props netweb.
Fixes #28446 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28658 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 05:34:37 +00:00
Drew Jaynes (DrewAPicture)
85961d28df
Mark the `MYSQL_NEW_LINK` constant as deprecated in 3.9+ as no equivalent to the `$new_link` parameter exists in `mysqli_*` functions.
...
Fixes #27933 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28657 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 05:00:00 +00:00
Drew Jaynes (DrewAPicture)
9232548142
Improve inline documentation for wp-includes/load.php.
...
Props ericlewis, DrewAPicture.
Fixes #24886 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28656 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 04:11:21 +00:00
Drew Jaynes (DrewAPicture)
b884487767
Be more specific that `$post_id` does not default to the ID of the global `$post` in some cases.
...
See [28654]. See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28655 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 04:51:05 +00:00
Drew Jaynes (DrewAPicture)
d068c888f3
Ensure `$post_id` is documented as optional where applicable.
...
See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28654 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 04:43:47 +00:00
Drew Jaynes (DrewAPicture)
9bb9177199
Make sure `$post` is properly documented as optional where applicable.
...
See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28653 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 03:52:46 +00:00
Scott Taylor
6a9c55cd9f
Because of YouTube's overwhelming dominance in the online video space, we should help our users who paste bad URLs when possible. It is easy to fix ` http://youtube.com/embed/acb1233 ` URLs by turning them into ` http://youtube.com/watch?v=abc1233 ` embeds using an embed handler (we already have one to fix Google Video embeds).
...
We should avoid doing this in almost every other case, but it's YouTube, and it's an easy error for a novice to make.
Fixes #24660 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28652 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 01:21:13 +00:00
Sergey Biryukov
9953e4ddaf
Add oEmbed support for TED talks.
...
props pdclark.
fixes #28285 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28651 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:45:12 +00:00
Scott Taylor
174af6cca4
In the spirit of [27622], add a few CSS rules to ensure that videos will be responsive, regardless of theme.
...
Props Funkatronic.
Fixes #28414 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28650 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:39:47 +00:00
Scott Taylor
58690d7b97
In `WPPlaylistView::ended()`, at the end of a playlist, set the index to `0` and call `->setCurrent()` instead of `->loadCurrent()` so that the first track is properly highlighted.
...
Fixes #28428 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28649 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:26:24 +00:00
Sergey Biryukov
d4b336ded2
Fix typo in mbstring_binary_safe_encoding() description.
...
props ghost1227.
fixes #28423 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28648 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-01 05:05:44 +00:00
Sergey Biryukov
4ecfd017b8
Capitalize 'ID' correctly to avoid random failures of Tests_Tax_Query::test_term_taxonomy_id_field_no_taxonomy().
...
see #25284 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28647 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-01 03:17:16 +00:00
Sergey Biryukov
e8e39d212b
Plugin activation/deletion errors should be styled as such.
...
props johnbillion.
fixes #28260 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28646 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-31 20:09:26 +00:00
Lance Willett
f48c3b9582
Twenty Fourteen: change hardcoded pagination base to use the WordPress Rewrite object's `pagination_base` value instead. Document global variable usage properly.
...
Props SergeyBiryukov, fixes #28405 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28645 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-31 18:50:16 +00:00
Sergey Biryukov
c04daa1ade
Avoid stomping of the $plugin variable in activate_plugin().
...
fixes #28102 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28644 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 22:07:43 +00:00
Sergey Biryukov
9120e6a9d7
Display the site scheme, not the current scheme on Edit Site screen in network admin.
...
props johnbillion.
fixes #28406 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28643 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 22:00:45 +00:00
Sergey Biryukov
dbef7e2587
Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite.
...
props jkudish, topher1kenobe.
fixes #20271 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28642 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 21:50:24 +00:00
Sergey Biryukov
3afd9885c2
Adjacent links in wp_head() should only be generated for posts, not pages.
...
props alexander.rohmann.
fixes #21658 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28641 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 21:19:55 +00:00
wonderboymusic
2d0be44d85
In `WP_Image_Editor_GD::_save()`, pass `$compression_level` into the args array for `->make_image()`.
...
Props MuViMoTV, markoheijnen, SergeyBiryukov, mikemanger, ericlewis.
Fixes #24380 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28640 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 20:05:02 +00:00
Scott Taylor
804b82bd11
Make the image editor less jumpy when opening.
...
Props eddiemoya, ericlewis.
Fixes #22793 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28639 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:52:35 +00:00
Scott Taylor
3d48e21248
Fix an error caused by [28604] in `get_comments_number()` unit tests.
...
Props SergeyBiryukov.
Fixes #26240 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28638 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:46:05 +00:00
Scott Taylor
e996a74984
Restore `$val` in `WP_Importer::bump_request_timeout()` - even though the parent class and `WP_Import` ignore the parameter, it creates an incompatible interface notice in the plugin.
...
See [28629].
git-svn-id: https://develop.svn.wordpress.org/trunk@28637 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:34:53 +00:00
Scott Taylor
fc2601044b
`wp_xmlrpc_server::wp_getPage()` should `return new IXR_Error(` instead of `return(new IXR_Error(`. One of the few places that is unparseable by static analysis.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28636 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:21:33 +00:00
Scott Taylor
273fd5ca4c
Add more test coverage for `wpdb`.
...
See #26999 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28635 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:17:15 +00:00
Scott Taylor
de685a9f73
Move `default` to the bottom in `_wp_mysql_week()`.
...
See #28409 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28634 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 18:09:43 +00:00
Scott Taylor
2cd825a21b
Cleanup for `switch` statements:
...
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) { .... }` syntax. (A few template-type instances linger).
Fixes #28409 .
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28633 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 17:57:51 +00:00
Drew Jaynes (DrewAPicture)
dc96d99a70
Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php.
...
Also add `@param` and `@return` descriptions.
See #28408 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28632 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 17:37:36 +00:00
Scott Taylor
1a1994b20f
Adds a unit test to demonstrate that the order of `case` and `default` in a `switch` statement does not matter.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28631 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 17:31:51 +00:00
Lance Willett
a0dbf001c5
Twenty Fourteen: adjust spacing for site description (tagline) to avoid cutting off accented characters. Props SergeyBiryukov, iamtakashi. Fixes #28397 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28630 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 17:08:14 +00:00
Scott Taylor
7ab6b096e6
Remove some dead variable assignments.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 16:58:36 +00:00
Drew Jaynes (DrewAPicture)
1da8a18e5f
Update the `$secure_logged_in_cookie` variable in the 'secure_logged_in_cookie' hook docs following [28627].
...
See #15330 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28628 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 15:19:29 +00:00
Andrew Nacin
8d980de0ee
Use a secure logged_in_cookie when the home URL is forced HTTPS (see #27954 ).
...
see #15330 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28627 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 15:07:18 +00:00
Andrew Ozz
d87a482353
TinyMCE in iOS:
...
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242
git-svn-id: https://develop.svn.wordpress.org/trunk@28626 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 02:37:52 +00:00
Scott Taylor
7f49c1320a
`@uses` means something entirely different for unit tests. More: http://thephp.cc/viewpoints/blog/2014/03/phpunit-4-0-code-coverage-improvements
...
Code coverage analysis takes forever to run, and these annotations will cause it to fail in the middle.
See #26999 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28625 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 23:33:13 +00:00
Andrew Ozz
1da0e87bdc
TinyMCE: remove margins from the image toolbar wrapper, props avryl, fixes #28389
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28624 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 22:58:27 +00:00
Scott Taylor
8f247884c2
Simplify the logic for determining `isset( $this->query['s'] )` after [28612], and don't limit this logic to just the main query.
...
Props SergeyBiryukov.
Fixes #11330 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28623 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 20:49:28 +00:00
Scott Taylor
8bb2117aad
If `post_status` is passed to `WP_Query` as an array containing `'any'` and anything else, don't exclude the other values if they match when running `any`'s exclusion logic.
...
Adds unit tests.
Fixes #28007 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28622 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 20:41:53 +00:00
Scott Taylor
eba9bf7171
These unit tests should point at an actual attachment file.
...
See [28619].
git-svn-id: https://develop.svn.wordpress.org/trunk@28621 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 20:39:05 +00:00
Andrew Ozz
44549d4918
Fix double quote jshint warning in Gruntfile.js, fixes #26751
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28620 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 19:33:00 +00:00
Scott Taylor
fcff169970
Add unit tests to confirm that `post__in` orderby is working as expected with `menu_order` based on comments from #28012 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28619 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 18:23:58 +00:00
Scott Taylor
25593e291c
When queries are passed to `WP_Tax_Query`, the value for `operator` is assumed to be uppercase. This is an unnecessary constraint. In `->get_sql()`, cast it using `$operator = strtoupper( $query['operator'] )`.
...
Props clifgriffin.
Fixes #27557 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28618 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 17:52:25 +00:00
Helen Hou-Sandi
2e1c4959af
Fix a jshint error introduced in [28607]. see #23560 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28617 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 14:24:20 +00:00
Helen Hou-Sandi
220a45a32d
Don't use the box shadow focus styling for the admin menu or toolbar. see #28267 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28616 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 14:22:39 +00:00
Andrew Ozz
6418ba1696
Regex should be non-greedy, see #28389
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28615 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 07:55:17 +00:00
Andrew Ozz
8f5ea4bacd
TinyMCE: fix problems with undo/redo after resizing an image several times. Fixes #28389 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28614 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 07:50:35 +00:00
Scott Taylor
8530693a51
If `post__in` or `post_parent__in` is passed to `WP_Query` as an empty array, nuke the query. Both vars are currently only checked for truthiness after which they are ignored. Setting these vars at all indicates explicit filtering being desired.
...
Adds unit test.
Fixes #28099 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28613 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 06:03:15 +00:00
Scott Taylor
4d1e46231b
When parsing the main query, if `s` is set to empty: `?s=` and `$this->is_main_query() && array_key_exists( 's', $this->query )` - kill the query instead of loading the homepage. This will load the search page with no results.
...
Fixes #11330 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28612 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 05:47:35 +00:00
Andrew Nacin
6e269a7120
Append the date to $wp_version in the build output, for nightly packages.
...
props azaozz.
fixes #26751 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28611 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 04:32:41 +00:00
Andrew Nacin
e317e5454a
Force SSL on the frontend via canonical when the home URL uses the https scheme.
...
fixes #27954 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28610 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 04:12:05 +00:00