sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
32,674 Commits 2 Branches 473 Tags 137 MiB
7674a767ed
Commit Graph

8989 Commits

Author SHA1 Message Date
Andrea Fercia
ac3edc61fd Press This: Improve the "choose tags" button focus style. 
Props adamholisky for the initial patch.

Fixes 34241.

git-svn-id: https://develop.svn.wordpress.org/trunk@35338 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 18:33:46 +00:00
Dominik Schilling (ocean90)
05356ff7dc Options: Hide the week starts on setting for installs that have the default setting already. 
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35337 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 17:38:44 +00:00
Dominik Schilling (ocean90)
597e3630f3 WP Locale: Add a start_of_week property to store the start of the week per locale. 
Props swissspidy.
See #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35336 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 17:27:47 +00:00
Boone Gorges
f492a81d70 Prevent non-public taxonomies from registering aquery var. 
[34247] made the 'public' paramater of `register_taxonomy()` work by blocking
requests for non-public taxonomy archives during `parse_request()`. Blocking
taxonomy archive requests this late means that it's impossible to register an
independent query var that matches the slug of a non-public taxonomy. By
moving the block to `register_taxonomy()` - not allowing these taxonomies to
register their query vars in the first place - we free up the slug for other
use. In addition, we free up a bit of processing (no need to look for the query
var in `parse_request()` and better parallel the way non-public post types
work. See `register_post_type()`.

Non-public taxonomy archives that are requested using `?taxonomy=tax_name` are
still blocked during `parse_request`. It's only custom query vars -
`?tax_name=term` - that are affected by this change.

Props mboynes.
Fixes #21949.

git-svn-id: https://develop.svn.wordpress.org/trunk@35333 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 16:53:51 +00:00
Boone Gorges
e4b72ad5ca Don't force comment pagination. 
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@35331 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 16:25:31 +00:00
Helen Hou-Sandi
11bd47beca Media: Update colors to match the times. 
This bikeshed is a real nice blue.

props afercia.
fixes #34244. see #34388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35330 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 16:17:58 +00:00
Drew Jaynes
6c178fd1ab Docs: Add documentation in the form of a hash notation for default arguments accepted by wp_login_form(). 
Props ramiy for the initial patch.
Fixes #34364.


git-svn-id: https://develop.svn.wordpress.org/trunk@35328 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 15:37:23 +00:00
Helen Hou-Sandi
3d64414d5c wp_die(): Update colors and button styling. 
see #34388, #31459.


git-svn-id: https://develop.svn.wordpress.org/trunk@35327 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 15:23:01 +00:00
Dominik Schilling (ocean90)
9a1b5f93cd List Tables: Replace the hyphen separator for titles and post/media states with a —. 
Props McGuive7.
Fixes #23230.

git-svn-id: https://develop.svn.wordpress.org/trunk@35326 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 14:32:02 +00:00
Drew Jaynes
a28e35e462 Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES constants in [35286], use them in various places in core. 
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 14:02:59 +00:00
Drew Jaynes
86794324c7 Docs: Improve the return description in the DocBlock for rest_send_allow_header(). 
Props danielbachhuber.
Fixes #34374.


git-svn-id: https://develop.svn.wordpress.org/trunk@35324 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 13:47:12 +00:00
Sergey Biryukov
bc2a538b1a REST API: Change nonce name to _wpnonce. 
It's shorter and is compatible with the default name in `wp_nonce_field()`.

Props danielbachhuber.
Fixes #34375.

git-svn-id: https://develop.svn.wordpress.org/trunk@35323 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 08:13:18 +00:00
Sergey Biryukov
5bba750579 Add get_terms_defaults filter for the default arguments of get_terms(). 
Fixes #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35322 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 08:07:12 +00:00
Sergey Biryukov
f3f2a222b9 Reorder default arguments in get_terms() for consistency with the hash notation added in [29128]. 
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35321 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 08:00:56 +00:00
Sergey Biryukov
7b81e1e56c Docs: Correct function name in get_terms_args parameter description. 
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35320 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 07:41:38 +00:00
Sergey Biryukov
892cef6da5 Docs: Correct duplicate hook reference for get_terms. 
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35319 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 07:39:11 +00:00
Andrew Ozz
5bc6ae50ab Precommit cleanup, see r35313. 
git-svn-id: https://develop.svn.wordpress.org/trunk@35318 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 05:32:54 +00:00
Andrew Ozz
7ba408c93e Widgets: add a button to delete all inactive widgets simultaneously for better UX. 
Props cdog.
Fixes #19159.

git-svn-id: https://develop.svn.wordpress.org/trunk@35317 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 05:22:52 +00:00
Scott Taylor
ba1177bf4c Export: add missing labels and improvement accessibility of the Export screen. 
Props afercia.
Fixes #33046.


git-svn-id: https://develop.svn.wordpress.org/trunk@35316 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 03:56:22 +00:00
Scott Taylor
6f6c0ebb52 Plugins/Updates: in request_filesystem_credentials(), alter the heading HTML tag based on the current screen for improved semantics. 
Props afercia.
Fixes #34267.


git-svn-id: https://develop.svn.wordpress.org/trunk@35315 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 03:50:19 +00:00
Scott Taylor
51637379a2 Formatting: move url_shorten() from wp-admin/includes/misc.php to wp-includes/formatting.php for more global access. 
Adds unit tests.

Props mulvane, chriscct7.
Fixes #20166.


git-svn-id: https://develop.svn.wordpress.org/trunk@35314 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 03:47:23 +00:00
Scott Taylor
be739bd6c0 Administration: the current admin menu item should have an aria-haspopup attribute when the menu is folded. 
Unify the jQuery selector caching for `window`, `document`, and `body`.

Props afercia.
Fixes #32578.


git-svn-id: https://develop.svn.wordpress.org/trunk@35313 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 03:40:38 +00:00
Scott Taylor
e4bcddecfb Site Icon: make the default value for the site_icon option 0 in schema.php. 
Props swissspidy, sebastian.pisula.
Fixes #34339.


git-svn-id: https://develop.svn.wordpress.org/trunk@35312 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 03:27:54 +00:00
Sergey Biryukov
5252cb7fe3 Autoprefixer for [35281]. 
See #33322.

git-svn-id: https://develop.svn.wordpress.org/trunk@35310 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-21 03:01:13 +00:00
Weston Ruter
ede4050ace Customizer: Prevent nav_menu_item settings from becoming dirty when their controls are set up. 
Since `wp_setup_nav_menu_item()` returns the `classes` property as an array but the Customizer manages the value as a string, the setting needs to initially export the value as a string. This prevents the `classes` property type change from causing the setting to get marked as dirty even though nothing changed. This is a regression from [34788].

See #34111.


git-svn-id: https://develop.svn.wordpress.org/trunk@35308 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 22:44:44 +00:00
Weston Ruter
bde89adaf8 Customizer: Introduce customize_loaded_components filter to allow core components to be disabled. 
Also move style rule from `customize-nav-menus.css` to `customize-controls.css` so that widgets button is properly styled when `nav_menus` component is excluded from loading. See [35304]. See #33327.

Props westonruter, DrewAPicture.
Fixes #33552.


git-svn-id: https://develop.svn.wordpress.org/trunk@35307 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 22:15:11 +00:00
Andrew Ozz
73d755b67a TinyMCE: update to 4.2.6. Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=887. 
Fixes #34331.

git-svn-id: https://develop.svn.wordpress.org/trunk@35306 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 22:05:31 +00:00
Weston Ruter
261aa51182 Customizer: Allow new option settings to not be saved as autoloaded by passing an autoload arg value of false. 
The `autoload` argument value is passed along to `update_option()` which has accepted an `$autoload` parameter since [31628].

Props westonruter, dlh.
See #26394.
Fixes #33499.


git-svn-id: https://develop.svn.wordpress.org/trunk@35305 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 21:18:04 +00:00
Andrea Fercia
8774b40dc8 Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons. 
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.

Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.

Fixes #33327.

git-svn-id: https://develop.svn.wordpress.org/trunk@35304 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 20:14:51 +00:00
Drew Jaynes
11f4d7bb68 Docs: Add translator comments for two _deprecated_argument() calls added to get_wp_title_rss() and wp_title_rss() in [35294]. 
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35303 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 19:19:37 +00:00
Weston Ruter
9724c7cdbd Customizer: Implement indicators for invalid nav menu items. 
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.

Props kucrut, westonruter.
Fixes #33665.


git-svn-id: https://develop.svn.wordpress.org/trunk@35302 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 19:07:58 +00:00
Drew Jaynes
1871d57dc5 Docs: Adjust syntax in the hook doc summaries for the document_title_separator and document_title_parts filters, introduced in [35294]. 
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35301 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 18:35:46 +00:00
Drew Jaynes
b11b651d24 Docs: Fix indentation and improve usefulness of inline comments surrounding the if/elseif conditions for assigning document titles in wp_get_document_title(). 
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35300 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 18:30:59 +00:00
Konstantin Obenland
e9579b3ed5 Site Icon: Get site icon ID only when needed. 
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.



git-svn-id: https://develop.svn.wordpress.org/trunk@35299 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 18:22:41 +00:00
Drew Jaynes
8ec6153115 Docs: Update the hook doc for the pre_get_document_title filter to explain ''what'' value is filterable rather than ''why'' the value is filterable :-) 
The hook was introduced in [35294].

See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35298 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 18:13:13 +00:00
Drew Jaynes
e5ec034d8f Docs: Improve vague changelog entries for functions and hooks where arguments were deprecated in [35294]. 
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35297 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 18:09:06 +00:00
Drew Jaynes
2f5c72fea8 Docs: Fix up DocBlock syntax for the now-deprecated wp_title(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35296 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 17:52:21 +00:00
Konstantin Obenland
c7a86be42c Tests: Use updated filter names and oembed title for UT sanity. 
See [35294], #31078.


git-svn-id: https://develop.svn.wordpress.org/trunk@35295 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 17:04:29 +00:00
Konstantin Obenland
d625bd2428 Themes: Improve document title output. 
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.



git-svn-id: https://develop.svn.wordpress.org/trunk@35294 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 16:20:04 +00:00
Sergey Biryukov
1940317385 In wp_list_categories(), rewrite a long condition for clarity. 
See #34363.

git-svn-id: https://develop.svn.wordpress.org/trunk@35293 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 16:12:21 +00:00
Sergey Biryukov
0a614515ac Tags: Avoid a double trailing space after tags separator in auto-suggest. 
Props afercia.
Fixes #33881.

git-svn-id: https://develop.svn.wordpress.org/trunk@35292 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 15:59:01 +00:00
Boone Gorges
2713768bb0 Correct inline comment in wp_list_categories(). 
The fallback link for the 'All' option is 'page_for_posts', not
'page_on_front'. Introduced in [32292].

Props sudar, SergeyBiryukov.
Fixes #34363.

git-svn-id: https://develop.svn.wordpress.org/trunk@35291 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 12:54:55 +00:00
Drew Jaynes
5b8bd2209e Docs: Correction: MONTH_IN_SECONDS was added in 4.4.0. 
Props swissspidy.
See [33698]. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35290 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 07:34:34 +00:00
Drew Jaynes
1ed7489957 Media: Introduce the image_get_intermediate_size filter to its like-named function, making it possible to manipulate returned intermedia image size data. 
Covers both the default and meaningful short-circuit return cases. Also adds a hash notation to the return documentation in the DocBlock.

Props A5hleyRich, DH-Shredder, wonderboymusic.
Fixes #34124.


git-svn-id: https://develop.svn.wordpress.org/trunk@35289 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 07:23:18 +00:00
Drew Jaynes
7972ba8126 Media: Introduce the enclosure_links filter, which makes it possible to adjust the list of audio and video enclosure links derived from post content before querying the database. 
Props niallkennedy, stevenkword.
Fixes #19890.


git-svn-id: https://develop.svn.wordpress.org/trunk@35288 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 07:08:59 +00:00
Drew Jaynes
aec5d8766b Docs: The MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, MONTH_IN_SECONDS, and YEAR_IN_SECONDS constants were introduced in 3.5. 
See [21996]. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35287 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 06:58:50 +00:00
Drew Jaynes
2bd3c9a832 Filesystem: Introduce constants to allow for easier expression of file sizes and other data amounts. 
Adds:
* `KB_IN_BYTES` (kilobytes)
* `MB_IN_BYTES` (megabytes)
* `GB_IN_BYTES` (gigabytes)
* `TB_IN_BYTES` (terabytes)

Props nbachiyski, sudar.
See #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35286 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 06:54:41 +00:00
Drew Jaynes
1a999bce25 Query: Introduce the content_pagination filter, which makes it possible to manipulate how post content is split into "pages" in WP_Query::setup_postdata(). 
The "pages" — or chunks of post content – are determined by splitting based on the presence of `<!-- nextpage -->` tags in the post content.

Props sirzooro, chriscct7.
Fixes #9911.


git-svn-id: https://develop.svn.wordpress.org/trunk@35285 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 06:32:16 +00:00
Scott Taylor
ea7e8314d2 Formatting: allow date strings to be passed to get_gmt_from_date(), instead of requiring 'Y-m-d H:i:s'. 
Adds unit tests.

Props pbearne.
Fixes #34279.


git-svn-id: https://develop.svn.wordpress.org/trunk@35284 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 06:07:45 +00:00
Scott Taylor
895cf207b5 Feeds: add CEST to $timezone in SimplePie_Parse_Date. 
Props swissspidy.
Fixes #32749.


git-svn-id: https://develop.svn.wordpress.org/trunk@35283 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 05:56:59 +00:00
Scott Taylor
eb6bdb59cd Dashboard: use the create_posts cap on the post type object when determining if the Quick Press widget can be displayed. 
Props jim912, ocean90, chriscct7.
Fixes #25681.


git-svn-id: https://develop.svn.wordpress.org/trunk@35282 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 05:48:11 +00:00
Scott Taylor
f07367d34c Theme Installer: toggle iframe-ready on the overlay to control the spinner animated GIF and high CPU usage. 
Props afercia, adamsilverstein.
Fixes #33322.


git-svn-id: https://develop.svn.wordpress.org/trunk@35281 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 05:35:07 +00:00
Scott Taylor
91d55f97c2 Users: when calling wp_insert_user() with an valid user ID, return WP_Error instead of arbitrarily updating user meta. 
Adds unit test.

Props swissspidy, bilalcoder.
Fixes #28004.


git-svn-id: https://develop.svn.wordpress.org/trunk@35280 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 05:27:32 +00:00
Scott Taylor
6ae2e24d28 XML-RPC: after [35095], change the name of the xmlrpc_memory_limit filter to xmlrpc_chunk_parsing_size. 
Props ankit.gade.
Fixes #29957.


git-svn-id: https://develop.svn.wordpress.org/trunk@35279 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 05:18:15 +00:00
Scott Taylor
b18755172b Widgets: revert [34376] and [34386] as pertains to the Categories widget supporting custom taxonomies. 
Punting on 4th down.

See #21165.


git-svn-id: https://develop.svn.wordpress.org/trunk@35278 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 04:56:57 +00:00
Scott Taylor
089276d5e8 List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns). 
See #31634.


git-svn-id: https://develop.svn.wordpress.org/trunk@35277 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 04:28:05 +00:00
Scott Taylor
fdd8106001 Formatting: when making unique filenames in wp_unique_filename() by adding an incrementing number, prefix it with a dash to disambiguate from files that end in numbers. 
Updates unit tests.

Props mikejolley, tyxla.
Fixes #21453.


git-svn-id: https://develop.svn.wordpress.org/trunk@35276 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 04:04:26 +00:00
Scott Taylor
9b27952d46 Customizer: when available, show the description when rendering the dropdown-pages Control. 
Props downstairsdev, MikeHansenMe, _smartik_.
Fixes #31540.


git-svn-id: https://develop.svn.wordpress.org/trunk@35275 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-20 03:47:34 +00:00
Drew Jaynes
85af87a19b Docs: Update the default scheme for get_rest_url() from 'json' to 'rest'. 
Also adds 'rest' to the documented list of schemes for `home_url()`, `get_home_url()`, `set_url_scheme()`, and the `home_url` and `set_url_scheme` hooks.

Props rachelbaker.
Fixes #34300.


git-svn-id: https://develop.svn.wordpress.org/trunk@35274 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-19 22:38:03 +00:00
Andrea Fercia
3ee61161c6 Accessibility: Improve the headings hierarchy in the Add Themes screen. 
Fixes #33819.

git-svn-id: https://develop.svn.wordpress.org/trunk@35273 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-19 22:03:48 +00:00
Drew Jaynes
900810e508 Docs: Add a missing file header for wp-admin/includes/class-wp-site-icon.php. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35271 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-19 20:08:34 +00:00
Boone Gorges
583b065e14 Don't store data as a property on WP_Term objects. 
`wp_ajax_add_term()` fetches a term using `get_term()`, and passes the term to
`WP_Ajax_Response`, which expects each of the term's properties to be scalar.
Having `$data` as a `stdClass` (meant to mimic `WP_User::data`, populated by
a `get_row()` database query) violated this expectation, causing fatal string
conversion errors. As a workaround, `$term->data` is converted so that it is
no longer an actual property of the term object, but is assembled only when
requested in the magic `__get()` method.

Fixes #34348.

git-svn-id: https://develop.svn.wordpress.org/trunk@35269 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-19 03:11:30 +00:00
Boone Gorges
990eebf373 Bust object term cache in wp_remove_object_terms(). 
Props tszming.
Fixes #34338.

git-svn-id: https://develop.svn.wordpress.org/trunk@35268 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-19 01:52:22 +00:00
Dion Hulse
063d42a801 In insert_with_markers() restore the 4.3 behaviour of creating the file if it doesn't exist. 
This change also makes it bail early (without writing) if the markers content is the same as the existing, and uses `ftell()` rather than `$bytes` for the location to truncate the file to - based on the file pointer being at the end of the written stream.

Props willmot tigertech kevinatelement
See #31767


git-svn-id: https://develop.svn.wordpress.org/trunk@35267 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-19 00:52:08 +00:00
Drew Jaynes
10322a38bf Docs: Fix a typo in the $blog_id parameter name in the rest_url filter doc. 
Props rachelbaker.
Fixes #34351.


git-svn-id: https://develop.svn.wordpress.org/trunk@35266 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-18 23:11:49 +00:00
Andrea Fercia
ccb76a5af0 Multisite: Improve the Admin Bar parent menu items color on hover and focus. 
Props Nikschavan for the initial patch.
Fixes #34040.

git-svn-id: https://develop.svn.wordpress.org/trunk@35265 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-18 16:21:42 +00:00
Drew Jaynes
0fb4304628 Taxonomy: Improve deprecated argument strings for the 'link' type in get_categories() and wp_dropdown_categories(). 
Props swissspidy, gagan0123.
Fixes #34318.


git-svn-id: https://develop.svn.wordpress.org/trunk@35264 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-18 15:34:55 +00:00
Drew Jaynes
84d3e1f305 Administration: Introduce the manage_posts_extra_tablenav action, which fires inside the tablenav for the posts list table, and just outside the "actions" container. 
Props hlashbrooke, wonderboymusic.
Fixes #30341.


git-svn-id: https://develop.svn.wordpress.org/trunk@35263 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-18 14:55:52 +00:00
Drew Jaynes
cb2bc30252 Docs: Add a version to the file header for wp-admin/includes/comment.php. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35262 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-18 14:33:31 +00:00
Ella Iseulde Van Dorpe
67ff09cf33 TinyMCE: Drag and drop link with image 
Make sure images don't loose their link after drag and drop.

Fixes #28272.


git-svn-id: https://develop.svn.wordpress.org/trunk@35261 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-18 11:04:33 +00:00
Sergey Biryukov
8c19030438 Embeds: After [35235], replace some missed oembed references with embed. 
Props peterwilsoncc.
Fixes #34272.

git-svn-id: https://develop.svn.wordpress.org/trunk@35253 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 23:25:56 +00:00
John Blackbourn
d5b31e6ba2 Introduce map_deep(), a utility function that recursively maps a callable function to every item in an array or object. Works like array_walk_recursive() but works with objects too. 
Updates `rawurlencode_deep()`, `urlencode_deep()`, and `stripslashes_deep()` to use `map_deep()`. Introduces `urldecode_deep()` for completeness.

Props wpmuguru, nbachiyski, boonebgorges, MikeHansenMe, chriscct7, realloc, johnbillion
Fixes #22300


git-svn-id: https://develop.svn.wordpress.org/trunk@35252 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 23:25:21 +00:00
Weston Ruter
f8e79c5bbc Customizer: Fix margin-top calculation for Themes section. 
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].

See #33567.



git-svn-id: https://develop.svn.wordpress.org/trunk@35251 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 22:40:10 +00:00
Scott Taylor
641e372432 Media: in wp_get_attachment_image_sizes(), ensure that $img_width exists when the image does not. 
Props kraftbj.
See #33641.



git-svn-id: https://develop.svn.wordpress.org/trunk@35250 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 22:11:28 +00:00
Drew Jaynes
5a0fd03f95 Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35241 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 15:12:48 +00:00
Drew Jaynes
0bb4a1bdd0 Docs: Improve the hook doc for the get_post_status filter, introduced in [35233]. 
Also adds a missing parameter description for `$post`.

See #23458. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35240 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 14:23:05 +00:00
Ella Iseulde Van Dorpe
5b5b67ee31 JSHint after [35238] 
git-svn-id: https://develop.svn.wordpress.org/trunk@35239 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 07:10:55 +00:00
Ella Iseulde Van Dorpe
112af0751f Admin: fix repositioning notices 
Fixes #34294.
Props afercia.


git-svn-id: https://develop.svn.wordpress.org/trunk@35238 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 07:03:30 +00:00
Drew Jaynes
cba5390270 Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35237 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 06:06:59 +00:00
Sergey Biryukov
9b591d6b09 Embeds: Rename files, functions, and hooks added in [34903] to make it more clear what is oEmbed-specific and what isn't. 
See https://core.trac.wordpress.org/ticket/34272#comment:7 for full list of renamed functions and hooks.

Props swissspidy.
Fixes #34272.

git-svn-id: https://develop.svn.wordpress.org/trunk@35235 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 01:20:19 +00:00
Sergey Biryukov
5c19a7a704 Replace Quick Edit and Bulk Edit headings with <legend> elements. 
Props afercia.
Fixes #34289.

git-svn-id: https://develop.svn.wordpress.org/trunk@35234 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 00:44:12 +00:00
Aaron Jorbin
7db19dcda2 Improve get_post_permalink compatibility with non standard post status 
This adds a new filter named `get_post_status` to the function named `get_post_status` which can be used to make additional post types behave like unpublished post status in `get_post_permalink`.

Props misterbisson, antpb, iamfriendly
Fixes #23458



git-svn-id: https://develop.svn.wordpress.org/trunk@35233 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 00:43:54 +00:00
Sergey Biryukov
fe72320f33 Merge two strings for expanding accordion and Customizer sections. 
Props pavelevap.
Fixes #33939.

git-svn-id: https://develop.svn.wordpress.org/trunk@35232 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-17 00:27:44 +00:00
Weston Ruter
370057b5d7 Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview. 
Widgets panel will not wait to display until the preview loads.

Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.

Fixes #33052.
Fixes #33567.


git-svn-id: https://develop.svn.wordpress.org/trunk@35231 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 23:47:56 +00:00
Sergey Biryukov
de182f7736 Merge two warning strings. 
Props pavelevap.
Fixes #29740.

git-svn-id: https://develop.svn.wordpress.org/trunk@35230 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 23:30:29 +00:00
Sergey Biryukov
af36c261e3 Sample permalink: Improve accessibility of changing the permalink on Edit Post screen. 
Props afercia.
Fixes #34255.

git-svn-id: https://develop.svn.wordpress.org/trunk@35229 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 23:01:58 +00:00
Sergey Biryukov
7b6454bf6b Embeds: In print_oembed_embed_styles(), load non-minified file if SCRIPT_DEBUG is true. 
This is consistent with `print_oembed_embed_scripts()`.

Props MikeHansenMe.
Fixes #34321.

git-svn-id: https://develop.svn.wordpress.org/trunk@35228 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 22:42:47 +00:00
Boone Gorges
f22ba848df Return null from get_term() on taxonomy mismatch. 
[34997] caused `get_term()` to return an error object in the case when
`$taxonomy` did not match the taxonomy of the located term. This was an
inadvertant change from the previous behavior, when `get_term()` would return
null in these cases.

Props dlh.
See #14162. Fixes #34332.

git-svn-id: https://develop.svn.wordpress.org/trunk@35227 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 21:41:51 +00:00
Sergey Biryukov
0d4a7ee029 In WP_Posts_List_Table, correct the type for $comment_pending_count. 
See #11381.

git-svn-id: https://develop.svn.wordpress.org/trunk@35223 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 18:24:25 +00:00
Sergey Biryukov
e4c9f97fb3 In WP_Media_List_Table, rename $pending_count to $comment_pending_count and mark it as protected, for consistency with WP_Posts_List_Table. 
See #11381.

git-svn-id: https://develop.svn.wordpress.org/trunk@35222 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 18:22:12 +00:00
Drew Jaynes
ea8e9f89cd Docs: Standardize the file header summary for wp-admin/includes/file.php. 
Also adds an `@since` version and corrects the `@subpackage` value.

See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35221 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 16:55:24 +00:00
Andrea Fercia
cb2285f63e Accessibility: Improve headings hierarchy in the Theme browser modal dialog. 
Fixes #34288.

git-svn-id: https://develop.svn.wordpress.org/trunk@35220 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 15:55:06 +00:00
Andrea Fercia
e68dfb6c6b Bump H4 headings to H2 in the Updates screen for better accessibility. 
Fixes #34265.

git-svn-id: https://develop.svn.wordpress.org/trunk@35219 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 15:44:49 +00:00
Ella Iseulde Van Dorpe
4abf64eb14 TinyMCE: add lang attribute 
This is needed to make `hyphens: auto;` work correctly.

Fixes #32555.


git-svn-id: https://develop.svn.wordpress.org/trunk@35217 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 10:10:32 +00:00
Ella Iseulde Van Dorpe
093b6b5d11 TinyMCE: make sure markers are removed after first init 
This is only relevant to non embeddable URLs.
After first init, markers were set but not removed,
causing an edited URL to revert when switching to text mode
or any paragraph after the URL to just contain that URL.

Fixes #33954.


git-svn-id: https://develop.svn.wordpress.org/trunk@35216 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 05:42:22 +00:00
Helen Hou-Sandi
b9c1a56e38 Account for icon alignment using text-indent in RTL. 
fixes #33808.


git-svn-id: https://develop.svn.wordpress.org/trunk@35215 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-16 00:57:47 +00:00
Dominik Schilling (ocean90)
f75321f3ec Multisite: Remove the strictness for $using_paths in WP_Network::get_by_path(). 
The network lookup was broken when using an external object cache because `$using_paths` isn't always a boolean. Added in [34099].

See #31985, #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@35212 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 22:06:38 +00:00
Drew Jaynes
c8bf2ce727 Docs: Fix a typo in an inline comment in wp_get_attachment_image_srcset_array(). 
Props neoxx.
Fixes #34319.


git-svn-id: https://develop.svn.wordpress.org/trunk@35210 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 20:51:58 +00:00
Helen Hou-Sandi
3a8bd20594 Circular focus styling for widgets and menus in the customizer. 
see #33808.


git-svn-id: https://develop.svn.wordpress.org/trunk@35207 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 18:52:24 +00:00
Sergey Biryukov
acce286d34 In WP::parse_request() and url_to_postid(), don't skip objects that have a post status with 'exclude_from_search' => false, e.g. inherit. 
This fixes pretty permalinks for attachments, broken in [35195].

Fixes #21970.

git-svn-id: https://develop.svn.wordpress.org/trunk@35205 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 17:52:36 +00:00
Helen Hou-Sandi
0ff0b0e606 Make the database update button primary. 
see #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35204 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 17:34:30 +00:00
Drew Jaynes
ebd20119ec Docs: Walker_Nav_Menu_Checklist and Walker_Nav_Menu_Edit are part of the Navigation Menu API, but intended for use in the scope of administration. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35202 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 17:25:11 +00:00
Helen Hou-Sandi
b023eef6ca Box shadows still need -webkit-, turns out. 
see #33808, [35200].


git-svn-id: https://develop.svn.wordpress.org/trunk@35201 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 17:09:00 +00:00
Helen Hou-Sandi
19bb379a17 Circular focus styling for expand/collapse arrows. 
Affects postboxes, widgets, and nav menus, all in the admin.

props grvrulz for the initial patch.
see #33808.


git-svn-id: https://develop.svn.wordpress.org/trunk@35200 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 16:45:14 +00:00
Ella Iseulde Van Dorpe
017daba3d8 TinyMCE: make captioned images draggable 
See #28003.


git-svn-id: https://develop.svn.wordpress.org/trunk@35199 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 15:19:04 +00:00
Ella Iseulde Van Dorpe
604fb7511c Fix close button plugin modal after [18590] 
See #18590.



git-svn-id: https://develop.svn.wordpress.org/trunk@35198 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 14:51:01 +00:00
Sergey Biryukov
65390cd9cf In WP::parse_request() and url_to_postid(), if a post slug clashes with a trashed page, return the post instead of the page. 
Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970.

git-svn-id: https://develop.svn.wordpress.org/trunk@35195 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 06:48:22 +00:00
Sergey Biryukov
3d7aa47df8 Remove a one-time variable from edit_user() added in [35189]. 
See #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35190 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 05:45:50 +00:00
Sergey Biryukov
e675e2ccf0 Users: Add 'illegal_user_logins' filter to allow certain usernames to be blacklisted. 
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35189 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 05:42:05 +00:00
Sergey Biryukov
80178d8dc8 Themes: Add Install Parent Theme button for child themes that are missing a parent theme. 
Props rabmalin for initial patch.
Fixes #32668.

git-svn-id: https://develop.svn.wordpress.org/trunk@35187 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 05:10:32 +00:00
Sergey Biryukov
9fdd5ae513 Acessibility: Add back-compat styles for plugins that use h3 inside the .metabox-holder container. 
Props afercia.
Fixes #33557.

git-svn-id: https://develop.svn.wordpress.org/trunk@35184 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 03:37:03 +00:00
Helen Hou-Sandi
61ef1ff96f Make some primary action buttons look primary. 
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35182 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 03:07:48 +00:00
Sergey Biryukov
0f944bb515 Theme Editor: Repurpose the 'wp_theme_editor_filetypes' filter added in [35134] to actually filter file types instead of files. 
Default types include 'php' and 'css' and cannot be removed, only new types can be added.

Props DrewAPicture, SergeyBiryukov.
Fixes #22924.

git-svn-id: https://develop.svn.wordpress.org/trunk@35180 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 02:19:45 +00:00
Drew Jaynes
0cb7c0bd9f Docs: Add missing descriptions for the $wpdb global in DocBlocks all the places. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35170 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 23:43:10 +00:00
Drew Jaynes
68a3c0cc73 Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php. 
Also adds some missing parameter, return, and global descriptions, and one missing summary.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35169 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 23:24:46 +00:00
Drew Jaynes
c163beb1db Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php. 
See #33701.

[ci skip]


git-svn-id: https://develop.svn.wordpress.org/trunk@35168 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 22:48:24 +00:00
Drew Jaynes
e8a1b5dcdb Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35167 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 22:34:55 +00:00
Drew Jaynes
a845610bc6 Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35166 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 22:31:55 +00:00
Helen Hou-Sandi
c98ac461a9 Screen options: Improve the "Apply" button 
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.

Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.

fixes #34295. see #22222, #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35161 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 18:57:16 +00:00
Andrea Fercia
33a3d1bba8 Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility. 
Fixes #34286.

git-svn-id: https://develop.svn.wordpress.org/trunk@35160 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 17:43:42 +00:00
Jeremy Felt
896b29c857 MS: Introduce action before_signup_header. 
This aligns `wp-signup.php` a bit more `with `wp-activate.php` and, among other things, allows a plugin to redirect signup requests.

Props pbearne.
Fixes #17630.


git-svn-id: https://develop.svn.wordpress.org/trunk@35159 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 17:31:54 +00:00
Andrea Fercia
359b826e2c Bump H3 headings to H2 on the legacy Link Manager screen for better accessibility. 
Fixes #34285.

git-svn-id: https://develop.svn.wordpress.org/trunk@35158 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 17:31:29 +00:00
Drew Jaynes
5ffe8f5aef Docs: Add missing file headers to two Toolbar API files: wp-includes/admin-bar.php and wp-includes/class-wp-admin-bar.php. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35157 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 17:26:28 +00:00
Jeremy Felt
224efdf892 MS: Add "Settings" link under "Network Admin" toolbar menu. 
Props johnjamesjacoby.
Fixes #34287.


git-svn-id: https://develop.svn.wordpress.org/trunk@35156 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 16:59:33 +00:00
Andrea Fercia
83fd029f6d Accessibility: update a jQuery selector used for the Plugin Cards after [35009]. 
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.

Fixes #33818.

git-svn-id: https://develop.svn.wordpress.org/trunk@35155 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 15:26:31 +00:00
John Blackbourn
ad519f2ee0 Reinstate the Link Category admin screen after [34359]. 
See [13216]

Fixes #34284


git-svn-id: https://develop.svn.wordpress.org/trunk@35153 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 01:50:25 +00:00
John Blackbourn
9fa4df5955 Introduce a language chooser to the site signup process on Multisite. 
If your Multisite installation is one of the relatively few that allows new sites to be registered, either by existing users or by new visitors to your site, a 'Site Language' dropdown menu will now be presented if your network has additional languages installed. This option defaults to the value of the 'Default Language' setting on the Network Admin Settings screen, and is restricted to currently installed languages.

The languages available in this setting can be controlled via the `signup_get_available_languages` filter. To disable it completely, return an empty array.

Fixes #33844
Props DrewAPicture, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@35152 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 23:45:14 +00:00
John Blackbourn
b5c3abcdfa Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite. 
These plugins are only shown to users with the `manage_network_plugins` capability, which is Super Admins by default. This new feature lowers the blood pressure of Super Admins who may browse or search the Plugins listing screen of an individual site, having forgotten that a particular plugin is network-active. Showing inactive network-only plugins here also reduces friction when searching the Plugins listing screen on individual sites.

This change introduces a `show_network_active_plugins` filter which controls whether the network-active plugins and inactive network-only plugins are shown. This can be used to enable this functionality for regular site admininstrators, or, indeed, to disable this functionality for Super Admins.

Fixes #20104


git-svn-id: https://develop.svn.wordpress.org/trunk@35151 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 22:11:36 +00:00
John Blackbourn
61a40366e6 Improve the docs for the $expiration parameter in set_transient(), set_site_transient(), and associated filters. 
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35149 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 21:30:41 +00:00
Drew Jaynes
99ec80b140 Upgrader: Introduce a new action hook pre_auto_update, which fires immediately prior to an auto-update for core, themes, plugins, or translations. 
Props DavidAnderson, welcher.
Fixes #30441.


git-svn-id: https://develop.svn.wordpress.org/trunk@35144 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 18:58:00 +00:00
Sergey Biryukov
a15ff7d800 Correct the error message displayed on setup when wp-config-sample.php does not exist. 
Props bradparbs.
Fixes #23247.

git-svn-id: https://develop.svn.wordpress.org/trunk@35143 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 17:35:22 +00:00
Drew Jaynes
7cb8fc1b3b Multisite: Improve two error strings specifying allowed characters in usernames and site names. 
Also removes two error strings that were likely never being triggered anyway due to the stricter character matching higher up.

Props atomicjack, bjornjohansen, DrewAPicture.
Fixes #33336.


git-svn-id: https://develop.svn.wordpress.org/trunk@35142 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 17:32:17 +00:00
Scott Taylor
16b02b6768 KSES: have you ever heard of the <bdo> HTML tag? Same. http://www.w3schools.com/tags/tag_bdo.asp 
Adds unit test.

Props iandunn.
Fixes #34063.


git-svn-id: https://develop.svn.wordpress.org/trunk@35141 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 17:17:13 +00:00
Scott Taylor
55a42e8afa Taxonomy: in wp_list_categories(), add an arg: separator, to allow the overriding of <br/>. 
Props wojtek.szkutnik.
Fixes #9025.


git-svn-id: https://develop.svn.wordpress.org/trunk@35140 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 17:01:10 +00:00
Scott Taylor
d929461fd8 Taxonomy: get_terms_to_edit() can also return false or WP_Error. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations. 
Props valendesigns.
Fixes #30472.


git-svn-id: https://develop.svn.wordpress.org/trunk@35139 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 16:39:47 +00:00
Drew Jaynes
0a8b41c950 Users: Restore changes from [35114] accidentally reverted in [35135]. 
See #28631.


git-svn-id: https://develop.svn.wordpress.org/trunk@35138 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 15:44:14 +00:00
Drew Jaynes
5e37130fcd Docs: Add a changelog entry mentioning that the number argument now supports -1 (all). 
Also fixes the argument description.

-1 support was added in [35114].

See #28631.


git-svn-id: https://develop.svn.wordpress.org/trunk@35135 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 15:15:30 +00:00
Scott Taylor
eb85b2c11b Theme Editor: add a filter, wp_theme_editor_filetypes, to allow more filetypes to be edited via the Theme Editor. Usage of the Theme Editor is strenuously discouraged, but we should allow you to add whatever filetypes (.less, .scss) you would like. 
Props MikeHansenMe, pross.
Fixes #22924.


git-svn-id: https://develop.svn.wordpress.org/trunk@35134 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 14:13:12 +00:00
Scott Taylor
b9e34ce4a2 Theme Installer: fix the theme "Install"/"Installed" button's vertical alignment for HiDPI displays. 
Props paulwilde.
Fixes #34198.


git-svn-id: https://develop.svn.wordpress.org/trunk@35133 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 13:51:45 +00:00
Sergey Biryukov
c5c5bd31dd Toolbar: Improve padding of toolbar submenu items on small screens. 
Props tillkruess.
Fixes #28608.

git-svn-id: https://develop.svn.wordpress.org/trunk@35132 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 07:39:54 +00:00
Sergey Biryukov
b8530e502a Accessibility: Add back-compat styles for plugins that still use h2 as a main heading in their screens. 
Props afercia.
Fixes #33559.

git-svn-id: https://develop.svn.wordpress.org/trunk@35131 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 07:16:43 +00:00
Sergey Biryukov
59af284f25 Accessibility: Correct the style for Popular Tags header on Edit Tags screen after [33917]. 
Props afercia.
See #33559. See #33658.

git-svn-id: https://develop.svn.wordpress.org/trunk@35130 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 07:13:33 +00:00
Sergey Biryukov
4240fe532c Acessibility: "Add New Category" links on Edit Post screen should not be a header. 
Props afercia.
Fixes #33557.

git-svn-id: https://develop.svn.wordpress.org/trunk@35129 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 06:59:34 +00:00
Sergey Biryukov
70a4da6f04 Accessibility: bump headings one level up in post meta boxes for a better headings hierarchy. 
Props afercia, joedolson, wonderboymusic.
See #33557.

git-svn-id: https://develop.svn.wordpress.org/trunk@35128 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 06:56:48 +00:00
Sergey Biryukov
b71dfae98c Add the CSS changes missed in [35126]. 
Props afercia.
See #34263.

git-svn-id: https://develop.svn.wordpress.org/trunk@35127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 06:50:29 +00:00
Sergey Biryukov
4a5585e09d Accessibility: bump headings one level up on Credits screen for a better headings hierarchy. 
Props afercia.
Fixes #34263.

git-svn-id: https://develop.svn.wordpress.org/trunk@35126 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 06:49:00 +00:00
Scott Taylor
da6e194d93 Admin Bar: fix the alignment of secondary menu item arrows. 
Props juhise.
Fixes #33836.


git-svn-id: https://develop.svn.wordpress.org/trunk@35125 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 03:53:16 +00:00
Scott Taylor
a6a0045460 Fotmatting: in sanitize_file_name(), escape % when uploads contain them, otherwise attachment URLs will unescape the char and break. 
Adds unit tests.

Props mordauk, simonwheatley, dd32, solarissmoke.
Fixes #16226.


git-svn-id: https://develop.svn.wordpress.org/trunk@35122 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 03:21:13 +00:00
Sergey Biryukov
0f2f946736 Feeds: Remove a confusing comment from add_feed(), added in [3638]. 
It always overrides the default callback if it's set, regardless of the `in_array()` check.

See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35121 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 03:13:31 +00:00
Boone Gorges
0d28b59c0b Use a more reliable method for generating get_terms() cache key. 
Previously, the cache key included a serialization of `list_terms_exclusions`
callbacks, to ensure that the cache was differentiated properly for different
uses of the `list_terms_exclusions` filter. This strategy was flawed in a
couple of ways: serialization doesn't work equally well for all callable types;
the serialization required reaching into the `$wp_filter` global; serializing
the callback itself didn't properly account for the possibility that the
callback might return different values in different contexts; the cache key
didn't account for other filters that similarly affect the cached values, such
as `terms_clauses`.

We skirt all these issues by concatenating the cache key using the SQL query
string, which will reflect all filters applied earlier in `get_terms()`.

Props boonebgorges, wonderboymusic.
Fixes #21267.

git-svn-id: https://develop.svn.wordpress.org/trunk@35120 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 03:06:27 +00:00
SergeyBiryukov
d5e0f87530 Docs: Describe the $feedname argument of add_feed(). 
Fixes #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35119 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 03:00:03 +00:00
Sergey Biryukov
77e2cd9e18 Feeds: Pass the second parameter of "do_feed_{$feed}" action, feed name, to callbacks added via add_feed(). 
The `$feed` parameter was added in [35115].

Props slimndap.
See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35118 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:58:21 +00:00
Boone Gorges
f9094e546a In get_terms(), don't store WP_Term objects in cache. 
Fixes #34282.

git-svn-id: https://develop.svn.wordpress.org/trunk@35117 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:57:21 +00:00
Scott Taylor
34cb01e2f1 Users: when passing a WP_User instance to wp_update_user(), ensure that the user password is not accidentally double-hashed. This is terrifying. 
Adds unit tests.

Props tbcorr, salcode.
Fixes #28435.


git-svn-id: https://develop.svn.wordpress.org/trunk@35116 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:47:09 +00:00
Sergey Biryukov
4a2184d00c Feeds: Pass the feed name to do_feed_{$feed} action. 
Props johnbillion.
See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35115 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:43:30 +00:00
Scott Taylor
4c0b89553a Users: allow -1 (no limit, use with extreme caution on large sites) as the value for number in WP_User_Query - similar to posts_per_page => -1 in WP_Query. 
Adds unit tests.

Props mordauk, jesin, nofearinc.
Fixes #28631.


git-svn-id: https://develop.svn.wordpress.org/trunk@35114 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:39:05 +00:00
Boone Gorges
ae96d16ed9 Remove dead code from WP_Query::lazyload_term_meta(). 
git-svn-id: https://develop.svn.wordpress.org/trunk@35111 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:35:30 +00:00
Sergey Biryukov
d884c65485 Remove obsolete code from `WP_Users_List_Table::get_sortable_columns(). 
Sorting by post count was disabled in [17024].

Props jdgrimes.
See #15861.

git-svn-id: https://develop.svn.wordpress.org/trunk@35110 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:24:12 +00:00
Sergey Biryukov
e654f82ce5 Replace get_bloginfo( 'wpurl' ) with admin_url() for plugin activation error message. 
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
Fixes #34280.

git-svn-id: https://develop.svn.wordpress.org/trunk@35109 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:11:30 +00:00
Sergey Biryukov
a326105ade Replace get_bloginfo( 'wpurl' ) with admin_url() in plugin editor. 
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
See #34280.

git-svn-id: https://develop.svn.wordpress.org/trunk@35107 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:04:14 +00:00
Scott Taylor
65c8adc252 Widgets: When using the_widget(), the $before_widget argument only receives the widget class if using the default sidebar arguments. Run sprintf after parsing the args to fix this. 
Adds unit test.

Props coffee2code.
Fixes #19450.


git-svn-id: https://develop.svn.wordpress.org/trunk@35106 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:48:41 +00:00
Sergey Biryukov
c0c0305749 Replace get_bloginfo( 'wpurl' ) with site_url() in rsd_link(). 
Ensure the correct scheme is used for the `application/rsd+xml` link URL.

Props johnbillion.
See #34280.

git-svn-id: https://develop.svn.wordpress.org/trunk@35105 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:48:32 +00:00
Drew Jaynes
72c81e01d4 Widgets: Rename the $name parameter in is_registered_sidebar() to $sidebar_id and adjust the accepted types to string|int as sidebar IDs can be numeric. 
See #24878.


git-svn-id: https://develop.svn.wordpress.org/trunk@35104 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:44:44 +00:00
Scott Taylor
b272dc68b9 Widgets: add a default filter for widget_text (used by the Text widget), balanceTags, which respects the option for use_balanceTags. 
Props MikeHansenMe.
Fixes #23083.


git-svn-id: https://develop.svn.wordpress.org/trunk@35103 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:39:43 +00:00
Scott Taylor
3616fe5939 Widgets: add a function, is_registered_sidebar() - helps us avoid touching the $wp_registered_sidebars global. 
Props GaryJ, wonderboymusic.
Fixes #24878.


git-svn-id: https://develop.svn.wordpress.org/trunk@35102 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:32:27 +00:00
Boone Gorges
9f551a4630 Don't match partial roles in WP_User_Query. 
Because 'role=ocean90' shouldn't match 'role=bocean901'.

Props bocean901, ocean90.
Fixes #22212.

git-svn-id: https://develop.svn.wordpress.org/trunk@35101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:31:53 +00:00
Scott Taylor
d936110f7c Widgets: when getting settings, and none exist, set them to empty to avoid extraneous database queries on subsequent requests. 
Adds unit tests.

Props kovshenin, MikeHansenMe, dlh.
Fixes #26876.


git-svn-id: https://develop.svn.wordpress.org/trunk@35100 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:12:12 +00:00
Scott Taylor
32b604de00 Color Picker: when opening and closing, toggle a wp-picker-active class on the wrapper. 
Props norcross.
Fixes #29471.


git-svn-id: https://develop.svn.wordpress.org/trunk@35099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:07:21 +00:00
Drew Jaynes
681d100fd6 Feeds: Simplify logic for checking if the do_feed_{$feed} action is hooked to any callbacks. 
See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra `$hook` variable moot.

See #34264.


git-svn-id: https://develop.svn.wordpress.org/trunk@35098 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:06:26 +00:00
Drew Jaynes
1246590769 Feeds: Adjust the do_feed_{$feed} hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that. 
Props johnbillion.
Fixes #34264.


git-svn-id: https://develop.svn.wordpress.org/trunk@35097 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:02:47 +00:00
Sergey Biryukov
6aa28b5bd3 Format the number of comments in wp-includes/embed-template.php for the locale. 
Props johnbillion.
Fixes #34276.

git-svn-id: https://develop.svn.wordpress.org/trunk@35096 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:01:53 +00:00
Scott Taylor
380d27331e XML-RPC: Add a filter, xmlrpc_memory_limit, to allow the value of $xmlrpc_memory_limit to be increased. 
Props ankit.gade.
Fixes #29957.


git-svn-id: https://develop.svn.wordpress.org/trunk@35095 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:00:04 +00:00
Drew Jaynes
44a4978535 Plugins: Introduce the delete_plugin transactional hook, which fires immediately after a plugin deletion attempt occurs. 
Props Veraxus for the initial patch.
Fixes #26904.


git-svn-id: https://develop.svn.wordpress.org/trunk@35094 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 00:56:32 +00:00
Drew Jaynes
3f756da63a Login: Pass the username and WP_User object to the retrieve_password_title filter. 
Adding these parameters creates parity with the `retrieve_password_message` filter, used for modifying the message body of the same password reset email.

Props sudar.
Fixes #34252.


git-svn-id: https://develop.svn.wordpress.org/trunk@35093 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 00:50:28 +00:00
Sergey Biryukov
34a716709c In number_format_i18n(), check if $wp_locale is set before using it. 
Props pauldewouters.
Fixes #31553.

git-svn-id: https://develop.svn.wordpress.org/trunk@35092 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 00:29:18 +00:00
John Blackbourn
91583fe499 Add missing @since params and update the docs for site_icon_url() and has_site_icon(). 
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 23:27:18 +00:00
John Blackbourn
d32c6cfbc9 Remove another unnecessary function_exists() call. 
See [35087]
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35089 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 23:19:43 +00:00
Drew Jaynes
33d083e263 Version bump. 
git-svn-id: https://develop.svn.wordpress.org/trunk@35088 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:58:22 +00:00
John Blackbourn
4d8c6f6e08 Remove an unnecessary function_exists() call which was included in the oEmbed feature plugin for compatibility with WordPress < 4.3. 
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35087 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:53:28 +00:00
John Blackbourn
2eaae4739b Correct two escaping functions used in wp-includes/embed-template.php. 
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35086 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:51:32 +00:00
John Blackbourn
da6090d9f7 Add missing @since docs for the filters in wp-includes/embed-template.php 
See #32522, #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35085 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:50:34 +00:00
John Blackbourn
d04e6dc919 Correct the @since doc for WP_Query::is_embed(). 
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35084 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:12:42 +00:00
Scott Taylor
743d22415f oEmbed: add fallback icons (not used yet) for older browsers. 
Props melchoyce.
See #34204.


git-svn-id: https://develop.svn.wordpress.org/trunk@35083 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 21:16:10 +00:00
John Blackbourn
f5d2e0dd61 Add $transient as a parameter to the set_transient_{transient} action. 
Props SergeyBiryukov
Fixes #34269


git-svn-id: https://develop.svn.wordpress.org/trunk@35082 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 21:01:24 +00:00
Scott Taylor
e05891a7ec Media: avoid "divide by zero" in wp_get_attachment_image_srcset_array(). 
Fixes #34238.


git-svn-id: https://develop.svn.wordpress.org/trunk@35081 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 20:59:12 +00:00
Drew Jaynes
6e6d9f9830 Docs: Specify the default image size in the $size parameter description for the image_send_to_editor hook. 
See #34257. See #32246. See [35058].


git-svn-id: https://develop.svn.wordpress.org/trunk@35080 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:17:19 +00:00
Drew Jaynes
dd7b3a62fd Docs: Normalize spacing in the DocBlock for get_image_send_to_editor() following [35056]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35079 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:15:16 +00:00
Drew Jaynes
6ca6c6fc1c Docs: The $size parameter for the get_image_tag hook also accepts an array. 
See #34257. See [35038].


git-svn-id: https://develop.svn.wordpress.org/trunk@35078 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:10:59 +00:00
Drew Jaynes
03481541aa Docs: The $size parameter for the get_image_tag_class hook also accepts an array. 
See #34257. See [35037].


git-svn-id: https://develop.svn.wordpress.org/trunk@35077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:08:39 +00:00
Drew Jaynes
2f5be3afcf Docs: Adjust documentation for the $size parameter in the_post_thumbnail_url() to clarify the required order of width and height values when passing an array. 
Fixes #34257. Whew!


git-svn-id: https://develop.svn.wordpress.org/trunk@35076 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:59:48 +00:00
Drew Jaynes
663d71de0d Docs: The post_thumbnail_size hook can also accept an array (already supported). 
See #34257. See [35069].


git-svn-id: https://develop.svn.wordpress.org/trunk@35075 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:56:54 +00:00
Drew Jaynes
38141969f2 Docs: The $size parameters in the begin_fetch_post_thumbnail_html and end_fetch_post_thumbnail_html hooks can also accept an array (already supported). 
See #34257. See #32246. See [35070] and [35071].


git-svn-id: https://develop.svn.wordpress.org/trunk@35074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:55:08 +00:00
Drew Jaynes
581723a924 Docs: Normalize spacing in the post_thumbnail_html hook doc following [35072]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35073 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:52:15 +00:00
Drew Jaynes
a92ba46df9 Docs: Adjust documentation for the $size parameter in the post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35072 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:51:15 +00:00
Drew Jaynes
ecf49d9f10 Docs: Adjust documentation for the $size parameter in the end_fetch_post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35071 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:49:14 +00:00
Drew Jaynes
73cfcece73 Docs: Adjust documentation for the $size parameter in the begin_fetch_post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:48:26 +00:00
Drew Jaynes
e918b66538 Docs: Adjust documentation for the $size parameter in the post_thumbnail_size hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35069 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:47:22 +00:00
Drew Jaynes
debd363cd7 Docs: Adjust documentation for the $size parameter in get_the_post_thumbnail() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35068 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:46:15 +00:00
Drew Jaynes
5f5bcfb15a Docs: Adjust documentation for the $size parameter in the_post_thumbnail() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35067 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:45:18 +00:00
Drew Jaynes
b0093711e4 Docs: Normalize spacing in the wp_get_attachment_link hook doc following [35065]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35066 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:43:19 +00:00
Drew Jaynes
e73fbb948c Docs: Adjust documentation for the $size parameter in the wp_get_attachment_link hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35065 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:41:54 +00:00
Drew Jaynes
6e4fdc4cbf Docs: Improve documentation for get_site_icon_url(), introduced in [32994]. 
Adds a missing `@since` version, fixes optional parameter syntax, adds default values, and fixes the return description.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35064 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:37:13 +00:00
Drew Jaynes
6cfda71af7 Docs: Re-clarify the $sizes[ $size ] section of the hash notations for WP_Image_Editor_GD::multi_resize() and WP_Image_Editor_Imagick::multi_resize() as not fully-optional. 
The `$width` value is optional if `$height` is specified, and vice versa. The `$crop` value is always optional and defaults to false.

Props dh-shredder.
See #32246. See [35061] and [35062].


git-svn-id: https://develop.svn.wordpress.org/trunk@35063 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:33:30 +00:00
Drew Jaynes
f66e753d46 Docs: Fix hash notation syntax for the $sizes[ $size ] section in the DocBlock for WP_Image_Editor_Imagick::multi_resize(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35062 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:26:22 +00:00
Drew Jaynes
9575f53d50 Docs: Fix hash notation syntax for the $sizes[ $size ] section in the DocBlock for WP_Image_Editor_GD::multi_resize(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35061 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:25:24 +00:00
Drew Jaynes
8749c5fa18 Docs: Adjust documentation for the $size parameter in the admin_post_thumbnail_size hook doc to clarify the required order of width and height values when an array is passed. 
See #34257. See #28512.


git-svn-id: https://develop.svn.wordpress.org/trunk@35060 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:21:57 +00:00
Drew Jaynes
6db985862a Docs: Normalize spacing in the image_send_to_editor hook doc following [35058]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35059 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:18:32 +00:00
Drew Jaynes
59db8cfe93 Docs: Adjust documentation for the $size parameter in the image_send_to_editor hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35058 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:16:35 +00:00
Drew Jaynes
f948ce0902 Docs: Fix the syntax for marking parameters optional and add defaults in the DocBlock for wp_get_attachment_link(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35057 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:14:03 +00:00
Drew Jaynes
25c0710f4c Docs: Fix syntax and properly mark optional parameters as such in the DocBlock for get_image_send_to_editor(). 
Also fixes the return description, and adds the `$size` default value, missed in [35055].

See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35056 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:10:44 +00:00
Drew Jaynes
4d967258f2 Docs: Adjust documentation for the $size parameter in get_image_send_to_editor() to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35055 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:07:25 +00:00
Drew Jaynes
0cf4a5e121 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in image_make_intermediate_size(). 
Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35054 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:05:30 +00:00
Drew Jaynes
6eb8c85678 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in image_resize_dimensions(). 
Also similarly adjusts the `$crop` parameter description in the corresponding `image_resize_dimensions` hook doc.

Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35053 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:01:10 +00:00
Drew Jaynes
4d2fa13bf5 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in set_post_thumbnail_size(). 
Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35052 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:59:11 +00:00
Drew Jaynes
1165053220 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in add_image_size(). 
Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35051 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:58:13 +00:00
Drew Jaynes
9a3fcf9fee Docs: Adjust documentation for the $size parameter in wp_get_attachment_link() to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the parameter documentation (already supported).

Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35050 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:55:12 +00:00
Drew Jaynes
ac9254faf8 Docs: Adjust documentation for the $size parameter in adjacent_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35049 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:52:30 +00:00
Drew Jaynes
e1d1e7a4af Docs: Adjust documentation for the $size parameter in next_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35048 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:49:52 +00:00
Drew Jaynes
0cebe5df94 Docs: Adjust documentation for the $size parameter in previous_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35047 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:47:50 +00:00
Drew Jaynes
da8c9d6c7e Docs: Normalize spacing in the $attr hash notation for gallery_shortcode() following [35045]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35046 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:45:23 +00:00
Drew Jaynes
447cdf9fc1 Docs: Adjust documentation for the $size argument in gallery_shortcode to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the argument documentation.

Props jaspermdegroot.
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35045 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:42:22 +00:00
Drew Jaynes
aeb289ca5f Docs: Adjust documentation for the $size parameter in wp_get_attachment_image_url() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35044 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:38:55 +00:00
Drew Jaynes
0d954c2c0b Docs: Adjust documentation for the $size parameter in the wp_get_attachment_image_attributes hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:37:17 +00:00
Drew Jaynes
4781b9d5d3 Docs: Adjust documentation for the $size parameter in wp_get_attachment_image() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35042 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:35:17 +00:00
Drew Jaynes
479532865d Docs: Adjust documentation for the $size parameter in the wp_get_attachment_image_src hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35041 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:33:48 +00:00
Drew Jaynes
43c2e54456 Docs: Adjust documentation for the $size parameter in wp_get_attachment_image_src() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35040 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:30:24 +00:00
Drew Jaynes
cc1bcb6add Docs: Adjust documentation for the $size parameter in image_get_intermediate_size() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35039 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:28:45 +00:00
Drew Jaynes
bb5c3bff20 Docs: Adjust documentation for the $size parameter in the get_image_tag hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35038 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:26:44 +00:00
Drew Jaynes
3fc7fea5f8 Docs: Adjust documentation for the $size parameter in the get_image_tag_class hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:25:41 +00:00
Drew Jaynes
ac370db0cb Docs: Adjust documentation for the $size parameter in get_image_tag() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35036 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:20:55 +00:00
Drew Jaynes
eae2d93f08 Docs: Adjust documentation for the $size parameter in the image_downside hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35035 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:19:13 +00:00
Drew Jaynes
259077deb5 Docs: Adjust documentation for the $size parameter in image_downsize() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35034 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:17:21 +00:00
Drew Jaynes
bdfb256110 Docs: Adjust documentation for the $size parameter in image_constrain_size_for_editor() to clarify the required order of width and height values when passing an array. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35033 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:15:07 +00:00
Boone Gorges
ed4eee668e Don't cache WP_Term objects in wp_get_object_cache(). 
The data stored in the cache should be raw database query results, not
`WP_Term` objects (which may be modified by plugins, and may contain additional
properties that shouldn't be cached).

If term relationships caches were handled in `wp_get_object_terms()` - where
a database query takes place - it would be straightforward to cache raw data.
See #34239. Since, in fact, `get_the_terms()` caches the value it gets from
`wp_get_object_terms()`, we need a technique that allows us to get raw data
from a `WP_Term` object. Mirroring `WP_User`, we introduce a `data` property
on term objects, which `get_the_terms()` uses to fetch cacheable term info.

Fixes #34262.

git-svn-id: https://develop.svn.wordpress.org/trunk@35032 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:12:29 +00:00
Boone Gorges
be5065a3ad Be stricter about sanitizing values coming out of WP_Term. 
Data passed into `get_instance()` should be run through `sanitize_term()`
before being used.

See #34262.

git-svn-id: https://develop.svn.wordpress.org/trunk@35031 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 15:12:22 +00:00
Boone Gorges
d632e2c4c1 After [35028], normalize get_term_field() doc formatting. 
Fixes #34245.

git-svn-id: https://develop.svn.wordpress.org/trunk@35029 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 04:13:31 +00:00
Boone Gorges
8847a58443 Don't require a $taxonomy to be specified in get_term_field(). 
After [34997], the `$taxonomy` parameter of `get_term()` is optional. This
changeset brings `get_term_field()` in line with the new usage.

Adds unit tests for `get_term_field()`.

Props DrewAPicture.
See #34245.

git-svn-id: https://develop.svn.wordpress.org/trunk@35028 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 04:13:25 +00:00
Drew Jaynes
ff65d77908 Docs: Wrap a couple of hook name references in inline @see tags in the hook docs for custom_menu_order and menu_order. 
Inline `@see` tags in the context of hooks are parsed as links to hook pages in the Code Reference.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35027 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 03:38:11 +00:00
Jeremy Felt
c8019610c8 MS: Reflect falsy values for upload_space_check_disabled in UI. 
If the network option for `upload_space_check_disabled` is missing or an empty string, we should reflect how it will be treated elsewhere in the UI.

Props stephenharris.
Fixes #33986.


git-svn-id: https://develop.svn.wordpress.org/trunk@35026 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 00:00:28 +00:00
Jeremy Felt
3ee40d6652 MS: Reject truthy, non-numeric network ids in _network_option(). 
A valid `$network_id` or `null`/`false` is expected as the first parameter for `_network_option()`. If something other than that is passed, we immediately return `false` rather than attempting to guess what network was intended.

See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@35025 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-11 23:29:55 +00:00
Jeremy Felt
55122c1538 MS: Adjust _network_option() parameter order, $network_id is first. 
This better aligns with expectations and matches the structure used by `_blog_option()`. The `_site_option()` functions remain as an appropriate method for working with the current network.

See #28290.


git-svn-id: https://develop.svn.wordpress.org/trunk@35024 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-11 22:43:59 +00:00
Drew Jaynes
16f56f4114 Media: Remove logic for unnecessarily overloading the $content_width global when passing default dimensions used to display the post thumbnail image in the 'Featured Image' meta box. 
Updates documentation for the `$size` parameter in `admin_post_thumbnail_size` filter doc.

See #28512.


git-svn-id: https://develop.svn.wordpress.org/trunk@35023 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-11 17:09:33 +00:00
Drew Jaynes
4d98b99cc3 Media: Introduce the admin_post_thumbnail_size filter, which enables manipulation of the image size used to display the post thumbnail in the 'Featured Image' meta box. 
This filter has no effect on the image size used to display post thumbnails on the front-end.

Props dboulet, DrewAPicture.
Fixes #28512.


git-svn-id: https://develop.svn.wordpress.org/trunk@35022 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-11 16:53:35 +00:00
Drew Jaynes
bf0fa3a570 Docs: Fix some syntactical issues in property DocBlocks for WP_List_Table. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35021 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-11 03:33:50 +00:00
Andrew Ozz
9d8c320a38 Fix inconsistency in src/wp-includes/js/media/views/uploader/editor.js. 
See #34251.


git-svn-id: https://develop.svn.wordpress.org/trunk@35020 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-11 00:08:48 +00:00
Andrew Ozz
0d6ea366c5 Plupload: update to 2.1.8. Changelog: https://github.com/moxiecode/plupload/releases. 
Hide the editor uploader overlay on all drop events in the window, not only when dropping on the editor uploader element.


Fixes #34251, #22403.

git-svn-id: https://develop.svn.wordpress.org/trunk@35019 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 23:49:44 +00:00
Sergey Biryukov
ddec8a1c2b Customizer: WP_Customize_Cropped_Image_Control should extend WP_Customize_Image_Control, since Site Icon can only an image. 
Props paulwilde.
Fixes #34250.

git-svn-id: https://develop.svn.wordpress.org/trunk@35018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 23:24:46 +00:00
Jeremy Felt
d5e572f992 MS: Handle the possibility of 0 when checking a user's upload quota. 
Upload space of 0 is now more possible via r35016 and should be respected rather than modified to a default of 10MB.

Fixes #34037.


git-svn-id: https://develop.svn.wordpress.org/trunk@35017 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 23:17:01 +00:00
Jeremy Felt
d9edf86faf MS: Allow for a blog_upload_space setting of 0 to restrict uploads. 
Previously, an value matching `empty()` would have been bypassed in favor of the default setting for 100MB.

Related #19538, r19639, r19652, where we saw the bug, fixed the bug, and then unfixed the bug so that it was not a surprise in a point release.

See #34037.


git-svn-id: https://develop.svn.wordpress.org/trunk@35016 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 23:14:11 +00:00
Andrea Fercia
52c2492afb Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy. 
Props mrahmadawais, afercia.
Fixes #33659.

git-svn-id: https://develop.svn.wordpress.org/trunk@35015 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 16:33:33 +00:00
Scott Taylor
5e85a8b55a Admin JS: after [34977], avoid variable names conflicts with e. 
Props afercia.
Fixes #18590.


git-svn-id: https://develop.svn.wordpress.org/trunk@35014 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 15:49:56 +00:00
Scott Taylor
c123726ba0 Docs: some @global object vernaculars should be converted to the actual object type. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@35013 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 15:44:16 +00:00
Scott Taylor
5200642cc5 Users List Table: after [35011], just use wp_roles(), no global import. #winning 
See #22959.


git-svn-id: https://develop.svn.wordpress.org/trunk@35012 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 15:35:26 +00:00
Scott Taylor
aa9b423cf4 Users List Table: after [34963], remove unused code/add doc for global import. 
See #22959.


git-svn-id: https://develop.svn.wordpress.org/trunk@35011 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 15:25:08 +00:00
Scott Taylor
b98303ae58 WP Screen: after [34991], avoid unnecessary nesting levels and remove unused global import. 
See #33646.


git-svn-id: https://develop.svn.wordpress.org/trunk@35010 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 15:19:54 +00:00
Andrea Fercia
e69aca18dc Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy. 
Fixes #33818.

git-svn-id: https://develop.svn.wordpress.org/trunk@35009 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 15:16:04 +00:00
Sergey Biryukov
437bbeead5 Users: Remove redundant error message when password is only entered once. 
"Please enter the same password in both password fields" should cover all the scenarios.

Props MikeHansenMe, jmayhak, desrosj, gounder.
Fixes #33101.

git-svn-id: https://develop.svn.wordpress.org/trunk@35008 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 13:21:30 +00:00
Weston Ruter
e158ff27de Customizer: Fix scalability performance problem for previewing multidimensional settings. 
As the number of multidimensional settings (serialized options and theme mods) increase for a given ID base (e.g. a widget of a certain type), the number of calls to the `multidimensional` methods on `WP_Customize_Setting` increase exponentially, and the time for the preview to refresh grows in time exponentially as well.

To improve performance, this change reduces the number of filters needed to preview the settings off of a multidimensional root from N to 1. This improves performance from `O(n^2)` to `O(n)`, but the linear increase is so low that the performance is essentially `O(1)` in comparison. This is achieved by introducing the concept of an "aggregated multidimensional" setting, where the root value of the multidimensional serialized setting value gets cached in a static array variable shared across all settings.

Also improves performance by only adding preview filters if there is actually a need to do so: there is no need to add a filter if there is an initial value and if there is no posted value for a given setting (if it is not dirty).

Fixes #32103.


git-svn-id: https://develop.svn.wordpress.org/trunk@35007 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 09:05:04 +00:00
Sergey Biryukov
975c16f4b2 Use wp_star_rating() on Add Themes screen: 
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible

Fixes #34080.

git-svn-id: https://develop.svn.wordpress.org/trunk@35006 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 06:50:35 +00:00
Sergey Biryukov
9487469f80 Add echo parameter for wp_star_rating(). 
See #34080.

git-svn-id: https://develop.svn.wordpress.org/trunk@35005 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 06:42:19 +00:00
Drew Jaynes
aacde02ed4 Docs: Fix some minor formatting in the $query_args parameter description for the `` filter doc. 
See #8243. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35004 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 06:38:24 +00:00
Drew Jaynes
a521a4e7f6 Dashboard: Introduce the dashboard_recent_drafts_query_args filter, making it possible to manipulate the post query arguments used in the 'Recent Drafts' dashboard widget. 
Props iamfriendly.
Fixes #8243.


git-svn-id: https://develop.svn.wordpress.org/trunk@35003 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 06:32:51 +00:00
Drew Jaynes
48ceecafc7 Template: Pass the $post parameter to the the_permalink filter. 
Props chriscct7.
Fixes #34234. See #23882.


git-svn-id: https://develop.svn.wordpress.org/trunk@35002 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 05:45:27 +00:00
Drew Jaynes
ed4b0aee3f Template: Rename the $id parameters in the_permalink(), get_the_permalink(), and get_permalink() to $post. 
In all three cases, the functions can accept a post ID, a `WP_Post` object, or a falsey value, which defaults to the value of the global `$post`. Switching to `$post` in this context allows the parameters to better self-document and removes ambiguity in the code they are subsequently used in.

Props chriscct7 for the initial patch.
See #34234.


git-svn-id: https://develop.svn.wordpress.org/trunk@35001 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 05:40:14 +00:00
Sergey Biryukov
fc9f0b229e Merge two database update strings for consistency. 
Props pavelevap.
Fixes #33514.

git-svn-id: https://develop.svn.wordpress.org/trunk@35000 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 05:13:57 +00:00
Boone Gorges
d6748bd2cb Return WP_Post objects from wp_get_object_terms(). 
A side effect of this change is that terms stored in the cache no longer have
an `object_id` associated with them. Previously, `object_id` had always been
cached when the term cache was populated via `wp_get_object_terms()`, a
strategy that was mostly harmless but still incorrect.

See #14162.

git-svn-id: https://develop.svn.wordpress.org/trunk@34999 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 03:38:41 +00:00
Boone Gorges
797ddb60ba Return WP_Term objects from get_terms(). 
Props boonebgorges, flixos90, DrewAPicture.
See #14162.

git-svn-id: https://develop.svn.wordpress.org/trunk@34998 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 02:12:40 +00:00
Boone Gorges
134a7af0fc Introduce WP_Term. 
`get_term()` now returns a `WP_Term` object, instead of a `stdClass` object.
Cache support and sanitization filters for individual terms are now more
centralized. For example, `get_term_by()` is able to cast results of its query
to a `WP_Term` object by passing it through `get_term()`.

The `$taxonomy` parameter for `get_term()` is now optional, as terms ought to
be unique to a taxonomy (ie, shared terms no longer exist). In cases where
`get_term()` detects that the term matching the specified term_id is from the
wrong taxonomy, it checks to see if you've requested a shared term, and if so,
it splits the term. This is used only for fallback purposes.

The elimination of shared terms allows the caching strategy for terms to be
simplified. Individual terms are now cached in a single 'terms' bucket.

Props flixos90, boonebgorges, scribu, dipesh.kakadiya.
See #14162.

git-svn-id: https://develop.svn.wordpress.org/trunk@34997 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 01:58:37 +00:00
Jeremy Felt
ecb75a16be MS: Show an error if a new site slug conflicts with an existing username. 
Props utkarshpatel, dipesh.kakadiya.
Fixes #33804.


git-svn-id: https://develop.svn.wordpress.org/trunk@34996 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-10 01:41:43 +00:00
Drew Jaynes
1758d36a88 Template: Make it possible to both ''add'' and ''remove'' items from the page templates list using the theme_page_templates filter. 
The `theme_page_templates` hook was originally added in [27297] as `page_templates`, and later renamed in [27470]. Previously, it was only possible to remove or rename page templates via this hook.

Fixes #13265. Fixes #25879.


git-svn-id: https://develop.svn.wordpress.org/trunk@34995 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 21:50:05 +00:00
Sergey Biryukov
b374a081a9 Remove stray closing tag in wp-admin/themes.php. 
Props tfrommen.
Fixes #34237.

git-svn-id: https://develop.svn.wordpress.org/trunk@34994 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 21:16:46 +00:00
Drew Jaynes
f26526264a Docs: Fix wrapping and syntax for a multi-comment in Walker_Comment::display_element(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34993 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 21:02:43 +00:00
Drew Jaynes
0d444dc6f9 Docs: Indent an example comment tree in the DocBlock for Walker_Comment::display_element() so it can be properly parsed in Markdown for the Code Reference. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34992 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 20:59:57 +00:00
Andrea Fercia
4b5f84295a Administration: Convert H5 usage in Screen Options to use fieldsets and legends. 
These H5 (heading level 5) don't allow for a good headings hierarchy and shouldn't be headings in the first place. Each group of options has now its own fieldset and legend.
In `render_screen_options()`, introduce two new "render" methods: `render_meta_boxes_preferences()` and `render_list_table_columns_preferences()` for consistency with already existing render methods and cleaner code.

Props joedolson, afercia.
Fixes #33646.

git-svn-id: https://develop.svn.wordpress.org/trunk@34991 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 18:04:18 +00:00
Helen Hou-Sandi
bb31c1ada8 Notices: Update one more instance of white-on-white. 
Because the media modal can be used on the front-end, the CSS needs to be added here rather than using the notice classes.

props paulwilde.
fixes #32244.


git-svn-id: https://develop.svn.wordpress.org/trunk@34990 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 17:46:24 +00:00
Boone Gorges
dc2b7c634d Ensure that WP_Date_Query accepts a value of 0 for 'hour'. 
Props jim912.
Fixes #34228.

git-svn-id: https://develop.svn.wordpress.org/trunk@34989 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 16:32:59 +00:00
Sergey Biryukov
eeea5d753a Fix typo in get_avatar() and get_avatar_data() docs. 
Props johnjamesjacoby.
Fixes #34232.

git-svn-id: https://develop.svn.wordpress.org/trunk@34988 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 15:51:37 +00:00
Drew Jaynes
ccfda7703c Install: Match existing tonal style in setup-config.php by converting strings containing 'do not' and 'does not' to instead use contractions. 
The 'do not' is converted to "don't" because "you" is third-person plural, and 'does not' is converted to "doesn't" because `localhost` is third-person singular. While both are "negative" contractions, we often write this way in WordPress to provide a friendlier tone. That's your English grammar lesson for the day.

Props ankit-k-gupta, iamfriendly.
Fixes #30317.


git-svn-id: https://develop.svn.wordpress.org/trunk@34987 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 15:42:33 +00:00
Sergey Biryukov
873dacf4a4 Fix typo in wp_rand() docs. 
See #28633.

git-svn-id: https://develop.svn.wordpress.org/trunk@34986 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 05:19:31 +00:00
Sergey Biryukov
724b83ab0e In do_robots(), allow crawling for admin-ajax.php, since it's often used on front-end. 
Props dmchale, joostdevalk.
Fixes #33156.

git-svn-id: https://develop.svn.wordpress.org/trunk@34985 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 05:15:01 +00:00
Sergey Biryukov
d58bcae1ad Media: Return early from media_sideload_image() if $file didn't match the pattern for images. 
Props MikeHansenMe, serpent7776.
Fixes #32755.

git-svn-id: https://develop.svn.wordpress.org/trunk@34984 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 04:46:00 +00:00
Sergey Biryukov
90f3849d62 Add $id parameter to the_permalink(), for consistency with get_permalink(). 
Props johnjamesjacoby, chriscct7.
Fixes #23882.

git-svn-id: https://develop.svn.wordpress.org/trunk@34982 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 04:33:16 +00:00
Dion Hulse
5700c3e060 Use PHP7's random_int() CSPRNG functionality in wp_rand() with a fallback to the random_compat library for PHP 5.x. 
`random_compat` offers a set of compatible functions for older versions of PHP, filling in the gap by using other PHP extensions when available.
We still include our existing `wp_rand()` functionality as a fallback for when no proper CSPRNG exists on the system.

Take Two, this was previously committed in [34922] but had an issue on PHP 5.2 which sarciszewski has now resolved.

Props sarciszewski
See #28633


git-svn-id: https://develop.svn.wordpress.org/trunk@34981 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 04:27:41 +00:00
Sergey Biryukov
fc966fd45d Dashboard: Display year in Activity widget if the post date year is not the same as the current one. 
Props GaryJ, chriscct7.
Fixes #26502.

git-svn-id: https://develop.svn.wordpress.org/trunk@34980 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 04:25:23 +00:00
Sergey Biryukov
b39b5b8758 My Sites: Make "Create a New Site" link consistent with other "Add New" links. 
Props JeffMatson.
Fixes #34179.

git-svn-id: https://develop.svn.wordpress.org/trunk@34979 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 03:49:24 +00:00
Sergey Biryukov
fb6d5f4aba After [34529], if a compatible termmeta table is found on database upgrade, convert it to utf8mb4 collation. 
Props dboulet.
Fixes #34224.

git-svn-id: https://develop.svn.wordpress.org/trunk@34978 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 02:06:15 +00:00
Andrew Ozz
5a55add794 JS: in event callbacks replace the very outdated return false with preventDefault(). 
Props adamsilverstein.
Fixes #18590.

git-svn-id: https://develop.svn.wordpress.org/trunk@34977 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 01:26:46 +00:00
Helen Hou-Sandi
c010db6ae4 Revisions: Update slider handle styling. 
This brings them in line with updated buttons as done in [34948] for #31459. It also gives it secondary action styling as opposed to primary, as restoring is considered the primary action.

props hugobaeta.
fixes #34220.


git-svn-id: https://develop.svn.wordpress.org/trunk@34976 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 00:24:36 +00:00
Drew Jaynes
654b633cb3 Docs: Add a missing @since version to the hook doc for the the_excerpt_embed filter, introduced in [34903]. 
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34975 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 23:24:28 +00:00
Drew Jaynes
85d0dfc45c Embeds: Rename the $return parameter in wp_filter_oembed_result() to $result to provide better context on what is being filtered. 
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34974 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 23:21:49 +00:00
John Blackbourn
8a7f8602b3 Remove HTML escaping for the plugin name and author fields that are displayed when deleting a plugin. 
While it might seem counter-intuitive to remove HTML escaping, these fields are already safe (they originate in `_get_plugin_data_markup_translate()` which handles sanitization and escaping), and the AuthorName field actually allows some HTML. This change prevents escaped HTML from appearing here.

Fixes #25422


git-svn-id: https://develop.svn.wordpress.org/trunk@34973 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 23:13:00 +00:00
Drew Jaynes
f2444857eb Embeds: Combine the oembed_minwidth and oembed_maxwidth filters into one, similar to how the existing oembed_defaults works for width and height. 
See #32522. See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34972 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 23:08:40 +00:00
Drew Jaynes
7c300ef221 Docs: Add missing @since versions for the oembed_minwidth and oembed_maxwidth filters, introduced in [34903]. 
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34971 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 22:54:14 +00:00
Drew Jaynes
2585c20b35 Docs: Adjust third-person singular verbs in DocBlock summaries for oEmbed functions introduced in [34903]. 
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34970 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 22:49:27 +00:00
Drew Jaynes
c959cb8b9b Embeds: Fix syntax on instantiating a new WP_oEmbed_Controller instance and cross-reference in the DocBlock for wp_oembed_parse_query(). 
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34969 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 22:39:52 +00:00
Drew Jaynes
bceea32c67 Docs: Adjust the summary for the oembed_discovery_links hook doc to mention that the filter is for HTML output. 
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34968 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 22:38:10 +00:00
Drew Jaynes
43431fd8b3 Docs: Clarify the file header summary for wp-includes/embed-functions.php, and add missing parameter information for wp_oembed_parse_query(), introduced in [34903]. 
See #34227.


git-svn-id: https://develop.svn.wordpress.org/trunk@34967 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 22:37:03 +00:00
Drew Jaynes
39ff95f883 Embeds: If we're adding a boatload of new items to default-filters.php, might as well make them readable. 
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34966 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 22:30:51 +00:00
John Blackbourn
bc043c51e8 Introduce the ability to filter the Users admin listing screen by users with no role, if such users exist. 
Fixes #22993
Props spmlucas, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@34965 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 22:06:46 +00:00
Drew Jaynes
6fe7598cff Docs: Add a couple of strategically-placed spaces in WP_Rewrite. 
Fixes #34218.


git-svn-id: https://develop.svn.wordpress.org/trunk@34964 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-08 22:06:42 +00:00