Commit Graph

1960 Commits

Author SHA1 Message Date
Sergey Biryukov
78391f6ebb I18N: Remove <em> tag from translatable string in wp-admin/includes/class-wp-ms-sites-list-table.php.
Props ramiy.
Fixes #35676.

git-svn-id: https://develop.svn.wordpress.org/trunk@36663 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 01:05:50 +00:00
Sergey Biryukov
45017abf02 Revisions: Clean up _wp_post_revision_fields():
* Move the array processing to a new function, `_wp_post_revision_data()`.
* Make both functions accept a post array or a `WP_Post` object. 
* Always apply the `_wp_post_revision_fields` filter and pass the post data to it.

Fixes #13382.

git-svn-id: https://develop.svn.wordpress.org/trunk@36659 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-24 00:43:31 +00:00
Dominik Schilling (ocean90)
960863e74c Schema: Add an index to wp_users.user_email.
Improves lookup of an email address on large user tables.

See #9568.
Fixes #33376.

git-svn-id: https://develop.svn.wordpress.org/trunk@36654 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-23 23:20:36 +00:00
Drew Jaynes
380e94f1ee Docs: Update the type for $callback parameters to callable in DocBlocks for add_settings_section() and add_settings_field().
Props aidanlane.
Fixes #35772.


git-svn-id: https://develop.svn.wordpress.org/trunk@36642 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-23 18:04:22 +00:00
Drew Jaynes
66ec958a5f Users: Pass the array of user IDs being deleted to the delete_user_form action hook in two places.
Also updates documentation for the first parameter, `$current_user`, to clarify that it holds the `WP_User` object for the _current_ user, not the one being deleted.

Props usermrpapa.
Fixes #35063. 


git-svn-id: https://develop.svn.wordpress.org/trunk@36640 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-23 17:41:15 +00:00
Andrea Fercia
bf528d321d Accessibility: Remove title attributes from the Plugin details modal.
Also, improves accessibility of the star rating reviews links.

Fixes #35111.

git-svn-id: https://develop.svn.wordpress.org/trunk@36618 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-22 23:17:21 +00:00
Andrea Fercia
f306793b2c Accessibility: Remove the revisions limit warning from the Publish box.
After [36053] don't show a warning about something users can't change
because there's no control exposed in the UI for that. The Revisions
screen is probably a better place to show a more complete information.

Fixes #35029.

git-svn-id: https://develop.svn.wordpress.org/trunk@36612 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-22 16:22:53 +00:00
Andrea Fercia
15a26902a6 Accessibility: Improve color contrast updating any #999 gray used for text or icons to a darker gray.
Fixes #35660.

git-svn-id: https://develop.svn.wordpress.org/trunk@36587 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-19 18:43:04 +00:00
Andrea Fercia
e4e9e19f4a Accessibility: after [36000] conditionally print out the aria-describedby attribute on the Featured Image postbox.
Fixes #35076.

git-svn-id: https://develop.svn.wordpress.org/trunk@36584 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-19 15:09:51 +00:00
Andrea Fercia
985e22828e Plugins: Remove an unused variable after [35953].
Fixes #35050.

git-svn-id: https://develop.svn.wordpress.org/trunk@36581 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-18 21:32:37 +00:00
Jeremy Felt
a16d97039b Remove extra spaces between function names and brackets
These were introduced when making list table view modes sticky.

See #16774, #34365.


git-svn-id: https://develop.svn.wordpress.org/trunk@36572 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-18 16:50:49 +00:00
Andrew Ozz
bb49a958d2 Replace wp_upload_dir() with the new wp_get_upload_dir() in all cases where a file is not being uploaded. Deprecate _wp_upload_dir_baseurl(), and replace it with wp_get_upload_dir().
See #34359.

git-svn-id: https://develop.svn.wordpress.org/trunk@36569 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-18 00:23:04 +00:00
Jeremy Felt
fafbd9fafd Multisite: Make view mode sticky for network users and sites list tables.
Fixes #34365.


git-svn-id: https://develop.svn.wordpress.org/trunk@36562 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 21:59:51 +00:00
Dominik Schilling (ocean90)
479596acda Plugins: Remove slashes from search terms and use urldecode() in non-URL contexts.
Fixes #35712.

git-svn-id: https://develop.svn.wordpress.org/trunk@36560 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 20:14:37 +00:00
Dominik Schilling (ocean90)
1d19617606 Updates: Prevent further actions if an update button is disabled.
Props adamsilverstein, afercia.
Fixes #35257.

git-svn-id: https://develop.svn.wordpress.org/trunk@36558 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 19:41:14 +00:00
Andrew Ozz
13a9d1a7e6 Do not strip slashes from the whole &_POST when doing autosaves.
Props joehoyle.
Fixes #35408.

git-svn-id: https://develop.svn.wordpress.org/trunk@36543 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-17 00:09:42 +00:00
Rachel Baker
0b761497c5 Comments: In the comments list table, only link rows inside the “Submitted On” column to the comment if it is publicly viewable.
The date within the comments list table “Submitted On” column will only be wrapped in `get_comment_link()` if the comment is approved and associated with a valid `comment_post_ID`.

Fixes #35279.

git-svn-id: https://develop.svn.wordpress.org/trunk@36521 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-12 21:42:03 +00:00
Dominik Schilling (ocean90)
c7e84936c8 Multisite: Don't show the database upgrade admin notice on the upgrade page itself.
Fixes #35782.

git-svn-id: https://develop.svn.wordpress.org/trunk@36505 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-09 14:29:06 +00:00
Dominik Schilling (ocean90)
92a9a57b63 Users: Display the new user email notice in user admin too.
Also, in `new_user_email_admin_notice()` use the global `$pagenow` and add a translators comment for the placeholder.

Fixes #35767.

git-svn-id: https://develop.svn.wordpress.org/trunk@36504 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-07 13:53:23 +00:00
Dominik Schilling (ocean90)
96b6828558 Users: Use self_admin_url() for the email change confirmation link.
Prevents sending users to wp-admin/profile.php if they only have access to wp-admin/user/profile.php.

Fixes #35766.

git-svn-id: https://develop.svn.wordpress.org/trunk@36503 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-07 13:25:44 +00:00
Boone Gorges
ef99ae21be Comments: Restore the ability to bypass post_id filter using 0 or '0'.
The changes introduced in [36381], while logical and clearly awesome, introduce
the potential for much breakage. Those who want to query for comments with a
null `comment_post_ID` should use `'post_in' => array( 0 )` instead.

Reverts [36381], [36387].
See #35090.


git-svn-id: https://develop.svn.wordpress.org/trunk@36480 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-05 18:49:46 +00:00
Drew Jaynes
9f52463206 Docs: Add more complete information to DocBlocks for private core functions _wp_dashboard_control_callback() and _wp_dashboard_recent_comments_row().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36474 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-03 20:19:31 +00:00
Drew Jaynes
5572e1d4f4 Docs: Add private access notation to the DocBlock for the core _wp_handle_upload() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36473 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-03 20:18:15 +00:00
Drew Jaynes
3aaf9506ce Docs: Mark two private functions as such in wp-admin/ajax-actions.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36472 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-03 20:16:42 +00:00
Dominik Schilling (ocean90)
62705eef00 Media: In wp_read_image_metadata() make sure that IPTC keywords are UTF8 encoded.
Prevents missing `_wp_attachment_metadata` when an image contains keywords with latin extended characters.

Fixes #35316.

git-svn-id: https://develop.svn.wordpress.org/trunk@36429 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-01 14:52:15 +00:00
Andrea Fercia
cde933e306 After [36171] remove all the occurrences of the old CSS clearfix.
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.

See #26396.

git-svn-id: https://develop.svn.wordpress.org/trunk@36422 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-30 13:45:37 +00:00
ericlewis
3fde994152 Networks and sites: Replace "blog" usage with "site" in docs.
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.

See #35417.


git-svn-id: https://develop.svn.wordpress.org/trunk@36416 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-28 03:34:02 +00:00
Eric Andrew Lewis
63afb0dcc8 Plugins: Clarify that mu-plugins can't be "active" in docs.
Plugins installed in the plugins/ folder can be activated by users. This puts the plugin in an "active" state. Plugins in the mu-folder/ are "must-use" plugins that are always loaded. They can't be activated, and thereby can't be "active." Because of this, using the `is_plugin_active()` or `is_plugin_active_for_network()` returns false when checking for these plugins. This clarifies that behavior in the functions' docs.


git-svn-id: https://develop.svn.wordpress.org/trunk@36397 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-26 00:31:08 +00:00
Konstantin Obenland
ddfbfce2e6 Pass data consistently on plugin, network plugin, and network theme screens.
List tables on these three screens look similar but come with unexpected caveats.
The network themes screen in particular has been neglected, using a `.plugin`
class to inherit its sibling's styles and not providing classes and data
attributes that the other two offer. This will provide some more consistency.

Fixes #35335.



git-svn-id: https://develop.svn.wordpress.org/trunk@36394 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-25 22:54:52 +00:00
Boone Gorges
e1b5d2d2bf In comments list table, $post_id should default to false rather than 0.
After [36381], the default value of `0` was causing the list table at
edit-comments.php to be empty. `false` prevents this.

This fix is likely temporary, while more research is done into the backward
compatibility concerns tied to [36381].

See #35090.

git-svn-id: https://develop.svn.wordpress.org/trunk@36387 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-23 22:15:19 +00:00
Ella Iseulde Van Dorpe
b780792d87 TinyMCE: add inline link dialog
First run.
Links the advanced button to the "old" dialog for now.

See #33301.


git-svn-id: https://develop.svn.wordpress.org/trunk@36384 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-23 00:07:29 +00:00
Andrea Fercia
e23986bdb3 Accessibility: Remove title attributes from the Menus screen.
Also, adds missing labels and improves the existing ones. 
Updates the "custom links" labels and inputs in the Customizer too.
Introduces a generic, reusable, `.wp-initial-focus` CSS class to be used for
the sole purpose of setting the initial focus.
"Quick Search": uniform the attached events and avoids new AJAX requests to
be triggered when the pressed key doesn't change the searched term.

Fixes #35374.

git-svn-id: https://develop.svn.wordpress.org/trunk@36379 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-22 14:25:58 +00:00
Sergey Biryukov
ac704e838c Media: In _wp_handle_upload(), move ending brace to a new line.
Props georgestephanis.
Fixes #35565.

git-svn-id: https://develop.svn.wordpress.org/trunk@36373 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-21 20:26:06 +00:00
Dion Hulse
51aee5ab1b Upgrade: Switch the locking mechanism to using static methods so that it can be accessed from other upgrade-classes.
Fixes #34878


git-svn-id: https://develop.svn.wordpress.org/trunk@36370 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-21 01:21:52 +00:00
Dion Hulse
b9e62671f6 Core Upgrader: Add a locking mechanism to avoid two concurrent updates of WordPress occuring.
Fixes #34878


git-svn-id: https://develop.svn.wordpress.org/trunk@36349 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-19 05:06:46 +00:00
Rachel Baker
2da13dda2e List Tables: Use the $GLOBALS array when unsetting the global post and comment in WP_Comments_List_Table::single_row().
In r35674 only the local variables were unset, when using `unset()` with a global variable the `$GLOBALS` array must be used.


Fixes #35506.


git-svn-id: https://develop.svn.wordpress.org/trunk@36339 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-18 02:49:40 +00:00
Andrea Fercia
2e78169eee After [36333] correctly use esc_attr() instead of esc_attr__().
See #35313.

git-svn-id: https://develop.svn.wordpress.org/trunk@36334 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-17 16:02:24 +00:00
Andrea Fercia
838f953d4d Accessibility: Remove title attributes from the Posts list table.
Fixes #35313.

git-svn-id: https://develop.svn.wordpress.org/trunk@36333 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-17 15:46:01 +00:00
Andrea Fercia
f8f12bf78a Accessibility: Remove title attributes from the Media Library list table.
Fixes #35136.

git-svn-id: https://develop.svn.wordpress.org/trunk@36331 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-17 14:45:26 +00:00
Dominik Schilling (ocean90)
54abada4cc Media: Update some attach/detach strings in the columns view.
* Show a "Media attachment reattached."/"Media attachment detached." message when only one attachment was attached/detached. 
* Use the string placeholder as `number_format_i18n()` returns a string.
* Add translator comments.
* Update help text to refer to the new dropdown menus.
* Add a more generic title to the attach modal.

Fixes #33237.

git-svn-id: https://develop.svn.wordpress.org/trunk@36328 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-15 22:28:15 +00:00
Pascal Birchler
cc6fe1179d Allow searching for 0 throughout the admin.
Fixes #31025.

git-svn-id: https://develop.svn.wordpress.org/trunk@36302 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 20:05:06 +00:00
Pascal Birchler
5209de6052 Plugins: Prevent a warning when searching in the plugins list table.
After [36182], plugin data contains compatibility info from the API, which is an array and cannot be searched.

Fixes #35461.

git-svn-id: https://develop.svn.wordpress.org/trunk@36301 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 19:59:06 +00:00
Andrea Fercia
0eed5e07d8 Accessibility: Remove title attributes from the Comments screen.
Fixes #35304.

git-svn-id: https://develop.svn.wordpress.org/trunk@36298 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 16:03:47 +00:00
Pascal Birchler
d2b96ce6b9 Plugins: Make sure the 'Beta testing' tab is first in the plugin installer.
This makes feature plugins more discoverable for people running development builds.

Fixes #29631.

git-svn-id: https://develop.svn.wordpress.org/trunk@36297 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-14 09:06:12 +00:00
Dominik Schilling (ocean90)
2efcaf2921 Plugins: In _get_plugin_data_markup_translate() remove the fallback to the "default" textdomain for Akismet.
Akismet has its own language files since WordPress 3.9.

Props jrf.
Fixes #35436.

git-svn-id: https://develop.svn.wordpress.org/trunk@36283 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-13 13:55:42 +00:00
Dominik Schilling (ocean90)
c86ffe454a Plugins: In _get_plugin_data_markup_translate() don't reload translations if they're already loaded.
Props jrf.
Fixes #35439.

git-svn-id: https://develop.svn.wordpress.org/trunk@36282 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-13 13:03:21 +00:00
Andrea Fercia
baaa8946a2 Accessibility: Remove title attributes from the Terms list table.
Fixes #35187.

git-svn-id: https://develop.svn.wordpress.org/trunk@36265 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 23:30:00 +00:00
Andrea Fercia
e6297676fb Accessibility: Remove title attributes from the General Settings screen.
Date and time formats are now displayed in plain text and available for all
users. Also, lines up them with the "custom" date and time format fields to
help reinforce what these fields do.

Props afercia, perezlabs.
Fixes #35064.

git-svn-id: https://develop.svn.wordpress.org/trunk@36263 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 22:53:10 +00:00
Pascal Birchler
844e1b6e7e After [36254], commit all the necessary files and not just the unit test.
git-svn-id: https://develop.svn.wordpress.org/trunk@36255 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 19:06:03 +00:00
John Blackbourn
ba5f0fdc7b Docs: Various docblock corrections.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36250 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 01:25:44 +00:00