Commit Graph

116 Commits

Author SHA1 Message Date
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin 85efa182f7 Forms with the class .wp-upload-form will now have their submit button disabled until a file is selected. props kovshenin, helenyhou, lessbloat, SergeyBiryukov, tommcfarlin. fixes #20855.
git-svn-id: https://develop.svn.wordpress.org/trunk@22459 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 23:54:03 +00:00
Andrew Nacin 8803a95bc3 Browse and install your wordpress.org plugin favorites from the plugin installer. props Otto42, Japh, DrewAPicture. fixes #22002.
git-svn-id: https://develop.svn.wordpress.org/trunk@22026 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-27 00:47:01 +00:00
Andrew Nacin 774a12be83 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: https://develop.svn.wordpress.org/trunk@21996 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 05:26:19 +00:00
Andrew Nacin 1c58ef9f33 Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598.
git-svn-id: https://develop.svn.wordpress.org/trunk@21944 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-21 19:34:23 +00:00
Daryl Koopersmith 7d6e53317c New button styles.
Using the new buttons:

* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".

For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.

get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).

props lessbloat, helenyhou, trepmal, nacin. see #21598.



git-svn-id: https://develop.svn.wordpress.org/trunk@21789 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-08 04:58:34 +00:00
Mark Jaquith 4374f93904 Autofocus the search box on the Theme and Plugin installation pages. Faster flow for people who know what they are looking for. props SergeyBiryukov. fixes #21080. see #21027.
git-svn-id: https://develop.svn.wordpress.org/trunk@21143 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-26 20:55:46 +00:00
Ryan Boren 1b25bfa42e Update plugin install screens to use the new stars. Add stars-rtl.png. Remove star.png and gray-star.png and add to old files list.
Props helenyhou
Fixes #20626



git-svn-id: https://develop.svn.wordpress.org/trunk@20754 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-09 16:27:24 +00:00
Ryan Boren 5b64115fc6 Friendlier strings with links to the support forums when experiencing problems talking to api.wordpress.org. fixes #20605
git-svn-id: https://develop.svn.wordpress.org/trunk@20752 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-09 15:55:59 +00:00
Andrew Nacin 869f8217ff Replace commas with periods when converting ratings float values to strings, to avoid issues with localized decimal points.
In these cases, we want a period because it is going to be used by CSS.

props SergeyBiryukov.
fixes #19593.



git-svn-id: https://develop.svn.wordpress.org/trunk@20675 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-01 22:09:55 +00:00
Andrew Nacin f553c11f28 Default to keyword searches for the plugin and theme installers in case no search type is posted back. fixes #19619.
props georgestephanis, SergeyBiryukov for initial patches.



git-svn-id: https://develop.svn.wordpress.org/trunk@20639 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-30 00:44:47 +00:00
Andrew Nacin cfe73da905 Reduce clutter and repetive functionality from the initial landing page for installing plugins and themes by removing the tag/author/term dropdown.
The tag cloud (plugins) and feature filter (themes) is sufficient for tag functionality. All three "search by" fields are already weighted for a standard keyword search through the WP.org API.

fixes #19619 for 3.4.



git-svn-id: https://develop.svn.wordpress.org/trunk@20592 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-25 19:37:19 +00:00
Andrew Nacin 8481a619b6 Check for the response property in tue update_plugins transient object. props ampt, fixes #20441.
git-svn-id: https://develop.svn.wordpress.org/trunk@20490 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-17 02:43:13 +00:00
Andrew Nacin 467905e308 Use 'Keyword' instead of 'Term' in the search type selector in the plugin and theme installers. see #19619.
git-svn-id: https://develop.svn.wordpress.org/trunk@20333 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-30 21:17:22 +00:00
Andrew Ozz fcbd8f7f57 Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
git-svn-id: https://develop.svn.wordpress.org/trunk@20168 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-10 01:23:48 +00:00
Dion Hulse 7cc1bd478d Better indentation. Props SergeyBiryukov. See #16580
git-svn-id: https://develop.svn.wordpress.org/trunk@19710 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 09:18:56 +00:00
Dion Hulse 7cedb26ac7 s/Faq/FAQ/ for Plugin Installer tabs, Gains Translation support for Tabs/Titles as well. Fixes #16580
git-svn-id: https://develop.svn.wordpress.org/trunk@19708 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 05:39:49 +00:00
Dion Hulse 3ff2213c55 use maybe_unserialize() in update and API checks, Tighten up the checks on expected return data to avoid processing invalid responses after change. See #19617
git-svn-id: https://develop.svn.wordpress.org/trunk@19707 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 03:48:05 +00:00
Ryan Boren f009eb7170 Remove 'Recently Updated' from plugin installer. Props nacin. see #19573
git-svn-id: https://develop.svn.wordpress.org/trunk@19627 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-22 21:21:57 +00:00
Ryan Boren 54067a5f20 Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: https://develop.svn.wordpress.org/trunk@19596 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-14 17:36:38 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Andrew Nacin 809c1558e3 Remove cruft. see #19106.
git-svn-id: https://develop.svn.wordpress.org/trunk@19112 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 04:14:14 +00:00
Mark Jaquith 41d1ab35f3 Use %s instead of %d in plugin install notice strings. props johnbillion. fixes #19106
git-svn-id: https://develop.svn.wordpress.org/trunk@19109 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 02:36:18 +00:00
Andrew Nacin 1287ec492a Translated strings in attributes require esc_attr(). s/_e/esc_attr_e/g
git-svn-id: https://develop.svn.wordpress.org/trunk@19028 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-20 15:04:46 +00:00
Jon Cave d6eb11b05b s/overridding/overriding/. Props trepmal, see #18560.
git-svn-id: https://develop.svn.wordpress.org/trunk@18641 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-05 19:25:55 +00:00
Jon Cave 60d321b14b Fix typos in documentation (wp-admin/). See #18560.
git-svn-id: https://develop.svn.wordpress.org/trunk@18632 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-03 14:18:10 +00:00
Andrew Nacin 8d5241c094 Check if property exists on plugins_api() returned object in install_plugin_information(). props hakre, fixes #18181.
git-svn-id: https://develop.svn.wordpress.org/trunk@18586 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-23 15:56:14 +00:00
Andrew Nacin f81a0e5a3c Link tab=upload when referenced on 'Install Plugins.' fixes #18290.
git-svn-id: https://develop.svn.wordpress.org/trunk@18481 602fd350-edb4-49c9-b593-d223f7449a82
2011-07-29 06:07:38 +00:00
Dion Hulse 2ed7ccf052 Add new star.gif replacement with a Grey background (& White counterpart). Props chexee for star icons. Fixes #17428
git-svn-id: https://develop.svn.wordpress.org/trunk@18318 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-17 05:41:35 +00:00
Andrew Nacin 02e8db225f Use wp_remote_retrieve_* helper functions instead of the raw HTTP response array. props aaroncampbell, fixes #17416.
git-svn-id: https://develop.svn.wordpress.org/trunk@17928 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-14 19:45:07 +00:00
Andrew Nacin ccea27cbe7 More param fixes, props duck_. see #14783.
git-svn-id: https://develop.svn.wordpress.org/trunk@16469 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-18 19:12:48 +00:00
Mark Jaquith d65cdf4ba8 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@16061 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-28 21:56:43 +00:00
Ryan Boren 771bf8b862 Add plugin update notifications, plugin install, plugin update to the network admin screen. Props PeteMall. see #15129
git-svn-id: https://develop.svn.wordpress.org/trunk@15867 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-20 14:16:03 +00:00
scribu 1c4aeef40e replace $table with $wp_list_table. See #14651
git-svn-id: https://develop.svn.wordpress.org/trunk@15519 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-22 11:22:46 +00:00
scribu fb9394167f Ajaxify list-type screens in the admin. See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@15491 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-11 21:54:51 +00:00
Dion Hulse f13e3b1dc2 Move plugin installer install_popular_tags() to use a site transient rather than its own caching logic. Fixes #13108
git-svn-id: https://develop.svn.wordpress.org/trunk@15287 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-19 07:28:27 +00:00
Dion Hulse 94487bb9ea Add Importer support to Plugin Install workflow, Offers to Activate Plugin & Run installer, and returning to Imports upon successful Importer Plugin Installation. See #13566
git-svn-id: https://develop.svn.wordpress.org/trunk@14985 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 11:04:08 +00:00
Andrew Nacin 47136b319f Introduce _ex(), a hybrid between _e() and _x() -- translate with context, then echo. props westi, see #13395.
git-svn-id: https://develop.svn.wordpress.org/trunk@14647 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-14 21:46:25 +00:00
Ryan Boren 57a5a11660 Revert [14347] and [14372]. It broke more than we expected. Try again in 3.1. see #13051
git-svn-id: https://develop.svn.wordpress.org/trunk@14374 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-03 18:16:22 +00:00
Ryan Boren 7fcda10d46 Escape links by default. Props alexkingorg. see #13051
git-svn-id: https://develop.svn.wordpress.org/trunk@14347 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-02 22:53:59 +00:00
Dion Hulse c63e95bdae Handle HTTP errors on popular tags requests, Handle HTTP Errors on listing loading slightly different no-js compatible. Fixes #13107
git-svn-id: https://develop.svn.wordpress.org/trunk@14228 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-25 05:39:39 +00:00
Andrew Nacin 5615e1ba93 Add AYS to "Install Now" link in plugin installer. fixes #11050
git-svn-id: https://develop.svn.wordpress.org/trunk@13951 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-02 23:27:23 +00:00
Andrew Nacin 5cd6b0f327 Change "More Information" link to "Details" in plugin installer. Shorten/clarify a few other strings. see #11050
git-svn-id: https://develop.svn.wordpress.org/trunk@13950 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-02 23:04:48 +00:00
Dion Hulse 1c542e0281 Correct typos in r13920. Use correct variable name. See #11050
git-svn-id: https://develop.svn.wordpress.org/trunk@13921 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-01 23:38:37 +00:00
Dion Hulse eb6dba1f3a Rename Install to More Information, Add an Install Now action link to the Plugin Installer search results. See #11050
git-svn-id: https://develop.svn.wordpress.org/trunk@13920 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-01 23:17:53 +00:00
Andrew Nacin 8ee771f548 Remove "Info" link in plugin installer. The "Install" link already opens a pop-up with information. see #11050
git-svn-id: https://develop.svn.wordpress.org/trunk@13522 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-01 06:01:00 +00:00
Andrew Nacin a7ddb80402 Rearrange action links in the install plugins browser. First pass on the UI overhaul. see #11050
git-svn-id: https://develop.svn.wordpress.org/trunk@13520 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-01 00:50:55 +00:00
Ryan Boren 72adbb470e Remove trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@12859 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-26 22:49:05 +00:00
Ryan Boren 2e46e81309 i18n fixes. Props nbachiyski. fixes #11954
git-svn-id: https://develop.svn.wordpress.org/trunk@12789 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-21 21:37:43 +00:00
Ryan Boren e2adfc832a Coding standards, space after if
git-svn-id: https://develop.svn.wordpress.org/trunk@12752 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-18 20:34:48 +00:00