sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
32,384 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

32384 Commits

Author SHA1 Message Date
Boone Gorges 0d28b59c0b Use a more reliable method for generating `get_terms()` cache key. 
Previously, the cache key included a serialization of `list_terms_exclusions`
callbacks, to ensure that the cache was differentiated properly for different
uses of the `list_terms_exclusions` filter. This strategy was flawed in a
couple of ways: serialization doesn't work equally well for all callable types;
the serialization required reaching into the `$wp_filter` global; serializing
the callback itself didn't properly account for the possibility that the
callback might return different values in different contexts; the cache key
didn't account for other filters that similarly affect the cached values, such
as `terms_clauses`.

We skirt all these issues by concatenating the cache key using the SQL query
string, which will reflect all filters applied earlier in `get_terms()`.

Props boonebgorges, wonderboymusic.
Fixes #21267.

git-svn-id: https://develop.svn.wordpress.org/trunk@35120 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 03:06:27 +00:00
SergeyBiryukov d5e0f87530 Docs: Describe the `$feedname` argument of `add_feed()`. 
Fixes #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35119 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 03:00:03 +00:00
Sergey Biryukov 77e2cd9e18 Feeds: Pass the second parameter of `"do_feed_{$feed}"` action, feed name, to callbacks added via `add_feed()`. 
The `$feed` parameter was added in [35115].

Props slimndap.
See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35118 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:58:21 +00:00
Boone Gorges f9094e546a In `get_terms()`, don't store `WP_Term` objects in cache. 
Fixes #34282.

git-svn-id: https://develop.svn.wordpress.org/trunk@35117 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:57:21 +00:00
Scott Taylor 34cb01e2f1 Users: when passing a `WP_User` instance to `wp_update_user()`, ensure that the user password is not accidentally double-hashed. This is terrifying. 
Adds unit tests.

Props tbcorr, salcode.
Fixes #28435.


git-svn-id: https://develop.svn.wordpress.org/trunk@35116 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:47:09 +00:00
Sergey Biryukov 4a2184d00c Feeds: Pass the feed name to `do_feed_{$feed}` action. 
Props johnbillion.
See #34259.

git-svn-id: https://develop.svn.wordpress.org/trunk@35115 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:43:30 +00:00
Scott Taylor 4c0b89553a Users: allow `-1` (no limit, use with extreme caution on large sites) as the value for `number` in `WP_User_Query` - similar to `posts_per_page => -1` in `WP_Query`. 
Adds unit tests.

Props mordauk, jesin, nofearinc.
Fixes #28631.


git-svn-id: https://develop.svn.wordpress.org/trunk@35114 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:39:05 +00:00
Scott Taylor 455392c531 Widgets: after [35106], ensure that the widget required by the unit test is registered. 
See #19450.


git-svn-id: https://develop.svn.wordpress.org/trunk@35113 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:35:47 +00:00
Boone Gorges e31a0390b1 In term meta lazy-loading tests, force `WP_Query` to cache results. 
By default, `WP_Query` will not cache query results when using a persistent
object cache. The lazyload tests, however, depend on the cache being set during
each `WP_Query`, because the object cache is cleared between tests.

See #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@35112 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:35:36 +00:00
Boone Gorges ae96d16ed9 Remove dead code from `WP_Query::lazyload_term_meta()`. 
git-svn-id: https://develop.svn.wordpress.org/trunk@35111 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:35:30 +00:00
Sergey Biryukov d884c65485 Remove obsolete code from `WP_Users_List_Table::get_sortable_columns(). 
Sorting by post count was disabled in [17024].

Props jdgrimes.
See #15861.

git-svn-id: https://develop.svn.wordpress.org/trunk@35110 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:24:12 +00:00
Sergey Biryukov e654f82ce5 Replace `get_bloginfo( 'wpurl' )` with `admin_url()` for plugin activation error message. 
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
Fixes #34280.

git-svn-id: https://develop.svn.wordpress.org/trunk@35109 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:11:30 +00:00
Boone Gorges 20225eb62a In cache tests, determine cache class name dynamically. 
Some cache backends may use a class name other than `WP_Object_Cache` for their
cache drop-in. For example, certain versions of the APC Object Cache plugin
have a shim called `APC_Object_Cache`.

See #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@35108 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:06:19 +00:00
Sergey Biryukov a326105ade Replace `get_bloginfo( 'wpurl' )` with `admin_url()` in plugin editor. 
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
See #34280.

git-svn-id: https://develop.svn.wordpress.org/trunk@35107 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 02:04:14 +00:00
Scott Taylor 65c8adc252 Widgets: When using `the_widget()`, the `$before_widget` argument only receives the widget class if using the default sidebar arguments. Run `sprintf` after parsing the args to fix this. 
Adds unit test.

Props coffee2code.
Fixes #19450.


git-svn-id: https://develop.svn.wordpress.org/trunk@35106 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:48:41 +00:00
Sergey Biryukov c0c0305749 Replace `get_bloginfo( 'wpurl' )` with `site_url()` in `rsd_link()`. 
Ensure the correct scheme is used for the `application/rsd+xml` link URL.

Props johnbillion.
See #34280.

git-svn-id: https://develop.svn.wordpress.org/trunk@35105 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:48:32 +00:00
Drew Jaynes 72c81e01d4 Widgets: Rename the `$name` parameter in `is_registered_sidebar()` to `$sidebar_id` and adjust the accepted types to `string|int` as sidebar IDs can be numeric. 
See #24878.


git-svn-id: https://develop.svn.wordpress.org/trunk@35104 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:44:44 +00:00
Scott Taylor b272dc68b9 Widgets: add a default filter for `widget_text` (used by the Text widget), `balanceTags`, which respects the option for `use_balanceTags`. 
Props MikeHansenMe.
Fixes #23083.


git-svn-id: https://develop.svn.wordpress.org/trunk@35103 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:39:43 +00:00
Scott Taylor 3616fe5939 Widgets: add a function, `is_registered_sidebar()` - helps us avoid touching the `$wp_registered_sidebars` global. 
Props GaryJ, wonderboymusic.
Fixes #24878.


git-svn-id: https://develop.svn.wordpress.org/trunk@35102 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:32:27 +00:00
Boone Gorges 9f551a4630 Don't match partial roles in `WP_User_Query`. 
Because 'role=ocean90' shouldn't match 'role=bocean901'.

Props bocean901, ocean90.
Fixes #22212.

git-svn-id: https://develop.svn.wordpress.org/trunk@35101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:31:53 +00:00
Scott Taylor d936110f7c Widgets: when getting settings, and none exist, set them to empty to avoid extraneous database queries on subsequent requests. 
Adds unit tests.

Props kovshenin, MikeHansenMe, dlh.
Fixes #26876.


git-svn-id: https://develop.svn.wordpress.org/trunk@35100 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:12:12 +00:00
Scott Taylor 32b604de00 Color Picker: when opening and closing, toggle a `wp-picker-active` class on the wrapper. 
Props norcross.
Fixes #29471.


git-svn-id: https://develop.svn.wordpress.org/trunk@35099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:07:21 +00:00
Drew Jaynes 681d100fd6 Feeds: Simplify logic for checking if the `do_feed_{$feed}` action is hooked to any callbacks. 
See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra `$hook` variable moot.

See #34264.


git-svn-id: https://develop.svn.wordpress.org/trunk@35098 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:06:26 +00:00
Drew Jaynes 1246590769 Feeds: Adjust the `do_feed_{$feed}` hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that. 
Props johnbillion.
Fixes #34264.


git-svn-id: https://develop.svn.wordpress.org/trunk@35097 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:02:47 +00:00
Sergey Biryukov 6aa28b5bd3 Format the number of comments in `wp-includes/embed-template.php` for the locale. 
Props johnbillion.
Fixes #34276.

git-svn-id: https://develop.svn.wordpress.org/trunk@35096 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:01:53 +00:00
Scott Taylor 380d27331e XML-RPC: Add a filter, `xmlrpc_memory_limit`, to allow the value of `$xmlrpc_memory_limit` to be increased. 
Props ankit.gade.
Fixes #29957.


git-svn-id: https://develop.svn.wordpress.org/trunk@35095 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 01:00:04 +00:00
Drew Jaynes 44a4978535 Plugins: Introduce the `delete_plugin` transactional hook, which fires immediately after a plugin deletion attempt occurs. 
Props Veraxus for the initial patch.
Fixes #26904.


git-svn-id: https://develop.svn.wordpress.org/trunk@35094 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 00:56:32 +00:00
Drew Jaynes 3f756da63a Login: Pass the username and `WP_User` object to the `retrieve_password_title` filter. 
Adding these parameters creates parity with the `retrieve_password_message` filter, used for modifying the message body of the same password reset email.

Props sudar.
Fixes #34252.


git-svn-id: https://develop.svn.wordpress.org/trunk@35093 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 00:50:28 +00:00
Sergey Biryukov 34a716709c In `number_format_i18n()`, check if `$wp_locale` is set before using it. 
Props pauldewouters.
Fixes #31553.

git-svn-id: https://develop.svn.wordpress.org/trunk@35092 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-13 00:29:18 +00:00
Sergey Biryukov e85d9f1312 Correct the `post_date` format in `WP_Date_Query` tests. 
It should be `'Y-m-d H:i:s'` in order to match the regex in `get_gmt_from_date()` if `'timezone_string'` option is not set.

Props pbearne.
Fixes #34277.

git-svn-id: https://develop.svn.wordpress.org/trunk@35091 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 23:39:50 +00:00
John Blackbourn 91583fe499 Add missing `@since` params and update the docs for `site_icon_url()` and `has_site_icon()`. 
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 23:27:18 +00:00
John Blackbourn d32c6cfbc9 Remove another unnecessary `function_exists()` call. 
See [35087]
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35089 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 23:19:43 +00:00
Drew Jaynes 33d083e263 Version bump. 
git-svn-id: https://develop.svn.wordpress.org/trunk@35088 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:58:22 +00:00
John Blackbourn 4d8c6f6e08 Remove an unnecessary `function_exists()` call which was included in the oEmbed feature plugin for compatibility with WordPress < 4.3. 
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35087 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:53:28 +00:00
John Blackbourn 2eaae4739b Correct two escaping functions used in `wp-includes/embed-template.php`. 
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35086 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:51:32 +00:00
John Blackbourn da6090d9f7 Add missing `@since` docs for the filters in `wp-includes/embed-template.php` 
See #32522, #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35085 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:50:34 +00:00
John Blackbourn d04e6dc919 Correct the `@since` doc for `WP_Query::is_embed()`. 
See #32522


git-svn-id: https://develop.svn.wordpress.org/trunk@35084 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 22:12:42 +00:00
Scott Taylor 743d22415f oEmbed: add fallback icons (not used yet) for older browsers. 
Props melchoyce.
See #34204.


git-svn-id: https://develop.svn.wordpress.org/trunk@35083 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 21:16:10 +00:00
John Blackbourn f5d2e0dd61 Add `$transient` as a parameter to the `set_transient_{transient}` action. 
Props SergeyBiryukov
Fixes #34269


git-svn-id: https://develop.svn.wordpress.org/trunk@35082 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 21:01:24 +00:00
Scott Taylor e05891a7ec Media: avoid "divide by zero" in `wp_get_attachment_image_srcset_array()`. 
Fixes #34238.


git-svn-id: https://develop.svn.wordpress.org/trunk@35081 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 20:59:12 +00:00
Drew Jaynes 6e6d9f9830 Docs: Specify the default image size in the `$size` parameter description for the `image_send_to_editor` hook. 
See #34257. See #32246. See [35058].


git-svn-id: https://develop.svn.wordpress.org/trunk@35080 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:17:19 +00:00
Drew Jaynes dd7b3a62fd Docs: Normalize spacing in the DocBlock for `get_image_send_to_editor()` following [35056]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35079 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:15:16 +00:00
Drew Jaynes 6ca6c6fc1c Docs: The `$size` parameter for the `get_image_tag` hook also accepts an array. 
See #34257. See [35038].


git-svn-id: https://develop.svn.wordpress.org/trunk@35078 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:10:59 +00:00
Drew Jaynes 03481541aa Docs: The `$size` parameter for the `get_image_tag_class` hook also accepts an array. 
See #34257. See [35037].


git-svn-id: https://develop.svn.wordpress.org/trunk@35077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:08:39 +00:00
Drew Jaynes 2f5be3afcf Docs: Adjust documentation for the `$size` parameter in `the_post_thumbnail_url()` to clarify the required order of width and height values when passing an array. 
Fixes #34257. Whew!


git-svn-id: https://develop.svn.wordpress.org/trunk@35076 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:59:48 +00:00
Drew Jaynes 663d71de0d Docs: The `post_thumbnail_size` hook can also accept an array (already supported). 
See #34257. See [35069].


git-svn-id: https://develop.svn.wordpress.org/trunk@35075 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:56:54 +00:00
Drew Jaynes 38141969f2 Docs: The `$size` parameters in the `begin_fetch_post_thumbnail_html` and `end_fetch_post_thumbnail_html` hooks can also accept an array (already supported). 
See #34257. See #32246. See [35070] and [35071].


git-svn-id: https://develop.svn.wordpress.org/trunk@35074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:55:08 +00:00
Drew Jaynes 581723a924 Docs: Normalize spacing in the `post_thumbnail_html` hook doc following [35072]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35073 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:52:15 +00:00
Drew Jaynes a92ba46df9 Docs: Adjust documentation for the `$size` parameter in the `post_thumbnail_html` hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35072 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:51:15 +00:00
Drew Jaynes ecf49d9f10 Docs: Adjust documentation for the `$size` parameter in the `end_fetch_post_thumbnail_html` hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35071 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:49:14 +00:00