Commit Graph

27744 Commits

Author SHA1 Message Date
Mark Jaquith be8a0c6f89 Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org)
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29789 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:36:38 +00:00
Mark Jaquith 7063377539 Use HTTPS URLs for core.trac.wordpress.org
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29788 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:27:55 +00:00
Mark Jaquith 4c22a5003b Use HTTPS links for planet.wordpress.org
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29787 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:23:46 +00:00
Sergey Biryukov 029d1dbaa4 Use a more specific selector for the count displayed on Add Themes network admin screen.
props mantismamita, nikolov.tmw.
fixes #29421.

git-svn-id: https://develop.svn.wordpress.org/trunk@29786 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:06:17 +00:00
Mark Jaquith 7402030670 Show the number of approved comments instead of all comments on
the dashboard in the "At a glance" section.

fixes #26738. props benjmay

git-svn-id: https://develop.svn.wordpress.org/trunk@29785 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 12:41:49 +00:00
Sergey Biryukov 2a050d1e6f Remove unnecessary semicolon.
props ixkaito.
fixes #29784.

git-svn-id: https://develop.svn.wordpress.org/trunk@29784 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 10:29:16 +00:00
Andrew Nacin 8a956769a4 PHPMailer: Merge upstream commit (PR274).
props zodiac1978.
fixes #27946.


git-svn-id: https://develop.svn.wordpress.org/trunk@29783 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 10:27:58 +00:00
Scott Taylor 37da833fce In the form handler logic for `edit-tags.php`, don't redirect until `$_REQUEST['paged']` has been checked. All `switch` cases (except `edit`) now use `break` instead of `exit`.
Fixes #16162.


git-svn-id: https://develop.svn.wordpress.org/trunk@29782 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 04:53:07 +00:00
Scott Taylor 23f7f53be2 The joys of `wptexturize()`:
* Revert parts of [28773] and [28727] and [29748].
* Do not crash PHP. Make the shortcode quantifier possessive to avoid backtracks.
* Reduce backtracking in long HTML comments by 100x.
* Do not ignore unclosed HTML comments.
* Do not break unregistered shortcodes, e.g. `[hello attr="value"]`.
* Do not break HTML in shortcode attributes, e.g. `[hello attr="<"]`.
* Do not match for shortcodes when there is extra whitespace, e.g. `[ hello ]`.
* Add unit tests to show #12690 was not fully resolved.
* Tested PHP 5.2.4, 5.2.13, 5.4.32, and 5.5.8.

Adds/modifies unit tests.

Props miqrogroove.
See #29557.


git-svn-id: https://develop.svn.wordpress.org/trunk@29781 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 04:06:54 +00:00
Scott Taylor 18adbb6439 In `paginate_links()`, ensure that query string args are propagated to the resulting paginated links.
Adds unit tests that use `DOMDocument` since `assertTag` is being deprecated - see #29545, [29746].

Props obenland, wonderboymusic.
Fixes #29636.


git-svn-id: https://develop.svn.wordpress.org/trunk@29780 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 04:02:23 +00:00
Scott Taylor d19b2ded94 Add `size` to the UI for Gallery Settings in the media modal. Ensure that the TinyMCE view is refreshed when size changes.
Props richardmtl, noplanman, wonderboymusic.
Fixes #18143.


git-svn-id: https://develop.svn.wordpress.org/trunk@29779 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 03:44:25 +00:00
Scott Taylor 0fe756a461 Allow bookmarks to be ordered by `link_description` in `get_bookmarks()`.
Fixes #29763.


git-svn-id: https://develop.svn.wordpress.org/trunk@29778 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 03:11:55 +00:00
Scott Taylor d1fe8a8152 Media Grid: when the modal is open, don't respond to arrow keys when `<textarea>` has focus.
Props ryelle.
Fixes #29725.


git-svn-id: https://develop.svn.wordpress.org/trunk@29777 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 02:59:40 +00:00
Andrew Ozz 3b757232d0 Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29776 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 00:13:47 +00:00
Sergey Biryukov 2e58e91dcc Remove unnecessary CSS overriding on Add Plugins screen.
props pavelevap.
fixes #29753.

git-svn-id: https://develop.svn.wordpress.org/trunk@29775 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-28 20:25:33 +00:00
Sergey Biryukov 9e5beefd72 Don't display an empty comment author IP link on Comments screen.
props afercia.
fixes #29766.

git-svn-id: https://develop.svn.wordpress.org/trunk@29774 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-28 06:37:10 +00:00
Sergey Biryukov 5f0598234b Use Tahoma for RTL in general and Arial for Hebrew in editor styles.
fixes #29553.

git-svn-id: https://develop.svn.wordpress.org/trunk@29773 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-27 11:10:01 +00:00
Sergey Biryukov f5a904c46a Twenty Fourteen: Include Latin Extended font subset for Lato.
fixes #29690.

git-svn-id: https://develop.svn.wordpress.org/trunk@29772 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-27 10:15:25 +00:00
Sergey Biryukov e2eebecfc6 Bundled themes: Prevent the arrow in "Continue reading" links from wrapping to a second line.
props DustinHartzler, dominik.schwind.
fixes #27908.

git-svn-id: https://develop.svn.wordpress.org/trunk@29771 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-27 08:01:35 +00:00
Andrew Ozz d34a54f1e4 Fix tapping on the menu in iOS and Android, fixes #29365 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@29770 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 23:01:52 +00:00
Sergey Biryukov 1c8658f620 Use correct i18n function after [29768].
props TobiasBg.
fixes #29751.

git-svn-id: https://develop.svn.wordpress.org/trunk@29769 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 20:53:12 +00:00
Sergey Biryukov a86e98ba96 Merge two similar strings.
props pavelevap.
fixes #29751.

git-svn-id: https://develop.svn.wordpress.org/trunk@29768 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 19:29:59 +00:00
Sergey Biryukov c993055800 Remove extra space from a string.
props pavelevap.
fixes #29752.

git-svn-id: https://develop.svn.wordpress.org/trunk@29767 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 18:48:05 +00:00
Andrew Ozz 27806558a2 TinyMCE wpView: when pasting/inserting content before a view, add new paragraph above it and insert the content there. Props avryl, fixes #29380 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29766 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 00:20:28 +00:00
Sergey Biryukov 3226d8b867 Create correct permalinks for child posts of hierarchical post types when default permalinks are used.
props loushou.
fixes #29615 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29765 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-24 21:29:15 +00:00
Sergey Biryukov fe6f5b3af3 Add context for 'Trash' string in media modal.
props pavelevap.
fixes #29739.

git-svn-id: https://develop.svn.wordpress.org/trunk@29764 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-24 13:48:27 +00:00
Drew Jaynes (DrewAPicture) 198db28c17 Improve and clarify inline commenting inside the `check_comment()` function.
Adds logical explanations of what some of the various comment checks are checking for, as well as some general cleanup and syntax fixes.

Fixes #29734.


git-svn-id: https://develop.svn.wordpress.org/trunk@29763 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 18:48:31 +00:00
Drew Jaynes (DrewAPicture) 0adb5f14aa Improve documentation in the `check_comments()` docblock.
* Removes two duplicate sentences from the long description
* Tightens up phrasing elsewhere in the long description for specific checks
* Clarifies the parameter and return descriptions, and adds periods

See #29734.


git-svn-id: https://develop.svn.wordpress.org/trunk@29762 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 18:46:52 +00:00
Scott Taylor 0b0eb4fb20 Ordering by `RAND()`:
The shortcode callbacks for `gallery` and `playlist` check for `'RAND' == $atts['order']`, which isn't a valid value for `order`. Remove those checks and update the docs.

In `WP_Query`, if the value of `orderby` is `rand`, `order` is irrelevant and should be unset.

Adds unit tests.

Fixes #29629.


git-svn-id: https://develop.svn.wordpress.org/trunk@29760 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:51:24 +00:00
Scott Taylor af71d22742 Add two properties to `media.model.Attachments.propmap`: `include` and `exclude`, which are aliases for `post__in` and `post__not_in`.
This allows you to instantiate a library that includes and/or excludes specific attachments by passing a single ID or an array of IDs.

Example usage:
{{{
wp.media({frame: 'post', library: {include: [414, 415]}}).open()
wp.media({frame: 'post', library: {include: 414}}).open()
wp.media({frame: 'post', library: {exclude: [414, 415]}}).open()
wp.media({frame: 'post', library: {exclude: 414}}).open()
}}}

Fixes #26587.


git-svn-id: https://develop.svn.wordpress.org/trunk@29759 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:37:06 +00:00
Scott Taylor 22db82dff1 In `wp_ajax_replyto_comment()`, if `$_POST['comment_type']` is set, use it for the value of `$comment_type`, which the `compact()` call has assumed is set since [8720]. It never was.
`wp_comment_reply()`'s output can be complete overridden by the `wp_comment_reply` filter, so this check is justified and makes the AJAX callback more flexible.

Props nerrad.
Fixes #29704.


git-svn-id: https://develop.svn.wordpress.org/trunk@29758 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:28:51 +00:00
Scott Taylor e97e5048c3 If the current user does not have the `delete_posts` cap on the current post type, don't list `delete` or `trash` as bulk actions for the relevant context of Post list table.
Props mvd7793.
Fixes #20175.


git-svn-id: https://develop.svn.wordpress.org/trunk@29757 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 02:57:43 +00:00
Scott Taylor f00f28cce0 `wp_extract_urls()` needs to also grab URLs with query strings and hashes.
Updates unit test.

Props hauvong, dlh.
Fixes #29314.


git-svn-id: https://develop.svn.wordpress.org/trunk@29756 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 02:49:22 +00:00
Scott Taylor 32c1d55d1f Media Grid:
* In Bulk Edit mode, don't attempt to delete or trash an attachment that doesn't have a `delete` nonce. The subsequent `_requery()` will then properly display the attachment still present in the library.
* Remove all updated models from the selection at the same time to avoid async race conditions. The selection is reset when the grid's `select` mode is deactivated, but this allows this view instance to be more portable.

This fix allows users to set caps on individual attachments without confusing the grid's library. This issue was present for bulk actions in general, had nothing to do with `MEDIA_TRASH` specifically.

Fixes #29597.


git-svn-id: https://develop.svn.wordpress.org/trunk@29755 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 18:51:41 +00:00
Sergey Biryukov 994566bb17 Pass the attachment ID to the 'image_add_caption_text' filter.
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29754 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 10:10:19 +00:00
Sergey Biryukov 9e673c7eee Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor.
props collinsinternet, DrewAPicture.
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29753 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 09:55:08 +00:00
Drew Jaynes (DrewAPicture) 191a7ead45 Add some missing information to the inline docs for `get_post_types()`.
* Improves the `@see` reference for `register_post_type()` to mention that it contains information about accepted arguments
* Adds a description of the accepted values for the `$operator` parameter
* Fixes a typo

Fixes #29721.


git-svn-id: https://develop.svn.wordpress.org/trunk@29752 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 08:54:37 +00:00
Andrew Nacin 4c1462f2ff Add safeguards for when ext/hash is not compiled with PHP.
see #29518, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@29751 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-20 17:27:46 +00:00
Sergey Biryukov 5b2c58d5b3 Correct 'wp_get_attachment_image_attributes' filter docs.
props tillkruess.
fixes #29701.

git-svn-id: https://develop.svn.wordpress.org/trunk@29750 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-18 12:35:25 +00:00
Andrew Nacin 9c751b268a Don't set ftp_credentials option when installling. see #29635.
git-svn-id: https://develop.svn.wordpress.org/trunk@29749 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-17 17:57:59 +00:00
Scott Taylor 606cd967f6 `wptexturize()` improvements:
* Expand the `wptexturize()` RegEx to include the list of registered shortcodes.
* Avoid backtracking after `[` chars by not filtering params in registered shortcodes. This will cause escaped shortcodes and their params to become texturized if not registered.
* Registered shortcode params will never be texturized, even when escaped.
* Move all tests involving unregistered shortcodes to a new and improved unit.
* Update one test involving HTML within shortcode params.

Props miqrogroove.
See #29557.


git-svn-id: https://develop.svn.wordpress.org/trunk@29748 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-17 15:13:24 +00:00
Scott Taylor fbf974a962 After [29200] and [29250], `Tests_MS::test_multisite_bootstrap()` should no longer have the `@expectedDeprecated` annotation.
git-svn-id: https://develop.svn.wordpress.org/trunk@29747 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-15 18:05:06 +00:00
Scott Taylor fd0b0d5f4f `assertTag()` has been deprecated in PHPUnit 4.2. Rewrite some of the tests in `Tests_Paginate_Links` to use `DOMDocument`.
Props effstieler.
Fixes #29545.


git-svn-id: https://develop.svn.wordpress.org/trunk@29746 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-15 17:41:47 +00:00
Sergey Biryukov 6e0ca0d8d9 Make sure the $parent argument of wp_insert_attachment() still works as expected after [28579].
prop jesin, dikiy_forester.
fixes #29646 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29745 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-15 14:23:31 +00:00
Sergey Biryukov 1ec860298d Correct @return value for WP_User_Query::get_total().
props jesin.
fixes #29656.

git-svn-id: https://develop.svn.wordpress.org/trunk@29744 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-13 22:23:12 +00:00
Sergey Biryukov 0075f1c7d1 Correct some @since values added in [29739].
see #28459.

git-svn-id: https://develop.svn.wordpress.org/trunk@29743 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-13 12:17:17 +00:00
Scott Taylor 0efd852117 `WP_oEmbed::_strip_newlines` is called as a filter callback for `oembed_dataparse`, must be public. It was marked as private for fun in [14109] and then made `private` officially in [28507].
Fixes #29647 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@29742 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 22:53:04 +00:00
wonderboymusic 578609d31e Make the URL output in `_thickbox_path_admin_subfolder()` use `includes_url()`.
Props voldemortensen.
Fixes #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29741 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 22:30:03 +00:00
Andrew Nacin 2dd4990234 kses: Add colgroup.
props collinsinternet.
fixes #29433.


git-svn-id: https://develop.svn.wordpress.org/trunk@29740 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 05:50:03 +00:00
Scott Taylor cbaef4a1a3 Add some `@since` annotations to `media-views.js`.
Props DrewAPicture.
See #28459.


git-svn-id: https://develop.svn.wordpress.org/trunk@29739 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 03:35:15 +00:00