Commit Graph

23188 Commits

Author SHA1 Message Date
Andrew Nacin d25d2a812b Use get_nav_menu_locations() in wp_delete_nav_menu().
props nofearinc.
see #25064.


git-svn-id: https://develop.svn.wordpress.org/trunk@25196 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 01:38:11 +00:00
Andrew Nacin a86a9f671d Nav menus: Allow assigning a new menu to an existing location when no theme setting is currently saved.
props ocean90.
see #25064, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25195 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 01:36:49 +00:00
Andrew Nacin 751fdfbc47 Remove display of 'Previously restored by' in the revisions meta box as it is busted.
Fixes invalid markup (missing closing ul tag) when there was no previously restored revision.

see #25051 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25194 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 01:32:06 +00:00
Andrew Nacin afe7f94304 Fix 'html5' theme support.
* Require it to have a second argument when adding.
 * Merge, rather than replace, on second add.
 * Make current_theme_supports() work when two arguments are passed.

Adds unit tests.

props nathanrice for initial patch.
see #24932 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25193 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 01:29:08 +00:00
Andrew Nacin 67f42435fe Hide 'Database Upgrade Required' on admin/network/upgrade.php when you are not being asked to upgrade, to prevent confusion.
props duck_.
see #24845. see #23540.


git-svn-id: https://develop.svn.wordpress.org/trunk@25191 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 00:56:31 +00:00
Andrew Nacin ee2baada7b Be less verbose when erroring out in do_feed() for an invalid feed template. fixes #24874.
git-svn-id: https://develop.svn.wordpress.org/trunk@25190 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 23:36:58 +00:00
Andrew Nacin dc3df4d410 Remove wp-tinymce.js.gz from develop.svn, as this is now part of the build process.
see #25159 and [25188].


git-svn-id: https://develop.svn.wordpress.org/trunk@25189 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 22:24:15 +00:00
Andrew Nacin 2b1b8427e7 Build tinymce.js.gz using grunt.
props azaozz.
see #25159.


git-svn-id: https://develop.svn.wordpress.org/trunk@25188 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 22:16:43 +00:00
Andrew Ozz fdafa8b480 Fix folding/unfolding of the admin menu on new installs, props SergeyBiryukov, fixes #24921 for 3.6.1.
git-svn-id: https://develop.svn.wordpress.org/trunk@25186 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 17:10:11 +00:00
Andrew Nacin 924a3227d8 Revert [23307] so new users in multisite are not automatically subscribers on the main site.
props duck_.
fixes #25166 for trunk.
see #15627.


git-svn-id: https://develop.svn.wordpress.org/trunk@25183 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 16:28:59 +00:00
Jon Cave a0940de83d Correct rewrite tag for hierarchical post types without a query_var.
Hierarchical rewrite rules operate via the 'pagename' query variable which is
passed to get_page_by_path(). However, the current rewrite rules use the 'name'
query variable for hierarchical types without a custom query_var.

Fixes #16323.


git-svn-id: https://develop.svn.wordpress.org/trunk@25182 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 08:07:06 +00:00
Dion Hulse b518606d42 Plugin Upgrader: Plugin_Upgrader::upgrade() returns nothing in event of success, every other install(), upgrade() and bulk_upgrade() method returns true, so return true;
git-svn-id: https://develop.svn.wordpress.org/trunk@25181 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 07:37:32 +00:00
Dion Hulse e320a48146 Theme Upgrader: Be super-careful and check the contents of the $wp_theme_directories variable before merging it, if someone has changed it directly, or worse, unset it, this could've resulted in the $protected_directories being empty. See [25082] See #22501
git-svn-id: https://develop.svn.wordpress.org/trunk@25180 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 07:34:24 +00:00
Andrew Nacin 21b61a9e6f Add signup_id primary key to $wpdb->signups, and add better indexes.
props josephscott, pento, barry.
see #15004.


git-svn-id: https://develop.svn.wordpress.org/trunk@25179 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 04:29:06 +00:00
Andrew Nacin 381affa4e4 Add `grunt test` task for QUnit tests.
props kadamwhite.
see #25096.


git-svn-id: https://develop.svn.wordpress.org/trunk@25178 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 04:06:34 +00:00
Andrew Nacin 3749745c3d Don't set up $post_author_data in map_meta_cap() as we don't need it.
props duck_.
fixes #25177.


git-svn-id: https://develop.svn.wordpress.org/trunk@25177 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 04:00:06 +00:00
Dion Hulse e9a8ae1acf WP_HTTP: Make the new 2nd parameter to WP_HTP::processHeaders() as optional. See #21182. Fixes #25179
git-svn-id: https://develop.svn.wordpress.org/trunk@25176 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 02:10:34 +00:00
Jon Cave 94e03ce09f Test that passwords containing the username are penalised.
Tidy up some spelling, indentation and whitespace whilst we're at it.

Props iandunn. See #25088.


git-svn-id: https://develop.svn.wordpress.org/trunk@25175 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 22:28:32 +00:00
Andrew Nacin 7e5192393a Check for a WP_Error return from wp_create_user() in register_new_user().
props coffee2code.
fixes #14290.


git-svn-id: https://develop.svn.wordpress.org/trunk@25174 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 22:15:06 +00:00
Andrew Nacin 0494df8152 Move wp-config-sample.php to the root of develop.svn.
wp-config.php is now created in the root. wp-config-sample.php is properly copied over to the build directory for syncing to core.svn.

Add some ignores.

fixes #25185, see #24976.



git-svn-id: https://develop.svn.wordpress.org/trunk@25173 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 20:45:17 +00:00
Scott Taylor 27e2fd864f Ignore `wp-tests-config.php` in root. See [25165].
git-svn-id: https://develop.svn.wordpress.org/trunk@25172 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 19:49:32 +00:00
Andrew Nacin fba8c3dabe Avoid validating wildcard hostnames in populate_network() when multisite is already activated.
props jeremyfelt.
fixes #25182.


git-svn-id: https://develop.svn.wordpress.org/trunk@25171 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 19:30:46 +00:00
Andrew Nacin f6966d20b3 Basic tests for wp_parse_id_list() to ensure positive integers. see [25169].
git-svn-id: https://develop.svn.wordpress.org/trunk@25170 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:58:40 +00:00
Scott Taylor 59b9a3a6f8 No need to re-map the return values of `wp_parse_id_list()` to int.
See #22074, #11823.



git-svn-id: https://develop.svn.wordpress.org/trunk@25169 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:53:03 +00:00
Scott Taylor f458d16c01 Improve the include / exclude SQL generation in `get_pages()` by using `IN` and `NOT IN` where applicable. Adds unit tests for include / exclude.
Fixes #22074.



git-svn-id: https://develop.svn.wordpress.org/trunk@25168 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:48:29 +00:00
Andrew Nacin dd78079286 Add QUnit tests for password-strength-meter.js.
props jorbin.
see #25088.


git-svn-id: https://develop.svn.wordpress.org/trunk@25167 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:44:36 +00:00
Andrew Nacin 1a651a4723 Add QUnit to WordPress core for JavaScript unit testing.
props jorbin.
see #25088.


git-svn-id: https://develop.svn.wordpress.org/trunk@25166 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:42:59 +00:00
Andrew Nacin 8045afd81b Move PHPUnit tests into a tests/phpunit directory.
wp-tests-config.php can/should reside in the root of a develop checkout. `phpunit` should be run from the root.

see #25088.


git-svn-id: https://develop.svn.wordpress.org/trunk@25165 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:39:34 +00:00
Scott Taylor d34baebc1d Search term `name` and `slug` when the `search` arg is passed to `get_terms()`. Adds unit test.
Props wojtek.szkutnik.
Fixes #13992.



git-svn-id: https://develop.svn.wordpress.org/trunk@25164 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 16:49:43 +00:00
Scott Taylor 9e96365b8e Pass the taxonomy around to relevant nav menu actions to avoid arbitrarily deleting all items with `menu-item-type` of `taxonomy`. Adds unit test for `wp_get_associated_nav_menu_items()`.
Props garyc40, SergeyBiryukov.
Fixes #15264.



git-svn-id: https://develop.svn.wordpress.org/trunk@25163 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 16:44:36 +00:00
Scott Taylor a4a765c5fd Improve the include / exclude SQL generation in `get_terms()` by using `IN` and `NOT IN` where applicable. Adds unit tests for include / exclude.
Props sirzooro, duck_.

Fixes #11823.



git-svn-id: https://develop.svn.wordpress.org/trunk@25162 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 16:23:30 +00:00
Scott Taylor 69785902db Support `id=>name` and `id=>slug` values for `fields` arg in `get_terms()`. Adds unit tests.
Props mikeschinkel.

Fixes #13661.



git-svn-id: https://develop.svn.wordpress.org/trunk@25161 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 15:18:08 +00:00
Scott Taylor 744a4a80a4 Respect the `fields` arg when passed to `get_children()`.
Fixes #22208.



git-svn-id: https://develop.svn.wordpress.org/trunk@25160 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 15:07:59 +00:00
Jon Cave 95cab73341 zxcvbn: Apply ROT13 when building the dynamic user_inputs dictionary.
The modified matcher assumes that the dictionaries are ROT13 encoded.
All of the static dictionaries were, but user_inputs wasn't. See #21737.


git-svn-id: https://develop.svn.wordpress.org/trunk@25159 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 08:40:51 +00:00
Andrew Nacin 0b9a70d548 Return to 'Item' for term updated messages for the link_category taxonomy.
props SergeyBiryukov, pavelevap.
fixes #18714.


git-svn-id: https://develop.svn.wordpress.org/trunk@25158 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 18:58:57 +00:00
Andrew Nacin 444d333872 Use Dropbox's zxcvbn library for our password meter.
The library was added in [25156].

props duck_.
see #21737.


git-svn-id: https://develop.svn.wordpress.org/trunk@25157 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 16:08:19 +00:00
Andrew Nacin b9f05488aa Add Dropbox's zxcvbn library for realistic password strength estimation.
Upstream: https://github.com/lowe/zxcvbn. MIT License.
Modified for WordPress with a rot13 of the included word dictionaries, for PG-ness.

props duck_.
see #21737.


git-svn-id: https://develop.svn.wordpress.org/trunk@25156 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 16:02:53 +00:00
Dion Hulse a044fcf1ae WP_HTTP: Fix a variable typo in [25153] See #23463
git-svn-id: https://develop.svn.wordpress.org/trunk@25155 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 07:29:09 +00:00
Dion Hulse de7d430280 WP_HTTP: Update the documentation regarding HTTP/1.1 support. Props leewillis77 Fixes #25074
git-svn-id: https://develop.svn.wordpress.org/trunk@25154 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 06:54:22 +00:00
Dion Hulse 2785826961 WP_HTTP: Improve WP_HTTP::chunkTransferDecode() to properly handle binary data and chunked responses which include data in the page that looks like a chunked response.
This also fixes a case where the gzip'd data would become corrupt after chunked decoding as \r\n was replaced with \n in the data stream. Fixes #23463 


git-svn-id: https://develop.svn.wordpress.org/trunk@25153 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 06:52:09 +00:00
Sergey Biryukov 1d00e1d88a Make sure $args is an array before treating it as such. fixes #25151 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@25151 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 05:27:03 +00:00
Dion Hulse 7f0891c1a1 WP_HTTP: When requesting a document with HTTP/1.1 include the 'Connection: Close' header (unless a Connection header is already specified) to prevent the connection being held open and hanging the request process. See #23463
git-svn-id: https://develop.svn.wordpress.org/trunk@25150 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 04:58:51 +00:00
Dion Hulse 4f410dc9f3 WP_HTTP: More relaxed host matching for WP_PROXY_BYPASS_HOSTS and WP_ACCESSIBLE_HOSTS, allowing for subdomains in wildcards to include dashes (and anything else which [\w.] didn't catch). Fixes #24201
git-svn-id: https://develop.svn.wordpress.org/trunk@25149 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 04:53:41 +00:00
Andrew Nacin 022e5c2227 The main site of a secondary network should not use the original wp-content/uploads upload path.
props jeremyfelt.
fixes #25030.


git-svn-id: https://develop.svn.wordpress.org/trunk@25148 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 03:35:44 +00:00
Andrew Nacin dc0d29b59b Introduce is_main_network().
By default, a network ID of 1 is assumed to be the main network.
Otherwise, it is the first network listed in the wp_site table.

If PRIMARY_NETWORK_ID is defined, it is considered main network.

props jeremyfelt.
see #25030.


git-svn-id: https://develop.svn.wordpress.org/trunk@25147 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 03:34:50 +00:00
Dion Hulse d9bd6e7039 Use a better variable name in antispambot() introduced with [25055]. Props duck_ Fixes #16754
git-svn-id: https://develop.svn.wordpress.org/trunk@25146 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 01:46:57 +00:00
Dion Hulse b38ac8cd66 Unit Tests: Make it more compatible with PHPUnit when installed as a Phar, or, Composer package, by removing a duplicate require (Phpunit already includes the file itself). Props scribu Fixes #25065
git-svn-id: https://develop.svn.wordpress.org/trunk@25145 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 01:43:14 +00:00
Dominik Schilling (ocean90) c1827f73cd Replace duplicated lines in [25143] with an assignment. see #18714.
git-svn-id: https://develop.svn.wordpress.org/trunk@25144 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-27 21:24:59 +00:00
Andrew Nacin d37203df8e Add a terms_updated_messages filter to edit-tags.php, along with taxonomy-specific strings.
props johnbillion.
fixes #18714.


git-svn-id: https://develop.svn.wordpress.org/trunk@25143 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-27 21:12:40 +00:00
Andrew Nacin 713c6cfb88 Pass $taxonomies to the get_terms_orderby filter.
props johnbillion.
fixes #18754.


git-svn-id: https://develop.svn.wordpress.org/trunk@25142 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-27 21:05:03 +00:00