Commit Graph

39 Commits

Author SHA1 Message Date
Ryan Boren 4088ca8723 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23563 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:00:25 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Andrew Nacin 780c74d246 Remove unused variables reset by wp_reset_vars(). Many of these haven't been used since b2. see #21767.
git-svn-id: https://develop.svn.wordpress.org/trunk@23445 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-16 18:28:41 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Ryan Boren 2986ab9418 Show a better message ondmins on link-manager.php, link-add.php, link.php when links are disabled.
Props nacin
fixes #22569


git-svn-id: https://develop.svn.wordpress.org/trunk@22855 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 00:20:27 +00:00
Andrew Nacin 54a6a40533 Introduce $wpdb->delete(). props justindgivens, scribu. fixes #18948.
git-svn-id: https://develop.svn.wordpress.org/trunk@20287 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-24 15:24:31 +00:00
Andrew Nacin a66dd764d6 Instantiate an object in get_default_link_to_edit(). fixes #20280.
git-svn-id: https://develop.svn.wordpress.org/trunk@20256 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-22 05:07:27 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Andrew Nacin fb4e38b0e7 Pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@15843 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-19 07:48:22 +00:00
Andrew Nacin af29b5d5cf phpdoc, @since, whitespace. Also require an argument in wp_insert_post(). props duck_, see #14783.
git-svn-id: https://develop.svn.wordpress.org/trunk@15564 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-05 02:45:39 +00:00
Ryan Boren 494ee995b5 Use get_current_user() and get_current_user_id() instead of global . Props filofo. see #13934 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@15315 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-24 15:01:29 +00:00
Andrew Nacin d43ba9114b Don't use deprecated functions. see #11388
git-svn-id: https://develop.svn.wordpress.org/trunk@13106 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-13 10:35:10 +00:00
Ryan Boren d204fd6215 Test explicitly for false from insert()/update(). Fixes early return that preventing link categories from being saved. fixes #12196
git-svn-id: https://develop.svn.wordpress.org/trunk@13053 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-11 16:17:12 +00:00
Ryan Boren 7b580bf8e8 Use update and insert. Props DD32. fixes #6836
git-svn-id: https://develop.svn.wordpress.org/trunk@12652 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-07 20:13:54 +00:00
Ryan Boren dcd3604d90 Use array calling style. Props Denis-de-Bernardy. see #6647
git-svn-id: https://develop.svn.wordpress.org/trunk@12515 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-23 15:31:02 +00:00
Mark Jaquith ba1c3bdd5b Deprecate sanitize_url() and clean_url() in favor of esc_url_raw() and esc_url()
git-svn-id: https://develop.svn.wordpress.org/trunk@11383 602fd350-edb4-49c9-b593-d223f7449a82
2009-05-18 16:00:33 +00:00
Mark Jaquith f0336cfa7d deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security.
git-svn-id: https://develop.svn.wordpress.org/trunk@11380 602fd350-edb4-49c9-b593-d223f7449a82
2009-05-18 15:11:07 +00:00
Mark Jaquith c638e8d8de _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650
git-svn-id: https://develop.svn.wordpress.org/trunk@11204 602fd350-edb4-49c9-b593-d223f7449a82
2009-05-05 19:43:53 +00:00
Ryan Boren fe7c34b6fd s/attribute_escape/attr/. see #9650
git-svn-id: https://develop.svn.wordpress.org/trunk@11109 602fd350-edb4-49c9-b593-d223f7449a82
2009-04-28 05:58:45 +00:00
Ryan Boren 181d28cd9a If link name not given, use url for name. Props Denis-de-Bernardy. fixes #7789 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@10414 602fd350-edb4-49c9-b593-d223f7449a82
2009-01-22 22:47:34 +00:00
Ryan Boren 2dc15c5a81 Notice fixes from DD32. see #7509
git-svn-id: https://develop.svn.wordpress.org/trunk@9699 602fd350-edb4-49c9-b593-d223f7449a82
2008-11-14 23:01:16 +00:00
Mark Jaquith 53fe2dd063 Code cleanup for wp-admin/includes/bookmark.php
git-svn-id: https://develop.svn.wordpress.org/trunk@9659 602fd350-edb4-49c9-b593-d223f7449a82
2008-11-13 07:17:40 +00:00
Ryan Boren f885a9f93a phpdoc for wp-admin/includes from jacobsantos. see #7527
git-svn-id: https://develop.svn.wordpress.org/trunk@9053 602fd350-edb4-49c9-b593-d223f7449a82
2008-10-02 01:03:26 +00:00
Ryan Boren fa0b44817d Add edit and delete links to the Content->Links rows. Add get_edit_bookmark_link(). Add caching for individual bookmarks. see #7552
git-svn-id: https://develop.svn.wordpress.org/trunk@8758 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-27 22:04:12 +00:00
Ryan Boren 2272a1a950 Trailing whitespace cleanup
git-svn-id: https://develop.svn.wordpress.org/trunk@8600 602fd350-edb4-49c9-b593-d223f7449a82
2008-08-09 05:36:14 +00:00
Ryan Boren cbcc62a5b2 Strip slashes before preparing link for insert. see #6644
git-svn-id: https://develop.svn.wordpress.org/trunk@7693 602fd350-edb4-49c9-b593-d223f7449a82
2008-04-16 05:55:27 +00:00
Ryan Boren fdc05b24f6 Prepare DB queries in more places. Props filosofo. see #6644
git-svn-id: https://develop.svn.wordpress.org/trunk@7645 602fd350-edb4-49c9-b593-d223f7449a82
2008-04-14 16:13:25 +00:00
Ryan Boren 882fa08d42 Add sanitization to get_link() and get_link_to_edit(). Props mdawaffe. fixes #6125
git-svn-id: https://develop.svn.wordpress.org/trunk@7193 602fd350-edb4-49c9-b593-d223f7449a82
2008-03-10 05:28:21 +00:00
Ryan Boren c644e7c0bc Add privacy and preview to edit link submitbox
git-svn-id: https://develop.svn.wordpress.org/trunk@6935 602fd350-edb4-49c9-b593-d223f7449a82
2008-02-20 08:06:03 +00:00
Ryan Boren 029a74ca44 Remove unused variables. Props DD32. see #5418
git-svn-id: https://develop.svn.wordpress.org/trunk@6363 602fd350-edb4-49c9-b593-d223f7449a82
2007-12-06 06:37:30 +00:00
Ryan Boren d8adefe0b2 bookmark sanitizer funcs and default filter cleanup. see #4546
git-svn-id: https://develop.svn.wordpress.org/trunk@5906 602fd350-edb4-49c9-b593-d223f7449a82
2007-08-20 22:50:04 +00:00
Ryan Boren 7df77b79b9 Add some taxonomy validation. Rearrange funcs.
git-svn-id: https://develop.svn.wordpress.org/trunk@5726 602fd350-edb4-49c9-b593-d223f7449a82
2007-06-19 00:33:44 +00:00
Ryan Boren 240cfc467c EXTR_SKIP. See #4468
git-svn-id: https://develop.svn.wordpress.org/trunk@5712 602fd350-edb4-49c9-b593-d223f7449a82
2007-06-15 17:30:37 +00:00
Ryan Boren b046d67f41 Trim empty lines. Nothing but newline.
git-svn-id: https://develop.svn.wordpress.org/trunk@5700 602fd350-edb4-49c9-b593-d223f7449a82
2007-06-14 02:25:30 +00:00
Ryan Boren 67013eb065 Separate AJAX cat adder into post and link flavors. see #4189
git-svn-id: https://develop.svn.wordpress.org/trunk@5637 602fd350-edb4-49c9-b593-d223f7449a82
2007-06-02 02:53:09 +00:00
Ryan Boren 921a17e6a0 Return true when deleting link to satisfy admin-ajax error check. see #4189
git-svn-id: https://develop.svn.wordpress.org/trunk@5564 602fd350-edb4-49c9-b593-d223f7449a82
2007-05-27 19:43:44 +00:00
Ryan Boren cb8250ff30 Link category fixes. see #4189
git-svn-id: https://develop.svn.wordpress.org/trunk@5560 602fd350-edb4-49c9-b593-d223f7449a82
2007-05-27 17:21:04 +00:00
Ryan Boren b41b02db5d Fix object term relationship deletion and count updating.
git-svn-id: https://develop.svn.wordpress.org/trunk@5556 602fd350-edb4-49c9-b593-d223f7449a82
2007-05-27 05:15:18 +00:00
Ryan Boren 09f70467e0 Admin includes reorg. see #4334
git-svn-id: https://develop.svn.wordpress.org/trunk@5542 602fd350-edb4-49c9-b593-d223f7449a82
2007-05-25 07:16:21 +00:00