Commit Graph

138 Commits

Author SHA1 Message Date
Sergey Biryukov 7c906b0c38 Avoid an undefined index notice in WP_Widget_Recent_Posts::update(). props jrf. fixes #24577.
git-svn-id: https://develop.svn.wordpress.org/trunk@24504 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-23 08:20:08 +00:00
Sergey Biryukov cb0bd68404 Don't append ellipsis in RSS widget if the entire content is shown. props kovshenin. fixes #21702.
git-svn-id: https://develop.svn.wordpress.org/trunk@24213 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-08 23:23:05 +00:00
Sergey Biryukov 4cfc8178cf Simplify logic in WP_Widget_Recent_Posts and WP_Widget_Recent_Comments. fixes #23089.
git-svn-id: https://develop.svn.wordpress.org/trunk@23597 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-04 02:14:23 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Sergey Biryukov f474e9da60 Add a missing closing tag. fixes #23510. see #14358.
git-svn-id: https://develop.svn.wordpress.org/trunk@23454 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-19 02:06:21 +00:00
Sergey Biryukov 417adb2e2e Filter "Powered by WordPress" text in Meta widget. props Viper007Bond, wonderboymusic. fixes #14358.
git-svn-id: https://develop.svn.wordpress.org/trunk@23424 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-15 16:20:14 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Sergey Biryukov 16e16c7ee4 Use correct escaping function. fixes #23334.
git-svn-id: https://develop.svn.wordpress.org/trunk@23413 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 05:52:23 +00:00
Andrew Nacin dffb1b36d5 Add context to the 'Random' string. It is now used in two places: gallery order and the links widget. props pavelevap, fixes #22724.
git-svn-id: https://develop.svn.wordpress.org/trunk@23021 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 14:49:44 +00:00
Andrew Nacin 21f4690f30 Final HiDPI tweaks. Don't use rss-2x.png on a front-end widget. Improve selectors for favicons in the toolbar to avoid breaking existing images. Remove unnecessary RTL styles. FIXES #21019.
git-svn-id: https://develop.svn.wordpress.org/trunk@22481 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-09 02:06:59 +00:00
Andrew Ozz 0493132497 More retina backgrounds and bits, props saracannon, empireoflight and lessbloat, see #21019
git-svn-id: https://develop.svn.wordpress.org/trunk@22439 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:54:08 +00:00
Andrew Nacin 496ae7b83f Merge some strings. props pavelevap. fixes #22306.
git-svn-id: https://develop.svn.wordpress.org/trunk@22430 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 19:37:54 +00:00
Andrew Nacin ffa6fd2e62 Prime post caches for the Recent Comments widget. props mitchoyoshitaka. see #15400.
git-svn-id: https://develop.svn.wordpress.org/trunk@22278 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-23 14:18:37 +00:00
Ryan Boren 7ba5099795 Objects no longer need to be explicitly passed by ref to call_user_func*() to be callable. Props wonderboymusic. fixes #21865
git-svn-id: https://develop.svn.wordpress.org/trunk@22118 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-04 20:00:16 +00:00
Andrew Nacin 9ce4af9bd4 Close label. props lancewillett, fixes #21064.
git-svn-id: https://develop.svn.wordpress.org/trunk@21978 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-24 19:16:53 +00:00
Peter Westwood cd0eabd965 Widgets: Add support for display the post date in the Recent Posts widget. Fixes #21064 props lancewillett and SergeyBiryukov.
git-svn-id: https://develop.svn.wordpress.org/trunk@21935 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-21 10:05:54 +00:00
Andrew Nacin 1563fce7ff Use selected() in default widgets. props SergeyBiryukov, iamfriendly. fixes #21451.
git-svn-id: https://develop.svn.wordpress.org/trunk@21867 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-16 16:51:12 +00:00
Andrew Nacin 0cc58945a6 Calendar widget: Don't print widget title markup when the title is empty. props jakub.tyrcha. fixes #17837.
git-svn-id: https://develop.svn.wordpress.org/trunk@21841 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-13 19:46:24 +00:00
Andrew Nacin 9931c1a45d Hide the link manager from the UI on upgrade, if the site has no links. New DB option, link_manager_enabled.
Enforce this by denying the 'manage_links' capability, which hides the All Links, Add New Link, and Link Categories screens. Hide WP_Widget_Links and the UI for the default_link_category as well.

Convert all references to 'posts and links' when handling reassignment on user deletion to just 'posts'.

see #21307.



git-svn-id: https://develop.svn.wordpress.org/trunk@21501 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-13 16:18:42 +00:00
Andrew Nacin 6624783c75 Use get_taxonomies() instead of get_object_taxonomies() in the tag cloud widget. props GautamGupta, scribu. see #20238, see #16125.
git-svn-id: https://develop.svn.wordpress.org/trunk@20285 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-24 14:00:52 +00:00
Jon Cave 9c5f3d0243 Remove dead code from the Links widget. Props pavelevap, SergeyBiryukov. Fixes #19179.
The widget() method isn't called on the admin screen.


git-svn-id: https://develop.svn.wordpress.org/trunk@20245 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-21 21:01:05 +00:00
Jon Cave 9d02deaa8e Add a trailing colon for consistency with other widget labels. See #20158.
git-svn-id: https://develop.svn.wordpress.org/trunk@20083 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 20:25:12 +00:00
Jon Cave 2cbf23b8ba Unhide the Select Link Category label. Fixes #20158.
git-svn-id: https://develop.svn.wordpress.org/trunk@20081 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 20:21:43 +00:00
Jon Cave fcfd3e03f5 Add sorting and limiting to the links widget. Props yoavf. Fixes #12785.
git-svn-id: https://develop.svn.wordpress.org/trunk@20071 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 13:58:58 +00:00
Andrew Nacin 5e9b785d5d Add widget_comments_args and widget_post_args filters. props ramiy, fixes #16159.
git-svn-id: https://develop.svn.wordpress.org/trunk@20047 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 21:56:24 +00:00
Jon Cave 8039f91954 Echo "WordPress.org" as well as translating it in the Meta widget. See #19603.
git-svn-id: https://develop.svn.wordpress.org/trunk@19838 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-06 19:52:42 +00:00
Andrew Nacin 10d17e6e29 Use translate, not translate with context. props azaozz. see #19603.
git-svn-id: https://develop.svn.wordpress.org/trunk@19829 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-04 18:37:53 +00:00
Andrew Nacin ca343daf1c Translate another http://wordpress.org/ link. see #19603.
git-svn-id: https://develop.svn.wordpress.org/trunk@19823 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-03 20:16:58 +00:00
Ryan Boren cb374258bb Remove extraneuos newlines
git-svn-id: https://develop.svn.wordpress.org/trunk@19623 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-21 18:42:11 +00:00
Andrew Nacin 50b132c285 Context for 'All Links'. props SergeyBiryukov, pavelevap. fixes #18096.
git-svn-id: https://develop.svn.wordpress.org/trunk@19202 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-07 17:28:20 +00:00
Andrew Nacin 425560c739 Pass instance and id_base to widget_tirle filter in WP_Widget_Recent_Comments. props scribu, fixes #18393.
git-svn-id: https://develop.svn.wordpress.org/trunk@18785 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-27 02:38:31 +00:00
Peter Westwood a8f99a3d72 Remove the accidental commit of the cache avoiding test code in [18677] props vnsavage
git-svn-id: https://develop.svn.wordpress.org/trunk@18679 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-15 10:43:22 +00:00
Peter Westwood 3aac6e630b Set a consistent cache key when using the_widget to display the Recent Posts and Recent Comments widgets so that they get cached. See #16761.
git-svn-id: https://develop.svn.wordpress.org/trunk@18677 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-15 10:08:43 +00:00
Peter Westwood 2d6257665d Fix Notices in default Widgets when called using the_widget(). Fixes #16761 props mfields and SergeyBiryukov
git-svn-id: https://develop.svn.wordpress.org/trunk@18676 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-15 09:41:17 +00:00
Ryan Boren 868ff9bcfa Pass no_found_rows to query in recent posts widget. Props scribu. fixes #17203
git-svn-id: https://develop.svn.wordpress.org/trunk@17825 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-06 20:54:43 +00:00
Andrew Nacin c3ed3b072e Update the self-referential destruction sequence in WP_Widget_RSS to account for trailing slashes. TODO: Strengthen our validation here.
git-svn-id: https://develop.svn.wordpress.org/trunk@17765 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-29 14:44:43 +00:00
Ryan Boren f888f1cc64 Allow retrieving comments by post type, status, author, author, name, or parent. Fetch only published posts for recent comments widget. Props filosofo. fixes #16506 #12904
git-svn-id: https://develop.svn.wordpress.org/trunk@17667 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-20 18:02:41 +00:00
Ryan Boren e7a943c60c Remove PHP4 constructors. Props scribu. fixes #16768
git-svn-id: https://develop.svn.wordpress.org/trunk@17655 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-18 21:46:57 +00:00
Andrew Nacin c4e9ac89ba Disallow a self-reference on RSS widget save, which would DoS a site. Checking home/siteurl should cover the vast majority of cases. see #8910.
git-svn-id: https://develop.svn.wordpress.org/trunk@17260 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-11 21:37:12 +00:00
Andrew Nacin dc821cedbf Remove ceilings on recent comments and posts widgets and dashboard widgets. fixes #14543.
git-svn-id: https://develop.svn.wordpress.org/trunk@16922 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-14 17:58:47 +00:00
Mark Jaquith 3da39609e4 Add class to Tag Cloud widget div. props djzone. fixes #12602
git-svn-id: https://develop.svn.wordpress.org/trunk@16694 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-02 21:28:17 +00:00
Peter Westwood 0da69e3b32 Let SimplePie do more of the date handling for us. Props rmccue.
git-svn-id: https://develop.svn.wordpress.org/trunk@16566 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-24 11:53:12 +00:00
Andrew Nacin f82118f579 Add a simple filter to allow removing the recent comments default widget styles. fixes #15493, see #14876.
git-svn-id: https://develop.svn.wordpress.org/trunk@16522 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-21 13:55:11 +00:00
Mark Jaquith 55e0256967 esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454
git-svn-id: https://develop.svn.wordpress.org/trunk@16431 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-17 17:12:01 +00:00
Peter Westwood 91d456e319 Restore the (at most 15) on the Recent Posts Widgets UI - Accidentally removed as part of [14483].
git-svn-id: https://develop.svn.wordpress.org/trunk@16013 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-27 14:10:47 +00:00
Andrew Nacin ad18a5dc4b Standardize on 'Display as dropdown' and list those before post counts in default widgets. fixes #15096.
git-svn-id: https://develop.svn.wordpress.org/trunk@15993 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-27 01:52:59 +00:00
Andrew Nacin 5e37bb785a s/showposts/posts_per_page/
git-svn-id: https://develop.svn.wordpress.org/trunk@15788 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-13 05:25:00 +00:00
Mark Jaquith 93680ad646 Rename caller_get_posts WP_Query flag to ignore_sticky_posts, because that is the only thing it does. fixes #14624. props scribu
git-svn-id: https://develop.svn.wordpress.org/trunk@15589 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-07 04:46:08 +00:00
Ryan Boren fdc775d75e Filter title for Custom Menu widget. Props jorbin. fixes #14009 for 3.1
git-svn-id: https://develop.svn.wordpress.org/trunk@15316 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-24 15:07:11 +00:00
Ryan Boren fc2793bd46 Deprecate is_term, is_taxonomy, is_post_type for *_exists(). Props nacin. fixes #13747
git-svn-id: https://develop.svn.wordpress.org/trunk@15220 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-11 15:53:41 +00:00