sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,118 Commits 2 Branches 473 Tags 137 MiB
81ec5c8e91
Commit Graph

7630 Commits

Author SHA1 Message Date
Scott Taylor
7b58399a45 Users: move WP_User_Query into its own file. user.php loads the new files, so this is 100% BC if someone is loading user.php directly (a lot of plugins do). New files created using svn cp. 
Creates: 
`class-wp-user-query.php` 
`user-functions.php` 

`user.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33749 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 04:19:32 +00:00
Scott Taylor
f4ecd11e10 HTTP: move classes into their own files, http.php loads the new files, so this is 100% BC if someone is loading http.php directly. New files created using svn cp. 
`class-http.php` requires functions from `http.php`, so loading it by itself wouldn't have worked.

Creates: 
`class-wp-http-cookie.php` 
`class-wp-http-curl.php` 
`class-wp-http-encoding.php` 
`class-wp-http-proxy.php` 
`class-wp-http-streams.php` 
`http-functions.php` 

`WP_Http` remains in `class-http.php`.

`http.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33748 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 03:55:00 +00:00
Gary Pendergast
2b67add6dd When wp_json_encode() calls json_encode(), the latter will generate warnings if the string contains non-UTF-8 characters. No-one likes warnings, so we need to do something about that. 
The good news is, the point of `wp_json_encode()` is to handle those non-UTF-8 characters. It'll totally just fix them up, no problem.

Anyway, we can just ignore those warnings.

Fixes #33524.



git-svn-id: https://develop.svn.wordpress.org/trunk@33747 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 03:25:15 +00:00
Scott Taylor
6c71ee8d84 Widgets: move classes into their own files, widgets.php loads the new files, so this is 100% BC if someone is loading widgets.php directly. New files created using svn cp. 
Creates: 
`class-wp-widget.php` 
`class-wp-widget-factory.php` 
`widget-functions.php` 

`widgets.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33746 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 02:39:50 +00:00
Sergey Biryukov
0654d9ed35 Add oEmbed support for ReverbNation. 
props rhubbardreverb.
fixes #33207.

git-svn-id: https://develop.svn.wordpress.org/trunk@33745 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 00:28:11 +00:00
Sergey Biryukov
b935049f24 Add 'wp_verify_nonce_failed' action that fires when nonce verification fails. 
props johnbillion, garza, Shelob9.
fixes #24030.

git-svn-id: https://develop.svn.wordpress.org/trunk@33744 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 00:05:11 +00:00
Sergey Biryukov
4bc9b3db6d Fire the check_ajax_referer action on failure as well as success. 
See [33017] for `check_admin_referer`.

props egill.
fixes #33342.

git-svn-id: https://develop.svn.wordpress.org/trunk@33743 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 23:24:39 +00:00
Sergey Biryukov
6598033243 Remove rounded corners from "Choose from the most used tags" result in Tags meta box. 
props tyxla.
fixes #31560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33742 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 23:13:30 +00:00
Sergey Biryukov
b73b9ed936 Customizer: Use existing decoupled strings in Menu Locations section. See [31941] and [31951]. 
props egill.
fixes #33416.

git-svn-id: https://develop.svn.wordpress.org/trunk@33741 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:52:45 +00:00
Scott Taylor
4a622d21fb Allow these CSS properties in KSES: min-height', 'max-height', 'min-width', 'max-width' 
Props MikeHansenMe.
Fixes #31949.


git-svn-id: https://develop.svn.wordpress.org/trunk@33739 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:45:42 +00:00
Scott Taylor
c76e3b3273 Pass option name to option and transient filters with dynamic names. 
Props Viper007Bond, SergeyBiryukov, MikeHansenMe.
Fixes #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33738 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:41:53 +00:00
wonderboymusic
20bad276e8 After [33698], wrap the time constants in a DocBlock template. 
Props egill.
Fixes #33397.


git-svn-id: https://develop.svn.wordpress.org/trunk@33737 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:20:02 +00:00
Scott Taylor
1fb94edb99 In get_home_url(), import the $pagenow global to avoid having to check if it exists before comparing against it. 
Props KalenJohnson.
See #33545.


git-svn-id: https://develop.svn.wordpress.org/trunk@33736 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:02:14 +00:00
Scott Taylor
ff7fcf5f04 In WP_Users_List_Table::single_row(), $actions is not always set before being used. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33735 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:37:50 +00:00
Scott Taylor
3b8c5529cb foreach is a statement, not a function. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:27:56 +00:00
Scott Taylor
755d109d10 Instead of [33713], allow WP_Posts_List_Table::get_bulk_actions() to check edit_posts AND delete_posts. 
Props DeBAAT.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33733 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:11:27 +00:00
Sergey Biryukov
b59d10ccac Multisite: Add 'invite_user' action that fires immediately after a user is invited to join a site, but before the notification is sent. 
props ebinnion, MikeHansenMe, DrewAPicture.
fixes #33008.

git-svn-id: https://develop.svn.wordpress.org/trunk@33732 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:47:26 +00:00
Drew Jaynes
40ce8c68fe Docs: The type for the $t_time parameter in the post_date_column_time filter docs should be string, not array. 
Props jjeaton
Fixes #33540.


git-svn-id: https://develop.svn.wordpress.org/trunk@33731 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:14:28 +00:00
Drew Jaynes
e853c467fd Docs: Document the default comment data arguments for wp_new_comment(). 
Props rachelbaker, DrewAPicture
Fixes #32369.


git-svn-id: https://develop.svn.wordpress.org/trunk@33730 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:02:51 +00:00
Scott Taylor
e1b1541932 Media: 
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.

The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.

Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467.


git-svn-id: https://develop.svn.wordpress.org/trunk@33729 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 12:12:59 +00:00
Andrew Ozz
a9b27cbc07 TinyMCE: ensure the wordpress plugin is loaded before calling _createToolbar(). 
Props hauvong, azaozz. Fixes #33393.

git-svn-id: https://develop.svn.wordpress.org/trunk@33728 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 04:37:27 +00:00
Dion Hulse
3b525395cc Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler. 
Props Otto42, dd32, peterwilsoncc
See #33423


git-svn-id: https://develop.svn.wordpress.org/trunk@33727 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 04:31:52 +00:00
Drew Jaynes
bc9e25d053 Docs: Clarify the return description for wp_create_user() to illustrate that a WP_Error object will be returned on failure. 
Props jmayhak
Fixes #33321.


git-svn-id: https://develop.svn.wordpress.org/trunk@33725 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 22:22:33 +00:00
Boone Gorges
32cd95e1c1 In WP_Query::parse_tax_query(), allow 'cat' and 'tag' querystrings to be formatted as arrays. 
See [33095] #32454 for a previous fix related to custom taxonomies.

Props Veraxus.
Fixes #33532.

git-svn-id: https://develop.svn.wordpress.org/trunk@33724 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 21:21:49 +00:00
Scott Taylor
5f3879e37c With a few modifications in wp-admin/menu.php, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare menu_position on post type registration. 
Props scribu, wonderboymusic.
Fixes #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33723 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 21:18:20 +00:00
Scott Taylor
dc577d6072 WP_Query: add changelog for the title param after [33706] 
Props dimadin.
Fixes #33074.


git-svn-id: https://develop.svn.wordpress.org/trunk@33722 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 20:09:25 +00:00
Drew Jaynes
7b7cd91984 Docs: Improve pared formatting of the oEmbed providers tables by removing the unrecognized first and last rows in the hook docs for the oembed_providers filter. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33720 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 04:37:40 +00:00
Gary Pendergast
845d31baf9 oEmbed: Remove blip.tv as an oEmbed provider, the service has been shut down. 
Vale, blip.tv.

Fixes #33522.

Props rabmalin.



git-svn-id: https://develop.svn.wordpress.org/trunk@33719 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 04:11:13 +00:00
Gary Pendergast
bf3d36e0b6 WPDB: get_table_from_query() didn't find table names with hyphens in them. 
Props dustinbolton for the fix.

Fixes #33470.



git-svn-id: https://develop.svn.wordpress.org/trunk@33718 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 00:18:49 +00:00
Drew Jaynes
83476bb77f Docs: Add a description and example to the hook docs for the navigation_markup_template filter, introduced in [33714]. 
Since the value of the filter is passed through `sprintf()` it's important to note that any filtered output needs to contain the expected specifiers.

See #31315.


git-svn-id: https://develop.svn.wordpress.org/trunk@33717 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 18:07:41 +00:00
Drew Jaynes
3969554606 Docs: Better clarify that the $post_type parameter for the get_usernumposts filter and count_user_posts() can accept either a single post type or array of post types. 
Props tyxla
See #33481. Fixes #33520.


git-svn-id: https://develop.svn.wordpress.org/trunk@33716 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 17:45:51 +00:00
Drew Jaynes
797b6c4d7c Docs: Add better documentation for all accepted values for the fields argument in get_terms(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33715 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 17:39:07 +00:00
Scott Taylor
d8ba4fde1b Add a filter to _navigation_markup: 'navigation_markup_template' 
Props joedolson, mordauk.
Fixes #31315.


git-svn-id: https://develop.svn.wordpress.org/trunk@33714 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 16:33:25 +00:00
Scott Taylor
9596ae0993 Posts List Table: 
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33713 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 16:27:44 +00:00
Drew Jaynes
dfa9da5356 Docs: Fix a minor alignment issue in the DocBlock for get_pagenum_link(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33712 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 07:18:19 +00:00
Boone Gorges
b01b3be23e In wp_delete_term(), the $deleted_term object passed to filters should be generated before term relationships are deleted. 
This allows the `count` property to reflect the pre-delete state of affairs,
rather than always being 0.

Props nicholas_io.
Fixes #33485.

git-svn-id: https://develop.svn.wordpress.org/trunk@33711 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 19:42:30 +00:00
Boone Gorges
6c3449b710 Pass the $public_only value to 'get_usernumposts' filter. 
[32523] introduced the `$public_only` parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.

This changeset also fixes an incorrect variable name in the docblock for
the same filter.

Props swisspidy, tmatsuur.
Fixes #33481 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33710 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 18:58:18 +00:00
Scott Taylor
a679368d8b Add some JS Docs for Customizer. 
Props ericlewis.
See #33503.


git-svn-id: https://develop.svn.wordpress.org/trunk@33709 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 17:23:37 +00:00
Scott Taylor
7e894153a4 In wp_insert_user(), add a filter: insert_user_meta, to filter a user's meta values and keys before the user is created or updated. 
Props tharsheblows, chriscct7, DrewAPicture.
Fixes #31549.


git-svn-id: https://develop.svn.wordpress.org/trunk@33708 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 17:11:42 +00:00
Scott Taylor
36a9be2af5 In wp_sanitize_redirect(), don't eat @ characters. According to RFC 3986, "@" is a perfectly valid character in a URL path or query string. 
Adds unit test.

Props markjaquith.
Fixes #18818.


git-svn-id: https://develop.svn.wordpress.org/trunk@33707 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 17:04:17 +00:00
Scott Taylor
dc48f3d795 Query: 
Add a query var, `title`, that allows you to query posts by `post_title`. To accomplish this now, you have to do something like:

{{{
$tacos = get_posts( [
  'post_type' => 'taco',
  's' => $name,
  'exact' => true,
  'sentence' => true,
  'post_status' => 'publish',
  'fields' => 'ids',
  'posts_per_page' => 1
] );
}}}

Adds unit tests.

Fixes #33074.


git-svn-id: https://develop.svn.wordpress.org/trunk@33706 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 16:58:21 +00:00
Scott Taylor
a70e0183e5 Ensure that attachment_url_to_postid() matches cross-scheme when front-end and back-end schemes are different. 
Adds unit test.

Props welcher.
Fixes #33109.


git-svn-id: https://develop.svn.wordpress.org/trunk@33705 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 16:38:09 +00:00
Scott Taylor
e76b48a26c update-core.php help docs, update string to include translations: themes, plugins, and translations 
Props netweb, DrewAPicture.
Fixes #28201.


git-svn-id: https://develop.svn.wordpress.org/trunk@33704 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 16:24:58 +00:00
Scott Taylor
326b67c0aa In wpdb::get_col_length(), breaks are not necessary when a case returns 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33701 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 18:40:55 +00:00
Scott Taylor
5d494bae12 Doc block for_wp_specialchars: $quote_style can also be string ('single' or 'double') 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33700 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 18:35:31 +00:00
Scott Taylor
a14be1fffa In _WP_Editors::editor_settings(), $first_run is unused. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33699 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 18:29:31 +00:00
Aaron Jorbin
3b24c024b5 Add new constant MONTH_IN_SECONDS and expand time convenience documentation. 
The "month" isn't really a month.  It's a WordPress Month. As the docs make clear, it's not about accuracy as much as it about convenience.  This adds a missing step in the time convenience constants. 

Props egill
Fixes #33397




git-svn-id: https://develop.svn.wordpress.org/trunk@33698 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 18:15:52 +00:00
Scott Taylor
e4f8047716 In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33697 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 18:12:56 +00:00
Weston Ruter
d40b6eab66 Widgets: Switch back to using array_key_exists() instead of isset() for widget instance existence check. 
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.

See #32474.
Fixes #33442.


git-svn-id: https://develop.svn.wordpress.org/trunk@33696 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 18:08:53 +00:00
Scott Taylor
a1e5332489 Make 'Docs Committer' translatable. 
Props dimadin. 
Fixes #33424.


git-svn-id: https://develop.svn.wordpress.org/trunk@33695 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:46:54 +00:00
Scott Taylor
9e784dd59f Clarify doc entry for _wp_customize_include() 
Props ericlewis. 
Fixes #33488.


git-svn-id: https://develop.svn.wordpress.org/trunk@33694 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:44:11 +00:00
Scott Taylor
ab71eb93b1 When createing "Sample Page" on install, comments should be closed. 
Props macmanx. 
Fixes #33490.


git-svn-id: https://develop.svn.wordpress.org/trunk@33693 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:41:16 +00:00
Scott Taylor
7dd261ce61 Comment List Tables: 
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33692 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:25:06 +00:00
Drew Jaynes
e6466911d7 Docs: Add a changelog entry for the $post_type parameter added to the restrict_manage_posts hook in [33644]. 
Props pavelevap
Fixes #17891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33691 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 16:11:31 +00:00
Drew Jaynes
31e802293c Docs: Fix a typo in the DocBlock description for _get_additional_user_keys(), introduced in [33687]. 
Props dimadin
See #29120.


git-svn-id: https://develop.svn.wordpress.org/trunk@33690 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 16:00:35 +00:00
Helen Hou-Sandi
961dd71cf3 List tables: Allow filtering of hidden and default hidden columns. 
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.

props Compute, MikeHansenMe, chriscct7.
fixes #32499.


git-svn-id: https://develop.svn.wordpress.org/trunk@33689 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 15:31:30 +00:00
Dion Hulse
466500743f WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33688 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 11:42:04 +00:00
Drew Jaynes
143c3e8a87 Docs: Clarify the DocBlock summary and add a description and return description for _get_additional_user_keys(). 
As noted in the description, returned keys being set is dependent on the existence of those keys in user meta at the point where `_get_additional_user_keys()` is called in `wp_update_user()`.

Fixes #29120.


git-svn-id: https://develop.svn.wordpress.org/trunk@33687 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 05:32:53 +00:00
Drew Jaynes
e803952278 Docs: Fix some minor inline documentation syntax issues in the hook docs for the post_edit_category_parent_dropdown_args filter, introduced in [33682]. 
See #32246. See #33026.


git-svn-id: https://develop.svn.wordpress.org/trunk@33686 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:54:00 +00:00
Drew Jaynes
a65c2e068a Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing. 
Fixes #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33685 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:12:45 +00:00
Drew Jaynes
c53fe2779e Docs: Add missing @access tags to properties and methods in wp-admin/includes/class-wp-upgrader. 
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33684 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:04:23 +00:00
Drew Jaynes
3721940e0f Docs: Correct a typo in the summary for the Theme_Upgrader->bulk property. 
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33683 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 03:14:35 +00:00
Boone Gorges
57592ef976 Filter the arguments passed to wp_dropdown_categories() in the Categories post edit metabox. 
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.

git-svn-id: https://develop.svn.wordpress.org/trunk@33682 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 01:27:15 +00:00
Boone Gorges
c1b8f1f72a In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute. 
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the `'selected'`
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.

We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.

Fixes #33452 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33681 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 01:10:34 +00:00
Drew Jaynes
f35fde4e35 Docs: Standardize @deprecated tag formatting in the DocBlock for the logIO() function. 
Props Alphawolf.
Fixes #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33680 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:43:02 +00:00
Drew Jaynes
6db612790d Docs: Standardize @deprecated tag formatting in the DocBlocks for several wpdb methods. 
Props Alphawolf.
See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33679 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:41:07 +00:00
Drew Jaynes
2cfd34e85e Docs: Standardize @deprecated tag formatting in the DocBlock for WP_Object_Cache:reset(). 
Props Alphawolf.
See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33678 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:38:45 +00:00
Drew Jaynes
d83fcf8e9c Docs: Standardize @deprecated tag formatting in the DocBlock for wp_xmlrpc_server::login_pass_ok(). 
Props Alphawolf.
See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33677 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:37:16 +00:00
Drew Jaynes
a66a94a149 Docs: Standardize @deprecated tag formatting and add missing summaries to deprecated functions in wp-includes/ms-deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33676 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:35:30 +00:00
Drew Jaynes
b09cedbd11 Docs: Standardize @deprecated tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 
Props Alphawolf for the initial patch
Props DrewAPicture

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33675 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:25:41 +00:00
Drew Jaynes
5c0b568ea1 Docs: Standardize @deprecated tag formatting for deprecated functions in wp-includes/pluggable-deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture.

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33674 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:14:44 +00:00
Drew Jaynes
6374a86e6c Docs: Standardize @deprecated tag formatting and add missing DocBlock summaries to deprecated functions in wp-includes/deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture.

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33673 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:10:20 +00:00
Scott Taylor
3b1e7ba1e0 After [33666], fix broken sprintf cruff. 
See #17609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33672 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:36:03 +00:00
Drew Jaynes
8edff9c979 Docs: Standardize @deprecated tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php. 
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.

Props Alphawolf for the initial patch.
See #28806


git-svn-id: https://develop.svn.wordpress.org/trunk@33671 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:22:26 +00:00
Drew Jaynes
5e6f651daf Docs: Add a missing summary to the DocBlock for wp_media_upload_handler(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33670 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:00:42 +00:00
Scott Taylor
f804d9a91d In wp_get_attachment_link(), accept an id or WP_Post as the first parameter. 
Props several27, DrewAPicture.
Fixes #33277.


git-svn-id: https://develop.svn.wordpress.org/trunk@33669 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 20:31:34 +00:00
Drew Jaynes
0af6d275b0 Docs: Clarify the different return conditions in the DocBlock for WP_List_Table->handle_row_actions(). 
This clarification follows the introduction of primary columns in 4.3. See #33313.

Props morganestes.
Fixes #33436.


git-svn-id: https://develop.svn.wordpress.org/trunk@33668 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 20:21:45 +00:00
Scott Taylor
695560bf58 In WP_Posts_List_Table::inline_edit(), check that $post_formats[0] is an array before traversing. 
Props DrewAPicture.
Fixes #33025.



git-svn-id: https://develop.svn.wordpress.org/trunk@33667 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 20:18:35 +00:00
Scott Taylor
98de66207f Custom Post Types: 
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end

When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.

Custom post types with `public_queryable` set to `false` are not viewable on the front end. 
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.

This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:

`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`

If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.

I am in search of edge cases, so this shall land.

Props wonderboymusic, DrewAPicture.
See #17609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33666 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 19:39:57 +00:00
Drew Jaynes
ab8417702e Docs: Correct the phpDoc type to a boolean for the $single parameter in the get_{$meta_type}_metadata hook docs. 
Props dlh.
Fixes #33451.


git-svn-id: https://develop.svn.wordpress.org/trunk@33665 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 19:35:43 +00:00
Drew Jaynes
ad2afcd0d9 Docs: Mark the $notify parameter in the DocBlock for wp_new_user_notification() as optional, and provide additional context on the difference between the accepted values. 
See [33620] and [33023] for background.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33664 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 18:26:00 +00:00
Scott Taylor
25004acaa6 After [33662], remove unused var. 
See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33663 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 17:18:51 +00:00
Scott Taylor
28e0ad2de1 Comment List Tables: 
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`

See #11200.



git-svn-id: https://develop.svn.wordpress.org/trunk@33662 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 16:35:21 +00:00
Dominik Schilling (ocean90)
3b4c1e7dd6 WordPress 4.3 has just passed 2,222,222 downloads. 
(Fix typo in [33653].)

git-svn-id: https://develop.svn.wordpress.org/trunk@33661 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 15:59:30 +00:00
Scott Taylor
89ecad8808 JSHint after [33655]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33660 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 06:30:48 +00:00
Scott Taylor
4b746c4b4e Deprecate post_permalink() (Introduced in 1.0, already had a deprecated argument in 1.3), which just wraps get_permalink() and was only used by XML-RPC in 4 places. 
Props solarissmoke.
Fixes #16982.


git-svn-id: https://develop.svn.wordpress.org/trunk@33659 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 06:24:00 +00:00
Scott Taylor
8528ff2ab4 Ensure that feeds are served with the proper Content-Type HTTP header. 
Props stevenkword.
Fixes #32024.


git-svn-id: https://develop.svn.wordpress.org/trunk@33658 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 06:09:28 +00:00
Scott Taylor
64944b7a87 Comments List Table: 
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises

Fixes #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33657 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 05:53:41 +00:00
Scott Taylor
88e804f6c0 Comments List Table: 
* Properly increment/decrement approved/pending bubbles in `response` column

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33656 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 04:01:35 +00:00
Scott Taylor
9b6f5b6270 Comments List Table: 
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33655 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 02:50:20 +00:00
Scott Taylor
cb9f80009f Comments shouldn't have more than one _wp_trash_meta_status entry. When deleting _wp_trash_meta_status, also delete _wp_trash_meta_time. 
See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33654 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 02:44:39 +00:00
Boone Gorges
5e9a216cf7 Introduce post_name__in parameter for WP_Query. 
Props enshrined.
Fixes #33065.

git-svn-id: https://develop.svn.wordpress.org/trunk@33653 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 02:18:05 +00:00
Boone Gorges
9bb010f2a1 wp_update_term() should return a true integer for 'term_taxonomy_id'. 
Props ipm-frommen.
Fixes #32876.

git-svn-id: https://develop.svn.wordpress.org/trunk@33652 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 19:32:04 +00:00
Konstantin Obenland
96437b6d57 Themes: Prevent short descriptions from wrapping version info. 
Props mehulkaklotar for initial patch.
Fixes #33248.



git-svn-id: https://develop.svn.wordpress.org/trunk@33651 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 19:09:20 +00:00
Konstantin Obenland
2ec26f617f Themes: Open preview when requesting a single theme in the installer. 
Props kraftner, obenland.
Fixes #28735.



git-svn-id: https://develop.svn.wordpress.org/trunk@33650 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 18:53:36 +00:00
Dion Hulse
f0ec4d5a7b Upgrades: When upgrading via FTP, use LIST -a to detect if a file exists. 
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.

Props jcroucher.
Fixes #28013.


git-svn-id: https://develop.svn.wordpress.org/trunk@33648 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 12:37:56 +00:00
Dion Hulse
63fd3a32dd Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621]. 
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33646 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 11:30:42 +00:00
Dion Hulse
26e7094951 Fix PHP notice after [33492] when updating themes. 
Props bobbingwide.
See #33208.
Fixes #33427.


git-svn-id: https://develop.svn.wordpress.org/trunk@33645 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 10:34:51 +00:00
Scott Taylor
5cbc7a706d The 'restrict_manage_posts' hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass $post_type. 
Props sunnyratilal, scribu.
Fixes #17891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33644 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 06:22:40 +00:00
Scott Taylor
80b6f4efca Playlists, for .wp-playlist-item-title elements: move the curly quotes to CSS pseudo-element content, making them easier to override or remove. 
Fixes #33391.


git-svn-id: https://develop.svn.wordpress.org/trunk@33643 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 05:50:23 +00:00
Scott Taylor
f629e70da3 WP_Embed::maybe_run_ajax_cache() doesn't hook to pages, because it only happens on 'edit_form_advanced', not 'edit_page_form'. Make sure it runs for pages as well. This was probably not intentional, see [29557]. 
Fixes #32418.


git-svn-id: https://develop.svn.wordpress.org/trunk@33642 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 05:39:31 +00:00
Scott Taylor
f8d13a7c86 Replace some hyphens with &mdash;s in admin help tabs. 
Props pixolin.
Fixes #30605.


git-svn-id: https://develop.svn.wordpress.org/trunk@33641 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 04:52:17 +00:00
Scott Taylor
4c3f8dac54 Correct punctuation/case for inline comment in async-upload.php 
Props chriscct7.
Fixes #33408.


git-svn-id: https://develop.svn.wordpress.org/trunk@33640 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 23:34:49 +00:00
Scott Taylor
69338b3fa7 Correct typo in doc block for WP_Filesystem_ftpsockets::rmdir 
Props Toro_Unit.
Fixes #33255.


git-svn-id: https://develop.svn.wordpress.org/trunk@33639 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 23:33:00 +00:00
Scott Taylor
9b37cc043c Correct typo in JSDoc for wp.updates.decrementCount 
Props mt8.biz.
Fixes #33363.


git-svn-id: https://develop.svn.wordpress.org/trunk@33638 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 21:46:19 +00:00
Scott Taylor
32a2e5ed48 Fix case type in docs for get_children(). 
Props bobbingwide.
Fixes #33364.


git-svn-id: https://develop.svn.wordpress.org/trunk@33637 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 21:38:25 +00:00
Helen Hou-Sandi
e048854dc1 Trunk is now 4.4-alpha. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33636 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 19:31:23 +00:00
Konstantin Obenland
08a58ff927 WordPress 4.3 
git-svn-id: https://develop.svn.wordpress.org/trunk@33633 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 18:01:25 +00:00
Konstantin Obenland
6367a427f4 About: Use actual locale and not subtitle debug cruft. 
H/t dimadin.

See #32929.


git-svn-id: https://develop.svn.wordpress.org/trunk@33632 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 17:06:37 +00:00
Konstantin Obenland
03bc4e6299 About: Update release video to use the correct ID. 
Also adjusts locale handling to work with Videopress' subtitle implementation.

Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33631 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 17:01:50 +00:00
Boone Gorges
48beba441b When generating a fallback post_name using the post ID, wp_insert_post() should clear the post cache immediately. 
If the post cache is not cleared at this point, the cache can become stale
for operations performed before the cache is cleared later in the function.
Specifically, the generation of a `guid` for new posts can use stale data,
resulting in non-unique values. [33262] introduced a call to `get_post()`
that introduced just such an invalidation problem.

Fixes #5305.

git-svn-id: https://develop.svn.wordpress.org/trunk@33630 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 02:50:23 +00:00
Konstantin Obenland
8f23b0db45 4.3-RC3-33629 
git-svn-id: https://develop.svn.wordpress.org/trunk@33629 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 21:45:42 +00:00
Konstantin Obenland
c992631099 4.3-RC3 
git-svn-id: https://develop.svn.wordpress.org/trunk@33628 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 21:39:05 +00:00
Dominik Schilling (ocean90)
0ec540b946 Pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33627 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 21:38:24 +00:00
Dominik Schilling (ocean90)
f545d74256 Upgrade: Update $_old_files for 4.3. 
fixes #33394.

git-svn-id: https://develop.svn.wordpress.org/trunk@33626 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 20:23:06 +00:00
Konstantin Obenland
e7c16b2d0a Passwords: Use keyup event to prevent IE8's misinterpretation of propertychange. 
Props adamsilverstein, peterwilsoncc.
Fixes #33385.



git-svn-id: https://develop.svn.wordpress.org/trunk@33625 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 18:45:33 +00:00
Andrew Ozz
b30fcd7597 Fix creating of extra <br /> tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future. 
Props valendesigns, azaozz. Fixes #33377.

git-svn-id: https://develop.svn.wordpress.org/trunk@33624 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 17:35:58 +00:00
Helen Hou-Sandi
3b1e1f0376 List tables: Yet more primary column fallbacks. 
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.


git-svn-id: https://develop.svn.wordpress.org/trunk@33623 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 15:37:03 +00:00
Konstantin Obenland
eea1678cd3 Editor: Exclude shift from modifier keys when handling spacebar shortcuts. 
Patterns that activate on enter are still canceled with any modifier active.

Props azaozz.
Fixes #33382.



git-svn-id: https://develop.svn.wordpress.org/trunk@33622 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 14:50:42 +00:00
Boone Gorges
e33ff607e6 Don't run term-splitting routine on new installations. 
Props pento.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33621 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 14:28:03 +00:00
Konstantin Obenland
e7a203cdf2 Passwords: Restore second parameter for wp_new_user_notification(). 
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.



git-svn-id: https://develop.svn.wordpress.org/trunk@33620 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 14:24:43 +00:00
Boone Gorges
9c70cea98f Don't suspend cache invalidation when running term splitting batch routine. 
`wp_suspend_cache_invalidation()` was originally added to increase performance,
but the switch to batch processing in [33615] mitigates serious performance
concerns.

As a precaution against timeouts, the batch size has been reduced from 20 to 10.

Props Chouby.
See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33619 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-15 19:24:42 +00:00
Helen Hou-Sandi
7abf08a52c Menu customizer: Ensure the search results section is full height. 
fixes #33375.


git-svn-id: https://develop.svn.wordpress.org/trunk@33618 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-14 21:31:23 +00:00
Weston Ruter
a4bbc4454c Customize: Fix keyboard accessibility for toggling screen options and contextual help. 
Also fix layout of search results in mobile.

Props valendesigns, afercia, adamsilverstein.
Fixes #33184.


git-svn-id: https://develop.svn.wordpress.org/trunk@33617 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-14 21:22:57 +00:00
Boone Gorges
f18355e66e Term splitting routine should be run in a separate process, triggered via wp-cron. 
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33615 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-14 03:58:41 +00:00
Dominik Schilling (ocean90)
23eaa36145 Capabilities: Fall back to the edit_posts capability for orphaned comments. 
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.

git-svn-id: https://develop.svn.wordpress.org/trunk@33614 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-13 22:30:26 +00:00
Konstantin Obenland
ce531d8723 About: Third pass at 4.3 about page: 
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33613 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-13 22:10:06 +00:00
Scott Taylor
df480edb24 After [33325], supply a missing post_type in ->mw_editPost(). 
Add unit test.

Props ocean90.
Fixes #20662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33612 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-13 15:27:57 +00:00
Boone Gorges
ee67bd08f9 When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained. 
Props boonebgorges, dd32.
Fixes #33187.

git-svn-id: https://develop.svn.wordpress.org/trunk@33611 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-12 14:06:21 +00:00
Weston Ruter
80bc70fc4b Customize: Fix layout issues in panels and sections when resizing and autofocusing. 
Also reverts [33157] which is no longer needed.

Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220.


git-svn-id: https://develop.svn.wordpress.org/trunk@33610 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-11 23:55:40 +00:00
Andrew Ozz
e509984261 Fix paste typos in upgrade.php. 
Props tellyworth. Fixes #33206.

git-svn-id: https://develop.svn.wordpress.org/trunk@33609 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-11 23:43:29 +00:00
Konstantin Obenland
14b7ed65bb After [32948]: Account for the use of paginate_links() with table navigation markup. 
Props afercia.
Fixes #32253.



git-svn-id: https://develop.svn.wordpress.org/trunk@33608 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-11 20:42:18 +00:00
Konstantin Obenland
8f37374c3d Site Icon: Improvements to Site Icon API. 
* Only call `get_blog_option()` when there is a blog id and we're in Mulitsite. If there is no blog id the request is for the current blog.
* Check return value of `wp_get_attachment_image_src()` before getting the URL since it could be `false`.
* Use `{bool}` rather than `!!` to return a boolean value.

Props MikeHansenMe, obenland.
Fixes #33326.



git-svn-id: https://develop.svn.wordpress.org/trunk@33606 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-11 16:24:07 +00:00
Helen Hou-Sandi
b9dd879f42 Site icon: Rearrange function parameters to avoid frequently passing empty values. 
props obenland.
fixes #33325.


git-svn-id: https://develop.svn.wordpress.org/trunk@33605 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 20:14:35 +00:00
Konstantin Obenland
a367a1b67b Customize: Limit styles for menu's reorder button to the nav_menu control. 
This prevents it from bleeding into other controls, misaligning their buttons.
Selectors use a class now too, which is preferable over ids.

Fixes #33260.



git-svn-id: https://develop.svn.wordpress.org/trunk@33604 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 19:35:57 +00:00
Helen Hou-Sandi
19f9dd3b72 Network admin: Internationalize some existing strings that were missed in [33186]. 
Also adds the trailing slash to the `get_home_url()` calls.

props johnbillion.
fixes #33317.


git-svn-id: https://develop.svn.wordpress.org/trunk@33603 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 18:10:11 +00:00
Helen Hou-Sandi
0999b0182b Customizer: Rename WP_New_Menu_Customize_Control to WP_Customize_New_Menu_Control for consistency. 
props DrewAPicture.
fixes #33324.


git-svn-id: https://develop.svn.wordpress.org/trunk@33602 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 18:06:01 +00:00
dd32
0c29101892 Function documentation: Fix a broken docbock introduced with [32642]. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@33601 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 10:49:02 +00:00
ocean90
239759914f Shortcodes: Trim whitespace after sanitizing the shortcode output. 
props Ankit K Gupta, obenland, miqrogroove.
fixes #33259.

git-svn-id: https://develop.svn.wordpress.org/trunk@33600 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 20:48:02 +00:00
Dominik Schilling (ocean90)
3f7b1ca2ff Customizer: Remove obsolete .control-panel-back and .customize-overlay-close buttons. 
props afercia, ocean90.
see #31336.
fixes #33229.

git-svn-id: https://develop.svn.wordpress.org/trunk@33599 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 18:59:34 +00:00
Dominik Schilling (ocean90)
6741897dd0 List tables: Adjust width of Quick Edit labels for longer translations. 
props Clorith, SergeyBiryukov, ocean90.
fixes #33212.

git-svn-id: https://develop.svn.wordpress.org/trunk@33598 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 18:54:37 +00:00
Dion Hulse
7ef82c235a Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled). 
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206


git-svn-id: https://develop.svn.wordpress.org/trunk@33597 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 02:21:11 +00:00
Dominik Schilling (ocean90)
2d6c10b842 Customizer: Restore Shift + Clicking on widgets to open the widgets panel. 
Includes an alternative for jQuery UI's `:focusable` selector because it has an ancestor visibility requirement, see https://github.com/jquery/jquery-ui/pull/1583.

props westonruter.
fixes #33258.

git-svn-id: https://develop.svn.wordpress.org/trunk@33596 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-08 09:36:55 +00:00
Konstantin Obenland
c03388bd9d Install: Adjust th padding to align with tds. 
Props Ankit K Gupta for initial patch.
Fixes #33280.



git-svn-id: https://develop.svn.wordpress.org/trunk@33595 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-07 22:09:41 +00:00
Dion Hulse
7a35bff916 Fix do_shortcode('<[shortcode]') edge case. 
Props miqrogroove.
Merges [33499] trunk.
See #33116.


git-svn-id: https://develop.svn.wordpress.org/trunk@33594 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-07 02:49:31 +00:00
John Blackbourn
1939742e32 Remove all existing internal feature pointers. 
Fixes #33289
Props obenland, ocean90, SergeyBiryukov


git-svn-id: https://develop.svn.wordpress.org/trunk@33593 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-07 00:58:10 +00:00
Ella Iseulde Van Dorpe
994b1d9a5b TinyMCE: fix inline toolbar repositioning for inline editors 
Fixes #33286.


git-svn-id: https://develop.svn.wordpress.org/trunk@33592 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-06 21:34:16 +00:00
Mark Jaquith
7e4a72b9bc Only use a bare URL when the link text field is used. 
Fixes bug that would remove images on edit, in some circumstances.

fixes #33293
props azaozz

git-svn-id: https://develop.svn.wordpress.org/trunk@33591 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-06 20:57:31 +00:00
Mark Jaquith
3d15757198 Move media hooks out of admin-filters.php as sometimes editors are used on the front end. 
fixes #33257
props wonderboymusic

git-svn-id: https://develop.svn.wordpress.org/trunk@33590 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-06 20:39:35 +00:00
Dominik Schilling (ocean90)
f29b25e104 Comments: Update help text for new comment bubbles. 
props kraftbj.
fixes #33256.

git-svn-id: https://develop.svn.wordpress.org/trunk@33589 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-06 08:02:53 +00:00
Sergey Biryukov
1dcb93b541 wpLink: Make sure the link wrapper is the last element in the body, otherwise the inline editor toolbar may show up above the backdrop. 
props azaozz.
fixes #33268.

git-svn-id: https://develop.svn.wordpress.org/trunk@33588 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-06 02:16:54 +00:00
Jeremy Felt
1872e759ea Multisite: Use single URL input when editing sites in a subdirectory configuration 
In [32759], we adjusted `site-info.php` to display a single input for a site's full URL if the network was configured for subdomains. We also enforced path only editing for non-subdomain networks, which is a regression in expected behavior.

The full URL of a site can now be edited in both subdomain and subdirectory configurations.

Props @michaelryanmcneill.
Fixes #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@33586 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-05 03:33:53 +00:00
Weston Ruter
fb62349c77 Customizer: Restore default fallback_cb arg for wp_nav_menu() calls in customizer preview. 
Props ocean90, westonruter.
Fixes #33218.


git-svn-id: https://develop.svn.wordpress.org/trunk@33585 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-04 21:56:57 +00:00
Ella Iseulde Van Dorpe
3d88983860 TinyMCE: wplink: fix WPLinkPreview for multiple editors 
Fixes #33264.


git-svn-id: https://develop.svn.wordpress.org/trunk@33584 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-04 21:41:34 +00:00
Dominik Schilling (ocean90)
e8b5345004 WordPress 4.3-RC2-33572. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33572 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-04 11:47:49 +00:00
Dominik Schilling (ocean90)
7fc5d6e2a4 WordPress 4.3-RC2. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33571 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-04 11:43:07 +00:00
Dominik Schilling (ocean90)
9f3217c8eb Multisite mails: Initialize $current_user before accessing $current_user->user_login. 
props Toro_Unit.
see #31217.
fixes #33254.

git-svn-id: https://develop.svn.wordpress.org/trunk@33569 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-04 11:38:52 +00:00
Ella Iseulde Van Dorpe
aaf15cdde8 TinyMCE: wptextpattern: trim whitespace 
Props iseulde and azaozz.
Fixes #33246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33563 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-03 22:06:25 +00:00
Dominik Schilling (ocean90)
9d8768f442 Comments: IDs are integers. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33555 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-03 21:37:26 +00:00
Dominik Schilling (ocean90)
ad74207fa7 Heartbeat: Ensure post locks are released. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33542 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-03 21:11:35 +00:00
Dominik Schilling (ocean90)
d834719f34 Nav menus: Adjust redundant titles in accessibility helpers. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33540 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-03 21:03:59 +00:00
Dominik Schilling (ocean90)
dd5471dab2 Customizer: Use hash_equals() for widgets. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33535 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-03 20:56:56 +00:00
Andrew Ozz
86e10358fd TinyMCE: fix initializing the editor on switching Text => Visual when the Text editor is loaded first. 
Props stuartshields, peterwilsoncc, netweb, azaozz. Fixes #33192.

git-svn-id: https://develop.svn.wordpress.org/trunk@33527 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-02 20:00:56 +00:00
Dominik Schilling (ocean90)
2ebc63579c Fix PHP notice after [33492]. 
props jesin.
see #33178.
fixes #33208.

git-svn-id: https://develop.svn.wordpress.org/trunk@33519 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-30 19:58:43 +00:00
Dominik Schilling (ocean90)
038e2e2e4f Editor: word count: Remove indentation from the translator comment. 
Avoids a duplicate comment in the POT file.

see #30966.

git-svn-id: https://develop.svn.wordpress.org/trunk@33517 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-30 17:08:01 +00:00
Andrew Ozz
2dfd08f05a TinyMCE: update to 4.2.3, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt. 
Fixes #33203.

git-svn-id: https://develop.svn.wordpress.org/trunk@33516 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-30 17:06:23 +00:00
Helen Hou-Sandi
4f2573a707 Remove debug cruft from [33511]. 
see #32710.


git-svn-id: https://develop.svn.wordpress.org/trunk@33515 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:52:46 +00:00
Konstantin Obenland
37605bdd38 4.3-RC1-33514 
git-svn-id: https://develop.svn.wordpress.org/trunk@33514 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:52:05 +00:00
Konstantin Obenland
59518e1625 4.3-RC1 
git-svn-id: https://develop.svn.wordpress.org/trunk@33513 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:46:05 +00:00
Ella Iseulde Van Dorpe
18e5891539 TinyMCE: wptextpattern: stop propagation on undo 
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@33512 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:44:08 +00:00
Helen Hou-Sandi
3fd1376418 Menu customizer: More clearly separate search results from available items. 
Available items now fade from view while you're searching, and there is an explicit way to clear search results. No results gives a better message, though still brief this time around.

props valendesigns, designsimply, DH-Shredder, helen.
fixes #32710.


git-svn-id: https://develop.svn.wordpress.org/trunk@33511 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:39:54 +00:00
Konstantin Obenland
63395e7652 Customizer: Improve focus styles for screen option and help toggles. 
Props ocean90.
See #33181.



git-svn-id: https://develop.svn.wordpress.org/trunk@33510 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:24:17 +00:00
Andrew Ozz
46f0c4d4e0 TinyMCE: remove the spare string for the keyboard shortcuts modal. 
See #31441.

git-svn-id: https://develop.svn.wordpress.org/trunk@33509 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:19:56 +00:00
Ella Iseulde Van Dorpe
662355f30c TinyMCE: wptextpattern: undo on esc after enter 
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@33508 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:11:42 +00:00
Ella Iseulde Van Dorpe
976687bc59 TinyMCE: wptextpattern: reorder undo 
After formatting on enter, undo should undo the formatting first, then undo the new line.

See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@33507 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 22:48:02 +00:00
Dominik Schilling (ocean90)
709cb42ab3 Customizer: Switch buttons to match the focus order with the visual order. 
props afercia.
see #33181.

git-svn-id: https://develop.svn.wordpress.org/trunk@33505 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 22:09:24 +00:00
Andrew Ozz
362bb806cd TinyMCE: fix (again) the text in the keyboard shortcuts modal for the changed patterns. 
See #31441.

git-svn-id: https://develop.svn.wordpress.org/trunk@33504 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 21:53:22 +00:00
Dominik Schilling (ocean90)
0bff13a8fd Customizer: This circular focus thing is hot. 
see #33181.

git-svn-id: https://develop.svn.wordpress.org/trunk@33503 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 21:50:27 +00:00
Dominik Schilling (ocean90)
55b1dd3411 Nav menus: Make the selector for the edit menu item link more specific. Prevents clashing with other elements which have the same class. 
fixes #33129.

git-svn-id: https://develop.svn.wordpress.org/trunk@33502 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 21:29:54 +00:00
Andrew Ozz
b1933f53dc TinyMCE: fix the text in the keyboard shortcuts modal for the changed patterns. 
See #31441.

git-svn-id: https://develop.svn.wordpress.org/trunk@33501 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 21:06:13 +00:00
Weston Ruter
1e2fdf5bc8 Customizer: Stack the menu gear icon below the help icon for more text breathing room. 
Fixes #33181.


git-svn-id: https://develop.svn.wordpress.org/trunk@33500 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 20:22:18 +00:00
Konstantin Obenland
fbfcb87b9d About: Second pass at 4.3 about page. 
Adds images and videos for major and minor features.
Restores a mangled placeholder in Formatting Shortcuts description.

Assets still need to be moved to the .org CDN once deemed final.

Props ryelle, melchoyce, helen.
See #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33498 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:57:00 +00:00
Andrew Ozz
f0935052c2 Press This: properly add Open Sans to the editor, using the mce_css filter. 
See #26072. Fixes #33189.

git-svn-id: https://develop.svn.wordpress.org/trunk@33497 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:37:06 +00:00
Weston Ruter
05c32013d7 Customizer: Update nav_menu_locations[...] controls to remove placeholder menus from the dropdown options upon Save & Publish. 
See #32814.
Fixes #33176.


git-svn-id: https://develop.svn.wordpress.org/trunk@33496 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:33:07 +00:00
Mark Jaquith
37aa0574c4 Persist (and mask) the password on the install screen if the install does not proceed due to errors. 
If you forget or enter an invalid username/e-mail, the password choosing shouldn't start over.

fixes #33162

git-svn-id: https://develop.svn.wordpress.org/trunk@33495 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:21:26 +00:00
Mark Jaquith
4149ad8845 Make the multisite new user messages reflect that reset links are sent, not passwords. 
fixes #33175

git-svn-id: https://develop.svn.wordpress.org/trunk@33494 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:03:09 +00:00
Weston Ruter
70f461ed61 Customizer: Remove redundant translated string. 
Props obenland.
Fixes #33183.


git-svn-id: https://develop.svn.wordpress.org/trunk@33493 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 18:53:00 +00:00
Dominik Schilling (ocean90)
faac72a070 Themes: Remove legacy theme preview. 
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.

git-svn-id: https://develop.svn.wordpress.org/trunk@33492 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 18:35:40 +00:00
Weston Ruter
27c7e27d8b Twenty Fifteen: Only re-initialize the main navigation in the Customizer when it is specifically updated. 
* Fix a bug where updating the social menu links would cause the main navigation to get its toggle-expanded buttons duplicated.
* Persist any existing submenu expanded states on the updated menu. 
* Improve naming of `customize-preview-menu-refreshed` event param from `wpNavArgs` to `wpNavMenuArgs` (old name is retained and marked as deprecated).

Fixes #33177.


git-svn-id: https://develop.svn.wordpress.org/trunk@33491 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 18:12:26 +00:00
Helen Hou-Sandi
00baf4adea Comments list table: Display that cute lil comment bubble. 
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.

props obenland. fixes #33149.


git-svn-id: https://develop.svn.wordpress.org/trunk@33490 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 18:07:03 +00:00
Helen Hou-Sandi
6b1733c01c Ensure the caption shortcode outputs a valid HTML ID. 
fixes #33179.


git-svn-id: https://develop.svn.wordpress.org/trunk@33489 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 17:58:06 +00:00
Weston Ruter
dbcb95c022 Customizer: Ensure that all existing menus are shown in the Custom Menu widget's dropdown. 
* Ensure that a Custom Menu widget selecting a newly-inserted menu gets updated to use the new menu ID upon Save & Publish.
* Dynamically update the visibility of the Custom Menu widget's "no menus" message when the number of menus changes between 0 and 1+.
* Send all dirty Customized settings in `update-widget` Ajax request and `preview()` them so that the widget update/form callbacks have access to any data dependencies in the current Customizer session (such as newly created unsaved menus).
* Update link in Custom Menu widget to point to Menus panel as opposed to Menus admin page, when in the Customizer.
* Fix an issue with extra space at top immediately after creating new menu.
* Fix doubled `update-widget` Ajax requests when changing select dropdown; prevent initial from being aborted.
* Add missing `wp_get_nav_menus()` hooks to preview Customizer updates/inserts for `nav_menu` settings; includes tests.
* Update `wp_get_nav_menu_object()` to allow a menu object to be passed in (and thus passed through).

Props westonruter, adamsilverstein.
Fixes #32814.


git-svn-id: https://develop.svn.wordpress.org/trunk@33488 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 16:02:08 +00:00
Dominik Schilling (ocean90)
dec1b4da8b Upgrade: Lowercase the "s" in remove_all_filters(). 
props afragen.
fixes #33173.

git-svn-id: https://develop.svn.wordpress.org/trunk@33487 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 14:56:23 +00:00
Mark Jaquith
2a25f9ce22 Change send_pass_change_email to send_password_change_email (better name). 
see #32430

git-svn-id: https://develop.svn.wordpress.org/trunk@33486 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 14:51:52 +00:00
Mark Jaquith
e43b4db995 Make the "using default password" nag more accurate. 
"Easy to remember" isn't necessarily what we want to encourage.

fixes #33168
props arjunskumar

git-svn-id: https://develop.svn.wordpress.org/trunk@33485 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 14:05:59 +00:00
Ella Iseulde Van Dorpe
b5c42d6b33 TinyMCE: views: correct cursor position after paste 
Fixes #33174.


git-svn-id: https://develop.svn.wordpress.org/trunk@33484 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 13:48:58 +00:00
Dominik Schilling (ocean90)
8db3eeec7d Customizer: Add an aria-expanded attribute to Edit menu item toggles. 
props afercia.
fixes #33129.

git-svn-id: https://develop.svn.wordpress.org/trunk@33483 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 09:49:55 +00:00
Ella Iseulde Van Dorpe
71dc853888 Press This: correct link on the post screens 
Props rabmalin.
Fixes #33169.


git-svn-id: https://develop.svn.wordpress.org/trunk@33482 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 08:43:06 +00:00
Mark Jaquith
11f4909315 Do not re-generate the password after pressing "cancel". Persist the state. 
Also removes pass2 code not needed since we're generating from one field.

fixes #33164

git-svn-id: https://develop.svn.wordpress.org/trunk@33475 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 04:29:36 +00:00
Mark Jaquith
fff891b1d9 Autogenerate passwords that more reliably fit within their inputs. 
fixes #33166

git-svn-id: https://develop.svn.wordpress.org/trunk@33474 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 03:55:56 +00:00
Mark Jaquith
c13b00709b Re-work user-profile.js so the password meter works in IE8 and password managers can fill multiple times. 
props adamsilverstein
fixes #32886

git-svn-id: https://develop.svn.wordpress.org/trunk@33473 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 03:26:20 +00:00
Mark Jaquith
694fb98fa1 Add CloudUp to our oEmbed provider whitelist. 
fixes #26278

git-svn-id: https://develop.svn.wordpress.org/trunk@33472 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 02:56:48 +00:00
Mark Jaquith
220ea93449 Omit the "(required)" text for password on the install screen. 
fixes #33163

git-svn-id: https://develop.svn.wordpress.org/trunk@33471 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 01:19:45 +00:00
Andrew Ozz
35acd9abf8 Use the embed_maybe_make_link filter to test WP_Embed::autoembed(). 
See #33106.

git-svn-id: https://develop.svn.wordpress.org/trunk@33470 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 00:01:22 +00:00
Scott Taylor
4f814ec9ae Protect newlines inside of CDATA. This was breaking things, notably inline JS that used comments for HTML standards compat. 
* Tokenize newlines in `WP_Embed::autoembed()` before running `->autoembed_callback()`
* Tokenize newlines with placeholders in `wpautop()` 
* Introduce `wp_html_split()` to DRY the RegEx from `wp_replace_in_html_tags()` and `do_shortcodes_in_html_tags()`

Adds unit tests.

Props miqrogroove, kitchin, azaozz.
Fixes #33106.


git-svn-id: https://develop.svn.wordpress.org/trunk@33469 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 23:02:04 +00:00
Andrew Ozz
1558be9dfa Fix updating of nonces on the Edit Post screen after the log in expires and the user logs in again. 
Props iseulde, azaozz. Fixes #33098.

git-svn-id: https://develop.svn.wordpress.org/trunk@33468 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 22:06:52 +00:00
Konstantin Obenland
649d02a16b About: Remove translation functions until strings are final. 
See #32929.


git-svn-id: https://develop.svn.wordpress.org/trunk@33467 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 21:38:32 +00:00
Konstantin Obenland
d3dd832933 About: First pass at WordPress 4.3 About page. 
Still missing images and some string revisions.

See #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33466 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 21:22:23 +00:00
Mark Jaquith
90e39719d8 Lose the clunky setTimeout() code and just track the password value changes. 
see #32886

git-svn-id: https://develop.svn.wordpress.org/trunk@33465 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 21:10:16 +00:00
Ella Iseulde Van Dorpe
d5a39fe063 TinyMCE: iOS: wrap long strings 
Fixes #33157.


git-svn-id: https://develop.svn.wordpress.org/trunk@33464 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 20:31:36 +00:00
Konstantin Obenland
2da9f26205 Themes: Update readme files. 
Adds information about changes in the current release, links to changlogs from
previous releases, and improves links to use `https`.

Release date for the latest versions will be August 18 even in the event of a
delayed core release. Since all themes are backwards compatible we don't have
a dependency there.

Props mercime, davidakennedy.
Fixes #32978.



git-svn-id: https://develop.svn.wordpress.org/trunk@33463 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 15:13:31 +00:00
Sergey Biryukov
962cc345ae Plugins list table: Make selector for Details links more specific to prevent the Description header from being announced as "clickable". 
props afercia.
fixes #32968.

git-svn-id: https://develop.svn.wordpress.org/trunk@33462 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 14:49:41 +00:00
Mark Jaquith
cda0fa1f76 Fill empty TinyMCE paragraphs with a dummy <br /> on all browsers. 
fixes #33151
props iseulde

git-svn-id: https://develop.svn.wordpress.org/trunk@33461 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 14:11:04 +00:00
Dominik Schilling (ocean90)
972f871214 Customizer: Make a string translatable, see [33413]. 
see #32715.

git-svn-id: https://develop.svn.wordpress.org/trunk@33460 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 13:24:53 +00:00
Gary Pendergast
74c061a480 XML-RPC: Don't rely on include_path to include files, use dirname() instead. 
See #17092.



git-svn-id: https://develop.svn.wordpress.org/trunk@33459 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 12:16:44 +00:00
Ella Iseulde Van Dorpe
4393f478ea TinyMCE: wptextpattern: fix typo and make it faster 
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@33458 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 11:40:29 +00:00
Sergey Biryukov
ecd1ceccdc Twenty Eleven: Fix "Skip to content" links appearance after [31464]. 
props davidakennedy.
fixes #32231.

git-svn-id: https://develop.svn.wordpress.org/trunk@33457 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 11:13:21 +00:00
Sergey Biryukov
6c6dc814a3 Replace empty table header with a table cell. 
props afercia.
fixes #33047.

git-svn-id: https://develop.svn.wordpress.org/trunk@33456 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 10:18:47 +00:00
Gary Pendergast
dfb86dc965 WPDB: When checking the encoding of strings against the database, make sure we're only relying on the return value of strings that were sent to the database. Also make sure that we're not trying to sanity check strings that've been marked as not needing sanity checking. 
Fixes #32279.



git-svn-id: https://develop.svn.wordpress.org/trunk@33455 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 06:31:39 +00:00
Weston Ruter
b53cbb1279 Customizer: Hide empty space in footer on small screens since it is only populated on larger screens. 
Props obenland.
Fixes #33138.


git-svn-id: https://develop.svn.wordpress.org/trunk@33454 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 03:42:36 +00:00
Ella Iseulde Van Dorpe
4c7dfd38f7 Remove broken/dead colour scheme code 
See #32152.


git-svn-id: https://develop.svn.wordpress.org/trunk@33453 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 23:49:07 +00:00
Ella Iseulde Van Dorpe
34354fc3c0 TinyMCE: wptextpattern: headings on enter 
Fixes #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@33452 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 23:15:15 +00:00
Scott Taylor
68ff8b1a80 Passwords UI: clean up the new JS in wp-admin/js/user-profile.js. 
Instead of wrapping `#pass1` in a `<span>` dynamically, add the `<span>` to the HTML in PHP. It currently has no styling.

Fixes #33145.


git-svn-id: https://develop.svn.wordpress.org/trunk@33450 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 21:24:36 +00:00
Dominik Schilling (ocean90)
99cd8b540b Bundled Themes: Bump version numbers and update POT files. 
see #32978.

git-svn-id: https://develop.svn.wordpress.org/trunk@33449 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 19:49:14 +00:00
Mark Jaquith
3f2b0779f5 Don't blindly trust the output of glob() to be an array. 
props kitchin
fixes #33093

git-svn-id: https://develop.svn.wordpress.org/trunk@33447 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 18:04:19 +00:00
Konstantin Obenland
cd4811bf66 Site Icon: Minor cleanup for WP_Site_Icon after [33329]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33446 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 16:08:47 +00:00
Konstantin Obenland
6bca6cb0b2 Customizer: Use correct spelling when instantiating CustomizeImageCropper. 
Introduced in [33329].


git-svn-id: https://develop.svn.wordpress.org/trunk@33445 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 15:54:51 +00:00
Konstantin Obenland
8f588b345b Menus: Readjust screen options toggle icon. 
Third revision. This will let the icon appear slightly bigger than the help
icon on Macs and just slightly smaller on Windows machines. It's a compromise
in every way.

Fixes #32733. Again.



git-svn-id: https://develop.svn.wordpress.org/trunk@33444 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 15:42:44 +00:00
Sergey Biryukov
c8f1bf5a94 Merge two similar strings about insufficient permissions. 
props pavelevap.
fixes #33140.

git-svn-id: https://develop.svn.wordpress.org/trunk@33442 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 13:24:39 +00:00
Sergey Biryukov
faecac7803 Move the translator note added in [33437] directly before the string it applies to. 
fixes #33091.

git-svn-id: https://develop.svn.wordpress.org/trunk@33441 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 12:42:14 +00:00
Ella Iseulde Van Dorpe
aed9a8c5bc Editor: word count: better names for types. 
Also fix it in wp_trim_words().

Fixes #30966.


git-svn-id: https://develop.svn.wordpress.org/trunk@33440 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 11:18:55 +00:00
Mark Jaquith
70dd339fa3 Fix the padding for the feature filter box on the Add Themes screen. 
fixes #33132
props SergeyBiryukov

git-svn-id: https://develop.svn.wordpress.org/trunk@33439 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 03:33:24 +00:00
Mark Jaquith
80c9c8cfca Toggle between dashicons-hidden and dashicons-visibility in the password hide/show button. 
fixes #33135

git-svn-id: https://develop.svn.wordpress.org/trunk@33438 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 03:12:55 +00:00
Mark Jaquith
3ad35be856 Add a translator note for the fix in r33387 
props SergeyBiryukov
fixes 33091

git-svn-id: https://develop.svn.wordpress.org/trunk@33437 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 01:53:04 +00:00
Sergey Biryukov
0fe4782373 Comment string tweaks: 
* Merge two strings about an invalid comment ID.
* Add missing context to 'Mark as Spam' string.
* Merge two 'In Response To' strings, replace redundant context with a translator comment.

props pavelevap.
fixes #32334.

git-svn-id: https://develop.svn.wordpress.org/trunk@33436 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:35:47 +00:00
Sergey Biryukov
71b9b522e2 Merge some similar media-related strings. 
props pavelevap.
fixes #32390.

git-svn-id: https://develop.svn.wordpress.org/trunk@33435 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:23:48 +00:00
Sergey Biryukov
be54cc64a9 Multisite: Introduce a singular string for user removal (we already have one for deletion). 
props pavelevap.
fixes #32387.

git-svn-id: https://develop.svn.wordpress.org/trunk@33434 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:18:19 +00:00
Sergey Biryukov
8e7c0148dc Merge two duplicate strings. 
props pavelevap.
fixes #31730.

git-svn-id: https://develop.svn.wordpress.org/trunk@33433 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:03:52 +00:00
Sergey Biryukov
b8a5123dc9 Merge similar strings for plugin update permissions. 
props pavelevap.
fixes #32388.

git-svn-id: https://develop.svn.wordpress.org/trunk@33432 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:00:11 +00:00
Sergey Biryukov
5a23543cc8 Merge duplicate strings related to Trash. 
props pavelevap.
fixes #33133.

git-svn-id: https://develop.svn.wordpress.org/trunk@33431 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 22:47:05 +00:00
Andrew Ozz
a5d922f427 TinyMCE: remove role=tab from the keyboard shortcuts help dialog. 
See #33031.

git-svn-id: https://develop.svn.wordpress.org/trunk@33430 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 21:36:06 +00:00
Andrew Ozz
4ca5459784 TinyMCE: fix accessibility for the keyboard shortcuts help dialog. 
Props afercia, azaozz. Fixes #33031.

git-svn-id: https://develop.svn.wordpress.org/trunk@33429 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 19:13:28 +00:00
Ella Iseulde Van Dorpe
7cff5c8794 JSHint for [33426] 
Oops. :|

See #33096.


git-svn-id: https://develop.svn.wordpress.org/trunk@33428 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 18:17:37 +00:00
Aaron Jorbin
385b98d828 Use explicit variable variable syntax 
PHP7 introduces a backwards compatable change to variable varibale syntax that requires us to use curly brackets to maintain the syntax between php5 and php7.  For more info, see https://wiki.php.net/rfc/uniform_variable_syntax#semantic_differences_in_existing_syntax for the semantic differences.  

Props ocean90
Fixes #31982



git-svn-id: https://develop.svn.wordpress.org/trunk@33427 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 18:03:58 +00:00
Ella Iseulde Van Dorpe
079d7eb56e TinyMCE: views: use media setting to get post ID 
Also fix dependency declarations and confusing variable names.

Props rhurling.
Fixes #33096.


git-svn-id: https://develop.svn.wordpress.org/trunk@33426 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 10:10:31 +00:00
Sergey Biryukov
67f74ea9c1 Comment status box: Move focus back to Edit link when changing the date. 
props afercia.
fixes #33062.

git-svn-id: https://develop.svn.wordpress.org/trunk@33422 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 02:25:43 +00:00
Sergey Biryukov
d279b43d2d Customizer: Set a correct default for nav_menu_locations setting. 
props westonruter.
fixes #33088.

git-svn-id: https://develop.svn.wordpress.org/trunk@33421 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 02:00:14 +00:00
Sergey Biryukov
a3f2503ddc Update help text after [33368]. 
fixes #33082.

git-svn-id: https://develop.svn.wordpress.org/trunk@33420 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 01:51:18 +00:00
Sergey Biryukov
7214dc6fb4 Remove unused pw-weak ID attributes. 
see #33077.

git-svn-id: https://develop.svn.wordpress.org/trunk@33419 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 00:57:21 +00:00
Ella Iseulde Van Dorpe
1a18cb3b00 Revert [31849] and [33351] 
Also set the max-width of images in themes to 100%, not in pixels.

See #33022 and #31250.


git-svn-id: https://develop.svn.wordpress.org/trunk@33418 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-25 22:59:23 +00:00