Commit Graph

41230 Commits

Author SHA1 Message Date
Sergey Biryukov 822167a42b Build/Test Tools: Bump devDependencies for WordPress 5.4.
Props ayeshrajans, garrett-eclipse.
Fixes #49547.

git-svn-id: https://develop.svn.wordpress.org/trunk@47404 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-02 01:52:29 +00:00
Sergey Biryukov 98003a7546 Tests: Add a unit test to ensure the "Supported Versions" section of GitHub Security Policy always includes the latest stable branch.
See #48667, #48521.

git-svn-id: https://develop.svn.wordpress.org/trunk@47403 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-02 01:11:29 +00:00
Sergey Biryukov 3feb885ec3 Docs: Use more specific type in parameter descriptions for `is_page()`, `is_single()`, `is_singular()`, and their `WP_Query` counterpart methods.
Props marekdedic, shaharia.azam, shaampk1.
Fixes #48354. See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47402 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 17:27:03 +00:00
Sergey Biryukov 6c33566c05 Docs: Synchronize parameter descriptions for conditional tags with their `WP_Query` counterpart methods.
See #48354, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47401 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 17:19:58 +00:00
Sergey Biryukov f327466200 Docs: Use more specific type in parameter description for `wp_unslash()`.
Props marekdedic.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47400 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 16:23:24 +00:00
Sergey Biryukov a7c0d2c8fc Docs: Use more specific type in description for `_WP_Dependency::$deps`.
Props marekdedic.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47399 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 16:22:51 +00:00
John Blackbourn ac6cb23470 Docs: Miscellaneous docs fixes and improvements.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47398 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:38:00 +00:00
John Blackbourn 78a6e4febb Docs: Use more specific types in parameter descriptions in place of `mixed`.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47397 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:36:38 +00:00
John Blackbourn ba57b0141c Docs: Correct the parameter documentation of the `request_filesystem_credentials` filter.
See #48303

git-svn-id: https://develop.svn.wordpress.org/trunk@47396 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:31:31 +00:00
Sergey Biryukov 5f23c79b1d Privacy: Make the progress indicator for export and erasure visible even if not hovered over.
Follow-up to [47246].

Props pbiron, garrett-eclipse.
Fixes #44264.

git-svn-id: https://develop.svn.wordpress.org/trunk@47395 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-29 23:43:57 +00:00
John Blackbourn b7bc6f7bb0 Docs: Correct and improve the docs for some media related functions.
See #48303

git-svn-id: https://develop.svn.wordpress.org/trunk@47394 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-29 16:47:44 +00:00
Ian Belanger b4d0da91f7 Bundled Themes: Twenty Twenty searchform.php error.
Fixes phpcs error in the searchform.php file. The variables in this file were not prefixed correctly.

Props fahimmurshed.
Fixes #49523.

git-svn-id: https://develop.svn.wordpress.org/trunk@47393 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 20:54:42 +00:00
Ian Belanger a00d79a07d Bundled Themes: Twenty Thirteen update calendar widget styles for 5.4 markup.
Fixes the alignment of month links in the calendar widget with the changes in version 5.4

Props sabernhardt.
Fixes #49546.

git-svn-id: https://develop.svn.wordpress.org/trunk@47392 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 20:05:39 +00:00
Sergey Biryukov b54d5925ce Docs: Improve documentation for `WP_REST_Attachments_Controller`.
This adds a missing DocBlock for `::register_routes()` and parameter descriptions for `::post_process_item()`.

Includes minor documenation fixes in other REST API classes for consistency.

Props dkarfa, mukesh27, SergeyBiryukov.
Fixes #48841.

git-svn-id: https://develop.svn.wordpress.org/trunk@47391 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 12:29:53 +00:00
Sergey Biryukov 697127203b Docs: Improve documentation for various metadata functions.
This adds a more specific description for accepted object types: `post`, `comment`, `term`, `user`, or any other object type with an associated meta table.

Props sheparddw, kraftbj, DrewAPicture, SergeyBiryukov.
Fixes #45464.

git-svn-id: https://develop.svn.wordpress.org/trunk@47390 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 12:12:58 +00:00
Sergey Biryukov ab4800b289 Coding Standards: Update PHPCS Composer plugin to v0.6.0.
Release log: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.6.0

Props jrf.
See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47389 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 01:38:58 +00:00
Sergey Biryukov 559ccdda0c Twenty Twenty: Replace quotation marks in starter content with HTML entities.
Props fahimmurshed.
Fixes #49534.

git-svn-id: https://develop.svn.wordpress.org/trunk@47388 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 21:58:54 +00:00
Sergey Biryukov ef613db765 Docs: Add a reference to `WP_Customize_Panel::__construct()` for information on accepted arguments in `WP_Customize_Manager::add_panel()`.
Synchronize the documentation between two places, use `WP_Customize_Panel::__construct()` as the canonical source.

Props iaaxpage, marekdedic.
Fixes #48344.

git-svn-id: https://develop.svn.wordpress.org/trunk@47387 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 20:34:49 +00:00
Sergey Biryukov 19bdff7326 Docs: Add a reference to `WP_Customize_Section::__construct()` for information on accepted arguments in `WP_Customize_Manager::add_section()`.
Synchronize the documentation between two places, use `WP_Customize_Section::__construct()` as the canonical source.

Props amolv, marekdedic.
Fixes #48346.

git-svn-id: https://develop.svn.wordpress.org/trunk@47386 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 20:27:45 +00:00
Sergey Biryukov 33b88a7c7f Docs: Clarify the type of `theme_supports` argument in various Customizer classes.
Props marekdedic.
See #48347.

git-svn-id: https://develop.svn.wordpress.org/trunk@47385 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 20:21:35 +00:00
Sergey Biryukov 9793244c74 Docs: Add a reference to `WP_Customize_Setting::__construct()` for information on accepted arguments in `WP_Customize_Manager::add_setting()`.
Synchronize the documentation between two places, use `WP_Customize_Setting::__construct()` as the canonical source.

Props tmanoilov, marekdedic.
Fixes #48347.

git-svn-id: https://develop.svn.wordpress.org/trunk@47384 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 20:07:31 +00:00
Sergey Biryukov bd71eb4b74 Docs: Use a consistent description for the `$manager` parameter in various Customizer class constructions.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47383 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-26 15:31:19 +00:00
Sergey Biryukov aab2667898 Docs: Add a `@see` reference to `WP_Customize_Control::__construct()` in child class constructors.
Follow-up to [47363], [47364].

See #48343, #48348.

git-svn-id: https://develop.svn.wordpress.org/trunk@47382 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-26 13:29:01 +00:00
Sergey Biryukov bc5a7e9506 Build/Test Tools: Remove redundant `Tests_Post_Types::register_post_type()` helper method, use `register_post_type()` directly.
Props gh640, varunshanbhag.
Fixes #49365.

git-svn-id: https://develop.svn.wordpress.org/trunk@47381 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-26 13:16:10 +00:00
Andrew Ozz 3a4faa975f Build Tools: Do not delete the (now committed) `script-loader-packages.php` file when running `clean:js` and copy it to /build. Fixes cases when running `grunt watch` or `-dev` where that file may be deleted and not recreated.
See #48154.

git-svn-id: https://develop.svn.wordpress.org/trunk@47380 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-26 05:13:05 +00:00
Jorge Costa 0975f8e79b Post WordPress 5.4 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@47379 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 22:11:55 +00:00
Jorge Costa 16aa8bbcce WordPress 5.4 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@47378 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 21:54:53 +00:00
Sergey Biryukov 762dc39878 Block Editor: Update `wp-includes/assets/script-loader-packages.php`.
Follow-up to [47352], [47354].

Props aduth, ocean90, garrett-eclipse.
Fixes #49506.

git-svn-id: https://develop.svn.wordpress.org/trunk@47377 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 21:43:57 +00:00
Sergey Biryukov 0347132f12 Privacy: Switch buttons in Next Steps column of privacy request tables to `break-word` for better legibility on various screen sizes.
Props garrett-eclipse, afercia, nrqsnchz.
Fixes #46304.

git-svn-id: https://develop.svn.wordpress.org/trunk@47376 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:59:08 +00:00
Sergey Biryukov ccb7aec7fc Accessibility: Media: Hide the invisible "file upload button" on media views from assistive technologies.
The button is visually hidden, but was announced by screen readers in workflows unrelated to file uploading, leading to confusion.

Props afercia, audrasjb, azaozz.
Fixes #47611.

git-svn-id: https://develop.svn.wordpress.org/trunk@47375 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:42:19 +00:00
Sergey Biryukov 22c02a0325 General: Introduce HTML classes in `get_calendar()` for easier CSS targeting:
* `.wp-calendar-table` for the `<table>` element.
* `.wp-calendar-nav` for the navigation wrapper.
* `.wp-calendar-nav-prev` for the previous month link.
* `.wp-calendar-nav-next` for the next month link.

Replace `#prev` and `#next` HTML IDs with `.wp-calendar-nav-prev` and `.wp-calendar-nav-next` classes.

Props sabernhardt, BackuPs, audrasjb, jorbin.
Fixes #39763.

git-svn-id: https://develop.svn.wordpress.org/trunk@47374 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:28:29 +00:00
Sergey Biryukov 91878831dd Docs: In `update_option()`, remove an inaccurate statement about the `$autoload` value for new options.
If the option does not exist, it will be created with whatever was passed to the `$autoload` parameter, `'yes'` being only the default value.

Props leogermani.
Fixes #48357.

git-svn-id: https://develop.svn.wordpress.org/trunk@47373 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:06:32 +00:00
Sergey Biryukov 38e9142a66 Coding Standards: Use strict comparison for `normalize_whitespace()` checks when comparing revisions or autosaves.
Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965.

git-svn-id: https://develop.svn.wordpress.org/trunk@47372 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 19:33:22 +00:00
Sergey Biryukov f852ca2cc1 Widgets: Create a unique HTML ID for the `<ul>` element of Recent Comments widget if more than one instance is displayed on the page.
Props peterwilsoncc, audrasjb, birgire, justinahinon, mbrailer, desrosj.
Fixes #46747.

git-svn-id: https://develop.svn.wordpress.org/trunk@47371 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 19:27:22 +00:00
Sergey Biryukov 97d43fbff5 Bootstrap/Load: In `wp_magic_quotes()`, revert the type change to string for `REQUEST_TIME` and `REQUEST_TIME_FLOAT` values, which should retain their proper type.
Among other things, this preserves compatibility of WP with PHPUnit Code Coverage generation.

Props jrf, Veraxus, Rarst.
See #48605.

git-svn-id: https://develop.svn.wordpress.org/trunk@47370 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 18:31:33 +00:00
Sergey Biryukov 8dbe048737 Docs: In `wp_insert_user()`, correct `@type` for `rich_editing`, `syntax_highlighting`, `comment_shortcuts`, and `show_admin_bar_front` arguments.
Follow-up to [47368].

See #49087.

git-svn-id: https://develop.svn.wordpress.org/trunk@47369 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 18:18:26 +00:00
Sergey Biryukov d722bdb0ac Docs: In `wp_insert_user()`, clarify that `rich_editing`, `syntax_highlighting`, `comment_shortcuts`, and `show_admin_bar_front` arguments accept `true` or `false` as a string literal, not boolean.
Props garrett-eclipse, audrasjb, valentinbora, bilgilabs, SergeyBiryukov.
Fixes #49087.

git-svn-id: https://develop.svn.wordpress.org/trunk@47368 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 18:15:00 +00:00
Sergey Biryukov f1124fc1cb Docs: Clarify in `WP_Customize_Manager::remove_*()` methods that removing a setting, panel, section, or control does not destroy the class instance or remove its filters.
Props dlh, fgiannar, jon81, westonruter.
Fixes #48747.

git-svn-id: https://develop.svn.wordpress.org/trunk@47367 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 17:48:40 +00:00
Sergey Biryukov a6b80a326a Comments: Restore the fourth parameter of `comments_number()` as `$post_id`, for consistency with `get_comments_number_text()`.
The parameter was previously used as the number of comments, marked as deprecated in [5101].

Given that it's been deprecated for the last 13 years, it should be safe to undeprecate and repurpose it for a cleaner function signature, instead of adding a fifth parameter.

Follow-up to [47276].

Fixes #48772.

git-svn-id: https://develop.svn.wordpress.org/trunk@47366 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 17:32:34 +00:00
Sergey Biryukov 812773b8fc Widgets: Avoid an overflow issue in widget controls that include `<select>` form fields.
Props alexischenal, audrasjb, dkarfa.
Fixes #49401.

git-svn-id: https://develop.svn.wordpress.org/trunk@47365 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 17:02:27 +00:00
Sergey Biryukov 3bd4e3a075 Docs: Add a reference to `WP_Customize_Control::__construct()` for information on accepted arguments in `WP_Customize_Manager::add_control()`.
Synchronize the documentation between two places, use `WP_Customize_Control::__construct()` as the canonical source.

Props hAmpzter, marekdedic, SergeyBiryukov.
Fixes #48343.

git-svn-id: https://develop.svn.wordpress.org/trunk@47364 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 16:39:36 +00:00
Sergey Biryukov 5178d29f4a Docs: Add a reference to `WP_Customize_Control::__construct()` for information on accepted arguments to override class property defaults in child classes.
Props marcio-zebedeu, marekdedic.
Fixes #48348.

git-svn-id: https://develop.svn.wordpress.org/trunk@47363 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 16:19:08 +00:00
K. Adam White 4e0062e5be REST API: Correctly infer empty objects passed via query parameters.
Permit passing an empty object as the string "?obj=". The type of the passed empty argument is inferred from the registered schema.

Props TimothyBlynJacobs, steffanhalv, schlessera, dd32.
Fixes #42961.


git-svn-id: https://develop.svn.wordpress.org/trunk@47362 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 15:32:27 +00:00
K. Adam White b5190458fe REST API: Permit access to the themes controller if user can edit any post type.
Check a more exhaustive list of post type editing caps beyond "edit_post" to ensure custom user roles with access to to specific post types may still use block editor functionality depending on theme features.

Props miyauchi, TimothyBlynJacobs.
Fixes #46723.


git-svn-id: https://develop.svn.wordpress.org/trunk@47361 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 15:18:19 +00:00
K. Adam White a0ac0ff13d REST API: Apply all relevant block rendering filters when rendering block previews.
Several filters were introduced to the render_block method since the initial implementation of the block-renderer/ endpoints, causing the output of those endpoints to diverge from the rendered content of blocks on the frontend.

Props kadamwhite, TimothyBlynJacobs, miinasikk.
Fixes #49387.


git-svn-id: https://develop.svn.wordpress.org/trunk@47360 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 15:03:57 +00:00
Sergey Biryukov 51e6228635 Script Loader: Improve performance of `wp_script_is()` for scripts registered with complex dependencies.
This switches `WP_Dependencies::recurse_deps()` from recursively checking the same handles over and over again to keep a flattened array of queued items and their dependencies for faster lookup in `WP_Dependencies::query()`.

Props superdav42.
Fixes #46469.

git-svn-id: https://develop.svn.wordpress.org/trunk@47359 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 13:40:52 +00:00
Sergey Biryukov 887e0a8004 Docs: Add a `@since` note for including `delete_posts` in default capabilities in `get_post_type_capabilities()`.
Follow-up to [47357].

See #30991.

git-svn-id: https://develop.svn.wordpress.org/trunk@47358 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 12:53:35 +00:00
Sergey Biryukov 317e1c076c Posts, Post Types: Ensure `delete_posts` is included in default post type capabilities regardless of `map_meta_cap` value.
This resolves PHP notices in a few places in core where this capability is checked.

Props Mte90, johnbillion, dipesh.kakadiya, jipmoors, bamadesigner, dd32, johnjamesjacoby, xedin.unknown, flixos90, SergeyBiryukov.
Fixes #30991.

git-svn-id: https://develop.svn.wordpress.org/trunk@47357 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 12:48:11 +00:00
Sergey Biryukov 196859f90f Customize: When a menu item is removed from the menu, uncheck its source item on the available items panel.
Props donmhico, garrett-eclipse, audrasjb.
Fixes #46830.

git-svn-id: https://develop.svn.wordpress.org/trunk@47356 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 11:12:18 +00:00
Sergey Biryukov f40c6c9ebe Script Loader: Remove unnecessary reference sign from function definitions in script loader.
This resolves PHP warnings when extensions like `php_uopz` or `php_tideways_xhprof` are in use.

Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.

Props jqz, killerbishop, Mte90, TJNowell, jorbin, pento, pcarvalho, valentinbora, SergeyBiryukov.
Fixes #44979.

git-svn-id: https://develop.svn.wordpress.org/trunk@47355 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 00:57:33 +00:00