Commit Graph

30509 Commits

Author SHA1 Message Date
Mark Jaquith
bac0e68b48 Say goodbye to ?replytocom=123 links and their URL pollution.
* Comment reply links continue to use JS as before.
* ?replytocom=123 links are deprecated.

props joostdevalk
fixes #22889

git-svn-id: https://develop.svn.wordpress.org/trunk@33038 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 21:41:17 +00:00
Dominik Schilling (ocean90)
d0728bf768 Site icon: Remove option name from $whitelist_options for the general options screen.
The option gets saved in `WP_Site_Icon->set_site_icon()`.

fixes #32859.

git-svn-id: https://develop.svn.wordpress.org/trunk@33037 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 21:40:40 +00:00
Weston Ruter
552879c842 Customizer: Add link to Widgets panel from Menus panel description.
Props celloexpressions.
Fixes #32742.



git-svn-id: https://develop.svn.wordpress.org/trunk@33036 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 19:34:17 +00:00
Sergey Biryukov
2ef2ac5e93 Customizer: Avoid PHP notices after [32806].
props adamsilverstein, westonruter.
fixes #32781.

git-svn-id: https://develop.svn.wordpress.org/trunk@33035 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 19:07:20 +00:00
Mark Jaquith
ef9f9c1a24 Fix small typo from [33019].
see #32429

git-svn-id: https://develop.svn.wordpress.org/trunk@33034 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 18:15:42 +00:00
Mark Jaquith
a288fe93f3 Slow down on calling zxcvbn if it isn't loaded.
see #32589

git-svn-id: https://develop.svn.wordpress.org/trunk@33033 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 18:12:04 +00:00
Konstantin Obenland
3bda728420 Add additional escaping to credits page.
Props Viper007Bond, gtuk for initial patch.
Fixes #21523.



git-svn-id: https://develop.svn.wordpress.org/trunk@33032 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 17:21:55 +00:00
Mark Jaquith
82150c08f2 Add a missing "var". see #32589
git-svn-id: https://develop.svn.wordpress.org/trunk@33031 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 17:15:43 +00:00
Dominik Schilling (ocean90)
d1bedc6769 Customizer: Make reordering menu items via drag and drop easier.
Introduce `wpNavMenu.options.targetTolerance` to define a tolerance when dragging items where no margins between the sortable items exists.

props adamsilverstein.
fixes #32821.

git-svn-id: https://develop.svn.wordpress.org/trunk@33030 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 16:43:02 +00:00
Jeremy Felt
568721eef1 Trim trailing space from string in site delete confirmation
Props yoavf.
Fixes #32853.


git-svn-id: https://develop.svn.wordpress.org/trunk@33029 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 16:30:34 +00:00
Dominik Schilling (ocean90)
54cd46c1d0 Customizer: Fix height calculation of placeholders when dragging menu items.
props adamsilverstein.
fixes #32857.

git-svn-id: https://develop.svn.wordpress.org/trunk@33028 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 16:19:51 +00:00
Dominik Schilling (ocean90)
caab22e5b2 l10n: Update wp_get_installed_translations() to support variants of a language.
* A variant of a language has its own locale, for example the locale of the formal variant of German is `de_DE_formal`.
* Update `remove_accents()` and some CSS rules to support `de_DE_formal`.
* Add tests for `get_bloginfo( 'language' )`.
* API changes will be deployed over the next few days.

see #28303.

git-svn-id: https://develop.svn.wordpress.org/trunk@33027 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 15:42:32 +00:00
Konstantin Obenland
b32cf591c2 Improve the tone of key/salts recommendation message.
Also adds some inline comments to make it easier to understand how it
is determined whether to show the message or not.

Props helen.
Fixes #20779.



git-svn-id: https://develop.svn.wordpress.org/trunk@33026 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 15:38:09 +00:00
Scott Taylor
f8841653ef wp_audio|video_shortcode() doesn't allow you to pass id, the docs shall reflect that.
Props thorbrink.
See #32855.


git-svn-id: https://develop.svn.wordpress.org/trunk@33025 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 15:00:54 +00:00
Konstantin Obenland
238d5a78a6 Close comment quick edit before updating a post.
Fixes a bug where the user gets redirected to the All Posts screen, after
updating a post while quick editing a comment.

Props polevaultweb.
Fixes #29457.



git-svn-id: https://develop.svn.wordpress.org/trunk@33024 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 14:53:48 +00:00
Mark Jaquith
cc23659078 New password change/set UI.
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords

see #32589

props MikeHansenMe, adamsilverstein, binarykitten

git-svn-id: https://develop.svn.wordpress.org/trunk@33023 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 14:47:24 +00:00
Boone Gorges
f7b8ff5a2e Don't allow $field param to be passed to get_term_link().
The new parameter creates inconsistencies in the signatures of the various
functions for fetching term links (`get_term_feed_link()`,
`get_edit_term_link()`, etc.).

Reverts [32553].

See #14156.

git-svn-id: https://develop.svn.wordpress.org/trunk@33022 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 12:53:05 +00:00
Boone Gorges
e8a16ec322 Allow 'comment_agent' and 'comment_author_IP' to be set via wp_new_comment().
Props mrutz, wonderboymusic, rachelbaker.
Fixes #14601.

git-svn-id: https://develop.svn.wordpress.org/trunk@33021 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 12:07:28 +00:00
Dion Hulse
1cccb02930 Split upgrade_430() into two so that split_all_shared_terms() runs when upgrade_430_fix_comments() bails early.
See [32814], #30261, [32364], #32165


git-svn-id: https://develop.svn.wordpress.org/trunk@33020 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 07:34:26 +00:00
Dion Hulse
5b58664439 Expire password reset links after 24 hours (by default). This causes existing password reset links to become invalid.
Props markjaquith, voldemortensen, johnbillion, MikeHansenMe, dd32
See #32429


git-svn-id: https://develop.svn.wordpress.org/trunk@33019 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 06:32:07 +00:00
Konstantin Obenland
b04ea26df1 After [32866], change filter name.
While filter names generally don't have to be tied to the function in which they 
are applied, the API for media display generally seems to use the
`wp_get_attachment_*` pattern.

Props DrewAPicture.
Fixes #32363.



git-svn-id: https://develop.svn.wordpress.org/trunk@33018 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 03:46:23 +00:00
Helen Hou-Sandi
cf9b82dd14 Fire the check_admin_referer action on failure as well as success.
This enables things like logging nonce failures in the admin.

props markjaquith.
fixes #32207.


git-svn-id: https://develop.svn.wordpress.org/trunk@33017 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 03:36:58 +00:00
Helen Hou-Sandi
e5c4c584c0 List tables: A better responsive view.
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33016 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 01:30:23 +00:00
Helen Hou-Sandi
6130ea5a0b Bulk/quick edit: Set the correct colspan.
`thead` can contain `td`s now, too.

props afercia.
fixes #31654.


git-svn-id: https://develop.svn.wordpress.org/trunk@33015 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 01:05:29 +00:00
Konstantin Obenland
016ebf43ed Open closed widget areas when dragging onto them.
Allows dropping Widgets into the correct spot of a given sidebar, no matter
whether that sidebar is open or closed. Removes a step from the setup process
for closed sidebars.

Props polevaultweb.
Fixes #13524.



git-svn-id: https://develop.svn.wordpress.org/trunk@33014 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 00:57:03 +00:00
Andrew Ozz
58f914004d TinyMCE: update to 4.2.1. Changelog: https://github.com/tinymce/tinymce-dist/blob/master/changelog.txt.
Fixes #32801.

git-svn-id: https://develop.svn.wordpress.org/trunk@33013 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 00:51:22 +00:00
Konstantin Obenland
f733d8a91d Customizer: Fresh colors for Reorder Done button.
When reordering Widgets or Menus, the red colorcould suggest
it would cancel the changes, rather than save them. The blue
suggests it's clickable and is more in line with the Close
link on open Widgets.

Fixes #32811.



git-svn-id: https://develop.svn.wordpress.org/trunk@33012 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 00:18:46 +00:00
Konstantin Obenland
7718755e2e Site Icon: Move admin icon filter to its rightful place.
The action is unrelated to `WP_Site_Icon` itself.

Props kraftbj.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@33011 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 23:25:46 +00:00
Dominik Schilling (ocean90)
454d8682d0 Plugins list table: Sort plugins by Name by default so translated plugin names get correctly sorted.
props swissspidy.
fixes #32735.

git-svn-id: https://develop.svn.wordpress.org/trunk@33010 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 22:30:19 +00:00
Andrew Ozz
9d22c89199 Squish that .png a bit more. See [32994].
git-svn-id: https://develop.svn.wordpress.org/trunk@33009 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 22:03:53 +00:00
Dominik Schilling (ocean90)
05e0f92632 Remove unnecessary feedback message from WP_Importer::is_user_over_quota().
fixes #32021.

git-svn-id: https://develop.svn.wordpress.org/trunk@33008 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 20:31:13 +00:00
Dominik Schilling (ocean90)
86bd177222 Make WP_Locale::rtl_src_admin_notice() translatable.
props jrf.
see #32021.

git-svn-id: https://develop.svn.wordpress.org/trunk@33007 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 20:20:40 +00:00
Dominik Schilling (ocean90)
9db82ab3a7 wpdb: Make "WordPress database error:" translatable.
props jrf.
see #32021.

git-svn-id: https://develop.svn.wordpress.org/trunk@33006 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 19:59:28 +00:00
Konstantin Obenland
b5c9418d88 Twenty Fifteen: Add missing textdomain.
Props pavelevap.
See #32001.



git-svn-id: https://develop.svn.wordpress.org/trunk@33005 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 19:22:10 +00:00
Konstantin Obenland
4a59595cf3 Use correct panel id for menus when linking to the customizer.
Props swissspidy.
Fixes #32808.



git-svn-id: https://develop.svn.wordpress.org/trunk@33004 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 16:23:29 +00:00
Konstantin Obenland
3092f5a638 Twenty Fifteen: Use default strings for comments link.
Also adds context for screen readers, like in default strings.

Props pavelevap for initial patch.
Fixes #32001.



git-svn-id: https://develop.svn.wordpress.org/trunk@33003 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 15:38:31 +00:00
Helen Hou-Sandi
e681cb8ba7 Image edit: Consistent whitespace for the side boxes.
props tyxla.
fixes #31845.


git-svn-id: https://develop.svn.wordpress.org/trunk@33002 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 15:18:29 +00:00
Konstantin Obenland
26c766c0a7 Use existing nomenclature pattern for Site Icon class.
Props kraftbj.
Fixes #32834.



git-svn-id: https://develop.svn.wordpress.org/trunk@33001 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 14:36:09 +00:00
Andrew Ozz
41c512a202 Add assertive capability to wp.a11y.speak().
Props afercia. See #32600.

git-svn-id: https://develop.svn.wordpress.org/trunk@33000 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 04:34:15 +00:00
azaozz
f27883ce42 Press This:
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706.

git-svn-id: https://develop.svn.wordpress.org/trunk@32999 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 03:57:42 +00:00
Konstantin Obenland
6872d9122e Provide alt text for uploaded header images.
The custom header screen will use it rather then the description,
if an alt text is set.

Props francoeurdavid, voldemortensen, valendesigns.
Fixes #27959.



git-svn-id: https://develop.svn.wordpress.org/trunk@32998 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 21:31:21 +00:00
Boone Gorges
3a982b1590 Fix Tests_Post_GetPostClass::test_taxonomy_classes_hit_cache() after [32994].
[32994] results in an additional database query during automated testing, so
the query count being compared in this specific test must be incremented
manually.

See #16434.

git-svn-id: https://develop.svn.wordpress.org/trunk@32997 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 14:31:52 +00:00
Boone Gorges
10d81a3fe5 Introduce 'wp_generate_tag_cloud_data' filter.
This filter allows developers to modify the data that is used to create tag
clouds, without having to manipulate the tag cloud markup directly.

As part of the refactor, this changeset also adds a few unit tests for the way
`wp_generate_tag_cloud()` generates the 'title' attribute, as well as
improvements to output escaping.

Props flixos90, ysalame.
Fixes #24656.

git-svn-id: https://develop.svn.wordpress.org/trunk@32996 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 14:15:59 +00:00
Boone Gorges
85ce3f7eba Add some tests for wp_generate_tag_cloud().
Props welcher.
See #24656.

git-svn-id: https://develop.svn.wordpress.org/trunk@32995 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 13:18:48 +00:00
Konstantin Obenland
ffa682bee4 Introducing Site Icon, favicon management for WordPress.
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.

Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@32994 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 12:57:35 +00:00
Dion Hulse
2959d58c91 XML-RPC: Only escape what we need to in wp.editPage, this allows for passwords with the special characters "' to work in a request.
Props redsweater for initial Patch.
Fixes #32703


git-svn-id: https://develop.svn.wordpress.org/trunk@32993 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 02:06:25 +00:00
Andrew Ozz
510aff0e2d wpLink: always attempt to correct the URL before getting the URL field value. Fixes an edge case where the URL was not corrected when the user submitted the form by pressing Enter.
Props andfinally. Fixes #32412.

git-svn-id: https://develop.svn.wordpress.org/trunk@32992 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 23:06:14 +00:00
Helen Hou-Sandi
74a2eb6790 List tables: Bring screen reader text for comments column title to media.
see #32152, [31513].


git-svn-id: https://develop.svn.wordpress.org/trunk@32991 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 15:43:32 +00:00
Aaron Jorbin
4a60647ab7 Deprecate php4 style constructors
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors.  The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used.  In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982



git-svn-id: https://develop.svn.wordpress.org/trunk@32990 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 15:26:41 +00:00
Aaron Jorbin
6c8944b6ea Add Deprecated Constructor Function
This function is one that can be called in core to indicate that a PHP4 style constructor is used. PHP4 style constructors are deprecated in PHP7.

Props jorbin, DrewAPicture for docs
See #31982



git-svn-id: https://develop.svn.wordpress.org/trunk@32989 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 14:55:33 +00:00