Commit Graph

33087 Commits

Author SHA1 Message Date
Rachel Baker c2943ef70a Comments: Use an integer as the default value for `comment_post_ID` in `wp_insert_comment` to match database column.
Props MikeHansenMe, juanfra, rabmalin. 
Fixes #34956



git-svn-id: https://develop.svn.wordpress.org/trunk@35948 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 15:12:50 +00:00
Andrea Fercia 8da5918fbc Accessibility: Add an ARIA role `button` to links that behave like buttons when JavaScript is on.
Introduces a simple way to give a proper semantics of `button` to links that behave
like UI controls when JavaScript is on and behave like actual links when JavaScript
is off. First implementation on the Terms list table.

Patch prepared during WordCamp US 2015 Contributor Day.

Props mcapybara, garusky, takayukister.

See #26504.
Fixes #34867.

git-svn-id: https://develop.svn.wordpress.org/trunk@35947 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 13:24:13 +00:00
Dion Hulse 9249f66609 Filesystem: Avoid PHP warnings when using the FTP Sockets class.
See #35026 


git-svn-id: https://develop.svn.wordpress.org/trunk@35946 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 03:11:17 +00:00
Dion Hulse 5564545ea8 Filesystem: Revert [33648] and [34733] unfortunately these have caused issues for some servers, while fixing it for others.
See #28013

Fixes #34976 for trunk
Fixes #34976 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@35944 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 02:35:26 +00:00
Weston Ruter d33deeeb74 Customize: Ensure that "Change" button appears when there are only 2 themes.
Fixes defect introduced in [35535].

Props igmoweb.
See #34549.
Fixes #35081.


git-svn-id: https://develop.svn.wordpress.org/trunk@35943 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 01:20:49 +00:00
Dion Hulse f6972f0fae Filesystem API: Cast the port to an int in the FTPSockets class. PemFTP requires that the port be specified as an integer, not a numeric string.
Fixes #35088


git-svn-id: https://develop.svn.wordpress.org/trunk@35942 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 00:28:59 +00:00
Drew Jaynes 6de1483105 Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Rewrite::iis7_url_rewrite_rules()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35941 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:57:09 +00:00
Drew Jaynes 83b882ebe2 Docs: Add missing parameter documentation for the `$args` parameter in the DocBlock for `WP_Http_Streams::test()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35940 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:53:44 +00:00
Drew Jaynes ec3f5efbf9 Docs: Remove an extra 'arguments' introduced in [35938].
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35939 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:51:50 +00:00
Drew Jaynes 43857268a9 Docs: Add missing parameter documentation for the `$args` parameter in the DocBlock for `WP_Http_Curl::test()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35938 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:42:54 +00:00
Drew Jaynes e20a31a888 Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Http_Curl::stream_body()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35937 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:40:55 +00:00
Drew Jaynes 5effdb5445 Docs: Clarify documentation for `WP_Role::has_cap()` to more clearing indicate that the method checks for capabilities against the role rather than the user.
Also updates syntax in the DocBlock summary and description.

Props GunGeekATX for the initial patch.
Fixes #35080.


git-svn-id: https://develop.svn.wordpress.org/trunk@35935 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 20:04:39 +00:00
Boone Gorges 42fe7609c7 Omit `cpage` query var in comment link if comment pagination is disabled.
WP 4.4 changed the way comment pagination is calculated. See #8071. In the
context of `get_comment_link()`, these changes introduced a regression that
causes `cpage` (or its pretty-permalink correlate `comment-page-x`) to appear
in comment links when comment pagination is disabled. The current changeset
fixes the regression.

Fixes #34946.

git-svn-id: https://develop.svn.wordpress.org/trunk@35933 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 19:45:45 +00:00
Boone Gorges 4732139799 Don't use `array_merge()` when building comment children arrays.
`array_merge()` is much slower than building the combined array using a
`foreach` loop. The performance difference was causing a speed regression with
the `get_children()` functionality introduced in 4.4.

Props rogerhub.
Fixes #35025.

git-svn-id: https://develop.svn.wordpress.org/trunk@35931 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 19:36:05 +00:00
Drew Jaynes 293de63969 Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Http_Curl::stream_headers()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35930 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 19:20:58 +00:00
Drew Jaynes b3f7fd1741 Docs: Add more complete property and method documentation for `Walker_Page`.
* Adds missing DocBlock summaries
* Adds missing `@param` descriptions
* Marks some optional parameters as such
* Reorders some DocBlock tags

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35929 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 18:05:06 +00:00
Drew Jaynes 3ea73eb0d9 Docs: Add a missing description for the `$id` parameter in the DocBlock for `Walker_PageDropdown::start_el()`, which is implemented by `Walker` but unused by the subclass method.
Also marks the other optional parameters as such.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35928 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 17:53:49 +00:00
Drew Jaynes 0794999be8 Docs: Document the `$id` parameter for `Walker_Comment::start_el()`, which is implemented by `Walker` but unused in the subclass method.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35927 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 17:49:22 +00:00
Drew Jaynes 4f765b688a Docs: Document the `$id` parameter for `Walker_CategoryDropdown::start_el()`, which is implemented by `Walker` but unused in the subclass method.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35926 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 17:46:27 +00:00
Andrea Fercia e17a5cee94 Authentication modal dialog: the spinner should disappear when loading is done.
Also, when using spinners as background images, the re-painted area should be the
smallest possible one. See similar performance issue in #33311.

Fixes #34951.

git-svn-id: https://develop.svn.wordpress.org/trunk@35925 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 16:39:48 +00:00
Andrea Fercia f20dc0f0ee Accessibility: Remove title attributes from the Network Themes list table.
Title attributes in the "Themes" screen and in the "Edit Site" screen Themes tab
are now replaced with `aria-label` attributes. Also, replaces string
concatenation with `add_query_arg()` and `sprintf()` to allow translator
comments to be properly parsed and for better code readability.

Props SergeyBiryukov, afercia.
Fixes #35051.

git-svn-id: https://develop.svn.wordpress.org/trunk@35924 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 16:06:55 +00:00
Sergey Biryukov 3cf74baa5b I18N: Remove `<strong>` tags from translatable strings in `WP_Customize_Manager::register_controls()` and `WP_Customize_Header_Image_Control::render_content()`.
Add translator comments.

See #35039.

git-svn-id: https://develop.svn.wordpress.org/trunk@35923 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 12:53:37 +00:00
Dion Hulse 7b273d6a5c Update random_compat to latest master (~1.1.5)
Changes:
 * Checks `disable_classes` for `COM()` before using to avoid PHP Warnings
 * Uses `stream_set_chunk_size()` to avoid reading 8KiB from `/dev/urandom` unintentionally.
See #34948


git-svn-id: https://develop.svn.wordpress.org/trunk@35922 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 07:45:13 +00:00
Sergey Biryukov c2d8c86b93 Docs: Capitalize 'URL' correctly in `the_guid()` DocBlock. Fix a typo.
See #32246.

git-svn-id: https://develop.svn.wordpress.org/trunk@35920 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 05:20:25 +00:00
Dion Hulse f9cd8c4d15 HTTP: Partially revert [34283] which removed the 1024bit certificates from our trust store.
Most browsers no longer trust 1024bit certificates, or certificates signed by them, instead verifying them by a trusted intermediate or a cross-sign from another trusted certificate.

Unfortunately, as it turns out, OpenSSL prior to 1.0.1g cannot correctly handle certificates chains such as this, even if one of the intermediates is trusted.
The solution is that we need to continue to trust the 1024bit legacy root certificates forthe foreseeable future

This adds the following certificates back into our trust store:
{{{
GTE CyberTrust Global Root
Thawte Server CA
Thawte Premium Server CA
Verisign Class 3 Public Primary Certification Authority
Verisign Class 3 Public Primary Certification Authority - G2
ValiCert Class 1 VA
ValiCert Class 2 VA
RSA Root Certificate 1
Entrust.net Secure Server CA
Equifax Secure Global eBusiness CA
Equifax Secure eBusiness CA 1
America Online Root Certification Authority 1
America Online Root Certification Authority 2
NetLock Business (Class B) Root
NetLock Express (Class C) Root
Verisign Class 3 Public Primary Certification Authority
}}}

Props rmccue
Fixes #34935 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@35919 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 05:19:24 +00:00
John Blackbourn 6b718eaa83 Correct the position of the `$alt` parameter's `@param` doc in `image_add_caption()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35918 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 03:00:09 +00:00
jeremyfelt 5f5898d200 MS: Fix pagination in MS Sites List Table when entering a page number.
When a page number is manually entered in the sites list table and no bulk action is selected, add `paged` as a query argument to the redirect.

Fixes #32982.


git-svn-id: https://develop.svn.wordpress.org/trunk@35917 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:58:22 +00:00
John Blackbourn 11b969c95b Correct some `@param` doc names in the `WP_Tax_Query` and `WP_User_Query` classes.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35916 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:49:54 +00:00
John Blackbourn 8c6d4d5d83 Correct a parameter name in the `@param` docs for `get_home_url()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35915 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:44:03 +00:00
John Blackbourn 860aa2dd98 Add missing `@param` docs to `wp_safe_redirect()` and `wp_sanitize_redirect()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35914 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:42:29 +00:00
John Blackbourn cb068034ee Add missing `@param` doc to `wp_hash()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35913 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:38:10 +00:00
John Blackbourn f4c5b65138 Add missing variadic markers to the optional parameters of `do_action()` and `apply_filters()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35912 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:35:29 +00:00
John Blackbourn 823c734524 Revert [35910].
git-svn-id: https://develop.svn.wordpress.org/trunk@35911 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:34:42 +00:00
John Blackbourn 70d44588ce git-svn-id: https://develop.svn.wordpress.org/trunk@35910 602fd350-edb4-49c9-b593-d223f7449a82 2015-12-14 02:32:04 +00:00
John Blackbourn a8ee60eebc Add missing `@param` doc to `wp_check_password()` and update the `check_password` filter docs.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35909 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:29:04 +00:00
John Blackbourn 69c27ec4fc Correct the name of the `@param` doc for `WP_Query::parse_tax_query()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35908 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:07:14 +00:00
John Blackbourn 29b1f4484e Add a missing `@param` doc to `wp_update_term_count()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35907 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:03:21 +00:00
John Blackbourn bc4e0a1c4e Remove a redundant `@param` tag from `the_taxonomies()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35906 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 02:01:43 +00:00
Andrea Fercia a366c4fde3 Accessibility: remove title attributes from the available headers in the (no more used) `custom-header.php` screen.
Fixes #35062.

git-svn-id: https://develop.svn.wordpress.org/trunk@35905 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 00:08:24 +00:00
Pascal Birchler 94da64bff3 Docs: Improve documentation for `format_for_editor()` and the `'the_editor_content'` filter it is hooked to.
Props AramZS for initial patch.
Fixes #34866.

git-svn-id: https://develop.svn.wordpress.org/trunk@35904 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 19:21:32 +00:00
Sergey Biryukov 81a9fe9c09 I18N: Use better context for post statuses.
See #35054.

git-svn-id: https://develop.svn.wordpress.org/trunk@35903 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 19:17:10 +00:00
Sergey Biryukov 4e130ed78f I18N: Use better context for comment statuses.
See #35054.

git-svn-id: https://develop.svn.wordpress.org/trunk@35902 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 19:10:04 +00:00
Sergey Biryukov 3068a5b333 I18N: Add missing context for 'Trash' strings.
Fixes #35054.

git-svn-id: https://develop.svn.wordpress.org/trunk@35901 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 19:02:30 +00:00
Sergey Biryukov f5d2251f50 List tables: After [34006], remove unnecessary context from 'View' string, for consistency with other strings in the same context.
Props MikeHansenMe, subharanjan.
Fixes #34914.

git-svn-id: https://develop.svn.wordpress.org/trunk@35900 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 18:36:22 +00:00
Sergey Biryukov b0f06b48aa Customizer: Change "Display Header Text" checkbox label to "Display Site Title and Tagline", to make it clearer that it affects both settings.
Props juanfra, vlad.olaru.
Fixes #31829.

git-svn-id: https://develop.svn.wordpress.org/trunk@35899 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 17:49:51 +00:00
Sergey Biryukov 94005d9402 Credits: After [26354], replace another instance of the "Contributing to WordPress" Codex link with http://make.wordpress.org/.
Remove redundant translator comments, add comments for placeholders instead.

See #25806.

git-svn-id: https://develop.svn.wordpress.org/trunk@35898 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 15:23:54 +00:00
Pascal Birchler 5d302ca4d2 Login: After [34213], use the `login_post` scheme again for login forms.
See #34925.

git-svn-id: https://develop.svn.wordpress.org/trunk@35897 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 14:02:04 +00:00
Pascal Birchler d0ef84ea8c Admin: After [35128], make the 'Configure' link work again for dashboard widgets.
See #34987.

git-svn-id: https://develop.svn.wordpress.org/trunk@35896 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 13:56:49 +00:00
Sergey Biryukov 5cae9f6aba Docs: Improve documentation for `wp_count_terms()`.
Props bordoni, swissspidy.
Fixes #34861.

git-svn-id: https://develop.svn.wordpress.org/trunk@35895 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 12:10:26 +00:00
Andrea Fercia 6e3838503c Dashboard: remove not clickable spaces between icons and links in the "At a Glance" panel. Also, some CSS cleanup.
Props 5um17 for the initial patch.
Fixes #27813.

git-svn-id: https://develop.svn.wordpress.org/trunk@35894 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 12:00:12 +00:00