Commit Graph

27973 Commits

Author SHA1 Message Date
Ian Stewart 0dcb810a91 Twenty Fifteen: escaping for the HTML5 shiv call.
Props philiparthurmoore, fixes #30212




git-svn-id: https://develop.svn.wordpress.org/trunk@30218 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 21:46:02 +00:00
Ian Stewart 17f38859e5 Twenty Fifteen: kern everything -- it reads better.
Props afercia, fixes #30195.




git-svn-id: https://develop.svn.wordpress.org/trunk@30217 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 21:42:11 +00:00
Ian Stewart 688d75c18f Twenty Fifteen: Use new core navigation tags.
Props obenland, iamtakashi, fixes #30189




git-svn-id: https://develop.svn.wordpress.org/trunk@30216 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 21:39:37 +00:00
Ian Stewart 1faa0f1622 Twenty Fifteen: Make sure that the edit link will always be right of it's icon.
Props iamtakashi, fixes #30171.




git-svn-id: https://develop.svn.wordpress.org/trunk@30215 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 21:35:31 +00:00
Dominik Schilling (ocean90) 507243a3e2 Customizer: Add stable sorting for panels, sections and controls in JS. Improve sorting in PHP.
props westonruter.
fixes #30225.

git-svn-id: https://develop.svn.wordpress.org/trunk@30214 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 21:34:44 +00:00
Ian Stewart bd07bf4575 Twenty Fifteen: nicer styles for playlists.
Props iamtakashi, fixes #30163



git-svn-id: https://develop.svn.wordpress.org/trunk@30213 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 19:32:10 +00:00
Ian Stewart 0d1cd76c06 Twenty Fifteen: add a fallback icon for social links where we don't have an icon
Props iamtakashi, fixes #30148



git-svn-id: https://develop.svn.wordpress.org/trunk@30212 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 19:01:53 +00:00
Ian Stewart 0788bccc0c Twenty Fifteen: prevent a flash of visible sub menus before scripts load.
Props mattwiebe, aferica, fixes #30056.



git-svn-id: https://develop.svn.wordpress.org/trunk@30211 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 18:57:22 +00:00
Boone Gorges 67871ba641 Improve docblocks for `get_the_taxonomies()` and `the_taxonomies()`.
* In `the_taxonomies()`, only document those arguments that are specific to the function. Arguments shared with `get_the_taxonomies()` should be documented in the later function's docblock.
* Add $args hash documentation to `get_the_taxonomies()`.
* Remove the redundant default argument definition in `the_taxonomies()`.

Fixes #27238.

git-svn-id: https://develop.svn.wordpress.org/trunk@30210 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 18:48:50 +00:00
Boone Gorges 9c13546518 Introduce `term_template` param to `get_the_taxonomies()`.
This parameter allows theme and plugin authors to specify the formatting they
would like on the term links as they are parsed into the taxonomy list.

Props hereswhatidid, dlh, davidjlaietta.
See #27238.

git-svn-id: https://develop.svn.wordpress.org/trunk@30209 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 18:48:42 +00:00
Ian Stewart 48c4599347 Twenty Fifteen: make it clear that a link is a link in post and comment meta by underlining it on hover or focus
Props morganestes, iamtakashi, fixes #30108



git-svn-id: https://develop.svn.wordpress.org/trunk@30208 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 17:00:06 +00:00
Boone Gorges 2b6df5f8ce Ignore case when checking string 'false' in `wp_validate_boolean()`.
Props TobiasBg, kitchin.
Fixes #30238.

git-svn-id: https://develop.svn.wordpress.org/trunk@30207 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 15:54:42 +00:00
Boone Gorges 1219355f2b Add unit tests for `wp_validate_boolean()`.
Props TobiasBg.
See #30238.

git-svn-id: https://develop.svn.wordpress.org/trunk@30206 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 15:51:11 +00:00
Boone Gorges f744ee189e In `in_object_in_term()`, only check numeric string values against term_id.
The previous `in_array()` check was playing too loose with mixed types, such
that a string like '10_term_name' would incorrectly match a term_id 10.

Props nobinobi, realloc.
Fixes #29467.

git-svn-id: https://develop.svn.wordpress.org/trunk@30205 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 14:24:23 +00:00
Boone Gorges fc8da37358 Add some unit tests for `is_object_in_term()`.
These tests check a number of the ways that different kinds of values for
`$terms` (integers that match term_id, strings that match term_id or name or
slug) are handled.

See #29467.

git-svn-id: https://develop.svn.wordpress.org/trunk@30204 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 14:24:17 +00:00
Scott Taylor 6c5e90eaa5 Correct some types in `wp-admin/*`-location files' doc blocks.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30203 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 07:08:16 +00:00
Scott Taylor 3942ff4616 Correct all `@return unknown` instances.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30202 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:16:34 +00:00
Scott Taylor ba85fbacba Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/deprecated.php` (pour one out).
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30201 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:07:26 +00:00
Scott Taylor e4b0a71ebd Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/misc.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30200 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:00:25 +00:00
Scott Taylor 884d27ea00 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/plugin.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30199 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:58:14 +00:00
Scott Taylor 8ddca875b5 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/post.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30198 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:54:04 +00:00
Scott Taylor 53df5b1a61 Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/taxonomy.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30197 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:49:57 +00:00
Scott Taylor 43d027f2af Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/template.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30196 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:44:33 +00:00
Scott Taylor aff2817015 Fill in the `@param` types for the args for `make_site_theme_from_default()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30195 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:42:06 +00:00
Scott Taylor 00d5b388c3 Fill in the `@param` types for the args for `make_site_theme_from_oldschool()`, which is actually the name of a function?
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30194 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:40:30 +00:00
Scott Taylor fa5b45c42a Fill in the `@param` types for the args for `dbDelta()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30193 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:39:08 +00:00
Scott Taylor d3d38505ea Fill in the `@param` types for the args in `WP_Text_Diff_Renderer_Table->interleave_changed_lines()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30192 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:38:34 +00:00
Scott Taylor 2443090c23 Correct the `@param` type for the `$query` arg for `remove_query_arg()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30191 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:28:47 +00:00
Scott Taylor 7ea8e0cb6a Fill in types for the `@param`s for `wp_comment_reply()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30190 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:20:43 +00:00
Scott Taylor 30e637cd93 Correct type in the doc block for `get_theme_support()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30189 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:17:05 +00:00
Scott Taylor cd8f6b881c Correct the return value doc block for `get_theme_support()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30188 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:16:33 +00:00
Scott Taylor c502804272 In `Custom_Image_Header`:
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403]. 
* Declare `$updated` as a property.

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30187 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:14:11 +00:00
Scott Taylor 19eb835aee In `Custom_Background`, declare `$updated` as a property.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30186 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:07:49 +00:00
Scott Taylor 3663a276f1 In `wp_audio|video_shortcode()`, make sure that `autoplay` and `loop` are booleans. Passing `'false'` to them will force them to be active, which is bad.
Fixes #29825.


git-svn-id: https://develop.svn.wordpress.org/trunk@30185 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:02:18 +00:00
Scott Taylor 152e977a6b In `WP_Tax_Query`, declare `$primary_table` and `$primary_id_column` as properties.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30184 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:44:54 +00:00
Scott Taylor 4c74c4a298 In `WP_Locale`, declare `$number_format` as a property.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30183 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:39:01 +00:00
Scott Taylor bfa6702145 In `WP_Comment_Query`, declare `$query_vars` and `$comments` as properties.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30182 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:07:42 +00:00
Scott Taylor 43d5210cfa Almost every method in `wp_xmlrpc_server` can also return `IXR_Error` and should be labeled as such. Rehabilitate some `return` syntax.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30181 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:03:30 +00:00
Scott Taylor 345a63f498 `WP_Image_Editor_GD` and `WP_Image_Editor_Imagick` should specify type in a doc block for the `$image` property, instead of inferring `bool` and `null`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30180 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 02:37:55 +00:00
Scott Taylor 204bab92c2 In `WP_HTTP_IXR_Client`:
* declare `$scheme` as a property, it doesn't exist on the parent class
* declare `$error` as a property of type `IXR_Error`, instead of it being inferred as `boolean` from the parent class

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30179 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 02:31:39 +00:00
Scott Taylor 31df6204d0 Fix the return docs for `WP_Embed->maybe_make_link()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30178 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 02:26:34 +00:00
Jeremy Felt 90aa65e0f7 Use common core syntax for checking DOING_AJAX
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891


git-svn-id: https://develop.svn.wordpress.org/trunk@30177 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-02 02:23:28 +00:00
Jeremy Felt 47e01357aa Delete admin_created_user_subject() rather than deprecate
As it was never used as anything more than a callback to a filter before the MU merge, and is only available in user-new.php in multisite, it is safe to remove this function entirely.

Fixes #29915


git-svn-id: https://develop.svn.wordpress.org/trunk@30176 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-02 02:06:20 +00:00
Jeremy Felt 6f88946089 Improve layout of test for cached invalid, then valid site details
* Rename method to `test_get_blog_details_when_site_does_not_exist()`.
* Always assume `MAX(blog_id)` is 1 and therefore always create a burner.
* Remove tests specific to `wpmu_delete_blog()` and cache, to be handled elsewhere.
* Remove extra asertions.

See #30080, #23405


git-svn-id: https://develop.svn.wordpress.org/trunk@30175 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-02 01:04:47 +00:00
Jeremy Felt 85aa2ef76e Split tests for wp_get_sites()
Test various arguments for `wp_get_sites()` in a more intentful way rather than in one large test. Leave tests for limit and offset together for convenience.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30174 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:39:22 +00:00
Scott Taylor 105cd50bdf In `_WP_Editors::editor_settings()`, `$str1` and `$str2` don't need to be initialized empty.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30173 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:21:07 +00:00
Scott Taylor b808e1af70 Declare the `$uploaded_headers` and `$default_headers` properties for `WP_Customize_Header_Image_Control`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30172 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:17:48 +00:00
Scott Taylor 7acb2c8eb1 Declare the `$update_count` and `$update_current` properties for `WP_Upgrader`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30171 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:06:38 +00:00
Scott Taylor 729bd580ab Declare the `$options` property for `WP_Upgrader_Skin`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30170 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:02:52 +00:00
Scott Taylor bb9f04baa8 Fix the return value doc for `WP_List_Table->get_pagination_arg()`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30169 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:59:48 +00:00