Sergey Biryukov
72fb826044
Widgets: Remove extra quotes from widget title in WP_Widget_RSS
, accidentally added in [33814].
...
Props ShinichiN.
Fixes #34978 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@35978 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 22:34:55 +00:00
Andrea Fercia
660608f219
Accessibility: Correctly associate the search input label in the new Themes favorites tab introduced in [35527].
...
Fixes #35122 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35977 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 22:29:38 +00:00
Pascal Birchler
ca529a52fd
Docs: Document the default value for the $validate
parameter in the validate_current_theme
hook docs.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35976 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 20:09:58 +00:00
Pascal Birchler
f8909ca7d6
Docs: Clarify the return value for wp_create_categories()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35975 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 19:58:40 +00:00
Pascal Birchler
9dbca6b6c3
Docs: Correct a parameter name for the press_this_redirect_in_parent
filter.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35974 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 19:42:46 +00:00
Pascal Birchler
505fc319c7
Docs: Correct a parameter name for the force_filtered_html_on_import
filter.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35973 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 19:39:34 +00:00
Pascal Birchler
b041e9b189
Docs: Correct a parameter name for the validate_current_theme
filter.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35972 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 19:35:20 +00:00
Pascal Birchler
44f82fcc70
Docs: Correct a parameter name for the allow_subdirectory_install
filter.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35971 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 19:31:30 +00:00
Pascal Birchler
9a9e2f6a5a
Docs: Correct a parameter name for the do_mu_upgrade
filter.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35970 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 19:29:12 +00:00
John Blackbourn
4ae4883372
Correct a parameter name for the allow_password_reset
filter so its entry on developer.wordpress.org displays correctly.
...
See #32246
git-svn-id: https://develop.svn.wordpress.org/trunk@35969 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 19:19:26 +00:00
Drew Jaynes
7a5128c4b0
Docs: Add missing parameter descriptions to the DocBlock for WP_Query::set_found_posts()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35968 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 18:10:59 +00:00
Drew Jaynes
d4b779fd47
Docs: Add a missing summary to the DocBlock for WP_Locale::rtl_src_admin_notice()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35967 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 18:07:29 +00:00
Drew Jaynes
036f50b7d2
Docs: Mark the upgrade_XX()
functions to be ignored from parsing for the Code Reference.
...
There is no great value in generating reference pages for these funcitons as they explicitly serve a core-only purpose.
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35966 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 17:58:35 +00:00
Drew Jaynes
d8aea7de83
Docs: Add missing DocBlocks, including summaries and @since
versions, to the __construct()
and init()
methods in WP_Scripts
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35965 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 17:47:07 +00:00
Drew Jaynes
193c0fe9a2
Docs: Add a missing summary, @since
version, and parameter descriptions to the DocBlock for wp_xmlrpc_server::pingback_error()
.
...
Introduced in [23329]. Also corrects return descriptions for two deprecated methods.
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35964 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 17:37:33 +00:00
Drew Jaynes
62d70a58a3
Docs: Add a missing summary, @since
version, and parameter descriptions to the DocBlock for wp_xmlrpc_server::add_enclosure_if_new()
.
...
Introduced in [10383].
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35963 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 17:31:10 +00:00
Drew Jaynes
86d78d3975
Docs: Add missing notations for the unused $args
parameter in the blogger_getTemplate()
and blogger_setTemplate()
methods in wp_xmlrpc_server
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35962 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 17:25:02 +00:00
Drew Jaynes
7b51c13f17
Docs: Add missing property and method summaries in DocBlocks for Walker_PageDropdown
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35961 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 16:35:11 +00:00
Sergey Biryukov
d727e3b516
KSES: Allow the reversed
attribute for <ol>
.
...
Props lancewillett.
Fixes #35079 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35960 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 09:53:18 +00:00
Sergey Biryukov
959f377c3e
I18N: Add a unit test for before_last_bar()
.
...
Props realloc.
Fixes #35073 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35959 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 08:03:38 +00:00
Sergey Biryukov
b5b92d9cbd
Accessibility: Add missing label for the theme upload input.
...
See [11152] for plugins.
Props mercime.
Fixes #35113 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35958 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 07:55:31 +00:00
Drew Jaynes
a9d3c9cc91
Docs: Add a missing notation for the $args
parameter in the DocBlock for wp_xmlrpc_server::_multisite_getUsersBlogs()
.
...
Also adds a missing `@since` version. The method was introduced in [12852].
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35957 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 05:48:10 +00:00
Drew Jaynes
f40efb487a
Docs: Add a missing summary and @since
version to the DocBlock for wp_xmlrpc_server::serve_request()
.
...
Introduced in [11789].
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35956 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 05:42:11 +00:00
Drew Jaynes
57aa67b2cf
Docs: Add missing summaries and @since
versions to DocBlocks for the _get_display_callback()
, _get_update_callback()
, and _get_form_callback()
methods in WP_Widget
.
...
Introduced in [10764].
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35955 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 05:38:46 +00:00
Drew Jaynes
228c200b35
Docs: Add variadic markers to the optional $object_id
parameter notation for WP_User::has_cap()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35954 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 05:31:27 +00:00
Andrea Fercia
e222e3e273
Accessibility: Remove title attributes from the Plugin Cards on the Plugin install screen.
...
Fixes #35050 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35953 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 22:32:15 +00:00
Andrea Fercia
e7296c25b9
Accessibility: add missing labels for Plugins and Themes checkboxes in the Updates screen.
...
Also, adds translator comments and improves readability.
Props SergeyBiryukov, afercia, oaron for the initial patch.
Fixes #34774 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35952 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 22:17:40 +00:00
Sergey Biryukov
333f1c38ea
I18N: After [35884], remove html_entity_decode()
for the thousands separator in WP_Locale::init()
, use the
entity directly.
...
We can't `get_option( 'blog_charset' )` here, because the database may not be available.
Fixes #10373 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35951 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 21:34:15 +00:00
Dominik Schilling (ocean90)
019f7ec6b5
Revert [35949].
...
Passing an object to `wp_list_pluck()` throws also a fatal error, see https://3v4l.org/9YsaD .
See #35087 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35950 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 19:49:43 +00:00
Pascal Birchler
666d0736f4
Ensure wp_list_pluck()
throws a warning when not being passed an array.
...
We should not paper over the code and hide warnings from developers by casting values to an array.
See #35087 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35949 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 18:28:55 +00:00
Rachel Baker
c2943ef70a
Comments: Use an integer as the default value for comment_post_ID
in wp_insert_comment
to match database column.
...
Props MikeHansenMe, juanfra, rabmalin.
Fixes #34956
git-svn-id: https://develop.svn.wordpress.org/trunk@35948 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 15:12:50 +00:00
Andrea Fercia
8da5918fbc
Accessibility: Add an ARIA role button
to links that behave like buttons when JavaScript is on.
...
Introduces a simple way to give a proper semantics of `button` to links that behave
like UI controls when JavaScript is on and behave like actual links when JavaScript
is off. First implementation on the Terms list table.
Patch prepared during WordCamp US 2015 Contributor Day.
Props mcapybara, garusky, takayukister.
See #26504 .
Fixes #34867 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35947 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 13:24:13 +00:00
Dion Hulse
9249f66609
Filesystem: Avoid PHP warnings when using the FTP Sockets class.
...
See #35026
git-svn-id: https://develop.svn.wordpress.org/trunk@35946 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 03:11:17 +00:00
Dion Hulse
5564545ea8
Filesystem: Revert [33648] and [34733] unfortunately these have caused issues for some servers, while fixing it for others.
...
See #28013
Fixes #34976 for trunk
Fixes #34976 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@35944 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 02:35:26 +00:00
Weston Ruter
d33deeeb74
Customize: Ensure that "Change" button appears when there are only 2 themes.
...
Fixes defect introduced in [35535].
Props igmoweb.
See #34549 .
Fixes #35081 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35943 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 01:20:49 +00:00
Dion Hulse
f6972f0fae
Filesystem API: Cast the port to an int in the FTPSockets class. PemFTP requires that the port be specified as an integer, not a numeric string.
...
Fixes #35088
git-svn-id: https://develop.svn.wordpress.org/trunk@35942 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-15 00:28:59 +00:00
Drew Jaynes
6de1483105
Docs: Add missing parameter and return descriptions to the DocBlock for WP_Rewrite::iis7_url_rewrite_rules()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35941 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:57:09 +00:00
Drew Jaynes
83b882ebe2
Docs: Add missing parameter documentation for the $args
parameter in the DocBlock for WP_Http_Streams::test()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35940 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:53:44 +00:00
Drew Jaynes
ec3f5efbf9
Docs: Remove an extra 'arguments' introduced in [35938].
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35939 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:51:50 +00:00
Drew Jaynes
43857268a9
Docs: Add missing parameter documentation for the $args
parameter in the DocBlock for WP_Http_Curl::test()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35938 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:42:54 +00:00
Drew Jaynes
e20a31a888
Docs: Add missing parameter and return descriptions to the DocBlock for WP_Http_Curl::stream_body()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35937 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 23:40:55 +00:00
Drew Jaynes
5effdb5445
Docs: Clarify documentation for WP_Role::has_cap()
to more clearing indicate that the method checks for capabilities against the role rather than the user.
...
Also updates syntax in the DocBlock summary and description.
Props GunGeekATX for the initial patch.
Fixes #35080 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35935 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 20:04:39 +00:00
Boone Gorges
42fe7609c7
Omit cpage
query var in comment link if comment pagination is disabled.
...
WP 4.4 changed the way comment pagination is calculated. See #8071 . In the
context of `get_comment_link()`, these changes introduced a regression that
causes `cpage` (or its pretty-permalink correlate `comment-page-x`) to appear
in comment links when comment pagination is disabled. The current changeset
fixes the regression.
Fixes #34946 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35933 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 19:45:45 +00:00
Boone Gorges
4732139799
Don't use array_merge()
when building comment children arrays.
...
`array_merge()` is much slower than building the combined array using a
`foreach` loop. The performance difference was causing a speed regression with
the `get_children()` functionality introduced in 4.4.
Props rogerhub.
Fixes #35025 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35931 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 19:36:05 +00:00
Drew Jaynes
293de63969
Docs: Add missing parameter and return descriptions to the DocBlock for WP_Http_Curl::stream_headers()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35930 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 19:20:58 +00:00
Drew Jaynes
b3f7fd1741
Docs: Add more complete property and method documentation for Walker_Page
.
...
* Adds missing DocBlock summaries
* Adds missing `@param` descriptions
* Marks some optional parameters as such
* Reorders some DocBlock tags
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35929 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 18:05:06 +00:00
Drew Jaynes
3ea73eb0d9
Docs: Add a missing description for the $id
parameter in the DocBlock for Walker_PageDropdown::start_el()
, which is implemented by Walker
but unused by the subclass method.
...
Also marks the other optional parameters as such.
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35928 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 17:53:49 +00:00
Drew Jaynes
0794999be8
Docs: Document the $id
parameter for Walker_Comment::start_el()
, which is implemented by Walker
but unused in the subclass method.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35927 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 17:49:22 +00:00
Drew Jaynes
4f765b688a
Docs: Document the $id
parameter for Walker_CategoryDropdown::start_el()
, which is implemented by Walker
but unused in the subclass method.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35926 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 17:46:27 +00:00
Andrea Fercia
e17a5cee94
Authentication modal dialog: the spinner should disappear when loading is done.
...
Also, when using spinners as background images, the re-painted area should be the
smallest possible one. See similar performance issue in #33311 .
Fixes #34951 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35925 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-14 16:39:48 +00:00