Commit Graph

136 Commits

Author SHA1 Message Date
Gary Pendergast
4943b377ce Coding Standards: Move wp-includes/class-oembed.php to wp-includes/class-wp-oembed.php.
This renames the file containing the `WP_oEmbed` class to conform to the coding standards.

This commit also includes:

- A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45663 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-19 04:31:40 +00:00
Gary Pendergast
4503f93961 Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes.
See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45590 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-02 23:41:16 +00:00
John Blackbourn
9ca74cade9 Embeds: Remove the "Supports HTTPS" column from the whitelisted oEmbed provider list now that all supported providers use HTTPS.
See #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@45386 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 21:22:23 +00:00
John Blackbourn
3a08a2ca34 Embeds: Use HTTPS for the Hulu oEmbed endpoint, as it redirects to HTTPS now.
Fixes #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@45385 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 21:19:50 +00:00
John Blackbourn
beb4a31c36 Embeds: Update the Crowdsignal embed handler so that surveys on subdomains are supported.
Props kraftbj

Fixes #46467


git-svn-id: https://develop.svn.wordpress.org/trunk@45061 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 21:26:20 +00:00
Sergey Biryukov
a630f23731 Embeds: Scribd: Add support for /document/ URL format, in addition to /doc/.
Props manzoorwani.jk, neobabis, swissspidy.
Fixes #46444.

git-svn-id: https://develop.svn.wordpress.org/trunk@45024 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 00:33:47 +00:00
Jonathan Desrosiers
7508db604b Embeds: Remove Photobucket, FunnyOrDie from the list of oEmbed providers.
These services no longer support oEmbed.

Props skostadinov, notnownikki.
Fixes #45399.

git-svn-id: https://develop.svn.wordpress.org/trunk@44552 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-10 22:41:13 +00:00
Pascal Birchler
a5594e7b07 Embeds: Fix typo introduced in [44484].
Props JustinSainton.
Fixes #45036.


git-svn-id: https://develop.svn.wordpress.org/trunk@44511 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-09 10:53:14 +00:00
Gary Pendergast
d2f0d5c812 Embeds: Add Instagram TV support.
Props dannydehaan.
Fixes #44557.



git-svn-id: https://develop.svn.wordpress.org/trunk@44486 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-09 00:23:35 +00:00
Gary Pendergast
78064d5ce3 Embeds: Polldaddy is now called Crowdsignal.
Crowdsignal adds an additional embed URL, survey.fm.

Props donncha.
Fixes #45036.



git-svn-id: https://develop.svn.wordpress.org/trunk@44484 602fd350-edb4-49c9-b593-d223f7449a82
2019-01-08 23:51:25 +00:00
Drew Jaynes
931777debb Docs: Remove erroneous pipe character usage in the oembed_providers filter DocBlock.
Avoids markdown table display errors when parsed and displayed in the Code Reference.

See #42505.


git-svn-id: https://develop.svn.wordpress.org/trunk@44333 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-19 16:35:30 +00:00
Gary Pendergast
f61cfa648c Embeds: Filter HTML response in oEmbed proxy controller.
Adapts the response from `WP_oEmbed_Controller::get_proxy_item()` so that the response is correctly filtered and embeds work properly in JavaSccript editors. Introduces new `get_oembed_response_data_for_url()` function for preparing internal oEmbed responses.

Merges [43810] from the 5.0 branch to trunk.

Props danielbachhuber, imath, swissspidy.
Fixes #45142.



git-svn-id: https://develop.svn.wordpress.org/trunk@44154 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-14 03:19:48 +00:00
Gary Pendergast
a75d153eee Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.



git-svn-id: https://develop.svn.wordpress.org/trunk@43571 602fd350-edb4-49c9-b593-d223f7449a82
2018-08-17 01:50:26 +00:00
John Blackbourn
d541798a64 Docs: Document more parameters and properties using typed array notation.
See #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@42875 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-25 18:09:56 +00:00
Sergey Biryukov
c89d25560b Docs: Remove @static notations from property DocBlocks in wp-admin/* and wp-includes/* classes.
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.

Props birgire.
See #42803.

git-svn-id: https://develop.svn.wordpress.org/trunk@42747 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-25 20:31:33 +00:00
Sergey Biryukov
c6c4edb47a Docs: Remove @static notations from method DocBlocks in wp-includes/* classes.
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.

Props birgire.
See #42803.

git-svn-id: https://develop.svn.wordpress.org/trunk@42746 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-25 20:21:37 +00:00
Gary Pendergast
8f95800d52 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-30 23:09:33 +00:00
John Blackbourn
fc40dea2fd Docs: Correct parameter type documentation for various __call() methods.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42151 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-10 22:56:01 +00:00
John Blackbourn
93fc60f36a Embeds: Add oEmbed support for someecards.com.
Props someecards

Fixes #40792


git-svn-id: https://develop.svn.wordpress.org/trunk@41681 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-02 19:09:46 +00:00
John Blackbourn
a89374bc30 Embeds: Switch the collegehumor.com oEmbed endpoint to HTTPS, as it redirects there by default now.
See #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@41680 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-02 19:05:18 +00:00
John Blackbourn
493805239e Embeds: Alignment following [41615].
See #38181


git-svn-id: https://develop.svn.wordpress.org/trunk@41676 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-02 18:37:53 +00:00
John Blackbourn
9d23f61503 Embeds: Documentation alignment following [41615].
See #38181


git-svn-id: https://develop.svn.wordpress.org/trunk@41616 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-27 13:26:53 +00:00
John Blackbourn
c2e30ec382 Embeds: Add support for Amazon Kindle instant previews.
Props jsepia, morganestes, adamsilverstein, swissspidy, jbpaul17, johnbillion, rugved

Fixes #38181


git-svn-id: https://develop.svn.wordpress.org/trunk@41615 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-27 13:25:06 +00:00
Dion Hulse
dd065164f4 Embeds: Switch the Imgur oEmbed endpoint to use SSL as the HTTP version has been deprecated.
Props swissspidy.
Fixes #41984.


git-svn-id: https://develop.svn.wordpress.org/trunk@41599 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-26 08:32:21 +00:00
John Blackbourn
7f3deb9988 Embeds: Remove support for oEmbedded videos from Vine.
* Vine effectively shut down in December 2016.
* The oEmbed endpoint no longer works and returns a 404.
* Developer documentation for Vine has been removed.

Fixes #41817


git-svn-id: https://develop.svn.wordpress.org/trunk@41347 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-08 15:00:33 +00:00
John Blackbourn
5c3d713beb Embeds: Add the dnt (Do Not Track) query parameter to all oEmbed provider URLs.
This means that, for those providers that support this somewhat de-facto standard, visitor tracking is disabled by default for all embeds.

Props norcross, joostdevalk

Fixes #41784


git-svn-id: https://develop.svn.wordpress.org/trunk@41345 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-08 12:30:03 +00:00
Drew Jaynes
b4d81bd654 Docs: Remove @access notations from method DocBlocks in wp-includes/* classes.
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.

See #41452.


git-svn-id: https://develop.svn.wordpress.org/trunk@41162 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-27 00:40:27 +00:00
Pascal Birchler
e67238f480 Embeds: Update oEmbed endpoint URL for VideoPress.
Props NomNom99.
Fixes #41019.

git-svn-id: https://develop.svn.wordpress.org/trunk@40901 602fd350-edb4-49c9-b593-d223f7449a82
2017-06-15 05:37:51 +00:00
James Nylen
d59f437268 REST API: Add endpoint for proxying requests to external oEmbed providers.
This endpoint is a prerequisite for the media widgets work (see https://github.com/xwp/wp-core-media-widgets).

Also use the new endpoint in the media modal instead of the `parse-embed` AJAX action.

Props westonruter, timmydcrawford, swissspidy, jnylen0.
Fixes #40450.


git-svn-id: https://develop.svn.wordpress.org/trunk@40628 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-11 18:18:00 +00:00
Pascal Birchler
9a2188dd56 Embeds: Add screencast.com to oEmbed provider whitelist.
Props ENDif Media.
Fixes #38367.


git-svn-id: https://develop.svn.wordpress.org/trunk@40574 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-06 14:24:37 +00:00
Sergey Biryukov
a0bdc5efe4 Embeds: After [31148], list correct method in WP_oEmbed::$compat_methods.
Props LewisCowles.
Fixes #39292.

git-svn-id: https://develop.svn.wordpress.org/trunk@40026 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-29 07:31:29 +00:00
Dominik Schilling (ocean90)
ade972bf86 Embeds: Realign the provider list after [38693].
See #38003.

git-svn-id: https://develop.svn.wordpress.org/trunk@38923 602fd350-edb4-49c9-b593-d223f7449a82
2016-10-25 20:15:45 +00:00
Dominik Schilling (ocean90)
41fc5ba881 Embeds: Add oEmbed support for User, List and Like Twitter timelines.
Props earnjam.
Fixes #38003.

git-svn-id: https://develop.svn.wordpress.org/trunk@38693 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-30 21:42:01 +00:00
Dominik Schilling (ocean90)
22d4eb63b6 Embeds: Add support for embedding Facebook photos of a user/page.
See #34737.

git-svn-id: https://develop.svn.wordpress.org/trunk@38691 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-30 20:39:32 +00:00
Sergey Biryukov
335cb0223f Embeds: Escape periods in oEmbed regex.
Props jrf.
Fixes #38187.

git-svn-id: https://develop.svn.wordpress.org/trunk@38684 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-30 11:24:08 +00:00
Sergey Biryukov
84b67c9e6b Docs: Correct 'Since' version number for Cloudup in oembed_providers filter description.
Props jrf.
Fixes #38188.

git-svn-id: https://develop.svn.wordpress.org/trunk@38675 602fd350-edb4-49c9-b593-d223f7449a82
2016-09-29 17:12:07 +00:00
John Blackbourn
87c1b26ee7 Docs: Correct various documentation around object and stdClass types.
See #37770


git-svn-id: https://develop.svn.wordpress.org/trunk@38369 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 16:48:17 +00:00
John Blackbourn
bc38f711cf Embeds: Add a missing regex delimiter for Facebook URLs.
See #34737


git-svn-id: https://develop.svn.wordpress.org/trunk@38368 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 12:16:56 +00:00
John Blackbourn
cb0048a6c5 Embeds: Add support for embedding Facebook posts and videos via oEmbed.
Fixes #34737
Props pento, GaryJ


git-svn-id: https://develop.svn.wordpress.org/trunk@38367 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 11:56:47 +00:00
John Blackbourn
d9b3ae759a Embeds: Many of our oEmbed providers now default to HTTPS embeds, redirect to the HTTPS oEmbed endpoint, or have complete support for HTTPS even if they don't default to HTTPS.
This change defaults to using HTTPS endpoints for oEmbeds for those providers that have full HTTPS support and don't redirect back to HTTP when clicking through from the embed. It covers:

* Vimeo
* SmugMug
* Scribd
* WordPress.tv
* SoundCloud
* Meetup
* issuu
* Mixcloud
* TED

See #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@38366 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 11:24:38 +00:00
John Blackbourn
acc91a60e0 Embeds: Always use the HTTPS endpoint for YouTube embeds. The scheme parameter is no longer required as all YouTube assets now use HTTPS.
See #36274, #28507
Props zsusag, tollmanz


git-svn-id: https://develop.svn.wordpress.org/trunk@38365 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 10:38:05 +00:00
Scott Taylor
1ff3356d22 OEmbed: move _wp_oembed_get_object() to embed.php, where all of the other embed functions live. WP_oEmbed is then in a file by itself. Load class-oembed.php in wp-settings.php and remove extraneous include calls.
See #37827.


git-svn-id: https://develop.svn.wordpress.org/trunk@38361 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 09:48:32 +00:00
Sergey Biryukov
5e99f1ef34 Embeds: Fix copy/paste error in WP_oEmbed::_add_provider_early() description.
Props ivantedja.
Fixes #37602.

git-svn-id: https://develop.svn.wordpress.org/trunk@38230 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-09 14:10:00 +00:00
Sergey Biryukov
b1f3926bcb Embeds: In WP_oEmbed::get_provider() and WP_oEmbed::get_html(), parse the $args string to an array, as we treat it as an array later.
See #37071.

git-svn-id: https://develop.svn.wordpress.org/trunk@37720 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 18:51:32 +00:00
Pascal Birchler
b2671c3880 Embeds: Improve performance when embedding a post from the current site.
When the post being embedded is from the same site, there's no reason to do an HTTP request for it. The data can be fetched directly using `get_oembed_response_data()`.

Fixes #36767 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@37708 602fd350-edb4-49c9-b593-d223f7449a82
2016-06-15 11:22:52 +00:00
Drew Jaynes
d11f7ed391 Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37518 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:49:05 +00:00
Drew Jaynes
195572596b Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.


git-svn-id: https://develop.svn.wordpress.org/trunk@37431 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-13 18:40:19 +00:00
Drew Jaynes
979d8931d3 Docs: Properly mark $args parameters in two WP_oEmbed methods as optional.
Also clarify that the `$args` parameters can accept a string (the default) in addition to an array.

Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37069 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 17:07:58 +00:00
Drew Jaynes
79150b2561 Docs: Use third-person singular verbs for summary DocBlocks in WP_oEmbed.
Also fixes inline `@see` formatting in appropriate places (summaries should not contain tags or markdown).

Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37068 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 16:57:08 +00:00
Drew Jaynes
d793244e3c Docs: Improve and add missing DocBlocks for methods and properties in WP_oEmbed.
Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37067 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 16:51:48 +00:00