Commit Graph

235 Commits

Author SHA1 Message Date
Ryan Boren
436b32ef62 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: https://develop.svn.wordpress.org/trunk@23567 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:14:09 +00:00
Ryan Boren
c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Ryan Boren
a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Ryan Boren
6610e321e7 Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@19528 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 04:51:35 +00:00
Ryan Boren
4ae0813953 Help tabs. Props chexee. see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19445 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-24 00:21:39 +00:00
Andrew Nacin
33ee9a7d04 s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@19119 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 20:14:10 +00:00
Ryan Boren
db63861af8 Use add_help_sidebar(). see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19111 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 03:12:37 +00:00
Andrew Nacin
2efff75050 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18911 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-07 04:57:12 +00:00
Andrew Ozz
98554b4bb6 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18867 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-03 04:00:57 +00:00
Andrew Ozz
d0d3855285 Add screen_options with contextual content, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18864 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-02 06:59:36 +00:00
Daryl Koopersmith
2c5592178f Admin Header 2: The Return of 32px Icons. Props, iammattthomas. see #17324.
git-svn-id: https://develop.svn.wordpress.org/trunk@17872 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-12 00:22:22 +00:00
Ryan Boren
57d714aedc Remove favorite_actions() from h2s. Restore Add New buttons. see #17324
git-svn-id: https://develop.svn.wordpress.org/trunk@17849 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-10 19:18:16 +00:00
Mark Jaquith
e897910b75 Big UI style update. props koopersmith. see #17324
git-svn-id: https://develop.svn.wordpress.org/trunk@17800 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-04 20:15:05 +00:00
Andrew Nacin
f504e221e1 Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: https://develop.svn.wordpress.org/trunk@17748 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 15:24:49 +00:00
Ryan Boren
2d0150b6de From post back to get. Props SergeyBiryukov. fixes #16335
git-svn-id: https://develop.svn.wordpress.org/trunk@17345 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-22 01:31:21 +00:00
Andrew Nacin
2b4674a3b4 Remove AJAX from list tables. first pass. see #16262.
git-svn-id: https://develop.svn.wordpress.org/trunk@17322 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-16 21:47:24 +00:00
Peter Westwood
59ed14ce74 Switch back to GET from REQUEST for these so the non js searches work again. See #14927
git-svn-id: https://develop.svn.wordpress.org/trunk@17307 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-15 02:03:46 +00:00
scribu
0f40bb19cd Introduce WP_List_Table::search_box(). See #15353
git-svn-id: https://develop.svn.wordpress.org/trunk@17006 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 20:45:10 +00:00
Andrew Nacin
afecafe7ab Remove check_permissions() calls outside of AJAX context. Also only check for switch_themes in check_permissions() for the themes table. see #15326.
git-svn-id: https://develop.svn.wordpress.org/trunk@16990 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 08:43:22 +00:00
Andrew Nacin
7feeb0a320 Help text edits. props dougwrites, fixes #15346.
git-svn-id: https://develop.svn.wordpress.org/trunk@16980 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 06:37:03 +00:00
scribu
3f5f212ffb Don't show search box if there are no items available. See #15353
git-svn-id: https://develop.svn.wordpress.org/trunk@16868 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-10 20:22:34 +00:00
Andrew Nacin
3ebb27ae3e Always exit after wp_redirect. props filosofo, fixes #15518.
git-svn-id: https://develop.svn.wordpress.org/trunk@16847 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-09 18:02:54 +00:00
Peter Westwood
ab5f09cfda Restore some more cap checks for clarity. See #15326.
git-svn-id: https://develop.svn.wordpress.org/trunk@16776 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-07 21:06:19 +00:00
Peter Westwood
817aa1975c Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming.
git-svn-id: https://develop.svn.wordpress.org/trunk@16175 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-04 08:07:03 +00:00
scribu
d1034ad0d3 complete the renaming. props ocean90. See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@16172 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-03 22:06:45 +00:00
Peter Westwood
c4633bbd54 The big renaming of the list-table class files.
See #14579

git-svn-id: https://develop.svn.wordpress.org/trunk@16128 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-01 09:19:50 +00:00
Mark Jaquith
d65cdf4ba8 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@16061 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-28 21:56:43 +00:00
Andrew Nacin
49589001bb Commit the rest of [15955]. see #14579.
git-svn-id: https://develop.svn.wordpress.org/trunk@15956 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-25 02:58:25 +00:00
scribu
728285edbd Introduce WP_List_Table::current_action() and use throughout admin list screens. See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@15642 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-22 00:10:39 +00:00
scribu
76ac1c93a8 Introduce get_list_table(). See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@15528 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-25 00:51:44 +00:00
scribu
1c4aeef40e replace $table with $wp_list_table. See #14651
git-svn-id: https://develop.svn.wordpress.org/trunk@15519 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-22 11:22:46 +00:00
scribu
37401689c5 Introduce WP_List_Table::check_permissions() and WP_List_Table::prepare_items(). Fixes #14596; See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@15496 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-12 23:21:05 +00:00
scribu
fb9394167f Ajaxify list-type screens in the admin. See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@15491 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-11 21:54:51 +00:00
Andrew Nacin
53d3846f6a target=blank for help. props jorbin, see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@15132 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-03 21:00:39 +00:00
Andrew Nacin
e89212637d Help whitespace/punctuation cleanup. props zeo, see #13467.
git-svn-id: https://develop.svn.wordpress.org/trunk@15054 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-29 16:16:40 +00:00
Andrew Nacin
4309532104 Help text typo fixes. props jorbin, dougwrites. see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@15001 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 19:20:52 +00:00
Nikolay Bachiyski
432ac03fb2 Menu translatable strings cleanup.
* Take out <strong> of the translatable part of For more information:
 * Include support forums and Codex links inside translations, because most translators would want to change them to their local documentation sites or Codex prefixes


git-svn-id: https://develop.svn.wordpress.org/trunk@14989 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 11:52:15 +00:00
Ryan Boren
1762f15347 Help cleanup. Props duck_. see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@14965 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 21:32:30 +00:00
Ryan Boren
779f739cca Help for links pages. Props jorbin. see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@14909 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-25 22:45:18 +00:00
Andrew Nacin
4d594cc798 Use 'Comments' and 'Links' as page title instead of Edit %s. fixes #11274.
git-svn-id: https://develop.svn.wordpress.org/trunk@14652 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-15 05:07:31 +00:00
Andrew Nacin
8800622876 s/blog/site/ in more places. props PeteMall, see #11644.
git-svn-id: https://develop.svn.wordpress.org/trunk@14313 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-30 01:54:32 +00:00
Andrew Nacin
ec4f5b83bf Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87.
git-svn-id: https://develop.svn.wordpress.org/trunk@14139 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-18 06:14:45 +00:00
Andrew Nacin
dd306def81 Remove redundant isset() and empty() checks.
git-svn-id: https://develop.svn.wordpress.org/trunk@13770 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-19 21:29:21 +00:00
Andrew Nacin
8be6c296b1 Consistently hide bulk actions, filters, and subpage links on admin panels when there are no items to show. Fixes #12086
git-svn-id: https://develop.svn.wordpress.org/trunk@13100 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-13 08:49:27 +00:00
Dion Hulse
ea82d93624 Use !empty() for Link searching title.
git-svn-id: https://develop.svn.wordpress.org/trunk@12895 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-29 08:11:20 +00:00
Dion Hulse
cfb58236dd Add text to 'Add New' button in link manager. Props scribu. Fixes #12071
git-svn-id: https://develop.svn.wordpress.org/trunk@12894 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-29 07:27:11 +00:00
Ryan Boren
0a04925b33 Show td attributes for custon coolumns. Props camiloclc. fixes #12050
git-svn-id: https://develop.svn.wordpress.org/trunk@12872 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-27 14:28:03 +00:00
Ryan Boren
2e46e81309 i18n fixes. Props nbachiyski. fixes #11954
git-svn-id: https://develop.svn.wordpress.org/trunk@12789 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-21 21:37:43 +00:00
Andrew Ozz
060d9185e6 Remove unused .fade CSS class, props nacin, fixes #11628
git-svn-id: https://develop.svn.wordpress.org/trunk@12546 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-26 09:00:58 +00:00
Ryan Boren
dcd3604d90 Use array calling style. Props Denis-de-Bernardy. see #6647
git-svn-id: https://develop.svn.wordpress.org/trunk@12515 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-23 15:31:02 +00:00