Commit Graph

16081 Commits

Author SHA1 Message Date
Sergey Biryukov
74795ca384 Docs: Correct version number in @deprecated tags for PHP 4 constructors in pomo/entry.php and pomo/streams.php.
Follow-up to [46629].

Props jrf.
See #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46631 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:28:31 +00:00
Sergey Biryukov
d3f486ed3f Docs: Correct @see references for PHP 4 constructors in wp-includes/class-json.php.
See #48252, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46630 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:11:20 +00:00
Sergey Biryukov
168bb48084 Docs: Add missing @deprecated tags to PHP 4 constructors in pomo/entry.php and pomo/streams.php.
Props jrf.
Fixes #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46629 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:09:35 +00:00
Sergey Biryukov
095ef4a2a2 Twenty Eleven: Add missing @deprecated tag to PHP 4 constructor in Twenty_Eleven_Ephemera_Widget.
Props jrf.
See #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46628 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:06:55 +00:00
Sergey Biryukov
dcced77dbb Docs: Add missing @deprecated tags to PHP 4 constructors in WP_Widget and WP_Widget_Factory().
Correct version number in `_deprecated_constructor()` call in `WP_Widget_Factory()`, see [32990].

Props jrf.
See #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46627 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:04:27 +00:00
Sergey Biryukov
00384f94db Docs: Update URLs in some @link tags and switch them to HTTPS.
Props tsuyoring.
Fixes #48479.

git-svn-id: https://develop.svn.wordpress.org/trunk@46626 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-01 14:55:51 +00:00
Sergey Biryukov
89621877f8 Code Modernization: Pass an appropriate error level to trigger_error() in _doing_it_wrong() and related functions:
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

The error level passed is `E_USER_DEPRECATED` for the deprecated function group and `E_USER_NOTICE` for `_doing_it_wrong()`.

Props jrf.
Fixes #36561.

git-svn-id: https://develop.svn.wordpress.org/trunk@46625 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-01 00:39:04 +00:00
johnbillion
3623ab0ad8 Docs: Correct some more invalid inline docs.
See https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description

See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46624 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-31 21:18:01 +00:00
John Blackbourn
669cefe587 Docs: Correct some incorrect docblock tags.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46623 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-31 17:49:12 +00:00
Sergey Biryukov
fe9b176aef Docs: Add @since tag for the $context parameter added to wp_generate_attachment_metadata filter in [46621].
See #48472.

git-svn-id: https://develop.svn.wordpress.org/trunk@46622 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-31 00:11:20 +00:00
Andrew Ozz
b9c02b3729 Upload:
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.

Fixes #48472 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@46621 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-30 21:08:32 +00:00
Sergey Biryukov
6582966e2e Docs: Document $error, $interim_login, and $action globals in login_header() and login_footer().
Props priyankabehera155, faisal03, mukesh27, SergeyBiryukov.
Fixes #45777.

git-svn-id: https://develop.svn.wordpress.org/trunk@46620 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-30 02:57:16 +00:00
Jonathan Desrosiers
7d2bb9f8c6 Help/About: Update the 5.3 About page for RC3.
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46616 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-29 20:08:32 +00:00
Jonathan Desrosiers
52508537cb Bundled Themes: Update Twenty Twenty.
This brings trunk’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46571], see 4549fd9...dea9290.

Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Fixes #48450.

git-svn-id: https://develop.svn.wordpress.org/trunk@46613 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-29 14:53:27 +00:00
John Blackbourn
c6c46a5a48 Docs: Miscellaneous docblock corrections.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46610 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 19:46:13 +00:00
John Blackbourn
38dd307f5a Docs: Coding standards fix after [46608].
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46609 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 19:33:24 +00:00
John Blackbourn
0cd24d5c60 Docs: Remove some funky nested filters.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46608 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 19:02:31 +00:00
Sergey Biryukov
7548aa86ba Docs: Restore correct placement for duplicate hook reference in render_block_core_latest_comments().
Previously fixed in [46604], accidentally reverted in [46606].

See #48447, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46607 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 15:15:51 +00:00
Riad Benguella
6352823e6e Block Editor: Bug fixes targetted for WordPress 5.3 RC3.
The list of included fixes is:

- https://github.com/WordPress/gutenberg/pull/18108
- https://github.com/WordPress/gutenberg/pull/18051
- https://github.com/WordPress/gutenberg/pull/18106
- https://github.com/WordPress/gutenberg/pull/18102

Updated packages:
 - @wordpress/api-fetch@3.6.4
 - @wordpress/block-directory@1.0.4
 - @wordpress/block-library@2.9.4
 - @wordpress/core-data@2.7.4
 - @wordpress/data-controls@1.3.4
 - @wordpress/edit-post@3.8.4
 - @wordpress/editor@9.7.4
 - @wordpress/list-reusable-blocks@1.8.4
 - @wordpress/media-utils@1.2.4
 - @wordpress/server-side-render@1.3.4

Props desrosj.
See #48447.


git-svn-id: https://develop.svn.wordpress.org/trunk@46606 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 14:11:06 +00:00
John Blackbourn
8c21607a97 Docs: Correct invalid hook docblock placement.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46604 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 19:33:12 +00:00
John Blackbourn
b422cc2ef6 Docs: Correct invalid hook docblocks.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46603 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 19:09:10 +00:00
Sergey Biryukov
6ac79feeeb Docs: Remove "private" designation from _doing_it_wrong() and related functions:
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

Plugins and themes should be allowed to use these functions to throw appropriate error notices.

This brings them in line with newer `do_action_deprecated()` and `apply_filters_deprecated()` functions, which are not marked as private.

Props jrf.
Fixes #48251.

git-svn-id: https://develop.svn.wordpress.org/trunk@46602 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 14:19:13 +00:00
Sergey Biryukov
f06419d070 Editor: Fix typo in an error message in WP_Block_Styles_Registry::register().
Props man4toman, alishankhan, shaampk1.
Fixes #48437.

git-svn-id: https://develop.svn.wordpress.org/trunk@46601 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 14:06:04 +00:00
Sergey Biryukov
fa02b8917e Docs: Improve DocBlock formatting in WP_Block_Styles_Registry per the documentation standards.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46600 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 14:05:18 +00:00
John Blackbourn
1ec1c5872b Docs: Correct and improve inline docs for the file type functions.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46599 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 23:47:04 +00:00
John Blackbourn
e228178d1b Docs: Add missing docs for the auth_cookie_bad_session_token action.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46598 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 23:44:02 +00:00
John Blackbourn
3559504161 Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46597 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 23:14:59 +00:00
John Blackbourn
4f281f1650 Docs: Switch more docs over to typed array notation, plus some fixes.
See #48303, #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@46596 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 21:07:10 +00:00
John Blackbourn
e07cf22fd0 Docs: Switch to typed array notation for the docs for asset dependency functions.
Props marekdedic

See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46595 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 21:00:08 +00:00
John Blackbourn
a2e08032dc Docs: Miscellaneous docblock fixes and improvements.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46594 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 20:42:00 +00:00
Sergey Biryukov
c951d94c72 Docs: Improve documentation for esc_attr_e(), esc_html_e(), esc_attr_x(), esc_html_x().
Props atachibana.
Fixes #48383.

git-svn-id: https://develop.svn.wordpress.org/trunk@46593 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 17:28:20 +00:00
Sergey Biryukov
e2c34a76f9 Docs: Improve documentation for wptexturize().
Props atachibana.
Fixes #48397.

git-svn-id: https://develop.svn.wordpress.org/trunk@46592 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 00:56:50 +00:00
Sergey Biryukov
21ce200edb Docs: Improve formatting of various WP_Screen DocBlocks.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46591 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 00:34:10 +00:00
Sergey Biryukov
d490968297 Docs: Improve documentation for WP_Screen::add_help_tab().
Props atachibana.
Fixes #48395.

git-svn-id: https://develop.svn.wordpress.org/trunk@46590 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 00:32:20 +00:00
Jonathan Desrosiers
10c787f0ca Ensure svn:eol-style is consistently set for all files (part 2).
Continuation of [46586]

See #42594.

git-svn-id: https://develop.svn.wordpress.org/trunk@46587 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 19:27:49 +00:00
Jonathan Desrosiers
d376fedd89 Ensure svn:eol-style is consistently set for all files.
See #42594.

git-svn-id: https://develop.svn.wordpress.org/trunk@46586 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 16:36:41 +00:00
Jonathan Desrosiers
3646ed75c1 Remove the svn:executable property from files that don't need it.
See #42594.

git-svn-id: https://develop.svn.wordpress.org/trunk@46585 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 15:34:43 +00:00
Jonathan Desrosiers
4b1dd6e549 Trunk is now 5.4 alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@46582 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 14:22:40 +00:00
Sergey Biryukov
c67b47c66e Date/Time: Make sure get_post_time() keeps UTC time on timezone change.
Add `$source` parameter to `get_post_datetime()` to instantiate from local or UTC time in database.

Props Rarst, david.binda.
Reviewed by azaozz, SergeyBiryukov.
Fixes #48384.

git-svn-id: https://develop.svn.wordpress.org/trunk@46580 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 13:06:29 +00:00
Sergey Biryukov
db4e52b923 Posts, Post Types: Remove unintended change from [46578].
See #48384.

git-svn-id: https://develop.svn.wordpress.org/trunk@46579 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 12:52:46 +00:00
Sergey Biryukov
9a9abc0fb8 Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp.
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.

git-svn-id: https://develop.svn.wordpress.org/trunk@46578 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 12:49:40 +00:00
Sergey Biryukov
38b4ecf2ed Date/Time: Make sure date_i18n() correctly handles zero timestamp after [45901].
Props soulseekah, gravityview, Rarst.
Reviewed by azaozz, SergeyBiryukov.
Fixes #28636.

git-svn-id: https://develop.svn.wordpress.org/trunk@46577 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 11:03:13 +00:00
Andrea Fercia
5952a5dcf7 Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241].
Props david.binda, audrasjb, azaozz.
See #34904.
Fixes #48396.


git-svn-id: https://develop.svn.wordpress.org/trunk@46575 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-23 20:55:31 +00:00
Jonathan Desrosiers
aa34f0d952 Post WordPress 5.3 RC2 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@46574 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-22 20:09:15 +00:00
Jonathan Desrosiers
1b411f9e05 WordPress 5.3 RC2.
git-svn-id: https://develop.svn.wordpress.org/trunk@46573 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-22 19:43:01 +00:00
Jonathan Desrosiers
3bf7246685 Help/About: Update the 5.3 About page for RC2.
This includes numerous improvements:

- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.

Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46572 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-22 19:17:59 +00:00
Jonathan Desrosiers
a8fa07371f Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46551], see bc89c51...4549fd9.

Reviewed by SergeyBiryukov, desrosj, ianbelanger.
Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, intimez, itowhid06, decrecementofeliz, aristath, westonruter, mukesh27, jorgefilipecosta, karmatosed.
Fixes #48386.

git-svn-id: https://develop.svn.wordpress.org/trunk@46571 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-22 18:25:45 +00:00
Sergey Biryukov
7ee1e12715 Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197].
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.

git-svn-id: https://develop.svn.wordpress.org/trunk@46570 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-22 17:50:45 +00:00
SergeyBiryukov
747f8e2186 Date/Time: Make sure wp_date() does not unnecessarily escape localized numbers, but keeps localized slashes.
Props Rarst, tmatsuur, remcotolsma, peterwilsoncc.
Reviewed by peterwilsoncc.
Fixes #48319.

git-svn-id: https://develop.svn.wordpress.org/trunk@46569 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-22 17:29:02 +00:00
Sergey Biryukov
99d5986b0c Plugins: Restore backward compatibility for PHP4-style passing of array( &$this ) as action argument to do_action().
This is a follow-up to [46149] to avoid unnecessary breakage in case of using the old notation.

Props david.binda, jrf.
Reviewed by azaozz.
Fixes #48312.

git-svn-id: https://develop.svn.wordpress.org/trunk@46568 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-22 00:09:39 +00:00
Andrew Ozz
67a937a2fd Media: After [46237] add the same fix to the .button-group on the "Insert form URL" screen in the media modal.
Props afercia, sabernhardt.
FIxes #48087.

git-svn-id: https://develop.svn.wordpress.org/trunk@46567 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-21 23:21:51 +00:00
Andrew Ozz
295acd4f95 Upload: Expand error codes to include all 5xx HTTP errors when retrying to create image sub-sizes. Some servers may be configured to set HTTP 508 or 504, or possibly other 5 errors.
Porps mikeschroder, azaozz.
Fixes #48379.

git-svn-id: https://develop.svn.wordpress.org/trunk@46566 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-21 22:42:02 +00:00
Andrew Ozz
c424187b6e Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append scaled- to the file names of the scaled images to make them easier to recognize.
Props kraftbj, azaozz.
Fixes #48304.

git-svn-id: https://develop.svn.wordpress.org/trunk@46565 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-21 21:41:09 +00:00
Sergey Biryukov
1f7f0a1357 Comments: Add rel="nofollow ugc" attribute when converting plain URLs to <a> tags in comments via make_clickable().
Introduce `make_clickable_rel` filter for the `rel` value that is added to URL matches converted to links.

This is a follow-up to [46349], which added the `rel="nofollow ugc"` attribute to existing `<a>` tags in comments via `wp_rel_ugc()`.

UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props blogginglife, SergeyBiryukov.
Reviewed by desrosj, audrasjb.
Fixes #48022.

git-svn-id: https://develop.svn.wordpress.org/trunk@46564 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-21 20:39:16 +00:00
K. Adam White
56aa018065 REST API: Cast empty meta values to correct scalar types in REST response.
Introducing complex meta value handling in [45807] unintentionally removed value casting for empty scalar meta values.

Props TimothyBlynJacobs, chrisvanpatten, rmccue, kadamwhite.
Fixes #48363.



git-svn-id: https://develop.svn.wordpress.org/trunk@46563 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-21 19:08:34 +00:00
Riad Benguella
0ad9c8231e Block Editor: Update Packages that include WP 5.3 RC2 fixes.
Updated packages:
 - @wordpress/api-fetch@3.6.3
 - @wordpress/block-directory@1.0.3
 - @wordpress/block-editor@3.2.3
 - @wordpress/block-library@2.9.3
 - @wordpress/core-data@2.7.3
 - @wordpress/data-controls@1.3.3
 - @wordpress/e2e-test-utils@2.4.3
 - @wordpress/e2e-tests@1.7.3
 - @wordpress/edit-post@3.8.3
 - @wordpress/editor@9.7.3
 - @wordpress/format-library@1.9.3
 - @wordpress/list-reusable-blocks@1.8.3
 - @wordpress/media-utils@1.2.3
 - @wordpress/server-side-render@1.3.3
 - @wordpress/url@2.8.2

Props gziolo.
Fixes #48381.


git-svn-id: https://develop.svn.wordpress.org/trunk@46562 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-21 14:00:13 +00:00
John Blackbourn
3cd121d5d7 Administration: Revert changes to the admin menu styles for long line lengths.
This reverts [46555], [46453], and [46332].

See #42201


git-svn-id: https://develop.svn.wordpress.org/trunk@46561 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-17 18:36:27 +00:00
Jonathan Desrosiers
3e6c0fb95e Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing.
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.

Follow up of [46455].

Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46560 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-16 21:01:22 +00:00
Andrea Fercia
aa37e6e2f8 Script Loader: Partially revert [46550] as it brought in unrelated CSS changes.
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.

See #47069.


git-svn-id: https://develop.svn.wordpress.org/trunk@46559 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-16 17:47:28 +00:00
Sergey Biryukov
31ae9e0f91 Post WordPress 5.3 RC1 version bump
git-svn-id: https://develop.svn.wordpress.org/trunk@46558 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 21:12:48 +00:00
Sergey Biryukov
52151d5cb6 WordPress 5.3 RC1
git-svn-id: https://develop.svn.wordpress.org/trunk@46557 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 20:48:59 +00:00
John Blackbourn
c0cb2300a1 Help/About: Let's tell the world about 5.3.
Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald

Thanks to everyone who provided feedback for this page for 5.3.

See #47708


git-svn-id: https://develop.svn.wordpress.org/trunk@46556 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 20:40:05 +00:00
John Blackbourn
9d2aa0f442 Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed.
Props afercia, amolv, sabernhardt

Fixes #42201, #48294


git-svn-id: https://develop.svn.wordpress.org/trunk@46555 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 19:37:03 +00:00
Sergey Biryukov
943fa44db0 Shortcodes: Revert [46369] for now to allow more time to investigate and prepare for backward compatibility changes.
Also reverts follow-up changes in [46370] and [46465].

See #47863.

git-svn-id: https://develop.svn.wordpress.org/trunk@46554 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 19:34:31 +00:00
Andrew Ozz
d5f11a9bbb Media: Similarly to wp_get_original_image_path() add wp_get_original_image_url() to always retrieve the URL to the original uploaded image.
Props kraftbj.
Fixes #48302.

git-svn-id: https://develop.svn.wordpress.org/trunk@46553 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 19:10:53 +00:00
desrosj
2b3fc3211f Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46445], see 7246fd6...bc89c51.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyously, mahesh901122, josephscott, byalextran, amolv, Clorith.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46551 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 18:45:02 +00:00
Andrea Fercia
943320fa03 Accessibility: Script Loader: Remove jQuery as dependency of admin-bar after [46440].
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.

See #47069.


git-svn-id: https://develop.svn.wordpress.org/trunk@46550 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 17:21:50 +00:00
Andrea Fercia
6e133af382 Accessibility: Media: Improve the Media Modal spinner position after [46418].
Fixes #47138.


git-svn-id: https://develop.svn.wordpress.org/trunk@46549 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 16:45:08 +00:00
Sergey Biryukov
3fb04abf15 Customize: Ensure that WP_Customize_Manager::import_theme_starter_content() properly handles starter content with (nested) arrays as values.
Previously, searching for symbol references to replace with post or attachment IDs in array values resulted in a PHP warning.

Props timph, JarretC, SergeyBiryukov.
Fixes #45484.

git-svn-id: https://develop.svn.wordpress.org/trunk@46548 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 16:41:51 +00:00
Jorge Costa
849e070be2 Block Editor: Update the WordPress Packages to the ones used in the Gutenberg 6.8 release.
Updated packages:
@wordpress/a11y@2.5.1
@wordpress/annotations@1.7.2
@wordpress/api-fetch@3.6.2
@wordpress/autop@2.5.1
@wordpress/babel-preset-default@4.6.2
@wordpress/blob@2.5.1
@wordpress/block-directory@1.0.2
@wordpress/block-editor@3.2.2
@wordpress/block-library@2.9.2
@wordpress/block-serialization-default-parser@3.4.1
@wordpress/block-serialization-spec-parser@3.3.1
@wordpress/blocks@6.7.2
@wordpress/components@8.3.2
@wordpress/compose@3.7.2
@wordpress/core-data@2.7.2
@wordpress/data-controls@1.3.2
@wordpress/data@4.9.2
@wordpress/deprecated@2.6.1
@wordpress/dom-ready@2.5.1
@wordpress/dom@2.5.2
@wordpress/e2e-test-utils@2.4.2
@wordpress/e2e-tests@1.7.2
@wordpress/edit-post@3.8.2
@wordpress/editor@9.7.2
@wordpress/element@2.8.2
@wordpress/escape-html@1.5.1
@wordpress/format-library@1.9.2
@wordpress/is-shallow-equal@1.6.1
@wordpress/keycodes@2.6.2
@wordpress/list-reusable-blocks@1.8.2
@wordpress/media-utils@1.2.2
@wordpress/notices@1.8.2
@wordpress/nux@3.7.2
@wordpress/plugins@2.7.2
@wordpress/priority-queue@1.3.1
@wordpress/redux-routine@3.6.2
@wordpress/rich-text@3.7.2
@wordpress/scripts@5.1.0
@wordpress/server-side-render@1.3.2
@wordpress/url@2.8.1
@wordpress/viewport@2.8.2
@wordpress/wordcount@2.6.2

Props gziolo, youknowriad.
Fixes: #48310

git-svn-id: https://develop.svn.wordpress.org/trunk@46546 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 16:15:50 +00:00
Jake Spurlock
3b2c6568a5 REST API: Allow for multiple Vary: Origin headers in GET responses.
Simple fix, we pass `false` as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309.
Props xknown, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46544 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 15:45:39 +00:00
Grzegorz (Greg) Ziółkowski
78d3ff391c Block Editor: Remove experimental Social Links blocks
We decided to mark Social Links block as an experimental feature in Gutenberg. In effect, we are moving all related code from WordPress 5.3 release.

Props youknowriad.

Fixes #48263.



git-svn-id: https://develop.svn.wordpress.org/trunk@46543 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-15 15:35:03 +00:00
Andrew Ozz
5df589ddf6 Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging.
Fixes #40439.

git-svn-id: https://develop.svn.wordpress.org/trunk@46507 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 20:03:01 +00:00
Andrew Ozz
329e042060 Uploads: Retry to post-process images after HTTP 500 and HTTP 502 errors.
Props mikeschroder, azaozz.
Fixes #47872.

git-svn-id: https://develop.svn.wordpress.org/trunk@46506 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 19:54:36 +00:00
Andrea Fercia
d2da46a5c5 Accessibility: Media: Improve the text of the Media Modal actions toggle button displayed in the responsive view.
See #47149.


git-svn-id: https://develop.svn.wordpress.org/trunk@46489 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 18:01:53 +00:00
Andrea Fercia
ab8e92995b Accessibility: Media: Improve the new Media Modal headings text.
See #47610.


git-svn-id: https://develop.svn.wordpress.org/trunk@46488 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 17:56:41 +00:00
Jake Spurlock
4e2d91d186 REST API: Ensure that we don't generate warnings from sending extra headers after headers have been sent.
Fixes issues stemming from [46478].



git-svn-id: https://develop.svn.wordpress.org/trunk@46483 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 16:23:13 +00:00
Jake Spurlock
2a5c167b21 REST API: Send a Vary: Origin header on GET requests.
Add this header on all GET requests to prevent cached requests.

Props darthhexx, davidbinda, nickdaugherty, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46478 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:41:05 +00:00
Jake Spurlock
f53a78fda7 Administration: Ensure that admin referer nonce is valid.
Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Props vortfu, xknown, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46477 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:38:14 +00:00
Jake Spurlock
f06c6bb20c Filesystem API: Prevent directory travelersals when creating new folders.
Reject file paths that contain sub-directory paths.

Props iandunn, xknown, sstoqnov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46476 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:29:25 +00:00
Jake Spurlock
af8afb943e HTTP API: Protect against hex interpretation.
Return earlier from wp_http_validate_url().

Props: iandunn, xknown, voldemortensen, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46475 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:25:38 +00:00
Jake Spurlock
ad6c214307 Query: Remove the static query property.
Prevent unauthenticated views of publicly queryables content types.

Props aaroncampbell, whyisjake, nickdaugherty, xknown.


git-svn-id: https://develop.svn.wordpress.org/trunk@46474 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:18:49 +00:00
Sergey Biryukov
0c75758333 Formatting: In wp_validate_redirect(), normalize the path when validating the location for relative URLs, to account for Windows paths.
Props peterwilsoncc, rconde, jmmathc, mat-lipe, Sixes, justinahinon, cmagrin, daxelrod, SergeyBiryukov.
Fixes #47980.

git-svn-id: https://develop.svn.wordpress.org/trunk@46472 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 10:50:41 +00:00
Sergey Biryukov
a9891c7109 Docs: Fix typo in a comment in WP_REST_Settings_Controller::prepare_value().
Convert the comment to a multi-line format per the documentation standards.

Props itowhid06.
See #48296.

git-svn-id: https://develop.svn.wordpress.org/trunk@46471 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-13 10:00:18 +00:00
Peter Wilson
8f7174fa1a Docs: Correct documentation typo in print_emoji_detection_script().
Props itowhid06.
Fixes #48298. See #47110.


git-svn-id: https://develop.svn.wordpress.org/trunk@46470 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-13 02:46:25 +00:00
Peter Wilson
438de1ff41 Docs: Correct comment typo in WP_REST_Terms_Controller::update_item().
Props manikmist09.
Fixes #48295. See #47110.


git-svn-id: https://develop.svn.wordpress.org/trunk@46469 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-13 02:40:05 +00:00
John Blackbourn
cda19de292 Docs: Fix and improve inline documentation for the HTTP API.
See #47110


git-svn-id: https://develop.svn.wordpress.org/trunk@46468 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 18:03:22 +00:00
Sergey Biryukov
a8259b8c5e Users: Make sure wp_logout() clears current user, so that a subsequent call to is_user_logged_in() works as expected.
Props sebastian.pisula, donmhico, roytanck, juliobox.
Fixes #35488.

git-svn-id: https://develop.svn.wordpress.org/trunk@46467 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 03:08:56 +00:00
Sergey Biryukov
5e6d8f584d Docs: Adjust @since note in shortcode_parse_atts() for consistency with similar notes.
See #47863.

git-svn-id: https://develop.svn.wordpress.org/trunk@46465 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 02:48:26 +00:00
Sergey Biryukov
7cd21b7bd0 I18N: Don't capitalize "Extension" in update_core(), for consistency with other strings.
Follow-up to [46455].

See #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46464 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 02:40:43 +00:00
Sergey Biryukov
e21792cb37 Docs: Add requires_php to the list of fields returned by plugins_api().
Props ediamin.
Fixes #48291.

git-svn-id: https://develop.svn.wordpress.org/trunk@46463 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 02:33:13 +00:00
Sergey Biryukov
9a6bce9f5c Formatting: Make sure wp_sanitize_redirect() encodes spaces in URLs instead of stripping them out.
Props donmhico, hlashbrooke, dd32, azaozz.
Fixes #36998.

git-svn-id: https://develop.svn.wordpress.org/trunk@46462 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 23:52:11 +00:00
Anthony Burchell
dcb037fc3a Media: Adds Edit Image controller to Media Library select frame.
This adds the necessary state for `EditImage` views in the `select` frame and listeners for setting that view.

Props fblaser, w3rkjana, afercia, antpb.
See #48028.


git-svn-id: https://develop.svn.wordpress.org/trunk@46461 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 20:41:51 +00:00
Anthony Burchell
42493b7ed8 Administration: Prevents horizontal scroll jumping around while admin menu is open.
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.


git-svn-id: https://develop.svn.wordpress.org/trunk@46460 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 19:20:43 +00:00
Mike Schroder
68729adb57 Media: Update fallback previews to support _wp_make_subsizes()
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.

git-svn-id: https://develop.svn.wordpress.org/trunk@46459 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 07:52:12 +00:00
Aaron Jorbin
466937669a Cron: Prevent sending headers when using ALTERNATE_WP_CRON
ALTERNATE_WP_CRON echos things which causes a "Headers already sent" warning. This adds a check to ensure headers haven't already been sent.

Previously: [45560]

See: #45560. Fixes #48283.
Props dlh.



git-svn-id: https://develop.svn.wordpress.org/trunk@46458 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-10 22:50:05 +00:00
Dominik Schilling
7a682e690e Themes: Convert core-provided starter content to block content.
Props Clorith.
Fixes #48130.

git-svn-id: https://develop.svn.wordpress.org/trunk@46457 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-10 19:05:57 +00:00
K. Adam White
70b408c8fe REST API: Fix error in _fields filtering logic where only one of several requested sibling properties would be included.
Props kadamwhite, TimothyBlynJacobs.
Fixes #48266.


git-svn-id: https://develop.svn.wordpress.org/trunk@46456 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-10 17:16:44 +00:00
Jonathan Desrosiers
1bcd41b7c1 Upgrade/Install: Detect the presence of the native PHP JSON extension before updating.
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46455 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 22:20:37 +00:00
K. Adam White
22d50c492d REST API: Do not addslash when receiving meta arrays of non-string values.
Slashing non-string data caused PUT requests containing unmodified meta arrays of integers to fail the check against the existing stored meta value, causing a 500 when posting an unmodified response body back to the server.

Props TimothyBlynJacobs, augustuswm.
Fixes #48264.


git-svn-id: https://develop.svn.wordpress.org/trunk@46454 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 17:34:20 +00:00