Commit Graph

36800 Commits

Author SHA1 Message Date
Andrea Fercia
746d3c23c4 Administration: Use consistent spacing for form elements in the Discussion Settings screen.
Props sagarjadhav.
Fixes #31594.


git-svn-id: https://develop.svn.wordpress.org/trunk@40779 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-18 15:54:55 +00:00
John Blackbourn
6da8500524 Login and Registration: Add some margin to notices on the login screen so multiple notices remain separated.
Fixes #39971


git-svn-id: https://develop.svn.wordpress.org/trunk@40778 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-18 15:39:30 +00:00
Konstantin Obenland
028d76ea70 Dashboard: Document request proxy for events.
Documents the reason why the request is proxied through WP, instead of being
made directly to api.wordpress.org.

Props iandunn, michelleweber.
See #40702.



git-svn-id: https://develop.svn.wordpress.org/trunk@40777 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-18 14:43:47 +00:00
Konstantin Obenland
0a15718b87 Dashboard: Properly localize data for events
Moves localization to script-loader and removes dependency for two strings.

Props dd32, iandunn.
See #40702.


git-svn-id: https://develop.svn.wordpress.org/trunk@40776 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-18 14:33:04 +00:00
Pascal Birchler
043a87446d Media: Correct a translatable string for MediaElement.js.
Adds the needed context to the string "None". Introduced in [38089].

Props leewillis77.
See #37394.
Fixes #40800.


git-svn-id: https://develop.svn.wordpress.org/trunk@40775 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-18 11:05:09 +00:00
obenland
16b7f7908f Dashboard: Always pass the IP when getting events
Allows the API to determine event locations more accurately.

Props iandunn.
See #40702.


git-svn-id: https://develop.svn.wordpress.org/trunk@40774 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-18 07:30:05 +00:00
Konstantin Obenland
b549350776 Upgrade: Use correct commit no. to trigger upgrade
Props iandunn.
See [40607], #40702.


git-svn-id: https://develop.svn.wordpress.org/trunk@40773 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-17 22:02:02 +00:00
Weston Ruter
2dd4bc7388 Media: Trim whitespace in URLs provided for external embeds.
Also avoid showing error notice in media widget when URL field is empty.

Props timmydcrawford, westonruter.
Fixes #40771.


git-svn-id: https://develop.svn.wordpress.org/trunk@40772 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-17 01:58:16 +00:00
Weston Ruter
4dc737ca8e Customize: Run a partial's fallback behavior (full refresh) when selective refresh fails due to a script error.
This ensures that 3rd-party scripts that users paste into Text widgets will gracefully recover and result in the expected preview.

See #27355.
Fixes #40658.


git-svn-id: https://develop.svn.wordpress.org/trunk@40771 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-17 00:00:26 +00:00
Pascal Birchler
8b07508cae Media: Simplify upload error message construction.
git-svn-id: https://develop.svn.wordpress.org/trunk@40736 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 17:57:37 +00:00
Aaron D. Campbell
96c3a01019 Add nonce for updating file system credentials.
git-svn-id: https://develop.svn.wordpress.org/trunk@40723 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 14:47:08 +00:00
Weston Ruter
fe789a2644 Customize: Fix phpunit tests after [40704] due to logic inversion error.
git-svn-id: https://develop.svn.wordpress.org/trunk@40716 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 14:33:16 +00:00
Dominik Schilling (ocean90)
eedf5b2a60 Customize: Igore invalid customization sessions.
git-svn-id: https://develop.svn.wordpress.org/trunk@40704 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 12:06:32 +00:00
Pascal Birchler
1a25b3f43e Adjust post meta checks
git-svn-id: https://develop.svn.wordpress.org/trunk@40692 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 08:45:18 +00:00
Pascal Birchler
8278c5ee9c Improve redirect handling
git-svn-id: https://develop.svn.wordpress.org/trunk@40689 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 08:37:34 +00:00
Pascal Birchler
4fa44333cb Whitelist post arguments in XML-RPC
git-svn-id: https://develop.svn.wordpress.org/trunk@40677 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 08:08:27 +00:00
Weston Ruter
77fe870bd5 Customize: Keep alive auto-drafts created for page/post stubs when parent changeset is updated, and delete when changeset is garbage-collected.
Props utkarshpatel, westonruter.
See #31089.
Fixes #39715.


git-svn-id: https://develop.svn.wordpress.org/trunk@40676 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 05:36:25 +00:00
Weston Ruter
8eade12087 Widgets: Add missing wp-editor-area CSS class for textarea in the TinyMCE-extended Text widget to ensure proper styles are applied.
Removes extra border around TinyMCE-wrapped `textarea` and removes gap at bottom due to lack of `display:block`.

Props johnjamesjacoby, westonruter.
See #35243.
Fixes #40755.


git-svn-id: https://develop.svn.wordpress.org/trunk@40675 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-16 00:10:42 +00:00
Weston Ruter
556e793ed6 Widgets: Remove image sizes generated during media widget phpunit tests from being version controlled.
Amends [40640].
See #32417.


git-svn-id: https://develop.svn.wordpress.org/trunk@40674 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-15 22:58:03 +00:00
Weston Ruter
74128e0e3f Widgets: Ensure return value of widget_text filter is not dropped but passed into widget_text_content filter for rendering.
Amends [40631].
Props vijustin, swissspidy, westonruter.
See #35243.
Fixes #40772.



git-svn-id: https://develop.svn.wordpress.org/trunk@40673 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-15 22:35:41 +00:00
Mel Choyce
88fd7b8652 Plugins: Fix plugin name display on Chrome 58 and above.
On Chrome 58 and above, plugin names within the plugin details modal were collapsed down into an ellipsis. This fix rewrites the CSS to make sure the titles are always shown.

Props mrwweb, afercia, Presskopp.
Fixes #40579.


git-svn-id: https://develop.svn.wordpress.org/trunk@40672 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-15 20:12:59 +00:00
Weston Ruter
b2ea5a2b11 Customize: Fix alignment of natural-width media buttons in site icon control.
Amends [40653].
Props afercia.
Fixes #40220.


git-svn-id: https://develop.svn.wordpress.org/trunk@40671 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-15 18:50:50 +00:00
Weston Ruter
6ae69be3a8 Widgets: Prevent image title attribute from being populated from attachment title by default upon selection.
Props westonruter, timmydcrawford.
See #39993.


git-svn-id: https://develop.svn.wordpress.org/trunk@40670 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-15 18:41:59 +00:00
Konstantin Obenland
41431d153d Dashboard: Community events formatting improvements
Props Soean.
See #40702.


git-svn-id: https://develop.svn.wordpress.org/trunk@40669 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-15 09:43:36 +00:00
Rachel Baker
ddcd8b6ddb Taxonomy: Remove extraneous ' included in Term delete markup.
Unmatched single quotation mark after the delete link href was introduced in r40655.

Props Chouby.
Fixes #9777.


git-svn-id: https://develop.svn.wordpress.org/trunk@40668 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-14 19:49:53 +00:00
Rachel Baker
c52f1fb160 Formatting: Increase minimum characters allowed in is_email() to 6.
Brings the minimum characters expected for a valid email address to six, which matches the expectations in `wp_handle_comment_submission()` and REST API email arguments.

Props rmccue, lukecavanagh, rachelbaker, desrosj, sudar.
Fixes #38708.


git-svn-id: https://develop.svn.wordpress.org/trunk@40667 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-14 04:19:51 +00:00
Rachel Baker
f2ce983da0 Comments: Correct the $post_id parameter passed to the 'comments_open' and 'pings_open' filters.
Fixes bug where previously the `$post_id` function argument was passed to the '_open' filters, instead of the result of the `get_post()` call. If the current post is not found, the `$post_id` filter parameter will be 0.

Props johnbillion, shulard, rachelbaker.
Fixes #40286.


git-svn-id: https://develop.svn.wordpress.org/trunk@40666 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-14 03:50:01 +00:00
Peter Wilson
aba08a1bf5 Menus: Prevent empty class attribute following [40537].
Prevents an empty class attribute, `class=""`, from appearing in the HTML if a developer removes all classes using the `nav_menu_submenu_css_class` filter.

Props Kopepasah.
Fixes #36163.


git-svn-id: https://develop.svn.wordpress.org/trunk@40665 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-14 03:37:45 +00:00
Rachel Baker
8ba881647c Comments: Update arguments passed to the 'comment_text' filter in check_comment().
Pass null or empty values for the missing $comment and $args parameters of the 'check_comment' filter in `check_comment()`.

Props boonebgorges, vaishu.agola27, SergeyBiryukov.
Fixes #38314. 


git-svn-id: https://develop.svn.wordpress.org/trunk@40664 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-14 03:05:11 +00:00
Andrew Ozz
0736fc84e6 Bump version after beta-1
git-svn-id: https://develop.svn.wordpress.org/trunk@40663 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-13 00:20:08 +00:00
Andrew Ozz
d4153621c8 Bump version, beta-1
git-svn-id: https://develop.svn.wordpress.org/trunk@40662 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 23:16:57 +00:00
Andrew Ozz
1d6af162c4 Revert [40256] for now as some tests are failing in some environments.
See #20383.

git-svn-id: https://develop.svn.wordpress.org/trunk@40661 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 22:49:48 +00:00
Weston Ruter
6e847af943 Widgets: Fix deferred rendering of controls for media widgets until container element fully expands.
Adds omitted call to `renderWhenAnimationDone()` which was missed when this code was copied from the Text widget.

Amends [40656].
See #40750.


git-svn-id: https://develop.svn.wordpress.org/trunk@40660 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 22:00:51 +00:00
Adam Silverstein
0f0c850723 Media: Fix improper use of jQuery hasClass method.
The jQuery `hasClass` method accepts a class name without a prefix '.' (period). Remove an errant class name with a '.' in `wp-mediaelement.js` that broke the selector in certain circumstances.

Props kostasx, Presskopp.
Fixes #40354.



git-svn-id: https://develop.svn.wordpress.org/trunk@40659 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 20:52:09 +00:00
Adam Silverstein
b2018dc679 Customizer: Fix an issue with menu classes in the customizer preview.
In customizer preview, strip changeset uuid in menu urls before comparing with current url to determine menu item classes.

In the customizer, menu items now contain a changeset uuid as part of their urls. Strip the changeset uuid off the url before comparing with current url (which lacks the changeset uuid).

Props priyankabehera155, jipmoors.
Fixes #39758.



git-svn-id: https://develop.svn.wordpress.org/trunk@40658 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 20:34:43 +00:00
Adam Silverstein
0f4c1e88dd Users: Update name in toolbar when changing user display name.
When changing the user name in Users -> Your Profile, update the name displayed in the toolbar dynamically using JavaScript.

Props menakas, lukecavanagh, maguiar.
Fixes #40342.



git-svn-id: https://develop.svn.wordpress.org/trunk@40657 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 20:05:07 +00:00
Weston Ruter
fd02381098 Widgets: Defer rendering controls for media widgets until container element fully expands.
Fixes issue with MediaElement.js failing to build the player in an animating container that doesn't have established dimensions.
Also utilizes MediaElement.js for the video widget instead of using a native player.

See #32417.
Fixes #40750.


git-svn-id: https://develop.svn.wordpress.org/trunk@40656 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 19:55:53 +00:00
Adam Silverstein
c21b828581 Taxonomy: Add a "delete" button on term edit page.
Add a 'delete' link next to the update button on the term edit screen so you can delete a term while you are reviewing it's details. 

Props cklosows, bradt, ocean90, johnbillion, DrewAPicture, ryan, MatheusGimenez, maguiar.
Fixes #9777.



git-svn-id: https://develop.svn.wordpress.org/trunk@40655 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 19:25:43 +00:00
Andrew Ozz
89ef4c2123 TinyMCE: do not override line-height for paragraphs and headings in 4.6+, makes them hard to read.
Fixes #40743.

git-svn-id: https://develop.svn.wordpress.org/trunk@40654 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 18:05:21 +00:00
Andrea Fercia
c29cab4491 Customize: Make the media control buttons natural-width.
Natural-width buttons are better for translations, and don't feel as
overpowering as the half-width (and full-width) buttons.

Props melchoyce, timmydcrawford, afercia.
Fixes #40220.


git-svn-id: https://develop.svn.wordpress.org/trunk@40653 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 17:50:00 +00:00
Andrea Fercia
2596b5ac1c Login and Registration: Add a filter to disable the initial auto-focus on the login screen.
Fixes #40301.


git-svn-id: https://develop.svn.wordpress.org/trunk@40652 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 17:11:17 +00:00
Konstantin Obenland
f3940bf771 Dashboard: Persist location for community events
Fixes a bug where cached events & location data was not accessible because the
cache key could not be regenerated without latitude and longitude information.

Discovered and fixed during #wcber contributor day.

Props soean, kubik-rubik, obenland.
See #40702.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@40651 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 15:52:09 +00:00
Joe McGill
ca3b0a700a Improve wording of the AYS warning when permanently deleting uploads, tags, posts.
This is a follow up on [40283], which cleans up the wording.

Props azaozz, swissspidy, ocean90.
Fixes #39712.


git-svn-id: https://develop.svn.wordpress.org/trunk@40650 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 12:49:14 +00:00
Dominik Schilling (ocean90)
0202bed74d Import: Replace assert() calls with PHPUnit's assertTrue() method.
Calling `assert()` with a string argument will be deprecated in PHP 7.2.

See #40109.

git-svn-id: https://develop.svn.wordpress.org/trunk@40649 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 07:37:33 +00:00
Andrea Fercia
2156223d50 Add missing semicolons after [40646].
See #40453.


git-svn-id: https://develop.svn.wordpress.org/trunk@40648 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 07:04:07 +00:00
Andrea Fercia
ead4097f11 Media: Clean-up some MediaElementJS CSS: no more needed after [40642].
See #40707, #32417, #39994, #39995, #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@40647 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-12 06:59:53 +00:00
Andrea Fercia
aef3839e7b Accessibility: Change the "Show details" links in the update core screen to buttons.
These controls toggle the visibility of the update progress: they perform an action
therefore they should be buttons. Also:
- uses `aria-expanded` to communicate the toggle button state
- removes some inline JavaScript
- when clicking the toggle buttons, the progress details get moved with JavaScript after the button: this helps users of assistive technologies in finding them and makes the UI a bit more intuitive

Props Cheffheid, afercia.
See #26504.
Fixes #40453.


git-svn-id: https://develop.svn.wordpress.org/trunk@40646 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-11 23:50:01 +00:00
Andrew Ozz
1705f4501e TinyMCE: update to 4.6.1. Changelog: https://www.tinymce.com/docs/changelog/#version461-may102017
Fixes #40727.

git-svn-id: https://develop.svn.wordpress.org/trunk@40645 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-11 23:11:46 +00:00
Andrew Ozz
c098bc38d0 TinyMCE: prevent removing of the temp link element when opening the advanced link dialog to insert new link.
Part props figureone for finding the cause.
Fixes #40558.

git-svn-id: https://develop.svn.wordpress.org/trunk@40644 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-11 23:03:17 +00:00
Andrea Fercia
bf4b384fd4 Accessibility: Add "(opens in a new window)" screen reader text to the "News-Nearby Events" dashboard widget footer links.
- standardizes similar messages in core to always use `(opens in a new window)`
- adds translators comments
- hides the dashicons with `aria-hidden="true"`, see #40428

Fixes #40733.


git-svn-id: https://develop.svn.wordpress.org/trunk@40643 602fd350-edb4-49c9-b593-d223f7449a82
2017-05-11 22:46:59 +00:00