Commit Graph

29172 Commits

Author SHA1 Message Date
Aaron Jorbin 21f4857a32 Run unit tests on Travis CI with php nightlies
With PHP7 in active development, this will help us identify issues there. Also will be fun to see how fast it is.

Fixes #31454



git-svn-id: https://develop.svn.wordpress.org/trunk@31558 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 17:49:13 +00:00
Aaron Jorbin 39d1f621fd Update grunt-patch-wordpress to 0.3.0
This new update includes the following changes:
 * The tools directory can now be patched along with a handful of other root level files that were failing
 * If patching fails  or otherwise issues a prompt, you can now interact with the prompt
 * Only save the watch file to your directory if you pass the --debug flag
 * Default to selecting the newest patch rather then the oldest patch

props ocean90 ntwb kadamwhite aaronjorbin
Fixes #31466



git-svn-id: https://develop.svn.wordpress.org/trunk@31557 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 17:46:33 +00:00
Sergey Biryukov 6e4b84f073 Press This: Use correct URL for update bookmarklet link.
props kraftbj.
fixes #31461.

git-svn-id: https://develop.svn.wordpress.org/trunk@31556 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 08:47:30 +00:00
Scott Taylor d73c180c9d Cleanup the `@property` annotations for `WP_User`.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31555 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 05:53:31 +00:00
Scott Taylor 79706ee8a8 Don't call the size function `count()` as part of a test condition in loops. Compute the size beforehand, and not on each iteration.
Scrutinizer added a Performance label: these are the only violations.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31554 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 05:47:53 +00:00
Scott Taylor a524e05572 `wp_insert_comment()` should be checking and setting `$compacted`, not the non-existent `$post_data`.
See [31263], #21212.


git-svn-id: https://develop.svn.wordpress.org/trunk@31553 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 05:37:34 +00:00
Scott Taylor 9145a72789 Add missing access modifiers to `WP_Press_This`.
See #31456.


git-svn-id: https://develop.svn.wordpress.org/trunk@31552 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 05:17:42 +00:00
Drew Jaynes a136a78c1e Ignore the internal-use function `_wp_posts_page_notice()` from parsing for the code reference.
See #17470.


git-svn-id: https://develop.svn.wordpress.org/trunk@31551 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 03:07:26 +00:00
Helen Hou-Sandi f11e86fb83 Hide irrelevant UI and display a message when editing the page for posts.
Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.

Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.

props alexkingorg for the initial, long-suffering patch.
fixes #17470.


git-svn-id: https://develop.svn.wordpress.org/trunk@31550 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 02:46:40 +00:00
Andrew Ozz 89120dbb92 Press This: fix notices/errors classes. Props michael-arestad. Fixes #31456.
git-svn-id: https://develop.svn.wordpress.org/trunk@31549 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 01:30:06 +00:00
Andrew Ozz fc6ffd2a83 TinyMCE: wpView improvements: remove the (obsolete) get/setViewText methods. Update stopping/pausing of multiple ME media players. Props iseulde. See #31412.
git-svn-id: https://develop.svn.wordpress.org/trunk@31548 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 00:30:35 +00:00
Andrew Ozz b40bc85424 Press This: add press-this.css to the list of stylesheets that are minified. Bump wp_version. See #31373.
git-svn-id: https://develop.svn.wordpress.org/trunk@31547 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 23:48:27 +00:00
Andrew Ozz 3d36949893 TinyMCE: wpView improvements:
- Better structure, simpler "view" registration, better extensibility.
- Better inline documentation.
- Don't show a placeholder for pasted link until we know the link is "embeddable'.
And many more improvements. Props iseulde. See #31412.

git-svn-id: https://develop.svn.wordpress.org/trunk@31546 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 23:12:08 +00:00
Andrew Ozz 2fb11a4ae4 PressThis: go back to loading the minified bookmarklet content with file_get_contents(). Add Grunt task to minify bookmarklet.js on precommit and update it in /src. See #31373.
git-svn-id: https://develop.svn.wordpress.org/trunk@31545 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 20:15:46 +00:00
Drew Jaynes 7bb4ab4088 Add a missing file header to wp-includes/class-wp-customize-widgets.php, separate out the class DocBlock for `WP_Customize_Widgets`.
Fixes #31446.


git-svn-id: https://develop.svn.wordpress.org/trunk@31544 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 08:19:54 +00:00
Drew Jaynes 6a3e9b10c3 Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-setting.php.
* Adds a file header separate from the `WP_Customize_Setting` class block
* Fixes formatting for the `WP_Customize_Setting`, `WP_Customize_Filter_Setting`, `WP_Customize_Header_Image_Setting`, and `WP_Customize_Background_Image_Setting` class DocBlocks.

See #31446.


git-svn-id: https://develop.svn.wordpress.org/trunk@31543 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 08:17:25 +00:00
Drew Jaynes 4331386507 Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-section.php.
* Adds a file header separate from the `WP_Customize_Section` class block
* Fixes formatting for the `WP_Customize_Section`, `WP_Customize_Themes_Section`, and `WP_Customize_Sidebar_Section` class DocBlocks.

See #31446.


git-svn-id: https://develop.svn.wordpress.org/trunk@31542 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 08:12:12 +00:00
Drew Jaynes 0f6ea391ab Add a missing file header to wp-includes/class-wp-customize-panel.php, separate out the class DocBlock for `WP_Customize_Panel`.
See #31446.


git-svn-id: https://develop.svn.wordpress.org/trunk@31541 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 08:08:48 +00:00
Drew Jaynes 4d549627b4 Add a missing file header to wp-includes/class-wp-customize-manager.php, separate out the class DocBlock for `WP_Customize_Manager`.
See #31446.


git-svn-id: https://develop.svn.wordpress.org/trunk@31540 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 08:06:26 +00:00
Drew Jaynes 575c60ac39 Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-control.php.
* Adds a file header separate from the `WP_Customize_Control` class block
* Fixes formatting for the `WP_Customize_Control`, `WP_Customize_Color_Control`, `WP_Customize_Upload_Control`, `WP_Customize_Image_Control`, `WP_Customize_Background_Image_Control`, `WP_Customize_Theme_Control`, `WP_Customize_New_Theme_Control`, `WP_Widget_Area_Customize_Control`, and `WP_Widget_Form_Customize_Control` class DocBlocks.
* Adds a missing class DocBlock for `WP_Customize_Header_Image_Control`

See #31446.


git-svn-id: https://develop.svn.wordpress.org/trunk@31539 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 07:55:55 +00:00
Andrew Ozz 6dad5d4353 Grunt precommit cleanup. See [31533], [31535].
git-svn-id: https://develop.svn.wordpress.org/trunk@31538 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 04:16:18 +00:00
Andrew Ozz e6bbea8fe7 Press This: JSON encode the URL before appending it to the bookmarklet. See #31373.
git-svn-id: https://develop.svn.wordpress.org/trunk@31537 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 03:57:43 +00:00
Mark Jaquith b734341433 Make sure WP_Customize_Manager::theme() never returns null.
* Fixes issue in [31533] that caused unit test fatal error

fixes #31445

git-svn-id: https://develop.svn.wordpress.org/trunk@31536 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 03:53:04 +00:00
Andrew Ozz 578a785440 PressThis:
- Hard-code the minified bookmarklet js. Adding the non-minified bookmarklet to the browser bookmarks bar may have unexpected effect.
- Fix type juggling when checking the bookmarklet version.
Props stephdau, see #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31535 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 03:02:48 +00:00
Andrew Ozz 2e3afd2760 PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373.
git-svn-id: https://develop.svn.wordpress.org/trunk@31534 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-25 01:49:26 +00:00
Mark Jaquith f1bb5c2fd7 Add theme browsing and theme switching to the Customizer
* Brings into core the Customizer Theme Switcher feature plugin
* You can now browse, preview, and activate themes right from the Customizer

fixes #31303.
props celloexpressions, afercia, westonruter, folletto, designsimply

git-svn-id: https://develop.svn.wordpress.org/trunk@31533 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-24 20:30:22 +00:00
Boone Gorges e365b3a364 Add 'orderby=description' support to `get_terms()`.
This fixes an interface inconsistency in edit-tags.php, where Description
appears as a sortable column header.

Props neil_pie.
Fixes #31364.

git-svn-id: https://develop.svn.wordpress.org/trunk@31532 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-24 16:36:26 +00:00
Sergey Biryukov 4d61c79ca1 Fix line endings after [31522].
fixes #31430.

git-svn-id: https://develop.svn.wordpress.org/trunk@31531 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-24 10:05:48 +00:00
Drew Jaynes d44289d6de Clarify a wide variety of function, parameter, and return descriptions in DocBlocks throughout wp-includes/media.php.
Props stevegrunwell, DrewAPicture.
Fixes #28408.


git-svn-id: https://develop.svn.wordpress.org/trunk@31530 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-24 07:41:24 +00:00
Drew Jaynes 4cc15f83cc Add missing function and parameter descriptions to a variety of functions in wp-admin/includes/image-edit.php.
Props NikV for the initial patch.
Fixes #31353.


git-svn-id: https://develop.svn.wordpress.org/trunk@31529 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-24 06:06:59 +00:00
Dion Hulse ced1630496 Upgrades: Specifically pass the 'version' and 'locale' POST vars through the Core Update FTP credentials form.
This bug was introduced with [30384] / #30245
Fixes #31378 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31527 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-24 03:00:54 +00:00
Andrew Ozz 4ca703e03b Load json2.js only in IE7 and older. Fixes #31276.
git-svn-id: https://develop.svn.wordpress.org/trunk@31526 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 23:03:19 +00:00
Boone Gorges 6bd6da908e Pass taxonomy name, not object, to 'edit_term_taxonomy' and 'edited_term_taxonomy' actions.
These actions are fired in a number of different places, and in some cases
the tax name is passed, while in others the taxonomy object is passed. This
inconsistency made it difficult for plugins to use the `$taxonomy` value.

Props ipm-frommen.
Fixes #30999.

git-svn-id: https://develop.svn.wordpress.org/trunk@31525 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 21:07:34 +00:00
Sergey Biryukov de4a5ada98 Menus: Remove fixed height from `.description-thin` fields.
props tyxla.
fixes #31426.

git-svn-id: https://develop.svn.wordpress.org/trunk@31524 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 20:22:32 +00:00
Sergey Biryukov fe2b449d1c Menus: Prevent checkboxes and radio buttons from being stretched to full width on mobile.
props tyxla.
fixes #31425.

git-svn-id: https://develop.svn.wordpress.org/trunk@31523 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 20:02:58 +00:00
Sergey Biryukov 0421ee26ec Add unit tests for `get_page_template_slug()`.
props tyxla.
fixes #31389.

git-svn-id: https://develop.svn.wordpress.org/trunk@31522 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 18:47:01 +00:00
Sergey Biryukov ed1cc5a126 Fix a typo in `wp_update_nav_menu_item` hook documentation.
props tyxla.
fixes #31338.

git-svn-id: https://develop.svn.wordpress.org/trunk@31521 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 16:50:01 +00:00
Sergey Biryukov 569a47075e Add missing labels to Archives and Categories dropdown widgets.
props joedolson, jlevandowski, DrewAPicture, SergeyBiryukov.
fixes #18650.

git-svn-id: https://develop.svn.wordpress.org/trunk@31520 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 16:31:31 +00:00
Sergey Biryukov 3e3eacb4de Themes: Use a darker color for "No themes found" message to increase contrast.
props joedolson.
see #26600.

git-svn-id: https://develop.svn.wordpress.org/trunk@31519 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 15:48:46 +00:00
Jeremy Felt a86c3114ae Add `comment-author-is-site-member` class to comment output for site members.
Add a class to allow targeting of comments made by members of a site rather than users of the entire network.

Props Viper007Bond, MikeHansenMe.

Fixes #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@31518 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 02:51:49 +00:00
Jeremy Felt ff0b2f7a6f Provide proper label associations and descriptions throughout the network admin
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.


git-svn-id: https://develop.svn.wordpress.org/trunk@31517 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 02:28:41 +00:00
Jeremy Felt 4958dd8998 Avoid clearing stored capabilities for a user when removing their built in role in multisite.
Previously, if “No role on this site” was assigned to a user AND that user did not have an empty role array stored for the site, the `$blog_prefix . ‘capabilities’` meta for that user would be deleted completely after changes to the user were saved. Any custom capabilities stored (i.e. `$user->add_role()`) would be removed as well.

This removes the code controlling the old WPMU handling of “no role” and allows custom stored capabilities to remain. Users with no role and custom capabilities will now appear in the users list table with “None” as the role.

In the process we’re able to better clarify the multisite specific pieces that do occur.

Props PeteMall, jeremyfelt.

Fixes #18934.


git-svn-id: https://develop.svn.wordpress.org/trunk@31516 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 01:33:11 +00:00
Boone Gorges 129e5f5278 Ensure that a request URL is always set in `WP_UnitTestCase::go_to()`.
Failure to set this variable meant that passing the home URL to `go_to()`
(without a trailing slash) resulted in a PHP notice, and failed to reset the
globals properly.

Props joostdevalk.
Fixes #31417.

git-svn-id: https://develop.svn.wordpress.org/trunk@31515 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-23 01:07:18 +00:00
Jeremy Felt e61b0021bd Use response code 200 when an existing network user joins a site via invitation.
Pass a response code of 200 to `wp_die()` when a user is successfully added to an individual site after using the `/newbloguser/` URL from an invite email. This is a user facing success message.

Props MikeHansenMe.

Fixes #31224.


git-svn-id: https://develop.svn.wordpress.org/trunk@31514 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 22:29:19 +00:00
Andrew Ozz 825fa21a22 Improve table footer tab sequence by moving `<tfoot>` after `<tbody>`. Props afercia, rianrietveld, DrewAPicture. Fixes #30914.
git-svn-id: https://develop.svn.wordpress.org/trunk@31513 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 21:47:30 +00:00
Boone Gorges 1beeccc96f Use PHP 5.2 compatible syntax in image tests.
T_PAAMAYIM_NEKUDOTAYIM, HAKUNA_MATATA, YOLO.

See [31510], #31124.

git-svn-id: https://develop.svn.wordpress.org/trunk@31512 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 21:41:22 +00:00
Jeremy Felt 6556f8e112 Do not activate plugins on initial installation in multisite.
Check `is_multisite()` before activating a plugin that has been installed via AJAX. Without this check, the plugin would be automatically activated on the main site of the network.

Props ianmjones.

Fixes #31327.


git-svn-id: https://develop.svn.wordpress.org/trunk@31511 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 21:29:45 +00:00
Boone Gorges d854564f73 Better image-type support checks in image unit tests.
PHP can be compiled without support for certain image types. Our unit tests
should be sensitive to these configurations.

Fixes #31124.

git-svn-id: https://develop.svn.wordpress.org/trunk@31510 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 21:06:36 +00:00
Sergey Biryukov a468005276 Delegate `focusin` and `focusout` events for row actions to make sure the actions are always revealed on focus.
props afercia.
fixes #29765.

git-svn-id: https://develop.svn.wordpress.org/trunk@31509 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 20:13:31 +00:00
Sergey Biryukov 2dd6c6e696 Dashboard: Add a filter for the query arguments used for the Recent Posts widget.
props danielbachhuber.
fixes #29374.

git-svn-id: https://develop.svn.wordpress.org/trunk@31508 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-22 19:56:09 +00:00