Commit Graph

9047 Commits

Author SHA1 Message Date
Scott Taylor
ee98fd84bb Feeds: <comments> is optional in RSS2, so don't include it when comments aren't present or open. Same for <wfw:commentRss> and <slash:comments>
Adds unit test.

Props swissspidy, realloc, hakre, sivel.
Fixes #9134.


git-svn-id: https://develop.svn.wordpress.org/trunk@35506 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 17:46:41 +00:00
Drew Jaynes
14cd5cf3ed Taxonomy: Introduce the dynamic taxonomy_labels_{$taxonomy} filter, which can be used to manipulate the labels for a given taxonomy.
The addition of this hook brings parity with the earlier-introduced `post_type_labels_{$post_type}` filter, which allows for similarly manipulating labels for a given post type.

Note: It isn't possible to unset or remove default labels via either of these hooks, only to overwrite. This is because WordPress relies on defaults being set for use in various UIs and admin experiences.

Props flixos90.
Fixes #34554.


git-svn-id: https://develop.svn.wordpress.org/trunk@35504 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 16:02:12 +00:00
Drew Jaynes
ebfc39e754 Docs: Add a missing return description for _get_custom_object_labels(), a private core helper function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35503 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 15:46:49 +00:00
SergeyBiryukov
059eb46ddd Menus: After [35450], use correct IDs in $initial_meta_boxes.
Props swissspidy.
Fixes #33925.

git-svn-id: https://develop.svn.wordpress.org/trunk@35502 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 10:55:01 +00:00
Weston Ruter
46778fe2b0 Customize: Simplify condition for returning nav_menus_invalid_post_type error.
Props swissspidy.
See #16075.


git-svn-id: https://develop.svn.wordpress.org/trunk@35501 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 07:28:36 +00:00
Weston Ruter
5084a0b28a Customize: Add support for post_type_archive nav menu items.
Props celloexpressions, westonruter.
Fixes #16075.


git-svn-id: https://develop.svn.wordpress.org/trunk@35500 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 04:29:39 +00:00
Gary Pendergast
ff6e398b6f Media Library: Allow longer labels in the filter dropdowns.
Props aaronrutley, AlbertoCT.

Fixes #32005.




git-svn-id: https://develop.svn.wordpress.org/trunk@35499 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 00:40:31 +00:00
Andrew Ozz
01e9de382e Responsive images:
- Fix `_wp_upload_dir_baseurl()` to cache by blog_id.
- Replace `path_join()` with `trailingslashit()`, it's much faster.
- Rename $image_url to $image_src for consistency (used at about 50 other places).
- Couple of tests fixes.

See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35498 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 00:21:23 +00:00
Sergey Biryukov
88c274fad8 Formatting: wp_make_link_relative() should return an empty string if no path is present in the link.
Props bcworkz, MikeHansenMe, chriscct7, SergeyBiryukov.
Fixes #26819.

git-svn-id: https://develop.svn.wordpress.org/trunk@35497 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 21:35:17 +00:00
Sergey Biryukov
b077aecd6a Accessibility: After [35130], adjust the h2.nav-tab-wrapper selector to only override .wrap > h2:first-child.
This improves compatibility with plugins that use navigation tabs as a first H2 heading on their screens.

Props afercia.
Fixes #33559.

git-svn-id: https://develop.svn.wordpress.org/trunk@35496 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 20:48:21 +00:00
DrewAPicture
d49c379d18 Docs: Fix two notations for the $_wp_real_parent_file global, which is an array.
Props NExt-Season.
Fixes #34443.


git-svn-id: https://develop.svn.wordpress.org/trunk@35495 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 20:12:02 +00:00
Andrea Fercia
f25e642086 Accessibility: Improve buttons focus and links style in the install screens.
Fixes #34530.

git-svn-id: https://develop.svn.wordpress.org/trunk@35494 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 17:58:15 +00:00
Andrea Fercia
29f271da44 Media: Improve form fields labels association in the Edit Media screen.
Fixes #34548.

git-svn-id: https://develop.svn.wordpress.org/trunk@35493 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 16:01:11 +00:00
Andrea Fercia
3b587473b5 WP oEmbed: Improve the Sharing dialog accessibility.
Improves ARIA attributes, focus handling, and constrains tabbing within the modal dialog.

Fixes #34484.

git-svn-id: https://develop.svn.wordpress.org/trunk@35492 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 15:48:37 +00:00
Andrew Ozz
d037ebdb31 Responsive images:
- More fixes to inline docs.
- Replace the last `wp_get_attachment_metadata()` with `get_post_meta()`.
- For consistency only accept array or named size in `wp_get_attachment_image_sizes()`.

Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35491 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 00:18:07 +00:00
Drew Jaynes
d464e70d9c Docs: Document use of the $comment_status global in the DocBlock for WP_Comments_List_Table::handle_row_actions().
Props shimakyohsuke.
Fixes #34425.


git-svn-id: https://develop.svn.wordpress.org/trunk@35490 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-02 21:32:14 +00:00
Sergey Biryukov
ae68fbfcee Docs: After [32654], remove duplicate @param tag in WP_List_Table::set_pagination_args() DocBlock.
Add `@since` tag.

Props bobbingwide.
See #32444.

git-svn-id: https://develop.svn.wordpress.org/trunk@35489 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-02 21:02:29 +00:00
Gary Pendergast
c9f7e05f7b Upgrades: Add support for FULLTEXT indexes to dbDelta().
Props edirect24, mdawaffe, pento.

Fixes #14445.



git-svn-id: https://develop.svn.wordpress.org/trunk@35487 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 23:09:49 +00:00
Weston Ruter
3ef1e8194b Customize: Fix auto-expand (and focus) on newly added widgets.
Add widget controls with an initially-true `active` state so that calling `expand()` will not be short-circuited. Previously the `active` state would be set once the preview refreshes, but this happens too late for the `addWidget` call. Fixes regression introduced in [35231].

Fixes #34514.


git-svn-id: https://develop.svn.wordpress.org/trunk@35486 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 22:26:47 +00:00
Drew Jaynes
d74794fdde Docs: Correctly notate that the default $width and $height embed dimensions are passed to the embed_defaults filter as a compacted array, and not two distinct parameters.
Props swissspidy.
Fixes #34522.


git-svn-id: https://develop.svn.wordpress.org/trunk@35485 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 15:41:28 +00:00
Sergey Biryukov
bce985a5d7 Docs: Correct $post parameter description for display_post_states filter.
Props grapplerulrich.
Fixes #34541.

git-svn-id: https://develop.svn.wordpress.org/trunk@35484 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 14:05:42 +00:00
Weston Ruter
204bad4685 Customize: Return user to referring URL when leaving Customizer in absence of return query param.
When referring URL is not available, default returning user to frontend URL instead of admin URL. Themes page is updated to include the `return` path in Customizer links.

Props McGuive7, westonruter.
Fixes #32637.


git-svn-id: https://develop.svn.wordpress.org/trunk@35483 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 06:39:50 +00:00
Sergey Biryukov
ca898ccbdb Post List Table: Hierarchical post types should not default to sorting by date.
Regression introduced in [34728].

Props ellie.roepken.
Fixes #34473. See #25493.

git-svn-id: https://develop.svn.wordpress.org/trunk@35482 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 00:48:36 +00:00
Andrew Ozz
f64bc40f69 Responsive images: add $image_url parameter to wp_get_attachment_image_sizes() and use it in the filter. This allows themes and plugins to identify the image.
Props joemcgill.
Fixes #34477.

git-svn-id: https://develop.svn.wordpress.org/trunk@35481 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 22:48:08 +00:00
Scott Taylor
d74ab4b6df Canonical: when /%post_id%/ is the permalink structure, don't redirect IDs that match Auto Drafts.
Props SergeyBiryukov.
Fixes #29431.


git-svn-id: https://develop.svn.wordpress.org/trunk@35480 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:53:41 +00:00
Scott Taylor
bd7bf83886 Media: add a new image size, medium_large. Bumps db version to add new options.
Adds unit tests.

Props DH-Shredder, joemcgill, azaozz.
Fixes #34196.


git-svn-id: https://develop.svn.wordpress.org/trunk@35479 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:49:26 +00:00
Scott Taylor
d944108b13 WP oEmbed: Improve height attribute sanitization
Props afercia, swissspidy.
Fixes #34527.


git-svn-id: https://develop.svn.wordpress.org/trunk@35478 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:38:07 +00:00
Scott Taylor
aa616b1b45 Admin Menu: allow more than one menu item to be added at the same priority/position.
Props chriscct7.
Fixes #23316.


git-svn-id: https://develop.svn.wordpress.org/trunk@35477 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:30:06 +00:00
Scott Taylor
df134d1763 Filesystem: in WP_Filesystem_FTPext::parselisting(), check for the existence of $b['islink'] before using it.
Props jesin.
Fixes #27975.


git-svn-id: https://develop.svn.wordpress.org/trunk@35476 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:16:32 +00:00
Scott Taylor
957a800bd3 Comments: don't auto-close comments on draft posts.
Adds unit tests.

Props solarissmoke, MikeHansenMe, nacin, rachelbaker.
Fixes #20262.


git-svn-id: https://develop.svn.wordpress.org/trunk@35475 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:12:16 +00:00
Scott Taylor
14253d11b3 REST API: remove the @internal annotation from rest_api_default_filters().
Props swissspidy, rachelbaker.
Fixes #34219.


git-svn-id: https://develop.svn.wordpress.org/trunk@35474 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:07:21 +00:00
Scott Taylor
96eda396a6 Nav Menus: add responsive styles for viewport between 768 and 1000px.
Props datta.parad, chriscct7.
Fixes #28912.


git-svn-id: https://develop.svn.wordpress.org/trunk@35473 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:04:04 +00:00
Sergey Biryukov
fbd0b570fc Embeds: In get_post_embed_html(), move the optional $post argument after the required $width and $height.
Props swissspidy.
Fixes #34523.

git-svn-id: https://develop.svn.wordpress.org/trunk@35472 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 15:50:23 +00:00
Sergey Biryukov
29f940c5b2 Embeds: In get_oembed_response_data(), make the $post argument required.
`get_oembed_response_data()` is called by the API endpoint controller and never in a context where it makes sense to use the global post object.

Props swissspidy.
See #34523.

git-svn-id: https://develop.svn.wordpress.org/trunk@35471 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 15:42:01 +00:00
Sergey Biryukov
b0c7058037 Embeds: Fix typo in oembed_request_post_id filter DocBlock.
Props swissspidy.
See #34523.

git-svn-id: https://develop.svn.wordpress.org/trunk@35470 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 15:37:10 +00:00
Andrea Fercia
c01ce19d70 Dashboard: Activity widget CSS cleanup after [35420].
Props tyxla.
Fixes #34524. See #33558.

git-svn-id: https://develop.svn.wordpress.org/trunk@35469 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 13:48:14 +00:00
Drew Jaynes
37145d5b88 Docs: Use 3-digit, x.x.x-style semantic versioning in the DocBlocks for post_form_autocomplete_off() and WP_Filesystem_SSH2::sftp_path().
Props aaronrutley.
Fixes #34518.


git-svn-id: https://develop.svn.wordpress.org/trunk@35468 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 13:15:01 +00:00
Gary Pendergast
2edd6a894b Embeds: Revert [35083], as the PNG files ended up not being used in [35466].
See #34204.



git-svn-id: https://develop.svn.wordpress.org/trunk@35467 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 04:41:07 +00:00
Gary Pendergast
47e6c78d88 Embeds: Add fallbacks for IE7-9.
Older IE versions need just that little bit of extra tender care to keep them going.

Props peterwilsoncc, swissspidy, pento.

Fixes #34204.



git-svn-id: https://develop.svn.wordpress.org/trunk@35466 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 04:37:41 +00:00
Andrew Ozz
62c0557b90 Responsive images: few more inline docs fixes.
Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35465 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 23:35:14 +00:00
Andrew Ozz
98a63f523f Responsive images:
- Merge `wp_image_srcset_attr()` into `wp_calculate_image_srcset()`.
- Remove the `wp_image_srcset` filter.
- Fix the tests for the above changes. 

See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35464 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 23:26:44 +00:00
Andrea Fercia
90a15b9649 Media: Restore proper conditional statement broken after [35427].
Unprops afercia.
See #34273.

git-svn-id: https://develop.svn.wordpress.org/trunk@35463 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 22:05:22 +00:00
John Blackbourn
31f63b8b52 Remove trailing whitespace introduced in [35351].
Props rachelbaker
Unprops johnbillion
Fixes #34512


git-svn-id: https://develop.svn.wordpress.org/trunk@35462 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 21:38:36 +00:00
Helen Hou-Sandi
a701118676 View mode is only a screen option for posts lists.
see #22222.


git-svn-id: https://develop.svn.wordpress.org/trunk@35461 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 21:02:35 +00:00
John Blackbourn
0b05c7aa24 Add wp-post-new-reload to the list of removable query vars so it doesn't persist in the URL.
Fixes #34510


git-svn-id: https://develop.svn.wordpress.org/trunk@35460 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 18:05:31 +00:00
Andrea Fercia
2b54d3143b Accessibility: Bump the Settings API sections heading one level up.
Also, fix a typo in the `do_settings_sections()` DocBlock.

Props neoxx.
Fixes #34492.

git-svn-id: https://develop.svn.wordpress.org/trunk@35459 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 15:29:31 +00:00
Sergey Biryukov
fff36156c2 Don't use <a> in translatable strings in theme-compat/sidebar.php.
Add translator comments.

Props ramiy.
Fixes #34503.

git-svn-id: https://develop.svn.wordpress.org/trunk@35458 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 10:39:02 +00:00
Sergey Biryukov
80a257622b Add translator comments for strings in theme-compat/header.php.
Props ramiy.
See #34503.

git-svn-id: https://develop.svn.wordpress.org/trunk@35457 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 10:38:20 +00:00
Sergey Biryukov
8cd3b7d040 Add translator comments for strings in theme-compat/footer.php.
Props ramiy.
See #34503.

git-svn-id: https://develop.svn.wordpress.org/trunk@35456 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 10:37:52 +00:00
Sergey Biryukov
8334945146 Don't use <a> in translatable string in theme-compat/comments.php.
Add translator comments.

Props ramiy.
See #34503.

git-svn-id: https://develop.svn.wordpress.org/trunk@35455 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 10:37:09 +00:00
Sergey Biryukov
bcc5046d40 Add translator comments for strings in theme-compat/comments-popup.php.
Props ramiy.
See #34503.

git-svn-id: https://develop.svn.wordpress.org/trunk@35454 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 10:34:37 +00:00
Sergey Biryukov
64bf19ba40 Don't use <a> in translatable string in wp-includes/ms-load.php.
Add translator commment.

Props ramiy.
Fixes #34506.

git-svn-id: https://develop.svn.wordpress.org/trunk@35453 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 09:15:42 +00:00
Sergey Biryukov
4bca320a77 Don't use <strong> in translatable string in wp-includes/nav-menu.php.
Add translator commment.

Props ramiy.
Fixes #34505.

git-svn-id: https://develop.svn.wordpress.org/trunk@35452 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 08:56:36 +00:00
Sergey Biryukov
7e3cac2095 Don't use <strong> in translatable strings in wp-signup.php.
Add translator commments.

Props ramiy.
Fixes #34502.

git-svn-id: https://develop.svn.wordpress.org/trunk@35451 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 08:51:24 +00:00
Drew Jaynes
a18f309761 Menus: Prevent display conflicts in the screen options for Menus when a post type and taxonomy share the same slug.
Prior to this change, both taxonomies and post types added meta boxes to the Menus UI (which in-turn registered screen options) using the same ID formula: `add-{$id}`. This caused a conflict between the two elements, resulting in the rendering of a screen option for only the taxonomy or post type but not both. Moving to a new meta box ID for post types, `add-post-type-{$id}`, removes that conflict.

Note: This change in meta box IDs for post types effectively resets current user settings for the visibility of post types in the Menus UI.

Fixes #33925.


git-svn-id: https://develop.svn.wordpress.org/trunk@35450 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 05:46:53 +00:00
Drew Jaynes
cc8772262d Multisite: Restore display of the Toolbar on wp-activate.php while logged-in.
Just as with wp-signup.php, display of the Toolbar on wp-activate.php was broken in [23512] due to a hook change for the `_wp_admin_bar_init()` callback. wp-signup.php was fixed in [35423] for #34418.

See [35423] for more in-depth background and reasoning behind restoring display of the Toolbar on wp-activate.php and wp-signup.php.

Fixes #34496. See #34418.


git-svn-id: https://develop.svn.wordpress.org/trunk@35449 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 04:23:13 +00:00
Gary Pendergast
11ff4d07f9 Buttons: Add some vendor prefixes missed in [35422].
See #31459.



git-svn-id: https://develop.svn.wordpress.org/trunk@35448 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 03:12:44 +00:00
Sergey Biryukov
eb0a1074d7 Don't use <strong> in translatable strings in wp-signup.php.
Add translator commments.

Props ramiy.
Fixes #34502.

git-svn-id: https://develop.svn.wordpress.org/trunk@35447 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 02:08:03 +00:00
John Blackbourn
3eb0e3a4bb Ensure that the scheme used in the URL returned by get_blogaddress_by_id() always reflects the blog's URL, instead of using http.
Props thomaswm
Fixes #14867


git-svn-id: https://develop.svn.wordpress.org/trunk@35446 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 02:01:32 +00:00
Sergey Biryukov
bb045e4e3c Replace a second instance of <code> in translatable string left in [35440].
Props ramiy.
See #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35445 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:55:49 +00:00
Sergey Biryukov
dfd5f4c188 Don't use <strong> in translatable string in wp-admin/includes/nav-menu.php.
Add translator commment.

Props ramiy.
Fixes #34500.

git-svn-id: https://develop.svn.wordpress.org/trunk@35444 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:36:53 +00:00
Sergey Biryukov
4c7f6dfad3 Don't use <a> in translatable strings in `wp-admin/includes/dashboard.php'.
Add translator commments.

Props ramiy.
Fixes #34501.

git-svn-id: https://develop.svn.wordpress.org/trunk@35443 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:32:17 +00:00
Sergey Biryukov
aee4a4e278 Don't use <strong> in translatable string in wp-admin/includes/nav-menu.php.
Add translator commment.

Props ramiy.
Fixes #34500.

git-svn-id: https://develop.svn.wordpress.org/trunk@35442 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:16:39 +00:00
Sergey Biryukov
9e8e68f001 Add <code> tag missed in [35440].
See #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35441 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:11:53 +00:00
Sergey Biryukov
540e4b5edd Don't use <code> in translatable strings in wp-admin/includes/class-wp-plugins-list-table.php.
Add translator commments.

Props ramiy.
Fixes #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35440 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:07:11 +00:00
Sergey Biryukov
d21d397d49 Don't use <code> in translatable string in wp-admin/includes/media.php.
Add translator commment.

Props ramiy.
Fixes #34499.

git-svn-id: https://develop.svn.wordpress.org/trunk@35439 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 00:57:22 +00:00
Sergey Biryukov
99f4630635 Don't use <code> in translatable strings in options-general.php.
Add translator commments.

Props ramiy.
Fixes #34497.

git-svn-id: https://develop.svn.wordpress.org/trunk@35438 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 00:51:03 +00:00
Gary Pendergast
63d9e9df96 Embeds: Provide a cached text fallback.
Sometimes, embedded sites might suffer from less than 100% uptime. Instead of leaving the embedding site with a big blank space where the embed should be, let's fall back to a link to the embedded post, so there's at least some context for the post.

Fixes #34462.



git-svn-id: https://develop.svn.wordpress.org/trunk@35437 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 23:10:46 +00:00
Gary Pendergast
4832d8d933 Embeds: Who put this REST API infrastructure in my WordPress?
Well, while it's here, we probably should make use of it. The oEmbed endpoint now uses the REST API infrastructure, instead of providing its own.

Props swissspidy.

Fixes #34207.



git-svn-id: https://develop.svn.wordpress.org/trunk@35436 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 22:50:13 +00:00
John Blackbourn
4b10def07e Correctly populate the user_id field for comments when a user submits a comment while logged in.
Props imath
Fixes #34493


git-svn-id: https://develop.svn.wordpress.org/trunk@35435 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 21:28:39 +00:00
Sergey Biryukov
170d361287 REST API: Use correct version in _doing_it_wrong() call.
Props TobiasBg.
Fixes #34490.

git-svn-id: https://develop.svn.wordpress.org/trunk@35434 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 20:11:22 +00:00
Sergey Biryukov
42e7bfd9b5 REST API: Add missing translator comments for deprecated function and argument strings.
Props akirk.
Fixes #34486.

git-svn-id: https://develop.svn.wordpress.org/trunk@35433 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 19:03:47 +00:00
Sergey Biryukov
391b67356a Embeds: Include post name in "Continue reading" links to provide a readable link for screenreaders.
Props swissspidy.
Fixes #34481.

git-svn-id: https://develop.svn.wordpress.org/trunk@35432 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 13:20:04 +00:00
Sergey Biryukov
78a2cf3db6 Rename internal variable in set_transient().
The previous name was inadvertently changing the dynamic part of `set_transient_{transient}` action and the transient name passed to the action since [35082].

Props GregLone.
Fixes #34470.

git-svn-id: https://develop.svn.wordpress.org/trunk@35431 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 11:51:21 +00:00
Gary Pendergast
198ad14ffd Embeds: Tweak a string added in [35429], and add a translator comment.
See #32522.



git-svn-id: https://develop.svn.wordpress.org/trunk@35430 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 11:41:32 +00:00
Gary Pendergast
01f507a051 Embeds: Tweak the "embed not found" message, based on the Twenty Sixteen 404 template.
See #32522.



git-svn-id: https://develop.svn.wordpress.org/trunk@35429 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 11:09:39 +00:00
Gary Pendergast
9b47d5fcd6 Shortcodes: Tweak the error messages added in [34745].
See #34090.



git-svn-id: https://develop.svn.wordpress.org/trunk@35428 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-29 10:31:31 +00:00
Andrea Fercia
347b0bf108 Media: Improve the headings hierarchy in the Media Views for better accessibility.
Fixes #34273.

git-svn-id: https://develop.svn.wordpress.org/trunk@35427 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 23:07:08 +00:00
Andrew Ozz
63b27d209a Responsive images: add inline docs for private functions.
Props swissspidy.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35426 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 21:54:04 +00:00
Scott Taylor
501fef30d6 Bump 4.4 Beta 2.
git-svn-id: https://develop.svn.wordpress.org/trunk@35425 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 20:47:40 +00:00
Scott Taylor
1cf714aa3d 4.4-beta2
git-svn-id: https://develop.svn.wordpress.org/trunk@35424 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 20:31:36 +00:00
Drew Jaynes
f4bba7cf95 Multisite: Restore displaying the Toolbar on wp-signup.php while logged-in.
Prior to [23512], the Toolbar was still displayed on wp-signup.php while logged-in because it was hooked to the `init` action. When `_wp_admin_bar_init()` was moved to instead fire on `template_redirect` for the front-end and `admin_init` on the back-end, the visibility was lost because `template_redirect` isn't fired on wp-signup.php due to `WP_USE_THEMES` not being defined.

In order to maintain expected display results, a default filter has been added to hook `_wp_admin_bar_init()` to the `before_signup_header` action. This approach has the added benefit of allowing `_wp_admin_bar_init()` to be fired prior to the `wp_head` action where `_admin_bar_bump_cb()` is called (or the callback defined when 'admin-bar' theme support is added).

Fixes #34418.


git-svn-id: https://develop.svn.wordpress.org/trunk@35423 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 20:29:19 +00:00
Helen Hou-Sandi
21f7dddfe4 Buttons: Screen Options/Help shouldn't have active styling.
see #31459.


git-svn-id: https://develop.svn.wordpress.org/trunk@35422 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 20:25:45 +00:00
Helen Hou-Sandi
6c243567cf Buttons: More consistent focus styling.
props afercia.
fixes #32915.


git-svn-id: https://develop.svn.wordpress.org/trunk@35421 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 20:16:43 +00:00
Scott Taylor
e52a0d4e7f Dashboard: cleanup after [35414].
Props afercia.
Fixes #33558.


git-svn-id: https://develop.svn.wordpress.org/trunk@35420 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 20:07:16 +00:00
Andrew Ozz
2fadc857de Responsive images:
- Check if wp_get_attachment_metadata() has returned an array to prevent errors when using SVGs.
- Only add the srcset attribute if there will be a sizes attribute.
- Better filter names.
- Some more inline docs fixes.

Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35419 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 20:00:14 +00:00
Scott Taylor
430d5b13be Thickbox: spinner should disappear when loading is done.
Props niklasbr, afercia.
Fixes #33311.


git-svn-id: https://develop.svn.wordpress.org/trunk@35418 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 18:18:42 +00:00
Boone Gorges
f1ca28c2ab Don't specify an offset default in get_posts().
The default value should be a null offset. A `0` default overrides any value
of `paged` passed to `get_posts()`. See [34697].

Fixes #34060.

git-svn-id: https://develop.svn.wordpress.org/trunk@35417 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 18:17:27 +00:00
Scott Taylor
ad471ac474 Admin Menu: after [34861], prevent adjacent separators.
Props johnjamesjacoby.
Fixes #24104.


git-svn-id: https://develop.svn.wordpress.org/trunk@35416 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 18:05:05 +00:00
Scott Taylor
2b11f8cc1c Mail: in wp_notify_postauthor() and wp_notify_moderator(), ensure that special chars aren't HTML-encoded in the email message body.
Props solarissmoke, leemon.
Fixes #12584.


git-svn-id: https://develop.svn.wordpress.org/trunk@35415 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 18:02:41 +00:00
Scott Taylor
83f90bf851 Dashboard: make tags used for headings more semantic.
Props Cheffheid, afercia.
Fixes #33558.


git-svn-id: https://develop.svn.wordpress.org/trunk@35414 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 17:56:22 +00:00
John Blackbourn
c1aa66cd52 List the possible values for the dynamic portion of the {type}_template hook.
See #14310, #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@35413 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 14:05:04 +00:00
Andrew Ozz
855ba2518b Responsive images:
- Introduce `wp_calculate_image_srcset()` that replaces `wp_get_attachment_image_srcset_array()` and is used as lower level function for retrieving the srcset data as array.
- Use the new function when generating `srcset` and `sizes` on the front-end. This is faster as no (other) image API functions are used.
- Change the `wp_get_attachment_image_srcset()`. Now it is meant for use in templates and is no longer used in core.
- A few logic fixes and improvements.
- Some names changed to be (hopefully) more descriptive.
- Fixed/updated tests.

Props joemcgill, jaspermdegroot, azaozz.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35412 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 05:40:04 +00:00
Sergey Biryukov
21532e1f7f Settings: Don't display Site Address field description if WP_HOME is defined and the field is disabled.
Props dipesh.kakadiya.
Fixes #33354.

git-svn-id: https://develop.svn.wordpress.org/trunk@35411 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 04:53:56 +00:00
Dion Hulse
fb109971e4 Update Random_Compat to master.
This update mostly concerns OpenSSL being unusable on PHP 5.3~5.3.3.
See #28633, #34409


git-svn-id: https://develop.svn.wordpress.org/trunk@35410 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 01:11:57 +00:00
Dominik Schilling (ocean90)
60f6db0c06 Embeds: Provide a site icon via srcset for HiDPI screens.
Fixes #34433.

git-svn-id: https://develop.svn.wordpress.org/trunk@35409 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-27 20:59:37 +00:00
Dominik Schilling (ocean90)
88cdbb6a49 Embeds: Replace hardcoded error messages with get_status_header_desc( $http_code ).
Fixes #34275.

git-svn-id: https://develop.svn.wordpress.org/trunk@35408 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-27 20:43:00 +00:00
Drew Jaynes
1353016c4f Docs: Standardize the file header for wp-admin/includes/ms-deprecated.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35407 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-27 20:07:45 +00:00
Gary Pendergast
9387dff5af Embeds: Add a CDATA and HTML comment wrapper around the JavaScript included in the embed HTML. This ensures that user agents which naively strip unwanted tags, without also stripping the content within those tages (for example, Slack), don't show the embed as a mess of JavaScript.
Props peterwilsoncc.

Fixes #34429.



git-svn-id: https://develop.svn.wordpress.org/trunk@35406 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 23:54:04 +00:00
Sergey Biryukov
c608146996 After [35402], don't unnecessary run wp_get_attachment_metadata(), wp_get_attachment_image_srcset(), and wp_get_attachment_image_sizes() in wp_img_add_srcset_and_sizes().
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35405 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 18:41:31 +00:00
Sergey Biryukov
aeca8fcfd8 After [35402], don't unnecessary run wp_get_attachment_image_srcset() and wp_get_attachment_image_sizes() in wp_get_attachment_image() if srcset is passed as an argument.
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35404 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 18:40:01 +00:00
Drew Jaynes
c1db6a9a56 Docs: Add a @subpackage tag to the file header for wp-admin/includes/ms-admin-filters.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35403 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 18:05:52 +00:00
Sergey Biryukov
9b29cf2574 Remove assignments from conditions in wp_get_attachment_image() and wp_img_add_srcset_and_sizes().
See #34379.

git-svn-id: https://develop.svn.wordpress.org/trunk@35402 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 16:28:27 +00:00
Sergey Biryukov
558984a8ab Docs: After [34453], correct inline comments in wp_get_attachment_image_sizes().
Props jaspermdegroot.
Fixes #34453.

git-svn-id: https://develop.svn.wordpress.org/trunk@35401 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 16:16:52 +00:00
Sergey Biryukov
0dd41231fa Docs: After [35399], correct $class parameter type and description for post_class filter.
See #34452.

git-svn-id: https://develop.svn.wordpress.org/trunk@35400 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 15:11:53 +00:00
Sergey Biryukov
d8ddd686d5 In get_post_class(), ensure that we always coerce the class list passed to the function to an array, even when it's empty.
This is consistent with `get_body_class()`, see [18176].

See #34452.

git-svn-id: https://develop.svn.wordpress.org/trunk@35399 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 15:08:47 +00:00
Sergey Biryukov
8a105470b4 Docs: Correct $class parameter type and description for body_class filter.
Props JPry.
Fixes #34452.

git-svn-id: https://develop.svn.wordpress.org/trunk@35398 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 15:02:53 +00:00
Sergey Biryukov
ee4e4b8ff2 Embeds: Rename TinyMCE wpoembed plugin to wpembed.
Props swissspidy.
Fixes #34272.

git-svn-id: https://develop.svn.wordpress.org/trunk@35397 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 14:49:25 +00:00
Andrea Fercia
fa29612530 Customizer: Remove the no more used add-menu-item-loading spinner.
Also makes more room for longer translations.

Props dipali.dhole27@gmail.com.
Fixes #34342.

git-svn-id: https://develop.svn.wordpress.org/trunk@35396 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 13:58:53 +00:00
Gary Pendergast
6d8ecd2fd6 Embeds: Move the embed iframe script to the footer, as it isn't being run until DOMContentLoaded is fired.
Props brainstormforce, pratikchaskar.

Fixes #344444.



git-svn-id: https://develop.svn.wordpress.org/trunk@35395 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 05:49:51 +00:00
Gary Pendergast
887e88d7d0 Docs: Fix a typo in the print_embed_scripts() function header.
Props brainstormforce.

Fixes #34445.



git-svn-id: https://develop.svn.wordpress.org/trunk@35394 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 05:18:48 +00:00
Drew Jaynes
95be0b747f Docs: Add missing DocBlocks for the $type and $sidebar_id properties, and summaries for the to_json() and render_content() methods in WP_Widget_Area_Customize_Control.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35393 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-25 19:57:46 +00:00
Sergey Biryukov
ab7d3bd104 Post 4.4-beta1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@35392 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-25 15:18:03 +00:00
Andrea Fercia
07041ae87c Customizer: remove the title attribute from the Preview html element while loading.
Props mehulkaklotar.

Fixes #33250.

git-svn-id: https://develop.svn.wordpress.org/trunk@35391 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-25 15:13:32 +00:00
Scott Taylor
1836e14bf2 Fix the @author doc param encoding in Text/Diff/Engine/string so the file is recognized as UTF-8, not ISO-8859-1.
git-svn-id: https://develop.svn.wordpress.org/trunk@35390 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 22:44:36 +00:00
Scott Taylor
b4c270030f Customize: move WP_Customize_Control subclasses to wp-includes/customize, they load in the exact same place.
See #34432.


git-svn-id: https://develop.svn.wordpress.org/trunk@35389 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 18:56:07 +00:00
Dominik Schilling (ocean90)
707cc2ae9e Use correct placeholders for translator comments added in [35303].
See #31078.

git-svn-id: https://develop.svn.wordpress.org/trunk@35388 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 18:49:11 +00:00
Drew Jaynes
62b00c70cc Docs: Add a version to the file header for wp-admin/includes/revision.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35387 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 18:28:10 +00:00
Scott Taylor
c43245e29d Customize: move WP_Customize_Panel subclass to wp-includes/customize, it loads in the exact same place.
See #34432.


git-svn-id: https://develop.svn.wordpress.org/trunk@35386 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 18:24:21 +00:00
Scott Taylor
625514655e Customize: move WP_Customize_Section subclasses to wp-includes/customize, they load in the exact same place.
See #34432.


git-svn-id: https://develop.svn.wordpress.org/trunk@35385 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 18:20:25 +00:00
Sergey Biryukov
9f0076436b Editor: After [33927], make sure user_can_richedit() returns true for Microsoft Edge.
Props usermrpapa.
Fixes #34431.

git-svn-id: https://develop.svn.wordpress.org/trunk@35384 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 18:12:10 +00:00
Scott Taylor
8541ba7907 Customize: move WP_Customize_Setting subclasses to wp-includes/customize, they load in the exact same place.
See #34432.


git-svn-id: https://develop.svn.wordpress.org/trunk@35383 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 18:10:17 +00:00
Scott Taylor
a18feed6bd Nav Menus: show custom post type Archive item at the top of the View All tab for the post type on the legacy Nav Menu screen.
Props aaroncampbell, DrewAPicture, seanchayes, hlashbrooke, paulwilde, ericlewis, raulillana
See #16075.


git-svn-id: https://develop.svn.wordpress.org/trunk@35382 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 17:45:11 +00:00
Sergey Biryukov
a97bf5b2ca Docs: Change variable name in WP_Customize_Widgets::filter_customize_dynamic_setting_args() DocBlock to match the actual variable.
Props mismith227, swissspidy.
Fixes #34426.

git-svn-id: https://develop.svn.wordpress.org/trunk@35381 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 14:41:19 +00:00
Sergey Biryukov
9da02a9155 Remove unused variable in _WP_Editors::editor().
Props Athsear.
Fixes #34427.

git-svn-id: https://develop.svn.wordpress.org/trunk@35380 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 14:31:05 +00:00
Sergey Biryukov
a001771ec4 Site Icon: Introduce get_site_icon_url filter for the icon URL.
Remove `oembed_site_icon_url` filter added in [34903].

Props swissspidy.
Fixes #34411.

git-svn-id: https://develop.svn.wordpress.org/trunk@35379 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 21:16:30 +00:00
Andrew Ozz
2c1f21190d Responsive Images: fix typo in r35358.
Props aduth.
See #34341.

git-svn-id: https://develop.svn.wordpress.org/trunk@35378 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 17:37:35 +00:00
Sergey Biryukov
fd19ba9cde After [34891] and [35376], add new labels to changelog entries.
Props afercia.
Fixes #32147.

git-svn-id: https://develop.svn.wordpress.org/trunk@35377 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 16:53:29 +00:00
Sergey Biryukov
c7cc7c44fe After [34891], rename new post type and taxonomy label keys to match the default strings.
See #32147.

git-svn-id: https://develop.svn.wordpress.org/trunk@35376 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 16:47:57 +00:00
Drew Jaynes
46ae6f1892 Docs: Syntax fixes for deprecating WP_Http::parse_url().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35375 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 15:42:51 +00:00
Sergey Biryukov
d842c03e02 Docs: Correct the type and description of $post parameter passed to the attachment_fields_to_save filter.
Props swissspidy.
Fixes #34404.

git-svn-id: https://develop.svn.wordpress.org/trunk@35374 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 13:00:11 +00:00
Sergey Biryukov
bcb1e8eda2 Docs: Use consistent naming and capitalization of menu names in add_submenu_page() wrappers.
Props atomicjack, Mckilem.
Fixes #34360.

git-svn-id: https://develop.svn.wordpress.org/trunk@35373 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 12:01:11 +00:00
Sergey Biryukov
f8fa5c0e53 In WP_Locale::init(), replace space as a thousands separator with a non-breaking space.
Also replace `'&nbsp;` and `&#160;` HTML entities with the actual character, since PHP < 5.4.0 does not allow multiple bytes to be used for decimal points or thousands separators.

Fixes #10373.

git-svn-id: https://develop.svn.wordpress.org/trunk@35372 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 11:50:37 +00:00
dd32
f935d4c26b Updates: Add a generic failure case to the ajax update endpoint for when the WP_Error value hasn't been found.
See #34403


git-svn-id: https://develop.svn.wordpress.org/trunk@35371 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 07:34:02 +00:00
Dion Hulse
8c33fe770e Use wp_parse_url() in esc_url() to avoid parsing bugs in < PHP 5.4.7.
Props johnbillion for unit tests
See #34408
Fixes #34202


git-svn-id: https://develop.svn.wordpress.org/trunk@35370 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 05:56:25 +00:00
Dion Hulse
cacd015856 WP_HTTP: Promote the WP_HTTP::parse_url() method to a more generic wp_parse_url() function.
Fixes #34408


git-svn-id: https://develop.svn.wordpress.org/trunk@35369 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 05:53:05 +00:00
Dion Hulse
743fe671f1 Comments: Use a full URL rather than a relative one for links which can contain IPv6 addresses to avoid an issue where the URL was being eaten by escaping functions.
See #34407, #34202
Fixes #34054


git-svn-id: https://develop.svn.wordpress.org/trunk@35368 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 05:13:27 +00:00
Dion Hulse
75ab50c70e XMLRPC: Prevent authentication from occuring after a failed authentication attmept in any single XML-RPC call.
This hardens WordPress against a common vector which uses multiple user identifiers in a single `system.multicall` call. In the event that authentication fails, all following authentication attempts ''in that call'' will also fail.

Props dd32, johnbillion.
Fixes #34336


git-svn-id: https://develop.svn.wordpress.org/trunk@35366 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 04:45:10 +00:00
Dion Hulse
3a992e266f Update to Random_Compat 1.0.9.
This update includes fixes for Windows support & libSodium support, and removes the `Throwable` Polyfill due to PHP7 incompatibilities. 

Fixes #28633


git-svn-id: https://develop.svn.wordpress.org/trunk@35365 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 04:21:01 +00:00
Dion Hulse
b89670b0f6 Update variable naming after [35279].
See #29957.


git-svn-id: https://develop.svn.wordpress.org/trunk@35364 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 02:00:21 +00:00
Scott Taylor
a77a05447c 4.4-beta1
git-svn-id: https://develop.svn.wordpress.org/trunk@35362 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 21:44:57 +00:00
Scott Taylor
c6354d6bfd Plugins: after [35151], set default $restrict_network_* values to prevent notices.
Props johnjamesjacoby.
Fixes #20104.


git-svn-id: https://develop.svn.wordpress.org/trunk@35361 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:55:30 +00:00
Scott Taylor
9aba8ef2aa Options: remove old 'gzipcompression' and 'advanced_edit' options.
Props chriscct7, solarissmoke.
Fixes #12996.


git-svn-id: https://develop.svn.wordpress.org/trunk@35360 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:48:38 +00:00
Drew Jaynes
68c5efb7f3 Docs: Add a proper file header to wp-admin/includes/continents-cities.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35359 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:42:23 +00:00
Andrew Ozz
5aa7a8ce78 Responsive Images: limit the size of images included in srcset attributes. Introduce max_srcset_image_width filter to adjust the limit.
Props joemcgill.
Fixes #34341.

git-svn-id: https://develop.svn.wordpress.org/trunk@35358 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:30:12 +00:00
Helen Hou-Sandi
7adf6e9125 List tables: Move the view mode switcher into screen options for posts.
Having a view mode switcher nestled within table navigation makes no sense, especially now that it's a sticky user option. While less convenient for frequent switching, there is no evidence as of yet that there is a large userbase of frequent view mode switchers.

Introduces a filter for `view_mode_post_types`, which by default is all hierarchical post types with edit UI on.

props Oxymoron.
fixes #22222.


git-svn-id: https://develop.svn.wordpress.org/trunk@35357 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:24:10 +00:00
Scott Taylor
a37f75eb87 oEmbed: add Reddit Comments as a provider
Docs: https://github.com/reddit/reddit/wiki/oEmbed

Props swissspidy.
Fixes #31752.



git-svn-id: https://develop.svn.wordpress.org/trunk@35356 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 18:16:12 +00:00
Scott Taylor
6a3b784104 Media: in wp_get_attachment_image_sizes(), to streamline and for performance:
* Change the 3rd arg from `args` to `width`
* Change `wp_image_sizes_args` filter to `wp_get_attachment_image_sizes`

Updates unit tests.

Props joemcgill.
Fixes #34379.


git-svn-id: https://develop.svn.wordpress.org/trunk@35355 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 16:45:37 +00:00
Scott Taylor
a19a0e6e72 oEmbed: if SimpleXMLElement does not exist, return an HTTP Error 501 Not implemented response.
Props swissspidy.
Fixes #34274.


git-svn-id: https://develop.svn.wordpress.org/trunk@35354 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 16:37:31 +00:00
Scott Taylor
ff49cc7ebf REST API: don't load wp-admin/includes/admin.php on every request.
Props swissspidy.
Fixes #34395.


git-svn-id: https://develop.svn.wordpress.org/trunk@35353 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 16:28:40 +00:00
Sergey Biryukov
54c840dc04 Docs: Correct description for _wp_post_revision_fields() arguments.
See #13382.

git-svn-id: https://develop.svn.wordpress.org/trunk@35352 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 12:16:48 +00:00
John Blackbourn
1691563872 Force the REST API URL to use https for its scheme when the current request is served over HTTPS and the host name matches that of the REST API URL.
This allows sites to use an admin area over HTTPS with the front end over HTTP, and not end up with a cross-protocol problem when using the REST API URL in the admin area.

Fixes #34299


git-svn-id: https://develop.svn.wordpress.org/trunk@35351 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 00:07:36 +00:00
John Blackbourn
2e1b898077 Revert [34352], pending investigation.
See #34299


git-svn-id: https://develop.svn.wordpress.org/trunk@35349 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 23:05:43 +00:00
Andrea Fercia
bdffdf0eb6 Plugins: Improve the "Install Now" button vertical alignment in the Plugin Details modal dialog.
Props paulwilde.

Fixes #34199.

git-svn-id: https://develop.svn.wordpress.org/trunk@35343 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 21:54:42 +00:00
John Blackbourn
672782f0a6 Force the REST API URL to use https for its scheme when the current request is served over HTTPS and the host name matches that of the REST API URL.
This allows sites to use an admin area over HTTPS with the front end over HTTP, and not end up with a cross-protocol problem when using the REST API URL in the admin area.

Fixes #34299


git-svn-id: https://develop.svn.wordpress.org/trunk@35342 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 20:37:56 +00:00
Andrew Ozz
f447d2f5bf TinyMCE:
- Sanitize and render HTML in captions when showing a gallery preview (wpView).
- Encode/escape HTML entered in the text field in the wpLink dialog.

Props iseulde, kraftbj, jnylen0, shawarkhan.
Fixes #32616.

git-svn-id: https://develop.svn.wordpress.org/trunk@35341 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 20:37:54 +00:00
Helen Hou-Sandi
9e865f51a8 RIP #21759b, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35340 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:35:05 +00:00
Drew Jaynes
1a7298861b Comments: Introduce two new filters, notify_moderator and notify_post_author, both of which make it possible to selectively override site notification email settings for new comments.
The `notify_moderator` filter makes it possible to override the value for the `moderation_notify` option, which controls whether to send new comment emails to "site moderators", that is to say, the owner of the admin email for the site and the post author if they have the ability to modify the comment.

The `notify_post_author` filter likewise makes it possible to override the value for the `comments_notify` option, which controls whether to send new comment emails to the post author. If the post author is the comment author, default behavior is not to send the notification. Note: enabling or disabling notifications via this hook could also affect other recipients added via the 'comment_notification_recipients' filter in `wp_notify_postauthor()`, if hooked.

Passing a falsey value to either of the new filters will prevent notifications from being sent, regardless of their corresponding option values.

Adds tests.

Props coffee2code, adamsilverstein, DrewAPicture.
Fixes #761.


git-svn-id: https://develop.svn.wordpress.org/trunk@35339 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:34:06 +00:00
Andrea Fercia
ac3edc61fd Press This: Improve the "choose tags" button focus style.
Props adamholisky for the initial patch.

Fixes 34241.

git-svn-id: https://develop.svn.wordpress.org/trunk@35338 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:33:46 +00:00
Dominik Schilling (ocean90)
05356ff7dc Options: Hide the week starts on setting for installs that have the default setting already.
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35337 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 17:38:44 +00:00
Dominik Schilling (ocean90)
597e3630f3 WP Locale: Add a start_of_week property to store the start of the week per locale.
Props swissspidy.
See #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35336 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 17:27:47 +00:00
Boone Gorges
f492a81d70 Prevent non-public taxonomies from registering aquery var.
[34247] made the 'public' paramater of `register_taxonomy()` work by blocking
requests for non-public taxonomy archives during `parse_request()`. Blocking
taxonomy archive requests this late means that it's impossible to register an
independent query var that matches the slug of a non-public taxonomy. By
moving the block to `register_taxonomy()` - not allowing these taxonomies to
register their query vars in the first place - we free up the slug for other
use. In addition, we free up a bit of processing (no need to look for the query
var in `parse_request()` and better parallel the way non-public post types
work. See `register_post_type()`.

Non-public taxonomy archives that are requested using `?taxonomy=tax_name` are
still blocked during `parse_request`. It's only custom query vars -
`?tax_name=term` - that are affected by this change.

Props mboynes.
Fixes #21949.

git-svn-id: https://develop.svn.wordpress.org/trunk@35333 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:53:51 +00:00
Boone Gorges
e4b72ad5ca Don't force comment pagination.
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@35331 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:25:31 +00:00
Helen Hou-Sandi
11bd47beca Media: Update colors to match the times.
This bikeshed is a real nice blue.

props afercia.
fixes #34244. see #34388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35330 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:17:58 +00:00
Drew Jaynes
6c178fd1ab Docs: Add documentation in the form of a hash notation for default arguments accepted by wp_login_form().
Props ramiy for the initial patch.
Fixes #34364.


git-svn-id: https://develop.svn.wordpress.org/trunk@35328 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 15:37:23 +00:00
Helen Hou-Sandi
3d64414d5c wp_die(): Update colors and button styling.
see #34388, #31459.


git-svn-id: https://develop.svn.wordpress.org/trunk@35327 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 15:23:01 +00:00
Dominik Schilling (ocean90)
9a1b5f93cd List Tables: Replace the hyphen separator for titles and post/media states with a &mdash;.
Props McGuive7.
Fixes #23230.

git-svn-id: https://develop.svn.wordpress.org/trunk@35326 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:32:02 +00:00
Drew Jaynes
a28e35e462 Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES constants in [35286], use them in various places in core.
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:02:59 +00:00
Drew Jaynes
86794324c7 Docs: Improve the return description in the DocBlock for rest_send_allow_header().
Props danielbachhuber.
Fixes #34374.


git-svn-id: https://develop.svn.wordpress.org/trunk@35324 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 13:47:12 +00:00
Sergey Biryukov
bc2a538b1a REST API: Change nonce name to _wpnonce.
It's shorter and is compatible with the default name in `wp_nonce_field()`.

Props danielbachhuber.
Fixes #34375.

git-svn-id: https://develop.svn.wordpress.org/trunk@35323 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 08:13:18 +00:00
Sergey Biryukov
5bba750579 Add get_terms_defaults filter for the default arguments of get_terms().
Fixes #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35322 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 08:07:12 +00:00
Sergey Biryukov
f3f2a222b9 Reorder default arguments in get_terms() for consistency with the hash notation added in [29128].
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35321 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 08:00:56 +00:00
Sergey Biryukov
7b81e1e56c Docs: Correct function name in get_terms_args parameter description.
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35320 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 07:41:38 +00:00
Sergey Biryukov
892cef6da5 Docs: Correct duplicate hook reference for get_terms.
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35319 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 07:39:11 +00:00
Andrew Ozz
5bc6ae50ab Precommit cleanup, see r35313.
git-svn-id: https://develop.svn.wordpress.org/trunk@35318 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:32:54 +00:00
Andrew Ozz
7ba408c93e Widgets: add a button to delete all inactive widgets simultaneously for better UX.
Props cdog.
Fixes #19159.

git-svn-id: https://develop.svn.wordpress.org/trunk@35317 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:22:52 +00:00
Scott Taylor
ba1177bf4c Export: add missing labels and improvement accessibility of the Export screen.
Props afercia.
Fixes #33046.


git-svn-id: https://develop.svn.wordpress.org/trunk@35316 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:56:22 +00:00
Scott Taylor
6f6c0ebb52 Plugins/Updates: in request_filesystem_credentials(), alter the heading HTML tag based on the current screen for improved semantics.
Props afercia.
Fixes #34267.


git-svn-id: https://develop.svn.wordpress.org/trunk@35315 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:50:19 +00:00
Scott Taylor
51637379a2 Formatting: move url_shorten() from wp-admin/includes/misc.php to wp-includes/formatting.php for more global access.
Adds unit tests.

Props mulvane, chriscct7.
Fixes #20166.


git-svn-id: https://develop.svn.wordpress.org/trunk@35314 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:47:23 +00:00
Scott Taylor
be739bd6c0 Administration: the current admin menu item should have an aria-haspopup attribute when the menu is folded.
Unify the jQuery selector caching for `window`, `document`, and `body`.

Props afercia.
Fixes #32578.


git-svn-id: https://develop.svn.wordpress.org/trunk@35313 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:40:38 +00:00
Scott Taylor
e4bcddecfb Site Icon: make the default value for the site_icon option 0 in schema.php.
Props swissspidy, sebastian.pisula.
Fixes #34339.


git-svn-id: https://develop.svn.wordpress.org/trunk@35312 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:27:54 +00:00
Sergey Biryukov
5252cb7fe3 Autoprefixer for [35281].
See #33322.

git-svn-id: https://develop.svn.wordpress.org/trunk@35310 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:01:13 +00:00
Weston Ruter
ede4050ace Customizer: Prevent nav_menu_item settings from becoming dirty when their controls are set up.
Since `wp_setup_nav_menu_item()` returns the `classes` property as an array but the Customizer manages the value as a string, the setting needs to initially export the value as a string. This prevents the `classes` property type change from causing the setting to get marked as dirty even though nothing changed. This is a regression from [34788].

See #34111.


git-svn-id: https://develop.svn.wordpress.org/trunk@35308 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 22:44:44 +00:00
Weston Ruter
bde89adaf8 Customizer: Introduce customize_loaded_components filter to allow core components to be disabled.
Also move style rule from `customize-nav-menus.css` to `customize-controls.css` so that widgets button is properly styled when `nav_menus` component is excluded from loading. See [35304]. See #33327.

Props westonruter, DrewAPicture.
Fixes #33552.


git-svn-id: https://develop.svn.wordpress.org/trunk@35307 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 22:15:11 +00:00
Andrew Ozz
73d755b67a TinyMCE: update to 4.2.6. Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=887.
Fixes #34331.

git-svn-id: https://develop.svn.wordpress.org/trunk@35306 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 22:05:31 +00:00
Weston Ruter
261aa51182 Customizer: Allow new option settings to not be saved as autoloaded by passing an autoload arg value of false.
The `autoload` argument value is passed along to `update_option()` which has accepted an `$autoload` parameter since [31628].

Props westonruter, dlh.
See #26394.
Fixes #33499.


git-svn-id: https://develop.svn.wordpress.org/trunk@35305 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 21:18:04 +00:00
Andrea Fercia
8774b40dc8 Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons.
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.

Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.

Fixes #33327.

git-svn-id: https://develop.svn.wordpress.org/trunk@35304 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 20:14:51 +00:00
Drew Jaynes
11f4d7bb68 Docs: Add translator comments for two _deprecated_argument() calls added to get_wp_title_rss() and wp_title_rss() in [35294].
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35303 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 19:19:37 +00:00
Weston Ruter
9724c7cdbd Customizer: Implement indicators for invalid nav menu items.
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.

Props kucrut, westonruter.
Fixes #33665.


git-svn-id: https://develop.svn.wordpress.org/trunk@35302 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 19:07:58 +00:00
Drew Jaynes
1871d57dc5 Docs: Adjust syntax in the hook doc summaries for the document_title_separator and document_title_parts filters, introduced in [35294].
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35301 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:35:46 +00:00
Drew Jaynes
b11b651d24 Docs: Fix indentation and improve usefulness of inline comments surrounding the if/elseif conditions for assigning document titles in wp_get_document_title().
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35300 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:30:59 +00:00
Konstantin Obenland
e9579b3ed5 Site Icon: Get site icon ID only when needed.
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.



git-svn-id: https://develop.svn.wordpress.org/trunk@35299 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:22:41 +00:00
Drew Jaynes
8ec6153115 Docs: Update the hook doc for the pre_get_document_title filter to explain ''what'' value is filterable rather than ''why'' the value is filterable :-)
The hook was introduced in [35294].

See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35298 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:13:13 +00:00
Drew Jaynes
e5ec034d8f Docs: Improve vague changelog entries for functions and hooks where arguments were deprecated in [35294].
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35297 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:09:06 +00:00
Drew Jaynes
2f5c72fea8 Docs: Fix up DocBlock syntax for the now-deprecated wp_title().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35296 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 17:52:21 +00:00
Konstantin Obenland
c7a86be42c Tests: Use updated filter names and oembed title for UT sanity.
See [35294], #31078.


git-svn-id: https://develop.svn.wordpress.org/trunk@35295 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 17:04:29 +00:00
Konstantin Obenland
d625bd2428 Themes: Improve document title output.
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.



git-svn-id: https://develop.svn.wordpress.org/trunk@35294 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 16:20:04 +00:00
Sergey Biryukov
1940317385 In wp_list_categories(), rewrite a long condition for clarity.
See #34363.

git-svn-id: https://develop.svn.wordpress.org/trunk@35293 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 16:12:21 +00:00
Sergey Biryukov
0a614515ac Tags: Avoid a double trailing space after tags separator in auto-suggest.
Props afercia.
Fixes #33881.

git-svn-id: https://develop.svn.wordpress.org/trunk@35292 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 15:59:01 +00:00
Boone Gorges
2713768bb0 Correct inline comment in wp_list_categories().
The fallback link for the 'All' option is 'page_for_posts', not
'page_on_front'. Introduced in [32292].

Props sudar, SergeyBiryukov.
Fixes #34363.

git-svn-id: https://develop.svn.wordpress.org/trunk@35291 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 12:54:55 +00:00