Commit Graph

35349 Commits

Author SHA1 Message Date
Scott Taylor 1ff3356d22 OEmbed: move `_wp_oembed_get_object()` to `embed.php`, where all of the other embed functions live. `WP_oEmbed` is then in a file by itself. Load `class-oembed.php` in `wp-settings.php` and remove extraneous include calls.
See #37827.


git-svn-id: https://develop.svn.wordpress.org/trunk@38361 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 09:48:32 +00:00
Scott Taylor 05cd65dd82 L10N: improve accuracy of docs.
Props johnbillion.
Fixes #37585.


git-svn-id: https://develop.svn.wordpress.org/trunk@38360 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 09:37:30 +00:00
Scott Taylor 8a667f3036 Formatting: for a performance boost in `remove_accents()`, convert `chr()` calls to string literals.
Props gitlost.
Fixes #37643.


git-svn-id: https://develop.svn.wordpress.org/trunk@38359 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 09:34:44 +00:00
Scott Taylor 62fe5001ba Editor: improve `word-count.js` documentation.
Props jipmoors, andizer.
Fixes #37718.


git-svn-id: https://develop.svn.wordpress.org/trunk@38358 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 09:24:34 +00:00
Scott Taylor 9bb9ea8185 Cron: clarify descriptions for Cron API functions.
Props johnbillion.
Fixes #37769.


git-svn-id: https://develop.svn.wordpress.org/trunk@38357 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-26 09:21:33 +00:00
Scott Taylor b16dcd954d Query: collapse several of the `is_*` methods using `__call()`. Add `@method` annotations.
Fixes #37830.


git-svn-id: https://develop.svn.wordpress.org/trunk@38356 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 19:41:42 +00:00
Scott Taylor a02d79cf73 Site Icon: There is no good reason for `class-wp-site-icon.php` to drop a global instance of itself whenever the file is loaded. The lone use of the `global` instance of `WP_Site_Icon` is in an AJAX action that provides virtually no way to override - the file is loaded immediately before the `global` is used.
Let us remove the `$wp_site_icon` global. I will fall on the sword if this comes back to bite us (waiting with bated breath).

See #37699.


git-svn-id: https://develop.svn.wordpress.org/trunk@38355 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 19:08:38 +00:00
Scott Taylor 9e9cc9d07a Feed: move 'WP_Feed_Cache', 'WP_Feed_Cache_Transient', `WP_SimplePie_File` and `WP_SimplePie_Sanitize_KSES` into their own files via `svn cp`. If we move forard with autoloading, `class-feed.php` is useless. We could even remove it now, and just load these new files in `wp-settings.php`. That can be decided post-mortem. `class-feed.php` is an interesting name: there is no `Feed` or `WP_Feed` class.
See #37827.


git-svn-id: https://develop.svn.wordpress.org/trunk@38354 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 18:18:01 +00:00
Scott Taylor 9c722d92cc Session: move `WP_Session_Tokens` and `WP_User_Meta_Session_Tokens` into their own files via `svn cp`. If we move forard with autoloading, `session.php` is useless. We could even remove it now, and just load these new files in `wp-settings.php`. That can be decided post-mortem.
See #37827.


git-svn-id: https://develop.svn.wordpress.org/trunk@38353 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 17:43:41 +00:00
Scott Taylor b71117fdc7 Diff: move `WP_Text_Diff_Renderer_inline` (behold that lowercase "i") and `WP_Text_Diff_Renderer_Table` into their own files via `svn cp`.
See #37827.


git-svn-id: https://develop.svn.wordpress.org/trunk@38352 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 17:36:22 +00:00
Scott Taylor 3638dd6716 Query: move `WP_Query` into its own file via `svn cp`.
See #37827.


git-svn-id: https://develop.svn.wordpress.org/trunk@38351 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 17:19:47 +00:00
Drew Jaynes 66ac1f40ed Docs: Add a missing parenthesis in an example in the DocBlock for `wp_redirect()`.
Props shayanys.
See #37770.


git-svn-id: https://develop.svn.wordpress.org/trunk@38350 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 07:35:15 +00:00
Andrew Ozz 861bdc722f TinyMCE: fix toolbars alignment in RTL.
Fixes #37760 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@38349 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-25 01:19:24 +00:00
Sergey Biryukov 8d490e9d83 Docs: Improve the docs for `the_title()` and make them more consistent with `the_title_attribute()`.
Props ixkaito, swissspidy.
Fixes #37732.

git-svn-id: https://develop.svn.wordpress.org/trunk@38348 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-24 15:59:00 +00:00
Sergey Biryukov 47e8c055ef Administration: Underline links in the admin footer for better accessibility.
Props Presskopp.
Fixes #37529.

git-svn-id: https://develop.svn.wordpress.org/trunk@38347 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-24 15:42:13 +00:00
Sergey Biryukov 80439d1c48 I18N: Add translator comments for strings in `wp-includes/functions.wp-scripts.php`.
Props ramiy.
Fixes #37803.

git-svn-id: https://develop.svn.wordpress.org/trunk@38345 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 23:52:31 +00:00
Sergey Biryukov 5ae7139efa I18N: Add translator comments for strings in `wp-includes/functions.php`.
Props ramiy.
Fixes #37802.

git-svn-id: https://develop.svn.wordpress.org/trunk@38344 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 23:47:28 +00:00
Sergey Biryukov 407f0aaa34 I18N: Add translator comments for strings in `wp-includes/deprecated.php`.
Props ramiy.
Fixes #37797.

git-svn-id: https://develop.svn.wordpress.org/trunk@38343 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 23:35:15 +00:00
Sergey Biryukov 75c975c5d1 I18N: Add translator comments for strings in `wp-includes/class-walker-comment.php`.
Merge two similar strings.

Props ramiy.
Fixes #37796.

git-svn-id: https://develop.svn.wordpress.org/trunk@38342 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 23:32:15 +00:00
Sergey Biryukov 364754b01b I18N: Add translator comments for strings in `wp-includes/author-template.php`.
Props ramiy.
Fixes #37795.

git-svn-id: https://develop.svn.wordpress.org/trunk@38341 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 23:17:32 +00:00
Sergey Biryukov bcc0fc20b3 I18N: Add translator comments for strings in `wp-includes/admin-bar.php`.
Props ramiy.
Fixes #37794.

git-svn-id: https://develop.svn.wordpress.org/trunk@38340 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 23:04:33 +00:00
Scott Taylor 5e1193272f Taxonomy: in `get_terms()`, do not assume that legacy args are being passed when the only params are top-level `meta_*` values. Add keys in `WP_Term_Query::__construct()`.
Adds unit tests.

Props flixos90, boonebgorges.
Fixes #37568.


git-svn-id: https://develop.svn.wordpress.org/trunk@38337 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 14:44:19 +00:00
Scott Taylor 148b09a79e Query: use correct description in the docblock for `$number` in `WP_Comment_Query`, `WP_Network_Query`, and `WP_Site_Query`.
Props flixos90.
Fixes #37621.


git-svn-id: https://develop.svn.wordpress.org/trunk@38336 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 14:40:09 +00:00
Scott Taylor da8597c76b Cache: in `WP_Object_Cache`, `$cache_misses` is public, but `$cache_hits` is private. They should both be `public`, because they're useful for debugging purposes.
Props danielbachhuber.
Fixes #37726.


git-svn-id: https://develop.svn.wordpress.org/trunk@38335 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 14:37:31 +00:00
Scott Taylor 3aee745492 AJAX: add a new function, `wp_doing_ajax()`, which can replace... (wait for it...) `DOING_AJAX` checks via the constant.
Props Mte90, sebastian.pisula, swissspidy.
Fixes #25669.


git-svn-id: https://develop.svn.wordpress.org/trunk@38334 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 14:32:18 +00:00
Scott Taylor b1de6df8b4 Media: remove `function_exists()` call for `ini_get()` in `_load_image_to_edit_path()`.
Props dd32.
Fixes #37681.


git-svn-id: https://develop.svn.wordpress.org/trunk@38333 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 14:23:41 +00:00
Sergey Biryukov c913fc4c23 WP Mail: If post-by-email functionality is disabled, `wp-mail.php` should return a `403 Forbidden` status code instead if `500 Internal Server Error`.
Props Presskopp, tomdxw.
Fixes #37572.

git-svn-id: https://develop.svn.wordpress.org/trunk@38332 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 14:01:16 +00:00
Boone Gorges 74b912705d Tests: Fix incorrect variable name from [38330].
See #37630.

git-svn-id: https://develop.svn.wordpress.org/trunk@38331 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 13:48:13 +00:00
Boone Gorges b93e0739a9 Tests: Attachment `create()` method should match signature of other `create()` methods.
Legacy argument format continues to be accepted.

Props bcole808.
See #37630.

git-svn-id: https://develop.svn.wordpress.org/trunk@38330 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 13:42:36 +00:00
Sergey Biryukov 934ffcf5b1 I18N: Remove unnecessary context for two strings on "Add New User" screen.
Props ramiy.
Fixes #37784.

git-svn-id: https://develop.svn.wordpress.org/trunk@38329 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 12:53:54 +00:00
Andrew Ozz d96cb127ee TinyMCE: make sure the temporary id is removed when using the default image dialog and inserting an external image.
Props fomenkoandrey for reporting and testing.
Fixes #37467.

git-svn-id: https://develop.svn.wordpress.org/trunk@38328 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 04:42:58 +00:00
Sergey Biryukov 8d48e9a685 I18N: Remove unnecessary context in `wp_post_revision_title_expanded()`.
Props ramiy.
Fixes #37781.

git-svn-id: https://develop.svn.wordpress.org/trunk@38327 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 01:45:04 +00:00
Sergey Biryukov 862b5a554f I18N: Use a consistent context for "Add New" submenu strings in admin bar (Toolbar).
Props ramiy.
Fixes #37780.

git-svn-id: https://develop.svn.wordpress.org/trunk@38326 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 01:41:16 +00:00
Sergey Biryukov afd7e3b16d I18N: Allow for WordPress Plugin/Theme Directory URLs to be localized.
Props ramiy.
Fixes #37501.

git-svn-id: https://develop.svn.wordpress.org/trunk@38325 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 01:18:53 +00:00
Sergey Biryukov 3a35ca8bd6 I18N: Replace unnecessary context with translator comments in `wp_post_revision_title()` and `wp_post_revision_title_expanded()`.
Props ramiy.
Fixes #37778.

git-svn-id: https://develop.svn.wordpress.org/trunk@38324 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 00:34:31 +00:00
Sergey Biryukov e408cbe86d I18N: Replace unnecessary context with a translator comment for `%s Sites` string in `network_step1()`.
Props ramiy.
Fixes #37777.

git-svn-id: https://develop.svn.wordpress.org/trunk@38323 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 00:16:43 +00:00
Sergey Biryukov aca32f8771 I18N: Replace unnecessary context with a translator comment for `%s KB` string on Network Settings screen.
Props ramiy.
Fixes #37496.

git-svn-id: https://develop.svn.wordpress.org/trunk@38322 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 00:10:49 +00:00
Sergey Biryukov 03e402b2ec Embeds: In `get_oembed_endpoint_url()`, avoid inadvertent stomping of the `$format` parameter passed to `oembed_endpoint_url` filter.
Props danhgilmore.
Fixes #37751.

git-svn-id: https://develop.svn.wordpress.org/trunk@38321 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-23 00:04:46 +00:00
Sergey Biryukov f2a91f6157 I18N: Add translator comments for `Edit Site: %s` string in network admin.
Props ramiy.
Fixes #37776.

git-svn-id: https://develop.svn.wordpress.org/trunk@38320 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 23:52:56 +00:00
Scott Taylor 653fe9aaa1 Users: after [38317], use a `@property` annotation, instead of a `public` field.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38319 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 22:14:03 +00:00
Scott Taylor e8ab847c74 Widgets: `$option_name` and `$alt_option_name` have been used as members ever since `WP_Widget` became an object in 2.8, but never declared.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38318 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 21:50:44 +00:00
Scott Taylor 459f3aa9a3 Users: `$user_level` has been publicly-accessed on instances of `WP_User` since version 2.0, but is has never been declared.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38317 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 21:40:35 +00:00
Scott Taylor 03aad23a01 Locale: declare the `$month_genitive` field on `WP_Locale`.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38316 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 21:32:09 +00:00
Scott Taylor 6f19452077 HTTP: in `WP_HTTP_Response`, the `@param` declarations for `$status` and `$headers` were swapped. Let us correct this.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38315 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 21:27:02 +00:00
Scott Taylor 670878cbaa Database: `WP_Network`, `WP_Network_Query`, and `WP_Site_Query` call `wpdb::_escape()`, thus requiring it to be `public`. It previously had no access modifier. `_` at the beginning of a method, believe it or not, does not enforce visibility constraints.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38314 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 21:09:03 +00:00
Scott Taylor 6df9616ff6 Comments: in `wp_handle_comment_submission()`, `$_wp_unfiltered_html_comment` is passed as part of `$comment_data`, but is not used locally.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38313 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 21:03:05 +00:00
Scott Taylor d46de8b22b Taxonomy: remove unnecessary `break` in `WP_Term::__get()`.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38312 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 20:59:35 +00:00
Scott Taylor 46d7304d4a Nav Menus: remove unnecessary variable assignment in `wp_nav_menu_item_post_type_meta_box()`.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38311 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 20:57:41 +00:00
Scott Taylor 368e28243f REST API: remove unnecessary variable assignments in `rest_handle_options_request()`.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38310 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 20:55:29 +00:00
Scott Taylor 0dcc38a1ef Media: remove unnecessary variable assignment in `gallery_shortcode()`.
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38309 602fd350-edb4-49c9-b593-d223f7449a82
2016-08-22 20:52:44 +00:00