Commit Graph

25886 Commits

Author SHA1 Message Date
Andrew Ozz 9c3da74353 Heartbeat: no longer "experimental", see #25272
git-svn-id: https://develop.svn.wordpress.org/trunk@27981 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:32:52 +00:00
Scott Taylor f48e74e789 Only set the `poster` attribute automatically for videos when the image does not match the default mime-type icon. `wp_prepare_attachment_for_js()` is used in multiple contexts. This context requires disambiguation.
See [27659].



git-svn-id: https://develop.svn.wordpress.org/trunk@27980 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:19:51 +00:00
Scott Taylor d11d19a2b7 [27640] supported a caption for audio and video shortcodes as part of a UX iteration for the related MCE views. These captions have since be excluded, so the extra code should be removed (it was there for this sole reason).
See #27320.



git-svn-id: https://develop.svn.wordpress.org/trunk@27979 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:12:06 +00:00
Andrew Ozz 53ce07bf36 TinyMCE:
- Tighten up button styles, add :hover for .mce-active buttons.
- Pad only the first toolbar row and remove the padding in both toolbars if the editor doesn't have a DFW mode.
Part props avryl, see #27279

git-svn-id: https://develop.svn.wordpress.org/trunk@27978 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 01:09:38 +00:00
Andrew Nacin 3fbe1ba7b7 Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation.
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27975 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 22:07:02 +00:00
Scott Taylor 5d3e7be690 When dynamically instantiating `MediaElementPlayer` instances in JS, `preload="metadata"` is extremely wonky. `preload="none"` lets the file play right away.
This has already been addressed for audio|video shortcodes, but also needs to be the case for playlists. When loading a playlist from a DOM cache or via AJAX, and when the sources match those already pre-loaded, the browser will sometimes donkey-punch the HTTP request for the first cached track selected.

Set `preload="none"` for the empty `<audio|video>` tag for playlists.

See commits related to #26779.



git-svn-id: https://develop.svn.wordpress.org/trunk@27974 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 21:33:00 +00:00
Dominik Schilling (ocean90) e4d4e0020b Widget Customizer: Remove leading/trailing whitespace to prevent jQuery migrate warning.
props gcorne.
fixes #27689.

git-svn-id: https://develop.svn.wordpress.org/trunk@27973 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 20:39:33 +00:00
Dominik Schilling (ocean90) 020e3ef811 Update TinyMCE help for pasting content.
props chiragswadia.
see #27100.

git-svn-id: https://develop.svn.wordpress.org/trunk@27972 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:45:07 +00:00
Dominik Schilling (ocean90) 0e8bd0b455 Header images: Revert unnecessary `tabindex="0"` from [27947].
see #21785.

git-svn-id: https://develop.svn.wordpress.org/trunk@27971 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:35:24 +00:00
Dominik Schilling (ocean90) 2f0a34dbb8 Header images: Improve accessibility of Randomize buttons.
props ehg.
see #27598, #21785.

git-svn-id: https://develop.svn.wordpress.org/trunk@27970 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:27:40 +00:00
Dominik Schilling (ocean90) ab8f7f7afd Widgets: Trigger jQuery events for widget updates.
* `widget-added` when a widget is added to a sidebar
* `widget-updated` when a widget is updated
A jQuery object of the widget is passed along to the event handler. Same events are used in the Widget Customizer, see [27909].

fixes #19675.

git-svn-id: https://develop.svn.wordpress.org/trunk@27969 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:05:03 +00:00
Dominik Schilling (ocean90) 8708a44d4a Widget Customizer: Minor code cleanup.
* Remove type hinting from `WP_Customize_Widgets`
* Rename `inject_preview_css` to `print_preview_css`
* Remove stray `@todo`

fixes #27534.

git-svn-id: https://develop.svn.wordpress.org/trunk@27968 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 18:53:31 +00:00
Dominik Schilling (ocean90) bccc4ea750 Fix whitespace around `$GLOBALS['_wp_deprecated_widgets_callbacks'] `.
git-svn-id: https://develop.svn.wordpress.org/trunk@27967 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 18:49:48 +00:00
Dominik Schilling (ocean90) a2c020e068 WP_Widget: Introduce `is_preview()` method.
With the Widget Customizer it's possible that previewed widgets can leak data outside of Customizer, when the widget uses the cache API.
The Customizer calls the regular update callback which should already refresh the cache. Since cache additions aren't blocked yet the cache can be filled with preview data.
To prevent this issue `WP_Widget::is_preview()` will return true, when `$wp_customize->is_preview()` returns true. If `is_preview()` is true, cache additions are suspended via `wp_suspend_cache_addition()`. Make sure your object cache drop-in has implemented `wp_suspend_cache_addition()`.

`is_preview()` can/should also be used inside `WP_Widget::widget()`, see WP_Widget_Recent_Posts or WP_Widget_Recent_Comments for examples.

For more info see IRC logs: http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-04-02&sort=asc#m824279

props westonruter.
fixes #27538.

git-svn-id: https://develop.svn.wordpress.org/trunk@27966 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 18:47:46 +00:00
Drew Jaynes (DrewAPicture) 789305948e Inline documentation for remaining hooks in wp-admin/includes/upgrade.php.
Props jackreichert, vancoder.
Fixes #27646.


git-svn-id: https://develop.svn.wordpress.org/trunk@27965 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 22:29:41 +00:00
Andrew Nacin 14d96748c7 Better checks for contributors when saving posts.
props dd32, kovshenin, plocha.
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27964 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 21:18:44 +00:00
Andrew Nacin 12f66b9859 Theme Installer: Separate API from an event handler to avoid issues where a false return value stops the event.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27963 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:45:37 +00:00
Andrew Nacin e40de50197 Theme Installer: Don't encode description entities/HTML.
props johnbillion.
fixes #27641.


git-svn-id: https://develop.svn.wordpress.org/trunk@27962 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:29:44 +00:00
Andrew Nacin ba9e3d2bc3 Theme Installer: Use JSONP for api.wordpress.org requests.
fixes #27639.


git-svn-id: https://develop.svn.wordpress.org/trunk@27961 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:27:56 +00:00
Scott Taylor 1ff1343a82 Revert the changes made to `data.title` in playlist Underscore templates in [27869]. `{{ data.title }}` causes the title to be double-encoded on the front end.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27960 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:05:04 +00:00
Andrew Nacin 5863d7874d Theme Installer: Better responsive styles for feature filters.
props matveb.
fixes #27661.


git-svn-id: https://develop.svn.wordpress.org/trunk@27959 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:03:41 +00:00
Andrew Nacin c4d09e4736 Theme Installer: Fix displaying of errors.
props SergeyBiryukov.
fixes #27640.


git-svn-id: https://develop.svn.wordpress.org/trunk@27958 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 19:25:20 +00:00
Andrew Nacin 631b55ac0b Don't pass variables by reference.
props markjaquith.
fixes #27656.


git-svn-id: https://develop.svn.wordpress.org/trunk@27957 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 18:16:45 +00:00
Andrew Nacin 84c4332b3e RTL: Fix taxonomy quick edit list alignment.
props SergeyBiryukov.
fixes #27629.


git-svn-id: https://develop.svn.wordpress.org/trunk@27956 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 18:13:11 +00:00
Dominik Schilling (ocean90) 8c28ef2b7c Fix typo in hook description for `async_upload_{$type}`.
git-svn-id: https://develop.svn.wordpress.org/trunk@27955 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 14:11:38 +00:00
Dominik Schilling (ocean90) fc34a6e63e Customizer: Add `height: auto;` for `select[multiple]`.
fixes #27662.

git-svn-id: https://develop.svn.wordpress.org/trunk@27954 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 13:11:39 +00:00
Sergey Biryukov 4a197c45a2 Avoid an undefined index notice in wp_http_validate_url().
props jesin.
fixes #27684.

git-svn-id: https://develop.svn.wordpress.org/trunk@27953 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 12:44:19 +00:00
Drew Jaynes (DrewAPicture) 6c7aabda19 Fix a typo in the PHPDoc description for the `WP_Http_Curl->max_body_length` property.
Props eightface.
Fixes #27681.


git-svn-id: https://develop.svn.wordpress.org/trunk@27952 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 05:47:54 +00:00
Andrew Ozz 30cdc10180 When autosaving a new post for the first time after a title was typed, cancel the autosave if the user is submitting the form. (Includes a precommit fix for customize-controls.css.) Props Nessworthy, davidmarichal, fixes #27657
git-svn-id: https://develop.svn.wordpress.org/trunk@27951 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 01:28:35 +00:00
Andrew Ozz 36f0a60829 Throw a user notice when the editor ID used for TinyMCE contains brackets, props nacin, fixes #27601
git-svn-id: https://develop.svn.wordpress.org/trunk@27950 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 01:10:19 +00:00
Andrew Ozz 548772fcc1 TinyMCE: update the default style for html5-captions, props obenland fixes #26642
git-svn-id: https://develop.svn.wordpress.org/trunk@27949 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 23:11:21 +00:00
Andrew Ozz 63bf25ec1f Edit image modal: check if full size exists before trying to use it for setting aspect ratio, props gcorne, see #27366
git-svn-id: https://develop.svn.wordpress.org/trunk@27948 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 18:00:04 +00:00
Andrew Nacin 6ec7a5a52b Header images: Accessibility and style improvements. Headers no longer jump around when chosen.
props mcsf, ehg.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27947 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 15:48:34 +00:00
Andrew Nacin 96e15acb2e Header images: Handle cropping failures.
props ehg.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27946 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 15:47:43 +00:00
Andrew Nacin 996a502103 Add missing space between strings.
props rachelbaker.
fixes #27597.


git-svn-id: https://develop.svn.wordpress.org/trunk@27945 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 13:16:15 +00:00
Andrew Ozz 48269a7c29 TinyMCE: add image backgrounds for more and nextpage tags (also jshint fix for theme.js). Fixes #27106
git-svn-id: https://develop.svn.wordpress.org/trunk@27944 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 05:22:47 +00:00
Drew Jaynes (DrewAPicture) e9f0de0951 Remove a blank line and @global reference in the PHPDoc for `comment_author_email_link()`.
Props norcross, ocean90.
Fixes #27655.


git-svn-id: https://develop.svn.wordpress.org/trunk@27943 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 04:35:20 +00:00
Andrew Ozz ee33326f32 Edit image modal:
- Make the calculation of the aspect ratio more robust.
- Better getting of the image height and width.
Props gcorne, see #27366

git-svn-id: https://develop.svn.wordpress.org/trunk@27942 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 01:48:24 +00:00
Andrew Ozz ec18e88dee TinyMCE: better calculation for editor height when switching Text to Visual and back. Add stopping of editor resizing when the mouse leaves the browser window. See #27279
git-svn-id: https://develop.svn.wordpress.org/trunk@27941 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 01:30:11 +00:00
Andrew Nacin e8ad1fbf6c Theme Installer: Center spinner, remove plural string.
fixes #27581. see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27940 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:45:13 +00:00
Sergey Biryukov 96563b4143 Clarify tooltips on Edit Image screen.
props siobhan.
fixes #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27939 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:02:22 +00:00
Sergey Biryukov a97e9018c4 Fix typo in verify_file_md5() description. see [25541].
props siobhan.
see #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27938 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:02:12 +00:00
Andrew Nacin b29ccb5656 Theme Installer: Fix sorting, counts, keyboard navigation; add prev/next to previews.
props matveb.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27937 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 23:52:45 +00:00
Andrew Nacin e73e290712 Themes: Hide 'Add New' with no JS. see #27055.
git-svn-id: https://develop.svn.wordpress.org/trunk@27936 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 23:05:01 +00:00
Andrew Nacin ccb4f3714a Database: Fall back from ext/mysqli to ext/mysql if the connection fails.
This allows us to avoid breaking a site that works under ext/mysql but is misconfigured for ext/mysqli.

props pento.
see #21663.


git-svn-id: https://develop.svn.wordpress.org/trunk@27935 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 21:57:22 +00:00
Andrew Ozz 641f9f9a93 TinyMCE: improve setting disabled/enabled/activated states on the Unlink button, fixes #27309
git-svn-id: https://develop.svn.wordpress.org/trunk@27934 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 20:04:44 +00:00
Dominik Schilling (ocean90) de2c9e23cf Plupload wrapper: Call init callback on PostInit event.
Fixes the background image uploader in Customizer, which was broken after [27316].

fixes #27620.

git-svn-id: https://develop.svn.wordpress.org/trunk@27933 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 19:43:53 +00:00
Dominik Schilling (ocean90) d817c574a3 Fix styling for plugin update details Thickbox.
see #26952.

git-svn-id: https://develop.svn.wordpress.org/trunk@27932 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 14:07:42 +00:00
Sergey Biryukov ed139644be Use multiplication sign instead of a colon for selection size when editing an image.
props siobhan.
fixes #27652.

git-svn-id: https://develop.svn.wordpress.org/trunk@27931 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 09:45:44 +00:00
Dion Hulse ce76432676 Background Updates: Fix a PHP Warning caused by a Upgrader instance being passed into the Theme & Plugin $extra_stats parameter. See #27633
git-svn-id: https://develop.svn.wordpress.org/trunk@27928 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 05:32:02 +00:00