Commit Graph

29691 Commits

Author SHA1 Message Date
Boone Gorges 93a4bf15e4 Attachment URLs should only be forced to SSL on the front end.
Detecting SSL status on the Dashboard introduces problems when writing content
that is saved to the database and then displayed on the front end, where SSL
may be optional (or impossible, due to self-signed certificates). The new
approach parallels the logic in `get_home_url()` for forcing HTTPS.

See [31614] #15928 for background.

Fixes #32112 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32342 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 13:09:14 +00:00
Drew Jaynes eea4111667 Add a missing DocBlock for `wp_caption_input_textarea()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32341 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:12:12 +00:00
Drew Jaynes b7bce33748 Add a missing `@return` tag to the DocBlock for `uninstall_plugin().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32340 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:07:47 +00:00
Drew Jaynes 5a45289302 Add a missing `@return` tag to the DocBlock for `site_admin_notice()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32339 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:05:48 +00:00
Drew Jaynes 511ce10e53 Clarify accepted types for the `$args` and `$context` parameters in `WP_Filesystem()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32338 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:03:08 +00:00
Andrew Ozz 49626f348a Emoji: rename the exclude class to wp-exclude-emoji.
Props Clorith. See #32197.

git-svn-id: https://develop.svn.wordpress.org/trunk@32337 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 00:04:15 +00:00
Andrew Ozz 992cc2e796 Emoji: add an exclude class to wp-emoji checked when monitoring for changes with mutationObserver. Use it for the hidden div used for resizing the Text editor.
See #32197.

git-svn-id: https://develop.svn.wordpress.org/trunk@32336 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 20:17:38 +00:00
Andrew Ozz 6368ee0c6a Emoji: before parsing added nodes test if the text in them contains emoji chars. That speeds up the processing quite a bit.
See #32125.

git-svn-id: https://develop.svn.wordpress.org/trunk@32335 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 19:07:31 +00:00
Andrew Ozz 9c3c452fa9 Emoji:
- Fix loading errors in IE9 and IE10.
- Add fallbacks for the loading events.
Fixes #32109 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32334 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 18:44:37 +00:00
Sergey Biryukov 2848b8a911 Replace `echo __()` with `_e()`.
props marsjaninzmarsa.
fixes #32239.

git-svn-id: https://develop.svn.wordpress.org/trunk@32333 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 16:17:06 +00:00
Sergey Biryukov 72c437c2a8 Merge two strings from theme details dialog.
props McGuive7.
fixes #32047.

git-svn-id: https://develop.svn.wordpress.org/trunk@32332 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-02 09:10:59 +00:00
Boone Gorges e5e467a41b Allow metadata to be deleted when meta_value matches 0 or '0'.
In `delete_metadata()`, be stricter about when to ignore a falsey value of
`$meta_value`.

For backward compatibility, an empty string for `$meta_value` is equivalent to
`null` or `false`.

Props sc0ttkclark.
Fixes #32224.

git-svn-id: https://develop.svn.wordpress.org/trunk@32331 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-01 16:37:35 +00:00
Scott Taylor 625e7135f3 After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.

See #31139.


git-svn-id: https://develop.svn.wordpress.org/trunk@32330 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 21:39:52 +00:00
Sergey Biryukov 345d34cad9 Bulk Edit: Properly associate the Format select with its label.
props afercia.
fixes #32210.

git-svn-id: https://develop.svn.wordpress.org/trunk@32329 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 16:03:06 +00:00
Sergey Biryukov e4be853426 Use correct closing tag.
props eligijus, TobiasBg.
fixes #32205.

git-svn-id: https://develop.svn.wordpress.org/trunk@32328 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 14:29:24 +00:00
Boone Gorges 53d42e6a9c Remove duplicate semicolon introduced in [32326].
git-svn-id: https://develop.svn.wordpress.org/trunk@32327 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 12:57:35 +00:00
Boone Gorges 1700d2b265 Improve performance of loop detection in `_get_term_children()`.
Using an array keyed by term_id allows us to use `isset()` rather than the
slower `in_array()`. In addition, it lets us avoid the use of `wp_list_pluck()`
on large arrays, and helps us to avoid arrays that are unnecessarily large due
to duplicate entries.

Fixes #32144 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32326 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 12:55:29 +00:00
Sergey Biryukov 51b69b1f7f Fix typo in a comment in `wp_guess_url()`.
props ixkaito.
fixes #32179.

git-svn-id: https://develop.svn.wordpress.org/trunk@32325 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 07:18:35 +00:00
Andrew Ozz f31aeb97f1 Emoji: fix loop when replacement images fail to load.
Props iseulde. Fixes #32128 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32323 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 03:19:01 +00:00
Dion Hulse 342989657f When creating a temporary file treat the `/` directory properly, to prevent it ending up in an endless self-calling loop.
Props hnle, taka2. Fixes #32135. See #31811


git-svn-id: https://develop.svn.wordpress.org/trunk@32322 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 03:16:06 +00:00
Sergey Biryukov af0315de16 Bundled themes: use SSL WordPress.org URL in `rtl.css`.
see #32083.

git-svn-id: https://develop.svn.wordpress.org/trunk@32315 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 18:11:01 +00:00
Lance Willett 0598065cdd Bundled themes: use SSL WordPress.org URLs.
Props SergeyBiryukov, fixes #32083.

git-svn-id: https://develop.svn.wordpress.org/trunk@32314 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 17:35:06 +00:00
Gary Pendergast 0b868edb8e When deleting suspicious comments, do so permanently.
git-svn-id: https://develop.svn.wordpress.org/trunk@32310 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:10:50 +00:00
Gary Pendergast ae1f6413c9 [32308] was for 4.3, not 4.2.1.
git-svn-id: https://develop.svn.wordpress.org/trunk@32309 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:07:20 +00:00
Gary Pendergast 0224286861 When upgrading to 4.2.1, delete suspicious comments.
git-svn-id: https://develop.svn.wordpress.org/trunk@32308 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:03:48 +00:00
Gary Pendergast 0152b8f49b In [32299], we should be using `mb_strlen()` for our string size checks.
git-svn-id: https://develop.svn.wordpress.org/trunk@32306 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 14:41:48 +00:00
Gary Pendergast 45b0abbef1 WPDB: Sanity check that any strings being stored in the DB are not too long to store correctly.
git-svn-id: https://develop.svn.wordpress.org/trunk@32299 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 14:02:45 +00:00
Andrew Nacin ca8d6fb60f Escape the $s global.
fixes #32142.


git-svn-id: https://develop.svn.wordpress.org/trunk@32298 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 05:09:24 +00:00
Sergey Biryukov fdd254b5d8 Add missing word to `wp_insert_term()` error strings.
props dipesh.kakadiya.
fixes #32031.

git-svn-id: https://develop.svn.wordpress.org/trunk@32297 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-26 11:49:36 +00:00
Sergey Biryukov 04ef03636e Check if `SCRIPT_DEBUG` is defined before using it in `print_emoji_detection_script()`.
props Craig Ralston.
fixes #32118 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32296 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-26 10:35:53 +00:00
Andrew Nacin 29718f1c28 Fix keyboard shortcut for save from the visual editor.
props iseulde.
see #32122, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@32295 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-26 04:50:41 +00:00
Boone Gorges c3ea088948 When priming the cache for taxonomy term nav items, don't fetch term descendants.
Descending the term tree causes unnecessary database queries when priming the
cache for a term with many descendants.

Fixes #31724.

git-svn-id: https://develop.svn.wordpress.org/trunk@32294 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-24 18:57:07 +00:00
Boone Gorges 7add279793 Allow rewrite endpoints to be registered without also registering query vars.
Passing `false` to `add_rewrite_endpoint()` will now allow you to take
advantage of the rewrite API without thereby modifying the way that WP sets up
the main query from the request URI.

This new functionality allows developers to work around certain edge-case bugs,
such as when a proper endpoint request (such as `/test/1/`) would short-
circuit `is_home()` calculation when a static front page is set.

Props mordauk, boonebgorges.
Fixes #25143.

git-svn-id: https://develop.svn.wordpress.org/trunk@32293 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-24 16:37:12 +00:00
Boone Gorges 000f4f98b4 In `wp_list_categories()`, 'All' link should point to post type archive if taxonomy is not registered for 'post' or 'page'.
Instead, we point to the post type archive of the first registered
object_type that supports archives.

Props stevegrunwell, hrishiv90, boonebgorges.
Fixes #21881.

git-svn-id: https://develop.svn.wordpress.org/trunk@32292 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-24 14:56:37 +00:00
Helen Hou-Sandi f8140ca961 Trunk is now 4.3-alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@32280 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-23 17:59:53 +00:00
Helen Hou-Sandi ffe23d2f93 About page: Finalize media for 4.2.
props ocean90, Nao.
fixes #31929.


git-svn-id: https://develop.svn.wordpress.org/trunk@32277 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-23 15:42:24 +00:00
Dominik Schilling (ocean90) 1ebc8a2867 Bundled Themes: Bump version numbers and update POT files.
fixes #32032.

git-svn-id: https://develop.svn.wordpress.org/trunk@32276 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-23 15:15:37 +00:00
Drew Jaynes 387b6a9087 Post 4.2-RC4 bump
git-svn-id: https://develop.svn.wordpress.org/trunk@32271 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 20:29:15 +00:00
Drew Jaynes 66b48f847a WordPress 4.2-RC4
git-svn-id: https://develop.svn.wordpress.org/trunk@32270 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 20:21:00 +00:00
Helen Hou-Sandi 09f830dca5 Customizer theme details modal: Repair the layout for IE8.
props obenland.
fixes #32066.


git-svn-id: https://develop.svn.wordpress.org/trunk@32269 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 18:56:01 +00:00
Helen Hou-Sandi eaba93ed33 Admin menu: prevent (most) lock outs caused by plugins or IE7.
fixes #30900.


git-svn-id: https://develop.svn.wordpress.org/trunk@32268 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 18:37:13 +00:00
Dominik Schilling (ocean90) 5e371ea458 Don't try to focus disabled input fields in the request filesystem credentials form.
fixes #32064.

git-svn-id: https://develop.svn.wordpress.org/trunk@32267 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:56:36 +00:00
Dominik Schilling (ocean90) 2abf4c39ef Don't focus input fields outside of the request filesystem credentials form.
props valendesigns.
fixes #32055.

git-svn-id: https://develop.svn.wordpress.org/trunk@32266 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:23:57 +00:00
Dominik Schilling (ocean90) f029572866 Theme Switcher: Provide an easier way to reset back to the current active theme.
* Add control for the active theme when doing a theme preview
* Highlight an active theme and move it to the top

props valendesigns, ocean90.
fixes #32002.

git-svn-id: https://develop.svn.wordpress.org/trunk@32265 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:15:01 +00:00
Dominik Schilling (ocean90) ca11d4c876 Don't return empty themes in `wp_prepare_themes_for_js()`.
see #32002.

git-svn-id: https://develop.svn.wordpress.org/trunk@32264 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:10:40 +00:00
Gary Pendergast cc8a9824c5 WPDB: When sanity checking a string by sending it to MySQL for conversion checks, the incorrect data structure was being returned from `wpdb::strip_invalid_text()`, causing all write queries to fail for some character sets when the query contained non-ASCII characters.
See #32051.



git-svn-id: https://develop.svn.wordpress.org/trunk@32261 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 15:01:25 +00:00
Sergey Biryukov 4e067b0354 About page design for 4.2.
props melchoyce, ryelle.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32260 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 06:03:03 +00:00
Helen Hou-Sandi 3fb766782d Don't add a class for comment authors who are members of the current site.
Reverts [32245] and [31518]. We'll keep the whitespace and comment clarification, though.

see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32259 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 23:35:55 +00:00
Andrew Ozz 925682e2d1 Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
Props iseulde. Fixes #31139, fixes #32006.

git-svn-id: https://develop.svn.wordpress.org/trunk@32258 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 22:40:23 +00:00
Andrew Ozz 312edcbc9d TinyMCE wpView: properly deselect views when hiding the editor. Do not remove `selected` on PreProcess.
Fixes #32045.

git-svn-id: https://develop.svn.wordpress.org/trunk@32257 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 21:31:26 +00:00