Commit Graph

28451 Commits

Author SHA1 Message Date
Andrew Ozz
d4946a7904 Editor:
- Add CSS reset for the TinyMCE fullscreen mode when used on the Edit Post screen.
- Fix loading of the old and new DFW buttons, use another arg. passed to WP_Editors.
- Reset editor-expand when exiting TinyMCE fullscreen mode.
Fixes #30453.

git-svn-id: https://develop.svn.wordpress.org/trunk@30573 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 02:49:41 +00:00
Ian Stewart
d7e4bdd88e Twenty Fifteen: docs correction.
Props rachelbaker, DrewAPicture, fixes #30456



git-svn-id: https://develop.svn.wordpress.org/trunk@30572 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 21:10:56 +00:00
Ian Stewart
c55081a2d1 Twenty Fifteen: update the .pot file.
Props iamtakashi, fixes #30433.



git-svn-id: https://develop.svn.wordpress.org/trunk@30571 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 21:07:39 +00:00
Ian Stewart
41f3470242 Twenty Fifteen: make sure the 'says:' in comments is readable by a screen-reader.
Fixes #30479.



git-svn-id: https://develop.svn.wordpress.org/trunk@30570 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 21:04:13 +00:00
Ian Stewart
af691073b9 Twenty Fifteen: docs correction and cleanup.
Props DrewAPicture, see #30149.



git-svn-id: https://develop.svn.wordpress.org/trunk@30569 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 20:56:33 +00:00
Ian Stewart
3c19ea9381 Twenty Fifteen: correct number of menus used in comments
Props jeherve, see #30149



git-svn-id: https://develop.svn.wordpress.org/trunk@30568 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 20:37:42 +00:00
Ian Stewart
78cff98ef9 Twenty Fifteen: remove unneeded custom header admin callbacks.
Props philiparthurmoore, fixes #30432.



git-svn-id: https://develop.svn.wordpress.org/trunk@30567 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 15:11:11 +00:00
Ian Stewart
781309a11c Twenty Fifteen: prevent too-wide tables from popping out of posts.
Props iamtakashi, fixes #30420



git-svn-id: https://develop.svn.wordpress.org/trunk@30566 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 15:03:49 +00:00
Ian Stewart
996b21e660 Twenty Fifteen: pinching to zoom in on landscape on iPads is breaking the layout with the sticky sidebar. Providing a one-column view on those screens looks good and will likely prevent other bugs we don't even know about.
Props iamtakashi, fixes #30366.




git-svn-id: https://develop.svn.wordpress.org/trunk@30565 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 14:57:40 +00:00
Ian Stewart
b5af639a5a Twenty Fifteen: a shorter header on small screens when there is no header text or header image looks more correct.
Props iamtakashi, fixes #30326.




git-svn-id: https://develop.svn.wordpress.org/trunk@30564 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 14:46:13 +00:00
Dominik Schilling (ocean90)
836ef75b8e Update embedded.png after running grunt imagemin.
After [30059] and [30079] we still had four images which could be minified. Three of them are handled by [30562], the last one by this.

fixes #30141.

git-svn-id: https://develop.svn.wordpress.org/trunk@30563 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 14:08:56 +00:00
Andrew Ozz
9185f64f20 TwentyFifteen:
- Fix image caption alignment in the editor.
- Remove unused var from functions.js.
Also includes few images that were shrunk a bit when running grunt precommit.
Fixes #30493.

git-svn-id: https://develop.svn.wordpress.org/trunk@30562 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 06:11:02 +00:00
Gary Pendergast
0cb93dd166 When json_encode() returns a JSON string containing 'null' in PHP 5.4 or earlier, wp_json_encode() will now sanity check the data, as older versions of PHP failed to encode non UTF-8 characters correctly, instead returning 'null'.
Fixes #30471.


git-svn-id: https://develop.svn.wordpress.org/trunk@30561 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 05:00:36 +00:00
Andrew Ozz
a6b7826831 TinyMCE: don't hide the image toolbar when the iframe window fires onresize. There is a bug in several browsers that triggers onresize when a tooltip is shown, only in RTL mode. Also use better variable name. Fixes #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30560 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 04:30:31 +00:00
Jeremy Felt
f1e5edee9a Add basic unit tests for is_plugin_active_for_network()
Props rodrigosprimo
Fixes #30491


git-svn-id: https://develop.svn.wordpress.org/trunk@30559 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 04:02:26 +00:00
Andrew Ozz
c2c0eee75a TinyMCE: use the actual image node when calculating the position of the toolbar. Fixes a bug in old IE. See #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30558 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 01:21:35 +00:00
Boone Gorges
4537217cf1 Add basic unit tests for is_plugin_active() and is_plugin_inactive().
Props voldemortensen.
Fixes #30489.

git-svn-id: https://develop.svn.wordpress.org/trunk@30557 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 01:12:39 +00:00
Dominik Schilling (ocean90)
bc53a39130 Remove incorrect documentation for wp.media().
props ericlewis.
fixes #30090.

git-svn-id: https://develop.svn.wordpress.org/trunk@30556 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 23:11:54 +00:00
Dominik Schilling (ocean90)
3ebd474750 Improve the focus style for review links in the plugin info modal.
props johnbillion.
fixes #30375.

git-svn-id: https://develop.svn.wordpress.org/trunk@30555 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:58:12 +00:00
Dominik Schilling (ocean90)
f38be98c89 Clear update caches when site language is changed.
The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached. 
Introduce `_wp_clear_update_cache()` as a helper function to clean up the update cache.

props SergeyBiryukov, ocean90.
fixes #30369.

git-svn-id: https://develop.svn.wordpress.org/trunk@30554 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:49:13 +00:00
Dominik Schilling (ocean90)
1b920af543 Customizer: Only show the default button in the upload control if there is a default attachment.
props celloexpressions.
see #21483.

git-svn-id: https://develop.svn.wordpress.org/trunk@30553 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:30:25 +00:00
Dominik Schilling (ocean90)
ea4528dc43 Customizer: Don't override Section.isContextuallyActive() in SidebarSection.
This fixes a bug where empty widget areas get deactivated in the Customizer.

fixes #30378.
see #30235.
props westonruter.

git-svn-id: https://develop.svn.wordpress.org/trunk@30552 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:25:30 +00:00
Dominik Schilling (ocean90)
09f6d69f5a Update the Iris color picker to version 1.0.6.
Changes: https://github.com/Automattic/Iris/compare/1.0.4...1.0.6

props mattwiebe.
fixes #30365.

git-svn-id: https://develop.svn.wordpress.org/trunk@30551 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:16:39 +00:00
Dominik Schilling (ocean90)
c6222d9d78 Editor CSS: Add missing semicolons.
props cfoellmann.
fixes #30487.

git-svn-id: https://develop.svn.wordpress.org/trunk@30550 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 21:53:49 +00:00
Boone Gorges
7c8c493a9c Fix the unit tests for Imagick alpha.
These tests were written to use the `assertImageAtAlpha()` helper method, whose
internals were specific to GD. As a result, the tests could not pass. This
changeset introduces GD- and Imagick-specific versions of this method.

Props voldemortensen.
Fixes #24871.

git-svn-id: https://develop.svn.wordpress.org/trunk@30549 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 20:56:36 +00:00
Boone Gorges
951409119e Declare an explicit 'order' in test_get_comments_by_user().
This change fixes broken builds on older versions of MySQL. See #30462.

Assertions regarding indeterminate secondary ORDER BY clauses will go in
separate test methods. See #30478.

git-svn-id: https://develop.svn.wordpress.org/trunk@30548 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 14:55:49 +00:00
Peter Westwood
7e349ec5c4 Fix the passing of commenter cookie data to the comment API so that we don't try and fetch all unapproved comments for users with no-email address when we only have an author.
Fixes #19623


git-svn-id: https://develop.svn.wordpress.org/trunk@30547 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 10:50:38 +00:00
Drew Jaynes (DrewAPicture)
a22e8b5354 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30546 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:30:19 +00:00
Drew Jaynes (DrewAPicture)
76699122d0 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape HTML tags in several argument descriptions for `wp_link_pages()`
* Remove an HTML tag from the summary for `prepend_attachment()`
* Backtick-escape inline code in the description for `get_extended()`
* Backtick-escape inline code in the description for `get_post_type_labels()`
* Various markdown formatting in the description for `add_rewrite_endpoint()`
* Markdown-indent a code snippet in the file header for wp-includes/shortcodes.php
* Markdown-indent code snippets in the description for `add_shortcode()

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30545 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:14:03 +00:00
Drew Jaynes (DrewAPicture)
5f574c7ec8 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `wp_salt()`
* Backtick-escape inline code in the return description for `get_avatar()`
* Various markdown formatting in the description for `add_filter()`
* Markdown-indent a code snippet in the description for `apply_filters()`
* Backtick-escape inline code in the `@see` description for `apply_filters_ref_array()`
* Backtick-escape inline code in the description for `do_action()`
* Backtick-escape variables in the parameter and return descriptions for `do_action_ref_array()`
* Various markdown formatting in the description for `get_plugin_data()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30544 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:04:10 +00:00
Drew Jaynes (DrewAPicture)
6007c0c17d Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30543 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:52:45 +00:00
Drew Jaynes (DrewAPicture)
9a9489db7f Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the file header for wp-admin/install-helper.php
* Add markdown formatting and two inline `@see` tags to the description for `translate()`
* Markdown-indent a code snippet in the description for `_n_noop()`
* Remove HTML tags from the summary for `get_media_embedded_in_content()`
* Remove an HTML tag from the summary for `wpview_media_sandbox_styles()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30542 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:46:04 +00:00
Drew Jaynes (DrewAPicture)
d93bfdce56 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `_deprecated_argument()`
* Markdown-indent a code snippet in the description for `wp_localize_script()`
* Backtick-escape HTML tags in two parameter descriptions for `wp_register()`
* Various DocBlock formatting in the description for `get_bloginfo()`
* Remove HTML tag from the summary for `_wp_render_title_tag()`
* Backtick-escape a HTML tag in the description for `get_archives_link()`
* Markdown-indent a code snippet in the description for `wp_admin_css_color()`
* Markdown-indent a code snippet in the description for the `welcome_panel` hook

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30541 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:38:44 +00:00
Drew Jaynes (DrewAPicture)
ac07c17400 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements in wp-includes/formatting.php:
* Markdown-indent code snippets in the description for `wptexturize()`
* Backtick-escape inline code in a parameter description for `_wptexturize_pushpop_element()`
* Backtick-escape inline code in the description for `shortcode_unautop()`
* Backtick-escape HTML tags in the description for `convert_chars()`
* Markdown-indent a code snippet in the description for `_split_str_by_whitespace()`
* Backtick-escape an `<img>` tag in the description for `translate_smiley()`
* Add markdown formatting to the description for `links_add_target()`
* Backtick-escape HTML tags in the description for `wp_strip_all_tags()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30540 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:29:43 +00:00
Drew Jaynes (DrewAPicture)
2d064e1b86 Ensure the DocBlock directly precedes the hook line for the post_edit_form_tag action in wp-admin/edit-form-advanced.php.
This fixes the parser getting confused about which DocBlock belongs to which hook or function in this file.

See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30539 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:21:56 +00:00
Drew Jaynes (DrewAPicture)
ad50389634 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30538 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:18:56 +00:00
Drew Jaynes (DrewAPicture)
ccc5f88887 Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escapes a `<link>` tag in a parameter description for the `embed_oembed_discover` hook
* Inline code fixes in the summary and return description for `WP_List_Table::get_table_classes()`
* Removes HTML markup from the summary for `WP_List_Table::display_rows_or_placeholder()`
* Backtick-escapes a `<tr>` tag in a parameter description for `WP_Users_List_Table::single_row()`
* Converts non-DocBlocks into multi-line comments in `WP_Dependencies::do_items()`
* Removes HTML markup from the summary for the `comment_form_top` hook.
* Inline code and snippet fixes in the description for `wp_get_schedules()`

Props rarst for the initial patch.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30537 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 04:57:17 +00:00
Drew Jaynes (DrewAPicture)
f843741d33 Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Two arguments in `_walk_bookmarks()`
* A code snippet in the class header for `WP_Roles`
* A code snippet in the class header for `WP_HTTP_Proxy`
* Inline code fixes in the summary and a parameter description for `WP_oEmbed::discover()`
* An argument description in `_WP_Editors::parse_settings()`
* Inline code fixes in the summary and a parameter description the `embed_oembed_discover` hook.

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30536 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 04:41:15 +00:00
Drew Jaynes (DrewAPicture)
f50cafce29 Remove HTML <head> tags from DocBlock summaries in wp-admin/admin-header.php.
Also better-specify the `$hook_suffix` value in the `admin_head-$hook_suffix` hook docs per hook documentation precedent.

Props rarst for the initial patch.
See #30473


git-svn-id: https://develop.svn.wordpress.org/trunk@30535 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 04:26:16 +00:00
Gary Pendergast
fc2bec7a5e json_encode() returns different results for non UTF-8 strings in PHP 5.5+, versus earlier versions of PHP.
This fixes the unit tests that fail in earlier versions, see #30471 for fixing this globally in `wp_json_encode()`.


git-svn-id: https://develop.svn.wordpress.org/trunk@30534 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 01:55:42 +00:00
Gary Pendergast
33dcc948f5 Split the tests for wp_json_encode() into smaller chunks (let's all them "units"). Skip a couple of these tests when running on older versions of PHP that don't support the tested functionality.
See #28786.


git-svn-id: https://develop.svn.wordpress.org/trunk@30533 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-23 23:51:13 +00:00
Drew Jaynes (DrewAPicture)
4f331ec1df Improve return description for get_file_data() documentation.
Also convert an incorrect use of `@see` to `@link`.

Props 5um17 for the initial patch.
Fixes #30466.


git-svn-id: https://develop.svn.wordpress.org/trunk@30532 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-23 17:56:14 +00:00
Andrew Ozz
4140cf6a46 Color Schemes: fix the pointer UP arrow color, fixes #30460.
git-svn-id: https://develop.svn.wordpress.org/trunk@30531 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-23 01:25:14 +00:00
Boone Gorges
b7bcd40bac Remove failing test_network_limit() XML-RPC test.
Test added as a patch on #21292.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30530 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-23 01:22:15 +00:00
Boone Gorges
e61c9fecbd Better rewrite rule flushing in test_permalink_without_title().
This ensures that the test is not polluted by permalink structure changes in
earlier tests.

git-svn-id: https://develop.svn.wordpress.org/trunk@30529 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-23 01:19:04 +00:00
Boone Gorges
b44106c380 Ensure that wpdb_exposed_methods_for_testing is available to all tests.
It should be defined in a common library file so that all tests have access to
it, even when run in isolation.

See [30345], #21212.

git-svn-id: https://develop.svn.wordpress.org/trunk@30528 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-23 00:46:50 +00:00
Boone Gorges
4992fdb95f Ensure sanitize_user() expected test values are lowercase on multisite.
[30524] neglected to account for the fact that multisite forces user logins to
lowercase.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30527 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 21:29:40 +00:00
Boone Gorges
96f9d84dba Stop checking Trac to skip tests against open tickets.
In general, skipped tests should live only in patches, which are committed at
the same time that the corresponding bug is fixed. In cases where it's
necessary to skip a test, use `markTestSkipped()` to declare this fact
explicitly.

We continue to check Trac when using `WP_UnitTestCase` to run non-core tests.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30526 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 21:10:12 +00:00
Boone Gorges
ed426ef8ef Repair the seems_utf8() tests that use Big5 encoding.
* Provide sample data that is actually encoded in Big5.
* Do some actual assertions against that data.

Props akumria.
Fixes #30455.

git-svn-id: https://develop.svn.wordpress.org/trunk@30525 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:56:23 +00:00
Boone Gorges
9b6563f70f Remove failing test related to the 'offset' param of WP_Query.
This test has been added as a patch to #18897.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30524 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:45:58 +00:00