Sergey Biryukov
20905d6f74
Twenty Nineteen: Remove duplicate `height` and `width` attributes from SVG icons.
...
The attributes are added via `TwentyNineteen_SVG_Icons::get_svg()`, there's no need to have them separately in SVG sources.
Props mukesh27, albertomake.
Fixes #47128 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45760 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-07 11:40:28 +00:00
Sergey Biryukov
10e13daccb
Coding Standards: Use strict comparison in `wp-admin/edit.php`.
...
Props davidbaumwald.
Fixes #47201 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45759 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-07 11:40:00 +00:00
Andrew Ozz
93aa98ce42
Remove trailing white space in upgrade.php after [45757].
...
See #46349 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45758 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-07 01:00:06 +00:00
Andrew Ozz
296d8646e7
Add admin email verification screen. Shown every six months after an admin has logged in.
...
Also includes WPCS fixes for wp-login.php.
Props andraganescu, boemedia, lessbloat, azaozz.
See #46349 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45757 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-07 00:03:39 +00:00
Sergey Biryukov
bab0d4ee9b
Administration: Correct "Quick Edit" link height in list tables for consistency with other action links.
...
Props jobthomas, burhandodhy.
Fixes #47815 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45756 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 22:19:10 +00:00
Sergey Biryukov
4bbe1ab5a9
Coding Standards: Fix WPCS violation in [45754].
...
See #46570 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45755 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 18:09:20 +00:00
Sergey Biryukov
fad1821dd7
General: Correctly detect large floats in `is_serialized()`.
...
Props killerbishop, donmhico, hoythan.
Fixes #46570 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45754 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 13:54:43 +00:00
Sergey Biryukov
9bb2eea37a
Feeds: Escape `&` characters in `atom_site_icon()` for XML, for consistency with `rss2_site_icon()`.
...
Props abhijitrakas, shawfactor.
Fixes #47482 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45753 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 13:14:25 +00:00
Sergey Biryukov
7b11f12d96
Coding Standards: Use strict comparison in `wp-admin/options-reading.php`.
...
Props subrataemfluence.
Fixes #46834 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45752 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 12:51:33 +00:00
Sergey Biryukov
c68927e509
Plugins: Use `include_once` for `wp-admin/includes/plugin-install.php` in `WP_Plugin_Install_List_Table::prepare_items()`.
...
This brings consistency with the other instances where the file is included, and allows for reusing its functions in custom code.
Props engelen, desrosj.
Fixes #38874 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45751 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 11:06:27 +00:00
Sergey Biryukov
3f2e265174
Site Health: Use correct variable when checking PHP requirements for a plugin update in `WP_Plugins_List_Table::single_row()`.
...
Props diddledan, sharaz, vaishalipanchal.
Fixes #47835 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45750 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 10:57:04 +00:00
Sergey Biryukov
7110d5507f
Docs: Correct `@type` annotation for `WP_Http_Curl` properties.
...
Props diddledan.
Fixes #46860 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45749 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 08:11:28 +00:00
Sergey Biryukov
89058d3c1c
Docs: Correct `@type` annotation for `WP_HTTP_Cookie::$expires`.
...
Props diddledan.
Fixes #46859 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45748 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 07:55:15 +00:00
Sergey Biryukov
62f6907bfa
Upgrade/Install: Make sure `translate_level_to_role()` always returns a value.
...
Props diddledan.
Fixes #46848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45747 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 07:47:43 +00:00
Sergey Biryukov
89c1d393b2
Posts, Post Types: Update, not delete the `page_for_posts` option in `_reset_front_page_settings_for_post()` when a linked page is deleted or trashed.
...
Props diddledan.
Fixes #46850 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45746 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 07:43:52 +00:00
Gary Pendergast
82d7870fe4
Build Tools: Add a WordPress Development Environment.
...
This commit adds the first iteration of a Docker-based config for setting up a local WordPress development environment.
Props pento, noisysocks, mcsf, pbearne, isabel_brison.
See #47767 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45745 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-05 07:09:14 +00:00
Sergey Biryukov
3705fddde7
Posts, Post Types: Revert unintended change from [45742].
...
See #46503 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45744 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 14:43:21 +00:00
Sergey Biryukov
b536f1de0b
Administration: Display a warning at the top of "All Settings" screen.
...
Props zodiac1978, donmhico, pixolin.
Fixes #47718 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45743 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 13:02:58 +00:00
Sergey Biryukov
7a6f44b979
Docs: Add missing description for `$post` global.
...
Props immeet94.
Fixes #46503 . See #47110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45742 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 12:27:02 +00:00
Sergey Biryukov
b440cd966f
Docs: Remove incorrect `@return` tags in `comment_reply_link()` and `post_reply_link()` DocBlocks.
...
Props atachibana.
Fixes #47826 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45741 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 02:19:19 +00:00
Sergey Biryukov
a7b20de958
Docs: Add missing description for `$current_screen` global.
...
Props mukesh27.
Fixes #45604 . See #47110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45740 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 02:02:10 +00:00
Sergey Biryukov
d19f4d7ff4
Docs: Add missing description for `$wp_query` and `$wp_the_query` globals.
...
Props mukesh27.
See #45604 , #47110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45739 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 01:58:03 +00:00
Sergey Biryukov
5af994b4ed
Docs: Add missing description for `$wp_locale_switcher` global.
...
See #45604 , #47110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45738 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 01:46:34 +00:00
Sergey Biryukov
1e6420ba55
Docs: Add missing description for `$wp_locale` global.
...
Props mukesh27.
See #45604 , #47110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45737 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 01:45:03 +00:00
Sergey Biryukov
914509f940
Docs: Add missing description for `$wp` global.
...
See #45604 , #47110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45736 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 01:27:22 +00:00
Sergey Biryukov
9c1123fb26
Docs: Add missing description for `$wp_rewrite` global.
...
See #45604 , #47110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45735 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 01:18:54 +00:00
SergeyBiryukov
cb1d21191d
Docs: Add missing description for `$wpdb`, `$wp_db_version`, and `$wp_current_db_version` globals.
...
Props mukesh27, utsav72640, immeet94, SergeyBiryukov.
See #45604 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45734 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 01:11:01 +00:00
Sergey Biryukov
cbbaca7ade
Docs: Fix typo in a comment in `WP_Site_Health::get_test_theme_version()`.
...
See #47110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45733 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 00:47:20 +00:00
Sergey Biryukov
17d1f402e2
Site Health: If `WP_DEFAULT_THEME` doesn't exist, use `WP_Theme::get_core_default_theme()` as a fallback.
...
Props ajayghaghretiya1, juliobox, SergeyBiryukov.
Fixes #47299 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45732 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-04 00:01:14 +00:00
Sergey Biryukov
f0f94aef7e
Script Loader: Send a 400 Bad Request status code in `load-scripts.php` and `load-styles.php` if the required `load[]` parameter is not set.
...
Props compilenix.
Fixes #44108 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45731 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 22:16:23 +00:00
Aaron Jorbin
5ed5587545
PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax
...
PHP used to allow both square brackets and curly braces to be used interchangeably for accessing array elements and string offsets. The curly bracket syntax is only allowed in a limited set of cases and can be confusing for people not used to it.
PHP 7.4 will deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0.
Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
See #47751 .
Props jrf.
git-svn-id: https://develop.svn.wordpress.org/trunk@45730 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 20:20:42 +00:00
Andrea Fercia
1f92cbb9c6
Accessibility: Improve the differences between revisions.
...
Color alone is not sufficient to visually communicate differences.
- adds `plus` and `minus` icons to the changed lines
- adds visually hidden text: `Added`, `Deleted`, and `Unchanged` to clarify the differences to assistive technologies users
Props birgire, audrasjb, kjellr, adamsilverstein.
Fixes #43532 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45729 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 15:45:06 +00:00
Andrea Fercia
882d3f5c16
Accessibility: Remove title attributes from the Meta widget.
...
- removes the `Powered by WordPress, state-of-the-art semantic personal publishing platform.` title attribute
- removes the title attribute from the abbreviations: contrary to a common belief, title attributes on abbreviations are only available to a minority of users, see https://developer.paciellogroup.com/blog/2019/03/short-note-the-abbreviation-appreciation-society/
- changes the term `RSS` to `feed`, as `RSS` is a technical term not all users are supposed to be familiar with
- improves the `widget_meta_poweredby` filter documentation
Props nishitlangaliya, chetan200891, audrasjb.
See #46980 , #24766 .
Fixes #46978 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45728 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 13:27:43 +00:00
Andrea Fercia
f82b40a2d2
Menus: Fix the Custom Links text fallback.
...
When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".
The changes in [36379] broke this behavior making the fallback text: ` (Pending)`, with a leading space.
Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.
Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Fixes #38415 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45727 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 12:18:50 +00:00
Andrea Fercia
b1ccaf8903
Accessibility: Improve the way emojis are announced by screen readers.
...
Adds an ARIA `role="img"` to the emojis markup in the front end. While the ARIA role is technically redundant, it helps Safari and VoiceOver to properly announce the emojis as "image". Without the role, they announce a generic "group" role.
Tested with Safari 12.1.1 / VoiceOver 9.
Props pento.
See #37486 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45726 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 11:52:51 +00:00
Andrea Fercia
101fd0647c
Accessibility: Fix the `alt` attribute of the Gallery images within the Classic Editor.
...
Passes the images `alt` attribute value to the Gallery template used within the Classic Editor.
Props yarnboy, wpboss.
Fixes #47687 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45725 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 11:35:19 +00:00
Sergey Biryukov
a634252c15
Posts, Post Types: Check the result of `wp_update_post()` in `wp_trash_post()` and `wp_untrash_post()`.
...
Props abhijitrakas, manzoorwani.jk, siliconforks.
Fixes #47773 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45724 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 03:46:46 +00:00
Sergey Biryukov
3c73c7a56f
Taxonomy: Fix deprecated calls to `get_terms()`.
...
The taxonomy should be passed as part of `$args`, rather than as its own argument.
Props sgastard, mukesh27, SergeyBiryukov.
Fixes #47819 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45723 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-03 03:34:54 +00:00
Andrea Fercia
2adeb5b6d5
Customize: Make the color picker close when clicking on the empty area on the right.
...
Props monikarao.
Fixes #47693 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45722 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-02 17:08:29 +00:00
Sergey Biryukov
73e1cdfa16
Twenty Thirteen: Make `twentythirteen_author_bio_template()` use author templates if exist, fall back to regular template hierarchy otherwise.
...
See #32096 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45721 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-02 03:08:06 +00:00
Sergey Biryukov
ce00f0b0f4
Twenty Fifteen: Make `twentyfifteen_author_bio_template()` use author templates if exist, fall back to regular template hierarchy otherwise.
...
See #32096 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45720 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-02 03:07:58 +00:00
Sergey Biryukov
35e070ca34
Twenty Thirteen: Prevent `author-bio.php` partial template from interfering with rendering an author archive of a user with the `bio` username.
...
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
Fixes #32096 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45719 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-02 02:32:58 +00:00
Sergey Biryukov
f6f0ac59dc
Twenty Fifteen: Prevent `author-bio.php` partial template from interfering with rendering an author archive of a user with the `bio` username.
...
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
See #32096 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45718 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-02 02:32:35 +00:00
Sergey Biryukov
6c78848612
Users: Clean user cache in `check_password_reset_key()` tests.
...
Props davidbaumwald, spacedmonkey.
See #45845 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45717 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 19:53:45 +00:00
Sergey Biryukov
eedb1193fc
Users: Replace raw SQL query in `check_password_reset_key()` with `get_user_by()`.
...
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45716 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 19:18:28 +00:00
Sergey Biryukov
750a5c4749
Users: Use `clean_user_cache()` in `wp_insert_user()`, `wp_update_user()`, `wp_set_password()`, `add_user_to_blog()`.
...
Props spacedmonkey.
Fixes #47021 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45715 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 17:48:31 +00:00
Sergey Biryukov
f912470ac3
Users: Use `wp_update_user()` in `get_password_reset_key()`.
...
Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov.
Fixes #45746 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45714 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 17:24:20 +00:00
Sergey Biryukov
65254fdc3e
Users: Reorganize `user_nicename`, `user_url`, `user_registered` setting in `wp_insert_user()` for consistency with the order or fields in the database.
...
See #45746 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45713 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 17:12:42 +00:00
SergeyBiryukov
1e0309b6e3
Users: Use `get_password_reset_key()` in `wp_new_user_notification()`.
...
Props mrasharirfan, spacedmonkey.
Fixes #45745 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45712 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 15:29:02 +00:00
Sergey Biryukov
69aa6b52ba
Taxonomy: Correct some strict comparisons after [45710].
...
See #47573 .
git-svn-id: https://develop.svn.wordpress.org/trunk@45711 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 15:03:33 +00:00